Re: [libvirt] [PATCH] openvz: Handle domain obj hash map errors

2012-07-09 Thread Osier Yang
On 2012年07月10日 13:21, Guido Günther wrote: This makes the driver fail with a clear error message in case of uuid collisions (for example if somebody copied a container configuration without updating the UUID). OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is only used

[libvirt] [PATCH] openvz: Handle domain obj hash map errors

2012-07-09 Thread Guido Günther
This makes the driver fail with a clear error message in case of uuid collisions (for example if somebody copied a container configuration without updating the UUID). OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is only used by libvirt. --- src/openvz/openvz_conf.c |

Re: [libvirt] [PATCH 1/6] maint: Clean up coding style

2012-07-09 Thread Osier Yang
On 2012年07月10日 01:29, Peter Krempa wrote: Style changes split out from next patch. --- src/conf/domain_conf.c | 23 +-- src/qemu/qemu_command.c | 19 +++ src/qemu/qemu_driver.c |7 +++ 3 files changed, 27 insertions(+), 22 deletions(-) diff

Re: [libvirt] [PATCH] ESX: interface driver routines

2012-07-09 Thread Ata Bohra
Thanks for your inputs Daniel, please see inline. > Date: Mon, 9 Jul 2012 09:21:36 +0100 > From: berra...@redhat.com > To: ata.hus...@hotmail.com > CC: libvirt-l...@redhat.com > Subject: Re: [libvirt] [PATCH] ESX: interface driver routines > > On Sun, Jul 08, 2012 at 08:52:01AM +0530, Ata Bohra

Re: [libvirt] Bug report 826704 - sanlock releases all resources on virsh detach-disk

2012-07-09 Thread Frido Roose
> Hold on, despite the behavior is as expected with the patch, there seems to > be an issue with the return value or check: > Problem found: the res_count variable was not properly initialized causing the improper return values. Included a new patch which I have tested again by hot-attaching/d

Re: [libvirt] [PATCH] build: fix typo that breaks non-Linux builds

2012-07-09 Thread Eric Blake
On 07/09/2012 03:22 PM, Eric Blake wrote: > Commit 9612e4b2 introduced a typo and unused variable that break > non-Linux builds. > > * src/util/virfile.c (virFileLoopDeviceAssociate): Fix syntax error. > --- > > Pushing under the build-breaker rule. Phooey, I ended up accidentally also pushing a

[libvirt] ANNOUNCE: virt-manager 0.9.3

2012-07-09 Thread Cole Robinson
On 07/09/2012 11:08 AM, Cole Robinson wrote: > I'm happy to announce two new releases: > > virt-manager 0.9.2: virt-manager is a desktop application for managing > KVM and Xen virtual machines via libvirt. > The 0.9.2 tar.gz was busted for reasons I haven't quite figured out yet: running ./confi

[libvirt] [PATCH] build: fix typo that breaks non-Linux builds

2012-07-09 Thread Eric Blake
Commit 9612e4b2 introduced a typo and unused variable that break non-Linux builds. * src/util/virfile.c (virFileLoopDeviceAssociate): Fix syntax error. --- Pushing under the build-breaker rule. src/util/virfile.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ut

Re: [libvirt] [Qemu-devel] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-07-09 Thread Anthony Liguori
On 07/09/2012 03:29 PM, Eric Blake wrote: On 07/09/2012 02:00 PM, Anthony Liguori wrote: with the fd:name approach, the sequence is: libvirt calls getfd:name1 over normal monitor qemu responds libvirt calls getfd:name2 over normal monitor qemu responds libvirt calls transaction around blockdev

Re: [libvirt] [Qemu-devel] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-07-09 Thread Eric Blake
On 07/09/2012 02:00 PM, Anthony Liguori wrote: >> with the fd:name approach, the sequence is: >> >> libvirt calls getfd:name1 over normal monitor >> qemu responds >> libvirt calls getfd:name2 over normal monitor >> qemu responds >> libvirt calls transaction around blockdev-snapshot-sync over norma

Re: [libvirt] [Qemu-devel] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-07-09 Thread Anthony Liguori
On 05/17/2012 09:14 AM, Eric Blake wrote: On 05/17/2012 07:42 AM, Stefan Hajnoczi wrote: The -open-hook-fd approach allows QEMU to support file descriptor passing without changing -drive. It also supports snapshot_blkdev and other commands By the way, How will it support them? The problem

[libvirt] [PATCH] systemd: start libvirtd after network

2012-07-09 Thread Jim Fehlig
Domains configured with autostart may fail to start if the host network stack has not been started. E.g. when using bridged networking autostarting a domain can fail with libvirtd[1403]: 2012-06-20 13:23:49.833+: 1485: error : qemuAutostartDomain:177 : Failed to autostart VM 'test': Cannot ge

Re: [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 13:40:34 -0500 Anthony Liguori wrote: > On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: > > On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: > >> libvirt's sVirt security driver provides SELinux MAC isolation for > >> Qemu guest processes and their corresponding

Re: [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Anthony Liguori
On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU proce

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 11:05 AM, Corey Bryant wrote: On 07/09/2012 10:05 AM, Luiz Capitulino wrote: On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/20

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 01:48 PM, Luiz Capitulino wrote: On Mon, 09 Jul 2012 13:35:19 -0400 Corey Bryant wrote: On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email thr

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 12:18 PM, Luiz Capitulino wrote: On Mon, 09 Jul 2012 17:46:00 +0200 Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design

Re: [libvirt] [PATCH] virsh: Clarify documentation for virsh dompmsuspend command

2012-07-09 Thread Peter Krempa
On 07/09/12 19:03, Eric Blake wrote: On 06/21/2012 10:02 AM, Peter Krempa wrote: Clarify the docs to make more clear what this command does and that it requires a guest agent running in the guest. --- tools/virsh.c |7 +-- tools/virsh.pod | 10 +- 2 files changed, 14 inse

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 13:35:19 -0400 Corey Bryant wrote: > > > On 07/09/2012 11:46 AM, Kevin Wolf wrote: > > Am 09.07.2012 17:05, schrieb Corey Bryant: > >> I'm not sure this is an issue with current design. I know things have > >> changed a bit as the email threads evolved, so I'll paste the cu

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am working from. Please let me know if you still see

Re: [libvirt] [PATCH] Add gvir_storage_vol_download() and gvir_storage_vol_upload() to h file

2012-07-09 Thread Zeeshan Ali (Khattak)
On Mon, Jul 9, 2012 at 7:32 AM, Jovanka Gulicoska wrote: > From: Jovanka Gulicoska Oh now i realize why most changes from your last commit were missing: you divided your change into 3 commits. You want to squash them into one as its one logical change. The log of this squashed commit should be

Re: [libvirt] [PATCH] Add gvir_storage_vol_download and gvir_storgae_vol_upload

2012-07-09 Thread Zeeshan Ali (Khattak)
On Mon, Jul 9, 2012 at 7:27 AM, Jovanka Gulicoska wrote: > From: Jovanka Gulicoska 1. I think you forgot to add most of the changes to the commit? 2. No biggie but more for future references, its better to keep the summary/first line as close to ~50 columns as possible so I suggest 's/and/&'. -

[libvirt] [PATCH 5/6] tests: Add support for cathing domain XML parsing errors

2012-07-09 Thread Peter Krempa
This patch enhances qemuxml2argvtest to deal with sematicaly incorrect domain XMLs, that generate errors while parsing. This patch cleans up macros that invoke the tests and changes boolean flags to a bit array flag variable. --- tests/qemuxml2argvtest.c | 497 +++

[libvirt] [PATCH 2/6] domain_conf: Add USB controler model "none"

2012-07-09 Thread Peter Krempa
Libvirt adds a USB controller to the guest even if the user does not specify any in the XML. This is due to back-compat reasons. To allow disabling USB for a guest this patch adds a new USB controller type "none" that disables USB support for the guest. --- docs/schemas/domaincommon.rng |1 +

[libvirt] [PATCH 4/6] qemu: Add support for "none" USB controller

2012-07-09 Thread Peter Krempa
This patch enables the "none" USB controller for qemu guests and adds valdiation on hot-plugged devices if the guest has USB disabled. --- src/qemu/qemu_command.c |7 +++ src/qemu/qemu_driver.c |6 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_co

[libvirt] [PATCH 3/6] domain_conf: Add helpers to verify if device configuration is valid

2012-07-09 Thread Peter Krempa
This patch adds helpers that validate domain's device configuration. This will be needed later on to verify devices being hot-plugged to guests. If the guest has no USB bus, then it's not valid to plug a USB device to that guest. --- src/conf/domain_conf.c | 43

[libvirt] [PATCH 0/6] Add usb controller model="none"

2012-07-09 Thread Peter Krempa
This series adds support for completely disabling USB bus for a host if a user requires this. For this to work a new USB controller model "none" was added that removes the USB bus. The controller is added in patches 2-4. Patch 1 cleans up some nits (and is not necessary) and patches 5 and 6 tweak

[libvirt] [PATCH 1/6] maint: Clean up coding style

2012-07-09 Thread Peter Krempa
Style changes split out from next patch. --- src/conf/domain_conf.c | 23 +-- src/qemu/qemu_command.c | 19 +++ src/qemu/qemu_driver.c |7 +++ 3 files changed, 27 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain

[libvirt] [PATCH 6/6] tests: Add tests to check the new USB "none" controller

2012-07-09 Thread Peter Krempa
This patch adds a set of tests to check parsing of domain XMLs that use the "none" controller and some forbidden situations concerning it. --- .../qemuxml2argvdata/qemuxml2argv-usb-none-hub.xml | 19 ++ .../qemuxml2argv-usb-none-other.xml| 19 ++

Re: [libvirt] [PATCH v2] esx: Extend esxVI_CURL_Download for partial downloads

2012-07-09 Thread Matthias Bolte
2012/7/8 Doug Goldstein : > On Sun, Jul 8, 2012 at 5:44 AM, Matthias Bolte > wrote: >> Also ensure that the virBuffer used to store the downloaded data >> does not overflow. >> --- >> >> v2: >> - Ensure that the used virBuffer dos not overflow. >> >> src/esx/esx_driver.c |2 +- >> src/esx/es

Re: [libvirt] [PATCH] virsh: Clarify documentation for virsh dompmsuspend command

2012-07-09 Thread Eric Blake
On 06/21/2012 10:02 AM, Peter Krempa wrote: > Clarify the docs to make more clear what this command does and that it > requires a guest agent running in the guest. > --- > tools/virsh.c |7 +-- > tools/virsh.pod | 10 +- > 2 files changed, 14 insertions(+), 3 deletions(-) ACK.

Re: [libvirt] [PATCH] Fix shutdown of LXC controller

2012-07-09 Thread Eric Blake
On 07/09/2012 07:56 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Since we are not yet using the virNetServerPtr object for running > the event loop, we can't use virNetServerQuit(). Instead set the > global 'quit' flag in libvirt_lxc > --- > src/lxc/lxc_controller.c |7

[libvirt] FYI: CVE-2012-3386 - vulnerability of 'make distcheck'

2012-07-09 Thread Eric Blake
Libvirt is vulnerable to an automake security hole; anyone that runs 'make distcheck' on any existing libvirt release tarball risks a local exploit that can take advantage of world-writable permissions to inject the operation of attacker-controlled code under the capabilities of the developer testi

Re: [libvirt] [PATCH v8 0/8] Add basic driver for Parallels Virtuozzo Server

2012-07-09 Thread Dmitry Guryanov
On 07/09/2012 07:47 PM, Peter Krempa wrote: On 07/09/12 17:35, Dmitry Guryanov wrote: On 07/04/2012 09:42 PM, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server.

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 17:46:00 +0200 Kevin Wolf wrote: > Am 09.07.2012 17:05, schrieb Corey Bryant: > > I'm not sure this is an issue with current design. I know things have > > changed a bit as the email threads evolved, so I'll paste the current > > design that I am working from. Please let m

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 17:05, schrieb Corey Bryant: > I'm not sure this is an issue with current design. I know things have > changed a bit as the email threads evolved, so I'll paste the current > design that I am working from. Please let me know if you still see any > issues. > > FD passing: > -

Re: [libvirt] [PATCH v8 0/8] Add basic driver for Parallels Virtuozzo Server

2012-07-09 Thread Peter Krempa
On 07/09/12 17:35, Dmitry Guryanov wrote: On 07/04/2012 09:42 PM, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can be found here: http://w

Re: [libvirt] [PATCH v8 0/8] Add basic driver for Parallels Virtuozzo Server

2012-07-09 Thread Dmitry Guryanov
On 07/04/2012 09:42 PM, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can be found here: http://www.parallels.com/products/pcs/ Also beta ve

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 17:23, schrieb Corey Bryant: >>> I think it would cause fds to sit on the monitor >>> until refcount gets to zero (monitor disconnects). Here's an example >>> without the in-use flag: >>> >>> 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with >>> refcount of 1 (increme

[libvirt] [PATCHv3 4/4] test: Add test case for nodeinfotest if host machine doesn't have NUMA

2012-07-09 Thread Peter Krempa
Test filling of nodeinfo structure if /sys/devices/system/node does not exist. (Based on dump from a real machine) --- .../linux-nodeinfo-sysfs-test-5-cpu-x86-output.txt |1 + .../linux-nodeinfo-sysfs-test-5-x86.cpuinfo| 100 .../cpu/cpu0/topology/core_id

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 10:04 AM, Kevin Wolf wrote: Am 06.07.2012 19:40, schrieb Corey Bryant: On 07/06/2012 05:11 AM, Kevin Wolf wrote: Am 05.07.2012 19:00, schrieb Eric Blake: On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount o

Re: [libvirt] [PATCH] virsh: Clarify documentation for virsh dompmsuspend command

2012-07-09 Thread Peter Krempa
On 06/21/12 18:02, Peter Krempa wrote: Clarify the docs to make more clear what this command does and that it requires a guest agent running in the guest. --- tools/virsh.c |7 +-- tools/virsh.pod | 10 +- 2 files changed, 14 insertions(+), 3 deletions(-) Ping? -- libv

Re: [libvirt] [PATCH] virsh: Check for existence of storage before undefining the domain

2012-07-09 Thread Peter Krempa
On 06/22/12 17:21, Peter Krempa wrote: When undefining a domain and removing associated storage using "virsh undefine --storage" the domain was at first undefined and after that the storage removal proces was started. If the user specified an invalid disk to remove, the error could not be correct

[libvirt] [PATCHv3 3/4] test: Add new test case for nodeinfotest

2012-07-09 Thread Peter Krempa
This patch adds test data that describe a machine that has two physical processors that don't share same core id's on their cores. On this data the "virsh nodeinfo" reported that the machine had 10 cores per socket while the processor had only 8. (Before fixing nodeinfo gathering code). --- .../li

Re: [libvirt] [PATCH 0/3] Fix filling of nodeinfo structure and add test cases

2012-07-09 Thread Peter Krempa
This series is now obsoleted by v3. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv3 2/4] nodeinfo: Fix gathering of nodeinfo data structure

2012-07-09 Thread Peter Krempa
This patch changes the way data to fill the nodeinfo structure are gathered. We've gathere the test data by iterating processors an sockets separately from nodes. The reported data was based solely on information about core id. Problems arise when eg cores in mulit-processor machines don't have sam

[libvirt] [PATCHv3 1/4] nodeinfo_test: Enhance test data before changing nodeinfo gathering

2012-07-09 Thread Peter Krempa
This patch adds test data needed by the new way node information will be gathered. This patch adds symlinks to cpu cores to their corresponding node directory. --- .../linux-nodeinfo-sysfs-test-2/node/node0/cpu0|1 + .../linux-nodeinfo-sysfs-test-2/node/node0/cpu1|1 + .../linux-no

[libvirt] [PATCHv3 0/4] Fix filling of nodeinfo structure and add test cases

2012-07-09 Thread Peter Krempa
For explanation why this is needed see 2/4. Patch 1/4 are test data split out from 1/3 of the previous version to ease reviewing of 2/4. Peter Krempa (4): nodeinfo_test: Enhance test data before changing nodeinfo gathering nodeinfo: Fix gathering of nodeinfo data structure test: Add new tes

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 10:05 AM, Luiz Capitulino wrote: On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I thin

[libvirt] ANNOUNCE: virt-manager 0.9.2 and virtinst 0.600.2 released

2012-07-09 Thread Cole Robinson
I'm happy to announce two new releases: virt-manager 0.9.2: virt-manager is a desktop application for managing KVM and Xen virtual machines via libvirt. virtinst 0.600.2: virtinst is a collection of command line tools for provisioning libvirt virtual machines, including virt-install and virt-clon

Re: [libvirt] [Patch v2 3/3] apparmor: QEMU bridge helper policy updates

2012-07-09 Thread Jamie Strandboge
On Mon, 2012-07-09 at 10:22 -0400, rmar...@linux.vnet.ibm.com wrote: > Quoting Jamie Strandboge : > > > On Tue, 2012-07-03 at 12:05 -0400, rmar...@linux.vnet.ibm.com wrote: > >> Quoting Jamie Strandboge : > >> > >> > On Fri, 2012-06-29 at 14:08 -0400, rmar...@linux.vnet.ibm.com wrote: > >> >> From

Re: [libvirt] [PATCH 3/3] storage_backend_fs: Allocate entry for host before accessing it

2012-07-09 Thread Peter Krempa
On 07/09/12 16:08, Osier Yang wrote: On 2012年07月09日 21:21, Peter Krempa wrote: Commit 122fa379de44a2fd0a6d5fbcb634535d647ada17 introduces option to store more than one host entry in a storage pool source definition. That commit causes a regression, where a check is added that only one host entry

Re: [libvirt] [Patch v2 3/3] apparmor: QEMU bridge helper policy updates

2012-07-09 Thread rmarwah
Quoting Jamie Strandboge : On Tue, 2012-07-03 at 12:05 -0400, rmar...@linux.vnet.ibm.com wrote: Quoting Jamie Strandboge : > On Fri, 2012-06-29 at 14:08 -0400, rmar...@linux.vnet.ibm.com wrote: >> From: Richa Marwaha >> >> This patch provides AppArmor policy updates for the QEMU bridge helpe

Re: [libvirt] [PATCH RESEND] add xhci support

2012-07-09 Thread Jiri Denemark
On Mon, Jul 09, 2012 at 14:18:58 +0200, Gerd Hoffmann wrote: > qemu 1.1 features a xhci controller, > this patch adds support for it. > > Signed-off-by: Gerd Hoffmann > --- > docs/formatdomain.html.in |4 ++-- > docs/schemas/domaincommon.rng |1 + > src/conf/domain_conf.c|

Re: [libvirt] [PATCH 2/3] storage_backend_fs: Don't free a part of a structure on error

2012-07-09 Thread Osier Yang
On 2012年07月09日 21:21, Peter Krempa wrote: As the storage pool sources are stored in a list of structs, the pointer returned by virStoragePoolSourceListNewSource() shouldn't be freed as it points in the middle of a memory block. This combined with a regression that takes the error path every time

Re: [libvirt] [PATCH 3/3] storage_backend_fs: Allocate entry for host before accessing it

2012-07-09 Thread Osier Yang
On 2012年07月09日 21:21, Peter Krempa wrote: Commit 122fa379de44a2fd0a6d5fbcb634535d647ada17 introduces option to store more than one host entry in a storage pool source definition. That commit causes a regression, where a check is added that only one host entry should be present (that actualy is no

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 06.07.2012 19:40, schrieb Corey Bryant: > > > On 07/06/2012 05:11 AM, Kevin Wolf wrote: >> Am 05.07.2012 19:00, schrieb Eric Blake: >>> On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount of 0; fd=4's in-use flag is

[libvirt] [PATCH] [libvirt-java] Fix Array IndexOutOfBoundsException for unknown error codes

2012-07-09 Thread Claudio Bley
Hi. I'm using libvirt-java 0.4.7 and libvirt 0.9.8. When libvirt returns an error code which is not mapped in enum ErrorNumber, an IndexOutOfBoundsException is thrown. I realize that the freshly released libvirt-java 0.4.8 supports all error codes up to libvirt 0.9.12. But that doesn't fix the p

[libvirt] [PATCH] [libvirt-java] Fix typo in Domain.java.

2012-07-09 Thread Claudio Bley
Hi. Just a small typo fix: --- diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index fe9f3b0..71c6397 100644 --- a/src/main/java/org/libvirt/Domain.java +++ b/src/main/java/org/libvirt/Domain.java @@ -678,7 +678,7 @@ public class Domain { * @retur

Re: [libvirt] [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant wrote: > > > On 07/04/2012 04:09 AM, Kevin Wolf wrote: > > Am 03.07.2012 20:21, schrieb Corey Bryant: > >> On 07/03/2012 02:00 PM, Eric Blake wrote: > >>> On 07/03/2012 11:46 AM, Corey Bryant wrote: > >>> > > Yes, I think adding a +1 to

[libvirt] [PATCH] [libvirt-java] Fix javadoc warnings.

2012-07-09 Thread Claudio Bley
Hi. Here's a patch fixing these javadoc warnings: --- [javadoc] x:\src\libvirt-java\src\main\java\org\libvirt\Connect.java:387: warning - @return tag has no arguments. [javadoc] x:\src\libvirt-java\src\main\java\org\libvirt\Connect.java:644: warning - @return tag has no arguments. [javado

[libvirt] [PATCH] Fix shutdown of LXC controller

2012-07-09 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Since we are not yet using the virNetServerPtr object for running the event loop, we can't use virNetServerQuit(). Instead set the global 'quit' flag in libvirt_lxc --- src/lxc/lxc_controller.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 1/3] storage_conf: Break long line and polish coding style

2012-07-09 Thread Osier Yang
On 2012年07月09日 21:21, Peter Krempa wrote: --- src/conf/storage_conf.c | 12 ++-- src/storage/storage_backend_fs.c |3 +-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index bf4567f..ab8df9e 100644 --- a

[libvirt] [PATCH 3/3] storage_backend_fs: Allocate entry for host before accessing it

2012-07-09 Thread Peter Krempa
Commit 122fa379de44a2fd0a6d5fbcb634535d647ada17 introduces option to store more than one host entry in a storage pool source definition. That commit causes a regression, where a check is added that only one host entry should be present (that actualy is not present as the source structure was just a

[libvirt] [PATCH 2/3] storage_backend_fs: Don't free a part of a structure on error

2012-07-09 Thread Peter Krempa
As the storage pool sources are stored in a list of structs, the pointer returned by virStoragePoolSourceListNewSource() shouldn't be freed as it points in the middle of a memory block. This combined with a regression that takes the error path every time on caused a double-free abort on the src str

[libvirt] [PATCH 0/3] fix segfault when trying to discover netfs pool sources

2012-07-09 Thread Peter Krempa
https://bugzilla.redhat.com/show_bug.cgi?id=837470 There's a regression in the netfs detection code that causes a double-free error when the detection fails. After fixing the regression another one appeared connected with adding multiple pool source hosts. This series fixes both problems. Peter K

[libvirt] [PATCH 1/3] storage_conf: Break long line and polish coding style

2012-07-09 Thread Peter Krempa
--- src/conf/storage_conf.c | 12 ++-- src/storage/storage_backend_fs.c |3 +-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index bf4567f..ab8df9e 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage

Re: [libvirt] [PATCH RESEND] add xhci support

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 02:18:58PM +0200, Gerd Hoffmann wrote: > qemu 1.1 features a xhci controller, > this patch adds support for it. > > Signed-off-by: Gerd Hoffmann > --- > docs/formatdomain.html.in |4 ++-- > docs/schemas/domaincommon.rng |1 + > src/conf/domain_conf.c|

Re: [libvirt] [PATCHv3 4/5] S390: Domain Schema for s390-virtio machines.

2012-07-09 Thread Viktor Mihajlovski
On 07/03/2012 06:18 PM, Michal Privoznik wrote: On 29.06.2012 17:02, Viktor Mihajlovski wrote: Added s390-virtio machine type to the XML schema for domains in order to not fail the domain schema tests. Signed-off-by: Viktor Mihajlovski --- docs/schemas/domaincommon.rng | 20

[libvirt] [PATCH RESEND] add xhci support

2012-07-09 Thread Gerd Hoffmann
qemu 1.1 features a xhci controller, this patch adds support for it. Signed-off-by: Gerd Hoffmann --- docs/formatdomain.html.in |4 ++-- docs/schemas/domaincommon.rng |1 + src/conf/domain_conf.c|3 ++- src/conf/domain_conf.h|1 + src/qemu/qemu_capabilities.c

Re: [libvirt] Bug report 826704 - sanlock releases all resources on virsh detach-disk

2012-07-09 Thread Frido Roose
> I compiled and tested the patch, and the release of the resource looks fine > now. Only the specific resource/disk is being removed from sanlock now, while > the others stay registered. > Hold on, despite the behavior is as expected with the patch, there seems to be an issue with the return

Re: [libvirt] [PATCH] qemu_agent: support qemu agent general command

2012-07-09 Thread Michal Privoznik
[I am pasting your patch here again so I can point out some nits] On 06.07.2012 03:29, MATSUDA, Daiki wrote: > diff -uNrp libvirt-0.9.13.orig/docs/hvsupport.pl > libvirt-0.9.13/docs/hvsupport.pl > --- libvirt-0.9.13.orig/docs/hvsupport.pl 2011-06-10 15:50:11.0 > +0900 > +++ libvirt-0

Re: [libvirt] Bug report 826704 - sanlock releases all resources on virsh detach-disk

2012-07-09 Thread Frido Roose
On Friday 8 June 2012 at 15:45, Daniel P. Berrange wrote: > > You are a little mixed up with the sanlock API naming here vs the hotplug > hotunplug actions. > > The way sanlock works is that you do > > - Connect to sanlock > - Register all the disks that will be operated on using > virLockManage

Re: [libvirt] numa query

2012-07-09 Thread Osier Yang
On 2012年07月05日 21:50, kapil jain wrote: Hi, I have a host machine which contains 4 numa nodes each with 2 GB memory and 4 cpus. I am using qem-kvm hypervisor. I am trying to create a guest with the similar topology (4 numa nodes, with only 2 vcpus and 1 GB memory) as host. Each vcpu is 1-1 pi

Re: [libvirt] [PATCH] docs: Improve patch submission guidelines

2012-07-09 Thread Michal Privoznik
On 09.07.2012 10:33, Daniel P. Berrange wrote: > On Mon, Jul 09, 2012 at 10:15:28AM +0200, Michal Privoznik wrote: >> We should really advise (new) developers to send rebased patches >> that apply cleanly and use git-send-email rather than all other >> obscure ways. >> --- >> docs/hacking.html.in

Re: [libvirt] [PATCH 15/15] Switch to using virNetServer APIs for monitor socket

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 04:26:55PM +0800, Gao feng wrote: > 于 2012年07月03日 23:58, Daniel P. Berrange 写道: > > From: "Daniel P. Berrange" > > > > In preparation for introducing a full RPC protocol for > > libvirt_lxc, switch over to using the virNetServer APIs > > for the monitor connection > > > >

Re: [libvirt] [PATCH] docs: Improve patch submission guidelines

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 10:15:28AM +0200, Michal Privoznik wrote: > We should really advise (new) developers to send rebased patches > that apply cleanly and use git-send-email rather than all other > obscure ways. > --- > docs/hacking.html.in | 30 +++--- > 1 files chang

Re: [libvirt] [PATCH] ESX: Add routines to interface driver

2012-07-09 Thread Daniel P. Berrange
On Sun, Jul 08, 2012 at 11:36:47AM -0700, Ata Bohra wrote: > From: Ata E Husain > > Includes most of the dirver routines except DefineXML, I am working on it and > will update patch for it soon. > > +/** > + * Generates native XML descritpor for a given interface. > + * For instance: > + *

Re: [libvirt] [PATCH 15/15] Switch to using virNetServer APIs for monitor socket

2012-07-09 Thread Gao feng
于 2012年07月03日 23:58, Daniel P. Berrange 写道: > From: "Daniel P. Berrange" > > In preparation for introducing a full RPC protocol for > libvirt_lxc, switch over to using the virNetServer APIs > for the monitor connection > > Signed-off-by: Daniel P. Berrange Hi Daniel With this patch [15/15] ap

Re: [libvirt] [PATCH] docs: Improve patch submission guidelines

2012-07-09 Thread Michal Privoznik
On 09.07.2012 10:15, Michal Privoznik wrote: > We should really advise (new) developers to send rebased patches > that apply cleanly and use git-send-email rather than all other > obscure ways. > --- > docs/hacking.html.in | 30 +++--- > 1 files changed, 27 insertions(+),

[libvirt] [PATCH] [libvirt-java] Fix typo in Domain.java.

2012-07-09 Thread Claudio Bley
Hi. I sent a few mails on friday, 6th July, via gmane.org but they haven't made it to the list yet. As I'm a subscriber now, I'm resending them directly. Sorry for any duplicates in advance. Just a small typo fix: --- diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvir

[libvirt] [PATCH] [libvirt-java] Fix javadoc warnings.

2012-07-09 Thread Claudio Bley
Hi. I sent a few mails on friday, 6th July, via gmane.org but they haven't made it to the list yet. As I'm a subscriber now, I'm resending them directly. Sorry for any duplicates in advance. Here's a patch fixing these javadoc warnings: --- [javadoc] x:\src\libvirt-java\src\main\java\org\libvi

[libvirt] [PATCH] [libvirt-java] Fix Array IndexOutOfBoundsException for unknown error codes

2012-07-09 Thread Claudio Bley
Hi. I sent a few mails on friday, 6th July, via gmane.org but they haven't made it to the list yet. As I'm a subscriber now, I'm resending them directly. Sorry for any duplicates in advance. I'm using libvirt-java 0.4.7 and libvirt 0.9.8. When libvirt returns an error code which is not mapped in

Re: [libvirt] [PATCH] ESX: interface driver routines

2012-07-09 Thread Daniel P. Berrange
On Sun, Jul 08, 2012 at 08:52:01AM +0530, Ata Bohra wrote: > Attached patch adds missing routines to esx interface driver, one of > the missing routine is esxInterfaceDefineXML. I am currently working > on it and will update patch soon. Also, patch addresses some of the > changes needed in esx_vi_g

[libvirt] [PATCH] docs: Improve patch submission guidelines

2012-07-09 Thread Michal Privoznik
We should really advise (new) developers to send rebased patches that apply cleanly and use git-send-email rather than all other obscure ways. --- docs/hacking.html.in | 30 +++--- 1 files changed, 27 insertions(+), 3 deletions(-) diff --git a/docs/hacking.html.in b/docs

Re: [libvirt] [PATCH] ESX: Add routines to interface driver

2012-07-09 Thread Daniel Veillard
On Mon, Jul 09, 2012 at 12:25:35AM -0700, Ata Bohra wrote: > > Thanks Daniel for sharing the link. I got the idea and will try to adhere to > the standards. > > One observation I want to share about "make check", with a fresh branch I see > one failure: > - > .!!...!

Re: [libvirt] [PATCH] ESX: Add routines to interface driver

2012-07-09 Thread Daniel Veillard
On Mon, Jul 09, 2012 at 09:25:48AM +0200, Michal Privoznik wrote: > On 09.07.2012 05:21, Daniel Veillard wrote: > > On Sun, Jul 08, 2012 at 11:36:47AM -0700, Ata Bohra wrote: > >> From: Ata E Husain > >> > >> Includes most of the dirver routines except DefineXML, I am working on it > >> and will

Re: [libvirt] [PATCH] ESX: Add routines to interface driver

2012-07-09 Thread Michal Privoznik
On 09.07.2012 05:21, Daniel Veillard wrote: > On Sun, Jul 08, 2012 at 11:36:47AM -0700, Ata Bohra wrote: >> From: Ata E Husain >> >> Includes most of the dirver routines except DefineXML, I am working on it >> and will update patch for it soon. > > typo s/dirver/driver/ > > I guess you didn

Re: [libvirt] Release of libvirt-java 0.4.8

2012-07-09 Thread Daniel Veillard
On Sun, Jul 08, 2012 at 10:39:31PM -0700, Jason Helfman wrote: > On Fri, Jul 06, 2012 at 02:20:40PM +0800, Daniel Veillard thus spake: > > I have tagged the git tree and pushed the tarball and rpms at: > > > > ftp://libvirt.org/libvirt/java/ > > > >This release includes the few improvement and