Re: [libvirt] trying to build 0.9.13 on F17: cannot find -lcrypto

2012-07-17 Thread Wido den Hollander
On 12-07-12 14:32, Daniel P. Berrange wrote: On Thu, Jul 12, 2012 at 02:20:11PM +0200, Christophe Fergeau wrote: Hey, On Wed, Jul 11, 2012 at 03:42:20PM +0100, Daniel P. Berrange wrote: On Wed, Jul 11, 2012 at 10:23:21AM -0400, Cole Robinson wrote: I think this comes from rbd support, from

Re: [libvirt] [PATCH v8 6/8] parallels: implement virDomainDefineXML operation for existing domains

2012-07-17 Thread Dmitry Guryanov
On 07/13/2012 04:04 PM, Peter Krempa wrote: Hello, Peter, Should I fix first 6 patches and resend them or wait until you finish reviewing last 2 ones ? On 07/04/12 19:42, Dmitry Guryanov wrote: Add parallelsDomainDefineXML function, it works only for existing domains for the present. It's

Re: [libvirt] [PATCH v8 6/8] parallels: implement virDomainDefineXML operation for existing domains

2012-07-17 Thread Peter Krempa
On 07/17/12 13:13, Dmitry Guryanov wrote: On 07/13/2012 04:04 PM, Peter Krempa wrote: Hello, Peter, Should I fix first 6 patches and resend them or wait until you finish reviewing last 2 ones ? I'll also review the rest of the series but 7/8 is quite massive and I had to do other things.

Re: [libvirt] How to get the real device in guest os after attached a disk?

2012-07-17 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:40 AM, Wangpan hzwang...@corp.netease.com wrote: I have a question as the subject above, the reason I want to know this is that, if I attach some disks on the guest, for example, I specified /dev/vdc/dev/vdd(target device) at the cmd line by using 'virsh

Re: [libvirt] [PATCH v2] Convert 'raw MAC address' usages to use virMacAddr

2012-07-17 Thread Stefan Berger
On 07/16/2012 07:16 PM, Eric Blake wrote: On 07/16/2012 05:14 AM, Stefan Berger wrote: @@ -127,7 +121,7 @@ struct _nwItemDesc { virNWFilterVarAccessPtr varAccess; enum attrDatatype datatype; union { -nwMACAddress macaddr; +virMacAddr macaddr;

Re: [libvirt] [PATCH] configure: rbd doesn't need -lcrypto

2012-07-17 Thread Cole Robinson
On 07/16/2012 04:19 AM, Daniel P. Berrange wrote: On Sun, Jul 15, 2012 at 01:24:25PM -0400, Cole Robinson wrote: See https://www.redhat.com/archives/libvir-list/2012-July/msg00493.html Basically building against librbd doesn't seem to actually require -lcrypto. Also report the rbd linker

[libvirt] [PATCH] nwfilter: Convert to virMacAddrPtr completely

2012-07-17 Thread Michal Privoznik
The previous commit (387117ad92) was incomplete leaving those who does not use libpcap with uncompilable sources beacuse of incomplete conversion of virNWFilterDHCPSnoopReq function. --- Pushing under build breaker and trivial rules. src/nwfilter/nwfilter_dhcpsnoop.c |2 +- 1 files changed,

Re: [libvirt] [PATCH 0/4] qemu: configurable port boundaries for remote displays

2012-07-17 Thread Martin Kletzander
bump? On 06/18/2012 01:10 PM, Martin Kletzander wrote: This series introduces a possibility to change default minimal and maximal port numbers that are used to specify a remote display port for both VNC and SPICE. Because the code was a bit messy, PATCH 1/4 cleans up few things needed to

[libvirt] [PATCH] nwfilter: Convert to virMacAddrPtr not virMacAddrPtr*

2012-07-17 Thread Michal Privoznik
My previous patch wasn't complete as it converted from (unsigned char *) to (virMacAddrPtr *). It should be (virMacAddrPtr) only. --- Again, pushed under build breaker. src/nwfilter/nwfilter_dhcpsnoop.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Switch virDomainObjPtr to use the virObject APIs for reference counting. The main change is that virObjectUnref does not return the reference count, merely a bool indicating whether the object

Re: [libvirt] [PATCH 07/13] Turn qemuAgentPtr and qemuMonitorPtr into virObjectPtr instances

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make qemuAgentPtr and qemuMonitorPtr types use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- @@ -791,12 +778,13 @@

Re: [libvirt] IPs via DHCP for guest domains

2012-07-17 Thread Laine Stump
On 06/27/2012 01:44 AM, Fong Vang wrote: I'm curious to know how you are providing IPs for your Windows VMs when connected via a bridge. Define connected via a bridge. If you are using interface type='bridge' (where the bridge is usually itself connected directly to a physical interface)

[libvirt] [PATCH] xenapi: Convert to virMacAddr

2012-07-17 Thread Jiri Denemark
--- Can't we just get rid of this horrific and mostly unmaintained xenapi code completely? :-) src/xenapi/xenapi_driver.c | 3 ++- src/xenapi/xenapi_utils.c | 36 ++-- 2 files changed, 16 insertions(+), 23 deletions(-) diff --git a/src/xenapi/xenapi_driver.c

[libvirt] We need this patch to mount all tmpfs file systems with the correct context.

2012-07-17 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Basically within a Secure Linux Container (virt-sandbox) we want all content that the process within the container can write to be labeled the same. We are labeling the physical disk correctly but when we create RAM based file systems libvirt is not

Re: [libvirt] [PATCH] xenapi: Convert to virMacAddr

2012-07-17 Thread Eric Blake
On 07/17/2012 09:24 AM, Jiri Denemark wrote: --- Can't we just get rid of this horrific and mostly unmaintained xenapi code completely? :-) Wouldn't it be nice? That may be a question worth asking on the announce list, to see who would be impacted if it disappears.

Re: [libvirt] [PATCH 08/13] Turn virNetTLSContext and virNetTLSSession into virObject instances

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make virNetTLSContext and virNetTLSSession use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- ACK. -- Eric Blake ebl...@redhat.com

Re: [libvirt] [PATCH] xenapi: Convert to virMacAddr

2012-07-17 Thread Jiri Denemark
On Tue, Jul 17, 2012 at 09:47:13 -0600, Eric Blake wrote: On 07/17/2012 09:24 AM, Jiri Denemark wrote: --- Can't we just get rid of this horrific and mostly unmaintained xenapi code completely? :-) Wouldn't it be nice? That may be a question worth asking on the announce list, to see

[libvirt] [PATCH] qemu: Set reasonable RSS limit on domain startup

2012-07-17 Thread Michal Privoznik
If there's a memory leak in qemu or qemu is exploited the host's system will sooner or later start trashing instead of killing the bad process. This however has impact on performance and other guests as well. Therefore we should set a reasonable RSS limit even when user hasn't set any. It's better

Re: [libvirt] [PATCH 09/13] Turn virNetSASLContext and virNetSASLSession into virObject instances

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make virNetSASLContext and virNetSASLSession use virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- ACK -- Eric Blake ebl...@redhat.com

[libvirt] [PATCH] remote: Fix locking in stream APIs

2012-07-17 Thread Jiri Denemark
Remote driver needs to make sure the driver lock is released before entering client IO loop as that may block indefinitely in poll(). As a direct consequence of not following this in stream APIs, tunneled migration to a destination host which becomes non-responding may block qemu driver. Luckily,

Re: [libvirt] [PATCH 10/13] Turn virKeepAlive into a virObject

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make virKeepAlive use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- ACK -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 11/13] Turn virSocket into a virObject

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make virSocket use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- ACK -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 12/13] Turn virNetServer* into virObject instances

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make all the virNetServer* objects use the virObject APIs for reference countign s/countign/counting/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- @@ -519,16 +530,6 @@ int

Re: [libvirt] [PATCH 04/13] Add a generic reference counted virObject type

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This introduces a fairly basic reference counted virObject type and an associated virClass type, that use atomic operations for ref counting. +void *virObjectNew(virClassPtr klass) +{ +

Re: [libvirt] [PATCH 13/13] Turn virNetClient* into virObject instances

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make all the virNetClient* objects use virObject APIs for reference counting Signed-off-by: Daniel P. Berrange berra...@redhat.com --- @@ -286,19 +294,22 @@ static virNetClientPtr

Re: [libvirt] [PATCH 04/13] Add a generic reference counted virObject type

2012-07-17 Thread Eric Blake
On 07/17/2012 02:25 PM, Eric Blake wrote: On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This introduces a fairly basic reference counted virObject type and an associated virClass type, that use atomic operations for ref counting. +void

Re: [libvirt] ESX: failure while performing CastFromAnyType

2012-07-17 Thread Ata E Husain Bohra
Just want to drop this note, so no one else gets bother with my query. I was able to find the reason and its fixed. It seems one of the ENUMs deep inside one of the structures was not defined. I am not sure if single step is the only way to solve such issues, as ESX_VI_ERROR never provided any

[libvirt] [PATCH v2] Per-guest configurable user/group for QEMU processes

2012-07-17 Thread Marcelo Cerri
This is a v2 patch series that updates the libvirt's security driver mechanism to support per-guest configurable user and group for QEMU processes running together with other security drivers, such as SELinux and AppArmor. Comments and feedbacks are welcome. -- libvir-list mailing list

[libvirt] [PATCH v2 4/5] Support for multiple default security drivers in QEMU config

2012-07-17 Thread Marcelo Cerri
This patch replaces the key security_driver in QEMU config by security_drivers, which accepts a list of default drivers. If security_drivers can't be found, libvirt will use security_driver to ensure that it will remain compatible with older version of the config file. ---

[libvirt] [PATCH v2 5/5] Update the remote API

2012-07-17 Thread Marcelo Cerri
Thist patch updates libvirt's API to allow applications to inspect the full list of security labels of a domain. --- daemon/remote.c | 62 include/libvirt/libvirt.h.in |2 + python/generator.py |1 + src/driver.h

[libvirt] [PATCH v2 1/5] Internal refactory of data structures

2012-07-17 Thread Marcelo Cerri
This patch updates the structures that store information about each domain and each hypervisor to support multiple security labels and drivers. It also updates all the remaining code to use the new fields. --- src/conf/capabilities.c | 17 -- src/conf/capabilities.h |6

[libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-17 Thread tangchen
Hi~ It seems that libvirt is not cpu hotplug aware. Please refer to the following problem. 1. At first, we have 2 cpus. # cat /cgroup/cpuset/cpuset.cpus 0-1 # cat /cgroup/cpuset/libvirt/qemu/cpuset.cpus 0-1 2. And we have a vm1 with following configuration. cputune vcpupin vcpu='0'

[libvirt] [PATCH v2 2/5] multiple security drivers in XML data

2012-07-17 Thread Marcelo Cerri
This patch updates the domain XML parser and formatter to support more than one seclabel element for each domain and device. The RNG schema and the tests related to this are also updated by this patch. --- docs/schemas/domaincommon.rng | 30 ++- src/conf/domain_conf.c

Re: [libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-17 Thread Eric Blake
On 07/17/2012 07:33 PM, tangchen wrote: Hi~ It seems that libvirt is not cpu hotplug aware. Portions of libvirt are aware of host hotplug issues, but you are correct that there are still lingering bugs (I just found one today in nodeinfo.c). 4. Online cpu1. # echo 1

[libvirt] [PATCH] nodeinfo: deal with offline cpus in a node

2012-07-17 Thread Eric Blake
Commit 80533ca forgot to think about offline cpus. When a node cpu is offline, then its topology/ subdirectory is not present, leading to spurious error messages leaked to the user such as: libvir: error : cannot open

Re: [libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-17 Thread tangchen
Hi~ On 07/18/2012 09:44 AM, Eric Blake wrote: On 07/17/2012 07:33 PM, tangchen wrote: Hi~ It seems that libvirt is not cpu hotplug aware. Portions of libvirt are aware of host hotplug issues, but you are correct that there are still lingering bugs (I just found one today in nodeinfo.c).

Re: [libvirt] [PATCH] qemu: Set reasonable RSS limit on domain startup

2012-07-17 Thread Doug Goldstein
On Tue, Jul 17, 2012 at 11:45 AM, Michal Privoznik mpriv...@redhat.com wrote: If there's a memory leak in qemu or qemu is exploited the host's system will sooner or later start trashing instead of killing the bad process. This however has impact on performance and other guests as well.