Re: [libvirt] QEMU 1.2 Test Day - August 16 2012

2012-08-17 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 10:24 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Aug 14, 2012 at 2:37 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Aug 2, 2012 at 1:22 PM, Stefan Hajnoczi stefa...@gmail.com wrote: I have set up the QEMU 1.2 Testing wiki page and suggest August 16 as

Re: [libvirt] [PATCH 6/7] Forward Mode Hostdev network driver Implementation

2012-08-17 Thread Laine Stump
On 08/16/2012 11:42 AM, Shradha Shah wrote: This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 ++ src/network/bridge_driver.c |

[libvirt] [PATCH v3] qemu: Set swap_hard_limit before hard_limit

2012-08-17 Thread Osier Yang
Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100 swap_hard_limit: 100 % virsh memtune rhel6 --hard-limit

[libvirt] [PATCHv2 6/7] network: support forward mode='hostdev' in network driver

2012-08-17 Thread Laine Stump
From: Shradha Shah ss...@solarflare.com This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com Signed-off-by: Laine Stump la...@laine.org --- This patch should *replace* patch 6/7 in

Re: [libvirt] [PATCH v3] qemu: Set swap_hard_limit before hard_limit

2012-08-17 Thread Martin Kletzander
On 08/17/2012 09:34 AM, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100 swap_hard_limit:

[libvirt] [test-API][PATCH 2/3] Modify function name to avoid key word 'check' in framework

2012-08-17 Thread Wayne Sun
Modfiy the function name to avoid generating check case and doing params check before the case run. Signed-off-by: Wayne Sun g...@redhat.com --- repos/domain/cpu_topology.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/repos/domain/cpu_topology.py

[libvirt] [test-API][PATCH 3/3] Target path should not with lines in pool xml

2012-08-17 Thread Wayne Sun
The xml for define and create pool is with line switch in target path. For aa.xml: pool type=netfs namenetfs_pool/name source host name=192.168.0.121/ dir path=/dir/ format type=nfs/ /source target path /tmp/netfs /path /target /pool virsh pool-create aa.xml

[libvirt] [test-API][PATCH 1/3] Delete the duplicate function

2012-08-17 Thread Wayne Sun
Signed-off-by: Wayne Sun g...@redhat.com --- utils/utils.py | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/utils/utils.py b/utils/utils.py index eade10d..b174a58 100644 --- a/utils/utils.py +++ b/utils/utils.py @@ -514,24 +514,6 @@ def

Re: [libvirt] [test-API][PATCH 3/3] Target path should not with lines in pool xml

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: The xml for define and create pool is with line switch in target path. For aa.xml: pool type=netfs namenetfs_pool/name source host name=192.168.0.121/ dir path=/dir/ format type=nfs/ /source target path

Re: [libvirt] [test-API][PATCH 2/3] Modify function name to avoid key word 'check' in framework

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: Modfiy the function name to avoid generating check case and doing params check before the case run. Signed-off-by: Wayne Sun g...@redhat.com --- repos/domain/cpu_topology.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [libvirt] [test-API][PATCH 1/3] Delete the duplicate function

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: Signed-off-by: Wayne Sun g...@redhat.com --- utils/utils.py | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/utils/utils.py b/utils/utils.py index eade10d..b174a58 100644 --- a/utils/utils.py +++

[libvirt] [PATCH] conf: Fix ABI stability check for spicevmc channel

2012-08-17 Thread Jiri Denemark
Change device type of a virtio channel from/to spicevmc is not a user visible change. However, spicevmc channels use different default target name than other virtio channels. To maintain ABI stability during this change target name must be explicitly specified (and equal) in both configurations.

[libvirt] [PATCH] docs: Enhance documentation of log_filters

2012-08-17 Thread Jiri Denemark
Also make sure documentation in libvirtd.conf matches the one from logging.html. --- daemon/libvirtd.conf | 9 ++--- docs/logging.html.in | 9 ++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index 56e880b..3d296cd 100644

Re: [libvirt] [PATCH 17/23] Introduce basic infrastructure for virtlockd daemon

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virtlockd daemon will maintain locks on behalf of libvirtd. There are two reasons for it to be separate - Avoid risk of other libvirtd threads accidentally releasing fcntl() locks by

Re: [libvirt] [PATCH] conf: Fix ABI stability check for spicevmc channel

2012-08-17 Thread Eric Blake
On 08/17/2012 06:20 AM, Jiri Denemark wrote: Change device type of a virtio channel from/to spicevmc is not a user visible change. However, spicevmc channels use different default target name than other virtio channels. To maintain ABI stability during this change target name must be

Re: [libvirt] [PATCH] docs: Enhance documentation of log_filters

2012-08-17 Thread Eric Blake
On 08/17/2012 06:20 AM, Jiri Denemark wrote: Also make sure documentation in libvirtd.conf matches the one from logging.html. --- daemon/libvirtd.conf | 9 ++--- docs/logging.html.in | 9 ++--- 2 files changed, 12 insertions(+), 6 deletions(-) ACK. -- Eric Blake

Re: [libvirt] [PATCH 0/8] Honour current process label when generating SELinux labels

2012-08-17 Thread Viktor Mihajlovski
On 08/16/2012 07:43 PM, Daniel J Walsh wrote: Yes the security context should be system_u:object_r:svirt_image_t:s0:c786,c986 These patches should have just affected the Process label not the file label. On the file label we should alter the role on the file label to include object_r.

[libvirt] [PATCH] selinux: Fix incorrect file label generation.

2012-08-17 Thread Viktor Mihajlovski
This is an ad-hoc fix for the file label generation. It uses the base context role to determine whether to use the libvirt process context role. If this is object_r we don't touch it. It might be better to add a new flag to virSecuritySELinuxGenNewContext that specifies the context type (process

[libvirt] [PATCHv4 0/2] Rework of Disk Geometry Support

2012-08-17 Thread Viktor Mihajlovski
With qemu it is possible to override the geometry (cylinders, heads, sectors) of disks. This series adds a new XML tag for geometry and the related support in the qemu driver. V2 Changes: Refactor into the generic domain configuration/XML support for disk geometry and a qemu specific part with

[libvirt] [PATCHv4 2/2] qemu: Disk Geometry Override Support

2012-08-17 Thread Viktor Mihajlovski
From: J.B. Joret j...@linux.vnet.ibm.com Qemu command line generation for geometry override and testcases. V2 Changes: squashed qemu code and testcases. V3 Changes: use virReportError. Signed-off-by: J.B. Joret j...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski

[libvirt] [PATCHv4 1/2] Support for Disk Geometry Override

2012-08-17 Thread Viktor Mihajlovski
From: J.B. Joret j...@linux.vnet.ibm.com A hypervisor may allow to override the disk geometry of drives. Qemu, as an example with cyls=,heads=,secs=[,trans=]. This patch extends the domain config to allow the specification of disk geometry with libvirt. V2 Changes: Split out qemu specific code,

Re: [libvirt] [PATCH 0/3] Allow to override disk geometry.

2012-08-17 Thread Viktor Mihajlovski
Obsoleted by new patch set. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [libvirt] [PATCH 18/23] Define a wire protocol for talking to the virtlockd daemon

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virtlockd daemon will be responsible for managing locks on virtual machines. Communication will be via the standard RPC infrastructure. This provides the XDR protocol definition *

Re: [libvirt] [PATCH v3] qemu: Set swap_hard_limit before hard_limit

2012-08-17 Thread Osier Yang
On 2012年08月17日 16:29, Martin Kletzander wrote: On 08/17/2012 09:34 AM, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100

Re: [libvirt] [test-API][PATCH 3/3] Target path should not with lines in pool xml

2012-08-17 Thread Osier Yang
On 2012年08月17日 18:41, Martin Kletzander wrote: On 08/17/2012 12:06 PM, Wayne Sun wrote: The xml for define and create pool is with line switch in target path. For aa.xml: pool type=netfs namenetfs_pool/name source host name=192.168.0.121/ dir path=/dir/ format type=nfs/

Re: [libvirt] [PATCH 6/7] Forward Mode Hostdev network driver Implementation

2012-08-17 Thread Shradha Shah
I'll be posting a proposed replacement patch for this one in a few minutes. Please try it out as soon as possible. I haven't gone through 7/7 yet, but with the small changes I've squashed in elsewhere, plus the 3.5/7 I posted and the 6/7 refactor I'm about to post, definitely the first 6 are

Re: [libvirt] [PATCH] selinux: Fix incorrect file label generation.

2012-08-17 Thread Osier Yang
On 2012年08月17日 20:53, Viktor Mihajlovski wrote: This is an ad-hoc fix for the file label generation. It uses the base context role to determine whether to use the libvirt process context role. If this is object_r we don't touch it. It might be better to add a new flag to

Re: [libvirt] [PATCH 19/23] Implement dispatch functions for lock protocol in virtlockd

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a lock_daemon_dispatch.c file which implements the server side dispatcher the RPC APIs previously defined in the lock protocol. Signed-off-by: Daniel P. Berrange berra...@redhat.com

Re: [libvirt] [PATCH] selinux: Fix incorrect file label generation.

2012-08-17 Thread Eric Blake
On 08/17/2012 08:18 AM, Osier Yang wrote: On 2012年08月17日 20:53, Viktor Mihajlovski wrote: This is an ad-hoc fix for the file label generation. It uses the base context role to determine whether to use the libvirt process context role. If this is object_r we don't touch it. It might be

Re: [libvirt] [PATCH] conf: Fix ABI stability check for spicevmc channel

2012-08-17 Thread Jiri Denemark
On Fri, Aug 17, 2012 at 06:51:22 -0600, Eric Blake wrote: On 08/17/2012 06:20 AM, Jiri Denemark wrote: Change device type of a virtio channel from/to spicevmc is not a user visible change. However, spicevmc channels use different default target name than other virtio channels. To maintain

[libvirt] [PATCHv2] selinux: Fix incorrect file label generation.

2012-08-17 Thread Viktor Mihajlovski
This is an ad-hoc fix for the file label generation. It uses the base context role to determine whether to use the libvirt process context role. If this is object_r we don't touch it. It might be better to add a new flag to virSecuritySELinuxGenNewContext that specifies the context type (process

[libvirt] [PATCH 0/2 v3] Storage: Allow pool building while creating it

2012-08-17 Thread Osier Yang
v2 - v3: * Just rebase on the top. We tries to start the pool while creating a transicient pool, if the pool target is not existed yet, we must fail on starting, and thus we see many users raise up the problem on either list or bugzilla. Patch 2/3 and 3/3 are to fix the problem by introducing

[libvirt] [PATCH 1/2] storage: New flags to allow building the pool while creating it

2012-08-17 Thread Osier Yang
We see the requirement for allowing to build the pool while pool-create /pool-create-as/pool-start often in either upstream list or bugzilla, so this patch introduces the flags virStoragePoolCreateFlags for both virStoragePoolCreate and virStoragePoolCreateXML. VIR_STORAGE_POOL_CREATE_WITH_BUILD

Re: [libvirt] [PATCH] Add support for setting VLANs on Open vSwitch ports

2012-08-17 Thread Laine Stump
On 08/17/2012 12:04 AM, Kyle Mestery wrote: Add the ability to support VLAN tags for Open vSwitch virtual port types. To accomplish this, modify virNetDevOpenvswitchAddPort and virNetDevTapCreateInBridgePort to take a virNetDevVlanPtr argument. When adding the port to the OVS bridge, setup

[libvirt] [PATCH 2/2] virsh: New options for the 3 pool commands to allow pool building

2012-08-17 Thread Osier Yang
New options --build, --build-overwrite, and --build-no-overwrite are added to commands pool-create/pool-create-as/pool-start. Perhaps it's not that necessary to allow pool building for pool-start, but it doesn't hurt to have them. --- The documents of pool-build is not that correct, as the flags

[libvirt] [PATCH 00/45 v3] Atomic APIs to list objects

2012-08-17 Thread Osier Yang
v3 - v4: * Except a few patches are pushed, it's just rebasing on the top v2 - v3: * Various document fixes/improvements (Suggested by Laine and Eric) * Destroy virdomainlist.[ch], and folder all list helper funcs into its own *_conf.[ch] * Improve the helpers to get the object list.

[libvirt] [PATCH 07/45] virsh: Fix the wrong doc for pool-list

2012-08-17 Thread Osier Yang
The storage pool's management doesn't relate with a domain, it probably was a intention, but not achieved yet. And the fact is only active pools are listed by default. --- tools/virsh.pod |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod

[libvirt] [PATCH 01/45] list: Define new API virStorageListAllStoragePools

2012-08-17 Thread Osier Yang
This introduces a new API to list the storage pool objects, 4 groups of flags are provided to filter the returned pools: * Active or not * Autostarting or not * Persistent or not * And the pool type. include/libvirt/libvirt.h.in: New enum virConnectListAllStoragePoolFlags;

[libvirt] [PATCH 05/45] list: Implement listAllStoragePools for test driver

2012-08-17 Thread Osier Yang
src/test/test_driver.c: Implement listAllStoragePools --- src/test/test_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a767e21..18691ad 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH 02/45] list: Add helpers for listing storage pool objects

2012-08-17 Thread Osier Yang
src/conf/storage_conf.c: Add virStoragePoolMatch to filter the pools; Add virStoragePoolList to iterate over the pool objects with filter. src/conf/storage_conf.h: Declare virStoragePoolMatch, virStoragePoolList, and the macros for filters. src/libvirt_private.syms: Export helper

[libvirt] [PATCH 03/45] list: Implement the RPC calls for virConnectListAllStoragePools

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object, this patch do the work manually. * daemon/remote.c: Implement the server side handler remoteDispatchConnectListAllStoragePools * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllStoragePools. *

[libvirt] [PATCH 16/45] list: Expose virStoragePoolListAllVolumes to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virStoragePool.py: * New file, includes implementation of listAllVolumes. python/libvirt-override.c:

[libvirt] [PATCH 06/45] list: Add helper to convert strings separated by ', ' to array

2012-08-17 Thread Osier Yang
tools/virsh.c: New helper function vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++- tools/virsh.c| 45 + 2 files changed, 47 insertions(+), 17 deletions(-) diff --git

[libvirt] [PATCH 08/45] list: Change MATCH for common use in virsh

2012-08-17 Thread Osier Yang
Move definition of MATCH from virsh-domain-monitor.c into virsh.c for further use. --- tools/virsh-domain-monitor.c |2 -- tools/virsh.c|2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index

[libvirt] [PATCH 04/45] list: Implement listAllStoragePools for storage driver

2012-08-17 Thread Osier Yang
src/storage/storage_driver.c: Implement listAllStoragePools. --- src/storage/storage_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 3dc66db..4f99eb9 100644 ---

[libvirt] [PATCH 09/45] list: Use virConnectListAllStoragePools in virsh

2012-08-17 Thread Osier Yang
tools/virsh-pool.c: * vshStoragePoolSorter to sort the pool list by pool name. * struct vshStoragePoolList to present the pool list, pool info is collected by list-poolinfo if 'details' is specified by user. * vshStoragePoolListFree to free the pool list *

[libvirt] [PATCH 10/45] python: Expose virStorageListAllStoragePools to python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Add listAllStoragePools python/libvirt-override.c: Implementation for the wrapper. ---

[libvirt] [PATCH 11/45] list: Define new API virStoragePoolListAllVolumes

2012-08-17 Thread Osier Yang
Simply returns the storage volume objects. No supported filter flags. include/libvirt/libvirt.h.in: Declare the API python/generator.py: Skip the function for generating. virStoragePool.py will be added in later patch. src/driver.h: virDrvStoragePoolListVolumesFlags

[libvirt] [PATCH 22/45] list: Use virConnectListAllNetworks in virsh

2012-08-17 Thread Osier Yang
tools/virsh-network.c: * vshNetworkSorter to sort networks by name * vshNetworkListFree to free the network objects list. * vshNetworkListCollect to collect the network objects, trying to use new API first, fall back to older APIs if it's not supported. * New options --persistent,

[libvirt] [PATCH 12/45] list: Implemente RPC calls for virStoragePoolListAllVolumes

2012-08-17 Thread Osier Yang
The RPC generator doesn't returning support list of object, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchStoragePoolListAllVolumes * src/remote/remote_driver.c: Add remote driver handler remoteStoragePoolListAllVolumes *

[libvirt] [PATCH 13/45] list: Implement virStoragePoolListAllVolumes for storage driver

2012-08-17 Thread Osier Yang
src/storage/storage_driver.c: Implement poolListAllVolumes. --- src/storage/storage_driver.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 4f99eb9..4f83348 100644

[libvirt] [PATCH 18/45] list: Implement RPC calls for virConnectListAllNetworks

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNetworks. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNetworks. *

[libvirt] [PATCH 23/45] list: Expose virConnectListAllNetworks to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Implement listAllNetworks. python/libvirt-override.c: Implementation for the wrapper. ---

[libvirt] [PATCH 17/45] list: Define new API virConnectListAllNetworks

2012-08-17 Thread Osier Yang
This is to list the network objects, supported filtering flags are: active|inactive, persistent|transient, autostart|no-autostart. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNetworkFlags and virConnectListAllNetworks. python/generator.py: Skip

[libvirt] [PATCH 14/45] list: Implement virStoragePoolListAllVolumes for test driver

2012-08-17 Thread Osier Yang
src/test/test_driver.c: Implement poolListAllVolumes. --- src/test/test_driver.c | 67 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 18691ad..f7913aa 100644 ---

[libvirt] [PATCH 15/45] list: Use virStoragePoolListAllVolumes in virsh

2012-08-17 Thread Osier Yang
tools/virsh-volume.c: * vshStorageVolSorter to sort storage vols by name * vshStorageVolumeListFree to free the volume objects list * vshStorageVolumeListCollect to collect the volume objects, trying to use new API first, fall back to older APIs if it's not supported. ---

[libvirt] [PATCH 20/45] list: Implement listAllNetworks for network driver

2012-08-17 Thread Osier Yang
src/network/bridge_driver.c: Implement listAllNetworks. --- src/network/bridge_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 474bbfa..d968f5f 100644 ---

[libvirt] [PATCH 19/45] list: Add helpers to list network objects

2012-08-17 Thread Osier Yang
src/conf/network_conf.c: Add virNetworkMatch to filter the networks; and virNetworkList to iterate over all the networks with the filter. src/conf/network_conf.h: Declare virNetworkList and define the macros for filters. src/libvirt_private.syms: Export virNetworkList. ---

[libvirt] [PATCH 24/45] list: Define new API virConnectListAllInterfaces

2012-08-17 Thread Osier Yang
This is to list the interface objects, supported filtering flags are: active|inactive. include/libvirt/libvirt.h.in: Declare enum virConnectListAllInterfaceFlags and virConnectListAllInterfaces. python/generator.py: Skip auto-generating src/driver.h:

[libvirt] [PATCH 32/45] list: Implement listAllNodeDevices

2012-08-17 Thread Osier Yang
This simply implements listAllNodeDevices using helper virNodeDeviceList src/node_device/node_device_driver.h: * Declare nodeListAllNodeDevices. src/node_device/node_device_driver.c: * Implement nodeListAllNodeDevices. src/node_device/node_device_hal.c: * Hook listAllNodeDevices to

[libvirt] [PATCH 21/45] list: Implement listAllNetworks for test driver

2012-08-17 Thread Osier Yang
src/test/test_driver.c: Implement listAllNetworks. --- src/test/test_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f7913aa..7b4dd02 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH 34/45] virsh: Fix a bug of nodedev-list

2012-08-17 Thread Osier Yang
output of commands like '%virsh nodedev-list --tree --cap pci' could be empty. Remove the useless checking. --- tools/virsh-nodedev.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 5a0987d..6848925 100644 ---

[libvirt] [PATCH 25/45] list: Implemente RPC calls for virConnectListAllInterfaces

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllInterfaces. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllInterfaces. *

[libvirt] [PATCH 26/45] list: Implement listAllInterfaces

2012-08-17 Thread Osier Yang
This is not that ideal as API for other objects, as it's still O(n). Because interface driver uses netcf APIs to manage the stuffs, instead of by itself. And netcf APIs don't return a object. It provides APIs like old libvirt APIs: ncf_number_of_interfaces ncf_list_interfaces

[libvirt] [PATCH 29/45] list: Define new API virConnectListAllNodeDevices

2012-08-17 Thread Osier Yang
This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py: Skip auto-generating src/driver.h:

[libvirt] [PATCH 38/45] list: Implement listAllNWFilters

2012-08-17 Thread Osier Yang
Simply returns the object list. No filtering. src/nwfilter/nwfilter_driver.c: Implement listAllNWFilters --- src/nwfilter/nwfilter_driver.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c

[libvirt] [PATCH 27/45] list: Use virConnectListAllInterfaces in virsh

2012-08-17 Thread Osier Yang
tools/virsh-interface.c: * vshInterfaceSorter to sort interfaces by name * vshInterfaceListFree to free the interface objects list. * vshInterfaceListCollect to collect the interface objects, trying to use new API first, fall back to older APIs if it's not supported. ---

[libvirt] [PATCH 28/45] list: Expose virConnectListAllInterfaces to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * New file, includes implementation of listAllInterfaces. python/libvirt-override.c:

[libvirt] [PATCH 36/45] list: Define new API virConnectListAllNWFilters

2012-08-17 Thread Osier Yang
This is to list the network fitler objects. No flags are supported include/libvirt/libvirt.h.in: Declare enum virConnectListAllNWFilterFlags and virConnectListAllNWFilters. python/generator.py: Skip auto-generating src/driver.h: (virDrvConnectListAllNWFilters)

[libvirt] [PATCH 30/45] list: Implemente RPC calls for virConnectListAllNodeDevices

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNodeDevices. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNodeDevices.

[libvirt] [PATCH 35/45] list: Use virConnectListAllNodeDevices in virsh

2012-08-17 Thread Osier Yang
tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to older APIs if it's not supported. * Change

[libvirt] [PATCH 39/45] list: Use virConnectListAllNWFilters in virsh

2012-08-17 Thread Osier Yang
tools/virsh-nwfilter.c: * vshNWFilterSorter to sort network filters by name * vshNWFilterListFree to free the network filter objects list. * vshNWFilterListCollect to collect the network filter objects, trying to use new API first, fall back to older APIs if it's not supported. ---

[libvirt] [PATCH 42/45] list: Implement RPC calls for virConnectListAllSecrets

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllSecrets. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllSecrets. *

[libvirt] [PATCH 40/45] list: Expose virConnectListAllNWFilters to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * Implementation for listAllNWFilters. python/libvirt-override.c: Implementation for the

Re: [libvirt] [PATCH] Add support for setting VLANs on Open vSwitch ports

2012-08-17 Thread Kyle Mestery (kmestery)
On Aug 17, 2012, at 10:12 AM, Laine Stump wrote: On 08/17/2012 12:04 AM, Kyle Mestery wrote: Add the ability to support VLAN tags for Open vSwitch virtual port types. To accomplish this, modify virNetDevOpenvswitchAddPort and virNetDevTapCreateInBridgePort to take a virNetDevVlanPtr

[libvirt] [PATCH 44/45] list: Use virConnectListAllSecrets in virsh

2012-08-17 Thread Osier Yang
tools/virsh.c: Remove vshNameSorter for nobody uses it tools/virsh-secret.c: * vshSecretSorter to sort secret object by name * vshSecretListFree to free the secret objects list. * vshSecretListCollect to collect the secret objects, trying to use new API first, fall back to older APIs

[libvirt] [PATCH 37/45] list: Implement RPC calls for virConnectListAllNWFilters

2012-08-17 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNWFilters. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNWFilters. *

[libvirt] [PATCH 41/45] list: Define new API virConnectListAllSecrets

2012-08-17 Thread Osier Yang
This is to list the secret objects. No flags are supported include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags and virConnectListAllSecrets. python/generator.py: Skip auto-generating src/driver.h: (virDrvConnectListAllSecrets) src/libvirt.c:

[libvirt] [PATCH 31/45] list: Add helpers for listing node devices

2012-08-17 Thread Osier Yang
src/conf/node_device_conf.h: * New macro VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP * Declare virNodeDeviceList src/conf/node_device_conf.c: * New helpers virNodeDeviceCapMatch, virNodeDeviceMatch. virNodeDeviceCapMatch looks up the list of all the caps the device support, to see if

[libvirt] [PATCH 43/45] list: Implement listAllSecrets

2012-08-17 Thread Osier Yang
Simply returns the object list. No filtering. src/secret/secret_driver.c: Implement listAllSecrets --- src/secret/secret_driver.c | 59 +++- 1 files changed, 58 insertions(+), 1 deletions(-) diff --git a/src/secret/secret_driver.c

[libvirt] [PATCH 45/45] list: Expose virConnectListAllSecrets to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Implementation for listAllSecrets. python/libvirt-override.c: Implementation for the wrapper.

[libvirt] [PATCH 33/45] list: Expose virConnectListAllNodeDevices to Python binding

2012-08-17 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * Implementation for listAllNodeDevices. python/libvirt-override.c: Implementation for the

Re: [libvirt] [PATCH 20/23] Enable systemd socket activation with virtlockd

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This enhancement virtlockd so that it can receive a pre-opened s/enhancement/enhances/ UNIX domain socket from systemd at launch time, and adds the systemd service/socket unit files *

Re: [libvirt] [PATCH 12/23] Add JSON serialization of virLockSpacePtr objects for process re-exec()

2012-08-17 Thread Eric Blake
On 08/16/2012 05:07 PM, Eric Blake wrote: On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add two new APIs virLockSpaceNewPostExecRestart and virLockSpacePreExecRestart which allow a virLockSpacePtr object to be created from a JSON object and

Re: [libvirt] [PATCH 21/23] Add support for re-exec() of virtlockd upon SIGUSR1

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virtlockd daemon maintains file locks on behalf of libvirtd and any VMs it is running. These file locks must be held for as long as any VM is running. If virtlockd itself ever quits, then it

Re: [libvirt] [PATCH 22/23] Add a virtlockd client as a lock driver impl

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This adds a 'lockd' lock driver which is just a client which talks to the lockd daemon to perform all locking. This will be the default lock driver for any hypervisor which needs one. *

Re: [libvirt] [PATCH 6/7] Forward Mode Hostdev network driver Implementation

2012-08-17 Thread Laine Stump
On 08/17/2012 10:11 AM, Shradha Shah wrote: I'll be posting a proposed replacement patch for this one in a few minutes. Please try it out as soon as possible. I haven't gone through 7/7 yet, but with the small changes I've squashed in elsewhere, plus the 3.5/7 I posted and the 6/7 refactor I'm

Re: [libvirt] [PATCH] Add support for setting VLANs on Open vSwitch ports

2012-08-17 Thread Laine Stump
On 08/17/2012 12:04 AM, Kyle Mestery wrote: Add the ability to support VLAN tags for Open vSwitch virtual port types. To accomplish this, modify virNetDevOpenvswitchAddPort and virNetDevTapCreateInBridgePort to take a virNetDevVlanPtr argument. When adding the port to the OVS bridge, setup

Re: [libvirt] [PATCH 23/23] Change the default QEMU lock manager to 'lockd'

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current default QEMU lock manager is the 'nop' lock manager, which obviously does not perform any locking. The new virtlockd daemon is able to work out of the box with zero configuration in

Re: [libvirt] [PATCH 00/23] Introduce a virtlockd daemon for disk locking

2012-08-17 Thread Eric Blake
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote: This is a long overdue update to a patch series I posted about a year ago https://www.redhat.com/archives/libvir-list/2011-July/msg00337.html There have been some major changes since that series Getting closer! I think the overall

Re: [libvirt] [PATCH] docs: Enhance documentation of log_filters

2012-08-17 Thread Jiri Denemark
On Fri, Aug 17, 2012 at 06:52:22 -0600, Eric Blake wrote: On 08/17/2012 06:20 AM, Jiri Denemark wrote: Also make sure documentation in libvirtd.conf matches the one from logging.html. --- daemon/libvirtd.conf | 9 ++--- docs/logging.html.in | 9 ++--- 2 files changed, 12

Re: [libvirt] [PATCH] conf: Fix ABI stability check for spicevmc channel

2012-08-17 Thread Jiri Denemark
On Fri, Aug 17, 2012 at 06:51:22 -0600, Eric Blake wrote: On 08/17/2012 06:20 AM, Jiri Denemark wrote: Change device type of a virtio channel from/to spicevmc is not a user visible change. However, spicevmc channels use different default target name than other virtio channels. To maintain

Re: [libvirt] [PATCH 1/3] Fix the indentions of libvirt.h.in

2012-08-17 Thread Osier Yang
On 2012年07月24日 17:50, Peter Krempa wrote: On 07/11/12 16:27, Osier Yang wrote: Substitute 2 spaces with 4 spaces instead. ACK, just whitespace change. Peter Thanks, pushed. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] selinux: Fix incorrect file label generation.

2012-08-17 Thread Viktor Mihajlovski
On 08/17/2012 04:28 PM, Eric Blake wrote: On 08/17/2012 08:18 AM, Osier Yang wrote: On 2012年08月17日 20:53, Viktor Mihajlovski wrote: This is an ad-hoc fix for the file label generation. It uses the base context role to determine whether to use the libvirt process context role. If this is

Re: [libvirt] [PATCH 01/45] list: Define new API virStorageListAllStoragePools

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: This introduces a new API to list the storage pool objects, 4 groups of flags are provided to filter the returned pools: * Active or not * Autostarting or not * Persistent or not * And the pool type. include/libvirt/libvirt.h.in:

Re: [libvirt] [PATCH 02/45] list: Add helpers for listing storage pool objects

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: src/conf/storage_conf.c: Add virStoragePoolMatch to filter the pools; Add virStoragePoolList to iterate over the pool objects with filter. src/conf/storage_conf.h: Declare virStoragePoolMatch, virStoragePoolList, and the macros for filters.

Re: [libvirt] [PATCH 03/45] list: Implement the RPC calls for virConnectListAllStoragePools

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: The RPC generator doesn't support returning list of object, this patch do s/patch do/patch does/ the work manually. * daemon/remote.c: Implement the server side handler remoteDispatchConnectListAllStoragePools *

Re: [libvirt] [PATCH 05/45] list: Implement listAllStoragePools for test driver

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: src/test/test_driver.c: Implement listAllStoragePools --- src/test/test_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH 04/45] list: Implement listAllStoragePools for storage driver

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: src/storage/storage_driver.c: Implement listAllStoragePools. --- src/storage/storage_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 06/45] list: Add helper to convert strings separated by ', ' to array

2012-08-17 Thread Eric Blake
On 08/17/2012 09:38 AM, Osier Yang wrote: tools/virsh.c: New helper function vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++- tools/virsh.c| 45 + 2 files

  1   2   >