[libvirt] [PATCH v3 2/9] New functions for virBitmap

2012-09-13 Thread Hu Tao
In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This patch extends virBitmap, and convert those codes to use virBitmap in subsequent patches. --- .gitignore |1 + src/libvirt_private.syms | 11 ++

[libvirt] [PATCH v3 1/9] bitmap: add a new member variable map_len

2012-09-13 Thread Hu Tao
Add a new member variable map_len to store map len of bitmap. and rename size to max_bit accordingly. --- src/util/bitmap.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/util/bitmap.c b/src/util/bitmap.c index cd52802..434c443 100644 ---

[libvirt] [PATCH v3 5/9] use virBitmap to store numa nodemask info.

2012-09-13 Thread Hu Tao
--- src/conf/domain_conf.c | 24 +--- src/conf/domain_conf.h |2 +- src/lxc/lxc_controller.c | 25 src/parallels/parallels_driver.c |2 +- src/qemu/qemu_cgroup.c |7 ++--- src/qemu/qemu_cgroup.h |2 +-

[libvirt] [PATCH v3 7/9] use virBitmap to store cells' cpumask info.

2012-09-13 Thread Hu Tao
--- src/conf/cpu_conf.c | 17 ++--- src/conf/cpu_conf.h |3 ++- src/qemu/qemu_command.c | 43 +++ 3 files changed, 15 insertions(+), 48 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 87e9540..48d5740

[libvirt] [PATCH v3 6/9] use virBitmap to store cpumask info.

2012-09-13 Thread Hu Tao
--- src/conf/domain_conf.c | 24 +--- src/conf/domain_conf.h |3 +-- src/lxc/lxc_controller.c | 14 ++ src/parallels/parallels_driver.c |3 +-- src/qemu/qemu_process.c | 12 +--- src/test/test_driver.c

[libvirt] [PATCH v3 0/9] improve virBitmap

2012-09-13 Thread Hu Tao
In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This series extends virBitmap, and convert those codes to use virBitmap. patch 01 is based on https://www.redhat.com/archives/libvir-list/2012-September/msg00644.html

[libvirt] [PATCH v3 9/9] remove virDomainCpuSetFormat and virDomainCpuSetParse

2012-09-13 Thread Hu Tao
virBitmap is recommanded to store cpuset info, and virBitmapFormat/virBitmapParse can do the format/parse jobs. --- src/conf/domain_conf.c | 196 -- src/conf/domain_conf.h |7 -- src/libvirt_private.syms |2 - 3 files changed, 205

[libvirt] [PATCH v3 3/9] use virBitmap to store cpupin info

2012-09-13 Thread Hu Tao
--- src/conf/domain_conf.c | 148 +++--- src/conf/domain_conf.h |6 +- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c |3 +- src/qemu/qemu_driver.c | 29 + src/qemu/qemu_process.c | 20 --- 6 files changed, 80

[libvirt] [PATCH v3 4/9] use virBitmap to store cpu affinity info

2012-09-13 Thread Hu Tao
--- src/lxc/lxc_controller.c | 23 + src/qemu/qemu_driver.c | 62 - src/qemu/qemu_process.c | 85 -- src/util/processinfo.c | 36 +++- src/util/processinfo.h |9 ++--- 5

[libvirt] [PATCH v3 8/9] use virBitmap to store nodeinfo.

2012-09-13 Thread Hu Tao
--- src/nodeinfo.c | 26 +++--- src/nodeinfo.h |6 +++--- src/qemu/qemu_driver.c | 19 --- 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index e3d4a24..803b261 100644 ---

[libvirt] [PATCH 6/7 v5] virsh: Don't motify the const string

2012-09-13 Thread Osier Yang
This improve helper vshStringToArray to accept const string as argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it. v4 - v5: * Except both are PATCH 6/7, totally different patches. --- tools/virsh-domain.c |2 +- tools/virsh-pool.c

[libvirt] [PATCH 1/7 v5] list: Define new API virConnectListAllNodeDevices

2012-09-13 Thread Osier Yang
This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py: Skip auto-generating src/driver.h:

[libvirt] [PATCH 7/7 v5] list: Use virConnectListAllNodeDevices in virsh

2012-09-13 Thread Osier Yang
tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to older APIs if it's not supported. * Change

Re: [libvirt] [PATCH 7/7] list: Use virConnectListAllNodeDevices in virsh

2012-09-13 Thread Osier Yang
On 2012年09月07日 06:05, Peter Krempa wrote: On 09/05/12 07:34, Osier Yang wrote: tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Guido Günther
On Wed, Sep 12, 2012 at 03:40:15PM -0600, Eric Blake wrote: On 09/12/2012 01:14 PM, Laine Stump wrote: On 09/10/2012 06:14 PM, Eric Blake wrote: Recent spec file changes ensure that in distro situations, netcf and libvirt will link against the same libnl in order to avoid dumping core.

Re: [libvirt] question about the commands: domhostname and hostname

2012-09-13 Thread Guido Günther
On Wed, Sep 12, 2012 at 08:40:12AM +0200, Martin Kletzander wrote: On 09/12/2012 07:59 AM, Li Zhang wrote: Sorry for wrong subject prefix of my mail, correct it. -:) The [libvirt] tag in the prefix is done automatically, you don't have to do that ;) On Wed, Sep 12, 2012 at 1:57 PM,

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Osier Yang
On 2012年09月13日 15:15, Guido Günther wrote: On Wed, Sep 12, 2012 at 03:40:15PM -0600, Eric Blake wrote: On 09/12/2012 01:14 PM, Laine Stump wrote: On 09/10/2012 06:14 PM, Eric Blake wrote: Recent spec file changes ensure that in distro situations, netcf and libvirt will link against the same

[libvirt] [PATCH 4/4] doc: update usb redirection filter infomation on formatdomain.html

2012-09-13 Thread Guannan Ren
--- docs/formatdomain.html.in | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 503685f..fc32c70 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2136,6

[libvirt] [PATCH 2/4] qemu: build USB redirection filter qemu command line

2012-09-13 Thread Guannan Ren
Input XML snip: redirdev bus='usb' type='spicevmc' address type='usb' bus='0' port='4'/ /redirdev redirfilter usbdev class='0x08' vendor='0x1234' product='0xbeef' \ version='2.00' allow='yes'/ usbdev class='-1' vendor='-1' product='-1' version='-1' allow='no'/ /redirfilter will

[libvirt] [PATCH 1/4] qemu: define and parse USB redirection filter XML

2012-09-13 Thread Guannan Ren
https://bugzilla.redhat.com/show_bug.cgi?id=795929 http://git.qemu.org/?p=qemu.git;a=commitdiff;h=6af165892cf900291046f1d25f95416f379504c2 This patch define and parse the input XML of USB redirection filter. devices ... redirdev bus='usb' type='spicevmc' address type='usb' bus='0' port='4'/

[libvirt] [PATCHv2 0/4]add support usb redirection filter

2012-09-13 Thread Guannan Ren
v2 fixed: (1) type int-size_t (2) Don't output filter attributes with default -1 value in XML. (3) Treat 0x0(0 decimal) as valid value for USB vendorID and productID as well as USB classID and bcdDevice code. (4) doc fixed. BZ RFE https://bugzilla.redhat.com/show_bug.cgi?id=795929 qemu

Re: [libvirt] [libvirt-designer][PATCH 0/3] Another cleanup

2012-09-13 Thread Martin Kletzander
On 09/12/2012 05:09 PM, Michal Privoznik wrote: to address Chritophe's improvements hints. Michal Privoznik (3): init_check: Ignore DB loading errors get_supported_disk_bus_types: NULL is valid list add_disk_full: Only set error if !NULL libvirt-designer/libvirt-designer-domain.c

Re: [libvirt] [libvirt-designer][PATCH 0/3] Another cleanup

2012-09-13 Thread Christophe Fergeau
Hey, On Wed, Sep 12, 2012 at 05:09:32PM +0200, Michal Privoznik wrote: to address Chritophe's improvements hints. Ah thanks for polishing these small nits, series looks good to me too. Christophe pgpWJyI3DbVfX.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [libvirt-glib][PATCH v4 2/2] gobject: Introduce gvir_connection_get_version

2012-09-13 Thread Christophe Fergeau
Hey, Series looks good to me, ACK to both patches. Christophe On Wed, Sep 12, 2012 at 07:42:56PM +0200, Michal Privoznik wrote: which is basically a wrapper for virConnectGetVersion(). --- examples/conn-test.c | 13 +

[libvirt] [PATCH] virsh: Fix version numbers in comments

2012-09-13 Thread Osier Yang
And redundant error resetting. Pushed under trivial rule. --- tools/virsh-network.c |8 +++- tools/virsh-pool.c|8 +++- tools/virsh-volume.c |8 +++- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index

Re: [libvirt] [PATCHv2 0/4]add support usb redirection filter

2012-09-13 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 03:25:44PM +0800, Guannan Ren wrote: v2 fixed: (1) type int-size_t (2) Don't output filter attributes with default -1 value in XML. (3) Treat 0x0(0 decimal) as valid value for USB vendorID and productID as well as USB classID and bcdDevice code. (4) doc fixed.

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 03:19:40PM +0800, Osier Yang wrote: On 2012年09月13日 15:15, Guido Günther wrote: On Wed, Sep 12, 2012 at 03:40:15PM -0600, Eric Blake wrote: On 09/12/2012 01:14 PM, Laine Stump wrote: On 09/10/2012 06:14 PM, Eric Blake wrote: Recent spec file changes ensure that in

Re: [libvirt] [libvirt-glib][PATCH v4 2/2] gobject: Introduce gvir_connection_get_version

2012-09-13 Thread Michal Privoznik
On 13.09.2012 11:00, Christophe Fergeau wrote: Hey, Series looks good to me, ACK to both patches. Christophe Thanks, pushed now. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 0/4]add support usb redirection filter

2012-09-13 Thread Guannan Ren
On 09/13/2012 05:14 PM, Daniel P. Berrange wrote: On Thu, Sep 13, 2012 at 03:25:44PM +0800, Guannan Ren wrote: v2 fixed: (1) type int-size_t (2) Don't output filter attributes with default -1 value in XML. (3) Treat 0x0(0 decimal) as valid value for USB vendorID and productID as well as

[libvirt] [PATCH v2] snapshot: fix rollback failure in transaction mode

2012-09-13 Thread Guannan Ren
BZ:https://bugzilla.redhat.com/show_bug.cgi?id=843372 when qemu supports the 'transaction' monitor command, and libvirt's --reuse-ext flag was not specified, libvirt created a stub file with zero size in first place. After the failure of QEMU transaction command performing qcow2 snapshots on more

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
Laine, Please find my comments inline. Regards, Shradha Shah On 09/11/2012 08:07 PM, Laine Stump wrote: On 09/07/2012 12:12 PM, Shradha Shah wrote: This patch series adds the support for interface-type=hostdev-hybrid and forward mode=hostdev-hybrid. The hostdev-hybrid mode makes migration

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
* At migration time, since guests with attached pci-passthrough devices can't be migrated, the pci-passthrough device (which is found by searching the hostdev array for items with the ephemeral flag set) is detached. This reduces the bond interface on the guest to only having the virtio-net

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
Please find my comments inline. Many Thanks, Regards, Shradha Shah On 09/12/2012 08:01 PM, Laine Stump wrote: On 09/12/2012 05:59 AM, Daniel P. Berrange wrote: On Tue, Sep 11, 2012 at 03:07:25PM -0400, Laine Stump wrote: On 09/07/2012 12:12 PM, Shradha Shah wrote: This patch series adds the

Re: [libvirt] [PATCH 3/8] Hostdev-hybrid mode requires a direct linkdev and direct mode.

2012-09-13 Thread Shradha Shah
On 09/11/2012 08:15 PM, Laine Stump wrote: (not a full review yet, but a couple of things I noticed in passing) On 09/07/2012 12:15 PM, Shradha Shah wrote: In this mode the guest contains a Virtual network device along with a SRIOV VF passed through to the guest as a pci device. ---

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Daniel P. Berrange
On Wed, Sep 12, 2012 at 03:01:08PM -0400, Laine Stump wrote: On 09/12/2012 05:59 AM, Daniel P. Berrange wrote: then I have to wonder why we need to add all this code for a new hybrid device type. It seems to me like we can do all this already simply by listing one virtio device and one

Re: [libvirt] [PATCH 10/20] Fix data types used for list sizes in QEMU capabilities

2012-09-13 Thread Eric Blake
On 09/12/2012 10:14 PM, Eric Blake wrote: On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The QEMU capabilities APIs used a misc of 'int' and 'unsigned int' for variables relating to array sizes. Change all these to use 'size_t' Signed-off-by:

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Eric Blake
On 09/12/2012 10:46 PM, Osier Yang wrote: On 2012年09月11日 06:14, Eric Blake wrote: Recent spec file changes ensure that in distro situations, netcf and libvirt will link against the same libnl in order to avoid dumping core. But for every-day development, if you are F17 and have the

Re: [libvirt] [PATCH] build: Fix typo which causes build failure

2012-09-13 Thread Eric Blake
On 09/12/2012 10:47 PM, Osier Yang wrote: Pushed under build-breaker rule. What was the break? This is the wrong fix, and should be reverted so that we can apply the correct fix. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac

Re: [libvirt] [PATCH 10/20] Fix data types used for list sizes in QEMU capabilities

2012-09-13 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 06:12:47AM -0600, Eric Blake wrote: On 09/12/2012 10:14 PM, Eric Blake wrote: On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The QEMU capabilities APIs used a misc of 'int' and 'unsigned int' for variables relating

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Eric Blake
On 09/13/2012 01:19 AM, Osier Yang wrote: configure:66413: result: no No package 'libnl-3.0' found configure:66429: error: Package requirements (libnl-3.0) were not met: Full log is at: http://honk.sigxcpu.org:8001/job/libvirt-build/60/console I didn't have a chance to have a closer look

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Eric Blake
On 09/13/2012 01:15 AM, Guido Günther wrote: Since this went in ./configure fails on Debian with a netcf linked against libnl1: Where does libnl.so live on your platform? Is it just a matter of expanding the for loop to find the library to run ldd on? configure:66413: result: no No

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-13 Thread Daniel Veillard
On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how to tell the main maven site to refetch ? Even

[libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread =?UTF-8?q?Guido=20G=C3=BCnther?=
to fix libnl detection --- Thanks Eric! On Thu, Sep 13, 2012 at 06:18:39AM -0600, Eric Blake wrote: On 09/13/2012 01:15 AM, Guido Günther wrote: Since this went in ./configure fails on Debian with a netcf linked against libnl1: Where does libnl.so live on your platform? Is it just a

[libvirt] Release of libvirt-java-0.4.9

2012-09-13 Thread Daniel Veillard
New version of the Java bindings are available, I know that there is bugs being chased ATM but I push this release to provide the change of licence from LGPLv2+ to MIT needed by the CloudStack folks (that was done after getting positive feedback from previous contributors). Release available

Re: [libvirt] [PATCH 10/20] Fix data types used for list sizes in QEMU capabilities

2012-09-13 Thread Eric Blake
On 09/13/2012 06:17 AM, Daniel P. Berrange wrote: Spoke too soon; I'm getting a test coredump: TEST: qemuxml2argvtest .../bin/sh: line 5: 19492 Segmentation fault abs_top_builddir=`cd '..'; pwd` abs_top_srcdir=`cd '..'; pwd` abs_builddir=`pwd` abs_srcdir=`cd '.'; pwd` CONFIG_HEADER=`cd

Re: [libvirt] [PATCH 04/20] Remove upfront check for hmp - just try it cope with failure

2012-09-13 Thread Daniel P. Berrange
On Tue, Sep 11, 2012 at 05:59:06PM -0600, Eric Blake wrote: On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Don't bother checking for the existance of the HMP passthrough command. Just try to execute it, and propagate the failure. And

Re: [libvirt] [PATCH] parallels: implement containers creation

2012-09-13 Thread Daniel Veillard
On Wed, Sep 12, 2012 at 04:40:54PM +0400, Dmitry Guryanov wrote: Add separate function parallelsCreateCt, which creates container. Also add example xml configuration domain-parallels-ct-simple.xml. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c

[libvirt] [PATCH v2] Remove upfront check for hmp - just try it cope with failure

2012-09-13 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Don't bother checking for the existance of the HMP passthrough command. Just try to execute it, and propagate the failure. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_monitor.c | 20 +-

[libvirt] [PATCH] Don't overwrite errors raised by qemuMonitorHMPCommand

2012-09-13 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The qemuMonitorHMPCommand() API and things it calls will report a wide variety of errors. The QEMU text monitor should not be overwriting these errors Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_monitor_text.c | 335

Re: [libvirt] [PATCH v3 2/9] New functions for virBitmap

2012-09-13 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 02:03:20PM +0800, Hu Tao wrote: In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This patch extends virBitmap, and convert those codes to use virBitmap in subsequent patches. --- .gitignore

Re: [libvirt] [libvirt-designer][PATCH 0/3] Another cleanup

2012-09-13 Thread Michal Privoznik
On 13.09.2012 10:57, Christophe Fergeau wrote: Hey, On Wed, Sep 12, 2012 at 05:09:32PM +0200, Michal Privoznik wrote: to address Chritophe's improvements hints. Ah thanks for polishing these small nits, series looks good to me too. Christophe Thank you guys, pushed. Michal --

[libvirt] [libvirt-designer][PATCH v2 1/4] virtxml: Init variables

2012-09-13 Thread Michal Privoznik
to avoid their uninitialized usage. --- examples/virtxml.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/virtxml.c b/examples/virtxml.c index 9783ba6..b0c3a77 100644 --- a/examples/virtxml.c +++ b/examples/virtxml.c @@ -97,7 +97,7 @@ print_oses(const gchar

[libvirt] [libvirt-designer][PATCH v2 0/4] Yet another functional extension

2012-09-13 Thread Michal Privoznik
This time aimed on virtxml tool to make it user friendlier a little bit. Michal Privoznik (4): virtxml: Init variables virtxml: Detect OS from given ISO virtxml: Detect platform from libvirt connection URI Implement resources setting configure.ac |2 +-

[libvirt] [PATCH 1/2] Add support for EOI with APIC

2012-09-13 Thread Martin Kletzander
New options is added to support EOI (End of Interrupt) exposure for guests. As it makes sense only when APIC is enabled, I added this into the apic element in features because this should be tri-state option (cannot be handled as standalone feature). --- docs/formatdomain.html.in | 7 +++

[libvirt] [libvirt-designer][PATCH v2 2/4] virtxml: Detect OS from given ISO

2012-09-13 Thread Michal Privoznik
In some cases telling OS version is redundant as ISO image with specified OS is passed some arguments later as disk. Don't require --os then. --- examples/virtxml.c | 110 +-- 1 files changed, 105 insertions(+), 5 deletions(-) diff --git

[libvirt] [libvirt-designer][PATCH v2 3/4] virtxml: Detect platform from libvirt connection URI

2012-09-13 Thread Michal Privoznik
as in nearly all cases users will install the guest on current libvirt we've just obtained capabilities from. --- configure.ac |2 +- examples/virtxml.c | 180 2 files changed, 139 insertions(+), 43 deletions(-) diff --git

[libvirt] [PATCH 2/2] qemu: Add support for EOI with APIC

2012-09-13 Thread Martin Kletzander
This patch adds full support for EOI setting for domains. Because this is CPU feature (flag), the model needs to be added even when it's not specified. Fortunately this problem was already solved with kvmclock, so this patch simply abuses that. And due to the size of the patch (17 lines) I dared

[libvirt] [libvirt-designer][PATCH v2 4/4] Implement resources setting

2012-09-13 Thread Michal Privoznik
Users can choose between minimum and recommended values for VCPU count and amount of RAM. Moreover, recommended values should inherit defaults from the minimum. --- examples/virtxml.c | 12 libvirt-designer/libvirt-designer-domain.c | 91

Re: [libvirt] [PATCH] Don't overwrite errors raised by qemuMonitorHMPCommand

2012-09-13 Thread Daniel Veillard
On Thu, Sep 13, 2012 at 02:29:50PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The qemuMonitorHMPCommand() API and things it calls will report a wide variety of errors. The QEMU text monitor should not be overwriting these errors Signed-off-by: Daniel P.

[libvirt] [PATCH] Use 'qemu-system-i386' as binary instead of 'qemu'.

2012-09-13 Thread Richard W.M. Jones
I have added the attached patch to Fedora because Fedora (only?) renames 'qemu' to 'qemu-system-i386'. As a result of this, on 32 bit Fedora would run 'qemu-system-x86_64 [...] -cpu qemu32'. In fact this caused no issues (I originally added the patch because I suspected this was a cause of

Re: [libvirt] [PATCH] build: Fix typo which causes build failure

2012-09-13 Thread Osier Yang
On 2012年09月13日 20:14, Eric Blake wrote: On 09/12/2012 10:47 PM, Osier Yang wrote: Pushed under build-breaker rule. What was the break? This is the wrong fix, and should be reverted so that we can apply the correct fix. same error as Guido. My machine is x86_64 + fc16, which netcf is linked

Re: [libvirt] [PATCH 2/2] qemu: Add support for EOI with APIC

2012-09-13 Thread Michal Privoznik
On 13.09.2012 16:12, Martin Kletzander wrote: This patch adds full support for EOI setting for domains. Because this is CPU feature (flag), the model needs to be added even when it's not specified. Fortunately this problem was already solved with kvmclock, so this patch simply abuses that.

Re: [libvirt] [PATCH 1/2] Add support for EOI with APIC

2012-09-13 Thread Michal Privoznik
On 13.09.2012 16:12, Martin Kletzander wrote: New options is added to support EOI (End of Interrupt) exposure for guests. As it makes sense only when APIC is enabled, I added this into the apic element in features because this should be tri-state option (cannot be handled as standalone

Re: [libvirt] [PATCH 1/2] Add support for EOI with APIC

2012-09-13 Thread Daniel Veillard
On Thu, Sep 13, 2012 at 04:12:01PM +0200, Martin Kletzander wrote: New options is added to support EOI (End of Interrupt) exposure for guests. As it makes sense only when APIC is enabled, I added this into the apic element in features because this should be tri-state option (cannot be handled

Re: [libvirt] [PATCH 0/4 v2] Support to set disk wwn

2012-09-13 Thread Osier Yang
Ping. On 2012年09月11日 16:57, Osier Yang wrote: v1 - v2: * Validate wwn while parsing * Error out earlier if (disk-device == lun disk-wwn), no logic change. This introduces new elementwwn for disk, to allow to set wwn (just like setting serial number) for the virtual disk (Only QEMU

Re: [libvirt] [PATCH v2] Fix libvirtd crash possibility

2012-09-13 Thread Eric Blake
On 09/12/2012 05:00 PM, Eric Blake wrote: On 09/12/2012 04:44 PM, Martin Kletzander wrote: When generating RPC protocol messages, it's strictly needed to have continuousline of numbers or RPC messages. However in case anyone s/continuousline/a continuous line/ tries backporting some

Re: [libvirt] [PATCH 0/7] New APIs to get/set node shared memory parameters

2012-09-13 Thread Osier Yang
Ping. On 2012年09月10日 20:08, Osier Yang wrote: As a result of RFC: https://www.redhat.com/archives/libvir-list/2012-August/msg01998.html, this adds two new APIs (virNode{Get,Set}SharedMemoryParameters) to get and set the host shared memory tunables (ksm under linux). Osier Yang (7): Improve

Re: [libvirt] [PATCH] Use 'qemu-system-i386' as binary instead of 'qemu'.

2012-09-13 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 03:51:01PM +0100, Richard W.M. Jones wrote: I have added the attached patch to Fedora because Fedora (only?) renames 'qemu' to 'qemu-system-i386'. As a result of this, on 32 bit Fedora would run 'qemu-system-x86_64 [...] -cpu qemu32'. In fact this caused no issues (I

Re: [libvirt] [PATCH] Use 'qemu-system-i386' as binary instead of 'qemu'.

2012-09-13 Thread Richard W.M. Jones
On Thu, Sep 13, 2012 at 04:02:17PM +0100, Daniel P. Berrange wrote: On Thu, Sep 13, 2012 at 03:51:01PM +0100, Richard W.M. Jones wrote: I have added the attached patch to Fedora because Fedora (only?) renames 'qemu' to 'qemu-system-i386'. As a result of this, on 32 bit Fedora would run

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote: I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which is already in a multiarch directory (`/usr/lib/i386-linux-gnu/libnl.so). So this fixes it: configure.ac |2 +- 1 file changed, 1

Re: [libvirt] [PATCH v2] snapshot: fix rollback failure in transaction mode

2012-09-13 Thread Eric Blake
On 09/13/2012 03:41 AM, Guannan Ren wrote: BZ:https://bugzilla.redhat.com/show_bug.cgi?id=843372 when qemu supports the 'transaction' monitor command, and libvirt's --reuse-ext flag was not specified, libvirt created a stub file with zero size in first place. After the failure of QEMU

Re: [libvirt] [PATCH v2] Remove upfront check for hmp - just try it cope with failure

2012-09-13 Thread Eric Blake
On 09/13/2012 07:29 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Don't bother checking for the existance of the HMP passthrough command. Just try to execute it, and propagate the failure. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 1/8] RNG updates, new xml parser/formatter code for interface type=hostdev-hybrid

2012-09-13 Thread Laine Stump
(a couple of things I noticed in passing, which are useful general info whether or not we take these patches in their current form) On 09/07/2012 12:14 PM, Shradha Shah wrote: This patch introduces the new interface type='hostdev-hybrid' along with attribute managed Includes updates to the

[libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
The 'def-target.addr' hasn't been initialized in virDomainChrDefNew() and its value is always '0x', in addition, the following test scenario hasn't also include 'port' element in channel XML block, so the branch 'if (addrStr == NULL)' is hit in virDomainChrDefParseTargetXML(), the

Re: [libvirt] [PATCH 11/20] Introduce a API for creating QEMU capabilities for a binary

2012-09-13 Thread Eric Blake
On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a qemuCapsNewForBinary() API which creates a new QEMU capabilities object, populated with data relating to a specific QEMU binary. The qemuCaps object is also given a timestamp, which

Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
- Original Message - From: Alex Jia a...@redhat.com To: libvir-list@redhat.com Cc: Alex Jia a...@redhat.com Sent: Friday, September 14, 2012 12:23:56 AM Subject: [libvirt][PATCH] conf: avoid libvirt crash with empty address guestfwd channel The 'def-target.addr' hasn't been initialized

Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Eric Blake
On 09/13/2012 10:23 AM, Alex Jia wrote: The 'def-target.addr' hasn't been initialized in virDomainChrDefNew() and its value is always '0x', in addition, the following test scenario hasn't also include 'port' element in channel XML block, so the branch 'if (addrStr == NULL)' is hit in

Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
Thanks and push now. -- Regards, Alex - Original Message - From: Eric Blake ebl...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, September 14, 2012 12:38:39 AM Subject: Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread Eric Blake
On 09/13/2012 09:36 AM, Guido Günther wrote: On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote: I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which is already in a multiarch directory (`/usr/lib/i386-linux-gnu/libnl.so). So this fixes it:

Re: [libvirt] [PATCH] build: Fix typo which causes build failure

2012-09-13 Thread Eric Blake
On 09/13/2012 08:53 AM, Osier Yang wrote: On 2012年09月13日 20:14, Eric Blake wrote: On 09/12/2012 10:47 PM, Osier Yang wrote: Pushed under build-breaker rule. What was the break? This is the wrong fix, and should be reverted so that we can apply the correct fix. same error as Guido. My

[libvirt] [PATCH] qemu: wait for SPICE to migrate

2012-09-13 Thread Michal Privoznik
Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its internal state to the destination. Once it's done, it fires

Re: [libvirt] [PATCH] qemu: wait for SPICE to migrate

2012-09-13 Thread Eric Blake
On 09/13/2012 11:06 AM, Michal Privoznik wrote: Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its internal state to the

[libvirt] libvirt plans: dns support for IPv6?

2012-09-13 Thread Gene Czarcinski
I would like to know what the plans are for supporting dns for virtual guests with only IPv6. My objective is to be able to reference a virtual guest for the host ... doing ssh, scp, etc. such functions work just fine if you specify the ip-address but, after a while, those ip-addresses are

Re: [libvirt] libvirt plans: dns support for IPv6?

2012-09-13 Thread Laine Stump
On 09/13/2012 02:00 PM, Gene Czarcinski wrote: I would like to know what the plans are for supporting dns for virtual guests with only IPv6. My objective is to be able to reference a virtual guest for the host ... doing ssh, scp, etc. such functions work just fine if you specify the

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-13 Thread Laine Stump
On 09/12/2012 11:08 PM, Kyle Mestery (kmestery) wrote: Hi Laine: I'm in the process of reworking this patch along the lines you and Daniel have provided input towards. I defined some helper functions in virnetdevopenvswitch.c, but when calling them from qemu_migration.c, the build is

Re: [libvirt] libvirt plans: dns support for IPv6?

2012-09-13 Thread Gene Czarcinski
On 09/13/2012 04:05 PM, Laine Stump wrote: On 09/13/2012 02:00 PM, Gene Czarcinski wrote: I would like to know what the plans are for supporting dns for virtual guests with only IPv6. My objective is to be able to reference a virtual guest for the host ... doing ssh, scp, etc. such functions

Re: [libvirt] [PATCH v4 0/5] Per-guest configurable user/group for QEMU processes

2012-09-13 Thread Marcelo Cerri
Hi, Any comments about that? Regards, Marcelo On Tue, Sep 11, 2012 at 02:13:38PM -0400, Corey Bryant wrote: Are there any other requirements that need to be taken care of to enable execution of QEMU guests under separate unprivileged user IDs (ie. DAC isolation)? At this point, this patch

Re: [libvirt] [PATCH 0/7] New APIs to get/set node shared memory parameters

2012-09-13 Thread Eric Blake
On 09/10/2012 06:08 AM, Osier Yang wrote: As a result of RFC: https://www.redhat.com/archives/libvir-list/2012-August/msg01998.html, this adds two new APIs (virNode{Get,Set}SharedMemoryParameters) to get I still think this name is too long; virNode{Get,Set}MemoryParameters seems just fine, and

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 10:46:30AM -0600, Eric Blake wrote: On 09/13/2012 09:36 AM, Guido Günther wrote: On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote: I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which is already in a multiarch

Re: [libvirt] [PATCH 1/7] Improve virTypedParameterValidateSet

2012-09-13 Thread Eric Blake
On 09/10/2012 06:08 AM, Osier Yang wrote: Assume not only domain object will use it. --- src/libvirt.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-13 Thread Kyle Mestery (kmestery)
On Sep 13, 2012, at 3:09 PM, Laine Stump wrote: On 09/12/2012 11:08 PM, Kyle Mestery (kmestery) wrote: Hi Laine: I'm in the process of reworking this patch along the lines you and Daniel have provided input towards. I defined some helper functions in virnetdevopenvswitch.c, but when

Re: [libvirt] [PATCH 0/7] New APIs to get/set node shared memory parameters

2012-09-13 Thread Osier Yang
On 2012年09月14日 05:04, Eric Blake wrote: On 09/10/2012 06:08 AM, Osier Yang wrote: As a result of RFC: https://www.redhat.com/archives/libvir-list/2012-August/msg01998.html, this adds two new APIs (virNode{Get,Set}SharedMemoryParameters) to get I still think this name is too long;

[libvirt] [PATCH v3] snapshot: fix rollback failure in transaction mode

2012-09-13 Thread Guannan Ren
BZ:https://bugzilla.redhat.com/show_bug.cgi?id=843372 when qemu supports the 'transaction' monitor command, and libvirt's --reuse-ext flag was not specified, libvirt created a stub file with zero size in first place. After the failure of QEMU transaction command performing qcow2 snapshots on more

Re: [libvirt] [PATCH v3] snapshot: fix rollback failure in transaction mode

2012-09-13 Thread Eric Blake
On 09/13/2012 08:52 PM, Guannan Ren wrote: BZ:https://bugzilla.redhat.com/show_bug.cgi?id=843372 when qemu supports the 'transaction' monitor command, and libvirt's --reuse-ext flag was not specified, libvirt created a stub file with zero size in first place. After the failure of QEMU

Re: [libvirt] [PATCH 1/7] Improve virTypedParameterValidateSet

2012-09-13 Thread Osier Yang
On 2012年09月14日 05:05, Eric Blake wrote: On 09/10/2012 06:08 AM, Osier Yang wrote: Assume not only domain object will use it. --- src/libvirt.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) ACK. Thanks, I pushed this first. Regards, Osier --

Re: [libvirt] [PATCH v3] snapshot: fix rollback failure in transaction mode

2012-09-13 Thread Guannan Ren
On 09/14/2012 11:00 AM, Eric Blake wrote: On 09/13/2012 08:52 PM, Guannan Ren wrote: BZ:https://bugzilla.redhat.com/show_bug.cgi?id=843372 when qemu supports the 'transaction' monitor command, and libvirt's --reuse-ext flag was not specified, libvirt created a stub file with zero size in first

Re: [libvirt] [PATCH 2/7] shared_memory: Define the APIs to get/set shared memory parameters

2012-09-13 Thread Eric Blake
On 09/10/2012 06:08 AM, Osier Yang wrote: * include/libvirt/libvirt.h.in: (Add macros for the param fields, declare the APIs). * src/driver.h: (New methods for the driver struct) * src/libvirt.c: (Implement the public APIs) * src/libvirt_public.syms: (Export the public symbols) ---

[libvirt] [PATCH 2/7 v2] shared_memory: Define the APIs to get/set shared memory parameters

2012-09-13 Thread Osier Yang
* include/libvirt/libvirt.h.in: (Add macros for the param fields, declare the APIs). * src/driver.h: (New methods for the driver struct) * src/libvirt.c: (Implement the public APIs) * src/libvirt_public.syms: (Export the public symbols) --- include/libvirt/libvirt.h.in | 63

Re: [libvirt] [PATCH 2/7] shared_memory: Define the APIs to get/set shared memory parameters

2012-09-13 Thread Osier Yang
On 2012年09月14日 11:26, Eric Blake wrote: On 09/10/2012 06:08 AM, Osier Yang wrote: * include/libvirt/libvirt.h.in: (Add macros for the param fields, declare the APIs). * src/driver.h: (New methods for the driver struct) * src/libvirt.c: (Implement the public APIs) * src/libvirt_public.syms: