Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:28 AM, Osier Yang jy...@redhat.com wrote: [...] It's bad that we don't have sheepdog pool documented in [1] when doing the patches. But the good thing is there are some documents for it in [2]. If you see the document is not enough. You can check the RNG schema to

Re: [libvirt] [PATCH 3/6] Introduce new XMLs to specify disk source using storage pool/vol

2013-01-28 Thread Daniel P. Berrange
On Mon, Jan 28, 2013 at 12:27:15PM +0800, Osier Yang wrote: On 2013年01月26日 03:12, Laine Stump wrote: On 01/24/2013 10:44 PM, Osier Yang wrote: So you agreed with just using the pool name and volume name? I think so. Unless you can think of a situation where the pool or volume name

Re: [libvirt] [PATCH] LXC: create directory /dev/shm automatically

2013-01-28 Thread Daniel P. Berrange
On Mon, Jan 28, 2013 at 02:37:11PM +0800, Gao feng wrote: Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as shm_open/sem_open will create files under dir /dev.(since /dev is mounted as tmpfs) Through these api still useable in container,but this cause

[libvirt] Candidate Release 2 of libvirt-1.0.2

2013-01-28 Thread Daniel Veillard
I have just tagged the rc2 in git and pushed the associated tarball and rpms for F17 to the FTP area: ftp://libvirt.org/libvirt/ Seems to work just fine for m limited testing, but please give it a try, and let's limit commits to only bug fixes until the release. I think I will push 1.0.2

Re: [libvirt] [Libvirt-announce] Candidate Release 2 of libvirt-1.0.2

2013-01-28 Thread Justin Clift
On 28/01/2013, at 12:22 PM, Daniel Veillard wrote: I have just tagged the rc2 in git and pushed the associated tarball and rpms for F17 to the FTP area: ftp://libvirt.org/libvirt/ This seems ok on OSX 10.7 too. :) + Justin -- Aeolus Cloud Evangelist http://www.aeolusproject.org --

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread MORITA Kazutaka
3, Morita said if QEMU does not support Sheepdog then Libvirt will not support Sheepdog but i am not clear about their communicating details. Could you please tell me their communicating details? If QEMU doesn't officially support your file system, we cannot use your system from VMs without

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread Daniel P. Berrange
On Mon, Jan 28, 2013 at 10:32:42PM +0900, MORITA Kazutaka wrote: 3, Morita said if QEMU does not support Sheepdog then Libvirt will not support Sheepdog but i am not clear about their communicating details. Could you please tell me their communicating details? If QEMU doesn't

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:32 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: 3, Morita said if QEMU does not support Sheepdog then Libvirt will not support Sheepdog but i am not clear about their communicating details. Could you please tell me their communicating details? If QEMU

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:32 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: 3, Morita said if QEMU does not support Sheepdog then Libvirt will not support Sheepdog but i am not clear about their communicating details. Could you please tell me their communicating details? If QEMU

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:36 PM, Daniel P. Berrange berra...@redhat.com wrote: [...] I agree with that. I don't see this being a part of libvirt until the QEMU community accepts it into the mainline QEMU GIT tree. So I'd focus on the latter first. After HLFS has a good performance, we will

Re: [libvirt] [PATCH 2/2] conf: Fix leaks in virNetworkObjUpdateParseFile

2013-01-28 Thread Ján Tomko
On 01/25/13 20:15, Laine Stump wrote: On 01/25/2013 10:36 AM, Ján Tomko wrote: Free the bitmap before calling virBitmapParse, which will overwrite it. Also free xml. --- src/conf/network_conf.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread MORITA Kazutaka
At Mon, 28 Jan 2013 21:18:42 +0800, harryxiyou wrote: Hi Morita and other developers, I have programed HLFS(HDFS based Log-structured FileSystem) driver for Libvirt according to Morita's patch(commit 036ad5052b43fe9f0d197e89fd16715950408e1d) for Libvirt, which my patch is not for Libvirt

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I'm not familiar with HLFS at all. Sheepdog examples I explained to you in another mail may help you, but I cannot give you any other suggestions about HLFS. Thanks for your reminder, i have found this

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:06 PM, harryxiyou harryxi...@gmail.com wrote: On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I'm not familiar with HLFS at all. Sheepdog examples I explained to you in another mail may help you, but I cannot give you any

Re: [libvirt] [PATCH v3 0/4] Updated FreeBSD netdev patches

2013-01-28 Thread John Ferlan
On 01/26/2013 10:13 AM, Roman Bogorodskiy wrote: Third round of porting netdev stuff to FreeBSD. A few words on virNetDevTapCreate() changes since the previous review: - it seems that there's no way to avoid iteration over possible interface names, at least I wasn't able to find

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:23 PM, harryxiyou harryxi...@gmail.com wrote: On Mon, Jan 28, 2013 at 11:06 PM, harryxiyou harryxi...@gmail.com wrote: On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I'm not familiar with HLFS at all. Sheepdog examples I

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread MORITA Kazutaka
At Mon, 28 Jan 2013 23:43:04 +0800, harryxiyou wrote: Following test is Libvirt v0.8.6, which you just add Sheepdog volume patch to Libvirt. The version doesn't support Sheepdog storage pool and volume. Please note that my patch you are looking at doesn't implements a sheepdog storage

[libvirt] [PATCH v2 0/7] Introduce virCommandDoAsyncIO

2013-01-28 Thread Michal Privoznik
Currently, if we want to use IO with asynchronous command we have to copy code from virFileWrapperFd to misuse our event loop for reading and writing to the command. However, we can extend our virCommand implementation to automatically set things up. All patches but the first has been ACKed

[libvirt] [PATCH v2 2/7] Introduce event loop to commandtest

2013-01-28 Thread Michal Privoznik
This is just preparing environment for the next patch, which is going to need an event loop. --- tests/commanddata/test3.log | 2 +- tests/commandtest.c | 87 + 2 files changed, 88 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 1/7] virCommand: Introduce virCommandDoAsyncIO

2013-01-28 Thread Michal Privoznik
Currently, if we want to feed stdin, or catch stdout or stderr of a virCommand we have to use virCommandRun(). When using virCommandRunAsync() we have to register FD handles by hand. This may lead to code duplication. Hence, introduce an internal API, which does this automatically within

[libvirt] [PATCH v2 4/7] virFileWrapperFd: Switch to new virCommandDoAsyncIO

2013-01-28 Thread Michal Privoznik
Commit 34e8f63a32f83 introduced support for catching errors from libvirt iohelper. However, at those times there wasn't such fancy API as virCommandDoAsyncIO(), so everything has to be implemented on our own. But since we do have the API now, we can use it and drop our implementation then. ---

[libvirt] [PATCH v2 3/7] tests: Create test for virCommandDoAsyncIO

2013-01-28 Thread Michal Privoznik
This is just a basic test, so we don't break virCommand in the future. A Hello world\n string is written to commanhelper, which copies input to stdout and stderr where we read it from. Then the read strings are compared with expected values. --- tests/commandtest.c | 49

[libvirt] [PATCH v2 5/7] qemu: Catch stderr of image decompression binary

2013-01-28 Thread Michal Privoznik
If a decompression binary prints something to stderr, currently it is discarded. However, it can contain useful data from debugging POV, so we should catch it. --- src/qemu/qemu_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH v2 6/7] qemu: Catch stderr of image compression binary

2013-01-28 Thread Michal Privoznik
If a compression binary prints something to stderr, currently it is discarded. However, it can contain useful data from debugging POV, so we should catch it. --- src/qemu/qemu_migration.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c

[libvirt] [PATCH v2 7/7] qemu: Destroy domain on decompression binary error

2013-01-28 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=894723 Currently, if qemuProcessStart() succeeds, but it's decompression binary that returns nonzero status, we don't kill the qemu process, but remove it from internal domain list, leaving the qemu process hanging around totally uncontrolled. ---

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka morita.kazut...@gmail.com wrote: At Mon, 28 Jan 2013 23:43:04 +0800, harryxiyou wrote: Following test is Libvirt v0.8.6, which you just add Sheepdog volume patch to Libvirt. The version doesn't support Sheepdog storage pool and volume.

[libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-28 Thread Peter Krempa
When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still present in the queue and it was passed to virNetMessageFree which tried to call the

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-28 Thread Eric Blake
On 01/28/2013 11:35 AM, Peter Krempa wrote: When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still present in the queue and it was passed to

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-28 Thread Cole Robinson
On 01/28/2013 01:58 PM, Eric Blake wrote: On 01/28/2013 11:35 AM, Peter Krempa wrote: When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-28 Thread Peter Krempa
On 01/28/13 19:58, Eric Blake wrote: On 01/28/2013 11:35 AM, Peter Krempa wrote: When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still present

Re: [libvirt] Add support for QEMU file descriptor sets

2013-01-28 Thread Eric Blake
On 01/26/2013 09:17 PM, Stefan Berger wrote: In a subsequent patch we now test inside that function whether the new command line parameter is available using the capability (from another patch) and create fd=/dev/set/10 and vhostfd=/dev/set/20 respectively *and* already add -add-fd

Re: [libvirt] [PATCH 1/4] doc: schema: Add basic documentation for the virtual RNG device support

2013-01-28 Thread Eric Blake
On 01/11/2013 10:00 AM, Peter Krempa wrote: This patch documments XML elements used for (basic) support of virtual s/documments/documents/ RNG devices. In the devices section in the domain XML users may specify: devices rng model='none'/ Do we need model='none'? Historically, we

Re: [libvirt] [PATCH 2/4] conf: Use correct type for device type enum in virDomainDeviceDefFree

2013-01-28 Thread Eric Blake
On 01/11/2013 10:00 AM, Peter Krempa wrote: With this change it's easy to spot a forgotten free if a new device class is added. --- src/conf/domain_conf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) ACK; and this can go in pre-release. -switch (def-type) { +

Re: [libvirt] [PATCH 3/4] conf: Add basic support for RNG configuration

2013-01-28 Thread Eric Blake
On 01/11/2013 10:00 AM, Peter Krempa wrote: This patch adds basic configuration support for the RNG device suporting the virtio model with the random backend type. --- src/conf/domain_conf.c | 148 ++- src/conf/domain_conf.h | 36

Re: [libvirt] [PATCH 4/4] qemu: Implement support for the RNG device and the random backend

2013-01-28 Thread Eric Blake
On 01/11/2013 10:00 AM, Peter Krempa wrote: This patch implements support for the virtio-rng-pci device and the rng-random backend in qemu. Two capabilities bits are added to track support for those: QEMU_CAPS_DEVICE_VIRTIO_RNG - for the device support and QEMU_CAPS_OBJECT_RNG_RANDOM -

Re: [libvirt] [PATCHv2 4/7] conf: Split out NUMA topology formatting to simplify access to data

2013-01-28 Thread Eric Blake
On 01/22/2013 02:30 PM, Peter Krempa wrote: --- src/conf/capabilities.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

[libvirt] ANNOUNCE: libvirt 0.10.2.3 maintenance release

2013-01-28 Thread Cole Robinson
libvirt 0.10.2.3 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.3.tar.gz Changes in this version: *

[libvirt] ANNOUNCE: libvirt 0.9.11.9 maintenance release

2013-01-28 Thread Cole Robinson
libvirt 0.9.11.9 maintenance release is now available. This is libvirt 0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.11.9.tar.gz Changes in this version: * Fix

[libvirt] ANNOUNCE: libvirt 0.9.6.4 maintenance release

2013-01-28 Thread Cole Robinson
libvirt 0.9.6.4 maintenance release is now available. This is libvirt 0.9.6 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.6.4.tar.gz Changes in this version: * rpc: Fix

Re: [libvirt] [PATCH] auto-create pci-bridge controller info

2013-01-28 Thread Eric Blake
On 01/23/2013 06:15 AM, Daniel P. Berrange wrote: ACK However, it fails to compile: CC libvirt_conf_la-domain_conf.lo conf/domain_conf.c: In function 'virDomainDefMaybeAddPcibridgeController': conf/domain_conf.c:11829:44: error: 'VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE' undeclared

Re: [libvirt] [PATCH] LXC: create directory /dev/shm automatically

2013-01-28 Thread Kamezawa Hiroyuki
(2013/01/28 19:36), Daniel P. Berrange wrote: On Mon, Jan 28, 2013 at 02:37:11PM +0800, Gao feng wrote: Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as shm_open/sem_open will create files under dir /dev.(since /dev is mounted as tmpfs) Through these

Re: [libvirt] [PATCH 4/9] xen: Add coverity[ptr_arith] and [sign_extension] tags

2013-01-28 Thread Eric Blake
On 01/22/2013 12:28 PM, John Ferlan wrote: @@ -1795,8 +1795,11 @@ virXen_setvcpumap(int handle, int id, unsigned int vcpu, return -1; memset(pm, 0, sizeof(cpumap_t)); -for (j = 0; j maplen; j++) +for (j = 0; j maplen; j++) { +/*

Re: [libvirt] [PATCH 0/7] documentation improvements - again

2013-01-28 Thread Eric Blake
On 01/22/2013 07:31 AM, Claudio Bley wrote: Hi. The first two patches are aimed at avoiding generation of empty argument description lists, which might happen if a function has no documentation for some argument or its return type. I'd rather see us fail 'make' if we detect missing

Re: [libvirt] [PATCH v3 0/3] add pci-bridge support

2013-01-28 Thread li guang
Hi, All any other comments? 在 2013-01-14一的 11:42 +0800,li guang写道: ping ... 在 2013-01-10四的 09:04 +0800,liguang写道: Now, it's impossible to arrange devices into multi-pci-bus, for example: sound model='ac97' address type='pci' domain='0x' bus='0x00' slot='0x04'

Re: [libvirt] [PATCH 1/7] docs: don't write out empty info attributes for function arguments

2013-01-28 Thread Eric Blake
On 01/22/2013 07:31 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- docs/apibuild.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 9a29c42..f9500b1 100755 --- a/docs/apibuild.py +++

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread MORITA Kazutaka
At Tue, 29 Jan 2013 01:00:21 +0800, harryxiyou wrote: On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka morita.kazut...@gmail.com wrote: At Mon, 28 Jan 2013 23:43:04 +0800, harryxiyou wrote: Following test is Libvirt v0.8.6, which you just add Sheepdog volume patch to Libvirt.

Re: [libvirt] [PATCH 2/7] docs: only generate function argument info for args with a description

2013-01-28 Thread Eric Blake
On 01/22/2013 07:31 AM, Claudio Bley wrote: When function arguments or return values lack a description there's no use in generating a meaningless ARG1: stanza. Again, can we instead tweak this to cause 'make' to fail if there is missing documentation? Signed-off-by: Claudio Bley

Re: [libvirt] [PATCH 4/9] xen: Add coverity[ptr_arith] and [sign_extension] tags

2013-01-28 Thread John Ferlan
On 01/28/2013 06:52 PM, Eric Blake wrote: On 01/22/2013 12:28 PM, John Ferlan wrote: @@ -1795,8 +1795,11 @@ virXen_setvcpumap(int handle, int id, unsigned int vcpu, return -1; memset(pm, 0, sizeof(cpumap_t)); -for (j = 0; j maplen; j++) +for (j =

Re: [libvirt] [PATCH 3/7] docs: use a div instead of a 3 column table for undisclosed notices

2013-01-28 Thread Eric Blake
On 01/22/2013 07:31 AM, Claudio Bley wrote: It's simpler to render and it prevents wrapping the line too early because of the table spacing, border et cetera. Subject line was a bit long; also, on my first read, I misread it as notices that were not disclosed to the reader (why are we worried

Re: [libvirt] [PATCH] LXC: create directory /dev/shm automatically

2013-01-28 Thread Gao feng
On 2013/01/29 07:52, Kamezawa Hiroyuki wrote: (2013/01/28 19:36), Daniel P. Berrange wrote: On Mon, Jan 28, 2013 at 02:37:11PM +0800, Gao feng wrote: Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as shm_open/sem_open will create files under dir

Re: [libvirt] [Libvirt-announce] Candidate Release 2 of libvirt-1.0.2

2013-01-28 Thread Jason Helfman
On Mon, Jan 28, 2013 at 5:03 AM, Justin Clift jcl...@redhat.com wrote: On 28/01/2013, at 12:22 PM, Daniel Veillard wrote: I have just tagged the rc2 in git and pushed the associated tarball and rpms for F17 to the FTP area: ftp://libvirt.org/libvirt/ This seems ok on OSX 10.7 too. :)

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Tue, Jan 29, 2013 at 8:18 AM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] I've looked at the upstream tree, but it certainly contains sheepdog codes. http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/storage Sorry, my libvirt git tree was not the latest one, which may not

Re: [libvirt] [PATCH] LXC: create directory /dev/shm automatically

2013-01-28 Thread Kamezawa Hiroyuki
(2013/01/29 11:16), Gao feng wrote: On 2013/01/29 07:52, Kamezawa Hiroyuki wrote: (2013/01/28 19:36), Daniel P. Berrange wrote: On Mon, Jan 28, 2013 at 02:37:11PM +0800, Gao feng wrote: Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as

Re: [libvirt] [PATCH] LXC: create directory /dev/shm automatically

2013-01-28 Thread Gao feng
On 2013/01/29 12:09, Kamezawa Hiroyuki wrote: (2013/01/29 11:16), Gao feng wrote: On 2013/01/29 07:52, Kamezawa Hiroyuki wrote: (2013/01/28 19:36), Daniel P. Berrange wrote: On Mon, Jan 28, 2013 at 02:37:11PM +0800, Gao feng wrote: Now we mount /dev as tmpfs and haven't created directory