Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread Claudio Bley
At Wed, 30 Jan 2013 11:52:19 -0700, Eric Blake wrote: On 01/30/2013 08:47 AM, harryxiyou wrote: Hi all, I did following steps to install Libvirt. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, ./autogen.sh 4, ./configure 5, make 6, sudo make install

Re: [libvirt] [PATCH 7/7] docs: syntax highlight code blocks using SHJS

2013-01-31 Thread Claudio Bley
I missed this reply of yours the first time. Let's see. At Tue, 29 Jan 2013 11:38:41 -0700, Eric Blake wrote: On 01/22/2013 07:31 AM, Claudio Bley wrote: Add minimized CSS and Javascript files of SHJS (http://shjs.sourceforge.net/) required for highlighting C code. Call

Re: [libvirt] [PATCH] tests: add a comment about our fake qmp

2013-01-31 Thread Daniel P. Berrange
On Wed, Jan 30, 2013 at 07:02:04PM -0700, Eric Blake wrote: While testing QMP, I used a simple qemu session of 'qemu-kvm -M none -nodefaults -nographic -qmp stdio' for some experiments. But it took me far too long to remember the magic invocation to unlock QMP into accepting normal commands.

Re: [libvirt] [PATCH] complete virterror-virerror name change

2013-01-31 Thread Daniel P. Berrange
On Wed, Jan 30, 2013 at 08:16:59PM -0700, Eric Blake wrote: On 01/30/2013 08:05 PM, Serge Hallyn wrote: Without these two string changes in generator.py, the virGetLastError wrapper does not get created in /usr/share/pyshared/libvirt.py. Noticed when running tests with virt-install.

Re: [libvirt] [PATCH 0/2] more work on qemu add-fd support

2013-01-31 Thread Daniel P. Berrange
On Wed, Jan 30, 2013 at 09:21:44PM -0700, Eric Blake wrote: As promised, here's my first contribution into what is turning into a joint effort between myself and Stefan to support fd passing in qemu 1.3 and newer. Patch 2 in this series is basically a rewrite of Stefan's patch 1/4, and I

Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: The 'dname' string was only filled in within the loop when available; however, the TRACE macros used it unconditionally and caused Coverity to compain about BAD_SIZEOF. Using a dnameptr keeps Coverity at bay and makes sure dname was properly filled

Re: [libvirt] [PATCH 02/11] keepalive: Resolve Coverity complaint

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: The Coverity analysis emitted a BAD_SIZEOF error when doing the math within the TRACE macro. Doing the math outside the macro keeps Coverity quiet. --- src/rpc/virkeepalive.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

Re: [libvirt] [PATCH 03/11] storage: Resolve resource leaks with cmd processing

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/storage/storage_backend_disk.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/storage/storage_backend_disk.c b/src/storage/storage_backend_disk.c index 4214e97..40da306 100644 ---

Re: [libvirt] [PATCH 04/11] network: Remove conditional settings to resolve resource leak

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: The conditional setting of cmdout in networkBuildDhcpDaemonCommandLine() caused Coverity to complain that 'cmd' could be leaked if !cmdout. Since the function is local and only called with cmdout being passed those checks have been removed. ---

Re: [libvirt] [PATCH 05/11] parallels: Need to free memory on error path

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/parallels/parallels_utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/parallels/parallels_utils.c b/src/parallels/parallels_utils.c index 171f5d0..0b589ab 100644 --- a/src/parallels/parallels_utils.c +++

Re: [libvirt] [PATCH 06/11] openvz: Need to error check openvzDomainSetVcpusFlagsInternal()

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/openvz/openvz_driver.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index e12a84b..61d8390 100644 --- a/src/openvz/openvz_driver.c +++

Re: [libvirt] [PATCH 07/11] uml: If need to requery, then VIR_FREE(res)

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: Coverity noted that in the retry logic loop if res had been set, then it could be leaked --- src/uml/uml_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 705495e..d97cc96

Re: [libvirt] [PATCH 08/11] rpc: Need to virCommandFree on error path

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/rpc/virnetsocket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 0158970..93980d6 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -704,6 +704,7 @@ int

Re: [libvirt] [PATCH 09/11] lxc: Need to call usbFreeDevice()

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/lxc/lxc_cgroup.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index 1984c5f..ece9e03 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -1,5 +1,5 @@ /* -

Re: [libvirt] [PATCH 10/11] qemu_cgroup: Need to call usbFreeDevice()

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/qemu/qemu_cgroup.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 6527146..9f0eaf9 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -294,8

Re: [libvirt] [PATCH 11/11] qemu_hotplug: Need to call usbFreeDevice()

2013-01-31 Thread Osier Yang
On 2013年01月31日 03:36, John Ferlan wrote: --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 18c4109..2a52650 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1,7

Re: [libvirt] [PATCH 2/2] Add support for QEMU -add-fd support detection

2013-01-31 Thread Stefan Berger
On 01/30/2013 11:21 PM, Eric Blake wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Add support for QEMU -add-fd command line parameter detection. This intentionally rejects qemu 1.2, where 'add-fd' QMP did not allow full control of set ids, and where there was no command line counterpart,

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 2:52 AM, Eric Blake ebl...@redhat.com wrote: [...] Pastebin links expire, making it harder to follow the conversation when revisiting the list archives in the future. It is okay to paste the actual error into the message rather than making people chase through a link.

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 4:19 PM, Claudio Bley cb...@av-test.de wrote: [...] AFAIK, the DTD files are not required, they are just used to validate the generated HTML files. Apparently, xsltproc is broken since there's a mismatch with its libraries. Why is xsltproc installed in /usr but the

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 3:05 AM, Eric Blake ebl...@redhat.com wrote: [...] There's two aspects to storage management in libvirt. Eric, very thanks for your perfectly answers ;-) [...] But without at least one online user (qemu), it doesn't make sense to worry about offline management in

Re: [libvirt] [PATCH v3 03/13] libvirt.h.in: add missing return doc for virEventRemoveHandleFunc

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- include/libvirt/libvirt.h.in |2 ++ 1 file changed, 2 insertions(+) ACK. I had to go hunting for where this callback was used, but this matches the documentation of

[libvirt] libvirt error while start vm with VGA passthrough

2013-01-31 Thread mzawdx wang
http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/6/html/Virtualization_Host_Configuration_and_Guest_Installation_Guide/chap-Virtualization_Host_Configuration_and_Guest_Installation_Guide-PCI_Assignment.html I have followed the instructions in the RedHat reference above to the best of my

[libvirt] [libvirt-php] Build failure with v0.4.7 due to malformatted html

2013-01-31 Thread Stefan Kuhn
I had a problem with the file docs/distros.html.in in libvirt-php-0.4.7 - The file is not in the repository! The error is: ### distros.html.tmp:96: element table: validity error : No declaration for attribute align of element table table align=center width=75%

Re: [libvirt] [libvirt-php] Build failure with v0.4.7 due to malformatted html

2013-01-31 Thread Michal Novotny
Thanks for notification, it was missing in the repository so I've pushed my version of the file there. Thanks, Michal On 01/31/2013 02:31 PM, Stefan Kuhn wrote: I had a problem with the file docs/distros.html.in in libvirt-php-0.4.7 - The file is not in the repository! The error is: ###

Re: [libvirt] [PATCH 1/2] qemu: expose qemu 1.3 add-fd monitor command

2013-01-31 Thread Stefan Berger
On 01/30/2013 11:21 PM, Eric Blake wrote: Add entry points for calling the qemu 'add-fd' and 'remove-fd' monitor commands. There is no entry point for 'query-fdsets'; the assumption is that a developer can use virsh qemu-monitor-command domain '{execute:query-fdsets}' when debugging issues,

Re: [libvirt] libvirt error while start vm with VGA passthrough

2013-01-31 Thread Daniel P. Berrange
On Thu, Jan 31, 2013 at 09:29:52PM +0800, mzawdx wang wrote: http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/6/html/Virtualization_Host_Configuration_and_Guest_Installation_Guide/chap-Virtualization_Host_Configuration_and_Guest_Installation_Guide-PCI_Assignment.html I have followed

[libvirt] [PATCH 0/5]] S390: Support for native CCW bus

2013-01-31 Thread Viktor Mihajlovski
Originally, QEMU did not implement a native I/O bus for s390. The initial implementation had a machine type 's390-virtio' featuring a fully paravirtualized I/O system with an artificial bus type 'virtio-s390'. This bus had a number of short-comings, like the need for a non-standard device

[libvirt] [PATCH 2/5] S390: domain_conf support for CCW

2013-01-31 Thread Viktor Mihajlovski
Add necessary handling code for the new s390 CCW address type to virDomainDeviceInfo. Further, introduce memory management, XML parsing, output formatting and range validation for the new virDomainDeviceCCWAddress type. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

[libvirt] [PATCH 5/5] S390: Testcases for virtio-ccw machines

2013-01-31 Thread Viktor Mihajlovski
This adds and corrects testcases for virtio devices on s390 guests. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-console-virtio-ccw.args | 10 + .../qemuxml2argv-console-virtio-ccw.xml| 27 ++

[libvirt] [PATCH 3/5] S390: QEMU driver support for CCW addresses

2013-01-31 Thread Viktor Mihajlovski
This commit adds the QEMU driver support for CCW addresses. The current QEMU only allows virtio devices to be attached to the CCW bus. We named the new capability indicating that support QEMU_CAPS_VIRTIO_CCW accordingly. The fact that CCW devices can only be assigned to domains with a machine

[libvirt] [PATCH 4/5] S390: Add hotplug support for s390 virtio devices

2013-01-31 Thread Viktor Mihajlovski
From: J.B. Joret j...@linux.vnet.ibm.com We didn't yet expose the virtio device attach and detach functionality for s390 domains as the device hotplug was very limited with the old virtio-s390 bus. With the CCW bus there's full hotplug support for virtio devices in QEMU, so we are adding this to

[libvirt] [libvirt-php PATCH 1/1] docs/distros.html.in: fix html validity error

2013-01-31 Thread stefan . kuhn
--- docs/distros.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/distros.html.in b/docs/distros.html.in index f929d94..c883fa3 100644 --- a/docs/distros.html.in +++ b/docs/distros.html.in @@ -4,8 +4,8 @@ p There are several distributions that

[libvirt] [libvirt-php PATCH 0/1] docs/distros.html.in: fix html validity

2013-01-31 Thread stefan . kuhn
The error is: ### distros.html.tmp:96: element table: validity error : No declaration for attribute align of element table table align=center width=75% ^ make[2]: *** [distros.html] Error 1 ### Stefan Kuhn (1): docs/distros.html.in: fix html

Re: [libvirt] [libvirt-php PATCH 0/1] docs/distros.html.in: fix html validity

2013-01-31 Thread Michal Novotny
On 01/31/2013 02:54 PM, stefan.k...@foss-group.ch wrote: The error is: ### distros.html.tmp:96: element table: validity error : No declaration for attribute align of element table table align=center width=75% ^ make[2]: *** [distros.html]

Re: [libvirt] [PATCH 2/2] Add support for QEMU -add-fd support detection

2013-01-31 Thread Eric Blake
On 01/31/2013 04:46 AM, Stefan Berger wrote: On 01/30/2013 11:21 PM, Eric Blake wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Add support for QEMU -add-fd command line parameter detection. This intentionally rejects qemu 1.2, where 'add-fd' QMP did not allow full control of set ids,

[libvirt] [Libvirt][Sheepdog]How to test network disk support for sheepdog in Libvirt

2013-01-31 Thread harryxiyou
Hi all, Morita added network disk support for Libvirt, which supported nbd, rbd, sheepdog, and other protocols. Now, i wanna test network disk support for sheepdog solely. I have following questions. Could anyone please give me some suggestions? Thanks in advance. 1, Before this test, whether

[libvirt] [PATCH] spec: Avoid using makeinstall relic

2013-01-31 Thread Jiri Denemark
The macro was made to help installing broken packages that did not use DESTDIR correctly by overriding individual path variables (prefix, sysconfdir, ...). Newer rpm provides fixed make_install macro that calls make install with just the correct DESTDIR, however it is not available everywhere

Re: [libvirt] [PATCH] complete virterror-virerror name change

2013-01-31 Thread Doug Goldstein
On Wed, Jan 30, 2013 at 9:16 PM, Eric Blake ebl...@redhat.com wrote: On 01/30/2013 08:05 PM, Serge Hallyn wrote: Without these two string changes in generator.py, the virGetLastError wrapper does not get created in /usr/share/pyshared/libvirt.py. Noticed when running tests with virt-install.

Re: [libvirt] [PATCH 2/2] Add support for QEMU -add-fd support detection

2013-01-31 Thread Corey Bryant
On 01/31/2013 09:06 AM, Eric Blake wrote: On 01/31/2013 04:46 AM, Stefan Berger wrote: On 01/30/2013 11:21 PM, Eric Blake wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Add support for QEMU -add-fd command line parameter detection. This intentionally rejects qemu 1.2, where 'add-fd'

[libvirt] persistent virtual networks

2013-01-31 Thread Gene Czarcinski
I seem to remember that, if you use net-define, the network will be persistent and, if you use net-create, the network will not be persistent. I am now running libvirt-1.0.2 on Fedora 18. When I use net-define a network from a template and then do a net-list --all, the network is NOT marked

Re: [libvirt] [PATCH] spec: Avoid using makeinstall relic

2013-01-31 Thread Eric Blake
On 01/31/2013 07:38 AM, Jiri Denemark wrote: The macro was made to help installing broken packages that did not use DESTDIR correctly by overriding individual path variables (prefix, sysconfdir, ...). Newer rpm provides fixed make_install macro that calls make install with just the correct

Re: [libvirt] [PATCH] spec: Avoid using makeinstall relic

2013-01-31 Thread Jiri Denemark
On Thu, Jan 31, 2013 at 08:44:03 -0700, Eric Blake wrote: On 01/31/2013 07:38 AM, Jiri Denemark wrote: The macro was made to help installing broken packages that did not use DESTDIR correctly by overriding individual path variables (prefix, sysconfdir, ...). Newer rpm provides fixed

[libvirt] NetworkManager git20121211

2013-01-31 Thread Gene Czarcinski
I needed some functionality (dynamic dns update) not available in the NetworkManager package available in Fedora 18 so I created my own version based on git20121130. This worked nicely providing the functionality and did not appear to have any bad side effects. Then the NetworkManager

Re: [libvirt] [PATCH 01/11] xs: Remove redundant validity checks

2013-01-31 Thread Osier Yang
On 2013年01月31日 02:51, John Ferlan wrote: Arguments for driver entry points are checked in libvirt.c, so no need to check again. --- src/xen/xs_internal.c | 139 ++ 1 file changed, 28 insertions(+), 111 deletions(-) diff --git

Re: [libvirt] [PATCH 02/11] xs: Code cleanup

2013-01-31 Thread Osier Yang
On 2013年01月31日 02:51, John Ferlan wrote: Housekeeping kind of stuff. --- src/xen/xs_internal.c | 108 +- 1 file changed, 45 insertions(+), 63 deletions(-) diff --git a/src/xen/xs_internal.c b/src/xen/xs_internal.c index 573c0c6..f823dfc 100644

Re: [libvirt] [PATCH 7/7] docs: syntax highlight code blocks using SHJS

2013-01-31 Thread Eric Blake
On 01/31/2013 02:47 AM, Claudio Bley wrote: IMO, these files are object files, as far as the GPL v3 is concerned. ,[ GPL v3 1. Source Code ] | The source code for a work means the preferred form of the work | for making modifications to it. Object code means any non-source | form

Re: [libvirt] [PATCH 03/11] inotify: Code cleanup

2013-01-31 Thread Osier Yang
On 2013年01月31日 02:51, John Ferlan wrote: Clean up some function headers --- src/xen/xen_inotify.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/src/xen/xen_inotify.c b/src/xen/xen_inotify.c index 2043c74..94803b2 100644

[libvirt] [PATCH v2 06/11] openvz: Need to error check openvzDomainSetVcpusFlagsInternal()

2013-01-31 Thread John Ferlan
--- Since I'm not only changing one 'virtual cpu' reference to 'vCPU', I figured I would just post an update. As you see the message I added was a cut-n-paste of other messages where similar calls were made. To be consistent, I changed other references to vCPUs and I changed one other message as

Re: [libvirt] [PATCH 04/11] xm: Remove redundant validity checks

2013-01-31 Thread Osier Yang
On 2013年01月31日 02:51, John Ferlan wrote: Arguments for driver entry points are checked in libvirt.c, so no need to check again. --- src/xen/xm_internal.c | 76 --- 1 file changed, 17 insertions(+), 59 deletions(-) diff --git

Re: [libvirt] [PATCH 05/11] xm: Clean up

2013-01-31 Thread Osier Yang
On 2013年01月31日 02:51, John Ferlan wrote: Clean up some function headers. --- src/xen/xm_internal.c | 119 +++--- 1 file changed, 75 insertions(+), 44 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 1c1db54..912de3f

Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

2013-01-31 Thread Eric Blake
On 01/31/2013 03:44 AM, Osier Yang wrote: On 2013年01月31日 03:36, John Ferlan wrote: The 'dname' string was only filled in within the loop when available; however, the TRACE macros used it unconditionally and caused Coverity to compain about BAD_SIZEOF. Using a dnameptr keeps Coverity at bay

Re: [libvirt] [PATCH 2/9] Introduce new XMLs to specify disk source using libvirt storage

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: With this patch, one can specify the disk source using libvirt storage like: disk type='volume' device='disk' driver name='qemu' type='raw' cache='none'/ source pool='default' volume='fc18.img'/ target dev='vdb' bus='virtio'/ /disk

Re: [libvirt] [PATCH v3 04/13] libvirt.h.in: document virConnectDomainEventCallback's return value

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- include/libvirt/libvirt.h.in |2 ++ 1 file changed, 2 insertions(+) Hmm, I wonder if we should at least log any situation where the user's callback returns non-zero, rather than flat-out

Re: [libvirt] [PATCH] tests: add a comment about our fake qmp

2013-01-31 Thread Eric Blake
On 01/31/2013 02:49 AM, Daniel P. Berrange wrote: * tests/qemumonitortestutils.c (QEMU_JSON_GREETING): Mention that the normal counterpart reply is skipped. --- #define QEMU_JSON_GREETING {\QMP\: {\version\: {\qemu\: {\micro\: 1, \minor\: 0, \major\: 1}, \package\: \ (qemu-kvm-1.0.1)\},

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread Eric Blake
On 01/31/2013 04:59 AM, harryxiyou wrote: On Thu, Jan 31, 2013 at 3:05 AM, Eric Blake ebl...@redhat.com wrote: [...] There's two aspects to storage management in libvirt. Eric, very thanks for your perfectly answers ;-) [...] But without at least one online user (qemu), it doesn't make

Re: [libvirt] [PATCH 2/9] Introduce new XMLs to specify disk source using libvirt storage

2013-01-31 Thread Osier Yang
On 2013年02月01日 01:17, John Ferlan wrote: On 01/30/2013 01:11 PM, Osier Yang wrote: With this patch, one can specify the disk source using libvirt storage like: disk type='volume' device='disk' driver name='qemu' type='raw' cache='none'/ source pool='default' volume='fc18.img'/

Re: [libvirt] [PATCH 3/9] New files to glue domain and storage together

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: This creates src/conf/domain_storage.h and src/conf/storage_conf.c, which defines a driver contains internal APIs to glue the domain and storage. Currently there is only one API, translateDiskSourcePool, which is to translate the specified pool/volume

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 2:52 AM, Eric Blake ebl...@redhat.com wrote: [...] [...] /usr/bin//xsltproc: /usr/local/lib/libxml2.so.2: no version information available (required by /usr/lib/libxslt.so.1) /usr/bin//xsltproc: /usr/local/lib/libxml2.so.2: no version information available (required

Re: [libvirt] [PATCH 2/2] Add support for QEMU -add-fd support detection

2013-01-31 Thread Eric Blake
On 01/31/2013 07:42 AM, Corey Bryant wrote: ...this code is what checks for 1.3. In 1.2, the qemuMonitorAddFd() call fails with an error, so we clear the bit back out. Only 1.3 allows libvirt to specify its own set number, because that was one of the changes qemu had to make in order to add

Re: [libvirt] [PATCH 4/9] Implement translateDiskSourcePool

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: It iterates over all the domain disks, and translate the source of all the disks of 'volume' type from storage pool/volume to the real underlying source. Disks of type 'file', 'block', and 'dir' are supported now. Network type is not supported yet,

Re: [libvirt] [PATCH 5/9] qemu: Translate the source when starting domain

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: * src/qemu/qemu_driver.c (Use virDomainStorageTranslateDiskSourcePool to translate the source to the real underlying source in qemuDomainCreate and qemuDomainObjStart) --- src/qemu/qemu_driver.c |7 +++ 1 files changed, 7 insertions(+),

Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

2013-01-31 Thread Osier Yang
On 2013年02月01日 00:41, Eric Blake wrote: On 01/31/2013 03:44 AM, Osier Yang wrote: On 2013年01月31日 03:36, John Ferlan wrote: The 'dname' string was only filled in within the loop when available; however, the TRACE macros used it unconditionally and caused Coverity to compain about BAD_SIZEOF.

Re: [libvirt] [PATCH 6/9] Support startupPolicy for 'volume' disk

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: startupPolicy is only valid for file type storage volume, otherwise it fails on starting the domain (no way to error out earlier when parsing). --- docs/formatdomain.html.in |7 --- docs/schemas/domaincommon.rng |3 +++

Re: [libvirt] [PATCH 4/9] Implement translateDiskSourcePool

2013-01-31 Thread Osier Yang
On 2013年02月01日 01:42, John Ferlan wrote: On 01/30/2013 01:11 PM, Osier Yang wrote: It iterates over all the domain disks, and translate the source of all the disks of 'volume' type from storage pool/volume to the real underlying source. Disks of type 'file', 'block', and 'dir' are supported

Re: [libvirt] [PATCH 7/9] conf: Fix bugs on disk source formating

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: One simple demo: * Edit the disk conf like: source startupPolicy='optional'/ The output will be like: startupPolicy='optional'/ --- src/conf/domain_conf.c | 36 +--- 1 files changed, 21 insertions(+),

Re: [libvirt] [PATCH 8/9] Support seclabels for volume type disk

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: seclabels is only valid for 'file' or 'block' type storage volume. --- docs/formatdomain.html.in | 31 --- docs/schemas/domaincommon.rng |3 +++ src/conf/domain_conf.c| 12 ++--

Re: [libvirt] [PATCH 9/9] Support network pool for volume disk

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: The only two network pools we supported are rbd and sheepdog, and attributes socket, transport are not supported in storage pool conf yet, this uses the default setting (TCP for 'transport', and socket is not set) temporarily. Future patches will

[libvirt] [libvirt-php PATCH 1/1] src/Makefile.am: use LDFLAGS for libvirt-php.so

2013-01-31 Thread stefan . kuhn
--- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0d08448..18b868b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,7 +14,7 @@ build: $(CC) $(CFLAGS) -Wall -fpic -DCOMPILE_DL_LIBVIRT=1 $(PHPINC) -c -o

[libvirt] [libvirt-php PATCH 0/1] use LDFLAGS for libvirt-php.so

2013-01-31 Thread stefan . kuhn
I'm getting this warning: * QA Notice: Files built without respecting LDFLAGS have been detected * Please include the following list of files in your report: * /usr/lib64/php5.3/lib/extensions/no-debug-non-zts-20090626/libvirt-php.so The attached patch seems reasonable to me, please check it.

Re: [libvirt] [PATCH 1/9] rng: Add definition for network disk source

2013-01-31 Thread John Ferlan
On 01/30/2013 01:11 PM, Osier Yang wrote: It's long enough to have a independant definition. --- docs/schemas/domaincommon.rng | 93 + 1 files changed, 48 insertions(+), 45 deletions(-) diff --git a/docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH v3 05/13] docs: abort when missing return or argument documentation

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: When a function has no associated information to one of its arguments or its return type we report it and stop with an error. Signed-off-by: Claudio Bley cb...@av-test.de --- docs/apibuild.py | 18 -- 1 file changed, 16

Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

2013-01-31 Thread John Ferlan
On 01/31/2013 11:41 AM, Eric Blake wrote: On 01/31/2013 03:44 AM, Osier Yang wrote: On 2013年01月31日 03:36, John Ferlan wrote: The 'dname' string was only filled in within the loop when available; however, the TRACE macros used it unconditionally and caused Coverity to compain about BAD_SIZEOF.

Re: [libvirt] NetworkManager git20121211

2013-01-31 Thread Laine Stump
On 01/31/2013 10:59 AM, Gene Czarcinski wrote: I needed some functionality (dynamic dns update) not available in the NetworkManager package available in Fedora 18 so I created my own version based on git20121130. This worked nicely providing the functionality and did not appear to have any

Re: [libvirt] NetworkManager git20121211

2013-01-31 Thread Gene Czarcinski
On 01/31/2013 10:59 AM, Gene Czarcinski wrote: I needed some functionality (dynamic dns update) not available in the NetworkManager package available in Fedora 18 so I created my own version based on git20121130. This worked nicely providing the functionality and did not appear to have any

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: When function arguments or return values lack a description there's no use in generating a meaningless ARG1: stanza. Can you point to an example of an argument lacking a description? This is another case where I think we're better off fixing things

Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

2013-01-31 Thread Eric Blake
On 01/31/2013 12:28 PM, John Ferlan wrote: On 01/31/2013 11:41 AM, Eric Blake wrote: On 01/31/2013 03:44 AM, Osier Yang wrote: On 2013年01月31日 03:36, John Ferlan wrote: The 'dname' string was only filled in within the loop when available; however, the TRACE macros used it unconditionally and

Re: [libvirt] NetworkManager git20121211

2013-01-31 Thread Gene Czarcinski
On 01/31/2013 02:31 PM, Laine Stump wrote: On 01/31/2013 10:59 AM, Gene Czarcinski wrote: I needed some functionality (dynamic dns update) not available in the NetworkManager package available in Fedora 18 so I created my own version based on git20121130. This worked nicely providing the

Re: [libvirt] Release of libvirt-1.0.2

2013-01-31 Thread Jason Helfman
On Wed, Jan 30, 2013 at 2:05 AM, Daniel Veillard veill...@redhat.comwrote: As scheduled, I just made the release today, it is tagged in git and tarball and rpms are available at the usual FTP place: ftp://libvirt.org/libvirt/ This is a large release, including over 450 commit, with a

[libvirt] [PATCH v2 01/11] tlscontext: Make sure to get proper pointer to 'dname'

2013-01-31 Thread John Ferlan
Keep Coverity happy by passing a pointer to 'dname' rather than the array itself. The PROBE expansion would cause a BAD_SIZEOF. --- After all that we're back to this version without the (unknown). I guess that was my former world sneaking in - have to put something there.

Re: [libvirt] [PATCH v2 01/11] tlscontext: Make sure to get proper pointer to 'dname'

2013-01-31 Thread Eric Blake
On 01/31/2013 02:50 PM, John Ferlan wrote: Keep Coverity happy by passing a pointer to 'dname' rather than the array itself. The PROBE expansion would cause a BAD_SIZEOF. --- After all that we're back to this version without the (unknown). I guess that was my former world sneaking in - have

Re: [libvirt] [PATCH v3 07/13] docs: use div, not table, for notices on opaque types

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: It's simpler to render and it prevents wrapping the line too early because of the table spacing, border et cetera. Signed-off-by: Claudio Bley cb...@av-test.de --- docs/libvirt.css |1 + docs/newapi.xsl | 110

[libvirt] Canonical citation for Libvirt

2013-01-31 Thread Lempereur, Brett
Hi, Is there a canonical paper I can cite for Libvirt in academic publications? The best I've found so far is Bolt, M., Birkenheuer, G., Niehörster, O., Brinkmann, A. (2010). Non-Intrusive Virtualization Management using Libvirt. Proceedings of the 2nd Design, Automation, and Test in

Re: [libvirt] [PATCH v3 08/13] docs: process code blocks similar to markdown

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: Wrap pre-formatted example code in pre elements. This works similar to markdown code blocks. Every line indented with at least 2 spaces is considered a code block and gets wrapped in a pre tag. Please, put a reference to an affected API in the

Re: [libvirt] [PATCH 02/11] keepalive: Resolve Coverity complaint

2013-01-31 Thread Eric Blake
On 01/30/2013 12:36 PM, John Ferlan wrote: The Coverity analysis emitted a BAD_SIZEOF error when doing the math within the TRACE macro. Doing the math outside the macro keeps Coverity quiet. --- src/rpc/virkeepalive.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-31 Thread Jim Fehlig
Eric Blake wrote: On 01/29/2013 07:05 PM, Jim Fehlig wrote: Mention CVE-2013-0170 in the commit message, now that it is public: https://bugzilla.redhat.com/show_bug.cgi?id=893450 * rpc/virnetserverclient.c: virNetServerClientDispatchRead: - avoid use after free of RPC

[libvirt] [PATCH] maint: update to latest gnulib

2013-01-31 Thread Eric Blake
CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon that runs a regex search on user input while in a multibyte locale. I'm not sure how hard it would be to trigger such a setup for libvirtd, but rather than risk things, we can avoid the issue: gnulib has worked around the problem, and

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Fri, Feb 1, 2013 at 1:18 AM, Eric Blake ebl...@redhat.com wrote: [...] Libvirt exists to manage existing hypervisor capabilities. It makes no sense for libvirt to be able to create storage volumes for a new protocol if there are no hypervisors that are also able to support that storage

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread MORITA Kazutaka
At Fri, 1 Feb 2013 09:59:52 +0800, harryxiyou wrote: On Fri, Feb 1, 2013 at 1:18 AM, Eric Blake ebl...@redhat.com wrote: [...] Libvirt exists to manage existing hypervisor capabilities. It makes no sense for libvirt to be able to create storage volumes for a new protocol if there are no

[libvirt] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-01-31 Thread harryxiyou
Hi all, We can get Boot VMs from sheepdog volumes in Libvirt way from https://github.com/collie/sheepdog/wiki/Libvirt like following. a, prepare a file containing an XML domain description $ cat sheepdog.xml domain type='qemu' nametestvm/name memory1048576/memory

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Fri, Feb 1, 2013 at 12:06 PM, MORITA Kazutaka morita.kazut...@lab.ntt.co.jp wrote: [...] 1. prepare a file containing an XML domain description $ cat sheepdog.xml domain type='qemu' nametestvm/name memory1048576/memory os type arch='x86_64'hvm/type /os

Re: [libvirt] [PATCH] maint: update to latest gnulib

2013-01-31 Thread Jiri Denemark
On Thu, Jan 31, 2013 at 16:34:24 -0700, Eric Blake wrote: CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon that runs a regex search on user input while in a multibyte locale. I'm not sure how hard it would be to trigger such a setup for libvirtd, but rather than risk things, we