On 02/19/13 13:35, Jiri Denemark wrote:
---
src/qemu/qemu_driver.c | 141 +
1 file changed, 141 insertions(+)
ACK.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 02/19/13 13:35, Jiri Denemark wrote:
As a side effect, this also fixes reporting disk migration process.
It was added to memory migration progress, which was wrong. Disk
progress has dedicated fields in virDomainJobInfo structure.
---
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_doma
On 02/19/13 13:35, Jiri Denemark wrote:
---
tools/virsh-domain.c | 215 ---
1 file changed, 169 insertions(+), 46 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f8b0cec..ba05fa7 100644
--- a/tools/virsh-domain.c
+++
On 02/22/13 01:45, Eric Blake wrote:
On 02/21/2013 02:04 PM, Peter Krempa wrote:
On 02/19/13 13:35, Jiri Denemark wrote:
This flag may be used with migration APIs to request compression of
migration data.
---
include/libvirt/libvirt.h.in | 1 +
tools/virsh-domain.c | 8
We are supposed to enter the freeze early Monday, so please
try to push features today or over the w.e. , if there is something
serious pending and that should go in and is in trouble please reply
so it gets the required attention and can be processed in time :-)
thanks !
Daniel
--
Daniel
On 02/21/2013 02:04 PM, Peter Krempa wrote:
> On 02/19/13 13:35, Jiri Denemark wrote:
>> This flag may be used with migration APIs to request compression of
>> migration data.
>> ---
>> include/libvirt/libvirt.h.in | 1 +
>> tools/virsh-domain.c | 8
>> tools/virsh.pod
On Wed, Feb 20, 2013 at 1:56 PM, Doug Goldstein wrote:
> Refactor code, clean up error handling, and finally add bond support. The
> last patch optionally supports a patch I submitted to the Linux kernel
> which should go in for 3.9 (it was just accepted for net-next).
>
> After this patch when yo
This patch adds support for a new -Tag in the block of network
configs,
based on a subset of the fifth proposal by Laine Stump in the mailing list
discussion at
https://www.redhat.com/archives/libvir-list/2012-November/msg01054.html. Any
such defined
option will result in a dhcp-option=,"" stat
On 02/19/13 13:35, Jiri Denemark wrote:
---
daemon/remote.c | 44
src/remote/remote_driver.c | 41 +
src/remote/remote_protocol.x | 14 +-
src/remote_protocol-structs | 12 +++
This allows ":" to be used a separator between each CPU range, so the
command-line may look like:
-numa node,cpus=A-B:C-D
Note that the following format, currently used by libvirt:
-numa nodes,cpus=A-B,C-D
will _not_ work, as "," is the option separator for the command-line
option parser, a
On 02/19/13 13:35, Jiri Denemark wrote:
---
python/libvirt-override-api.xml | 6 ++
python/libvirt-override.c | 42 +
2 files changed, 48 insertions(+)
ACK
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/ma
On 02/19/13 13:35, Jiri Denemark wrote:
This is an extensible version of virDomainGetJobInfo.
---
include/libvirt/libvirt.h.in | 205 +++
python/generator.py | 1 +
src/driver.h | 7 ++
src/libvirt.c| 58 ++
On 02/19/13 13:35, Jiri Denemark wrote:
---
src/qemu/qemu_migration.c| 59 --
src/qemu/qemu_migration.h| 3 +-
src/qemu/qemu_monitor.c | 43
src/qemu/qemu_monitor.h | 13 +
src/qemu/qemu_monitor_json.c | 118 +++
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> The udev backend now supports bond interfaces.
> ---
> src/interface/interface_backend_udev.c | 264
> -
> 1 file changed, 263 insertions(+), 1 deletion(-)
>
> diff --git a/src/interface/interface_backend_udev.c
> b/
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> Refactored the interface device type identification to make it more
> clear about the operations. Add support for udev devtype to detect
> VLANs on Linux 3.7 and newer. Move VLAN detection based on device
> name to fallback case.
> ---
> src/interfac
On 02/19/13 13:35, Jiri Denemark wrote:
This flag may be used with migration APIs to request compression of
migration data.
---
include/libvirt/libvirt.h.in | 1 +
tools/virsh-domain.c | 8
tools/virsh.pod | 6 --
3 files changed, 13 insertions(+), 2 deletio
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> Mechanical move to break up udevIfaceGetIfaceDef() into different
> helpers for each of the interface types to hopefully make the code
> easier to follow. This moves the vlan code to
> udevIfaceGetIfaceDefVlan().
> ---
> src/interface/interface_backe
Ah, *now* I understand. You did the extra error checking in a separate
patch!
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> Based on feedback from Laine Stump, improve a number of the error
> handling cases to report the issue to the user instead of not generating
> data or giving vague errors.
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> Mechanical move to break up udevIfaceGetIfaceDef() into different
> helpers for each of the interface types to hopefully make the code
> easier to follow. This moves the bridge code to
> udevIfaceGetIfaceDefBridge().
> ---
> src/interface/interface_b
On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > This allows "," to be used a separator between each CPU range. Note
> > that commas inside key=value command-line options have to be escaped
> > using ",,", so the command-line will look like:
> >
On 02/19/13 13:35, Jiri Denemark wrote:
remoteDeserializeTypedParameters can now be called with either
preallocated params array (size of which is announced by nparams) or it
can allocate params array according to the number of parameters received
from the server.
---
src/remote/remote_driver.c
Markus Armbruster writes:
> Eduardo Habkost writes:
>
>> This allows "," to be used a separator between each CPU range. Note
>> that commas inside key=value command-line options have to be escaped
>> using ",,", so the command-line will look like:
>>
>> -numa node,cpus=A,,B,,C,,D
>
> This is
Anthony Liguori writes:
> Markus Armbruster writes:
>
>> Eduardo Habkost writes:
>>
>>> This allows "," to be used a separator between each CPU range. Note
>>> that commas inside key=value command-line options have to be escaped
>>> using ",,", so the command-line will look like:
>>>
>>> -nu
On 02/20/2013 02:56 PM, Doug Goldstein wrote:
> Patch has been accepted into net-next's 3.9 queue to correctly expose
> bond interfaces with the 'bond' devtype.
> ---
> I'd consider this patch optional until the fix lands in Linus' tree.
Optional but innocuous. ACK.
> ---
> src/interface/interfa
On 02/20/2013 12:06 PM, Peter Krempa wrote:
> This patch changes many unrelated places to simplify the code or update
> code style. This patch should not have any semantic impact on the code.
> ---
> src/conf/domain_conf.c | 137
> +
> src/conf/doma
Eduardo Habkost writes:
> This allows "," to be used a separator between each CPU range. Note
> that commas inside key=value command-line options have to be escaped
> using ",,", so the command-line will look like:
>
> -numa node,cpus=A,,B,,C,,D
This is really, really ugly, and an embarrassme
On 02/21/2013 08:49 AM, Christophe Fergeau wrote:
> It's only freed on normal returns from virDomainVideoDefParseXML,
> but not when erroring out.
> ---
> src/conf/domain_conf.c | 1 +
> 1 file changed, 1 insertion(+)
ACK. Again, going with a more idiomatic cleanup label that cleans up on
both s
On 02/21/2013 08:49 AM, Christophe Fergeau wrote:
> It's only freed on normal returns from virDomainVideoDefParseXML,
> but not when erroring out.
> ---
> src/conf/domain_conf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
ACK; your fix is reasonable. A more idiomatic fix might b
This allows "," to be used a separator between each CPU range. Note
that commas inside key=value command-line options have to be escaped
using ",,", so the command-line will look like:
-numa node,cpus=A,,B,,C,,D
Note that the following format, currently used by libvirt:
-numa nodes,cpus=A,B
On 02/21/2013 03:44 AM, Daniel P. Berrange wrote:
> On Wed, Feb 20, 2013 at 03:38:36PM -0700, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=896685 points out
>> a regression caused by commit 38c4a9c - libvirt only labels
>> the backing chain if the backing chain cache is populate
On Thu, Feb 21, 2013 at 9:55 AM, Peter Krempa wrote:
> On 02/18/13 06:11, Doug Goldstein wrote:
>>
>> On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther wrote:
>>>
>>> On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote:
On 01/08/2013 02:36 PM, Doug Goldstein wrote:
>
> I oft
On 02/21/2013 04:21 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> When the virarch.c file was introduced to formalize the arch
> list, we forgot to update the RNG schema with the new arches.
> ---
> docs/schemas/basictypes.rng | 34 ++
> docs/sche
Add support for file descriptor sets by converting some of the
command line parameters to use /dev/fdset/%d if -add-fd is found
to be supported by QEMU. For those devices libvirt now open()s
the device to obtain the file descriptor and 'transfers' the
fd using virCommand.
For the following fragm
Extend the QEMU private domain structure with virFdSet.
Persist the virFdSet using XML and parse its XML.
Free the FdSet upon domain stop.
Stefan Berger
---
v6->v7:
- followed Eric's comments on v6
v5->v6:
- change found in patch 3 moved to this patch
---
src/qemu/qemu_domain.c | 11
Rather than passing the next-to-use file descriptor set Id
and the hash table for remembering the mappings of aliases to
file descriptor sets around, encapsulate the two in a class.
Signed-off-by: Stefan Berger
---
v6->v7:
- followed Eric's & Corey's comments on v6
v5->v6:
- following to
The following patch series adds initial support for QEMU file
descriptor sets implementing support for creating the proper
command line. Some devices are using the sets now.
Regards,
Stefan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 02/15/2013 03:22 AM, Ján Tomko wrote:
> Allow allocating addresses with non-zero bus numbers.
while not actually allowing it :-) (since maxbus is never set to
anything > 0, as you say in Patch 0/2). How/when do you envision that
being changed? liguang's patches allow devices with any bus number
On 02/18/13 06:11, Doug Goldstein wrote:
On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther wrote:
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote:
On 01/08/2013 02:36 PM, Doug Goldstein wrote:
I often find myself doing virsh "define blah.xml; start blah". I figured
adding this would b
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
revision as QEMU sometimes support newer QXL revisions than what
it defaults to.
---
docs/formatdomain.html.in
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 258ee93..0c75838 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/doma
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
---
src/conf/domain_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 10f361c..258ee93 100644
--- a/src/conf/domain_conf.
---
Pushed under the trivial rule.
docs/formatdomain.html.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index ffcc33e..a9003d7 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3583,7 +3583,8
Hey Martin,
Sorry, took me a while to get back to this patch,
On Thu, Feb 14, 2013 at 05:54:02PM +0100, Martin Kletzander wrote:
> On 02/04/2013 04:16 PM, Christophe Fergeau wrote:
> > ---
> > docs/formatdomain.html.in | 5 -
> > docs/schemas/domaincommon.rng
Hi,
After a long time trying to figure out the proper modelling inside QEMU,
I believe the plans are now clearer in QEMU, so it's time to coordinate
more closely with libvirt to try to make use of the new stuff.
I tried to enumerate the libvirt requirements and current problems, and
how we should
This patch documents XML elements used for (basic) support of virtual
RNG devices.
In the devices section in the domain XML users may specify:
For the default 'random' backend:
/dev/urandom
For the slightly more advanced EGD backend:
Qemu's implementation of virtio RNG supports rate limiting of the
entropy used. This patch exposes the option to tune this fucntionality.
This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4
The rate limiting is exported in the XML as:
...
4321
...
---
Notes
This patch adds a new capability bit QEMU_CAPS_OBJECT_RNG_EGD and code
to support the egd backend for the VirtIO RNG device.
The device is added by 3 qemu command line options:
-chardev socket,id=charrng0,host=1.2.3.4,port=1234 (communication
bac
This patch adds a fake switch statement to force the compiler to warn
after a new device type was added. This should remind the contributor to
add the new device also to this iterator function.
---
Notes:
Version 2:
- NEW in series, kind of RFC
src/conf/domain_conf.c | 29 +++
---
Notes:
Version 2:
- ACKed, no change, doesn't make sense to push alone
src/conf/domain_conf.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 082f1f5..b6de57c 100644
--- a/src/conf/domain_con
This patch adds basic configuration support for the RNG device suporting
the virtio model with the "random" and "egd" backend types as described
in the schema in the previous patch.
---
Notes:
Version 2:
- fix a ton of memory leaks (I assumed that virXMLGetProp returns static
strings)
Adds XML parsing and qemu commandline tests for the VirtIO RNG device
support.
---
Notes:
Version 2:
- ACKed
.../qemuxml2argv-virtio-rng-egd.args | 1 +
.../qemuxml2argv-virtio-rng-egd.xml| 26 ++
.../qemuxml2argv-virtio-rng-random.args
Version 2 fixes comments by John and several improvements I noticed.
There's 1 new patch in this series. See patch notes for more info.
Peter Krempa (8):
conf: Add fake switch statement to warn for new device types
doc: schema: Add basic documentation for the virtual RNG device
support
This patch implements support for the virtio-rng-pci device and the
rng-random backend in qemu.
Two capabilities bits are added to track support for those:
QEMU_CAPS_DEVICE_VIRTIO_RNG - for the device support and
QEMU_CAPS_OBJECT_RNG_RANDOM - for the backend support.
qemu is invoked with these a
On 02/20/13 18:44, Laine Stump wrote:
On 02/20/2013 12:06 PM, Peter Krempa wrote:
Get rid of the "identical" variable in the ABI stability checks in favor
of return statements and break or refactor very long lines where
possible.
---
src/conf/domain_conf.c | 469 +--
If a migration fails, we need to stop all block jobs running so
qemu doesn't try to send data to destination over and over again.
---
src/qemu/qemu_migration.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/q
This function does the source part of NBD magic. It
invokes drive-mirror on each non shared and RW disk with
a source and wait till the mirroring process completes.
When it does we can proceed with migration.
Currently, an active waiting is done: every 500ms libvirt
asks qemu if block-job is finis
This will be used after all migration work is done
to stop NBD server running on destination. It
doesn't take any arguments, just issues a command.
---
src/qemu/qemu_monitor.c | 19 +++
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 21 +++
This will be used with new migration scheme.
This patch creates basically just monitor stub
functions. Wiring them into something useful
is done in later patches.
---
src/qemu/qemu_monitor.c | 22 ++
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 25
At the end of migration, it is important to stop NBD
server and thus release all allocated resources.
---
src/qemu/qemu_migration.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 081a72b..8350f5d 100644
--
This will be used with new migration scheme.
This patch creates basically just monitor stub
functions. Wiring them into something useful
is done in later patches.
---
src/qemu/qemu_monitor.c | 22 +
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 56 +
We need to start NBD server and feed it with all non-,
RW and source-full disks. Moreover, with new virPortAllocator we
must ensure the borrowed port for NBD server will be returned if
either migration completes or qemu process is teared down.
---
src/qemu/qemu_migration.c | 76 +++
This migration cookie is meant for two purposes. The first is to be sent
in begin phase from source to destination to let it know we support new
implementation of VIR_MIGRATE_NON_SHARED_{DISK,INC} so destination can
start NBD server. Then, the second purpose is, destination can let us
know, on whic
This just keeps track whether qemu knows nbd-server-* commands
so we can use it during migration or not.
---
src/qemu/qemu_capabilities.c | 4 +++-
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabil
Since there are many hidden problems with auto-creating storage for the domain
in here, as previous rounds of reviewing the series has shown, I've decided to
not do anything about it for now and the auto allocation is dropped completely.
So we are back to the assumption we already have - users need
v1:
add 2 host node memory cases and update conf
- node_mem_param: tuning host node memory parameters
- node_memory: get host node memory info, including host free
memory, node free memory and node memory stats
- numa_param conf is updated with the 2 new cases
v2:
node_mem_param: polish codes with
From: "Daniel P. Berrange"
When the virarch.c file was introduced to formalize the arch
list, we forgot to update the RNG schema with the new arches.
---
docs/schemas/basictypes.rng | 34 ++
docs/schemas/capability.rng | 17 -
2 files changed, 34 i
On Wed, Feb 20, 2013 at 03:38:36PM -0700, Eric Blake wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=896685 points out
> a regression caused by commit 38c4a9c - libvirt only labels
> the backing chain if the backing chain cache is populated, but
> the code to populate the cache was only condit
On Wed, Feb 20, 2013 at 10:16:43PM -0600, Doug Goldstein wrote:
> Instead of hijacking another thread I figured I'd start a new one. I
> tried to push the branch I had made as requested by Jiri, but I don't
> appear to have access.
>
> $ git push origin v1.0.2-maint
> Counting objects: 30, done.
>
To avoid confusion about usage of this function explicitly document that
this function returns copy of the attribute string.
---
src/util/virxml.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/util/virxml.c b/src/util/virxml.c
index 74f8beb..aa55a33 100644
--- a/src/util/virx
On Mon, Feb 18, 2013 at 17:07:43 +0100, Jiri Denemark wrote:
> After the recent removal of qemu driver locks, implicit driver locks were
> introduced in places that previously relied on being called from functions
> that alread had the driver locked. Thus calling anything complex (such as
> close c
is forbidden inside
---
Pushed as trivial.
docs/formatnetwork.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index adb5bb9..f7c483d 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.ht
On 02/19/13 14:20, John Ferlan wrote:
On 02/13/2013 05:59 AM, Peter Krempa wrote:
Adds XML parsing and qemu commandline tests for the VirtIO RNG device
support.
---
.../qemuxml2argv-virtio-rng-egd.args | 1 +
.../qemuxml2argv-virtio-rng-egd.xml| 26 +
On Thu, Feb 21, 2013 at 09:00:04 +0100, Thierry Parmentelat wrote:
> Hi all
>
> I have 2 additional suggestions for a smoother build with 1.0.2
>
> * I applied this change in my specfile:
> http://git.onelab.eu/?p=libvirt.git;a=commitdiff;h=184bc19ce855e1498f6775b711ea3d37808cd45c
> otherwise lik
Hi all
I have 2 additional suggestions for a smoother build with 1.0.2
* I applied this change in my specfile:
http://git.onelab.eu/?p=libvirt.git;a=commitdiff;h=184bc19ce855e1498f6775b711ea3d37808cd45c
otherwise like I reported already, I end up with a plain libvirt rpm that
requires libvirt-da
74 matches
Mail list logo
