[libvirt] One problem of libvirt for fc18.

2013-03-11 Thread Li Zhang
Hi all, We are trying to compile libvirt on fc18. But it always reports such a problem with rpcgen. "make" fails: GEN lxc/lxc_monitor_protocol.h /usr/bin/rpcgen: C preprocessor failed with exit code 1 cannot shutdown /usr/bin/rpcgen: at ./rpc/genprotocol.pl line 124. make[2]: *** [lxc/lx

Re: [libvirt] [PATCH 1/1] Set legacy USB option with default for ppc64.

2013-03-11 Thread Li Zhang
Sorry for annoying again. Any comment? Thanks a lot. :) On 2013年03月04日 14:47, Li Zhang wrote: From: Li Zhang Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to legacy USB option with default for ppc64.

Re: [libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-11 Thread Gao feng
On 2013/03/11 20:34, Aristeu Rozanski wrote: > On Mon, Mar 11, 2013 at 04:27:58PM +0800, Gao feng wrote: >> On 2013/03/06 23:10, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> To allow the efficient correlation of container audit messages >>> with host hosts, include the pid name

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-11 Thread Eric Blake
On 03/07/2013 11:14 AM, Stefan Berger wrote: > Add support for file descriptor sets by converting some of the > command line parameters to use /dev/fdset/%d if -add-fd is found > to be supported by QEMU. For those devices libvirt now open()s > the device to obtain the file descriptor and 'transfer

Re: [libvirt] libvirtd segfault

2013-03-11 Thread AL13N
Op maandag 11 maart 2013 12:59:08 schreef Eric Blake: > On 03/10/2013 09:25 AM, AL13N wrote: > > regarding > > > > http://www.redhat.com/archives/libvir-list/2012-December/msg01365.html > > > > and > > > > https://www.redhat.com/archives/libvir-list/2012-December/msg00935.html > > There have be

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 02:26:58PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: > >> Markus Armbruster writes: > >> > >> > "Michael S. Tsirkin" writes: > >> > > >> >> On Thu, Mar 07, 2013 at 08:57:52PM +0100

[libvirt] IPv6: getting it to work

2013-03-11 Thread Gene Czarcinski
Before I start creating patches (since it is not only source code but also documentation, schemas, tests, etc), I thought I would run this by you folks for comments/suggestions. With IPv4, it is relatively easy to set up working networks: just use nat/MASQUERADE and things pretty much just wor

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-11 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: >> Markus Armbruster writes: >> >> > "Michael S. Tsirkin" writes: >> > >> >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: >> >>> "Michael S. Tsirkin" writes: >> >>> >> >>> >

Re: [libvirt] using virSetUIDGID() with unprivileged qemu defeats setuid helper

2013-03-11 Thread Eric Blake
On 03/10/2013 10:25 PM, Csaba Henk wrote: > Hi, > > I recently experienced that my qemu guest (which I'm using with > unprivileged user) fails to start with: > > error: internal error process exited while connecting to monitor: > chardev: opening backend "pty" failed > > This happens upon t

Re: [libvirt] [PATCH 4/8] Define internal APIs for managing identities

2013-03-11 Thread Eric Blake
On 03/06/2013 05:49 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Introduce a local object virIdentity for managing security > attributes used to form a client application's identity. > Instances of this object are intended to be used as if they > were immutable, once created & p

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-11 Thread Ján Tomko
On 03/04/2013 08:39 PM, Laine Stump wrote: > On 03/04/2013 11:51 AM, Ján Tomko wrote: >> On 02/19/13 03:25, liguang wrote: >>> if some devices specify a pci bus number that >>> haven't been defined by a pci-bridge controller >>> then fill the required correct controller info >>> silently. >>> >>> A

Re: [libvirt] libvirtd segfault

2013-03-11 Thread Eric Blake
On 03/10/2013 09:25 AM, AL13N wrote: > regarding > > http://www.redhat.com/archives/libvir-list/2012-December/msg01365.html > > and > > https://www.redhat.com/archives/libvir-list/2012-December/msg00935.html There have been several fixes to shutdown since December; can you reproduce the proble

[libvirt] IPv6 migration

2013-03-11 Thread Ján Tomko
Hello. We can only tell QEMU on the destination to listen either on IPv6 or on IPv4. If we're supplied with a numeric v6 address, that's the only thing we need to know to set the listen address to [::]. For hostnames, we can either assume this based on how it resolves by default on the destinati

Re: [libvirt] RFC: vfio pci passthrough support

2013-03-11 Thread Alex Williamson
On Mon, 2013-03-11 at 13:23 -0400, Laine Stump wrote: > VFIO is a new method of doing PCI device assignment ("PCI passthrough" > aka "") available in newish kernels (3.6?; it's in Fedora 18 at > any rate) and via the "vfio-pci" device in qemu-1.4+. In contrast to the > traditional KVM PCI device as

[libvirt] [PATCHv5 3/3] qmp: add path to device_deleted event

2013-03-11 Thread Michael S. Tsirkin
Add QOM path to device deleted event. It now becomes useful to report it for devices which don't have an ID assigned. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt | 9 + hw/qdev.c | 11 --- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/QMP

[libvirt] [PATCHv5 2/3] qom: pass original path to unparent method

2013-03-11 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 393e8

[libvirt] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event for devices with ID, second path adds it for all devices and adds a path fields. Split th

[libvirt] [PATCHv5 1/3] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 17 + hw/qdev.c | 6

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-11 Thread Ján Tomko
On 03/04/2013 04:40 PM, Kevin Wolf wrote: > Am 04.03.2013 um 16:19 hat Daniel P. Berrange geschrieben: >> On Mon, Mar 04, 2013 at 04:05:50PM +0100, Kevin Wolf wrote: >>> >>> I'm not talking about the QEMU cli, but about qcow2 as the format as >>> defined in the spec (which just happens to sit in qe

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: > Markus Armbruster writes: > > > "Michael S. Tsirkin" writes: > > > >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > libvirt has a long-standing bug: when rem

[libvirt] RFC: vfio pci passthrough support

2013-03-11 Thread Laine Stump
VFIO is a new method of doing PCI device assignment ("PCI passthrough" aka "") available in newish kernels (3.6?; it's in Fedora 18 at any rate) and via the "vfio-pci" device in qemu-1.4+. In contrast to the traditional KVM PCI device assignment (available via the "pci-assign" device in qemu), VFIO

Re: [libvirt] [PATCH] qemu: Fix retrieval of maximum number of vCPUs on KVM hosts

2013-03-11 Thread Peter Krempa
On 03/11/13 17:56, Eric Blake wrote: On 03/11/2013 07:59 AM, Peter Krempa wrote: The detection of the maximum number of cpus used incorrect ioctl argument value. This flaw caused that on kvm hosts this returns always "160" as the maximum. This is just a recommended maximum value. The real value

Re: [libvirt] [PATCH] qemu: Fix retrieval of maximum number of vCPUs on KVM hosts

2013-03-11 Thread Eric Blake
On 03/11/2013 07:59 AM, Peter Krempa wrote: > The detection of the maximum number of cpus used incorrect ioctl > argument value. This flaw caused that on kvm hosts this returns always > "160" as the maximum. This is just a recommended maximum value. The real > value is higher than that. > > This p

[libvirt] libvirtd segfault

2013-03-11 Thread AL13N
regarding http://www.redhat.com/archives/libvir-list/2012-December/msg01365.html and https://www.redhat.com/archives/libvir-list/2012-December/msg00935.html This seems like the problem i'm having... is there a permanent solution for this? (i'm using libvirtd with XEN using libxl) almost eve

Re: [libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-11 Thread Aristeu Rozanski
On Mon, Mar 11, 2013 at 04:27:58PM +0800, Gao feng wrote: > On 2013/03/06 23:10, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > To allow the efficient correlation of container audit messages > > with host hosts, include the pid namespace inode in audit > > messages. > > > > The

[libvirt] using virSetUIDGID() with unprivileged qemu defeats setuid helper

2013-03-11 Thread Csaba Henk
Hi, I recently experienced that my qemu guest (which I'm using with unprivileged user) fails to start with: error: internal error process exited while connecting to monitor: chardev: opening backend "pty" failed This happens upon trying to facilitate the

[libvirt] [PATCH] audit: Audit operations done by using VirtIO RNG

2013-03-11 Thread Peter Krempa
This patch adds auditing of resources used by the 'random' backend of virtio RNG. --- If there's desire to audit also use of the "egd" backend that uses a generic character device, a way how to audit this device will need to be introduced. We don't audit useage of chardevs right now. src/conf/dom

[libvirt] [PATCH v3 1/3] virFile: Add APIs for extended attributes handling

2013-03-11 Thread Michal Privoznik
Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual value) virFileRemoveAttr for removing attributes --- diff to v2: -dro

[libvirt] [PATCH v3 3/3] security_dac: Favour ACLs over chown()

2013-03-11 Thread Michal Privoznik
On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we set read write access unconditionally. >From implementation POV, a re

[libvirt] [PATCH v3 2/3] virfile: Introduce internal API for managing ACL

2013-03-11 Thread Michal Privoznik
For now, only three APIs are implemented: virFileGetACL to retrieve permission for a specific user virFileSetACL for setting requested permissions for a specific user, virFileRemoveACL to remove those permissions. --- diff to v2: -Introduced m4 macro to check for libacl -new virFileGetACL API -ACL

[libvirt] [PATCH v3 0/3] Keep original file label

2013-03-11 Thread Michal Privoznik
Yet another rework of $subj. I am still not solving atomicity problem for now. See diff to the patches if you want to know what's changed. Michal Privoznik (3): virFile: Add APIs for extended attributes handling virfile: Introduce internal API for managing ACL security_dac: Favour ACLs ove

Re: [libvirt] [PATCH] nodeGetCellMemory is unused without numactl

2013-03-11 Thread Eric Blake
On 03/09/2013 08:10 AM, Guido Günther wrote: > make[3]: Entering directory `/var/scratch/debian/libvirt/upstream/libvirt/src' > CC libvirt_driver_la-nodeinfo.lo > nodeinfo.c:105:27: error: 'nodeGetCellMemory' declared 'static' but never > defined [-Werror=unused-function] > cc1: all warnings

Re: [libvirt] [PATCH] nodeinfo: don't define nodeGetCellMemory if it isn't ever used

2013-03-11 Thread Eric Blake
On 03/11/2013 03:20 AM, Hu Tao wrote: > On Mon, Mar 11, 2013 at 05:12:25PM +0800, Osier Yang wrote: >> On 2013年03月11日 16:57, Hu Tao wrote: >>> >>> Signed-off-by: Hu Tao >>> --- >>> src/nodeinfo.c | 10 ++ >>> 1 file changed, 2 insertions(+), 8 deletions(-) >> But I like this more, as it a

Re: [libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Eric Blake
On 03/11/2013 06:48 AM, Peter Krempa wrote: > On 03/11/13 13:40, Ján Tomko wrote: >> Properly check the return value of vshCommandOptStringReq for xmlfile: >> * error out on incorrect input (--xmlfile '') >> * use default XML with no --xmlfile specified >> >> (Broken by commit b2e8585) >> >> Bug:

Re: [libvirt] [PATCH] docs: Clarify semantics of sparse storage volumes

2013-03-11 Thread Eric Blake
On 03/11/2013 07:46 AM, Jiri Denemark wrote: > Sparse LVM volumes do not behave in the way one would naively expect. > The allocation does not automatically increase (which is different from > how sparse files work). > --- > docs/formatstorage.html.in | 6 +- > 1 file changed, 5 insertions(+),

Re: [libvirt] [PATCHv3 27/27] conf: Enforce ranges on cputune variables

2013-03-11 Thread Peter Krempa
On 03/11/13 16:06, Peter Krempa wrote: The limits are documented at http://libvirt.org/formatdomain.html#elementsCPUTuning . Enforce them when going through XML parsing in addition to being enforced by the API. --- src/conf/domain_conf.c | 37 + 1 file chang

[libvirt] [PATCHv3 27/27] conf: Enforce ranges on cputune variables

2013-03-11 Thread Peter Krempa
The limits are documented at http://libvirt.org/formatdomain.html#elementsCPUTuning . Enforce them when going through XML parsing in addition to being enforced by the API. --- src/conf/domain_conf.c | 37 + 1 file changed, 37 insertions(+) diff --git a/src/conf

[libvirt] [PATCHv3 22/27] qemu: Record the default NIC model in the domain XML

2013-03-11 Thread Peter Krempa
This patch implements the callback that is used to fill the qemu default network card into the XML if none is specified. Libvirt assumes that the network card for qemu if none specified is the "rtl8139". Record this in the XML using the new callback to avoid user confusion. --- src/qemu/qemu_conf

[libvirt] [PATCHv3 25/27] virCaps: get rid of defaultDiskDriverName

2013-03-11 Thread Peter Krempa
This patch removes the defaultDiskDriverName from the virCaps structure. This particular default value is used only in the qemu driver so this patch uses the recently added callback to fill the driver name if it's needed instead of propagating it through virCaps. --- src/conf/capabilities.h

[libvirt] [PATCHv3 26/27] virCaps: get rid of emulatorRequired

2013-03-11 Thread Peter Krempa
This patch removes the emulatorRequired field and associated infrastructure from the virCaps object. Instead the driver specific callbacks are used as this field isn't enforced by all drivers. This patch implements the appropriate callbacks in the qemu and lxc driver and moves to check to that loc

[libvirt] [PATCHv3 23/27] fix fallout of the change of the network device default

2013-03-11 Thread Peter Krempa
--- tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-net-client.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml| 1

[libvirt] [PATCHv3 20/27] fix fallout from adding new parameter to internal APIs

2013-03-11 Thread Peter Krempa
--- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 ++ src/libxl/libxl_driver.c | 6 -- src/lxc/lxc_driver.c | 6 -- src/openvz/openvz_driver.c | 4 ++-- src/phyp/phyp_driver.c | 4 ++-- src/qemu/qemu_driver.c | 11 +++ src/uml/uml_driver.

[libvirt] [PATCHv3 12/27] fix fallout in src/uml

2013-03-11 Thread Peter Krempa
--- src/uml/uml_conf.h | 1 + src/uml/uml_driver.c | 29 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/src/uml/uml_conf.h b/src/uml/uml_conf.h index ff71b45..488c1b7 100644 --- a/src/uml/uml_conf.h +++ b/src/uml/uml_conf.h @@ -63,6 +63,7 @@ struc

[libvirt] [PATCHv3 09/27] fix fallout in tests/

2013-03-11 Thread Peter Krempa
--- tests/domainsnapshotxml2xmltest.c | 5 + tests/lxcxml2xmltest.c| 7 ++- tests/qemuargv2xmltest.c | 8 ++-- tests/qemumonitorjsontest.c | 29 +++-- tests/qemumonitortestutils.c | 4 ++-- tests/qemumonitortestutils.h |

[libvirt] [PATCHv3 18/27] fix fallout in selinux test

2013-03-11 Thread Peter Krempa
--- tests/securityselinuxlabeltest.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c index 2454772..405bc2b 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -44,6 +44

[libvirt] [PATCHv3 16/27] fix fallout in src/libxl

2013-03-11 Thread Peter Krempa
--- src/libxl/libxl_conf.h | 1 + src/libxl/libxl_driver.c | 51 ++-- 2 files changed, 33 insertions(+), 19 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 4c3280e..f8602b4 100644 --- a/src/libxl/libxl_conf.h +++ b/src

[libvirt] [PATCHv3 15/27] fix fallout in aahelper code

2013-03-11 Thread Peter Krempa
--- src/security/virt-aa-helper.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 8ce1f53..c1a3ec9 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -71,6 +71,7 @@ type

[libvirt] [PATCHv3 10/27] fix fallout in src/xen

2013-03-11 Thread Peter Krempa
--- src/xen/xen_driver.c| 8 ++-- src/xen/xen_driver.h| 1 + src/xen/xend_internal.c | 8 src/xen/xm_internal.c | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index d896893..fd20b73 100644 --- a/src/xen/xen

[libvirt] [PATCHv3 17/27] fix fallout in src/xenapi

2013-03-11 Thread Peter Krempa
--- src/xenapi/xenapi_driver.c | 34 ++ src/xenapi/xenapi_driver_private.h | 1 + 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index df7ab36..b368f48 100644 --- a/src/xenapi/xenapi_

[libvirt] [PATCHv3 19/27] conf: Add separate defaults addition and validation for XML parsing

2013-03-11 Thread Peter Krempa
This patch adds instrumentation that will ultimately allow to split out filling of defaults and input validation from the XML parser to separate functions. With this patch, after the XML is parsed, a callback to the driver is issued requesing to fill and validate driver specific details of the con

[libvirt] [PATCHv3 21/27] conf: Add argument to support use of the driver adjust callbacks

2013-03-11 Thread Peter Krempa
This patch adds a argument to the virDomainXMLConfNew constructor to pass the driver adjust callback pointers and fixes the fallout of this change. --- src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/esx/esx_driver.c | 2 +- src/libxl/libxl_driver

[libvirt] [PATCHv3 14/27] fix fallout in vbox driver

2013-03-11 Thread Peter Krempa
--- src/vbox/vbox_tmpl.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index cd88579..aa7466b 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -193,6 +193,7 @@ typedef struct { unsigned long

[libvirt] [PATCHv3 24/27] virCaps: get rid of "defaultInitPath" value in the virCaps struct

2013-03-11 Thread Peter Krempa
This gets rid of the parameter in favor of using the new callback infrastructure to do the same stuff. This patch implements the domain adjustment callback in the openVZ driver and moves the check from the parser to a new validation method in the callback infrastructure. --- src/conf/capabilities

[libvirt] [PATCHv3 08/27] fix fallout in src/qemu/

2013-03-11 Thread Peter Krempa
--- src/qemu/qemu_command.c | 9 ++-- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_conf.c | 10 ++-- src/qemu/qemu_conf.h | 4 ++ src/qemu/qemu_domain.c| 58 +- src/qemu/qemu_domain.h| 6 +-- src/qemu/qemu_driver.c| 123 +

[libvirt] [PATCHv3 04/27] fix fallout in src/lxc

2013-03-11 Thread Peter Krempa
--- src/Makefile.am | 1 + src/lxc/lxc_conf.c | 8 src/lxc/lxc_conf.h | 2 ++ src/lxc/lxc_controller.c | 7 ++- src/lxc/lxc_domain.c | 13 ++--- src/lxc/lxc_domain.h | 2 +- src/lxc/lxc_driver.c | 43 ---

[libvirt] [PATCHv3 01/27] virCaps: conf: start splitting out irrelevat data

2013-03-11 Thread Peter Krempa
The virCaps structure gathered a ton of irrelevant data over time that. The original reason is that it was propagated to the XML parser functions. This patch aims to create a new data structure virDomainXMLConf that will contain immutable data that are used by the XML parser. This will allow two t

[libvirt] [PATCHv3 11/27] fix fallout in src/vmware

2013-03-11 Thread Peter Krempa
--- src/vmware/vmware_conf.c | 3 ++- src/vmware/vmware_conf.h | 1 + src/vmware/vmware_driver.c | 25 + 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index a17b2e1..19be62a 100644 --- a/src/vmware/

[libvirt] [PATCHv3 13/27] fix fallout in test driver

2013-03-11 Thread Peter Krempa
--- src/test/test_driver.c | 61 ++ 1 file changed, 42 insertions(+), 19 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 0037a6f..c5fffb9 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -82,6 +82,7

[libvirt] [PATCHv3 02/27] fix fallout in src/conf/

2013-03-11 Thread Peter Krempa
--- src/conf/domain_conf.c | 104 +-- src/conf/domain_conf.h | 20 ++--- src/conf/snapshot_conf.c | 3 +- src/conf/snapshot_conf.h | 1 + src/libvirt_private.syms | 2 + 5 files changed, 83 insertions(+), 47 deletions(-) diff --git a/src/

[libvirt] [PATCHv3 07/27] fix fallout in phyp driver

2013-03-11 Thread Peter Krempa
--- src/phyp/phyp_driver.c | 8 ++-- src/phyp/phyp_driver.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8c67338..59cc1ca 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1204,6 +1204,9 @@ phypOp

[libvirt] [PATCHv3 05/27] fix fallout in src/openvz

2013-03-11 Thread Peter Krempa
--- src/openvz/openvz_conf.c | 3 ++- src/openvz/openvz_conf.h | 1 + src/openvz/openvz_driver.c | 16 ++-- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index fde32ce..f175655 100644 --- a/src/openvz/openvz_co

[libvirt] [PATCHv3 06/27] fix fallout in src/parallels

2013-03-11 Thread Peter Krempa
--- src/parallels/parallels_driver.c | 12 src/parallels/parallels_utils.h | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 8f8fdac..88f41f7 100644 --- a/src/parallels/parallels_driver.c +

[libvirt] [PATCHv3 00/27] Driver XML conf adjustment callbacks [READ FIRST]

2013-03-11 Thread Peter Krempa
This series implements the driver XML parsing callbacks as Dan suggested. This series may appear to be monstrous but I chose to split some patches to separate ones although the code does not compile afterwards to ease review. !! READ THIS: !! !! The patches starting with the word "fix" will need

[libvirt] [PATCHv3 03/27] fix fallout in src/esx

2013-03-11 Thread Peter Krempa
--- src/esx/esx_driver.c | 14 ++ src/esx/esx_private.h | 2 ++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 046035d..fc8a3ae 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -71,6 +71,7 @@ esxFreePri

Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

2013-03-11 Thread Osier Yang
On 2013年03月11日 21:22, Paolo Bonzini wrote: Il 11/03/2013 11:44, Osier Yang ha scritto: On 2013年02月26日 01:44, Paolo Bonzini wrote: libiscsi provides a userspace iSCSI initiator. The main advantage over the kernel initiator is that it is very easy to provide different initiator names for VMs on

Re: [libvirt] [PATCH 05/13] qemu: support NBD with Unix sockets

2013-03-11 Thread Osier Yang
On 2013年03月11日 21:20, Paolo Bonzini wrote: Il 11/03/2013 10:34, Osier Yang ha scritto: +if (STRPREFIX(host, "unix:/")) { +src = strchr(host + strlen("unix:"), ':'); +if (src) +*src++ = '\0'; Same comments as previous patches. I think in this case the value th

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-11 Thread Osier Yang
On 2013年03月11日 21:16, Paolo Bonzini wrote: Il 11/03/2013 04:23, Osier Yang ha scritto: On 2013年02月26日 01:44, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it in

Re: [libvirt] [libvirt-designer] Fix FSF address

2013-03-11 Thread Eric Blake
On 03/11/2013 05:36 AM, Christophe Fergeau wrote: > A few files were using the old address. > --- > libvirt-designer/libvirt-designer-domain.c | 2 +- > libvirt-designer/libvirt-designer-domain.h | 2 +- > libvirt-designer/test-designer-domain.c| 2 +- > 3 files changed, 3 insertions(+), 3 del

[libvirt] [PATCH] qemu: Fix retrieval of maximum number of vCPUs on KVM hosts

2013-03-11 Thread Peter Krempa
The detection of the maximum number of cpus used incorrect ioctl argument value. This flaw caused that on kvm hosts this returns always "160" as the maximum. This is just a recommended maximum value. The real value is higher than that. This patch tweaks the detection function to behave as describe

[libvirt] [PATCH] docs: Clarify semantics of sparse storage volumes

2013-03-11 Thread Jiri Denemark
Sparse LVM volumes do not behave in the way one would naively expect. The allocation does not automatically increase (which is different from how sparse files work). --- docs/formatstorage.html.in | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/formatstorage.html.in b

Re: [libvirt] [libvirt-designer PATCHv2] Remove FSF address from a few files

2013-03-11 Thread Christophe Fergeau
On Mon, Mar 11, 2013 at 02:16:32PM +0100, Michal Privoznik wrote: > On 11.03.2013 14:07, Christophe Fergeau wrote: > > It was wrong after the FSF moved, and this is not how the > > licensing boilerplate is written in other source files. > > --- > > libvirt-designer/libvirt-designer-domain.c | 4 ++

Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 11:44, Osier Yang ha scritto: > On 2013年02月26日 01:44, Paolo Bonzini wrote: >> libiscsi provides a userspace iSCSI initiator. >> >> The main advantage over the kernel initiator is that it is very >> easy to provide different initiator names for VMs on the same host. >> Thus libiscsi su

Re: [libvirt] [PATCH 06/13] qemu: support URI syntax for NBD

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 11:09, Osier Yang ha scritto: >> >> +if (!STREQ(uri->scheme, scheme)) { >> +virReportError(VIR_ERR_INTERNAL_ERROR, >> + _("Invalid transport/scheme '%s'"), uri->scheme); >> +goto error; >> +} > > How about uri->scheme is "gluster", and sc

Re: [libvirt] [PATCH 05/13] qemu: support NBD with Unix sockets

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 10:34, Osier Yang ha scritto: >> >> +if (STRPREFIX(host, "unix:/")) { >> +src = strchr(host + strlen("unix:"), ':'); >> +if (src) >> +*src++ = '\0'; > > Same comments as previous patches. I think in this case the value that is assigned to src is compl

Re: [libvirt] [PATCH 03/13] qemu: rewrite NBD command-line builder and parser

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 04:38, Osier Yang ha scritto: > On 2013年02月26日 01:44, Paolo Bonzini wrote: >> Move the code to an external function, and structure it to prepare >> the addition of new features in the next few patches. >> >> Signed-off-by: Paolo Bonzini >> --- >> src/qemu/qemu_command.c | 128 >> +++

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 04:23, Osier Yang ha scritto: > On 2013年02月26日 01:44, Paolo Bonzini wrote: >> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in >> release 0.10.0. Thus the code to support network disks without -drive >> is dead, and in fact it incorrectly escapes commas. Drop it.

Re: [libvirt] [libvirt-designer PATCHv2] Remove FSF address from a few files

2013-03-11 Thread Michal Privoznik
On 11.03.2013 14:07, Christophe Fergeau wrote: > It was wrong after the FSF moved, and this is not how the > licensing boilerplate is written in other source files. > --- > libvirt-designer/libvirt-designer-domain.c | 4 ++-- > libvirt-designer/libvirt-designer-domain.h | 4 ++-- > libvirt-designe

Re: [libvirt] [libvirt-designer] Fix FSF address

2013-03-11 Thread Christophe Fergeau
Self NACK, I just sent a v2 removing the FSF address from these files, and pointing at the fsf website instead as suggested by Laine in my libvirt-glib patch. Christophe On Mon, Mar 11, 2013 at 12:36:16PM +0100, Christophe Fergeau wrote: > A few files were using the old address. > --- > libvirt-

[libvirt] [libvirt-designer PATCHv2] Remove FSF address from a few files

2013-03-11 Thread Christophe Fergeau
It was wrong after the FSF moved, and this is not how the licensing boilerplate is written in other source files. --- libvirt-designer/libvirt-designer-domain.c | 4 ++-- libvirt-designer/libvirt-designer-domain.h | 4 ++-- libvirt-designer/test-designer-domain.c| 4 ++-- 3 files changed, 6 in

Re: [libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Ján Tomko
On 03/11/13 13:48, Peter Krempa wrote: > On 03/11/13 13:40, Ján Tomko wrote: >> Properly check the return value of vshCommandOptStringReq for xmlfile: >> * error out on incorrect input (--xmlfile '') >> * use default XML with no --xmlfile specified >> >> (Broken by commit b2e8585) >> >> Bug: https

Re: [libvirt] [libvirt-glib] Fix FSF address

2013-03-11 Thread Christophe Fergeau
On Mon, Mar 11, 2013 at 07:47:34PM +0800, Osier Yang wrote: > Given that the address can be changed unpreditabl, better to change > it as what GNU recommends. Just like libvirt does: > > * You should have received a copy of the GNU Lesser General Public > * License along with this library. If n

Re: [libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Peter Krempa
On 03/11/13 13:40, Ján Tomko wrote: Properly check the return value of vshCommandOptStringReq for xmlfile: * error out on incorrect input (--xmlfile '') * use default XML with no --xmlfile specified (Broken by commit b2e8585) Bug: https://bugzilla.redhat.com/show_bug.cgi?id=919826 --- tools/

[libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Ján Tomko
Properly check the return value of vshCommandOptStringReq for xmlfile: * error out on incorrect input (--xmlfile '') * use default XML with no --xmlfile specified (Broken by commit b2e8585) Bug: https://bugzilla.redhat.com/show_bug.cgi?id=919826 --- tools/virsh-snapshot.c | 4 +++- 1 file chang

Re: [libvirt] [libvirt-glib] Fix FSF address

2013-03-11 Thread Osier Yang
On 2013年03月11日 19:35, Christophe Fergeau wrote: The FSF moved a while ago, this commit adjusts the address we are using in the copyright header in each source file. --- examples/conn-test.c | 2 +- libvirt-gconfig/libvirt-gconfig-capabilities-cpu

[libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-11 Thread Christophe Fergeau
The text version of LGPLv2.1 available at http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly different from COPYING.LIB: - several paragraphs were rewrapped - the FSF address has changed, so the license has been changed to indicate the newer address I've checked that there are no

[libvirt] [libvirt-designer] Fix FSF address

2013-03-11 Thread Christophe Fergeau
A few files were using the old address. --- libvirt-designer/libvirt-designer-domain.c | 2 +- libvirt-designer/libvirt-designer-domain.h | 2 +- libvirt-designer/test-designer-domain.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-doma

Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

2013-03-11 Thread Osier Yang
On 2013年02月26日 01:44, Paolo Bonzini wrote: libiscsi provides a userspace iSCSI initiator. The main advantage over the kernel initiator is that it is very easy to provide different initiator names for VMs on the same host. Thus libiscsi supports usage of persistent reservations in the VM, which o

Re: [libvirt] [PATCH] lxc: Init activeUsbHostdevs

2013-03-11 Thread Guido Günther
On Mon, Mar 11, 2013 at 09:56:19AM +0800, Osier Yang wrote: > On 2013年03月09日 23:08, Guido Günther wrote: > >otherwise we crash with > > > > #0 virUSBDeviceListFind (list=0x0, dev=dev@entry=0x8193d70) at > > util/virusb.c:526 > > #1 0xb1a4995b in virLXCPrepareHostdevUSBDevices > > (driver=driv

Re: [libvirt] [PATCH] Convert HAVE_SELINUX to WITH_SELINUX

2013-03-11 Thread Guido Günther
On Mon, Mar 11, 2013 at 09:54:42AM +0800, Osier Yang wrote: > On 2013年03月09日 23:08, Guido Günther wrote: > >these were missed by 63f18f378693cac6b6e33f4a8c15c20cb191c7c8 > >--- > > src/lxc/lxc_container.c |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/src/lxc/

Re: [libvirt] [PATCH 07/13] domain: add support for iscsi network disks

2013-03-11 Thread Osier Yang
On 2013年02月26日 01:44, Paolo Bonzini wrote: This plumbs in the XML description of iSCSI shares. The next patches will add support for the libiscsi userspace initiator. Signed-off-by: Paolo Bonzini --- docs/formatdomain.html.in | 7 +- docs/schemas/domaincommon.rn

Re: [libvirt] [PATCH 06/13] qemu: support URI syntax for NBD

2013-03-11 Thread Osier Yang
On 2013年02月26日 01:44, Paolo Bonzini wrote: QEMU 1.3 and newer support an alternative URI-based syntax to specify the location of an NBD server. Libvirt can keep on using the old syntax in general, but only the URI syntax supports IPv6 addresses. The URI syntax also supports relative paths to Un

Re: [libvirt] [PATCH] bandwidth: Require network QoS if interface uses 'floor'

2013-03-11 Thread Michal Privoznik
On 11.03.2013 04:53, Laine Stump wrote: > On 03/07/2013 05:02 AM, Michal Privoznik wrote: >> By current implementation, network inbound is required in order >> to use 'floor' for guaranteeing minimal throughput. This is so, >> because we want user to tell us the maximal throughput of the >> networ

Re: [libvirt] [PATCH 05/13] qemu: support NBD with Unix sockets

2013-03-11 Thread Osier Yang
On 2013年02月26日 01:44, Paolo Bonzini wrote: This reuses the XML format that was introduced for Gluster. Signed-off-by: Paolo Bonzini --- docs/formatdomain.html.in | 8 ++-- src/qemu/qemu_command.c| 49 +++--- tests/qemuargv

Re: [libvirt] [PATCH] nodeinfo: don't define nodeGetCellMemory if it isn't ever used

2013-03-11 Thread Hu Tao
On Mon, Mar 11, 2013 at 05:12:25PM +0800, Osier Yang wrote: > On 2013年03月11日 16:57, Hu Tao wrote: > > > >Signed-off-by: Hu Tao > >--- > > src/nodeinfo.c | 10 ++ > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > >diff --git a/src/nodeinfo.c b/src/nodeinfo.c > >index b80e389..415c2e

Re: [libvirt] [PATCH] nodeinfo: don't define nodeGetCellMemory if it isn't ever used

2013-03-11 Thread Osier Yang
On 2013年03月11日 16:57, Hu Tao wrote: Signed-off-by: Hu Tao --- src/nodeinfo.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index b80e389..415c2e5 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -102,7 +102,6 @@ static int li

[libvirt] [PATCH] nodeinfo: don't define nodeGetCellMemory if it isn't ever used

2013-03-11 Thread Hu Tao
Signed-off-by: Hu Tao --- src/nodeinfo.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index b80e389..415c2e5 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -102,7 +102,6 @@ static int linuxNodeGetMemoryStats(FILE *meminfo,

Re: [libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-11 Thread Gao feng
On 2013/03/06 23:10, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > To allow the efficient correlation of container audit messages > with host hosts, include the pid namespace inode in audit > messages. > > The resulting audit message will be > > type=VIRT_CONTROL msg=audit(13625824

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-11 Thread li guang
在 2013-03-06三的 13:13 +0800,li guang写道: > 在 2013-03-05二的 10:36 +,Daniel P. Berrange写道: > > On Mon, Mar 04, 2013 at 02:39:40PM -0500, Laine Stump wrote: > > > On 03/04/2013 11:51 AM, Ján Tomko wrote: > > > > On 02/19/13 03:25, liguang wrote: > > > >> if some devices specify a pci bus number that