[libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 9becd07..69d1e62 100644 ---

[libvirt] [PATCH] Fix a copypaste error for virsh dump help

2013-03-15 Thread Yanbing Du
Signed-off-by: Yanbing Du y...@redhat.com --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ab90f58..aa45e72 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4358,7 +4358,7 @@ static

Re: [libvirt] [PATCH] Fix a copypaste error for virsh dump help

2013-03-15 Thread Osier Yang
On 2013年03月15日 15:40, Yanbing Du wrote: Signed-off-by: Yanbing Duy...@redhat.com --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ab90f58..aa45e72 100644 --- a/tools/virsh-domain.c +++

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Osier Yang
On 2013年03月15日 15:23, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c

[libvirt] [PATCH v2 2/2] json: add test for virJSONValueFromStream function

2013-03-15 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- tests/jsontest.c | 205 - 1 files changed, 201 insertions(+), 4 deletions(-) diff --git a/tests/jsontest.c b/tests/jsontest.c index 98a6069..107d772 100644 --- a/tests/jsontest.c +++

[libvirt] [PATCH v2 1/2] json: add stream parser

2013-03-15 Thread Dmitry Guryanov
Add function virJSONValueFromStream, which reads data from a stream and passes it to json parser. When end of the object is reached, it returns this object. To avoid reading from the stream by single bytes it reads to a buffer (in a structure virJSONStreamParserState), which should be passed to a

Re: [libvirt] [PATCHv3] audit: Audit resources used by VirtIO RNG

2013-03-15 Thread Peter Krempa
On 03/13/13 11:21, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 10:46:24AM +0100, Peter Krempa wrote: This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited. The audit logs look like: For the 'random' backend:

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virGetNumadAdvice

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename it to virGetNumaAdvice and move it to virnuma.c s/virGetNumaAdvice/virGetNumadAdvice/, Signed-off-by: Gao fenggaof...@cn.fujitsu.com --- po/POTFILES.in | 1 + src/Makefile.am |

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Viktor Mihajlovski
On 03/15/2013 12:28 AM, Eric Blake wrote: -if (conn-closeFreeCallback) +if (conn-closeCallback) +conn-closeCallback = NULL; The if is pointless. Just blindly set conn-closeCallback to NULL. agreed + +if (conn-closeFreeCallback) {

Re: [libvirt] [PATCH 2/4] LXC: allow uses advisory nodeset from querying numad

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: Allow lxc using the advisory nodeset from querying numad, this means if user doesn't specify the numa nodes that the lxc domain should assign to, libvirt will automatically bind the lxc domain to the advisory nodeset which queried from numad. Signed-off-by:

Re: [libvirt] [PATCHv3 3/3] S390: Testcases for virtio-scsi and virtio-rng

2013-03-15 Thread Viktor Mihajlovski
On 03/14/2013 11:05 PM, Eric Blake wrote: ACK, and pushed. Big thanks, again. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft:

Re: [libvirt] [PATCH 3/4] remove the redundant codes

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: Intend to reduce the redundant code,use virSetupNumaMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. Signed-off-by: Gao fenggaof...@cn.fujitsu.com --- src/conf/domain_conf.h | 23 +

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-15 Thread Christophe Fergeau
Ping? On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote: The text version of LGPLv2.1 available at http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly different from COPYING.LIB: - several paragraphs were rewrapped - the FSF address has changed, so the license

Re: [libvirt] [[PATCHv2]] Add support for qxl.revision in domain XML

2013-03-15 Thread Christophe Fergeau
ping? On Thu, Feb 21, 2013 at 04:49:53PM +0100, Christophe Fergeau wrote: QXL devices have an associated 'revision' which is raised when new features have been introduced which would break migration to older versions. This commit makes it possible to set this revision as QEMU sometimes

Re: [libvirt] [PATCH V1 4/6] Add SELinux labeling support for TPM

2013-03-15 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 08:00:21PM -0400, Stefan Berger wrote: On 03/14/2013 06:34 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 04:24:27PM -0400, Stefan Berger wrote: On 03/14/2013 10:29 AM, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 12:03:52PM -0400, Stefan Berger wrote:

[libvirt] [PATCHv2 2/2] Add USB option capability

2013-03-15 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com To avoid the collision for creating USB controllers in machine-init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine-init(). So that libvirt can use -device or -usb to create USB controller

[libvirt] [PATCHv2 1/2] Optimize machine option to set more options with it.

2013-03-15 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -machine option is used only when dump-guest-core is set. To use options defined in machine option for newer version of QEMU, it needs to use -machine xxx, and to be compatible with older version -M, this patch addes QEMU_CAPS_MACHINE_OPT

Re: [libvirt] [PATCHv2 2/2] Add USB option capability

2013-03-15 Thread Li Zhang
On 2013年03月15日 17:19, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com To avoid the collision for creating USB controllers in machine-init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine-init(). So that libvirt can use -device or

[libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

2013-03-15 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information is not right on ppc64 and vpuinfo, vcpupin can't work

Re: [libvirt] [PATCH 4/4] LXC: add cpuset cgroup support for lxc

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: This patch adds cpuset cgroup support for LXC. also set cpuset cgroup before setting cpu affinity and numa policy. Any special reason to move lxcSetupCgroup before the CPU affinity and NUMA setttings? Signed-off-by: Gao fenggaof...@cn.fujitsu.com ---

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
On 03/15/2013 04:02 PM, Osier Yang wrote: On 2013年03月15日 15:23, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 10:08:37AM +0100, Christophe Fergeau wrote: Ping? On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote: The text version of LGPLv2.1 available at http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly different from COPYING.LIB: -

[libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 90217f1..f96d417 100644 ---

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 01:26:55PM +0100, Viktor Mihajlovski wrote: A race condition can occur when virConnectClose is called parallel to the execution of the connection close callback in remoteClientCloseFunc. The race happens if the connection object is destroyed (including the mutex)

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virGetNumadAdvice

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 04:13:30PM +0800, Osier Yang wrote: On 2013年03月01日 14:52, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename it to virGetNumaAdvice and move it to virnuma.c s/virGetNumaAdvice/virGetNumadAdvice/, diff --git a/src/util/virnuma.h

Re: [libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:25:09PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information

Re: [libvirt] [PATCH 3/4] remove the redundant codes

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:03:47PM +0800, Osier Yang wrote: diff --git a/src/util/virnuma.h b/src/util/virnuma.h index b9046c2..8d9f14d 100644 --- a/src/util/virnuma.h +++ b/src/util/virnuma.h @@ -22,7 +22,31 @@ #ifndef __VIR_NUMA_H__ # define __VIR_NUMA_H__ +#include virbitmap.h +

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:32:24PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
On 03/15/2013 05:44 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:32:24PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Viktor Mihajlovski
On 03/15/2013 10:33 AM, Daniel P. Berrange wrote: No, this really isn't solving the problem. The virConnectDipose function is the last thing to run on an object. Once virConnectDispose is running absolutely nothing else may safely use that object pointer. The thread that is not in

Re: [libvirt] [libvirt-sandbox][PATCH v2] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:50:32PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c

Re: [libvirt] [libvirt-sandbox][PATCH v2] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
On 03/15/2013 05:52 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:50:32PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[libvirt] [libvirt-sandbox][PATCH v2] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 90217f1..08d21b9 100644 ---

Re: [libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

2013-03-15 Thread Osier Yang
On 2013年03月15日 17:42, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:25:09PM +0800, Li Zhang wrote: From: Li Zhangzhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 10:50:08AM +0100, Viktor Mihajlovski wrote: On 03/15/2013 10:33 AM, Daniel P. Berrange wrote: No, this really isn't solving the problem. The virConnectDipose function is the last thing to run on an object. Once virConnectDispose is running absolutely nothing else may

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-15 Thread Christophe Fergeau
On Fri, Mar 15, 2013 at 09:26:08AM +, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 10:08:37AM +0100, Christophe Fergeau wrote: Ping? On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote: The text version of LGPLv2.1 available at

[libvirt] [libvirt-sandbox][PATCH] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 69d1e62..66676c3 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -372,13 +372,19 @@

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: Fix security options wrongs in man page

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 06:29:05PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 69d1e62..66676c3 100644 ---

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
On 03/15/2013 06:42 PM, Daniel P. Berrange wrote: Dynamically allocate an SELinux label, using the base context USER:ROLE:TYPE:LEVEL, instead of the default base context. Thanks for your nice comment, the v2 patch is coming. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [libvirt-sandbox][PATCH v2] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 69d1e62..bd7ac49 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -372,13 +372,22 @@

Re: [libvirt] [libvirt-sandbox][PATCH v2] Docs: Fix security options wrongs in man page

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 06:57:15PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:15 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether to print out the message or not. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 02:10:08PM +0100, Martin Kletzander wrote: On 03/14/2013 06:15 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether

[libvirt] conftest segfault

2013-03-15 Thread Gene Czarcinski
One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this by building libvirt-1.0.3-1 with mock. Gene -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] conftest segfault

2013-03-15 Thread Gene Czarcinski
On 03/15/2013 09:48 AM, Gene Czarcinski wrote: One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this by building libvirt-1.0.3-1 with mock. I went back and looked at my logs more closely.

[libvirt] [PATCH v4 0/3] Keep original file label

2013-03-15 Thread Michal Privoznik
Yet another rework of $subj. I am still not solving atomicity problem for now. See diff to the patches if you want to know what's changed. Patch 1/3 has been already ACKed, however, I've changed it slightly. Michal Privoznik (3): virFile: Add APIs for extended attributes handling virfile:

[libvirt] [PATCH v4 3/3] security_dac: Favour ACLs over chown()

2013-03-15 Thread Michal Privoznik
On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we set read write access unconditionally. From implementation POV, a

[libvirt] [PATCH v4 1/3] virFile: Add APIs for extended attributes handling

2013-03-15 Thread Michal Privoznik
Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual value) virFileRemoveAttr for removing attributes --- diff to v3:

[libvirt] [PATCH v4 2/3] virfile: Introduce internal API for managing ACL

2013-03-15 Thread Michal Privoznik
For now, only three APIs are implemented: virFileGetACL to retrieve permission for a specific user virFileSetACL for setting requested permissions for a specific user, virFileRemoveACL to remove those permissions. --- diff to v3: -set errno=ENOSYS when building without WITH_ATTR for easier check

Re: [libvirt] conftest segfault

2013-03-15 Thread Michal Privoznik
On 15.03.2013 14:56, Gene Czarcinski wrote: On 03/15/2013 09:48 AM, Gene Czarcinski wrote: One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this by building libvirt-1.0.3-1 with mock. I

Re: [libvirt] [PATCH v4 3/3] security_dac: Favour ACLs over chown()

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 03:12:03PM +0100, Michal Privoznik wrote: static int +virSecurityDACSetOwnership(const char *path, uid_t uid, gid_t gid) +{ +int refCount = 0; +bool xattrSupported = true; + +VIR_INFO(Setting DAC user and group on '%s' to '%ld:%ld', + path,

Re: [libvirt] [PATCH v4 1/3] virFile: Add APIs for extended attributes handling

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 03:12:01PM +0100, Michal Privoznik wrote: Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-15 Thread Stefan Berger
On 03/14/2013 10:47 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:44:32AM -0400, Stefan Berger wrote: Hm, this surprises me since this would put JSON specific code into the monitor APIs (qemu_monitor.c) while qemu_monitor.c typically only serves as a dispatcher for either text

Re: [libvirt] [PATCH v4 2/3] virfile: Introduce internal API for managing ACL

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 03:12:02PM +0100, Michal Privoznik wrote: For now, only three APIs are implemented: virFileGetACL to retrieve permission for a specific user virFileSetACL for setting requested permissions for a specific user, virFileRemoveACL to remove those permissions. --- diff

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it incorrectly escapes commas. Drop it. Signed-off-by: Paolo Bonzini

Re: [libvirt] [PATCH 03/13] qemu: rewrite NBD command-line builder and parser

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:22PM +0100, Paolo Bonzini wrote: Move the code to an external function, and structure it to prepare the addition of new features in the next few patches. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/qemu/qemu_command.c | 128

Re: [libvirt] [PATCH 04/13] qemu: support named nbd exports

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:23PM +0100, Paolo Bonzini wrote: These are supported by nbd-server and by the NBD server that QEMU embeds for live image access. But seemingly not by 'qemu-nbd' ? ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCH 05/13] qemu: support NBD with Unix sockets

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:24PM +0100, Paolo Bonzini wrote: This reuses the XML format that was introduced for Gluster. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/formatdomain.html.in | 8 ++-- src/qemu/qemu_command.c|

Re: [libvirt] [PATCH 07/13] domain: add support for iscsi network disks

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:26PM +0100, Paolo Bonzini wrote: This plumbs in the XML description of iSCSI shares. The next patches will add support for the libiscsi userspace initiator. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/formatdomain.html.in

Re: [libvirt] [PATCH 06/13] qemu: support URI syntax for NBD

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:25PM +0100, Paolo Bonzini wrote: QEMU 1.3 and newer support an alternative URI-based syntax to specify the location of an NBD server. Libvirt can keep on using the old syntax in general, but only the URI syntax supports IPv6 addresses. The URI syntax also

Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:48 PM, Eric Blake wrote: On 03/14/2013 11:16 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote: According to the man page, the memspec parameter should have the '--memspec' option mandatory and this is as close as we can get to

Re: [libvirt] [PATCH 04/13] qemu: support named nbd exports

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 15:34, Daniel P. Berrange ha scritto: These are supported by nbd-server and by the NBD server that QEMU embeds for live image access. But seemingly not by 'qemu-nbd' ? No, not yet at least. Paolo -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-15 Thread Martin Kletzander
On 03/15/2013 02:17 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 02:10:08PM +0100, Martin Kletzander wrote: On 03/14/2013 06:15 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which

Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:27PM +0100, Paolo Bonzini wrote: libiscsi provides a userspace iSCSI initiator. The main advantage over the kernel initiator is that it is very easy to provide different initiator names for VMs on the same host. Thus libiscsi supports usage of persistent

Re: [libvirt] [PATCHv3] audit: Audit resources used by VirtIO RNG

2013-03-15 Thread Steve Grubb
On Wednesday, March 13, 2013 10:21:00 AM Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 10:46:24AM +0100, Peter Krempa wrote: This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited. The audit logs look like: For the

Re: [libvirt] [PATCH 4/4] Cleanup useless flags specifications

2013-03-15 Thread Martin Kletzander
On 03/14/2013 06:25 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:35AM +0100, Martin Kletzander wrote: After we switched to C99 initialization, I noticed there were many places where the specification of .flags parameter differed. After going through many options and deciding

Re: [libvirt] [PATCH 12/13] domain: parse XML for iscsi authorization credentials

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:31PM +0100, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/formatdomain.html.in | 12 - docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c

Re: [libvirt] [PATCH 10/13] domain: make port optional for network disks

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:29PM +0100, Paolo Bonzini wrote: Only sheepdog actually required it in the code, and we can use 7000 as the default---the same value that QEMU uses for the simple sheepdog:VOLUME syntax. With this change, the schema can be fixed to allow no port. Signed-off-by:

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Eric Blake
On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it incorrectly

Re: [libvirt] [PATCH 11/13] secret: add iscsi to possible usage types

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:30PM +0100, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/formatsecret.html.in| 12 docs/schemas/secret.rng | 10 ++ include/libvirt/libvirt.h.in | 1 + src/conf/secret_conf.c | 22

Re: [libvirt] [PATCH 14/13] qemu: support passthrough for iscsi disks

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 07:09:14PM +0100, Paolo Bonzini wrote: This enables usage of commands like persistent reservations. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c|

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 10:28:38AM -0400, Stefan Berger wrote: On 03/14/2013 10:47 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:44:32AM -0400, Stefan Berger wrote: Hm, this surprises me since this would put JSON specific code into the monitor APIs (qemu_monitor.c) while

[libvirt] [PATCH 2/3] remote: Don't call NULL closeFreeCallback

2013-03-15 Thread Viktor Mihajlovski
Check function pointer before calling. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/remote/remote_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 3721af9..885120e 100644 ---

[libvirt] [PATCH 1/3] libvirt: Increase connection reference count for callbacks

2013-03-15 Thread Viktor Mihajlovski
By adjusting the reference count of the connection object we prevent races between callback function and virConnectClose. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/libvirt.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c

[libvirt] [PATCH 0/3] Fix virsh race and coredump

2013-03-15 Thread Viktor Mihajlovski
I hope that this is an acceptable solution. The race is caused by referencing a disposed connection object in a callback. In the first patch we make sure that the object reference count is reflecting the callback registration. The second patch prevents the invocation of a NULL callback. The

[libvirt] [PATCHv4 7/9] virCaps: remove defaultDiskDriverType from the struct

2013-03-15 Thread Peter Krempa
Use the qemu specific callback to fill this data in the qemu driver as it's the only place where it was used and fix tests as the qemu test capability object didn't configure the defaults for the tests. --- Notes: Version 4: - new in series src/conf/capabilities.h

[libvirt] [PATCHv4 3/9] virCaps: get rid of defaultInitPath value in the virCaps struct

2013-03-15 Thread Peter Krempa
This gets rid of the parameter in favor of using the new callback infrastructure to do the same stuff. This patch implements the domain adjustment callback in the openVZ driver and moves the check from the parser to a new validation method in the callback infrastructure. --- Notes: Version

[libvirt] [PATCHv4 4/9] virCaps: get rid of defaultDiskDriverName

2013-03-15 Thread Peter Krempa
This patch removes the defaultDiskDriverName from the virCaps structure. This particular default value is used only in the qemu driver so this patch uses the recently added callback to fill the driver name if it's needed instead of propagating it through virCaps. --- Notes: Version 4: -

[libvirt] [PATCHv4 0/9] Introduce driver specific callbacks and get rid of irrelevant data in virCaps

2013-03-15 Thread Peter Krempa
This series now splits out almost everything from the virCaps object (except for the defaultConsoleTargetType callback that I will post later as It requires more tweaking). See notes in individual patches for change summary. Peter Krempa (9): conf: Add post XML parse callbacks and prepare for

[libvirt] [PATCHv4 8/9] virCaps: Get rid of hasWideScsiBus

2013-03-15 Thread Peter Krempa
Use the virDomainXMLConf structure to hold this data. --- Notes: Version 4: - new in series src/conf/capabilities.h| 1 - src/conf/domain_conf.c | 13 +++-- src/conf/domain_conf.h | 8 +++- src/esx/esx_driver.c | 12 +--- src/libvirt_vmx.syms

[libvirt] [PATCHv4 5/9] virCaps: get rid of emulatorRequired

2013-03-15 Thread Peter Krempa
This patch removes the emulatorRequired field and associated infrastructure from the virCaps object. Instead the driver specific callbacks are used as this field isn't enforced by all drivers. This patch implements the appropriate callbacks in the qemu and lxc driver and moves to check to that

[libvirt] [PATCHv4 9/9] virCaps: get rid of macPrefix field

2013-03-15 Thread Peter Krempa
Use the virDomainXMLConf structure to hold this data and tweak the code to avoid semantic change. Without configuration the KVM mac prefix is used by default. I chose it as it's in the privately administered segment so it should be usable for any purposes. --- Notes: Version 4: - new in

[libvirt] [PATCHv4 1/9] conf: Add post XML parse callbacks and prepare for cleaning of virCaps

2013-03-15 Thread Peter Krempa
This patch adds instrumentation that will allow hypervisor drivers to fill and validate domain and device definitions after parsed by the XML parser. With this patch, after the XML is parsed, a callback to the driver is issued requesing to fill and validate driver specific details of the

[libvirt] [PATCHv4 2/9] qemu: Record the default NIC model in the domain XML

2013-03-15 Thread Peter Krempa
This patch implements the devices post parse cllback and uses it to fill the default qemu network card model into the XML if none is specified. Libvirt assumes that the network card model for qemu is the rtl8139. Record this in the XML using the new callback to avoid user confusion. --- Notes:

[libvirt] [PATCHv4 6/9] conf: Enforce ranges on cputune variables

2013-03-15 Thread Peter Krempa
The limits are documented at http://libvirt.org/formatdomain.html#elementsCPUTuning . Enforce them when going through XML parsing in addition to being enforced by the API. --- Notes: Version 4: - changed error from VIR_ERR_XML_ERROR to VIR_ERR_CONFIG_UNSUPPORTED Version 3: - new

Re: [libvirt] conftest segfault

2013-03-15 Thread Eric Blake
On 03/15/2013 07:48 AM, Gene Czarcinski wrote: One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this by building libvirt-1.0.3-1 with mock. Generally, this is not an issue. Autoconf tests

Re: [libvirt] [PATCH 0/8] Simplify mutually exclusive argument handling in virsh

2013-03-15 Thread Peter Krempa
On 03/07/13 13:52, Peter Krempa wrote: This patchset introduces a new macro that allows simple checking for mutually exclusive arguments in virsh and uses it in many occasions in virs. Peter Krempa (8): virsh: Introduce macros to reject mutually exclusive arguments virsh-snapshot:

Re: [libvirt] [PATCH 09/13] qemu: support LUN numbers for iSCSI disks

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 15:40, Daniel P. Berrange ha scritto: Each iSCSI target can provide multiple logical units. Support this with an additional attribute in the source element. Hmm, this is kind of what the 'name' attribute is used for with RBD / Gluster. I tend to feel we should just use that

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 15:43, Eric Blake ha scritto: On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without

Re: [libvirt] [PATCH 09/13] qemu: support LUN numbers for iSCSI disks

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 04:53:19PM +0100, Paolo Bonzini wrote: Il 15/03/2013 15:40, Daniel P. Berrange ha scritto: Each iSCSI target can provide multiple logical units. Support this with an additional attribute in the source element. Hmm, this is kind of what the 'name' attribute is used

Re: [libvirt] conftest segfault

2013-03-15 Thread Gene Czarcinski
On 03/15/2013 10:17 AM, Michal Privoznik wrote: On 15.03.2013 14:56, Gene Czarcinski wrote: On 03/15/2013 09:48 AM, Gene Czarcinski wrote: One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this

Re: [libvirt] conftest segfault

2013-03-15 Thread Gene Czarcinski
On 03/15/2013 11:38 AM, Eric Blake wrote: On 03/15/2013 07:48 AM, Gene Czarcinski wrote: One of the libvirt tests (conftest) has been segfaulting for some time with no indication of a test failure other than a message in syslog. I verified this by building libvirt-1.0.3-1 with mock.

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 04:56:26PM +0100, Paolo Bonzini wrote: Il 15/03/2013 15:43, Eric Blake ha scritto: On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in

Re: [libvirt] [PATCH 09/13] qemu: support LUN numbers for iSCSI disks

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 16:59, Daniel P. Berrange ha scritto: I think IQN and LUN are separate things, and best kept separate. For example, for each IQN you can only have (if you use -readconfig, which this series doesn't do) a single username/password/initiator-name triple. Note that the 'name'

Re: [libvirt] [PATCHv3] audit: Audit resources used by VirtIO RNG

2013-03-15 Thread Steve Grubb
On Wednesday, March 13, 2013 10:46:24 AM Peter Krempa wrote: This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited. Further testing revealed that I needed to make a some updates to the audit package to support this. The auvirt

[libvirt] [PATCH 3/7] Re-arrange code setting up ifs/disk loop devices for LXC

2013-03-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current code for setting up loop devices to LXC disks first does a switch() based on the disk format, then looks at the disk driver name. Reverse this so it first looks at the driver name, and then the disk format. This is more useful since the

[libvirt] [PATCH 1/7] Setup LXC cgroups in two phases

2013-03-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the LXC controller creates the cgroup, configures the resources and adds the task all in one go. This is not sufficiently flexible for the forthcoming NBD integration. We need to make sure the NBD process gets into the right cgroup

[libvirt] [PATCH 0/7] Support NBD volumes with LXC containers

2013-03-15 Thread Daniel P. Berrange
This series adds support for using non-raw disks with LXC containers by leverging NBD + qemu-nbd as an alternative to the loopback device. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 6/7] Support NBD backed disks/filesystems in LXC driver

2013-03-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The LXC driver can already configure disk or filesystem devices to use the loop device. This extends it to also allow for use of the NBD device, to support non-raw formats. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH 2/7] Add support for storage format in FS driver

2013-03-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Extend the driver element in filesystem devices to allow a storage format to be set. The new attribute uses 'format' to reflect the storage format. This is different from the driver element in disk devices which use 'type' to reflect the storage

  1   2   >