---
cfg.mk | 14 ++
1 file changed, 14 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index 394521e..9cf4cff 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -722,6 +722,20 @@ sc_prohibit_exit_in_tests:
halt='use return, not exit(), in tests' \
Detected by a simple Shell script.
---
daemon/libvirtd.c| 1 -
src/conf/node_device_conf.c | 1 -
src/network/bridge_driver.c | 1 -
src/openvz/openvz_conf.c | 1 -
src/openvz/openvz_driver.c | 1 -
src/parallels/parallels_driver.c | 1 -
---
src/remote/remote_driver.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/remote/remote_driver.h b/src/remote/remote_driver.h
index 7288381..bd907c0 100644
--- a/src/remote/remote_driver.h
+++ b/src/remote/remote_driver.h
@@ -24,8 +24,6 @@
#ifndef __VIR_REMOTE_INTERNAL_H__
#
Which is already included by internal.h.
---
src/nodeinfo.h | 1 -
src/phyp/phyp_driver.c | 1 -
src/remote/remote_protocol.x | 1 -
src/util/virkeycode.h| 1 -
4 files changed, 4 deletions(-)
diff --git a/src/nodeinfo.h b/src/nodeinfo.h
index 350f3c3..b0e5fbc 100644
No reason to include it in both if and else branches.
---
tests/domainsnapshotxml2xmltest.c | 4 ++--
tests/esxutilstest.c | 4 ++--
tests/lxcxml2xmltest.c| 4 ++--
tests/openvzutilstest.c | 4 ++--
tests/qemuargv2xmltest.c | 4 ++--
*** BLURB HERE ***
Osier Yang (6):
cleanup: Remove the duplicate header
cleanup: Only include testutils.h once
cleanup: Don't include libvirt/libvirt.h
cleanup: Don't include libvirt/virterror.h
syntax-check: Don't include duplicate header
syntax-check: Don't include libvirt.h and
Except for internal.h and the public headers
---
cfg.mk | 20
1 file changed, 20 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index 9cf4cff..0f07abd 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -736,6 +736,20 @@ sc_prohibit_duplicate_header:
else :;
On Mon, Apr 15, 2013 at 4:43 AM, harryxiyou harryxi...@gmail.com wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote:
On 04/12/13 18:10, Daniel P. Berrange wrote:
On Fri, Apr 12, 2013 at 03:24:56PM +0200, Peter Krempa wrote:
Report the errors as:
Domain not found: no domain with matching uuid
'41414141-4141-4141-4141-414141414141' (crashtest)
instead of:
Domain not found: no domain with matching uuid
On 15.04.2013 04:43, harryxiyou wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote:
On 10.04.2013 15:13, harryxiyou
On 15/04/13 15:56, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 4:43 AM, harryxiyou harryxi...@gmail.com wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at
On Mon, Apr 15, 2013 at 10:43:22AM +0800, harryxiyou wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote:
On
On 04/11/2013 08:11 AM, Gene Czarcinski wrote:
This patch adds support for adding a static route for
a network. The gateway sub-element specifies
the gateway's IP address. Both IPv4 and IPv6
static routes are supported although it is
expected that this functionality will have
more use with
On 15/04/13 16:34, Michal Privoznik wrote:
On 15.04.2013 04:43, harryxiyou wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal
On Mon, Apr 15, 2013 at 10:34:01AM +0200, Michal Privoznik wrote:
On 15.04.2013 04:43, harryxiyou wrote:
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com
wrote:
On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Apr 12, 2013 at
On Wed, Apr 10, 2013 at 03:09:18PM +0100, Richard W.M. Jones wrote:
This patch allows you to use the qemu Secure Shell (ssh) block device.
This is not upstream yet, but you can find my latest version here:
http://lists.nongnu.org/archive/html/qemu-devel/2013-04/threads.html#01703
This
On Mon, Apr 15, 2013 at 10:55:07AM +0800, Li Zhang wrote:
On 2013年04月12日 18:11, Daniel P. Berrange wrote:
On Thu, Apr 11, 2013 at 05:53:41PM +0800, Li Zhang wrote:
On 2013年04月11日 17:41, Daniel P. Berrange wrote:
On Sun, Apr 07, 2013 at 05:00:06PM +0800, Li Zhang wrote:
On 2013年03月14日 14:54,
On Mon, Apr 15, 2013 at 11:11:10AM +0100, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 03:09:18PM +0100, Richard W.M. Jones wrote:
- Not sure how best to deal with the ssh-agent authentication socket
problem. Use libvirt secrets? If so, how?
The way that works, is that the
On Fri, Apr 12, 2013 at 11:46:15AM -0400, Laine Stump wrote:
On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote:
On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote:
On 04/10/2013 05:26 AM, Daniel P. Berrange wrote:
So if we later allowed for mutiple PCI roots, then we'd have
On Mon, Apr 15, 2013 at 11:18:26AM +0100, Richard W.M. Jones wrote:
On Mon, Apr 15, 2013 at 11:11:10AM +0100, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 03:09:18PM +0100, Richard W.M. Jones wrote:
- Not sure how best to deal with the ssh-agent authentication socket
problem.
Though they are the same thing, mixed use of them is uncomfortable.
unsigned is used a lot in old codes, this just tries to change the
ones in utils.
---
src/util/virpci.c | 65 +--
src/util/virpci.h | 24 ++--
2 files changed,
On 15/04/13 18:35, Osier Yang wrote:
Though they are the same thing, mixed use of them is uncomfortable.
unsigned is used a lot in old codes, this just tries to change the
ones in utils.
---
src/util/virpci.c | 65 +--
src/util/virpci.h | 24
On 04/15/2013 02:28 AM, Osier Yang wrote:
*** BLURB HERE ***
Osier Yang (6):
cleanup: Remove the duplicate header
cleanup: Only include testutils.h once
cleanup: Don't include libvirt/libvirt.h
cleanup: Don't include libvirt/virterror.h
syntax-check: Don't include duplicate
On 15/04/13 18:51, John Ferlan wrote:
On 04/15/2013 02:28 AM, Osier Yang wrote:
*** BLURB HERE ***
Osier Yang (6):
cleanup: Remove the duplicate header
cleanup: Only include testutils.h once
cleanup: Don't include libvirt/libvirt.h
cleanup: Don't include libvirt/virterror.h
On Fri, Apr 12, 2013 at 01:31:44PM -0600, Eric Blake wrote:
On 04/12/2013 10:27 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If libvirt makes any gcry_control() calls, then this
prevents gnutls for doing any initialization. As such
we must take care to do
On Mon, Apr 15, 2013 at 12:01:56PM +0100, Daniel P. Berrange wrote:
On Fri, Apr 12, 2013 at 01:31:44PM -0600, Eric Blake wrote:
On 04/12/2013 10:27 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If libvirt makes any gcry_control() calls, then this
On Mon, Apr 15, 2013 at 11:31:08AM +0100, Daniel P. Berrange wrote:
Yep, that would make it easier. Also if you did SSH key auth, but allowed
passphrases to be passed in, instead of pulled from an agent (in same way
SSH does if no agent is running).
Because qemu is running as a different user
diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c
index 55b3623..0c6f3cb 100644
--- a/tests/esxutilstest.c
+++ b/tests/esxutilstest.c
@@ -1,5 +1,7 @@
#include config.h
+#include virutil.h
+
#ifdef WITH_ESX
# include stdio.h
@@ -9,7 +11,6 @@
# include internal.h
#
On Mon, Apr 15, 2013 at 12:18:43PM +0100, Richard W.M. Jones wrote:
On Mon, Apr 15, 2013 at 11:31:08AM +0100, Daniel P. Berrange wrote:
Yep, that would make it easier. Also if you did SSH key auth, but allowed
passphrases to be passed in, instead of pulled from an agent (in same way
SSH
On Mon, Apr 15, 2013 at 12:39:30PM +0100, Daniel P. Berrange wrote:
On Mon, Apr 15, 2013 at 12:18:43PM +0100, Richard W.M. Jones wrote:
- How should host_key_check be modelled via the libvirt XML / API?
I'm not sure - what does that do ?
Three settings:
(1) host_key_check=no turns off
On 2013年04月15日 18:16, Daniel P. Berrange wrote:
On Mon, Apr 15, 2013 at 10:55:07AM +0800, Li Zhang wrote:
On 2013年04月12日 18:11, Daniel P. Berrange wrote:
On Thu, Apr 11, 2013 at 05:53:41PM +0800, Li Zhang wrote:
On 2013年04月11日 17:41, Daniel P. Berrange wrote:
On Sun, Apr 07, 2013 at
On 04/13/2013 04:54 AM, SHREE DUTH AWASTHI wrote:
Hi Daniel,
Thanks a lot for the patch, yes it is working as expected.
[Please don't top-post on technical lists]
# virsh -c qemu://localhost/system version
Compiled against library: libvirt 0.10.2
Using library: libvirt 0.10.2
Using
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, -device xxx still can't work well for ppc64 platform.
It's better use legacy USB option with default for ppc64.
This patch is to legacy USB option with default for ppc64.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
v2 - v1:
*
Thanks for your best efforts.
I only have one problem. Please find it at the end.
于 2013/4/10 16:59, Osier Yang 写道:
On 09/04/13 10:32, Han Cheng wrote:
Add scsi hostdev, it looks like:
hostdev mode='subsystem' type='scsi'
source
adapter name='scsi_host0'/
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com wrote:
[...]
I'm not hugely comfortable with the idea of capability support being
done by a student. IMHO to do a good job on that design-wise requires
someone with a very good understanding of libvirt architecture
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
[...]
I'm not hugely comfortable with the idea of capability support being
done by a student. IMHO to do a good job on that design-wise
On Mon, Apr 15, 2013 at 4:41 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
[...]
I'm not hugely comfortable with the idea of capability support
On Mon, Apr 15, 2013 at 09:43:55PM +0800, harryxiyou wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
[...]
I'm not hugely comfortable with the idea of capability support being
done by a student. IMHO to do a good job on that design-wise requires
On 04/15/2013 12:28 AM, Osier Yang wrote:
Detected by a simple Shell script.
Mentioning the contents of that script in the commit message would make
it nicer to rerun the same check later, if we desired. In fact,
codifying the script into a syntax-check rule would prevent running into
this
On Mon, Apr 15, 2013 at 5:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
[...]
I'm not hugely comfortable
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com wrote:
[...]
I'm not hugely comfortable with the idea of capability support being
done by a student. IMHO to do a
On 04/15/2013 04:35 AM, Osier Yang wrote:
Though they are the same thing, mixed use of them is uncomfortable.
unsigned is used a lot in old codes, this just tries to change the
ones in utils.
---
src/util/virpci.c | 65
+--
On 15/04/13 22:48, Eric Blake wrote:
On 04/15/2013 04:35 AM, Osier Yang wrote:
Though they are the same thing, mixed use of them is uncomfortable.
unsigned is used a lot in old codes, this just tries to change the
ones in utils.
---
src/util/virpci.c | 65
This patch adds support for agent-based cpu disabling and enabling to
qemuDomainSetVcpusFlags() API.
---
src/qemu/qemu_driver.c | 121 +++--
1 file changed, 108 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
This patch factors out the vCPU count retrieval including fallback means into
vshCPUCountCollect() and removes the duplicated code to retrieve individual
counts.
The --current flag (this flag is assumed by default) now works also with
--maximum or --active without the need to explicitly specify
Add support for array elements for agent commands just like 64d5e815 did for
monitor commands
---
src/qemu/qemu_agent.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 3e26cf1..8c8c38b 100644
--- a/src/qemu/qemu_agent.c
+++
The qemu guest agent allows to online and offline CPUs from the perspective of
the guest. This patch adds helpers that call 'guest-get-vcpus' and
'guest-set-vcpus' guest agent functions and convert the data for internal
libvirt usage.
---
src/qemu/qemu_agent.c | 137
On Mon, Apr 15, 2013 at 11:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
[...]
I'm not hugely comfortable
On 04/15/2013 12:28 AM, Osier Yang wrote:
Except for internal.h and the public headers
---
cfg.mk | 20
1 file changed, 20 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index 9cf4cff..0f07abd 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -736,6 +736,20 @@
On 15/04/13 23:10, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
On 04/15/2013 12:28 AM, Osier Yang wrote:
---
cfg.mk | 14 ++
1 file changed, 14 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index 394521e..9cf4cff 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -722,6 +722,20 @@ sc_prohibit_exit_in_tests:
halt='use return, not exit(), in tests'
The return value description stated that 0 is returned in case of success
instead of the count of vCPUs.
---
src/libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index c5221f5..c8728b7 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@
On Mon, Apr 15, 2013 at 10:56 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
[...]
A project must be a 12-week effort. Are you saying you'd like to
focus on just capability support for 12 weeks?
Yup, after i read the comments from Danpb and Osier, i find Renaming all
APIs is more comfortable
This patch implements the VIR_DOMAIN_VCPU flag for the qemuDomainGetVcpusFlags()
libvirt API implementation.
---
src/qemu/qemu_driver.c | 60 ++
1 file changed, 56 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c
This is a initial support for guest-agent based cpu hotplug that was commited
in upstream qemu and should be released in qemu 1.5.0.
This patchset relies on the existing qemuDomainSetVcpusFlags API that is not
really ideal for this purpose but is usable. I'm planing on adding a
specific-cpu
On Mon, Apr 15, 2013 at 10:55 PM, Daniel P. Berrange
berra...@redhat.com wrote:
[...]
Enthusiasm of the students to learn libvirt isn't the only consideration.
The project mentors have to put non-trivial effort into GSoC and want to
have some level of confidence that the project will result in
This flag will allow to use qemu guest agent commands to disable processors in a
live guest.
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
tools/virsh-domain.c | 25 +++--
tools/virsh.pod | 13 ++---
4 files
On 15/04/13 23:28, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:15 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 23:10, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM,
On Mon, Apr 15, 2013 at 5:15 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 23:10, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com
wrote:
On 15/04/13 23:16, harryxiyou wrote:
On Mon, Apr 15, 2013 at 11:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou harryxi...@gmail.com wrote:
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange berra...@redhat.com
wrote:
Upstream gnulib determined that we were needlessly compiling in
gnulib's regex instead of glibc's when targetting new-enough glibc,
because the m4 test was being too strict in requiring a particular
answer to undefined behavior.
https://lists.gnu.org/archive/html/bug-gnulib/2013-04/msg00032.html
On 04/15/2013 09:16 AM, harryxiyou wrote:
I could be if you want, but the question is which project you are focusing
on? This one or the renaming APIs? And as far as I got from the wiki page,
we generally don't want the student fails, and the renaming APIs work is
much simpler than this one,
---
tools/virsh-domain.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f41a74b..a201316 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -2627,18 +2627,30 @@ cmdSuspend(vshControl
Commit id '1acfc171' resulted in the following valgrind failure:
==25317== 136 (24 direct, 112 indirect) bytes in 1 blocks are definitely lost
in loss record 4 of 4
==25317==at 0x4A06B6F: calloc (vg_replace_malloc.c:593)
==25317==by 0x4C6F851: virAlloc (viralloc.c:124)
==25317==by
https://bugzilla.redhat.com/show_bug.cgi?id=906644
Added checks to both virsh suspend and virsh resume for the domain to be
in a the right state before trying the suspend/resume. Similar checks to
examples/domsuspend/suspend.c.
Although not stated in case, any thoughts on adding a --force for
On Fri, Apr 12, 2013 at 03:24:04PM -0600, Eric Blake wrote:
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
+++ b/tests/Makefile.am
@@ -97,7 +97,9 @@ test_programs = virshtest sockettest \
utiltest shunloadtest \
virtimetest viruritest virkeyfiletest \
virauthconfigtest
From: Daniel P. Berrange berra...@redhat.com
On win32, all code is position independent and adding -fPIE
to the compiler flags results in warnings being printed
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a Win32 build breaker fix
---
m4/virt-compile-pie.m4 | 9 +++--
---
tools/virsh-domain.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 4d0cc8f..f41a74b 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -4530,19 +4530,29 @@ static bool
cmdResume(vshControl
From: Daniel P. Berrange berra...@redhat.com
On Win32 symlink() is not available, so virstoragetest.c
must be conditionalized to avoid compile failures.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a win32 build breaker fix
---
configure.ac | 2 +-
On Fri, Apr 05, 2013 at 10:05:52AM -0400, Stefan Berger wrote:
Probe for QEMU's QMP TPM support by querying the lists of
supported TPM models (query-tpm-models) and backend types
(query-tpm-types).
The setting of the capability flags following the strings
returned from the commands above
On 03/25/2013 10:25 AM, Paolo Bonzini wrote:
This will be used on a tap file descriptor returned by the bridge helper
to populate the target element, because the helper does not provide
the interface name.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
src/libvirt_private.syms | 1 +
From: Daniel P. Berrange berra...@redhat.com
The second param of virNetlinkCommand should be
struct nlmsghdr, not unsigned char.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a Win32 build breaker fix
---
src/util/virnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Daniel P. Berrange berra...@redhat.com
The virCgroupForDriver method recently gained an 'int controllers'
parameter, but the stub impl did not
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a Win32 build breaker fix
---
src/util/vircgroup.c | 3 ++-
1 file changed, 2
On 04/15/2013 10:49 AM, John Ferlan wrote:
Commit id '1acfc171' resulted in the following valgrind failure:
==25317== 136 (24 direct, 112 indirect) bytes in 1 blocks are definitely lost
in loss record 4 of 4
==25317==at 0x4A06B6F: calloc (vg_replace_malloc.c:593)
==25317==by
From: Daniel P. Berrange berra...@redhat.com
Only compile storagevolxml2argvtest if WITH_STORAGE is
set, because it links to that driver
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a Win32 build breaker fix
---
tests/Makefile.am | 6 ++
1 file changed, 6 insertions(+)
From: Daniel P. Berrange berra...@redhat.com
Win32 does not like undefined symbols, so define an
empty virThreadCancel impl.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Pushed as a Win32 build breaker fix
---
src/util/virthreadwin32.c | 2 ++
1 file changed, 2 insertions(+)
diff
On Fri, 2013-04-12 at 11:46 -0400, Laine Stump wrote:
On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote:
On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote:
On 04/10/2013 05:26 AM, Daniel P. Berrange wrote:
On Tue, Apr 09, 2013 at 04:06:06PM -0400, Laine Stump wrote:
On 04/09/2013
On 04/15/2013 11:04 AM, Daniel P. Berrange wrote:
On Mon, Apr 15, 2013 at 12:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=906644
Added checks to both virsh suspend and virsh resume for the domain to be
in a the right state before trying the suspend/resume.
On Mon, Apr 15, 2013 at 12:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=906644
Added checks to both virsh suspend and virsh resume for the domain to be
in a the right state before trying the suspend/resume. Similar checks to
examples/domsuspend/suspend.c.
On 04/15/2013 12:56 PM, Daniel P. Berrange wrote:
Guess you never tested this on a QEMU which lacked those commands.
Probing capabilities now fails for any QEMU using QMP which lacks
these commands
Indeed, all the executables it checks have TPM enabled by now. What's
the best way of
On Mon, Apr 15, 2013 at 11:23:09AM -0600, Eric Blake wrote:
On 04/15/2013 11:04 AM, Daniel P. Berrange wrote:
On Mon, Apr 15, 2013 at 12:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=906644
Added checks to both virsh suspend and virsh resume for the domain
Check for QMP query-tpm-models and set a capability flag. Do not use
this QMP command if it is not supported.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c |8
src/qemu/qemu_capabilities.h |1 +
2 files changed, 9 insertions(+)
On 04/15/2013 01:49 PM, Stefan Berger wrote:
Check for QMP query-tpm-models and set a capability flag. Do not use
this QMP command if it is not supported.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c |8
On 04/15/2013 04:15 PM, Eric Blake wrote:
On 04/15/2013 01:49 PM, Stefan Berger wrote:
Check for QMP query-tpm-models and set a capability flag. Do not use
this QMP command if it is not supported.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c |
On Mon, Apr 15, 2013 at 11:27:03AM -0600, Alex Williamson wrote:
On Fri, 2013-04-12 at 11:46 -0400, Laine Stump wrote:
On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote:
On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote:
On 04/10/2013 05:26 AM, Daniel P. Berrange wrote:
On
On 04/15/2013 04:09 PM, Laine Stump wrote:
On 04/15/2013 06:29 AM, Daniel P. Berrange wrote:
On Fri, Apr 12, 2013 at 11:46:15AM -0400, Laine Stump wrote:
On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote:
On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote:
On 04/10/2013 05:26 AM,
On 04/15/2013 09:11 AM, Peter Krempa wrote:
The return value description stated that 0 is returned in case of success
instead of the count of vCPUs.
---
src/libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/src/libvirt.c b/src/libvirt.c
index
On 04/15/2013 09:11 AM, Peter Krempa wrote:
This patch factors out the vCPU count retrieval including fallback means into
vshCPUCountCollect() and removes the duplicated code to retrieve individual
counts.
The --current flag (this flag is assumed by default) now works also with
--maximum or
On 04/15/2013 09:11 AM, Peter Krempa wrote:
Add support for array elements for agent commands just like 64d5e815 did for
monitor commands
Always fun to see someone else using one of my commits as a starting
point - the virtual pay day of open source development!
---
src/qemu/qemu_agent.c |
On 04/15/2013 09:11 AM, Peter Krempa wrote:
The qemu guest agent allows to online and offline CPUs from the perspective of
the guest. This patch adds helpers that call 'guest-get-vcpus' and
'guest-set-vcpus' guest agent functions and convert the data for internal
libvirt usage.
---
On 04/15/2013 09:11 AM, Peter Krempa wrote:
Subject line is long, and doesn't match...
This flag will allow to use qemu guest agent commands to disable processors
in a
live guest.
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
tools/virsh-domain.c
On Tue, Apr 16, 2013 at 12:22 AM, Eric Blake ebl...@redhat.com wrote:
[...]
This indeed feels like a reasonable project, where there is enough work
to do to fill up 12 weeks of good effort while still having something
measurable to commit, and where the design is known enough in advance
that
On Mon, Apr 15, 2013 at 11:28 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
[...]
I asked because it seems like a very mechanical and relatively short
thing to work on.
If you still think the scope is good, then please add the project idea
to the GSoC wiki using this template:
On 15/04/13 23:28, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:15 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 23:10, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 5:00 PM, Osier Yang jy...@redhat.com wrote:
On 15/04/13 22:41, harryxiyou wrote:
On Mon, Apr 15, 2013 at 9:43 PM,
94 matches
Mail list logo
