Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Osier Yang
On 19/04/13 11:35, harryxiyou wrote: On Thu, Apr 18, 2013 at 11:03 PM, Eric Blake wrote: [...] Exactly - we need to add a new libvirt API that can support renames at the backend driver level, with instant effect (a directory pool forwarding to rename(2), other pools using pool-specific renaming

[libvirt] [PATCH] qemu: fix default spice password setting

2013-04-18 Thread Ján Tomko
Set spice password even if default VNC password hasn't been set. https://bugzilla.redhat.com/show_bug.cgi?id=953720 --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6c75cb..4f39ca4 100644 --- a

Re: [libvirt] [PATCH v4 1/2 RESEND] Add NVRAM device

2013-04-18 Thread Li Zhang
On 2013年04月19日 11:19, Eric Blake wrote: On 04/17/2013 11:40 PM, Li Zhang wrote: From: Li Zhang For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device t

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 11:03 PM, Eric Blake wrote: [...] > Exactly - we need to add a new libvirt API that can support renames at > the backend driver level, with instant effect (a directory pool > forwarding to rename(2), other pools using pool-specific renaming commands). > > It might be worth

Re: [libvirt] [PATCH v4 1/2 RESEND] Add NVRAM device

2013-04-18 Thread Eric Blake
On 04/17/2013 11:40 PM, Li Zhang wrote: > From: Li Zhang > > For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. > Users are allowed to specify spapr-vio devices'address. > But NVRAM is not supported in libvirt. So this patch is to > add NVRAM device to allow users to specify its ad

Re: [libvirt] [PATCH v4 2/2 RESEND] qemu: Add command line parser for NVRAM.

2013-04-18 Thread Li Zhang
On 2013年04月18日 17:55, Osier Yang wrote: On 18/04/13 13:40, Li Zhang wrote: From: Li Zhang This patch is to add command line parser for NVRAM device, s/parser/builder and parser/, I didn't go through it carefully, but what I catched with a rough look... Thanks for review. and add test ca

Re: [libvirt] [PATCHv2 1/6] virsh-domain: Refactor cmdVcpucount and fix output on inactive domains

2013-04-18 Thread Eric Blake
On 04/16/2013 08:00 AM, Peter Krempa wrote: > This patch factors out the vCPU count retrieval including fallback means > into vshCPUCountCollect() and removes the duplicated code to retrieve > individual counts. > > +#define PRINT_COUNT(VAR, MAX, STATE) if (VAR > 0) \ > +vshPrint(ctl, "%-12s

Re: [libvirt] [PATCH v2 10/11] qemu: auto-add bridges and allow using them

2013-04-18 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: > Add a "dry run" address allocation to figure out how many bridges > will be needed for all the devices without explicit addresses. > > Auto-add just enough bridges to put all the devices on, or up to the > bridge with the largest specified index. > --- >

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-18 Thread Eric Blake
On 04/18/2013 11:32 AM, Laine Stump wrote: > On 03/25/2013 10:25 AM, Paolo Bonzini wrote: >> uses a helper application to do the necessary >> TUN/TAP setup to use an existing network bridge, thus letting >> unprivileged users use TUN/TAP interfaces. >> >> @@ -3746,7 +3828,6 @@ error: >> char * >

Re: [libvirt] [PATCH 3/5] qemu_conf: add new configuration key bridge_helper

2013-04-18 Thread Eric Blake
On 04/18/2013 11:35 AM, Laine Stump wrote: >> +# Path to the setuid helper for creating tap devices. This executable >> +# is used to create interfaces when libvirtd is >> +# running unprivileged. libvirt invokes the helper directly, instead >> +# of using "-netdev bridge", for security reasons

Re: [libvirt] [PATCH 2/5] util: allow using virCommandAllowCap with setuid helpers

2013-04-18 Thread Eric Blake
On 03/27/2013 04:46 PM, Eric Blake wrote: > On 03/25/2013 08:25 AM, Paolo Bonzini wrote: >> When running unprivileged, virSetUIDGIDWithCaps will fail because it >> tries to add the requested capabilities to the permitted and effective >> sets. >> >> Detect this case, and invoke the child with clear

Re: [libvirt] [PATCH 1/5] util: simplify virSetUIDGIDWithCaps

2013-04-18 Thread Eric Blake
On 03/28/2013 04:04 AM, Paolo Bonzini wrote: > >>> /* Change to the temp capabilities */ >>> -if ((capng_ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) { >>> +if ((capng_ret = capng_apply(CAPNG_SELECT_CAPS)) < 0) { >> >> Beforehand, we limited both caps and bounding set, with an overlarge

Re: [libvirt] QEMU/KVM support for non zero PCI domain

2013-04-18 Thread Laine Stump
On 04/18/2013 03:13 PM, Charles Peri wrote: > On Apr 17, 2013, at 12:29 PM, Laine Stump wrote: > >> On 04/16/2013 11:23 AM, Charles Peri wrote: >> >>> Hi, >>> I am trying to run Virt-Manager, using KVM on a SGIUV100 system with RHEL >>> 6.1. I am trying to enable PCI pass-thorugh for the Mellano

Re: [libvirt] [PATCHv3] Support for static routes on a virtual bridge

2013-04-18 Thread Gene Czarcinski
On 04/16/2013 02:18 PM, Laine Stump wrote: int virSocketAddrGetIpPrefix(const virSocketAddr *addr, const virSocketAddr *netmask, int prefix) Creating separate patch which creates this new utility function and also updates virNetworkIpDefPrefix() to use it. Gene -- libvir-list mailing list lib

Re: [libvirt] QEMU/KVM support for non zero PCI domain

2013-04-18 Thread Charles Peri
On Apr 17, 2013, at 12:29 PM, Laine Stump wrote: > On 04/16/2013 11:23 AM, Charles Peri wrote: > >> >> Hi, >> I am trying to run Virt-Manager, using KVM on a SGIUV100 system with RHEL >> 6.1. I am trying to enable PCI pass-thorugh for the Mellanox, but the PCI >> domain for the device is 00

Re: [libvirt] need help: what should be supported?

2013-04-18 Thread Gene Czarcinski
On 04/18/2013 11:27 AM, Laine Stump wrote: On 04/18/2013 09:08 AM, Gene Czarcinski wrote: I need some help/guidance as to what networking characteristics should be supported by libvirt. Mostly, I am asking what should be valid for a prefix. For IPv4: The prefix can theoretically range from 0

[libvirt] Reworked patch set to add UID/GID support for containers

2013-04-18 Thread dwalsh
Combined all UID/GID patches, taken into account Dan Berrange feedback. Now UID will be based off the current UID. Sandbox Shell is no longer used when using LXC containers. Connect will now just execute a shell within the container. [sandbox PATCH 1/6] Add UID/GID support for use with interacti

[libvirt] [sandbox PATCH 3/6] Only create the destination directory if it does not exist.

2013-04-18 Thread dwalsh
From: Dan Walsh If a user specifies a path that already exists, we should just use the path. --- bin/virt-sandbox-service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 6524a05..308b871 100755 --- a/bin/virt-sandbox

[libvirt] [sandbox PATCH 1/6] Add UID/GID support for use with interactive containers.

2013-04-18 Thread dwalsh
From: Dan Walsh Openshift Containers will be run with a unique UID and GID --- bin/virt-sandbox-service | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index ad01649..d3dceea 100755 --- a/bin/virt-sandbox

[libvirt] [sandbox PATCH 2/6] We should not turn on the sanbox shell by default.

2013-04-18 Thread dwalsh
From: Dan Walsh We want to limit the number of processes which run within a container, especially for openshift work loads. Eventually we could add an option if someone wanted to run this shell. --- bin/virt-sandbox-service | 1 - 1 file changed, 1 deletion(-) diff --git a/bin/virt-sandbox-se

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports

2013-04-18 Thread Laine Stump
On 04/18/2013 01:44 PM, james robson wrote: > Hello, > Has any one been able to review this yet? I realise that the 'Since > 1.0.3' in the doc page is now out of date, but is the code itself > acceptable? I was hoping that someone with more knowledge of Open vSwitch and/or vlan tagging/trunking/na

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports

2013-04-18 Thread james robson
Hello, Has any one been able to review this yet? I realise that the 'Since 1.0.3' in the doc page is now out of date, but is the code itself acceptable? On Mon, 2013-02-18 at 11:01 +, james robson wrote: > This patch adds functionality to allow libvirt to configure the > 'native-tagged' and '

Re: [libvirt] [PATCH 3/5] qemu_conf: add new configuration key bridge_helper

2013-04-18 Thread Laine Stump
On 03/25/2013 10:25 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf | 8 > src/qemu/qemu_conf.c | 3 +++ > src/qemu/qemu_conf.h | 1 + > src/qemu/test_libvirtd_qemu.

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-18 Thread Laine Stump
On 03/25/2013 10:25 AM, Paolo Bonzini wrote: > uses a helper application to do the necessary > TUN/TAP setup to use an existing network bridge, thus letting > unprivileged users use TUN/TAP interfaces. > > However, libvirt should be preventing QEMU from running any setuid > programs at all, which

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-18 Thread Laine Stump
On 04/18/2013 08:09 AM, Ján Tomko wrote: > On 04/18/2013 07:22 AM, Laine Stump wrote: >> On 04/17/2013 03:00 PM, Ján Tomko wrote: >>> } >>> >>> @@ -10146,6 +10150,12 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr >>> qemuCaps, >>> if (virDomainDefAddImplicitControllers(def) < 0) >>

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-18 Thread Laine Stump
On 04/18/2013 04:42 AM, Martin Kletzander wrote: > Apart from that, the RNG with this patch is precise according to the > documentation, so ACK. I'll try to send the numQueues patch to see > what others think. Martin Thanks. I've pushed it. -- libvir-list mailing list libvir-list@redhat.com http

Re: [libvirt] [libvirt-glib] vapi: Get rid of redundant LibvirtGObject-1.0.metadata

2013-04-18 Thread Christophe Fergeau
On Wed, Apr 17, 2013 at 07:40:56PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Achieve the same through GIR annotations, just like we already do for > libvirt-glib. > --- > libvirt-gobject/libvirt-gobject-main.c | 8 ++-- > vapi/LibvirtGObject-1.0.metadata |

Re: [libvirt] [libvirt-designer PATCHv2 1/9] Improve VM skeleton created by gvir_designer_domain_setup_guest()

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 06:12:25PM +0200, Christophe Fergeau wrote: > Add various devices/configuration to libvirt XML config when > creating the VM. This configuration is generic enough that it > should be useful on all created VMs, that's why no public API is > added to set them up. However, they

[libvirt] [libvirt-designer PATCHv2 9/9] Implement gvir_designer_domain_add_video()

2013-04-18 Thread Christophe Fergeau
This takes into account the devices specified by the deployment, if this fails, consider the intersection of devices supported by the OS and by the platform, and if this still fails, falls back to a hardcoded hypervisor type -> video model mapping. --- examples/virtxml.c |

[libvirt] [libvirt-designer PATCHv2 0/9] Handle more devices in GVirDesignerDomain

2013-04-18 Thread Christophe Fergeau
This goes on top of v2 of the "Improve disk bus type generation" series. Diff with the previous version is that it's rebased against latest master, and I've reworked "Implement gvir_designer_domain_add_sound()" patch to address danpb's comments (gvir_designer_domain_add_sound() is now a public meth

[libvirt] [libvirt-designer PATCHv2 4/9] Implement gvir_designer_domain_add_graphics()

2013-04-18 Thread Christophe Fergeau
This allows to choose between SPICE, VNC or a local display, which will go through SDL or 'desktop' depending on the hypervisor. --- configure.ac | 2 +- examples/virtxml.c | 4 ++ libvirt-designer/libvirt-designer-domain.c | 111 ++

Re: [libvirt] [libvirt-designer 0/9] Handle more devices in GVirDesignerDomain

2013-04-18 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 04:17:17PM +0200, Michal Privoznik wrote: > On 17.04.2013 10:37, Christophe Fergeau wrote: > > Apart from danpb's comment in patch #3 which I've fixed locally, any > > more feedback/review on this series? > > > > Christophe > > > > Same applies here. I am unable to apply

Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-18 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 04:16:30PM +0200, Michal Privoznik wrote: > Well, for some reason, after applying that patch I cannot apply even the > first one (which I could before). It seems like there's a context > mismatch in the syms file libvirt-designer/libvirt-designer.sym. > > If you could repos

[libvirt] [libvirt-designer PATCHv2 5/9] Automatically add SPICE channel with SPICE graphics

2013-04-18 Thread Christophe Fergeau
When the user sets up the graphical framebuffer to use SPICE, we now add automatically the SPICE agent channel if it's not present already. --- libvirt-designer/libvirt-designer-domain.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/libvirt-designer/libvirt-de

[libvirt] [libvirt-designer PATCHv2 6/9] Check for vioserial availability before adding a SPICE agent

2013-04-18 Thread Christophe Fergeau
This makes use of the new gvir_designer_domain_get_supported_devices() method. --- libvirt-designer/libvirt-designer-domain.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-d

[libvirt] [libvirt-designer PATCHv2 1/9] Improve VM skeleton created by gvir_designer_domain_setup_guest()

2013-04-18 Thread Christophe Fergeau
Add various devices/configuration to libvirt XML config when creating the VM. This configuration is generic enough that it should be useful on all created VMs, that's why no public API is added to set them up. However, they are split in several helpers that can easily be exported if needed. What t

[libvirt] [libvirt-designer PATCHv2 7/9] Implement gvir_designer_domain_add_usb_redir()

2013-04-18 Thread Christophe Fergeau
This will add an USB redirection channel to the VM. This can be called multiple times to redirect several USB devices at once. This will also adds the needed controllers if they are not already present in the VM. The current code has 2 shortcomings: - USB redirection is only supported with SPICE, b

[libvirt] [libvirt-designer PATCHv2 3/9] Update copyright notice

2013-04-18 Thread Christophe Fergeau
--- libvirt-designer/libvirt-designer-domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c index c5105cd..0b70dfb 100644 --- a/libvirt-designer/libvirt-designer-domain.c +++ b/libvirt

[libvirt] [libvirt-designer PATCHv2 2/9] Implement gvir_designer_domain_add_sound()

2013-04-18 Thread Christophe Fergeau
--- examples/virtxml.c | 3 + libvirt-designer/libvirt-designer-domain.c | 131 + libvirt-designer/libvirt-designer-domain.h | 2 + libvirt-designer/libvirt-designer.sym | 1 + 4 files changed, 137 insertions(+) diff --git a/examples/

[libvirt] [libvirt-designer PATCHv2 0/3] Improve disk bus type generation

2013-04-18 Thread Christophe Fergeau
Here is a new version of this series rebased against master. Christophe -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-designer PATCHv2 8/9] Implement gvir_designer_domain_add_smartcard()

2013-04-18 Thread Christophe Fergeau
This setups smartcard redirection to the guest. I'm not yet fully sure what users could want to tweak there (there are various ways of setting up the smartcard redirection), so this code may need to be made more flexible. The current code is also not checking whether the hypervisor supports this ki

[libvirt] [libvirt-designer PATCHv2 3/3] Rework disk bus type handling

2013-04-18 Thread Christophe Fergeau
The current handling of bus types has some issues: - it assumes that if the design uses a disk controller hanging off a PCI bus, then it can use virtio, which is not true for Windows for example unless an additional driver is installed - it checks for "ide", "sata", "virtio" bus names, but they

[libvirt] [libvirt-designer PATCHv2 1/3] Add driver handling methods to GVirDesignerDomain

2013-04-18 Thread Christophe Fergeau
They are useful to tell libvirt-designer about which drivers are install/will be installed in the OS associated with the domain. This in turns allows libvirt-designer code to use these devices when it's making some guesses about what to enable/not enable in the VM being created. --- libvirt-design

[libvirt] [libvirt-designer PATCHv2 2/3] Add gvir_designer_domain_get_supported_devices()

2013-04-18 Thread Christophe Fergeau
This method gathers the list of devices supported by the hypervisor, and intersects this list with the list of devices supported by the OS, natively or using a driver (added with gvir_designer_domain_add_driver()). The lists can be filtered if needed. This commit changes gvir_designer_domain_get_s

Re: [libvirt] [libvirt-designer PATCHv2] Add support for floppies and CDROMs

2013-04-18 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 03:17:05PM +0200, Michal Privoznik wrote: > On 03.04.2013 13:35, Christophe Fergeau wrote: > > This mirrors disk_file/disk_device API so that it's possible to > > add CDROMs and floppies to a GVirDesignerDomain. > > This also adds the corresponding -C/-F options to virtxml >

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-18 Thread Eric Blake
On 04/17/2013 10:38 PM, Laine Stump wrote: > It occurred to me that we should only allow model='pci-root|pci-bridge' > if type='pci', and when I went back to look at the rng directly (instead > of just the diff), I noticed that there is already a separate set of > attributes/values allowable for ty

Re: [libvirt] [PATCH 2/3][ocaml] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-04-18 Thread David Scott
Hi, I just spotted a flaw in my OCaml event callback patch. I was hoping to ensure the ocaml bindings build against libvirt 0.9.1 and later. For functions, I remembered to include the usual symbol detection magic. However I forgot that there are also some enums which were added later than 0.9.1 i.

Re: [libvirt] need help: what should be supported?

2013-04-18 Thread Laine Stump
On 04/18/2013 09:08 AM, Gene Czarcinski wrote: > I need some help/guidance as to what networking characteristics should > be supported by libvirt. Mostly, I am asking what should be valid for > a prefix. > > For IPv4: > > The prefix can theoretically range from 0 to 32. Typically, the > values of

Re: [libvirt] [PATCH] Change default resource partition to /machine

2013-04-18 Thread Lennart Poettering
On Thu, 18.04.13 08:33, Eric Blake (ebl...@redhat.com) wrote: > On 04/18/2013 04:11 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > After discussions with systemd developers it was decided that > > a better default policy for resource partitions is to have > > 3 default part

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-18 Thread Laine Stump
On 04/18/2013 10:27 AM, Eric Blake wrote: > On 04/18/2013 03:02 AM, Martin Kletzander wrote: >> In commit d4bf0a9, we used num_queues for an attribute in the XML, but >> the consensus is that we use camelCase for that. Since there was no >> release yet (the above commit describes as v1.0.4-65-gd4b

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Eric Blake
On 04/18/2013 06:21 AM, harryxiyou wrote: > On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange > wrote: >> On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: >>> From: Harry Wei >>> >>> Vol-rename is a convenience function, requiring when >>> one wanna rename a volume name. >

Re: [libvirt] [PATCH 1/3] Add missing error reporting

2013-04-18 Thread Eric Blake
On 04/18/2013 04:30 AM, Martin Kletzander wrote: > On two places, there were errors not being reported. One strdup > without virReportOOMError() and call for virFileMakePathHelper() which > doesn't report any errors, just sets errno (or leaves it set by > underlying functions). > > Signed-off-by:

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-18 Thread Martin Kletzander
On 04/18/2013 04:27 PM, Eric Blake wrote: > On 04/18/2013 03:02 AM, Martin Kletzander wrote: >> In commit d4bf0a9, we used num_queues for an attribute in the XML, but >> the consensus is that we use camelCase for that. Since there was no >> release yet (the above commit describes as v1.0.4-65-gd4b

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-18 Thread Laine Stump
On 04/18/2013 08:09 AM, Ján Tomko wrote: > On 04/18/2013 07:22 AM, Laine Stump wrote: >> On 04/17/2013 03:00 PM, Ján Tomko wrote: >>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >>> index 68518a7..a2179aa 100644 >>> --- a/src/conf/domain_conf.c >>> +++ b/src/conf/domain_conf.c >>>

Re: [libvirt] [PATCH] Change default resource partition to /machine

2013-04-18 Thread Eric Blake
On 04/18/2013 04:11 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > After discussions with systemd developers it was decided that > a better default policy for resource partitions is to have > 3 default partitions at the top level > >/system - system services >/machine -

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-18 Thread Eric Blake
On 04/18/2013 03:02 AM, Martin Kletzander wrote: > In commit d4bf0a9, we used num_queues for an attribute in the XML, but > the consensus is that we use camelCase for that. Since there was no > release yet (the above commit describes as v1.0.4-65-gd4bf0a9), we > still have time to change it. You

Re: [libvirt] [libvirt-designer 0/9] Handle more devices in GVirDesignerDomain

2013-04-18 Thread Michal Privoznik
On 17.04.2013 10:37, Christophe Fergeau wrote: > Apart from danpb's comment in patch #3 which I've fixed locally, any > more feedback/review on this series? > > Christophe > Same applies here. I am unable to apply the patchset cleanly. Could you repost please? Michal -- libvir-list mailing lis

Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-18 Thread Michal Privoznik
On 11.04.2013 14:36, Christophe Fergeau wrote: > Hi, > > On Thu, Apr 11, 2013 at 01:33:50PM +0200, Michal Privoznik wrote: >> For some reason this patch cannot be applied cleanly: >> >> >> Applying: Rework disk bus type handling >> error: patch failed: libvirt-designer/libvirt-designer-domain.c:99

Re: [libvirt] [sandbox PATCH 6/6] Update man page to document current virt-sandbox-service options

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:57:01AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > Also cleanup some formatting issues in man pages. > --- > bin/virt-sandbox-service-create.pod | 45 > - > 1 file changed, 40 insertions(+), 5 deletions(-) > > diff --git

Re: [libvirt] [sandbox PATCH 5/6] Add support for --uid, --gid, --username, --homedir for creation

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:57:00AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > Add missing options Itentity fields for new InteractiveContainer Typo, I presume you mean 'identity' there, but even so the sentence doesn't really make sense. > --- > bin/virt-sandbox-service-bash-complet

Re: [libvirt] [sandbox PATCH 4/6] Add support for --homedir and --username setting for virt-sandbox-service

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:56:59AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > Also default --homedir, --username, --gid all off of the --uid settings. > But allow the admin to override if required. > --- > bin/virt-sandbox-service | 33 + > 1 file chang

Re: [libvirt] [sandbox PATCH 3/6] Only create the destination directory if it does not exist.

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:56:58AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > If a user specifies a path that already exists, we should just > use the path. > --- > bin/virt-sandbox-service | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) ACK Daniel -- |: http://berrange.c

Re: [libvirt] [sandbox PATCH 2/6] We should not turn on the sanbox shell by default.

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:56:57AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > We want to limit the number of processes which run within a container, > especially for openshift work loads. Eventually we could add an > option if someone wanted to run this shell. > --- > bin/virt-sandb

Re: [libvirt] [sandbox PATCH 1/6] Add UID/GID support for use with interactive containers.

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:56:56AM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > Openshift Containers will be run with a unique UID and GID > --- > bin/virt-sandbox-service | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) ACK Daniel -- |: http://berrange.com

[libvirt] [sandbox PATCH 3/6] Only create the destination directory if it does not exist.

2013-04-18 Thread dwalsh
From: Dan Walsh If a user specifies a path that already exists, we should just use the path. --- bin/virt-sandbox-service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 6524a05..308b871 100755 --- a/bin/virt-sandbox

[libvirt] [sandbox PATCH 1/6] Add UID/GID support for use with interactive containers.

2013-04-18 Thread dwalsh
From: Dan Walsh Openshift Containers will be run with a unique UID and GID --- bin/virt-sandbox-service | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index ad01649..d3dceea 100755 --- a/bin/virt-sandbox

[libvirt] [sandbox PATCH 5/6] Add support for --uid, --gid, --username, --homedir for creation

2013-04-18 Thread dwalsh
From: Dan Walsh Add missing options Itentity fields for new InteractiveContainer --- bin/virt-sandbox-service-bash-completion.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service-bash-completion.sh b/bin/virt-sandbox-service-bash-completion.sh inde

[libvirt] Add USER support to virt-sandbox-service

2013-04-18 Thread dwalsh
This patch set is adding support for UID/GID/USERNAME/USERDIR for use with openshift containers [sandbox PATCH 1/6] Add UID/GID support for use with interactive [sandbox PATCH 2/6] We should not turn on the sanbox shell by [sandbox PATCH 3/6] Only create the destination directory if it does [sand

[libvirt] [sandbox PATCH 2/6] We should not turn on the sanbox shell by default.

2013-04-18 Thread dwalsh
From: Dan Walsh We want to limit the number of processes which run within a container, especially for openshift work loads. Eventually we could add an option if someone wanted to run this shell. --- bin/virt-sandbox-service | 1 - 1 file changed, 1 deletion(-) diff --git a/bin/virt-sandbox-se

[libvirt] [sandbox PATCH 4/6] Add support for --homedir and --username setting for virt-sandbox-service

2013-04-18 Thread dwalsh
From: Dan Walsh Also default --homedir, --username, --gid all off of the --uid settings. But allow the admin to override if required. --- bin/virt-sandbox-service | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox-service b/bin

[libvirt] [sandbox PATCH 6/6] Update man page to document current virt-sandbox-service options

2013-04-18 Thread dwalsh
From: Dan Walsh Also cleanup some formatting issues in man pages. --- bin/virt-sandbox-service-create.pod | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/bin/virt-sandbox-service-create.pod b/bin/virt-sandbox-service-create.pod index fd

Re: [libvirt] [PATCH 2/2] virsh-domain: Report errors on invalid --holdtime value for cmdSendKey

2013-04-18 Thread Eric Blake
On 04/18/2013 02:51 AM, Peter Krempa wrote: > Using of a incorrect value for the --holdtime option was silently > ignored and 0 was used. In case a negative number was used, it > overflowed as the API expects a unsigned int. > > Fix the data type and getter function type and report errors on > inc

Re: [libvirt] [PATCH 2/2] virsh-domain: Report errors on invalid --holdtime value for cmdSendKey

2013-04-18 Thread Peter Krempa
On 04/18/13 14:44, Eric Blake wrote: On 04/18/2013 02:51 AM, Peter Krempa wrote: Using of a incorrect value for the --holdtime option was silently ignored and 0 was used. In case a negative number was used, it overflowed as the API expects a unsigned int. Fix the data type and getter function t

Re: [libvirt] [libvirt-designer PATCHv2] Add support for floppies and CDROMs

2013-04-18 Thread Michal Privoznik
On 03.04.2013 13:35, Christophe Fergeau wrote: > This mirrors disk_file/disk_device API so that it's possible to > add CDROMs and floppies to a GVirDesignerDomain. > This also adds the corresponding -C/-F options to virtxml > --- > > Here is a reworked version of my patch to add support for CDROMs

[libvirt] need help: what should be supported?

2013-04-18 Thread Gene Czarcinski
I need some help/guidance as to what networking characteristics should be supported by libvirt. Mostly, I am asking what should be valid for a prefix. For IPv4: The prefix can theoretically range from 0 to 32. Typically, the values of 8, 16 or 24 is used. For an IP specification, should I

Re: [libvirt] [PATCH 1/2] virsh-domain: Clean up cmdSendKey

2013-04-18 Thread Eric Blake
On 04/18/2013 02:51 AM, Peter Krempa wrote: > Rename the get_integer_keycode helper to vshKeyCodeGetInt and get rid of > a unneeded typecast. > --- > tools/virsh-domain.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libv

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-18 Thread Eric Blake
On 04/18/2013 01:36 AM, Tal Kain wrote: >> >> Personally, I don't think the patch is too bad, and I'll probably apply >> it unless Dan can give a stronger objection. >> > I was wondering if there are any updates about this patch Sure, I just applied it. I shortened the subject line (generally com

[libvirt] libvirt-1.0.3 vs qemu-1.4

2013-04-18 Thread Yin Olivia-R63875
Hi guys, I used to go through libvirt (1.0.3) use cases with qemu-1.0 + linux-3.0.43. Recently I tried Linux-3.8.4 + qemu-1.4. But it can't start qemu domain. - root@p1022ds:~# virsh version Compiled against library: libvirt 1.0.3 Using library: libvirt 1.0.3 Using

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 07:59:45AM -0400, Laine Stump wrote: > On 04/18/2013 07:27 AM, Osier Yang wrote: > > On 18/04/13 19:16, Laine Stump wrote: > >> On 04/18/2013 05:41 AM, Martin Kletzander wrote: > >>> On 04/18/2013 11:05 AM, Osier Yang wrote: > On 18/04/13 17:00, Martin Kletzander wrote:

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange wrote: > On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: >> From: Harry Wei >> >> Vol-rename is a convenience function, requiring when >> one wanna rename a volume name. >> >> Signed-off-by: Harry Wei >> --- >> tools/virs

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-18 Thread Ján Tomko
On 04/18/2013 07:22 AM, Laine Stump wrote: > On 04/17/2013 03:00 PM, Ján Tomko wrote: >> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >> index 68518a7..a2179aa 100644 >> --- a/src/conf/domain_conf.c >> +++ b/src/conf/domain_conf.c >> @@ -10849,9 +10849,15 @@ virDomainDefParseXML(

Re: [libvirt] [PATCH 2/2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-18 Thread Peter Krempa
On 04/17/13 18:07, Laine Stump wrote: On 04/17/2013 04:40 AM, Peter Krempa wrote: Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so t

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:27 PM, Osier Yang wrote: > On 18/04/13 16:29, harryxi...@gmail.com wrote: >> >> From: Harry Wei >> >> Vol-rename is a convenience function, requiring when >> one wanna rename a volume name. > > > NACK. It should use the upcoming rename APIs for the *-rename virsh > comma

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-18 Thread Laine Stump
On 04/18/2013 07:27 AM, Osier Yang wrote: > On 18/04/13 19:16, Laine Stump wrote: >> On 04/18/2013 05:41 AM, Martin Kletzander wrote: >>> On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander wrote: > On 04/18/2013 10:54 AM, Osier Yang wrote: >> On 18/04/13 16:

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-18 Thread Osier Yang
On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander wrote: On 04/18/2013 10:54 AM, Osier Yang wrote: On 18/04/13 16:42, Martin Kletzander wrote: On 04/18/2013 06:36 AM, Laine Stu

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-18 Thread Laine Stump
On 04/18/2013 05:41 AM, Martin Kletzander wrote: > On 04/18/2013 11:05 AM, Osier Yang wrote: >> On 18/04/13 17:00, Martin Kletzander wrote: >>> On 04/18/2013 10:54 AM, Osier Yang wrote: On 18/04/13 16:42, Martin Kletzander wrote: > On 04/18/2013 06:36 AM, Laine Stump wrote: >> The rng

Re: [libvirt] [PATCH 3/3] Speed up waiting for the session daemon

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 12:47:46PM +0200, Martin Kletzander wrote: > On 04/18/2013 12:43 PM, Daniel P. Berrange wrote: > > On Thu, Apr 18, 2013 at 12:30:56PM +0200, Martin Kletzander wrote: > >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369 > >> > >> When launching the session daemon

Re: [libvirt] [PATCH 3/3] Speed up waiting for the session daemon

2013-04-18 Thread Martin Kletzander
On 04/18/2013 12:43 PM, Daniel P. Berrange wrote: > On Thu, Apr 18, 2013 at 12:30:56PM +0200, Martin Kletzander wrote: >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369 >> >> When launching the session daemon, we were waiting for around 20 >> seconds even it died before creating any s

Re: [libvirt] [PATCH 3/3] Speed up waiting for the session daemon

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 12:30:56PM +0200, Martin Kletzander wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369 > > When launching the session daemon, we were waiting for around 20 > seconds even it died before creating any sockets etc. > > The following modification pre-creates

Re: [libvirt] [PATCH 2/3] Move daemonPidFilePath into virutil.c

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 12:30:55PM +0200, Martin Kletzander wrote: > Change daemonPidFilePath to virDaemonPidFilePath so it is accessible > in other parts of the code. > > Signed-off-by: Martin Kletzander > --- > daemon/libvirtd.c| 43 +++ > src/li

[libvirt] [PATCH 2/3] Move daemonPidFilePath into virutil.c

2013-04-18 Thread Martin Kletzander
Change daemonPidFilePath to virDaemonPidFilePath so it is accessible in other parts of the code. Signed-off-by: Martin Kletzander --- daemon/libvirtd.c| 43 +++ src/libvirt_private.syms | 1 + src/util/virutil.c | 39

[libvirt] [PATCH 3/3] Speed up waiting for the session daemon

2013-04-18 Thread Martin Kletzander
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369 When launching the session daemon, we were waiting for around 20 seconds even it died before creating any sockets etc. The following modification pre-creates the pidfile which will be used by the forked daemon and cleans it up in case t

[libvirt] [PATCH 0/3] Speeding up the wait for session daemon

2013-04-18 Thread Martin Kletzander
When the session daemon is spawned and ends with an error before the spawning process notices, it becomes waiting for Godot (fortunately with a timeout of about 20 seconds). With this series, there is pidfile created for the spawned daemon and the pid is being checked for to make sure we are not w

[libvirt] [PATCH 1/3] Add missing error reporting

2013-04-18 Thread Martin Kletzander
On two places, there were errors not being reported. One strdup without virReportOOMError() and call for virFileMakePathHelper() which doesn't report any errors, just sets errno (or leaves it set by underlying functions). Signed-off-by: Martin Kletzander --- src/util/virutil.c | 6 +- 1 fil

[libvirt] [PATCH] Change default resource partition to /machine

2013-04-18 Thread Daniel P. Berrange
From: "Daniel P. Berrange" After discussions with systemd developers it was decided that a better default policy for resource partitions is to have 3 default partitions at the top level /system - system services /machine - virtual machines / containers /user- user login session T

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-18 Thread Peter Krempa
On 04/17/13 11:16, Daniel P. Berrange wrote: On Wed, Apr 17, 2013 at 08:47:01AM +0200, Peter Krempa wrote: On 04/16/13 19:41, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: This flag will allow to use qemu guest agent commands to disable (offline) and e

Re: [libvirt] [PATCH v4 2/2 RESEND] qemu: Add command line parser for NVRAM.

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 01:40:03PM +0800, Li Zhang wrote: > From: Li Zhang > > This patch is to add command line parser for NVRAM device, > and add test cases. > > Signed-off-by: Li Zhang > --- > src/qemu/qemu_command.c| 72 > ++ > src/qemu/qemu

Re: [libvirt] [PATCH v4 2/2 RESEND] qemu: Add command line parser for NVRAM.

2013-04-18 Thread Osier Yang
On 18/04/13 13:40, Li Zhang wrote: From: Li Zhang This patch is to add command line parser for NVRAM device, s/parser/builder and parser/, I didn't go through it carefully, but what I catched with a rough look... and add test cases. Signed-off-by: Li Zhang --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH v4 1/2 RESEND] Add NVRAM device

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 01:40:02PM +0800, Li Zhang wrote: > From: Li Zhang > > For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. > Users are allowed to specify spapr-vio devices'address. > But NVRAM is not supported in libvirt. So this patch is to > add NVRAM device to allow users

Re: [libvirt] [PATCH] Switch to a more extensible annotation system for RPC protocols

2013-04-18 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 10:16:08AM -0600, Eric Blake wrote: > On 04/17/2013 09:43 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently the RPC protocol files can contain annotations after > > the protocol enum eg > > > >REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAME

  1   2   >