Re: [libvirt] Entering freeze for libvirt-1.0.5

On 04/26/2013 08:19 PM, Ján Tomko wrote: A fix that doesn't assign a PCI address for model=none USB controller is pushed now. I can confirm this is working. Thanks! If we really have to do a workaround, I'd suggest just ignoring the PCI root and assuming one PCI bus is always there. I

Re: [libvirt] [Xen-devel] libvirt, libxl and QDISKs

Hi Jim, Thanks for the explanation about the capabilities. On 27/04/13 00:44, Jim Fehlig wrote: Do you have time for an upstream libvirt patch to expose the possible emulators in the capabilities, along with this patch allowing the user to specify one? I'll have a go and send you (cc'ing the

[libvirt] [libvirt-java] [Patch] remove unused imports

Hi, Clean up all java classes which have imports which are not used. Greetings Stefan Majer --- src/main/java/org/libvirt/Device.java |1 - src/main/java/org/libvirt/Domain.java |1 - src/main/java/org/libvirt/DomainSnapshot.java |1 -

[libvirt] [PATCH] qemu: Error out if spice port autoallocation is requested, but disabled

When a user requests auto-allocation of the spice TLS port but spice TLS is disabled in qemu.conf, we start the machine and let qemu fail instead of erroring out sooner. Add an error message so that this doesn't happen. --- src/qemu/qemu_process.c | 10 -- 1 file changed, 8

Re: [libvirt] [PATCH] network: Don't remove transient network if creating of config file fails

On 04/22/13 11:32, Peter Krempa wrote: On the off-chance that creation of persistent configuration file would fail when defining a network that is already started as transient, the code would remove the transient data structure and thus the network. This patch changes the code so that in such

Re: [libvirt] [libvirt-java] [Patch] remove unused imports

Hi. At Mon, 29 Apr 2013 12:36:20 +0200, Stefan Majer wrote: Hi, Clean up all java classes which have imports which are not used. Greetings Stefan Majer This part would be directly included in the git commit message. You (most likely) don't want that. Could you send your patches

[libvirt] [PATCH] Resolve valgrind error

As a result of commit id '19c345f2', 'make -C tests valgrind' has the following for qemuxml2argvtest: ==22482== 197 (80 direct, 117 indirect) bytes in 1 blocks are definitely lost in loss record 101 of 120 ==22482==at 0x4A06B6F: calloc (vg_replace_malloc.c:593) ==22482==by 0x4C6F301:

[libvirt] [PATCH] qemu: Do fake auto-allocation of ports when generating native command

When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done when starting the actual machine. --- src/qemu/qemu_driver.c | 51

[libvirt] [PATCHv2] qemu: Do fake auto-allocation of ports when generating native command

When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done when starting the actual machine. --- src/qemu/qemu_driver.c | 52

Re: [libvirt] [PATCH] qemu: Do fake auto-allocation of ports when generating native command

On 04/29/13 14:39, Peter Krempa wrote: When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done when starting the actual machine. ---

Re: [libvirt] [PATCH] Resolve valgrind error

On 29.04.2013 14:35, John Ferlan wrote: As a result of commit id '19c345f2', 'make -C tests valgrind' has the following for qemuxml2argvtest: ==22482== 197 (80 direct, 117 indirect) bytes in 1 blocks are definitely lost in loss record 101 of 120 ==22482==at 0x4A06B6F: calloc

Re: [libvirt] [PATCHv2] qemu: Do fake auto-allocation of ports when generating native command

On 29.04.2013 14:42, Peter Krempa wrote: When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done when starting the actual machine. ---

Re: [libvirt] [PATCHv2] qemu: Do fake auto-allocation of ports when generating native command

On Mon, Apr 29, 2013 at 02:48:54PM +0200, Michal Privoznik wrote: On 29.04.2013 14:42, Peter Krempa wrote: When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake

Re: [libvirt] [PATCHv2] qemu: Do fake auto-allocation of ports when generating native command

On 04/29/13 14:48, Michal Privoznik wrote: On 29.04.2013 14:42, Peter Krempa wrote: When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done

Re: [libvirt] [PATCH] Resolve valgrind error

On 04/29/2013 08:45 AM, Michal Privoznik wrote: On 29.04.2013 14:35, John Ferlan wrote: As a result of commit id '19c345f2', 'make -C tests valgrind' has the following for qemuxml2argvtest: ==22482== 197 (80 direct, 117 indirect) bytes in 1 blocks are definitely lost in loss record 101 of

[libvirt] [PATCH v2 00/37] Change OOM reporting

Previously, the first version dropped virReportOOMError from almost everywhere. This series don't set such high goal yet. It just prepares ground for doing so. The worst case scenario is the OOM error is reported twice. Once in VIR_ALLOC, VIR_STRDUP, virAsprintf (or similar), then in

[libvirt] [PATCH v2 10/37] Adapt to VIR_STRDUP in src/lxc/*

--- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_conf.c | 18 +- src/lxc/lxc_container.c | 8 src/lxc/lxc_controller.c | 6 +++--- src/lxc/lxc_driver.c | 7 ++- src/lxc/lxc_process.c| 4 ++-- 6 files changed, 21 insertions(+), 24 deletions(-) diff

[libvirt] [PATCH v2 07/37] Adapt to VIR_STRDUP in src/hyperv/*

--- src/hyperv/hyperv_driver.c | 35 +++ src/hyperv/hyperv_util.c | 15 +-- 2 files changed, 16 insertions(+), 34 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 7031fdb..23d30e1 100644 ---

[libvirt] [PATCH v2 05/37] Adapt to VIR_STRDUP in src/cpu/*

--- src/cpu/cpu_generic.c | 6 +++--- src/cpu/cpu_map.c | 3 ++- src/cpu/cpu_powerpc.c | 10 +- src/cpu/cpu_x86.c | 6 +++--- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_generic.c b/src/cpu/cpu_generic.c index 9d5117f..e907269 100644 ---

[libvirt] [PATCH v2 04/37] Adapt to VIR_STRDUP in src/conf/*

--- src/conf/capabilities.c | 26 -- src/conf/cpu_conf.c | 12 - src/conf/domain_conf.c | 64 - src/conf/domain_event.c | 31 +++--- src/conf/node_device_conf.c | 28 +---

[libvirt] [PATCH v2 21/37] Adapt to VIR_STRDUP in src/secret/*

--- src/secret/secret_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 377b9f4..cfd5b6a 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -1097,8 +1097,7 @@

[libvirt] [PATCH v2 12/37] Adapt to VIR_STRDUP in src/node_device/*

--- src/node_device/node_device_driver.c | 28 -- src/node_device/node_device_hal.c| 13 ++--- src/node_device/node_device_udev.c | 102 +++ 3 files changed, 60 insertions(+), 83 deletions(-) diff --git a/src/node_device/node_device_driver.c

[libvirt] [PATCH v2 02/37] virstring: Introduce VIR_STRUP and VIR_STRNDUP

The code adaptation is not done right now, but in subsequent patches. Hence I am not implementing syntax-check rule as it would break compilation. Developers are strongly advised to use these new macros. They are similar to VIR_ALLOC() logic: VIR_STRDUP(dst, src) returns zero on success, -1

[libvirt] [PATCH v2 15/37] Adapt to VIR_STRDUP in src/openvz/*

--- src/openvz/openvz_conf.c | 31 +++ src/openvz/openvz_driver.c | 30 +++--- 2 files changed, 30 insertions(+), 31 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 49fae28..9dbdc74 100644 ---

[libvirt] [PATCH v2 08/37] Adapt to VIR_STRDUP in src/libxl/*

--- src/libxl/libxl_conf.c | 59 ++-- src/libxl/libxl_driver.c | 13 ++- 2 files changed, 34 insertions(+), 38 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 7e0753a..19d40f3 100644 ---

[libvirt] [PATCH v2 36/37] virstring: Introduce virAsprintfQuiet and virVasprintfQuiet

Moreover, the original virVasprintf and virAsprintf functions will report OOM error. The new behaviour is not enabled for now as the rest of code needs to be adapted so we don't report an error twice. --- HACKING | 4 docs/hacking.html.in | 6 ++

[libvirt] [PATCH v2 17/37] Adapt to VIR_STRDUP in src/phyp/*

--- src/phyp/phyp_driver.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 85eb650..1cb92d2 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -954,9 +954,7 @@

[libvirt] [PATCH v2 20/37] Adapt to VIR_STRDUP in src/rpc/*

--- src/rpc/gendispatch.pl | 13 + src/rpc/virnetclient.c | 8 src/rpc/virnetmessage.c | 11 ++- src/rpc/virnetsaslcontext.c | 3 ++- src/rpc/virnetserver.c | 4 ++-- src/rpc/virnetserverclient.c | 6 ++ src/rpc/virnetservermdns.c |

[libvirt] [PATCH v2 24/37] Adapt to VIR_STRDUP in src/test/*

--- src/test/test_driver.c | 82 +++--- 1 file changed, 37 insertions(+), 45 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f60f106..b7c121e 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -219,12

[libvirt] [PATCH v2 14/37] Adapt to VIR_STRDUP in src/nwfilter/*

--- src/nwfilter/nwfilter_dhcpsnoop.c | 15 +++ src/nwfilter/nwfilter_driver.c| 4 ++-- src/nwfilter/nwfilter_ebiptables_driver.c | 10 +- src/nwfilter/nwfilter_gentech_driver.c| 4 ++-- src/nwfilter/nwfilter_learnipaddr.c | 3 +-- 5 files

[libvirt] [PATCH v2 16/37] Adapt to VIR_STRDUP in src/parallels/*

--- src/parallels/parallels_driver.c | 34 +- src/parallels/parallels_network.c | 12 ++-- src/parallels/parallels_storage.c | 38 +++--- 3 files changed, 38 insertions(+), 46 deletions(-) diff --git

[libvirt] [PATCH v2 06/37] Adapt to VIR_STRDUP in src/esx/*

--- src/esx/esx_driver.c| 33 + src/esx/esx_interface_driver.c | 5 ++-- src/esx/esx_network_driver.c| 20 ++- src/esx/esx_storage_backend_iscsi.c | 14 --- src/esx/esx_storage_backend_vmfs.c | 8 ++

[libvirt] [PATCH v2 11/37] Adapt to VIR_STRDUP in src/network/*

--- src/network/bridge_driver.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b561e85..1a4029c 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -378,7

[libvirt] [PATCH v2 03/37] Adapt to VIR_STRDUP in daemon/*

--- daemon/libvirtd-config.c | 37 ++- daemon/libvirtd.c| 17 + daemon/remote.c | 94 3 files changed, 66 insertions(+), 82 deletions(-) diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c

[libvirt] [PATCH v2 32/37] Adapt to VIR_STRDUP in src/xenxs/*

--- src/xenxs/xen_sxpr.c | 107 +-- src/xenxs/xen_xm.c | 43 ++--- 2 files changed, 65 insertions(+), 85 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 9a76d04..7ebaa30 100644 ---

[libvirt] [PATCH v2 19/37] Adapt to VIR_STRDUP in src/remote/*

--- src/remote/remote_driver.c | 79 -- 1 file changed, 34 insertions(+), 45 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 97be2a0..89e0e96 100644 --- a/src/remote/remote_driver.c +++

[libvirt] [PATCH v2 23/37] Adapt to VIR_STRDUP in src/storage/*

--- src/storage/parthelper.c | 7 --- src/storage/storage_backend.c | 16 ++-- src/storage/storage_backend_disk.c| 14 +++--- src/storage/storage_backend_fs.c | 17 - src/storage/storage_backend_iscsi.c | 14 ++

[libvirt] [PATCH v2 31/37] Adapt to VIR_STRDUP in src/xenapi/*

--- src/xenapi/xenapi_driver.c | 32 +++- src/xenapi/xenapi_utils.c | 20 ++-- 2 files changed, 25 insertions(+), 27 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 7e64df6..86abab8 100644 ---

[libvirt] [PATCH v2 27/37] Adapt to VIR_STRDUP in src/vbox/*

--- src/vbox/vbox_XPCOMCGlue.c | 4 +- src/vbox/vbox_tmpl.c | 190 +++-- 2 files changed, 98 insertions(+), 96 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index e0b606f..c5500b9 100644 ---

[libvirt] [PATCH v2 29/37] Adapt to VIR_STRDUP in src/vmx/*

--- src/vmx/vmx.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index c6c2f0d..4ccb0cd 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -682,9 +682,7 @@ virVMXGetConfigString(virConfPtr conf, const char *name, char

[libvirt] [PATCH v2 37/37] viralloc.c: Do report OOM error in VIR_ALLOC and friends

For cases where caller doesn't want to repor an OOM error, he should use VIR_ALLOC_QUIET or variants. --- HACKING | 4 ++ docs/hacking.html.in| 6 +++ po/POTFILES.in | 1 + python/libvirt-override.c | 102

[libvirt] [PATCH v2 22/37] Adapt to VIR_STRDUP in src/security/*

--- src/security/security_apparmor.c | 11 - src/security/security_dac.c | 6 ++--- src/security/security_nop.c | 4 ++-- src/security/security_selinux.c | 49 src/security/virt-aa-helper.c| 4 ++-- 5 files changed, 30

[libvirt] [PATCH v2 34/37] Adapt to VIR_STRDUP in src/*

--- src/datatypes.c | 25 + src/libvirt.c | 9 + src/nodeinfo.c | 3 +-- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index d3cf5f2..71aab04 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -27,6 +27,7

[libvirt] [PATCH v2 09/37] Adapt to VIR_STRDUP in src/locking/*

--- src/locking/lock_daemon.c | 12 ++-- src/locking/lock_daemon_config.c | 8 src/locking/lock_daemon_dispatch.c | 3 ++- src/locking/lock_driver_lockd.c| 22 +++--- src/locking/lock_driver_sanlock.c | 8 src/locking/lock_manager.c

[libvirt] [PATCH v2 33/37] Adapt to VIR_STRDUP in tests/*

--- tests/commandhelper.c | 14 +++--- tests/commandtest.c| 2 +- tests/openvzutilstest.c| 6 -- tests/qemumonitortestutils.c | 8 tests/qemuxml2argvtest.c | 27 --- tests/qemuxmlnstest.c

[libvirt] [PATCH v2 28/37] Adapt to VIR_STRDUP in src/vmware/*

--- src/vmware/vmware_conf.c | 13 ++--- src/vmware/vmware_driver.c | 12 +--- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 4fb61a8..f7cd3bb 100644 --- a/src/vmware/vmware_conf.c +++

[libvirt] [PATCH v2 25/37] Adapt to VIR_STRDUP in src/uml/*

--- src/uml/uml_conf.c | 4 ++-- src/uml/uml_driver.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index a55b5b1..47e0fc0 100644 --- a/src/uml/uml_conf.c +++ b/src/uml/uml_conf.c @@ -114,7 +114,7 @@

[libvirt] [PATCH v2 35/37] Introduce syntax-check rule to prefer VIR_STRDUP over strdup

--- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk b/cfg.mk index d499ded..4c6d85c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -383,6 +383,11 @@ sc_prohibit_asprintf: halt='use virAsprintf, not as'printf\ $(_sc_search_regexp)

[libvirt] [PATCH v2 30/37] Adapt to VIR_STRDUP in src/xen/*

--- src/xen/xen_driver.c | 2 +- src/xen/xen_hypervisor.c | 15 +- src/xen/xen_inotify.c| 11 -- src/xen/xend_internal.c | 53 +++- src/xen/xm_internal.c| 6 +++--- src/xen/xs_internal.c| 22 6

[libvirt] [PATCH v2 13/37] Adapt to VIR_STRDUP in src/interface/

--- src/interface/interface_backend_udev.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 7daad16..65c8c31 100644 --- a/src/interface/interface_backend_udev.c +++

[libvirt] [PATCH] qemu: honor allowDiskFormatProbing when parsing command line

My commit 024e9af broke this. --- src/qemu/qemu_command.c | 3 --- tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 4 ++--

Re: [libvirt] [PATCH 1/1][RESEND] ppc64 cpu features

On Mon, Apr 22, 2013 at 17:38:23 +0800, Li Zhang wrote: On 2013年04月22日 17:10, Jiri Denemark wrote: If you want to add powernv feature just because you need to distinguish if the host supports KVM or not, there's much better way... In guest section of capabilities XML, KVM support is

[libvirt] libxl: expose and control xen device model versions

Hi, These patches expose multiple xen device model options in the capabilities XML and allow the user to select a specific device model via the domain XML's emulator tag. It is important to control the device model per VM, since the default is changing from xen-4.2 qemu traditional to xen-4.3

[libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386) The person who builds and packages xen gets to choose which emulators are built. We examine the filesystem for the

[libvirt] [PATCH 0/2] [RFC] Support for VNC WebSocket

This series, which is meant to be applied _after_ 1.0.5 release, is adding support for the VNC WebSocket to be configured for QEMU. I tagged this with [RFC] because this is the fastest way I managed to code it and I'd welcome any opinions on naming changes etc. Documentation from

[libvirt] [PATCH 2/2] qemu: Add VNC WebSocket support

Adding a VNC WebSocket support for QEMU driver. This funcitonality is in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/libvirtd_qemu.aug

[libvirt] [PATCH 1/2] Add VNC WebSocket support

Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 5 +

[libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff

Re: [libvirt] [PATCH 1/2] Add VNC WebSocket support

On 29.04.2013 16:52, Martin Kletzander wrote: Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] [PATCH 2/2] qemu: Add VNC WebSocket support

On 29.04.2013 16:52, Martin Kletzander wrote: Adding a VNC WebSocket support for QEMU driver. This funcitonality is in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 0/2] [RFC] Support for VNC WebSocket

On 29.04.2013 16:52, Martin Kletzander wrote: This series, which is meant to be applied _after_ 1.0.5 release, is adding support for the VNC WebSocket to be configured for QEMU. I tagged this with [RFC] because this is the fastest way I managed to code it and I'd welcome any opinions on

Re: [libvirt] [PATCH-v4.2] Support for static routes on a virtual bridge

On 04/26/2013 07:22 PM, Gene Czarcinski wrote: network: static route support for network This patch adds the route subelement of network to define a static route. the address and prefix (or netmask) attribute identify the destination network, and the gateway attribute specifies the next hop

Re: [libvirt] [PATCH-v4.2] Support for static routes on a virtual bridge

(I wanted a separate message to comment on this part...) On 04/26/2013 07:22 PM, Gene Czarcinski wrote: +/* add an IP (static) route to a bridge */ +static int +networkAddRouteToBridge(virNetworkObjPtr network, +virNetworkRouteDefPtr routedef) +{ +bool done =

Re: [libvirt] [PATCH] network: Don't remove transient network if creating of config file fails

On 04/22/2013 05:32 AM, Peter Krempa wrote: On the off-chance that creation of persistent configuration file would fail when defining a network that is already started as transient, the code would remove the transient data structure and thus the network. This patch changes the code so that in

[libvirt] [PATCH 0/2] Get rid of default USB controller on S390

QEMU for S390 has presently no USB controllers nor a PCI bus. Both are created by the default in the libvirt domain definition. Although this can be suppressed by explicitly specifying an USB controller with model='none', it's a real bad default. With Jan's recent patch we can reliably suppress

[libvirt] [PATCH 1/2] S390: Mention changed USB behavior

Add a line saying that no USB controllers are generated by default on s390. --- docs/formatdomain.html.in |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f325c3c..8870e46 100644 --- a/docs/formatdomain.html.in

[libvirt] [PATCH 2/2] S390: Do not generate a default USB controller

For s390 we don't want to have a default USB device generated even if QEMU is silently tolerating -usb on the command line. This may change in the future. Another reason to avoid the USB controller is that it implies a PCI bus which might cause a regression at some later point in time. The

Re: [libvirt] [PATCH] qemu: honor allowDiskFormatProbing when parsing command line

On 04/29/2013 07:56 AM, Ján Tomko wrote: My commit 024e9af broke this. --- src/qemu/qemu_command.c | 3 --- diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d23bdfc..d161b56 100644 --- a/src/qemu/qemu_command.c +++

Re: [libvirt] [PATCH] qemu: Error out if spice port autoallocation is requested, but disabled

On 04/29/2013 05:50 AM, Peter Krempa wrote: When a user requests auto-allocation of the spice TLS port but spice TLS is disabled in qemu.conf, we start the machine and let qemu fail instead of erroring out sooner. Add an error message so that this doesn't happen. ---

Re: [libvirt] [PATCH v2 02/37] virstring: Introduce VIR_STRUP and VIR_STRNDUP

On 04/29/2013 07:50 AM, Michal Privoznik wrote: s/STRUP/STRDUP/ in the subject line. The code adaptation is not done right now, but in subsequent patches. Hence I am not implementing syntax-check rule as it would break compilation. Developers are strongly advised to use these new macros.

Re: [libvirt] [PATCH v2 01/37] virutil: Move string related functions to virstring.c

On 04/29/2013 07:50 AM, Michal Privoznik wrote: The source code base needs to be adapted as well. Some files include virutil.h just for the string related functions (here, the include is substituted to match the new file), some include virutil.h without any need (here, the include is removed),

[libvirt] [PATCH v2] virsh: fix incorrect argument errors for long options

For long options, print: * the option as specified by the user if it's unknown * the cannoncial long option if its argument is not a number (and should be) And for missing arguments, print both the short and the long option name. (Doing only one of those would require either parsing argv

Re: [libvirt] [PATCH] qemu: honor allowDiskFormatProbing when parsing command line

On 04/29/2013 06:16 PM, Eric Blake wrote: On 04/29/2013 07:56 AM, Ján Tomko wrote: My commit 024e9af broke this. --- src/qemu/qemu_command.c | 3 --- ... ACK. Using VIR_STORAGE_FILE_AUTO would be a security hole if it contradicts the user's

Re: [libvirt] [PATCH 2/2] qemu: Add VNC WebSocket support

On Mon, Apr 29, 2013 at 4:52 PM, Martin Kletzander mklet...@redhat.comwrote: diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 2acf535..2ddeb8c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -225,6 +225,7 @@

[libvirt] [RFC PATCH 5/4] qemu: detect -machine mem-merge capability

* src/qemu/qemu_capabilities.h: New capability bit. * src/qemu/qemu_capabilities.c (virQEMUCapsProbeQMPCommandLine): New function; use it to set new capability bit. (virQEMUCapsInitQMP): Use new function. --- As promised, here is how I would set the new capability for use in Osier's series here:

Re: [libvirt] [PATCH] portability: handle ifreq differences in virnetdev

On 04/27/2013 09:50 AM, Roman Bogorodskiy wrote: FreeBSD (and maybe other BSDs) have different member names in struct ifreq when compared to Linux, such as: - uses ifr_data instead of ifr_newname for setting interface names - uses ifr_index instead of ifr_ifindex for interface

Re: [libvirt] [PATCH 2/2] qemu: Add VNC WebSocket support

On 04/29/2013 11:34 AM, Ruben Kerkhof wrote: On Mon, Apr 29, 2013 at 4:52 PM, Martin Kletzander mklet...@redhat.comwrote: diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 2acf535..2ddeb8c 100644 --- a/src/qemu/qemu_capabilities.c +++

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386) The person who builds and packages xen gets to choose which emulators are built. We examine

[libvirt] [PATCH v2 0/2] qemu: xml-native memballoon fixes

v1: https://www.redhat.com/archives/libvir-list/2013-April/msg01910.html v2: Instead of assuming 'pci' as the default memballoon device, assign the addresses when doing xml-native conversion and add an error message for the wrong address type. Ján Tomko (2): qemu: assign addresses when

[libvirt] [PATCH v2 1/2] qemu: assign addresses when converting xml to native

This adds addresses to domxml-to-native output and chooses the correct virtio devices for ccw and s390 machines. https://bugzilla.redhat.com/show_bug.cgi?id=957077 --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH v2 2/2] qemu: report an error if memballoon has wrong address type

qemuBuildMemballoonDevStr returns NULL if memballoon doesn't have the right address type, but it doesn't report an error, leading to: error: An error occurred, but the cause is unknown Report a helpful error message instead, e.g.: error: XML error: memballoon unsupported with address type 'usb'

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386) The person who builds and

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

On Mon, Apr 29, 2013 at 03:49:41PM +0100, David Scott wrote: We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

David Scott wrote: We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files changed, 41 insertions(+),

Re: [libvirt] [PATCH v2 10/37] Adapt to VIR_STRDUP in src/lxc/*

On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_conf.c | 18 +- src/lxc/lxc_container.c | 8 src/lxc/lxc_controller.c | 6 +++--- src/lxc/lxc_driver.c | 7 ++- src/lxc/lxc_process.c| 4 ++--

Re: [libvirt] [PATCH v2 12/37] Adapt to VIR_STRDUP in src/node_device/*

On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/node_device/node_device_driver.c | 28 -- src/node_device/node_device_hal.c| 13 ++--- src/node_device/node_device_udev.c | 102 +++ 3 files changed, 60 insertions(+), 83 deletions(-)

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386)

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

Jim Fehlig wrote: David Scott wrote: We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files

Re: [libvirt] [PATCH v2 12/37] Adapt to VIR_STRDUP in src/node_device/*

On 04/29/2013 12:51 PM, John Ferlan wrote: On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/node_device/node_device_driver.c | 28 -- src/node_device/node_device_hal.c| 13 ++--- src/node_device/node_device_udev.c | 102 +++ 3 files

[libvirt] [PATCH 2/2] qemu: put usb cgroup setup in common function

The USB-specific cgroup setup had been inserted inline in qemuDomainAttachHostUsbDevice and qemuSetupCgroup, but now there is a common cgroup setup function called for all hostdevs, so it makes sens to put the usb-specific setup there and just rely on that function being called. The one thing I'm

[libvirt] [PATCH 0/2] fix cgroup setup for vfio hostdevs

The first patch is required for vfio hostdev to work. The 2nd is just a refactor to eliminate duplicated code for usb hostdev cgroup setup. Laine Stump (2): qemu: add vfio devices to cgroup ACL when appropriate qemu: put usb cgroup setup in common function src/qemu/qemu.conf

[libvirt] [PATCH 1/2] qemu: add vfio devices to cgroup ACL when appropriate

PCIO device assignment using VFIO requires read/write access by the qemu process to /dev/vfio/vfio, and /dev/vfio/nn, where nn is the VFIO group number that the assigned device belongs to (and can be found with the function virPCIDeviceGetVFIOGroupDev) /dev/vfio/vfio can be accessible to any

Re: [libvirt] [PATCH v2] virsh: fix incorrect argument errors for long options

On 04/29/2013 11:27 AM, Ján Tomko wrote: For long options, print: * the option as specified by the user if it's unknown * the cannoncial long option if its argument is not s/cannonical/canonical/ a number (and should be) And for missing arguments, print both the short and the long

Re: [libvirt] [PATCH v2 03/37] Adapt to VIR_STRDUP in daemon/*

On 04/29/2013 07:50 AM, Michal Privoznik wrote: --- daemon/libvirtd-config.c | 37 ++- daemon/libvirtd.c| 17 + daemon/remote.c | 94 3 files changed, 66 insertions(+), 82 deletions(-) diff --git

Re: [libvirt] [PATCH 1/2] qemu: add vfio devices to cgroup ACL when appropriate

On 04/29/2013 02:28 PM, Laine Stump wrote: PCIO device assignment using VFIO requires read/write access by the qemu process to /dev/vfio/vfio, and /dev/vfio/nn, where nn is the VFIO group number that the assigned device belongs to (and can be found with the function

[libvirt] LXC: user namespaces

Hi! We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise David and I will implement it and send patches very soon. Thanks, //richard -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 2/2] qemu: put usb cgroup setup in common function

On 04/29/2013 02:28 PM, Laine Stump wrote: The USB-specific cgroup setup had been inserted inline in qemuDomainAttachHostUsbDevice and qemuSetupCgroup, but now there is a common cgroup setup function called for all hostdevs, so it makes sens to put the usb-specific setup there and just rely on

Re: [libvirt] [PATCH v2 2/2] qemu: report an error if memballoon has wrong address type

On 04/29/2013 12:20 PM, Ján Tomko wrote: qemuBuildMemballoonDevStr returns NULL if memballoon doesn't have the right address type, but it doesn't report an error, leading to: error: An error occurred, but the cause is unknown Report a helpful error message instead, e.g.: error: XML error:

Re: [libvirt] [PATCH v2 1/2] qemu: assign addresses when converting xml to native

On 04/29/2013 12:20 PM, Ján Tomko wrote: This adds addresses to domxml-to-native output and chooses the correct virtio devices for ccw and s390 machines. https://bugzilla.redhat.com/show_bug.cgi?id=957077 --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) ACK. diff

[libvirt] [PATCH] libxl: Fix double-dispose of libxl domain config

libxlBuildDomainConfig() was disposing the libxl_domain_config object on error, only to have it disposed again by libxlBuildDomainConfig()'s caller, which resulted in a segfault. Leave disposing of the config object to it's owner. --- src/libxl/libxl_conf.c | 12 1 file changed, 4

  1   2   >