[libvirt] [Qemu-devel]virtio serial device problem

2013-05-07 Thread Li Zhang
Hi all, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. qemu-system-ppc64: -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=com.redhat.rhevm.vdsm: Bus 'virtio-serial0.0' is full qemu-system-ppc64: -device

Re: [libvirt] [PATCH 1/3] qemu: new vnc display sharing policy caps flag

2013-05-07 Thread Ján Tomko
On 05/06/2013 03:19 PM, Guannan Ren wrote: QEMU_CAPS_VNC_DISPLAY_POLICY (qemu = v1.10) --- docs/formatdomain.html.in | 13 +++-- docs/schemas/domaincommon.rng | 9 + src/qemu/qemu_capabilities.c | 12 src/qemu/qemu_capabilities.h | 1 +

Re: [libvirt] [PATCH 2/3] conf: add 'policy' attribute to graphics element for vnc

2013-05-07 Thread Ján Tomko
On 05/06/2013 03:19 PM, Guannan Ren wrote: -vnc :5900,share=allow-exclusive allows clients to ask for exclusive access which is implemented by dropping other connections Connecting multiple clients in parallel requires all clients asking for a shared session (vncviewer: -shared switch)

Re: [libvirt] [PATCH 3/3] qemu: support share attribute and its values to -vnc option

2013-05-07 Thread Ján Tomko
On 05/06/2013 03:19 PM, Guannan Ren wrote: --- src/qemu/qemu_command.c| 13 .../qemuxml2argv-graphics-vnc-policy.args | 4 +++ .../qemuxml2argv-graphics-vnc-policy.xml | 35 ++ tests/qemuxml2argvtest.c

[libvirt] [PATCH] iscsi: don't leak portal string when starting a pool

2013-05-07 Thread Ján Tomko
--- src/storage/storage_backend_iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index cf25919..3b48f44 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -772,6 +772,7

Re: [libvirt] [PATCH v3 04/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/cpu/*

2013-05-07 Thread Michal Privoznik
On 07.05.2013 00:00, Eric Blake wrote: On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/cpu/cpu_generic.c | 8 src/cpu/cpu_map.c | 3 ++- src/cpu/cpu_powerpc.c | 13 ++--- src/cpu/cpu_x86.c | 10 +- 4 files changed, 17 insertions(+), 17

Re: [libvirt] [PATCH] Fix docs generator regression in previous commit

2013-05-07 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 01:26:20PM -0600, Eric Blake wrote: On 05/03/2013 12:16 PM, Daniel P. Berrange wrote: On Fri, May 03, 2013 at 10:51:48AM -0600, Eric Blake wrote: On 05/03/2013 09:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The previous commit

Re: [libvirt] [PATCH 0/2] VIR_STRDUP ease of use

2013-05-07 Thread Michal Privoznik
On 07.05.2013 05:24, Eric Blake wrote: As pointed out during my (ongoing) review of Michal's series, I think that letting VIR_STRDUP take a NULL source can make it easier to use; I also think that documenting the guarantee that it evaluates arguments exactly once is worth enforcing. Hmm, I

Re: [libvirt] Missing documentation?

2013-05-07 Thread Joseph Glanville
Fixed the libxml2 errors. You need to install the DTD into /etc/xml as W3C is now blocking libxml2 from downloading them, that is what caused the errors I saw. On debian systems the DTD for XHTML is packaged as w3c-dtd-xhtml For RHEL compatible systems I think the correct package is html11-dtds

Re: [libvirt] [PATCH v3 04/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/cpu/*

2013-05-07 Thread Michal Privoznik
On 07.05.2013 11:15, Michal Privoznik wrote: On 07.05.2013 00:00, Eric Blake wrote: On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/cpu/cpu_generic.c | 8 src/cpu/cpu_map.c | 3 ++- src/cpu/cpu_powerpc.c | 13 ++--- src/cpu/cpu_x86.c | 10 +- 4

Re: [libvirt] virtio serial device problem

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this? It might have been fixed already. Paolo qemu-system-ppc64: -device

Re: [libvirt] [PATCH] qemu: allocate network connections sooner during domain startup

2013-05-07 Thread Michal Privoznik
On 06.05.2013 22:16, Laine Stump wrote: VFIO device assignment requires a cgroup ACL to be setup for access to the /dev/vfio/nn group device for any devices that will be assigned to a guest. In the case of a host device that is allocated from a pool, it was being allocated during

[libvirt] [PATCH] Fix namespace bugs in API docs, todo page hv support page

2013-05-07 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The XSL for generating the API docs was missing the HTML5 namespace declarations. The todo and hvsupport scripts were also missing the HTML5 doctype / namespace declaration. Pushed as a website breaker fix Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Fix docs generator regression in previous commit

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 09:26:04AM +0800, Daniel Veillard wrote: On Fri, May 03, 2013 at 04:59:13PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The previous commit failed to update the XSL to take account of fact that in XHTML mode the elements need

[libvirt] [libvirt PATCH] storage: Skip not active lv volumes

2013-05-07 Thread Osier Yang
If the volume is of a clustered volume group, and not active, the related pool APIs fails on open /dev/vg/lv. If the volume is suspended, it hangs on open(2) the volume. Though the best solution is to expose the volume status in volume XML, and even better to provide API to active/deactive the

[libvirt] [PATCH] get rid of virBufferAsprintf where possible

2013-05-07 Thread Ján Tomko
Use virBufferAddLit or virBufferAddChar instead. --- src/conf/domain_conf.c | 14 +++--- src/conf/network_conf.c | 4 ++-- src/conf/storage_conf.c | 6 +++--- src/nwfilter/nwfilter_learnipaddr.c | 2 +- src/phyp/phyp_driver.c | 28

Re: [libvirt] Missing documentation?

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 02:38:30AM -0700, Joseph Glanville wrote: Fixed the libxml2 errors. You need to install the DTD into /etc/xml as W3C is now blocking libxml2 from downloading them, that is what caused the errors I saw. On debian systems the DTD for XHTML is packaged as w3c-dtd-xhtml

Re: [libvirt] [PATCH 01/25] conf: Generic XMLs for scsi hostdev

2013-05-07 Thread Osier Yang
On 07/05/13 00:33, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com An example of the scsi hostdev XML: hostdev mode='subsystem' type='scsi' source adapter name='scsi_host0'/ address bus='0' target='0'

Re: [libvirt] [PATCH] get rid of virBufferAsprintf where possible

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 12:37:07PM +0200, Ján Tomko wrote: Use virBufferAddLit or virBufferAddChar instead. --- src/conf/domain_conf.c | 14 +++--- src/conf/network_conf.c | 4 ++-- src/conf/storage_conf.c | 6 +++---

Re: [libvirt] Missing documentation?

2013-05-07 Thread Joseph Glanville
You might want to make sure you update the website too hehe. http://libvirt.org/html/libvirt-libvirt.html is still dead. :P All good mate, mistakes happen. Joseph. On Tue, May 7, 2013 at 3:35 AM, Daniel P. Berrange berra...@redhat.comwrote: On Tue, May 07, 2013 at 02:38:30AM -0700, Joseph

Re: [libvirt] Missing documentation?

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 03:46:18AM -0700, Joseph Glanville wrote: You might want to make sure you update the website too hehe. http://libvirt.org/html/libvirt-libvirt.html is still dead. :P All good mate, mistakes happen. The website automatically refreshes itself from GIT once an hour via

[libvirt] [PATCH] Point users to Virt-Viewer MSI installers for Windows builds

2013-05-07 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The Windows port page currently links to pre-built libvirt DLLs for release 0.8.8 which are 2 years old now. Until we can reliably produce official Windows installers, point people to the virt-viewer MSI installers instead which include the libvirt

Re: [libvirt] [PATCH 10/25] qemu: Introduce activeScsiHostdevs list for scsi host devices

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com Although virtio-scsi supports SCSI PR, the device on host may do not support it. To avoid losing data, we only allow one scsi hostdev to be passthroughed to one live guest, Just like what we do for PCI and

Re: [libvirt] [PATCH] get rid of virBufferAsprintf where possible

2013-05-07 Thread Michal Privoznik
On 07.05.2013 12:37, Ján Tomko wrote: Use virBufferAddLit or virBufferAddChar instead. --- src/conf/domain_conf.c | 14 +++--- src/conf/network_conf.c | 4 ++-- src/conf/storage_conf.c | 6 +++--- src/nwfilter/nwfilter_learnipaddr.c | 2 +-

Re: [libvirt] [PATCH 06/25] Introduce readonly for hostdev

2013-05-07 Thread Osier Yang
On 07/05/13 02:01, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: Since it's generic enough to be used by other types in future, I put it in hostdev as sub-element, though now it's only used by scsi host device. --- docs/formatdomain.html.in | 4 +++

Re: [libvirt] [PATCH 04/25] qemu: Build qemu command line for scsi host device

2013-05-07 Thread Osier Yang
On 07/05/13 01:37, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com Except the scsi host device's controller is lsilogic, mapping between the libvirt attributes and scsi-generic properties is: libvirt qemu

Re: [libvirt] [PATCH] Fix docs generator regression in previous commit

2013-05-07 Thread Daniel Veillard
On Tue, May 07, 2013 at 11:21:45AM +0100, Daniel P. Berrange wrote: On Tue, May 07, 2013 at 09:26:04AM +0800, Daniel Veillard wrote: On Fri, May 03, 2013 at 04:59:13PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The previous commit failed to update

Re: [libvirt] [PATCH 03/25] utils: util functions for scsi hostdev

2013-05-07 Thread Osier Yang
On 07/05/13 01:20, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com This patch adds util functions for scsi hostdev. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com Signed-off-by: Osier Yang jy...@redhat.com --- v3 - v4: * Use strdup

[libvirt] [PATCHv3] rpc: message related sizes enlarged

2013-05-07 Thread Viktor Mihajlovski
From: Daniel Hansel daniel.han...@linux.vnet.ibm.com We have seen an issue on s390x platform where domain XMLs larger than 1MB were used. The define command was finished successfully. The dumpxml command was not successful (i.e. could not encode message payload). Enlarged message related sizes

Re: [libvirt] [PATCH 10/25] qemu: Introduce activeScsiHostdevs list for scsi host devices

2013-05-07 Thread Osier Yang
On 07/05/13 18:57, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com Although virtio-scsi supports SCSI PR, the device on host may do not support it. To avoid losing data, we only allow one scsi hostdev to be passthroughed to one live guest,

Re: [libvirt] [libvirt-glib 3/3] gconfig: Add GVirConfigDomainSnapshot getters/setters

2013-05-07 Thread Christophe Fergeau
On Fri, May 03, 2013 at 07:01:11PM +0200, Christophe Fergeau wrote: On Thu, May 02, 2013 at 06:33:44PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com wrote: + + +const char

[libvirt] [PATCH RESENT] qemu: Enable the capability bit for -no-kvm-pit-reinjection on x86 only

2013-05-07 Thread Viktor Mihajlovski
From: Boris Fiuczynski fiu...@linux.vnet.ibm.com On architectures not supporting the Intel specific programmable interval timer, like e.g. S390, starting a domain with a clock definition containing a pit timer results in the error Option no-kvm-pit-reinjection not supported for this target. By

[libvirt] [PATCH] syntax-check: forbid virBufferAsprintf with string literals

2013-05-07 Thread Ján Tomko
--- cfg.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/cfg.mk b/cfg.mk index 1d63bbd..06f89d1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -490,6 +490,11 @@ sc_prohibit_virBufferAdd_with_string_literal: halt='use virBufferAddLit, not virBufferAdd, with a string literal' \

[libvirt] [libvirt-java] [PATCH] trivial remove unused imports

2013-05-07 Thread Stefan Majer
Signed-off-by: Stefan Majer stefan.majer at gmail dot com --- src/main/java/org/libvirt/jna/Libvirt.java | 1 - src/main/java/org/libvirt/jna/virError.java | 1 - 2 files changed, 2 deletions(-) diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java

Re: [libvirt] [PATCH 02/25] qemu: New cap flags for scsi-generic

2013-05-07 Thread Ján Tomko
On 05/03/2013 08:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com Adding two cap flags for scsi-generic: QEMU_CAPS_SCSI_GENERIC QEMU_CAPS_SCSI_GENERIC_BOOTINDEX Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com Signed-off-by: Osier Yang hanc.f...@cn.fujitsu.com

Re: [libvirt] [PATCHv3] rpc: message related sizes enlarged

2013-05-07 Thread Michal Privoznik
On 07.05.2013 13:22, Viktor Mihajlovski wrote: From: Daniel Hansel daniel.han...@linux.vnet.ibm.com We have seen an issue on s390x platform where domain XMLs larger than 1MB were used. The define command was finished successfully. The dumpxml command was not successful (i.e. could not encode

Re: [libvirt] [PATCH 11/25] qemu: Refactor helpers for USB device attachment

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: It's better to put the usb related codes into qemuDomainAttachHostUsbDevice instead of qemuDomainAttachHostDevice. And in the old qemuDomainAttachHostDevice, just stealing the usb from driver-activeUsbHostdevs leaks the memory. Seems this is a bug

Re: [libvirt] [PATCHv3] rpc: message related sizes enlarged

2013-05-07 Thread Viktor Mihajlovski
On 05/07/2013 02:14 PM, Michal Privoznik wrote: ACK. Now is the best time to push this so we have as much time for testing as possible. So I've pushed this as well. Michal Right, a couple of weeks should suffice. Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM

Re: [libvirt] [PATCH 12/25] qemu: Add hotplug support for scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: From: Han Cheng hanc.f...@cn.fujitsu.com This adds both attachment and detachment support for scsi host device. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com Signed-off-by: Osier Yang jyang@redhat --- src/qemu/qemu_hotplug.c | 141

Re: [libvirt] [PATCH RESENT] qemu: Enable the capability bit for -no-kvm-pit-reinjection on x86 only

2013-05-07 Thread Michal Privoznik
On 07.05.2013 13:34, Viktor Mihajlovski wrote: From: Boris Fiuczynski fiu...@linux.vnet.ibm.com On architectures not supporting the Intel specific programmable interval timer, like e.g. S390, starting a domain with a clock definition containing a pit timer results in the error Option

Re: [libvirt] [PATCH 14/25] conf: Introduce shareable for hostdev

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: Unlike disk device, the scsi-generic always writethrough the data, so no need to introduce a cache tag, and set cache=off. --- docs/formatdomain.html.in | 6 docs/schemas/domaincommon.rng | 5 +++

Re: [libvirt] [PATCH 13/25] conf: Generate address for scsi host device automatically

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: With unknown good reasons, the attribute bus of scsi device address is always set to 0, same for attribute target. (See virDomainDiskDefAssignAddress). Though we might need to change the algrithom to honor bus s/algrithom/algorithm and target too,

Re: [libvirt] virtio serial device problem

2013-05-07 Thread Li Zhang
On 2013年05月07日 17:50, Paolo Bonzini wrote: Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this? It might have been fixed already. You mean this is one bug of QEMU, right?

Re: [libvirt] [PATCH 15/25] utils: Rename scsi-path to scsi-sg_path

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: sg_path is more clear to indicate what it tries to store. And later patch will use path to store the path like /dev/sda. And also rename virSCSIDeviceGetDevStr to virSCSIDeviceGetSgName, to reflect what the function does more clear. Seems to me that

Re: [libvirt] [PATCH 16/25] qemu: Rename qemu_driver-sharedDisks to qemu_driver-sharedDevices

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: Shared disk is not only the thing we should care about after scsi hostdev is introduced. A same scsi device can be used as disk for one domain, and as scsi hostdev for another domain at the same time. That's why this patch renames

Re: [libvirt] virtio serial device problem

2013-05-07 Thread Li Zhang
On 2013年05月07日 21:05, Alexey Kardashevskiy wrote: On 05/07/2013 07:50 PM, Paolo Bonzini wrote: Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this?

Re: [libvirt] [PATCH 17/25] utils: Add a helper to get the device name that sg device mapped to

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: E.g. % sg_map /dev/sg0 /dev/sda /dev/sg1 /dev/sr0 What the helper gets for /dev/sg0 is /dev/sda, it will be used by later patch. --- src/libvirt_private.syms | 1 + src/util/virscsi.c | 47

Re: [libvirt] [PATCH 1/3] qemu: new vnc display sharing policy caps flag

2013-05-07 Thread Eric Blake
On 05/07/2013 01:51 AM, Ján Tomko wrote: On 05/06/2013 03:19 PM, Guannan Ren wrote: QEMU_CAPS_VNC_DISPLAY_POLICY (qemu = v1.10) Huh? qemu is at 1.5, not 1.10. Based on your code, you meant 1.1. -if (version = 1001000) +if (version = 1001000) { virQEMUCapsSet(qemuCaps,

Re: [libvirt] [PATCH] Point users to Virt-Viewer MSI installers for Windows builds

2013-05-07 Thread Eric Blake
On 05/07/2013 04:55 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Windows port page currently links to pre-built libvirt DLLs for release 0.8.8 which are 2 years old now. Until we can reliably produce official Windows installers, point people to the

Re: [libvirt] [libvirt-java] [PATCH] trivial remove unused imports

2013-05-07 Thread Eric Blake
On 05/07/2013 05:53 AM, Stefan Majer wrote: Signed-off-by: Stefan Majer stefan.majer at gmail dot com --- src/main/java/org/libvirt/jna/Libvirt.java | 1 - src/main/java/org/libvirt/jna/virError.java | 1 - 2 files changed, 2 deletions(-) Seems simple enough that even I can give: ACK --

Re: [libvirt] [PATCH] syntax-check: forbid virBufferAsprintf with string literals

2013-05-07 Thread Eric Blake
On 05/07/2013 05:46 AM, Ján Tomko wrote: --- cfg.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/cfg.mk b/cfg.mk index 1d63bbd..06f89d1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -490,6 +490,11 @@ sc_prohibit_virBufferAdd_with_string_literal: halt='use virBufferAddLit, not

Re: [libvirt] [libvirt PATCH] storage: Skip not active lv volumes

2013-05-07 Thread Eric Blake
On 05/07/2013 04:29 AM, Osier Yang wrote: If the volume is of a clustered volume group, and not active, the related pool APIs fails on open /dev/vg/lv. If the volume is suspended, it hangs on open(2) the volume. Though the best solution is to expose the volume status in volume XML, and even

[libvirt] [PATCH] Ensure stub todo.html.in file is HTML5

2013-05-07 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If no todo.cfg is present, make sure the stub is in HTML5 format and clearly states that the config was not available Pushed as another website build breaker fix Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/Makefile.am | 2 +- 1

Re: [libvirt] [PATCH] qemu: allocate network connections sooner during domain startup

2013-05-07 Thread Laine Stump
On 05/07/2013 05:52 AM, Michal Privoznik wrote: On 06.05.2013 22:16, Laine Stump wrote: I'd expect a one line comment here at least to give a reason why we are skipping VIR_DOMAIN_NET_TYPE_HOSTDEV. Something like: /* hostdev interfaces already handled by qemuNetworkPrepareDevices */ It's

Re: [libvirt] [PATCH 15/25] utils: Rename scsi-path to scsi-sg_path

2013-05-07 Thread Osier Yang
On 07/05/13 21:50, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: sg_path is more clear to indicate what it tries to store. And later patch will use path to store the path like /dev/sda. And also rename virSCSIDeviceGetDevStr to virSCSIDeviceGetSgName, to reflect what the

Re: [libvirt] [PATCH 17/25] utils: Add a helper to get the device name that sg device mapped to

2013-05-07 Thread Osier Yang
On 07/05/13 22:00, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: E.g. % sg_map /dev/sg0 /dev/sda /dev/sg1 /dev/sr0 What the helper gets for /dev/sg0 is /dev/sda, it will be used by later patch. --- src/libvirt_private.syms | 1 + src/util/virscsi.c | 47

[libvirt] [libvirt-java] [RFC] simplify java build process

2013-05-07 Thread Stefan Majer
Hi, I have small patch series which tries to accomplish a easier developer experience when building libvirt-java. The reason is simple based on the fact that the following workflow does not work out of the box. 1. with ant: # git clone git://libvirt.org/libvirt-java.git # cd libvirt-java # ant

Re: [libvirt] [PATCH] qemu: allocate network connections sooner during domain startup

2013-05-07 Thread Michal Privoznik
On 07.05.2013 16:47, Laine Stump wrote: On 05/07/2013 05:52 AM, Michal Privoznik wrote: On 06.05.2013 22:16, Laine Stump wrote: I'd expect a one line comment here at least to give a reason why we are skipping VIR_DOMAIN_NET_TYPE_HOSTDEV. Something like: /* hostdev interfaces already

Re: [libvirt] [PATCH] qemu: allocate network connections sooner during domain startup

2013-05-07 Thread Laine Stump
On 05/07/2013 10:57 AM, Michal Privoznik wrote: On 07.05.2013 16:47, Laine Stump wrote: On 05/07/2013 05:52 AM, Michal Privoznik wrote: On 06.05.2013 22:16, Laine Stump wrote: I'd expect a one line comment here at least to give a reason why we are skipping VIR_DOMAIN_NET_TYPE_HOSTDEV.

Re: [libvirt] virtio serial device problem

2013-05-07 Thread Alexey Kardashevskiy
On 05/07/2013 07:50 PM, Paolo Bonzini wrote: Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this? b3e6d591b05538056d665572f3e3bbfb3cbb70e7 It might have been fixed

Re: [libvirt] [PATCH 13/25] conf: Generate address for scsi host device automatically

2013-05-07 Thread Osier Yang
On 07/05/13 21:42, John Ferlan wrote: On 05/03/2013 02:07 PM, Osier Yang wrote: With unknown good reasons, the attribute bus of scsi device address is always set to 0, same for attribute target. (See virDomainDiskDefAssignAddress). Though we might need to change the algrithom to honor bus

Re: [libvirt] [PATCH] get rid of virBufferAsprintf where possible

2013-05-07 Thread Ján Tomko
On 05/07/2013 12:58 PM, Michal Privoznik wrote: On 07.05.2013 12:37, Ján Tomko wrote: Use virBufferAddLit or virBufferAddChar instead. --- src/conf/domain_conf.c | 14 +++--- src/conf/network_conf.c | 4 ++-- src/conf/storage_conf.c | 6 +++---

Re: [libvirt] [PATCH] syntax-check: forbid virBufferAsprintf with string literals

2013-05-07 Thread Ján Tomko
On 05/07/2013 04:32 PM, Eric Blake wrote: On 05/07/2013 05:46 AM, Ján Tomko wrote: --- cfg.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/cfg.mk b/cfg.mk index 1d63bbd..06f89d1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -490,6 +490,11 @@

Re: [libvirt] [sandbox PATCH v2 2/2] Add support for templated unit in virt-sandbox

2013-05-07 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 10:01:23PM +0200, Michael Scherer wrote: This permit to create a templated unit inside the sandbox, using the sandbox name as a variable and so running the same unit with a different configuration without too much hassle. For example, someone could have several

[libvirt] ANNOUNCE: libvirt-sandbox Nubian Desert release 0.2.0

2013-05-07 Thread Daniel P. Berrange
I pleased to announce the a new public release of libvirt-sandbox, version 0.2.0, is now available for download ftp://libvirt.org/libvirt/sandbox/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) The libvirt-sandbox package

Re: [libvirt] [PATCH] Ensure stub todo.html.in file is HTML5

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 10:31:20AM -0600, Eric Blake wrote: On 05/07/2013 08:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If no todo.cfg is present, make sure the stub is in HTML5 format and clearly states that the config was not available Pushed as

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-05-07 Thread Eric Blake
On 03/11/2013 05:43 AM, Christophe Fergeau wrote: The text version of LGPLv2.1 available at http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly different from COPYING.LIB: - several paragraphs were rewrapped - the FSF address has changed, so the license has been changed to

Re: [libvirt] Bug in DOMINFO command when balloon driver is used on a vm with more then 8 GB of MaxMemory ?

2013-05-07 Thread Eric Blake
On 03/22/2013 04:11 PM, fc lists wrote: Hi , I have been banging my head on this for the last 8 hours ... and i really need to know if is really a bug or i am doing something wrong. Cleaning out my inbox, and I don't think I ever saw a reply to this one. Description of the problem: When

Re: [libvirt] [PATCH] Ensure stub todo.html.in file is HTML5

2013-05-07 Thread Eric Blake
On 05/07/2013 08:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If no todo.cfg is present, make sure the stub is in HTML5 format and clearly states that the config was not available Pushed as another website build breaker fix Signed-off-by: Daniel P.

Re: [libvirt] [PATCH] qemu: allocate network connections sooner during domain startup

2013-05-07 Thread Eric Blake
On 05/07/2013 09:12 AM, Laine Stump wrote: However, if we are gonna move all the allocation code out of the qemuBuildCommandLine we should remember now, that there are gonna be several FDs being passed (multiple for /dev/net/tun and for /dev/vhost-net). Yep. That's the thing (along with

[libvirt] [PATCH-v5.1] Support for static routes on a virtual bridge

2013-05-07 Thread Gene Czarcinski
network: static route support for network This update includes Laine Stump's comments/suggestions. Once again he has improved my over-engineered solutions. My original patch and his patch have been squashed/merged with this being the result. That plus a little simplified code added to

[libvirt] [PATCH-v5.1] Support for static routes on a virtual bridge

2013-05-07 Thread Gene Czarcinski
network: static route support for network This update includes Laine Stump's comments/suggestions. Once again he has improved my over-engineered solutions. My original patch and his patch have been squashed/merged with this being the result. That plus a little simplified code added to

Re: [libvirt] [libvirt-users] libvirt-snmp on Ubuntu

2013-05-07 Thread george john
Thank you. I was able to compile/install libvirt-snmp on Ubuntu by mainly following the instructions on: http://lost-and-found-narihiro.blogspot.com/2013/01/how-to-install-libvirt-snmp-on-ubuntu.html When I check the data returned by snmpwalk, I find that values for the UUID of the Virtual

Re: [libvirt] [PATCH 18/25] qemu: Refactor the helpers to track shared scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: This changes the helpers qemu{Add,Remove}SharedDisk into qemu{Add,Remove}SharedDevice, as most of the code in the helpers can be reused for scsi host device. To track the shared scsi host device, first it finds out the device path (e.g. /dev/s[dr]*)

Re: [libvirt] [PATCH 19/25] qemu: Manage shared device entry for scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: This adds the shared device entry when starting domain (more exactly, when preparing host devices), and remove the entry when destroying domain (when reattaching host devices). --- src/qemu/qemu_hostdev.c | 25 ++--- 1 file

Re: [libvirt] [PATCH 21/25] conf: Introduce sgio for hostdev

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: sgio is only valid for scsi host device. --- docs/formatdomain.html.in | 7 - docs/schemas/domaincommon.rng | 8 + src/conf/domain_conf.c | 34 ++---

Re: [libvirt] [PATCH 0/2] VIR_STRDUP ease of use

2013-05-07 Thread Eric Blake
On 05/07/2013 03:37 AM, Michal Privoznik wrote: On 07.05.2013 05:24, Eric Blake wrote: As pointed out during my (ongoing) review of Michal's series, I think that letting VIR_STRDUP take a NULL source can make it easier to use; I also think that documenting the guarantee that it evaluates

Re: [libvirt] [PATCH 18/40] Simplify the Xen domain get info/state driver methods

2013-05-07 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the xenUnifiedDomainGetInfo and xenUnifiedDomainGetState drivers call the correct sub-driver APIs directly. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 52

Re: [libvirt] [PATCH 19/40] Simplify the Xen domain save/restore driver methods

2013-05-07 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call the XenD APIs for save/restore, since that driver will always be open. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 21 -

[libvirt] [PATCH 3/2] string: test VIR_STRDUP

2013-05-07 Thread Eric Blake
The surest way to avoid regressions is to test documented behavior :) * tests/virstringtest.c (testStrdup): New test case. Signed-off-by: Eric Blake ebl...@redhat.com --- tests/virstringtest.c | 49 - 1 file changed, 48 insertions(+), 1

Re: [libvirt] [PATCH 22/25] qemu: Move qemuSetUnprivSGIO into qemu_conf.c

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: unpriv_sgio setting is tight with the shared device helpers, let's put them together in qemu_conf.c --- src/qemu/qemu_conf.c| 36 src/qemu/qemu_conf.h| 2 ++ src/qemu/qemu_process.c | 38

Re: [libvirt] [PATCH 23/25] qemu: Refactor qemuSetUnprivSGIO to support scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: Just like what previous patches do, it refactors qemuSetUnprivSGIO to take the virDomainDeviceDefPtr as argument instead. --- src/qemu/qemu_conf.c| 67 - src/qemu/qemu_conf.h| 2 +-

Re: [libvirt] [PATCH 24/25] qemu: Set unpriv_sgio for scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: --- src/qemu/qemu_hostdev.c | 3 +++ 1 file changed, 3 insertions(+) ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 25/25] qemu: Check conflicts for shared scsi host device

2013-05-07 Thread John Ferlan
On 05/03/2013 02:07 PM, Osier Yang wrote: Just like previous patches, this changes qemuCheckSharedDisk into qemuCheckSharedDevice, which takes a virDomainDeviceDefPtr argument instead. --- src/qemu/qemu_conf.c | 86 +--- 1 file changed, 61

Re: [libvirt] [libvirt PATCH] storage: Skip not active lv volumes

2013-05-07 Thread Osier Yang
On 07/05/13 22:47, Eric Blake wrote: On 05/07/2013 04:29 AM, Osier Yang wrote: If the volume is of a clustered volume group, and not active, the related pool APIs fails on open /dev/vg/lv. If the volume is suspended, it hangs on open(2) the volume. Though the best solution is to expose the

[libvirt] [PATCH v2 3/3] qemu: support share attribute and its values to -vnc option

2013-05-07 Thread Guannan Ren
--- src/qemu/qemu_command.c| 13 .../qemuxml2argv-graphics-vnc-policy.args | 4 +++ .../qemuxml2argv-graphics-vnc-policy.xml | 35 ++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 53

[libvirt] [PATCH v2 0/3]add 'sharePolicy' attribute for qemu vnc sharing policy

2013-05-07 Thread Guannan Ren
v1-v2: changed attribute name from 'policy' to 'sharePolicy' renamed caps flag name: QEMU_CAPS_VNC_SHARE_POLICY fixed issues pointed out in v1 review have to keep hard-coded version probe after checking qemu -help and qmp command. These patches try to add a new attribute 'sharePolicy'

[libvirt] [PATCH v2 1/3] qemu: new vnc display sharing policy caps flag

2013-05-07 Thread Guannan Ren
QEMU_CAPS_VNC_SHARE_POLICY (qemu = 1.1) --- src/qemu/qemu_capabilities.c | 12 src/qemu/qemu_capabilities.h | 1 + tests/qemuhelptest.c | 9 ++--- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v2 2/3] conf: add 'sharePolicy' attribute to graphics element for vnc

2013-05-07 Thread Guannan Ren
-vnc :5900,share=allow-exclusive allows clients to ask for exclusive access which is implemented by dropping other connections Connecting multiple clients in parallel requires all clients asking for a shared session (vncviewer: -shared switch) -vnc :5900,share=force-shared disables exclusive