Re: [libvirt] [PATCH v2] qemuOpenVhostNet: Decrease vhostfdSize on open failure

2013-05-29 Thread Michal Privoznik
On 28.05.2013 18:43, Laine Stump wrote: On 05/27/2013 02:44 AM, Michal Privoznik wrote: Currently, if there's an error opening /dev/vhost-net (e.g. because it doesn't exist) but it's not required we proceed with vhostfd array filled with -1 and vhostfdSize unchanged. Later, when constructing

Re: [libvirt] Put the audio work on Windows 2008 Server 64bits

2013-05-29 Thread Carlos Rodrigues
Thank you for your answer. I try to install Ulteo (http://www.ulteo.com/) with one Linux Application Server and one Windows Application Server and i need audio support on Windows APS. On, Linux the audio works ok, but on Windows 2008 Server, the device is detected but the driver is not working

[libvirt] [PATCH] storage: Refresh pool after creating volume

2013-05-29 Thread Osier Yang
https://bugzilla.redhat.com/show_bug.cgi?id=965442 One has to refresh the pool to get the correct pool info, this patch refreshes the pool after creating a volume in code instead. Pool refreshing failure is fine to ignore with a warning. --- src/storage/storage_driver.c | 6 ++ 1 file

Re: [libvirt] [PATCH 12/12] storage_conf: Use uid_t/gid_t instead of int to cast the value

2013-05-29 Thread Osier Yang
On 24/05/13 22:11, Eric Blake wrote: On 05/22/2013 06:05 AM, Osier Yang wrote: And error out if the casted value is not same with the original one, which prevents the bug on platform(s) where uid_t/gid_t has different size with long. --- src/conf/storage_conf.c | 13 - 1 file

Re: [libvirt] [PATCH 0/3 v3] Cgroup fixes

2013-05-29 Thread Osier Yang
ping? On 24/05/13 17:08, Osier Yang wrote: Instead of only post v2 of 5/7 (v2) in the old mail thread, this resend the left patches of v2 with a independant thread for easy reviewing. v2 - v3: * 1/7 ~ 4/7 of v1 are pushed. * goto label cleanup is kept with Daniel's suggestion for 5/7

Re: [libvirt] [PATCH] doc: cpu topology values should be equal to maxmium vcpus

2013-05-29 Thread Guannan Ren
On 05/29/2013 11:14 AM, Eric Blake wrote: On 05/28/2013 08:53 PM, Guannan Ren wrote: --- docs/formatdomain.html.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) There are little document about how to set values of sockets, cores, threads properly. After going through qemu code,

Re: [libvirt] [PATCH] storage: Refresh pool after creating volume

2013-05-29 Thread Martin Kletzander
On 05/29/2013 11:53 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=965442 One has to refresh the pool to get the correct pool info, this patch refreshes the pool after creating a volume in code instead. Pool refreshing failure is fine to ignore with a warning. ---

Re: [libvirt] [PATCH] doc: cpu topology values should be equal to maxmium vcpus

2013-05-29 Thread Guannan Ren
If the calculation is true, I think my patch is self-acked. s/self-acked/self-nacked/, sorry. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-29 Thread Eduardo Habkost
(CCing libvirt people) On Tue, May 28, 2013 at 06:48:52PM +0200, Andreas Färber wrote: Am 28.05.2013 18:46, schrieb Paolo Bonzini: Il 28/05/2013 18:34, Bandan Das ha scritto: Eduardo Habkost ehabk...@redhat.com writes: On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: Il

[libvirt] [PATCHv2] build: fix build with newer gnutls

2013-05-29 Thread Eric Blake
Building with gnutls 3.2.0 (such as shipped with current cygwin) fails with: rpc/virnettlscontext.c: In function 'virNetTLSSessionGetKeySize': rpc/virnettlscontext.c:1358:5: error: implicit declaration of function 'gnutls_cipher_get_key_size' [-Wimplicit-function-declaration] Yeah, it's stupid

[libvirt] [PATCH] build: fix build without libvirtd

2013-05-29 Thread Eric Blake
Building when configured --with-libvirtd=no fails with: In file included from ../src/qemu/qemu_command.h:30:0, from testutilsqemu.h:4, from networkxml2xmltest.c:14: ../src/qemu/qemu_conf.h:175:5: error: expected specifier-qualifier-list before

Re: [libvirt] [PATCH] storage: Refresh pool after creating volume

2013-05-29 Thread Osier Yang
On 29/05/13 20:51, Martin Kletzander wrote: On 05/29/2013 11:53 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=965442 One has to refresh the pool to get the correct pool info, this patch refreshes the pool after creating a volume in code instead. Pool refreshing failure is

Re: [libvirt] [PATCH] storage: Refresh pool after creating volume

2013-05-29 Thread Martin Kletzander
On 05/29/2013 05:55 PM, Osier Yang wrote: On 29/05/13 20:51, Martin Kletzander wrote: On 05/29/2013 11:53 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=965442 One has to refresh the pool to get the correct pool info, this patch refreshes the pool after creating a volume

Re: [libvirt] [PATCH] storage: Refresh pool after creating volume

2013-05-29 Thread Osier Yang
On 30/05/13 00:04, Martin Kletzander wrote: On 05/29/2013 05:55 PM, Osier Yang wrote: On 29/05/13 20:51, Martin Kletzander wrote: On 05/29/2013 11:53 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=965442 One has to refresh the pool to get the correct pool info, this patch

Re: [libvirt] [PATCH 1/3] qemu: migration: Improve p2p error if we can't open conn

2013-05-29 Thread Cole Robinson
On 05/28/2013 05:04 PM, Eric Blake wrote: On 05/28/2013 02:44 PM, Cole Robinson wrote: By actually showing the Open() error to the user --- src/qemu/qemu_migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Does qemuDomainObjExitRemote(vm) risk clobbering the last error

Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-29 Thread Michal Privoznik
On 28.05.2013 22:44, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_migration.c

Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-29 Thread Cole Robinson
On 05/29/2013 03:16 PM, Michal Privoznik wrote: On 28.05.2013 22:44, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff

[libvirt] [PATCH] build: work around broken sasl header

2013-05-29 Thread Eric Blake
Compilation on cygwin failed due to a bug in the sasl headers present on that platform (libsasl2-devel 2.1.26): In file included from rpc/virnetserverclient.c:27:0: /usr/include/sasl/sasl.h:230:38: error: expected declaration specifiers or '...' before 'size_t' * src/rpc/virnetserverclient.c

[libvirt] [PATCH] build: use correct rpc.h for lockd

2013-05-29 Thread Eric Blake
On cygwin, the build failed with: In file included from ./rpc/virnetmessage.h:24:0, from ./rpc/virnetclient.h:29, from locking/lock_driver_lockd.c:31: ./rpc/virnetprotocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory * src/Makefile.am

[libvirt] [PATCH] build: port vbox to cygwin

2013-05-29 Thread Eric Blake
I have no idea if a Cygwin app can be made to directly interact with VBoxXPCOMC.dll, but this at least lets compilation of vbox finish rather than requiring me to ./configure --without-vbox. * src/vbox/vbox_XPCOMCGlue.c (DYNLIB_NAME): Assume .dll under cygwin. Signed-off-by: Eric Blake

[libvirt] [PATCH] build: port qemu to cygwin

2013-05-29 Thread Eric Blake
A cygwin build of the qemu driver fails with: qemu/qemu_process.c: In function 'qemuPrepareCpumap': qemu/qemu_process.c:1803:31: error: 'CPU_SETSIZE' undeclared (first use in this function) CPU_SETSIZE is a Linux extension in sched.h; a bit more portable is using sysconf if _SC_NPROCESSORS_CONF