Hello,
I'm trying to set up a development environment on an Arndale (ARM Samsung
Exynos 5250) board to work on sVirt. I'm using Debian 7.0, I've downloaded
the source code from GIT and than:
./autogen.sh --prefix=$HOME/usr
make
but in the middle of make execution, the program fails with this
On Wed, May 22, 2013 at 06:22:12PM -0400, Michael R. Hines wrote:
Hi,
We run nvidia devices inside libvirt-managed LXC containers.
It used to be that simply doing:
$ echo 'c 195:* rwm' /sys/fs/cgroup/devices/libvirt/lxc
Then, after booting the container, we would do:
$ mknod -m
The xml outputed by HAL backend for scsi generic device:
device
namepci_8086_2922_scsi_host_scsi_device_lun0_scsi_generic/name
path/sys/devices/pci:00/:00:1f.2/host0/target0:0:0/0:0:0:0/scsi_generic/sg0/path
parentpci_8086_2922_scsi_host_scsi_device_lun0/parent
capability
---
include/libvirt/libvirt.h.in | 1 +
src/conf/node_device_conf.c | 4 +++-
src/conf/node_device_conf.h | 3 ++-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 1804c93..e7e003c 100644
---
The name format is constructed by libvirt, it's not that clear to
get what the device's sysfs path should be. This exposes the device's
sysfs path by a new tag path.
Since the sysfspath is filled during enumerating the devices by
either udev or HAL. It's an output-only tag.
---
Checking if the devtype is NULL along with each if statements
is bad. It wastes the performance, and also not good for reading.
And also when the devtype is NULL, the logic is also not clear.
This reorgnizes the logic of with if...else and a bunch of else if.
Other changes:
* Change the
The scsi generic device is listed as a child of the parent
of the mapped disk device. E.g.
+- pci__00_1f_2
| |
| +- scsi_host0
| | |
| | +- scsi_target0_0_0
| | |
| | +- scsi_0_0_0_0
| | |
| | +-
Since scsi generic device doesn't have DEVTYPE property set, the
only way to we have to get it's a scsi generic device is from the
SUBSYSTEM property.
The XML of the scsi generic device will be like:
device
namescsi_generic_sg0/name
Document for nodedev-list is also updated.
---
tools/virsh-nodedev.c | 3 +++
tools/virsh.pod | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c
index 3657c5f..da93b8e 100644
--- a/tools/virsh-nodedev.c
+++
On Wed, May 22, 2013 at 10:00:12AM +0200, Manuel VIVES wrote:
Hello,
I'm re-sending this patch for reviewing.
If necessary I'm willing to make
some changes to those patches.
I'm currently working on a better management for snapshots with virtualbox,
and my work is based on Virtualbox
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
---
src/conf/domain_conf.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 46d49a2..6dc8cf3 100644
---
Delay only makes sense with STP enabled.
---
tools/virsh-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 1c2e40b..2bdb215 100644
--- a/tools/virsh-interface.c
+++ b/tools/virsh-interface.c
@@ -894,7 +894,7 @@
According to plans, the release is available, I tagged it in git and
the tarball and rpms should be available shortly on the FTP:
ftp://libvirt.org/libvirt/
This is a fairly large release considering the number of commits which
went in, this is due in part to a lot of refactoring of the code
On Sat, May 25, 2013 at 07:07:49AM -0600, Eric Blake wrote:
On 05/15/2013 11:47 PM, Roman Bogorodskiy wrote:
This method is useful not only in virnetdev.c.
---
src/libvirt_private.syms | 1 +
src/util/virnetdev.c | 15 +--
src/util/virnetdev.h
On 03/06/13 18:22, Jiri Denemark wrote:
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
---
src/conf/domain_conf.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c
On Tue, May 28, 2013 at 02:35:50PM +0200, Peter Krempa wrote:
The RPC limits for cpu maps didn't allow to use libvirt on ultra big
boxes. This patch increases size of the limits to support a maximum of
4096 cpus on the host with the built-in maximum of 256 cpus per guest.
The full cpu map of
On Fri, May 24, 2013 at 11:37:04AM -0400, Peter Feiner wrote:
On Wed, May 22, 2013 at 7:31 PM, Peter Feiner pe...@gridcentric.ca wrote:
Since some security driver operations are costly, I think it's
worthwhile to reduce the scope of the security manager lock or
increase the granularity by
Found by 'git grep FREE.*cpumask' after looking at 31f1f6b.
---
src/conf/domain_conf.c | 2 +-
src/libxl/libxl_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 46d49a2..b335b58 100644
---
On 06/03/13 12:32, Daniel P. Berrange wrote:
On Tue, May 28, 2013 at 02:35:50PM +0200, Peter Krempa wrote:
The RPC limits for cpu maps didn't allow to use libvirt on ultra big
boxes. This patch increases size of the limits to support a maximum of
4096 cpus on the host with the built-in maximum
On Mon, Jun 03, 2013 at 18:32:15 +0800, Osier Yang wrote:
On 03/06/13 18:22, Jiri Denemark wrote:
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
...
This statement still uses the bool variable found:
hostdev-info-addr.drive.controller =
On 06/03/2013 07:11 PM, Ján Tomko wrote:
Found by 'git grep FREE.*cpumask' after looking at 31f1f6b.
---
src/conf/domain_conf.c | 2 +-
src/libxl/libxl_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
---
src/conf/domain_conf.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 46d49a2..21750ac
The RPC limits for cpu maps didn't allow to use libvirt on ultra big
boxes. This patch increases size of the limits to support a maximum of
16384 cpus on the host with a maximum of 4096 cpus per guest.
The full cpu map of such a system takes 8 megabytes and the map for
vcpu pinning is 2 kilobytes
On 06/02/2013 02:41 AM, Eric Blake wrote:
On 06/01/2013 01:52 AM, Martin Kletzander wrote:
For USB devices, dev-name gets formated as %.3o:%.3o even though the
numbers are decadic.
s/decadic/decimal/ here and in the subject line.
Resolves:
On 05/27/13 19:59, Peter Krempa wrote:
This patch series consists of multiple parts:
-patch 1,2: Two trivial cleanups
-patch 3: Improve and refactor vCPU data parsing
-patch 4: Add agent monitor helpers for cpu-hotplug stuff
-patch 5,6,7: Implement universal guest vCPU mapping function
-patch 8:
On 06/03/2013 02:00 PM, Guannan Ren wrote:
On 06/03/2013 07:11 PM, Ján Tomko wrote:
Found by 'git grep FREE.*cpumask' after looking at 31f1f6b.
---
src/conf/domain_conf.c | 2 +-
src/libxl/libxl_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On 05/28/13 17:33, Peter Krempa wrote:
On 05/28/13 14:01, Guannan Ren wrote:
On 05/28/2013 06:52 PM, Peter Krempa wrote:
Use the approach established in commit
69ce3ffa8d431e9810607c6e00b7cfcc481b491d to improve this function too.
---
ACK with the rest.
I've pushed this series,
On 06/03/2013 01:56 PM, Jiri Denemark wrote:
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
---
src/conf/domain_conf.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
ACK
Jan
--
libvir-list mailing
Our configure.ac says:
Not all versions of gnutls include -lgcrypt, and so we add
it explicitly for the calls to gcry_control/check_version
Thus we cannot rely on gnutls-devel to bring grcypt-devel as a
dependency.
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git
On 06/03/2013 04:23 AM, Jiri Denemark wrote:
Delay only makes sense with STP enabled.
---
tools/virsh-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 1c2e40b..2bdb215 100644
---
On Mon, Jun 03, 2013 at 14:59:10 +0200, Jiri Denemark wrote:
Our configure.ac says:
Not all versions of gnutls include -lgcrypt, and so we add
it explicitly for the calls to gcry_control/check_version
Thus we cannot rely on gnutls-devel to bring grcypt-devel as a
dependency.
---
On 06/03/13 15:06, Jiri Denemark wrote:
On Mon, Jun 03, 2013 at 14:59:10 +0200, Jiri Denemark wrote:
Our configure.ac says:
Not all versions of gnutls include -lgcrypt, and so we add
it explicitly for the calls to gcry_control/check_version
Thus we cannot rely on gnutls-devel to
On 06/03/2013 05:11 AM, Ján Tomko wrote:
Found by 'git grep FREE.*cpumask' after looking at 31f1f6b.
---
src/conf/domain_conf.c | 2 +-
src/libxl/libxl_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
On Mon, Jun 03, 2013 at 06:49:06 -0600, Eric Blake wrote:
On 06/03/2013 04:23 AM, Jiri Denemark wrote:
Delay only makes sense with STP enabled.
---
tools/virsh-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Pushed, thanks.
Jirka
--
libvir-list mailing list
On Mon, Jun 03, 2013 at 14:34:22 +0200, Jano Tomko wrote:
On 06/03/2013 01:56 PM, Jiri Denemark wrote:
Using an uninitialized value and a bool saying if the value is valid may
confuse compilators.
---
src/conf/domain_conf.c | 34 +-
1 file changed, 17
On Mon, Jun 03, 2013 at 15:09:59 +0200, Peter Krempa wrote:
On 06/03/13 15:06, Jiri Denemark wrote:
On Mon, Jun 03, 2013 at 14:59:10 +0200, Jiri Denemark wrote:
Our configure.ac says:
Not all versions of gnutls include -lgcrypt, and so we add
it explicitly for the calls to
On 05/31/2013 12:09 PM, Osier Yang wrote:
+
+static int
+virDomainHostdevAssignAddress(virDomainXMLOptionPtr xmlopt,
+ virDomainDefPtr def,
+ virDomainHostdevDefPtr hostdev)
+{
+int next_unit;
+unsigned nscsi_controllers = 0;
+
On 03/06/13 22:15, Viktor Mihajlovski wrote:
On 05/31/2013 12:09 PM, Osier Yang wrote:
+
+static int
+virDomainHostdevAssignAddress(virDomainXMLOptionPtr xmlopt,
+ virDomainDefPtr def,
+ virDomainHostdevDefPtr hostdev)
+{
+int
Check the returned value for NULL and take the cleanup path
appropriately if the API fails.
---
tools/virsh-domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 46f07ed..9ea5ffc 100644
--- a/tools/virsh-domain.c
+++
The code was horribly broken in multiple ways. This series fixes dispatching of
errors
from the API, null dereference in virsh and shadowed error messages.
Peter Krempa (3):
virsh-domain: Report errors and don't deref NULL in qemu-agent-command
qemu: Properly report guest agent errors on
The original implementation didn't follow the established pattern and
did not dispatch errors in case of failure.
---
src/libvirt-qemu.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index 747488d..e884e32 100644
---
The code for arbitrary guest agent passthrough was horribly broken since
introduciton. Fix it to correctly report errors.
---
src/qemu/qemu_agent.c | 31 +++
src/qemu/qemu_driver.c | 10 +++---
2 files changed, 22 insertions(+), 19 deletions(-)
diff --git
On 06/03/2013 04:29 PM, Osier Yang wrote:
fixed by Jirka with 4db39e3fee6
the post somehow went past me, sorry...
:$
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung:
On Mon, Jun 03, 2013 at 02:02:00PM +0200, Peter Krempa wrote:
The RPC limits for cpu maps didn't allow to use libvirt on ultra big
boxes. This patch increases size of the limits to support a maximum of
16384 cpus on the host with a maximum of 4096 cpus per guest.
The full cpu map of such a
When using logical pools, we had to trust the target-pth provided.
This parameter, however, can be completely ommited and we can get the
correct path using 'lvdisplay' command.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952973
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On 06/03/2013 04:34 PM, Peter Krempa wrote:
Check the returned value for NULL and take the cleanup path
appropriately if the API fails.
---
tools/virsh-domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 46f07ed..9ea5ffc 100644
On 06/03/13 17:03, Daniel P. Berrange wrote:
On Mon, Jun 03, 2013 at 02:02:00PM +0200, Peter Krempa wrote:
The RPC limits for cpu maps didn't allow to use libvirt on ultra big
boxes. This patch increases size of the limits to support a maximum of
16384 cpus on the host with a maximum of 4096
On 06/03/2013 04:35 PM, Peter Krempa wrote:
The code for arbitrary guest agent passthrough was horribly broken since
introduciton. Fix it to correctly report errors.
s/introduciton/introduction/
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 06/03/2013 04:35 PM, Peter Krempa wrote:
The original implementation didn't follow the established pattern and
did not dispatch errors in case of failure.
---
src/libvirt-qemu.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/libvirt-qemu.c
On 06/03/13 17:22, Martin Kletzander wrote:
On 06/03/2013 04:35 PM, Peter Krempa wrote:
The original implementation didn't follow the established pattern and
did not dispatch errors in case of failure.
---
src/libvirt-qemu.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
On 01/06/13 16:05, Martin Kletzander wrote:
On 05/29/2013 06:16 PM, Osier Yang wrote:
On 30/05/13 00:04, Martin Kletzander wrote:
On 05/29/2013 05:55 PM, Osier Yang wrote:
On 29/05/13 20:51, Martin Kletzander wrote:
On 05/29/2013 11:53 AM, Osier Yang wrote:
This patch is in relation to Bug 966449:
https://bugzilla.redhat.com/show_bug.cgi?id=966449
Below is a possible patch addressing the coredump.
Thread 1 must be calling nwfilterDriverRemoveDBusMatches(). It does so
with nwfilterDriverLock held. In the patch below I am now moving the
On 03/06/13 23:05, Martin Kletzander wrote:
When using logical pools, we had to trust the target-pth provided.
s/pth/path/,
This parameter, however, can be completely ommited and we can get the
correct path using 'lvdisplay' command.
Resolves:
On 06/03/2013 11:57 AM, Stefan Berger wrote:
This patch is in relation to Bug 966449:
https://bugzilla.redhat.com/show_bug.cgi?id=966449
Below is a possible patch addressing the coredump.
Thread 1 must be calling nwfilterDriverRemoveDBusMatches(). It does so
with nwfilterDriverLock held.
On 06/03/2013 06:03 AM, Daniel P. Berrange wrote:
On Wed, May 22, 2013 at 06:22:12PM -0400, Michael R. Hines wrote:
Hi,
We run nvidia devices inside libvirt-managed LXC containers.
It used to be that simply doing:
$ echo 'c 195:* rwm' /sys/fs/cgroup/devices/libvirt/lxc
Then, after booting
On 06/03/2013 12:29 PM, Laine Stump wrote:
On 06/03/2013 11:57 AM, Stefan Berger wrote:
This patch is in relation to Bug 966449:
https://bugzilla.redhat.com/show_bug.cgi?id=966449
Below is a possible patch addressing the coredump.
Thread 1 must be calling nwfilterDriverRemoveDBusMatches().
This patch is in _relation_ to Bug 966449:
https://bugzilla.redhat.com/show_bug.cgi?id=966449
Below is a possible patch addressing the coredump.
Thread 1 must be calling nwfilterDriverRemoveDBusMatches(). It does so with
nwfilterDriverLock held. In the patch below I am now moving the
Commit 6e73850b01ee support to set wwn for disks, but it was not
exposed to attach-disk.
---
tools/virsh-domain.c | 14 +-
tools/virsh.pod | 8
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
58 matches
Mail list logo
