Go through disks of guest, if one disk doesn't exist or its backing
chain is broken, with 'optional' startupPolicy, for CDROM and Floppy
we only discard its source path definition in xml, for disks we drop
it from disk list and free it.
---
include/libvirt/libvirt.h.in | 1 +
On 08/02/2013 12:42 AM, Eric Blake wrote:
On 08/01/2013 04:23 PM, Paolo Bonzini wrote:
Automatic devices with no command line argument have proven to be a
nightmare for libvirt as well. Although the just-released libvirt 1.1.1
now supports the on_crash element for controlling the command line
On 08/01/13 20:01, Eric Blake wrote:
On 08/01/2013 11:57 AM, John Ferlan wrote:
On 08/01/2013 10:39 AM, Peter Krempa wrote:
The shutdown test utilizes waiting for condition to exit the test. This
addition will return an error for the shutdown command to see if the
condition waiting code will
Hello.
I'm try to create L1 and L2 virt machines, but when I connect via libvirt
to L2 virt-manager says that L2 does not contain KVM.
Where I can find complete instructions and does it possible with Intel CPU?
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Aug 02, 2013 at 10:31:11AM +0200, Paolo Bonzini wrote:
On 08/02/2013 12:42 AM, Eric Blake wrote:
On 08/01/2013 04:23 PM, Paolo Bonzini wrote:
Automatic devices with no command line argument have proven to be a
nightmare for libvirt as well. Although the just-released libvirt 1.1.1
On 07/31/2013 07:41 AM, Ján Tomko wrote:
Before, missing attributes were only OK when adding entries;
modification and deletion required all of them.
Now, only deletion works with missing attributes, as long as
the host is uniquely identified.
---
src/conf/network_conf.c | 21
From: Daniel P. Berrange berra...@redhat.com
The python/tests files were recently deleted, but a reference was
left in the RPM %doc entry
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/libvirt.spec.in
On 08/01/13 19:57, John Ferlan wrote:
On 08/01/2013 10:39 AM, Peter Krempa wrote:
When allocation of memory failed the error path didn't call va_end()
causing a coverity failure.
Reported by John Ferlan.
---
tests/qemumonitortestutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 08/02/2013 06:27 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The python/tests files were recently deleted, but a reference was
left in the RPM %doc entry
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt.spec.in | 1 -
1 file changed, 1
From: Daniel P. Berrange berra...@redhat.com
The journald code would crash if a NULL was passed for the
filename / funcname in the logging code. This shouldn't
happen in general, but it is better to be save, since there
have been bugs triggering this.
Signed-off-by: Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com
The virLibConnError macros in libvirt-lxc.c and
libvirt-qemu.c were passing NULL for the filename.
This causes a crash if the logging code is configured
to use journald.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt-lxc.c | 6
On Fri, Aug 02, 2013 at 12:17:19 +0100, Daniel Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The journald code would crash if a NULL was passed for the
filename / funcname in the logging code. This shouldn't
happen in general, but it is better to be save, since there
have
On Fri, Aug 02, 2013 at 12:17:03 +0100, Daniel Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virLibConnError macros in libvirt-lxc.c and
libvirt-qemu.c were passing NULL for the filename.
This causes a crash if the logging code is configured
to use journald.
From: Daniel P. Berrange berra...@redhat.com
If upgrading from a libvirt that is older than 1.0.5, we can
not assume that vm-def-resource is non-NULL. This bogus
assumption caused libvirtd to crash
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc/lxc_process.c | 8 ++--
On 08/01/2013 08:43 PM, Jincheng Miao wrote:
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Jincheng Miao jm...@redhat.com
Cc: libvir-list@redhat.com
Sent: Friday, August 2, 2013 4:09:24 AM
Subject: Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in
On 08/02/2013 05:51 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If upgrading from a libvirt that is older than 1.0.5, we can
not assume that vm-def-resource is non-NULL. This bogus
assumption caused libvirtd to crash
Signed-off-by: Daniel P. Berrange
On 08/02/2013 05:17 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The journald code would crash if a NULL was passed for the
filename / funcname in the logging code. This shouldn't
happen in general, but it is better to be save, since there
s/save/safe/
have
Any comment?
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
On Behalf Of Seiji Aguchi
Sent: Wednesday, July 24, 2013 4:06 PM
To: libvir-list@redhat.com
Subject: [libvirt] [PATCH v3] xml: introduce startupPolicy for chardev device
On Fri, Aug 02, 2013 at 06:35:42 -0400, Laine Stump wrote:
On 08/02/2013 06:27 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The python/tests files were recently deleted, but a reference was
left in the RPM %doc entry
Signed-off-by: Daniel P. Berrange
As both /var/lib/libvirt/qemu and /var/lib/libvirt/qemu/channel/target
are owned by us, the intermediate /var/lib/libvirt/qemu/channel should
be owned by us too.
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index c457fda..79c5a2c 100644
On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote:
Hi
Please, send any topic that you are interested in covering.
* libvirt requirements for:
* Checking which CPU features are exposed/required by each CPU model
+ machine-type
* Checking which CPU features are
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
for some reason my git-sendmail keeps failing.
[sandbox PATCH 1/3] Add virt-sandbox -s inherit, to execute the
[sandbox PATCH 2/3] Add comment about LIBVIRT_DEFAULT_URI to
[sandbox PATCH 3/3] virt-sandbox-service.pod did not mention upgrade
On 08/02/2013 04:38 PM, Jiri Denemark wrote:
As both /var/lib/libvirt/qemu and /var/lib/libvirt/qemu/channel/target
are owned by us, the intermediate /var/lib/libvirt/qemu/channel should
be owned by us too.
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
THis patch fixes all of Eric's and Daniels comments.
[PATCH] virt-login-shell joins users into lxc container.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
On Fri, Aug 02, 2013 at 17:19:30 +0200, Martin Kletzander wrote:
On 08/02/2013 04:38 PM, Jiri Denemark wrote:
As both /var/lib/libvirt/qemu and /var/lib/libvirt/qemu/channel/target
are owned by us, the intermediate /var/lib/libvirt/qemu/channel should
be owned by us too.
---
On Fri, Aug 02, 2013 at 11:20:16AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
for some reason my git-sendmail keeps failing.
Here's the wrapper script I used for that
$ cat $HOME/usr/bin/git-spam
#!/bin/sh
dohelp() {
echo syntax: $0 TO-ADDR
On Fri, Aug 02, 2013 at 11:22:07AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
THis patch fixes all of Eric's and Daniels comments.
[PATCH] virt-login-shell joins users into lxc container.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.14 (GNU/Linux)
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Jincheng Miao jm...@redhat.com
Cc: libvir-list@redhat.com
Sent: Friday, August 2, 2013 9:09:23 PM
Subject: Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in
fedora 19.
No, it was caused by having a
The parser shouldn't be doing arch-specific things like adding in
implicit controllers to the config. This should instead be done in the
hypervisor's post-parse callback.
This patch removes the auto-add of a usb controller from the domain
parser, and puts it into the qemu driver's post-parse
This series adds everything needed to create and start a Q35 machine
from libvirt, with a couple of small exceptions:
1) Although the implicit pcie-root controller on q35 machinetypes is
referred to as pcie.0 by qemu, the code as it stands now still puts
pci.0 on the commandline, which means it's
* The functions qemuDomainPCIAddressReserveAddr and
qemuDomainPCIAddressReserveSlot were very similar (and should have
been more similar) and were about to get more code added to them which
would create even more duplicated code, so this patch gives
qemuDomainPCIAddressReserveAddr a
* qemuDomainPCIAddressSetNextAddr
The name of this function was confusing because 1) other functions in
the file that end in Addr are only operating on a single function of
one PCI slot, not the entire slot, while functions that do something
with the entire slot end in Slot, and 2) it didn't
This PCI controller connects to a PCI Express slot (e.g. one of the
slots provided by the pcie-root controller, aka pcie.0 on the qemu
commandline), and provides 31 *non-hot-pluggable* PCI (*not* PCIe)
slots, numbered 1-31.
Any time a machine is defined which has a pcie-root controller
(i.e. any
Previous refactoring of the guest PCI address reservation/allocation
code allowed for slot types other than basic PCI (e.g. PCI express,
non-hotpluggable slots, etc) but would not auto-allocate a slot for a
device that required any type other than a basic hot-pluggable
PCI slot.
This patch
This patch adds in special handling for a few devices that need to be
treated differently for q35 domains:
usb - there is no implicit/default usb controller for the q35
machinetype. This is done because normally the default usb controller
is added to a domain by just adding -usb to the qemu
This controller is implicit on q35 machinetypes. It provides 31 PCIe
(*not* PCI) slots as controller 0.
Currently there are no devices that can connect to pcie-root, and no
implicit pci controller on a q35 machine, so q35 is still
unusable. For a usable q35 system, we need to add a
We had been setting the device alias in the devinceinfo for pci
controllers to pci%u, but then hardcoding pci.%u when creating the
device address for other devices using that pci bus. This all worked
just fine until we encountered the built-in pcie.0 bus (the PCIe
root complex) in Q35 machines.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/02/2013 11:51 AM, Daniel P. Berrange wrote:
On Fri, Aug 02, 2013 at 11:20:16AM -0400, Daniel J Walsh wrote: for some
reason my git-sendmail keeps failing.
Here's the wrapper script I used for that
$ cat $HOME/usr/bin/git-spam #!/bin/sh
Currently the virConnectBaselineCPU API does not expose the CPU features
that are part of the CPU's model. This patch adds a new flag,
VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, that causes the API to explictly
list all features that are part of that model.
Signed-off-by: Don Dugger
The gnulib testsuite is relatively stable - the only times it is
likely to have a test change from pass to fail is on a gnulib
submodule update or a major system change (such as moving from
Fedora 18 to 19, or other large change to libc). While it is an
important test for end users on arbitrary
On 08/01/2013 07:24 AM, Peter Krempa wrote:
Excercise the arbitrary command passthrough API.
s/Excercise/Exercise/
---
tests/qemuagenttest.c | 45 +
1 file changed, 45 insertions(+)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
On 08/01/2013 07:24 AM, Peter Krempa wrote:
If VIR_TEST_EXPENSIVE is enabled, test timeout of agent commands. This
test takes 6 seconds to finish.
---
tests/qemuagenttest.c | 60
+++
1 file changed, 60 insertions(+)
In my v2 patch for
On 08/01/2013 07:24 AM, Peter Krempa wrote:
When the test-lib for shell tests was introduced it did think of
expensive tests although this option was never used.
More historically accurate: the shell script was lifted verbatim from
GNU coreutils, back in the days when Jim Meyering was actively
The logic set up in previous patch for exposing VIR_TEST_EXPENSIVE
to individual tests is as follows:
make check VIR_TEST_EXPENSIVE=0 = getenv(VIR_TEST_EXPENSIVE) sees 0
make check VIR_TEST_EXPENSIVE=1 = getenv(VIR_TEST_EXPENSIVE) sees 1
make check=
On 08/02/2013 10:55 AM, Laine Stump wrote:
The parser shouldn't be doing arch-specific things like adding in
implicit controllers to the config. This should instead be done in the
hypervisor's post-parse callback.
This patch removes the auto-add of a usb controller from the domain
parser,
On 08/02/2013 10:55 AM, Laine Stump wrote:
* qemuDomainPCIAddressSetNextAddr
The name of this function was confusing because 1) other functions in
the file that end in Addr are only operating on a single function of
one PCI slot, not the entire slot, while functions that do something
with
On 08/02/2013 10:55 AM, Laine Stump wrote:
* The functions qemuDomainPCIAddressReserveAddr and
qemuDomainPCIAddressReserveSlot were very similar (and should have
been more similar) and were about to get more code added to them which
would create even more duplicated code, so this patch gives
Hi,
I'm using OpenStack grizzly on Ubuntu 12.04 to create LXC containers.
After successful container creation and a subsequent reboot of the
hypervisor,
libvirt gets stuck in an infinite loop, spinning at 100%
Here's the backtrace:
(gdb) thread 12
[Switching to thread 12 (Thread
On 08/02/2013 09:06 PM, Michael R. Hines wrote:
Hi,
I'm using OpenStack grizzly on Ubuntu 12.04 to create LXC containers.
After successful container creation and a subsequent reboot of the
hypervisor,
libvirt gets stuck in an infinite loop, spinning at 100%
Here's the backtrace:
(gdb)
On 08/01/2013 02:30 AM, Laine Stump wrote:
On 07/31/2013 10:14 PM, Cole Robinson wrote:
Preferably what we'd do is not add any USB controller by default,
but that goes against how the QEMU driver has historically acted for
other architectures, so let's be consistent.
---
50 matches
Mail list logo
