Re: [libvirt] [PATCHV2] qemu: ask for -enable-fips when FIPS is required

2013-12-16 Thread Peter Krempa
On 12/13/13 19:51, Eric Blake wrote: On a system that is enforcing FIPS, most libraries honor the current mode by default. Qemu, on the other hand, refused to honor FIPS mode unless you add the '-enable-fips' command line option; worse, this option is not discoverable via QMP, and is only

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Laine Stump
On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to print long error messages such as the list of supported ARM machine models (more than 1700 chars). This is

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Peter Krempa
On 12/16/13 10:27, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to print long error messages such as the list of supported ARM machine

Re: [libvirt] First mail (long) question

2013-12-16 Thread Michal Privoznik
On 13.12.2013 19:21, Joaquim Barrera wrote: Hello everybody! I would like to introduce myself, as this is my first contact with libvirt mailing list (although I've been reading quite a lot of documentation). My name is Joaquim Barrera, from Barcelona, Catalonia. I am a computer engineer

Re: [libvirt] [PATCH] LXC: Change incorrect error report in lxcContainerPivotRoot

2013-12-16 Thread Michal Privoznik
On 22.11.2013 08:11, Gao feng wrote: The newroot is not mounted as tmpfs, we bind root-src to it. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 10:35:58AM +0100, Peter Krempa wrote: On 12/16/13 10:27, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to print

Re: [libvirt] [PATCH] libvirt-perl: Use correct free() in get_cpu_model_names

2013-12-16 Thread Daniel P. Berrange
On Sat, Dec 14, 2013 at 07:15:02PM +0100, Olaf Hering wrote: Make check currently fails for me due to wrong free usage in get_cpu_model_names. names is allocated by libvirt, so it should be released with just free(). t/100-connect..panic: free from wrong pool at t/100-connect.t line

Re: [libvirt] [PATCH] libvirt-perl: Use correct free() in get_cpu_model_names

2013-12-16 Thread Olaf Hering
On Mon, Dec 16, Daniel P. Berrange wrote: BTW, what platform do you see this crash on ? During make check on x86_64. Olaf -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] Add APIs for formatting systemd slice/scope names

2013-12-16 Thread Daniel P. Berrange
On Sun, Dec 15, 2013 at 07:09:19PM +0100, Richard Weinberger wrote: On Fri, Jul 26, 2013 at 5:48 PM, Daniel P. Berrange berra...@redhat.com wrote: +char *virSystemdMakeScopeName(const char *name, + const char *drivername, + const

Re: [libvirt] [PATCH] libvirt-perl: Use correct free() in get_cpu_model_names

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 11:49:36AM +0100, Olaf Hering wrote: On Mon, Dec 16, Daniel P. Berrange wrote: BTW, what platform do you see this crash on ? During make check on x86_64. But what operating system ? Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH 1/4] Add APIs for formatting systemd slice/scope names

2013-12-16 Thread Richard Weinberger
Am Montag, 16. Dezember 2013, 10:51:01 schrieb Daniel P. Berrange: On Sun, Dec 15, 2013 at 07:09:19PM +0100, Richard Weinberger wrote: On Fri, Jul 26, 2013 at 5:48 PM, Daniel P. Berrange berra...@redhat.com wrote: +char *virSystemdMakeScopeName(const char *name, +

Re: [libvirt] [PATCH] libvirt-perl: Use correct free() in get_cpu_model_names

2013-12-16 Thread Olaf Hering
On Mon, Dec 16, Daniel P. Berrange wrote: On Mon, Dec 16, 2013 at 11:49:36AM +0100, Olaf Hering wrote: On Mon, Dec 16, Daniel P. Berrange wrote: BTW, what platform do you see this crash on ? During make check on x86_64. But what operating system ? openSUSE 12.2 and older. It

[libvirt] [PATCHv2.5] specfile: fix make rpm when with_driver_modules is 1

2013-12-16 Thread Laine Stump
Commit ff76566 moved around things in the specfiles to put driver-specific files into their appropriate sub-packages (when with_driver_modules == 1), but accidentally changed things so that the deamon-driver-network and daemon-config-network files were only included in a package when

Re: [libvirt] [PATCH 1/1] storage: resize vol against real allocated size when --allocate is specified

2013-12-16 Thread Michal Privoznik
On 16.12.2013 06:00, Wang Sen wrote: Currently, vol-resize allocates more bytes against vol-capacity, but vol-capacity may be different from the real allocated size because --allocate may not be specified. e.g. [root@localhost ~]# virsh vol-list --pool tmp-pool --details name

Re: [libvirt] [PATCH] specfile: fix make rpm when with_driver_modules is 1

2013-12-16 Thread Laine Stump
On 12/14/2013 07:21 AM, Jim Fehlig wrote: Laine Stump wrote: Commit ff76566 moved around things in the specfiles to put driver-specific files into their appropriate sub-packages (when with_driver_modules == 1), but accidentally changed things so that the deamon-driver-network and

[libvirt] [PATCH] tools: Fix virsh connect man page

2013-12-16 Thread Jiri Denemark
The URI parameter is optional and xen:/// is not the default connection URI. Signed-off-by: Jiri Denemark jdene...@redhat.com --- tools/virsh.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c6a8be3..677931f 100644 ---

Re: [libvirt] [PATCHv5 3/4] net-dhcp-leases: Private implementation inside network

2013-12-16 Thread Nehal J Wani
+virReportError(VIR_ERR_INTERNAL_ERROR, + _(No leases available for network: %s), obj-def-name); Hmm, if we have started the network, but no VMs have yet booted, then will we find that the lease file does not exist ? Or is the lease file guaranteed to exist,

[libvirt] [PATCH] storage: resize vol against real allocated size

2013-12-16 Thread Michal Privoznik
From: Wang Sen wang...@linux.vnet.ibm.com Currently, 'vol-resize --allocate' allocates new space at the vol-capacity offset. But the vol-capacity is not necessarily the same as vol-allocation. For instance:. [root@localhost ~]# virsh vol-list --pool tmp-pool --details Name

Re: [libvirt] [PATCHv5 4/4] net-dhcp-leases: Add virsh support

2013-12-16 Thread Nehal J Wani
On 12/12/13, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Nov 26, 2013 at 02:36:01AM +0530, Nehal J Wani wrote: Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network

Re: [libvirt] [PATCHv5 4/4] net-dhcp-leases: Add virsh support

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 07:00:25PM +0530, Nehal J Wani wrote: On 12/12/13, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Nov 26, 2013 at 02:36:01AM +0530, Nehal J Wani wrote: Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the

Re: [libvirt] [PATCH] tools: Fix virsh connect man page

2013-12-16 Thread Laine Stump
On 12/16/2013 02:38 PM, Jiri Denemark wrote: The URI parameter is optional and xen:/// is not the default connection URI. Signed-off-by: Jiri Denemark jdene...@redhat.com --- tools/virsh.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK. diff --git a/tools/virsh.pod

Re: [libvirt] [PATCHv4 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

2013-12-16 Thread Michal Privoznik
On 25.11.2013 18:23, Manuel VIVES wrote: Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 2. The code

Re: [libvirt] [PATCH] tools: Fix virsh connect man page

2013-12-16 Thread Jiri Denemark
On Mon, Dec 16, 2013 at 15:42:09 +0200, Laine Stump wrote: On 12/16/2013 02:38 PM, Jiri Denemark wrote: The URI parameter is optional and xen:/// is not the default connection URI. Signed-off-by: Jiri Denemark jdene...@redhat.com --- tools/virsh.pod | 4 ++-- 1 file changed, 2

Re: [libvirt] [PATCH 0/2] Introduce max_anonymous_clients

2013-12-16 Thread Michal Privoznik
On 09.12.2013 15:35, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=981729 So far we can limit how many clients are connected, how many are waiting in accept() line but we could not control the count of accepted but not authenticated yet. Michal Privoznik (2):

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-16 Thread Michal Privoznik
On 11.12.2013 10:16, Michal Privoznik wrote: Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other areas like qemu driver. Michal Privoznik (2):

Re: [libvirt] [PATCH] network: only prevent forwarding of DNS requests for unqualified names

2013-12-16 Thread Laine Stump
On 12/10/2013 04:45 PM, Daniel P. Berrange wrote: So considering your example XML config above we're debating the behaviour of the following 5 possible DNS requests - myguest - myguest.example.com - notmyguest - notmyguest.example.com - google.com Originally - myguest - dnsmasq

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Cole Robinson
On 12/16/2013 04:27 AM, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to print long error messages such as the list of supported ARM machine

Re: [libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-16 Thread Laine Stump
On 12/16/2013 04:32 PM, Michal Privoznik wrote: On 11.12.2013 10:16, Michal Privoznik wrote: Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other

Re: [libvirt] [PATCH 1/2] interface: Introduce netcfInterfaceObjIsActive

2013-12-16 Thread Laine Stump
On 12/11/2013 11:16 AM, Michal Privoznik wrote: This function barely wraps ncf_if_status() and error handling code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/interface/interface_backend_netcf.c | 57 +++-- 1 file changed, 33 insertions(+), 24

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 09:50:30AM -0500, Cole Robinson wrote: On 12/16/2013 04:27 AM, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to

Re: [libvirt] [PATCH 2/2] interface: Take interface status into account when starting and destroying

2013-12-16 Thread Laine Stump
On 12/11/2013 11:16 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=956994 Currently, it is possible to start an interface that is already running: # virsh iface-start eth2 Interface eth2 started # echo $? 0 # virsh iface-start eth2 Interface eth2 started

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Michele Paolino
On 16/12/2013 16:00, Daniel P. Berrange wrote: On Mon, Dec 16, 2013 at 09:50:30AM -0500, Cole Robinson wrote: On 12/16/2013 04:27 AM, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length is

Re: [libvirt] [PATCH] storage: resize vol against real allocated size

2013-12-16 Thread Martin Kletzander
On Mon, Dec 16, 2013 at 02:29:15PM +0100, Michal Privoznik wrote: From: Wang Sen wang...@linux.vnet.ibm.com Currently, 'vol-resize --allocate' allocates new space at the vol-capacity offset. But the vol-capacity is not necessarily the same as vol-allocation. For instance:.

Re: [libvirt] [PATCH 1/1] storage: resize vol against real allocated size when --allocate is specified

2013-12-16 Thread Wang Sen
On Mon, Dec 16, 2013 at 01:18:05PM +0100, Michal Privoznik wrote: On 16.12.2013 06:00, Wang Sen wrote: Currently, vol-resize allocates more bytes against vol-capacity, but vol-capacity may be different from the real allocated size because --allocate may not be specified. e.g.

[libvirt] [PATCH] docs: fix address type for disks

2013-12-16 Thread Martin Kletzander
Disks have type='drive', not type='disk'. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0067e8f..2b8bc8f 100644 ---

[libvirt] [PATCH RFC 01/27] DO NOT APPLY UPSTREAM: Reproducer for disk snapshot crash

2013-12-16 Thread Peter Krempa
Use the following xml to create a disk-only snapshot of a VM with this patch applied to crash libvirtd: domainsnapshot disks disk name='vda' type='file' driver type='qcow2'/ source file='/tmp/path.img'/ /disk /disks /domainsnapshot --- src/qemu/qemu_driver.c | 3 +++ 1

[libvirt] [PATCH RFC 03/27] Revert DO NOT APPLY UPSTREAM: Reproducer for disk snapshot crash

2013-12-16 Thread Peter Krempa
This reverts commit 96313c60b91197578b313717db154b6bac029c9e. --- src/qemu/qemu_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ab20dfb..2140e1b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12226,9

[libvirt] [PATCH RFC 14/27] storage: LVM: Separate creating of the volume from building

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend_logical.c | 60 +-- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 15b86dc..039d962 100644 ---

[libvirt] [PATCH RFC 16/27] storage: RBD: Separate creating of the volume from building

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend_rbd.c | 41 --- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 4b6f18c..c5f0bc5 100644 --- a/src/storage/storage_backend_rbd.c +++

[libvirt] [PATCH RFC 02/27] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2013-12-16 Thread Peter Krempa
We shouldn't access the domain definition while we are in the monitor section as the domain is unlocked. Additionaly after we exit from the monitor we need to check if the VM is still alive. Not doing so resulted into crash if qemu exits while attempting to do a external VM snapshot. ---

[libvirt] [PATCH RFC 05/27] storage: gluster: Properly fix missing slashes in volume paths

2013-12-16 Thread Peter Krempa
Add a slash to the volume key so that the URI that is generated from it will be formated properly. The extra slash doesn't hurt in the 'key' attribute as we just need it to be unique. --- src/storage/storage_backend_gluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH RFC 22/27] maint: Fix messy include of libvirt_internal.h

2013-12-16 Thread Peter Krempa
The libvirt_internal.h header was included by the internal.h header. This made it painful to add new stuff to the header file that would require some more specific types. Remove inclusion by internal.h and add it to appropriate places manually. --- src/driver.h | 1 + src/internal.h

[libvirt] [PATCH RFC 21/27] storage: Improve error message when a storage backend is missing

2013-12-16 Thread Peter Krempa
Include the name of the storage backend in the error message instead of just the number. --- src/storage/storage_backend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index b08d646..19fb1f0 100644 ---

[libvirt] [PATCH RFC 07/27] snapshot: Add support for specifying snapshot disk backing type

2013-12-16 Thread Peter Krempa
Add support for specifying various types when doing snapshots. This will later allow to do snapshots on network backed volumes. Disks of type 'volume' are not supported by snapshots (yet). --- docs/schemas/domainsnapshot.rng | 76 +++-- src/conf/snapshot_conf.c

[libvirt] [PATCH RFC 12/27] storage: Support deletion of volumes on gluster pools

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend_gluster.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index 36e99e9..2ea78c7 100644 --- a/src/storage/storage_backend_gluster.c +++

[libvirt] [PATCH RFC 26/27] qemu: snapshot: Switch snapshot file deletion to the new storage API

2013-12-16 Thread Peter Krempa
Use the new storage conversion APIs to delete garbage left behind after a failed snapshot attempt using the storage driver. --- src/qemu/qemu_driver.c | 60 ++ 1 file changed, 46 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCHv2.5] specfile: fix make rpm when with_driver_modules is 1

2013-12-16 Thread Jim Fehlig
Laine Stump wrote: Commit ff76566 moved around things in the specfiles to put driver-specific files into their appropriate sub-packages (when with_driver_modules == 1), but accidentally changed things so that the deamon-driver-network and daemon-config-network files were only included in a

[libvirt] [PATCH RFC 19/27] storage: Add new argument for createVol backend API

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend.h | 2 +- src/storage/storage_backend_disk.c | 3 ++- src/storage/storage_backend_fs.c | 30 +++--- src/storage/storage_backend_logical.c | 6 -- src/storage/storage_backend_rbd.c | 3 ++-

[libvirt] [PATCH RFC 20/27] storage: gluster: Introduce dummy functions for creating a volume

2013-12-16 Thread Peter Krempa
The temporary pool code will need to initialize dummy gluster volumes which needs the createVol function of the storage backend. This patch implements it only for that purpose. When an user will get an error message that it is not implemented on an attempt to create a volume in a gluster pool. ---

[libvirt] [PATCH RFC 24/27] storage: Implement ephemeral storage APIs for local disk volumes

2013-12-16 Thread Peter Krempa
This patch implements the APIs for getting temporary storage pools for the local filesystem driver using storage_backend_fs. --- src/check-aclrules.pl| 3 + src/storage/storage_driver.c | 253 +++ 2 files changed, 256 insertions(+) diff --git

[libvirt] [PATCH RFC 27/27] qemu: snapshot: Add support for external active snapshots on gluster

2013-12-16 Thread Peter Krempa
--- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 9 src/qemu/qemu_driver.c | 113 +--- 3 files changed, 116 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a80559e..d742248

[libvirt] [PATCH RFC 23/27] storage: Add internal API to create temporary storage pools and vols

2013-12-16 Thread Peter Krempa
If a VM driver wants to access stuff provided by a storage driver the volume needs to be a part of a storage pool. As this wasn't designed in from the beginning we need a way to convert generic domain disk and snapshot disk definitions into temporary pools and volumes. This patch allows that by

[libvirt] [PATCH RFC 10/27] storage: Avoid forward declaration of virStorageVolDelete

2013-12-16 Thread Peter Krempa
Move the code around so that the forward declaration isn't needed. --- src/storage/storage_driver.c | 181 ++- 1 file changed, 91 insertions(+), 90 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index f08255e..8b1dcae

[libvirt] [PATCH RFC 13/27] storage: lvm: Avoid forward decl of virStorageBackendLogicalDeleteVol

2013-12-16 Thread Peter Krempa
Change code ordering to avoid the need for a forward declaration. --- src/storage/storage_backend_logical.c | 67 --- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c

Re: [libvirt] [PATCH] qemu: fix typo PCi = PCI

2013-12-16 Thread Peter Krempa
On 12/16/13 17:31, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Trivial. ACK. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu: fix typo PCi = PCI

2013-12-16 Thread Ján Tomko
On 12/16/2013 05:31 PM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK signature.asc Description: OpenPGP digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu: fix typo PCi = PCI

2013-12-16 Thread Martin Kletzander
On Mon, Dec 16, 2013 at 05:36:00PM +0100, Peter Krempa wrote: On 12/16/13 17:31, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Trivial. ACK. Of course this was

[libvirt] [PATCH RFC 04/27] Revert storage: fix omitted slash in gluster volume URI

2013-12-16 Thread Peter Krempa
The fix for the missing slash at the beginning of the volume URI prints to a bad variable causing a memory leak and another one if the variable will be fixed. Revert the commit instead as we can just add a slash to the key attribute. The fix also caused a regression, where the path of the volume

[libvirt] [PATCH RFC 17/27] storage: Sheepdog: Separate creating of the volume from building

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend_sheepdog.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index a97af1b..a6981ce 100644 --- a/src/storage/storage_backend_sheepdog.c

[libvirt] [PATCH RFC 09/27] storage: Add gluster pool filter and fix virsh pool listing

2013-12-16 Thread Peter Krempa
Recent adition of the gluster pool type omitted fixing the virsh and virConnectListAllStoragePool filters. A typecast of the converting function in virsh showed that also the sheepdog pool was omitted in the command parser. This patch adds gluster pool filtering support and fixes virsh to

[libvirt] [PATCH RFC 18/27] storage: Introduce internal pool support

2013-12-16 Thread Peter Krempa
To allow using the storage driver APIs to do operation on generic domain disks we will need to introduce internal storage pools that will give is a base to support this stuff even on files that weren't originally defined as a part of the pool. This patch introduces the 'internal' flag for a

[libvirt] [PATCH RFC 00/27] Native external gluster snapshots

2013-12-16 Thread Peter Krempa
This series refactors and fixes stuff needed to support snapshots on gluster-backed vm's. The series is marked as RFC as docs for some of the changes are missing and I'd like to start code review while I'll figure out the docs. Peter Krempa (27): DO NOT APPLY UPSTREAM: Reproducer for disk

[libvirt] [PATCH RFC 15/27] storage: disk: Separate creating of the volume from building

2013-12-16 Thread Peter Krempa
--- src/storage/storage_backend_disk.c | 44 ++ 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/src/storage/storage_backend_disk.c b/src/storage/storage_backend_disk.c index a7a7d0e..aa3b72f 100644 --- a/src/storage/storage_backend_disk.c +++

[libvirt] [PATCH] qemu: fix typo PCi = PCI

2013-12-16 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index bd9546e..d0fde54 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[libvirt] [PATCH RFC 11/27] storage: fs: Fix comment for virStorageBackendFileSystemDelete

2013-12-16 Thread Peter Krempa
The comment was talking about creating the pool while the function is deleting it. Fix the mismatch. --- src/storage/storage_backend_fs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index

[libvirt] [PATCH RFC 25/27] storage: gluster: Support conversion of gluster volumes to temp volumes

2013-12-16 Thread Peter Krempa
Add code to convert an regular guest volume into a ephemeral pool. --- src/storage/storage_driver.c | 153 ++- 1 file changed, 150 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 436b8e0..c0637b0

[libvirt] [PATCH RFC 08/27] snapshot: Test snapshot disk type specification

2013-12-16 Thread Peter Krempa
Amend tests to check parsing of the various new disk types that can now be specified. --- tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 18 ++ tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 18 ++ 2 files changed, 36 insertions(+) diff --git

[libvirt] [PATCH RFC 06/27] snapshot: schema: Split out snapshot disk driver definition

2013-12-16 Thread Peter Krempa
Extract the definition to a new type to allow avoiding of duplication. --- docs/schemas/domainsnapshot.rng | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/docs/schemas/domainsnapshot.rng b/docs/schemas/domainsnapshot.rng index 7b46df1..169fcfb 100644

Re: [libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-16 Thread Cole Robinson
On 12/16/2013 10:00 AM, Daniel P. Berrange wrote: On Mon, Dec 16, 2013 at 09:50:30AM -0500, Cole Robinson wrote: On 12/16/2013 04:27 AM, Laine Stump wrote: On 12/14/2013 07:15 PM, Cole Robinson wrote: On 12/11/2013 03:33 PM, Michele Paolino wrote: In libvirt, the default error message length

Re: [libvirt] [PATCHv2.5] specfile: fix make rpm when with_driver_modules is 1

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 09:30:31AM -0700, Jim Fehlig wrote: Laine Stump wrote: Commit ff76566 moved around things in the specfiles to put driver-specific files into their appropriate sub-packages (when with_driver_modules == 1), but accidentally changed things so that the

Re: [libvirt] [PATCH] docs: fix address type for disks

2013-12-16 Thread Eric Blake
On 12/16/2013 09:06 AM, Martin Kletzander wrote: Disks have type='drive', not type='disk'. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCH] examples: Resurrect domsuspend example

2013-12-16 Thread Eric Blake
On 12/13/2013 07:22 AM, Michal Privoznik wrote: This partially reverts 5eb4b04211 and 62774afb6ba8. Rewrite the domsuspend example from scratch. This time do it right. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- .gitignore | 1 + Makefile.am

[libvirt] [PATCH v2] Set the 'container_ttys' env variable for LXC consoles

2013-12-16 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Systemd specified that any /dev/pts/NNN device on which it is expected to spawn a agetty login, should be listed in the 'container_ttys' env variable. It should just contain the relative paths, eg 'pts/0' not '/dev/pts/0' and should be space separated.

Re: [libvirt] [PATCH v2] Set the 'container_ttys' env variable for LXC consoles

2013-12-16 Thread Eric Blake
On 12/16/2013 12:04 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Systemd specified that any /dev/pts/NNN device on which it is expected to spawn a agetty login, should be listed in the 'container_ttys' env variable. It should just contain the relative paths, eg

[libvirt] non trivial question

2013-12-16 Thread Vasiliy Tolstov
Hi all. I have very special task - i have some vps on kvm, that sometimes needs external support help (administration). But i can't trust external workers and need to known what files are changed. As i understand best of all - create backup before work and after. After that check it for

Re: [libvirt] [v7 1/6] add hostdev passthrough common library

2013-12-16 Thread Jim Fehlig
Chunyan Liu wrote: Extract code from qemu_hostdev.c and make it reusable for multiple drivers, meanwhile maintain a global hostdev state to solve conflict between different drivers. Signed-off-by: Chunyan Liu cy...@suse.com --- po/POTFILES.in |1 + src/Makefile.am |

Re: [libvirt] [PATCH v2] virtlockd: make re-exec more robust

2013-12-16 Thread Michael Chapman
On Wed, 11 Dec 2013, Michael Chapman wrote: - Use $XDG_RUNTIME_DIR for re-exec state file when running unprivileged. - argv[0] may not contain a full path to the binary, however it should contain something that can be looked up in the PATH. Use execvp() to do path lookup on re-exec. - As per

Re: [libvirt] [v7 4/6] add unit test for hostdev common library

2013-12-16 Thread Jim Fehlig
Chunyan Liu wrote: Add unit test for hostdev common library. Current tests are based on virpcimock, limited to pci related APIs only. The USB and SCSI logic is similar, so PCI tests do help those somewhat. USB and SCSI tests could be added later if no one objects. BTW, this should be

[libvirt] hindsight on qcow2v3 format

2013-12-16 Thread Eric Blake
I spent a couple hours today debugging a bug in an older branch of libvirt (0.10.2) - one where libvirt only knew how to parse version 2 qcow2 images. Alas, that version of libvirt can be coerced into reading the header of a random file under the assumption that it is qcow2 data, and where it

Re: [libvirt] [v7 2/6] change qemu driver to use hostdev common library

2013-12-16 Thread Jim Fehlig
Chunyan Liu wrote: Change qemu driver to use hostdev common library instead of APIs in qemu_hostdev.[ch] This patch causes 'make check' to fail qemuxml2xmltest and qemuargv2xmltest tests. Also, there's a segfault when running qemuhotplugtest. ~/upstream/libvirt/tests libtool

Re: [libvirt] [PATCH v2] Set the 'container_ttys' env variable for LXC consoles

2013-12-16 Thread Gao feng
On 12/17/2013 03:04 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Systemd specified that any /dev/pts/NNN device on which it is expected to spawn a agetty login, should be listed in the 'container_ttys' env variable. It should just contain the relative paths, eg

Re: [libvirt] [PATCH] storage: resize vol against real allocated size

2013-12-16 Thread Wang Sen
tested with dir type. [root@localhost ~]# virsh vol-create-as tmp-pool tmp-vol 1G Vol tmp-vol created [root@localhost ~]# virsh vol-list --pool tmp-pool --details Name PathType Capacity Allocation - tmp-vol

Re: [libvirt] [v7 2/6] change qemu driver to use hostdev common library

2013-12-16 Thread Chunyan Liu
2013/12/17 Jim Fehlig jfeh...@suse.com Chunyan Liu wrote: Change qemu driver to use hostdev common library instead of APIs in qemu_hostdev.[ch] This patch causes 'make check' to fail qemuxml2xmltest and qemuargv2xmltest tests. Also, there's a segfault when running qemuhotplugtest.