[libvirt] [PATCH] man: shm-merge-across-nodes is optional

2014-02-04 Thread Ján Tomko
Mark the shm-merge-across-nodes parameter of node-memory-tune command as optional in the virsh man page. --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/tools/virsh.pod b/tools/virsh.pod index 9e670da..f221475 100644 ---

Re: [libvirt] [PATCH] event: improve public API docs

2014-02-04 Thread Claudio Bley
At Tue, 31 Dec 2013 08:21:29 -0700, Eric Blake wrote: @@ -132,17 +151,20 @@ virEventAddTimeout(int timeout, * @timer: timer id to change * @timeout: time between events in milliseconds * - * Change frequency for a timer. + * Change frequency for a timer. This function + * requires

Re: [libvirt] [PATCH v3 1/2] BSD: implement nodeGetCPUStats

2014-02-04 Thread Ján Tomko
On 01/28/2014 06:49 PM, Roman Bogorodskiy wrote: Implementation obtains CPU usage information using kern.cp_time and kern.cp_times sysctl(8)s and reports CPU utilization. --- include/libvirt/libvirt.h.in | 8 src/nodeinfo.c | 104

[libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-04 Thread Ján Tomko
Rewrite the function to use an array instead of a struct, translating the field names to int via an enum. --- tools/virsh-host.c | 126 +++-- 1 file changed, 64 insertions(+), 62 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c

Re: [libvirt] [PATCH] Host cpu offline/online removes the cpus available for vms

2014-02-04 Thread Shivaprasad bhat
Hi Eric, Came across a thread where the kernel stands not to change the cpuset's behavior during the online-offline-online scenario. https://lkml.org/lkml/2012/5/4/265 Hope fixing this in Libvirt makes more sense now. Regards, Shivaprasad G Bhat On Sat, Feb 1, 2014 at 8:49 AM, Shivaprasad

Re: [libvirt] [PATCH v3 2/2] virsh: report only filled values in 'nodecpustats'

2014-02-04 Thread Ján Tomko
On 01/28/2014 06:49 PM, Roman Bogorodskiy wrote: A set of fields for CPU stats could vary on different platforms, for example, FreeBSD doesn't report 'iowait'. Make virsh print out only the fields that were actually filled. --- tools/virsh-host.c | 119

[libvirt] [PATCHv4 7/7] qemu: snapshot: Add support for external active snapshots on gluster

2014-02-04 Thread Peter Krempa
Add support for gluster backed images as sources for snapshots in the qemu driver. This will also simplify adding further network backed volumes as sources for snapshot in case qemu will support them. --- docs/formatsnapshot.html.in | 5 +- src/qemu/qemu_command.c | 2 +-

[libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-04 Thread Teto
Hi, The following patch was generated with format patch checked with syntax-check. It is really short and adds a new function virDomainFSInsert which is called when Qemu driver is requested t attach a filesystem device. Matt From f8c0612c48c06c61199693743d98c251ba4d887e Mon Sep 17 00:00:00 2001

[libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 + tools/wireshark/src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/wireshark/Makefile.am b/tools/wireshark/Makefile.am index b6fa57c..28e6ed8 100644 ---

Re: [libvirt] [PATCHv2 2/2] network: change default of forwardPlainNames to 'yes'

2014-02-04 Thread Laine Stump
On 02/03/2014 08:09 PM, Daniel P. Berrange wrote: On Fri, Jan 31, 2014 at 04:25:14PM +0200, Laine Stump wrote: The previous patch fixed forwardPlainNames so that it really is doing only what is intended, but left the default to be forwardPlainNames='no'. Discussion around the initial version

Re: [libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Christophe Fergeau
On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 + tools/wireshark/src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 01/15] Introduce virDomainSuspendFlags

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 08:37:28AM +0100, Michal Privoznik wrote: On 04.02.2014 08:05, Martin Kletzander wrote: On Mon, Feb 03, 2014 at 10:12:58AM -0700, Eric Blake wrote: On 02/03/2014 09:16 AM, Michal Privoznik wrote: So far, we have just bare virDomainSuspend() API that suspends a domain.

Re: [libvirt] [PATCH python] Fix calling of virStreamSend method

2014-02-04 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 02:32:27PM -0700, Eric Blake wrote: On 01/23/2014 07:25 AM, Daniel P. Berrange wrote: Change d40861 removed the 'len' argument from the virStreamSend C level wrapper, but forgot to remove it from the python level wrapper. Reported-by: Robie Basak

Re: [libvirt] [PATCH] event: improve public API docs

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 10:07:58AM +0100, Claudio Bley wrote: At Tue, 31 Dec 2013 08:21:29 -0700, Eric Blake wrote: @@ -132,17 +151,20 @@ virEventAddTimeout(int timeout, * @timer: timer id to change * @timeout: time between events in milliseconds * - * Change frequency for a

Re: [libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 11:14:34AM +0100, Christophe Fergeau wrote: On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 + tools/wireshark/src/Makefile.am | 2 +- 2 files

Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-04 Thread Roman Bogorodskiy
Ján Tomko wrote: Rewrite the function to use an array instead of a struct, translating the field names to int via an enum. That works as expected on FreeBSD. Thanks, Roman Bogorodskiy -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-02-04 Thread Wido den Hollander
On 01/30/2014 02:02 PM, Ján Tomko wrote: On 12/11/2013 03:47 PM, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Older versions of libvirt can work

Re: [libvirt] [PATCH 14/15] xenapiDriver: Adapt to virDomain{Resume, Suspend}Flags

2014-02-04 Thread Michal Privoznik
On 03.02.2014 18:51, Eric Blake wrote: On 02/03/2014 10:50 AM, Eric Blake wrote: On 02/03/2014 09:17 AM, Michal Privoznik wrote: So far, there are no flags to implement, so just call the corresponding function with 0 passed as @flags. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

Re: [libvirt] [PATCH v3 1/3] utils: Introduce functions for modprobe

2014-02-04 Thread Ján Tomko
On 01/30/2014 06:50 PM, John Ferlan wrote: This patch adds functions for various usages of modprobe Signed-off-by: John Ferlan jfer...@redhat.com --- configure.ac | 6 ++ src/Makefile.am | 1 + src/libvirt_private.syms | 7 ++ src/util/virkmod.c | 182

Re: [libvirt] [PATCH v3 2/3] tests: Add test for new virkmod functions

2014-02-04 Thread Ján Tomko
On 01/30/2014 06:50 PM, John Ferlan wrote: Adding tests for new virKMod{Config|Load|Unload}() API's. A test for virKModIsBlacklisted() would require some setup which cannot be assumed. Signed-off-by: John Ferlan jfer...@redhat.com --- .gitignore | 2 + tests/Makefile.am |

Re: [libvirt] [PATCH v3 3/3] Honor blacklist for modprobe command

2014-02-04 Thread Ján Tomko
On 01/30/2014 06:50 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1045124 When loading modules, libvirt does not honor the modprobe blacklist. Use the new virKModLoad() API in order to attempt load with blacklist check. Use the new virKModIsBlacklisted() API to check if

Re: [libvirt] [PATCH] Write up the project governance process

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 07:56:12AM +0100, Martin Kletzander wrote: On Mon, Feb 03, 2014 at 06:30:24PM +, Daniel P. Berrange wrote: The project has historically operated as a meritocratic consensus based community. Formally document what has always been an unwritten assumption amongst

Re: [libvirt] [PATCH] Write up the project governance process

2014-02-04 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 12:23:46PM -0700, Eric Blake wrote: On 02/03/2014 11:30 AM, Daniel P. Berrange wrote: The project has historically operated as a meritocratic consensus based community. Formally document what has always been an unwritten assumption amongst the community

[libvirt] [PATCH] qemu: be sure we're using the updated value of backend during hotplug

2014-02-04 Thread Laine Stump
Probable fix for https://bugzilla.redhat.com/show_bug.cgi?id=1056360 commit f094aaac changed qemuPrepareHostdevPCIDevices() such that it may modify the backend (vfio vs. legacy kvm) setting in the virHostdevDef. However, qemuDomainAttachHostPciDevice() (used by hotplug) copies the backend

Re: [libvirt] [PATCH] qemu: be sure we're using the updated value of backend during hotplug

2014-02-04 Thread Ján Tomko
On 02/04/2014 12:24 PM, Laine Stump wrote: Probable fix for https://bugzilla.redhat.com/show_bug.cgi?id=1056360 commit f094aaac changed qemuPrepareHostdevPCIDevices() such that it may modify the backend (vfio vs. legacy kvm) setting in the virHostdevDef. However,

[libvirt] [PATCH] The numa node numbers can be non-sequential.

2014-02-04 Thread Shivaprasad G Bhat
On PowerNV platform the numa node numbers can be non-sequential, #numactl --hardware node distances: node 0 1 16 17 0: 10 40 40 40 1: 40 10 40 40 16: 40 40 10 40 17: 40 40 40 10 The numa node number is used as index and vice versa which can cause the libvirt to crash.

Re: [libvirt] [libvirt-glib 1/5] gconfig: Fix gvir_config_domain_os_get_boot_devices() API doc

2014-02-04 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:42:54AM +0100, Christophe Fergeau wrote: The elements of the returned list are integer enum values, so they cannot be unreffed. --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libvirt] [libvirt-glib 2/5] Add various clock-related getters

2014-02-04 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:42:55AM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-clock.c | 35 ++ libvirt-gconfig/libvirt-gconfig-domain-clock.h | 3 +++ libvirt-gconfig/libvirt-gconfig-domain.c | 24 ++

Re: [libvirt] [libvirt-glib 5/5] gconfig: Fix removal of GVirConfigDomainCpu from domains

2014-02-04 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:42:58AM +0100, Christophe Fergeau wrote: A wrong precondition in gvir_config_domain_set_cpu() would reject NULL GVirConfigDomainCpus instead of accepting them. --- libvirt-gconfig/libvirt-gconfig-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libvirt] [libvirt-glib 4/5] gconfig: Fix removal of GVirConfigCapabilitiesCpu topology

2014-02-04 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:42:57AM +0100, Christophe Fergeau wrote: Calling gvir_config_capabilities_cpu_set_topology with a NULL topology would not remove the topology as expected as NULL would be rejected by this method preconditions. --- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c

Re: [libvirt] [libvirt-glib 3/5] Implement getters for GVirConfigDomainInput

2014-02-04 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:42:56AM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-input.c | 24 libvirt-gconfig/libvirt-gconfig-domain-input.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym| 3 +++ 3 files changed, 29

Re: [libvirt] [PATCH] The numa node numbers can be non-sequential.

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 05:57:22AM -0500, Shivaprasad G Bhat wrote: On PowerNV platform the numa node numbers can be non-sequential, #numactl --hardware node distances: node 0 1 16 17 0: 10 40 40 40 1: 40 10 40 40 16: 40 40 10 40 17: 40 40 40 10 The numa node

Re: [libvirt] [PATCH v2 01/18] Improve virConf parse to handle LXC config format

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:49AM +0100, Cédric Bosdonnat wrote: virConf now honours a VIR_CONF_FLAG_LXC_FORMAT flag to handle LXC configuration files. The differences are that property names can contain '.' character and values are all strings without any bounding quotes. Provide a new

Re: [libvirt] [PATCH v2 02/18] LXC driver: started implementing connectDomainXMLFromNative

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:50AM +0100, Cédric Bosdonnat wrote: This function aims at converting LXC configuration into a libvirt domain XML description to help users migrate from LXC to libvirt. Here is an example of how the lxc configuration works: virsh -c lxc:/// domxml-from-native lxc

Re: [libvirt] [PATCH v2 03/18] LXC from native: import rootfs

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:51AM +0100, Cédric Bosdonnat wrote: LXC rootfs can be either a directory or a block device or an image file. The first two types have been implemented, but the image file is still to be done since LXC auto-guesses the file format at mount time and the LXC driver

Re: [libvirt] [PATCH v2 04/18] LXC from native: migrate fstab and lxc.mount.entry

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:52AM +0100, Cédric Bosdonnat wrote: Tmpfs relative size and default 50% size values aren't supported as we have no idea of the available memory at the conversion time. --- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_container.h

Re: [libvirt] [PATCH v2 05/18] LXC from native: implement no network conversion

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:53AM +0100, Cédric Bosdonnat wrote: If no network configuration is provided, LXC only provides the loopback interface. To match this, we need to use the privnet feature. LXC will also define a 'none' network type in its 1.0.0 version that fits libvirt LXC driver's

Re: [libvirt] [PATCH v2 06/18] LXC from native: migrate veth network configuration

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:54AM +0100, Cédric Bosdonnat wrote: Some of the LXC configuration properties aren't migrated since they would only cause problems in libvirt-lxc: * lxc.network.ipv[46]: LXC driver doesn't setup IP address of guests, see rhbz#1059624 * lxc.network.name,

Re: [libvirt] [PATCH v2 07/18] LXC from native: convert phys network types to net hostdev devices

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:55AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 44 +++--- .../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 6 +++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 26 +

Re: [libvirt] [PATCH v2 08/18] LXC from native: convert lxc.tty to console devices

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:56AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 44 tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 6 2 files changed, 50 insertions(+) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH] qemu: introduce spiceport serial backend

2014-02-04 Thread Christophe Fergeau
Hey, Not a full review yet as I have only been looking at the doc so far. On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: This applies on top of qemu: minor cleanups:

Re: [libvirt] [PATCH v2 09/18] LXC from native: convert macvlan network configuration

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:57AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 47 +- .../lxcconf2xml-macvlannetwork.config | 13 ++ .../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 26

Re: [libvirt] [PATCH v2 10/18] LXC from native: convert lxc.id_map into idmap

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:58AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 43 ++ tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 5 +++ tests/lxcconf2xmldata/lxcconf2xml-idmap.xml| 28 +

Re: [libvirt] [PATCH v2 11/18] LXC from native: migrate memory tuning

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:55:59AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 40 tests/lxcconf2xmldata/lxcconf2xml-memtune.config | 10 ++ tests/lxcconf2xmldata/lxcconf2xml-memtune.xml| 29 +

Re: [libvirt] [PATCH v2 13/18] LXC from native: map lxc.cgroup.cpuset.*

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:01AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 30 ++ .../lxcconf2xmldata/lxcconf2xml-cpusettune.config | 6 + tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 27 +++

Re: [libvirt] [PATCH v2 12/18] LXC from native: map lxc.cgroup.cpu.*

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:00AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 34 tests/lxcconf2xmldata/lxcconf2xml-cputune.config | 7 + tests/lxcconf2xmldata/lxcconf2xml-cputune.xml| 29

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-04 Thread Michal Privoznik
On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM libvirt: you are welcome to join the QEMU umbrella organization like last year. I've updated wiki with a libvirt idea. But I can sense more to come later as I have some time to think about it :) Michal -- libvir-list mailing list

Re: [libvirt] [PATCH v2 16/18] LXC from native: map block filesystems

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:04AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 4 1 file changed, 4 insertions(+) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

Re: [libvirt] [PATCH v2 14/18] LXC from native: add lxc.cgroup.blkio.* mapping

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:02AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 63 ++ tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 7 +++ tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 35

Re: [libvirt] [PATCH v2 15/18] LXC from native: map lxc.arch to /domain/os/type@arch

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:03AM +0100, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c| 9 + tests/lxcconf2xmldata/lxcconf2xml-simple.config | 1 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 +- 3 files changed, 11 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH v2 17/18] LXC from native: map vlan network type

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:05AM +0100, Cédric Bosdonnat wrote: The problem with VLAN is that the user still has to manually create the vlan interface on the host. Then the generated configuration will use it as a nerwork hostdev device. So the generated configurations of the following two

Re: [libvirt] [PATCH v2 18/18] LXC: added some doc on domxml-from-native with mention of limitations

2014-02-04 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 10:56:06AM +0100, Cédric Bosdonnat wrote: --- docs/drvlxc.html.in | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCH v2 02/18] LXC driver: started implementing connectDomainXMLFromNative

2014-02-04 Thread Cedric Bosdonnat
Hi Daniel, On Tue, 2014-02-04 at 12:17 +, Daniel P. Berrange wrote: On Thu, Jan 30, 2014 at 10:55:50AM +0100, Cédric Bosdonnat wrote: This function aims at converting LXC configuration into a libvirt domain XML description to help users migrate from LXC to libvirt. Here is an

Re: [libvirt] [libvirt-glib 1/5] gconfig: Fix gvir_config_domain_os_get_boot_devices() API doc

2014-02-04 Thread Christophe Fergeau
On Tue, Feb 04, 2014 at 12:03:21PM +, Daniel P. Berrange wrote: On Tue, Jan 21, 2014 at 11:42:54AM +0100, Christophe Fergeau wrote: The elements of the returned list are integer enum values, so they cannot be unreffed. --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 3 +-- 1 file

[libvirt] [libvirt-glib 6/5] gconfig: Adjust transfer annotation for gvir_config_domain_os_get_boot_devices()

2014-02-04 Thread Christophe Fergeau
(transfer container) is more correct than (transfer full) for GList of scalar values, it's not clear whether it's an issue or not, but better be safe than sorry. --- I'll push this patch too in order to be fully sure that this will not be an issue, someone on #introspection told me: teuf: if you

Re: [libvirt] [PATCH v2 14/18] LXC from native: add lxc.cgroup.blkio.* mapping

2014-02-04 Thread Cedric Bosdonnat
On Tue, 2014-02-04 at 12:39 +, Daniel P. Berrange wrote: diff --git a/tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config b/tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config new file mode 100644 index 000..8083c71 --- /dev/null +++

Re: [libvirt] [PATCH] qemu: introduce spiceport serial backend

2014-02-04 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 01:34:38PM +0100, Christophe Fergeau wrote: Hey, Not a full review yet as I have only been looking at the doc so far. On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: This

Re: [libvirt] [PATCH python] Fix calling of virStreamSend method

2014-02-04 Thread Eric Blake
On 02/04/2014 03:21 AM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 02:32:27PM -0700, Eric Blake wrote: On 01/23/2014 07:25 AM, Daniel P. Berrange wrote: Change d40861 removed the 'len' argument from the virStreamSend C level wrapper, but forgot to remove it from the python level

[libvirt] [PATCH] Skip the 'copyright-check' on -maint branches

2014-02-04 Thread Daniel P. Berrange
The maint branches will often have out of date copyright headers so we must skip the 'sc_copyright_check' rule there. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk | 11 +++ 1 file changed, 11 insertions(+) Perhaps there's a better way to detect -maint branches than

Re: [libvirt] [PATCH v3 1/3] utils: Introduce functions for modprobe

2014-02-04 Thread John Ferlan
On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: This patch adds functions for various usages of modprobe Signed-off-by: John Ferlan jfer...@redhat.com --- configure.ac | 6 ++ src/Makefile.am | 1 + src/libvirt_private.syms |

Re: [libvirt] [PATCH v1 2/2] network: Introduce start and shutdown hooks

2014-02-04 Thread Michal Privoznik
On 03.02.2014 15:21, Laine Stump wrote: On 02/03/2014 01:40 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 12:36:32PM +0100, Michal Privoznik wrote: On 31.01.2014 17:43, Michal Privoznik wrote: There might be some use cases, where user wants to prepare the host or its environment prior

Re: [libvirt] [PATCH v3 2/3] tests: Add test for new virkmod functions

2014-02-04 Thread John Ferlan
On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: Adding tests for new virKMod{Config|Load|Unload}() API's. A test for virKModIsBlacklisted() would require some setup which cannot be assumed. Signed-off-by: John Ferlan jfer...@redhat.com --- .gitignore

Re: [libvirt] [PATCH v3 2/3] tests: Add test for new virkmod functions

2014-02-04 Thread Ján Tomko
On 02/04/2014 03:01 PM, John Ferlan wrote: On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: Adding tests for new virKMod{Config|Load|Unload}() API's. A test for virKModIsBlacklisted() would require some setup which cannot be assumed. Signed-off-by:

Re: [libvirt] [PATCH v3 2/3] tests: Add test for new virkmod functions

2014-02-04 Thread Eric Blake
On 02/04/2014 07:07 AM, Ján Tomko wrote: /docs/todo.html.in +/examples/domain-events/ /examples/object-events/event-test /examples/dominfo/info1 /examples/domsuspend/suspend Unrelated change. OK - I'll send this separately (trivially). Actually, domain-events has been renamed to

Re: [libvirt] [PATCH v3 3/3] Honor blacklist for modprobe command

2014-02-04 Thread John Ferlan
On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1045124 When loading modules, libvirt does not honor the modprobe blacklist. Use the new virKModLoad() API in order to attempt load with blacklist check. Use the

Re: [libvirt] [RFC PATCH v2 3/3] qemu: memory pre-pinning support for RDMA migration

2014-02-04 Thread Jiri Denemark
On Mon, Jan 13, 2014 at 14:28:12 +0800, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com RDMA Live migration requires registering memory with the hardware, Hmm, I forgot to ask when I was reviewing the previous patch but does any of this RDMA migration functionality

Re: [libvirt] [RFC PATCH] libvirt support to force convergence of live guest migration

2014-02-04 Thread Jiri Denemark
On Wed, Jan 29, 2014 at 08:34:58 -0800, Chegu Vinod wrote: On 1/29/2014 8:27 AM, Jim Fehlig wrote: Chegu Vinod wrote: Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent

Re: [libvirt] [PATCH] qemu: hyperv: Add enlightenment support for TSC timekeeping

2014-02-04 Thread Peter Krempa
[adding Vadim as he implemented the qemu/kvm parts] On 01/22/14 11:35, Daniel P. Berrange wrote: On Tue, Jan 21, 2014 at 06:54:34PM +0100, Peter Krempa wrote: The hyperv enlightenment features allow to ease guests timekeeping by allowing to store offset from the TSC as a reference. Add the

Re: [libvirt] [PATCH] qemu: hyperv: Add enlightenment support for TSC timekeeping

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 04:04:06PM +0100, Peter Krempa wrote: [adding Vadim as he implemented the qemu/kvm parts] On 01/22/14 11:35, Daniel P. Berrange wrote: On Tue, Jan 21, 2014 at 06:54:34PM +0100, Peter Krempa wrote: The hyperv enlightenment features allow to ease guests timekeeping by

Re: [libvirt] [PATCH v3 3/3] Honor blacklist for modprobe command

2014-02-04 Thread Ján Tomko
On 02/04/2014 03:29 PM, John Ferlan wrote: On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: +VIR_FREE(errbuf); +goto cleanup; } goto recheck; } +/* If we know failure was because of blacklist,

Re: [libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Eric Blake
On 02/04/2014 03:32 AM, Martin Kletzander wrote: On Tue, Feb 04, 2014 at 11:14:34AM +0100, Christophe Fergeau wrote: On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 +

Re: [libvirt] [PATCH] event: improve public API docs

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 04:32:10PM +0100, Claudio Bley wrote: At Tue, 4 Feb 2014 10:23:22 +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 10:07:58AM +0100, Claudio Bley wrote: At Tue, 31 Dec 2013 08:21:29 -0700, Eric Blake wrote: @@ -132,17 +151,20 @@

Re: [libvirt] [PATCH] event: improve public API docs

2014-02-04 Thread Claudio Bley
At Tue, 4 Feb 2014 10:23:22 +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 10:07:58AM +0100, Claudio Bley wrote: At Tue, 31 Dec 2013 08:21:29 -0700, Eric Blake wrote: @@ -132,17 +151,20 @@ virEventAddTimeout(int timeout, * @timer: timer id to change * @timeout:

Re: [libvirt] [PATCH v3 3/3] Honor blacklist for modprobe command

2014-02-04 Thread John Ferlan
On 02/04/2014 10:10 AM, Ján Tomko wrote: On 02/04/2014 03:29 PM, John Ferlan wrote: On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: +VIR_FREE(errbuf); +goto cleanup; } goto recheck; } +/* If

Re: [libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 08:29:53AM -0700, Eric Blake wrote: On 02/04/2014 03:32 AM, Martin Kletzander wrote: On Tue, Feb 04, 2014 at 11:14:34AM +0100, Christophe Fergeau wrote: On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH v3 3/3] Honor blacklist for modprobe command

2014-02-04 Thread Ján Tomko
On 02/04/2014 04:29 PM, John Ferlan wrote: On 02/04/2014 10:10 AM, Ján Tomko wrote: On 02/04/2014 03:29 PM, John Ferlan wrote: On 02/04/2014 06:06 AM, Ján Tomko wrote: On 01/30/2014 06:50 PM, John Ferlan wrote: +VIR_FREE(errbuf); +goto cleanup; }

[libvirt] [PATCH 0/2] Taint domains altered by hook scripts

2014-02-04 Thread Michal Privoznik
Currently, we only allow XML changing in qemu driver and nowhere else. Michal Privoznik (2): virDomainTaintFlags: Introduce VIR_DOMAIN_TAINT_HOOK qemu: Implement VIR_DOMAIN_TAINT_HOOK src/conf/domain_conf.c| 3 ++- src/conf/domain_conf.h| 1 + src/qemu/qemu_domain.c| 4

[libvirt] [PATCH 2/2] qemu: Implement VIR_DOMAIN_TAINT_HOOK

2014-02-04 Thread Michal Privoznik
Currently, there's just one place where we care if hook script is changing the domain XML: migration hook for incoming migration. In all other places where a hook script is executed, we don't read the XML back from the script. Anyway, the hook script can alter domain XML and hence we should taint

[libvirt] [PATCH 1/2] virDomainTaintFlags: Introduce VIR_DOMAIN_TAINT_HOOK

2014-02-04 Thread Michal Privoznik
This new flag is to be used for tainting domains which XML definition was altered at runtime by a hook script. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v3 0/3] Honor blacklist for modprobe command

2014-02-04 Thread John Ferlan
On 01/30/2014 12:50 PM, John Ferlan wrote: Rework changes from code review v2 here: http://www.redhat.com/archives/libvir-list/2014-January/msg01473.html v3 changes over v2: * Changed configure.ac for RMMOD definition * Use virKMod*() instead of virModprobe*() for function names * Adjust

[libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
Add an element named strict-hugepages to control whether to refuse guest initialization in case hugepage allocation cannot be performed. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index ff50214..e79f5e6 100644 ---

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: Add an element named strict-hugepages to control whether to refuse guest initialization in case hugepage allocation cannot be performed. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: Add an element named strict-hugepages to control whether to refuse guest initialization in case hugepage allocation cannot be performed.

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: Add an element named strict-hugepages to control whether to refuse guest initialization in case hugepage allocation cannot be performed.

Re: [libvirt] 1.2.0 segfault on Centos 6

2014-02-04 Thread Franky Van Liedekerke
On 2014-02-04 17:02, Franky Van Liedekerke wrote: Hi, using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to occasional segmentation faults (see below). Sometimes it runs for 5 minutes, sometimes for an hour, but after that the result is always the same: segfault after some weird

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: Add an element named strict-hugepages to control whether to refuse guest

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 12:18:34PM -0500, Marcelo Tosatti wrote: On Tue, Feb 04, 2014 at 05:10:13PM +, Daniel P. Berrange wrote: Because there is no guarantee with -mem-prealloc. For instance, if the hugepage path is not actually hugetlbfs backed, QEMU falls back to malloc().

[libvirt] [PATCH] Fix minor typo in governance doc

2014-02-04 Thread Justin Clift
--- docs/governance.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/governance.html.in b/docs/governance.html.in index e649f08..2f04281 100644 --- a/docs/governance.html.in +++ b/docs/governance.html.in @@ -24,7 +24,7 @@ project community taken as a whole,

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
You're OK with StrictHugePageSize=N element ? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] 1.2.0 segfault on Centos 6

2014-02-04 Thread Eric Blake
On 02/04/2014 09:02 AM, Franky Van Liedekerke wrote: Hi, using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to occasional segmentation faults (see below). Sometimes it runs for 5 minutes, sometimes for an hour, but after that the result is always the same: segfault after some weird

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:10:13PM +, Daniel P. Berrange wrote: Because there is no guarantee with -mem-prealloc. For instance, if the hugepage path is not actually hugetlbfs backed, QEMU falls back to malloc(). Well if you can't fix -mem-prealloc to properly report errors for reasons

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: You're OK with StrictHugePageSize=N element ? I'm not entirely sure what that would do ? Is that for when people want to have a specific size of hugepages ? If so, then I guess we might actually need some kind of granularity

Re: [libvirt] [PATCH] Fix minor typo in governance doc

2014-02-04 Thread Eric Blake
On 02/04/2014 10:19 AM, Justin Clift wrote: --- docs/governance.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/governance.html.in b/docs/governance.html.in index e649f08..2f04281 100644 --- a/docs/governance.html.in +++ b/docs/governance.html.in @@ -24,7

Re: [libvirt] [PATCH] Fix minor typo in governance doc

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 10:21:50AM -0700, Eric Blake wrote: On 02/04/2014 10:19 AM, Justin Clift wrote: --- docs/governance.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/governance.html.in b/docs/governance.html.in index e649f08..2f04281 100644

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:26:31PM +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: You're OK with StrictHugePageSize=N element ? I'm not entirely sure what that would do ? Is that for when people want to have a specific size of hugepages

Re: [libvirt] 1.2.0 segfault on Centos 6

2014-02-04 Thread Eric Blake
On 02/04/2014 11:28 AM, Franky Van Liedekerke wrote: Are you in a position to bisect which libvirt patch introduced the problem? It looks like our first use of qom-list was in 1.1.1, with commit d76a897. Errr ... I don't really know what you mean with bisect ... but tell me what to do,

Re: [libvirt] 1.2.0 segfault on Centos 6

2014-02-04 Thread Franky Van Liedekerke
On Tue, 04 Feb 2014 10:19:56 -0700 Eric Blake ebl...@redhat.com wrote: On 02/04/2014 09:02 AM, Franky Van Liedekerke wrote: Hi, using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to occasional segmentation faults (see below). Sometimes it runs for 5 minutes, sometimes for an

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:26:31PM +, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: You're OK with StrictHugePageSize=N element ? I'm not entirely sure what that would do ? Is that for when people want to have a specific size of hugepages

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Eric Blake
On 02/04/2014 02:57 PM, Marcelo Tosatti wrote: So perhaps we do need some policy attribute on the hugepages/ element to indicate desired behaviour here. What about the following new element under hugepages/ ? enforce_hugepage_size=integer Which feels a bit redundant (we're already

[libvirt] [PATCH] rpm: create libvirt-wireshark sub-package

2014-02-04 Thread Eric Blake
On Fedora 20, with wireshark-devel installed, 'make rpm' failed due to installed but unpackaged files related to wireshark. As F20 is already released without wireshark, I chose to add a new sub-package that is enabled only for F21 and later. Furthermore, all existing wireshark plugins belong to

  1   2   >