[libvirt] systemd, LXC and user namespaces

2014-02-06 Thread Richard Weinberger
Hi! I'm trying to get rid of a hack to make systemd (kind of) work in Linux containers on libvirt. The hack can be found in the first mail of [0]. systemd folks told me that systemd needs a name=systemd cgroup [0], which makes perfectly sense to me. I found that libvirt does this already, but

Re: [libvirt] [PATCH 2/2] qemu: blockjob: Print correct file name in error message

2014-02-06 Thread Peter Krempa
On 02/05/14 19:41, Eric Blake wrote: On 02/05/2014 10:44 AM, Peter Krempa wrote: When attempting a blockcommit from the top layer, the base argument passed is NULL. This will be dereferenced when attempting a commit with an empty image chain. Output the real volume path instead: virsh

Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-06 Thread Jiri Denemark
On Wed, Feb 05, 2014 at 15:12:03 -0700, Eric Blake wrote: On 02/05/2014 07:58 AM, John Ferlan wrote: On 02/05/2014 08:19 AM, Jiri Denemark wrote: If virDomainMemoryStats was run on a domain with virtio balloon driver running on an old qemu which supports QMP but does not support

Re: [libvirt] [PATCH 2/2] qemuxml2argvtest: Test localtime clock basis

2014-02-06 Thread Roman Bogorodskiy
Eric Blake wrote: On 02/05/2014 07:32 AM, Michal Privoznik wrote: When trying to introduce a test for previous patch, I've noticed that the command line is constructed using current time. This won't work in our test suite (unless you guys wants to set a specific time prior to each test

Re: [libvirt] [PATCH 2/2] qemuxml2argvtest: Test localtime clock basis

2014-02-06 Thread Daniel P. Berrange
On Wed, Feb 05, 2014 at 03:26:23PM -0700, Eric Blake wrote: On 02/05/2014 07:32 AM, Michal Privoznik wrote: When trying to introduce a test for previous patch, I've noticed that the command line is constructed using current time. This won't work in our test suite (unless you guys wants to

Re: [libvirt] [PATCH v3] bhyve: add a basic driver

2014-02-06 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 12:07:10AM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: +virCommandAddArg(cmd, -H); /* vmexit from guest on hlt */ +virCommandAddArg(cmd, -P); /* vmexit from guest on pause */ What's the functional effect of having these set, or not ?

Re: [libvirt] systemd, LXC and user namespaces

2014-02-06 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 10:36:09AM +0100, Richard Weinberger wrote: Hi! I'm trying to get rid of a hack to make systemd (kind of) work in Linux containers on libvirt. The hack can be found in the first mail of [0]. systemd folks told me that systemd needs a name=systemd cgroup [0], which

Re: [libvirt] [PATCHv3 09/10] Fix misspelled cpuacct.usage_percpu in cgroup mock.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- Turned out during test writing, when this was actually used the first time. tests/vircgroupmock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c index d772652..84bb1b0 100644

Re: [libvirt] [PATCHv3 05/10] Implement lxcDomainBlockStats* for lxc driver

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: Adds lxcDomainBlockStatsFlags and lxcDomainBlockStats functions. --- Notes v3: - merged patch, both api methods now added in one - addressed comments from v2 review - check for cgroup controllers actually being mounted src/lxc/lxc_driver.c |

Re: [libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear

Re: [libvirt] [PATCHv3 08/10] Add unit test for virCgroupGetMemoryUsage.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- tests/vircgrouptest.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index a29cdd2..6826442 100644 --- a/tests/vircgrouptest.c +++ b/tests/vircgrouptest.c

Re: [libvirt] [PATCHv3 10/10] Add unit test for virCgroupGetPercpuStats.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- tests/vircgrouptest.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index 6826442..dfcb0aa 100644 --- a/tests/vircgrouptest.c +++

Re: [libvirt] [PATCHv3 07/10] Add unit test for virCgroupGetBlkioIo*Serviced

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- Adds another dummy device to push the cgroup parsing code a bit harder tests/vircgroupmock.c | 107 +++- tests/vircgrouptest.c | 133 ++ 2 files

Re: [libvirt] [PATCHv3 06/10] Widening API change - accept empty path for virDomainBlockStats

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: And provide domain summary stat in that case, for lxc backend. Use case is a container inheriting all devices from the host, e.g. when doing application containerization. --- src/libvirt.c| 8 ++-- tools/virsh-domain-monitor.c

Re: [libvirt] [PATCHv3 04/10] Implement domainGetCPUStats for lxc driver.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- Notes v3: - moved most of the code out to virCgroupGetPercpuStats, for better testability. - addressed comments from v2 review src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 51

Re: [libvirt] [PATCHv3 02/10] Implement domainMemoryStats API slot for LXC driver.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: --- src/lxc/lxc_driver.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 138c706..02b5cc3 100644 --- a/src/lxc/lxc_driver.c +++

Re: [libvirt] [PATCHv3 01/10] Add util virCgroupGetBlkioIo*Serviced methods.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: This reads blkio stats from blkio.throttle.io_service_bytes and blkio.throttle.io_serviced. --- Notes v3: - beyond the minor nits from the last review, virCgroupGetBlkioIoDeviceServiced was rather busted wrt. string ptr p. Now fixed, and

Re: [libvirt] [PATCHv3 03/10] Make qemuGetDomainTotalCPUStats a virCgroup function.

2014-02-06 Thread Michal Privoznik
On 03.02.2014 18:44, Thorsten Behrens wrote: To reuse this from other drivers, like lxc. --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 54 ++-- src/util/vircgroup.c | 53 +++

[libvirt] [PATCH v1.1.0-maint] Push nwfilter update locking up to top level

2014-02-06 Thread Laine Stump
From: Daniel P. Berrange berra...@redhat.com (see notes about conflict resolution at the end. I'm not sending the other 5 patches required, since they were all simple cherry-picks of: 4f2094346d98f4ed6a2de115d204c166cc563496 b77b16ce4166dcc87963ae5d279b77b162ddbb55

Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-06 Thread Michal Privoznik
On 04.02.2014 10:22, Ján Tomko wrote: Rewrite the function to use an array instead of a struct, translating the field names to int via an enum. --- tools/virsh-host.c | 126 +++-- 1 file changed, 64 insertions(+), 62 deletions(-) ACK, I like

Re: [libvirt] [PATCH v1.1.0-maint] Push nwfilter update locking up to top level

2014-02-06 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 02:11:26PM +0200, Laine Stump wrote: From: Daniel P. Berrange berra...@redhat.com (see notes about conflict resolution at the end. I'm not sending the other 5 patches required, since they were all simple cherry-picks of: 4f2094346d98f4ed6a2de115d204c166cc563496

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-06 Thread Stefan Hajnoczi
On Tue, Feb 4, 2014 at 1:38 PM, Michal Privoznik mpriv...@redhat.com wrote: On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM libvirt: you are welcome to join the QEMU umbrella organization like last year. I've updated wiki with a libvirt idea. But I can sense more to come later as I have

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-06 Thread Giorgio Zoppi
Hi all, i offer part of my free time as mentor. Cheers, Giorgio 2014-02-06 13:27 GMT+01:00 Stefan Hajnoczi stefa...@gmail.com: On Tue, Feb 4, 2014 at 1:38 PM, Michal Privoznik mpriv...@redhat.com wrote: On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM libvirt: you are welcome to join

Re: [libvirt] [PATCH v3] bhyve: add a basic driver

2014-02-06 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Thu, Feb 06, 2014 at 12:07:10AM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: +virCommandAddArg(cmd, -H); /* vmexit from guest on hlt */ +virCommandAddArg(cmd, -P); /* vmexit from guest on pause */ What's the functional

Re: [libvirt] [PATCH 3/4] libxl: handle domain shutdown events in a thread

2014-02-06 Thread Michal Privoznik
On 05.02.2014 18:39, Jim Fehlig wrote: Handling the domain shutdown event within the event handler seems a bit unfair to libxl's event machinery. Domain shutdown could take considerable time. E.g. if the shutdown reason is reboot, the domain must be reaped and then started again. Spawn a

Re: [libvirt] [PATCH 0/4] libxl: fixes related to concurrency improvements

2014-02-06 Thread Michal Privoznik
On 05.02.2014 18:39, Jim Fehlig wrote: While reviving old patches to add job support to the libxl driver, testing revealed some problems that were difficult to encounter in the current, more serialized processing approach used in the driver. The first patch is a bug fix, plugging leaks of

Re: [libvirt] [PATCH v3 20/21] lxc: honor link state=up for veth interfaces

2014-02-06 Thread Cedric Bosdonnat
On Wed, 2014-02-05 at 15:10 +0100, Cédric Bosdonnat wrote: direct interfaces are already brought up when creating them. Just ignore (and drop) this patch, veth interfaces are already up when starting the container... even thought I couldn't ifdown it ;) -- Cedric --- src/lxc/lxc_process.c |

Re: [libvirt] [PATCH v3 1/2] BSD: implement nodeGetCPUStats

2014-02-06 Thread Ján Tomko
On 02/04/2014 10:24 AM, Ján Tomko wrote: On 01/28/2014 06:49 PM, Roman Bogorodskiy wrote: Implementation obtains CPU usage information using kern.cp_time and kern.cp_times sysctl(8)s and reports CPU utilization. --- include/libvirt/libvirt.h.in | 8 src/nodeinfo.c |

Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-06 Thread Ján Tomko
On 02/06/2014 01:14 PM, Michal Privoznik wrote: On 04.02.2014 10:22, Ján Tomko wrote: Rewrite the function to use an array instead of a struct, translating the field names to int via an enum. --- tools/virsh-host.c | 126 +++-- 1 file

[libvirt] [PATCH 2/2] qemuxml2argvtest: Set timezone

2014-02-06 Thread Michal Privoznik
With my recent work on the test, both time() and localtime() are used. While mocking the former one, we get predictible result for UTC. But since the latter function uses timezone to get local time, the result of localtime() is not so predictive. Therefore, we must set the TZ variable at the

[libvirt] [PATCH 1/2] qemuxml2argvmock: Mock time() on non-linux platforms too

2014-02-06 Thread Michal Privoznik
The qemuxml2argvtest is run on more platforms than linux. For instance FreeBSD. On these platforms we are, however, not mocking time() which results in current time being fetched from system and hence tests number 32 and 33 failing. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

Re: [libvirt] [PATCH 2/2] qemuxml2argvtest: Set timezone

2014-02-06 Thread Eric Blake
On 02/06/2014 06:33 AM, Michal Privoznik wrote: With my recent work on the test, both time() and localtime() are used. While mocking the former one, we get predictible result for UTC. But s/predictible/predictable/ since the latter function uses timezone to get local time, the result of

Re: [libvirt] [PATCH 1/2] qemuxml2argvmock: Mock time() on non-linux platforms too

2014-02-06 Thread Roman Bogorodskiy
Michal Privoznik wrote: The qemuxml2argvtest is run on more platforms than linux. For instance FreeBSD. On these platforms we are, however, not mocking time() which results in current time being fetched from system and hence tests number 32 and 33 failing. This change works on FreeBSD and

[libvirt] [PATCH v2] qemuxml2argvtest: Set timezone

2014-02-06 Thread Michal Privoznik
With my recent work on the test, both time() and localtime() are used. While mocking the former one, we get predictable result for UTC. But since the latter function uses timezone to get local time, the result of localtime() is not so predictive. Therefore, we must set the TZ variable at the

[libvirt] Enabling x2apic by default in KvM (was Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models)

2014-02-06 Thread Eduardo Habkost
On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: Am 03.02.2014 20:01, schrieb Eduardo Habkost: On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: Il 21/01/2014 16:51, Andreas Färber ha scritto: We already do that for other bits (e.g. XSAVE/OSXSAVE), Please point

Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-06 Thread Teto
These 2 patches should address your points. I've also used VIR_APPEND_ELEMENT in another function (1st patch). At your service should you have any other comment. Matthieu Coudron 2014-02-05 Michal Privoznik mpriv...@redhat.com: On 04.02.2014 10:37, Teto wrote: Hi, The following patch was

Re: [libvirt] [PATCH v2] qemuxml2argvtest: Set timezone

2014-02-06 Thread Ján Tomko
On 02/06/2014 03:11 PM, Michal Privoznik wrote: With my recent work on the test, both time() and localtime() are used. While mocking the former one, we get predictable result for UTC. But since the latter function uses timezone to get local time, the result of localtime() is not so predictive.

Re: [libvirt] [PATCH 1/2] qemuxml2argvmock: Mock time() on non-linux platforms too

2014-02-06 Thread Ján Tomko
On 02/06/2014 02:33 PM, Michal Privoznik wrote: The qemuxml2argvtest is run on more platforms than linux. For instance FreeBSD. On these platforms we are, however, not mocking time() which results in current time being fetched from system and hence tests number 32 and 33 failing.

[libvirt] [PATCH] virpcitest: fix coverity issues

2014-02-06 Thread Pavel Hrdina
The coverity server complains about the dev-stubDriver that it was freed by the virPCIDeviceSetStubDriver function, but it somehow don't get the fact that into the variable is immediately assigned new string. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- tests/virpcitest.c | 2 ++ 1 file

Re: [libvirt] [PATCH] virpcitest: fix coverity issues

2014-02-06 Thread Eric Blake
On 02/06/2014 08:18 AM, Pavel Hrdina wrote: The coverity server complains about the dev-stubDriver that it was freed by the virPCIDeviceSetStubDriver function, but it somehow don't get the fact that into the variable is immediately assigned new string. Signed-off-by: Pavel Hrdina

[libvirt] CPU models and feature probing (was Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Eduardo Habkost
(CCing libvir-list again, as this is continuing a discussion about a subject that interests libvirt developers, from another thread.) On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: Am 06.02.2014 16:19, schrieb Igor Mammedov: On Wed, 5 Feb 2014 17:52:16 +0100 Igor Mammedov

Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-06 Thread Michal Privoznik
On 06.02.2014 15:51, Teto wrote: These 2 patches should address your points. I've also used VIR_APPEND_ELEMENT in another function (1st patch). At your service should you have any other comment. Matthieu Coudron snip/ 0001-Replaced-VIR_REALLOC_N-by-VIR_APPEND_ELEMENT-in-virD.patch From

[libvirt] [PATCH] qemu: keep pre-migration domain state after failed migration

2014-02-06 Thread Martin Kletzander
Couple of codepaths shared the same code which can be moved out to a function and on one of such places, qemuMigrationConfirmPhase(), the domain was resumed even if it wasn't running before the migration started. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1057407 Signed-off-by: Martin

Re: [libvirt] [PATCH] virpcitest: fix coverity issues

2014-02-06 Thread Pavel Hrdina
On 6.2.2014 16:48, Eric Blake wrote: On 02/06/2014 08:18 AM, Pavel Hrdina wrote: The coverity server complains about the dev-stubDriver that it was freed by the virPCIDeviceSetStubDriver function, but it somehow don't get the fact that into the variable is immediately assigned new string.

[libvirt] [PATCHv3 1/2] Split out bind() from virPortAllocatorAcquire

2014-02-06 Thread Ján Tomko
--- src/util/virportallocator.c | 72 - 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c index 694f191..5d51434 100644 --- a/src/util/virportallocator.c +++

[libvirt] [PATCHv3 0/2] Support IPv6 in port allocator

2014-02-06 Thread Ján Tomko
v1: Support IPv6 in port allocator https://www.redhat.com/archives/libvir-list/2013-October/msg7.html v2: https://www.redhat.com/archives/libvir-list/2013-October/msg01313.html bind to v4 and v6 separately v3: fix the embarrasing bug of hardcoding AF_INET anyway added a test that mocks

[libvirt] [PATCHv3 2/2] Support IPv6 in port allocator

2014-02-06 Thread Ján Tomko
Also try to bind on IPv6 to check if the port is occupied. Change the mocked bind in the test to return EADDRINUSE for some ports only for the IPv4/IPv6 socket if we're testing on a host with IPv6 compiled in. Also mock socket() to make it fail with EAFNOTSUPPORTED if LIBVIRT_TEST_IPV4ONLY is

[libvirt] [PATCH] add option to enforce minimal pagesize for hugetlbfs backed guests

2014-02-06 Thread Marcelo Tosatti
Require a minimal pagesize for hugetlbfs backed guests. Fail guest initialization if hugetlbfs mount is configured with smaller page size. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index fd02864..e28d182 100644 ---

Re: [libvirt] CPU models and feature probing (was Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Andreas Färber
Am 06.02.2014 17:16, schrieb Eduardo Habkost: (CCing libvir-list again, as this is continuing a discussion about a subject that interests libvirt developers, from another thread.) On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: Am 06.02.2014 16:19, schrieb Igor Mammedov: On

Re: [libvirt] [PATCH] qemu: keep pre-migration domain state after failed migration

2014-02-06 Thread Jiri Denemark
On Thu, Feb 06, 2014 at 17:33:14 +0100, Martin Kletzander wrote: Couple of codepaths shared the same code which can be moved out to a function and on one of such places, qemuMigrationConfirmPhase(), the domain was resumed even if it wasn't running before the migration started. Resolves:

Re: [libvirt] [PATCH V4] Sheepdog: Auto Adding volume and pool refresh.

2014-02-06 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 05:55:49PM +0100, joel SIMOES wrote: From: Joel SIMOES joel.sim...@laposte.net Libvirt lose sheepdogs volumes on pool refresh or restart. When restarting sheepdog pool, all volumes are missing. This patch add automatically all volume from the added pool. With Jan

Re: [libvirt] [PATCH 0/4] libxl: fixes related to concurrency improvements

2014-02-06 Thread Jim Fehlig
Michal Privoznik wrote: On 05.02.2014 18:39, Jim Fehlig wrote: While reviving old patches to add job support to the libxl driver, testing revealed some problems that were difficult to encounter in the current, more serialized processing approach used in the driver. The first patch is a bug

[libvirt] [PATCH] libxl: remove unneeded locking of driver when restoring

2014-02-06 Thread Jim Fehlig
libxlDomainRestoreFlags acquires the driver lock while reading the domain config from the save file and adding it to libxlDriverPrivatePtr-domains. But virDomainObjList provides self-locking APIs, so remove the needless driver locking. Signed-off-by: Jim Fehlig jfeh...@suse.com --- I noticed

Re: [libvirt] [PATCH] libxl: remove unneeded locking of driver when restoring

2014-02-06 Thread Michal Privoznik
On 06.02.2014 18:46, Jim Fehlig wrote: libxlDomainRestoreFlags acquires the driver lock while reading the domain config from the save file and adding it to libxlDriverPrivatePtr-domains. But virDomainObjList provides self-locking APIs, so remove the needless driver locking. Signed-off-by: Jim

[libvirt] [PATCH 0/2] glusterfs related fixes

2014-02-06 Thread Christophe Fergeau
Hi, I noticed that virsh pool-list --type gluster is not giving me an empty list as expected, but rather the list of active pools. This is happening because virConnectListAllStoragePools() is returning VIR_ERROR_INVALID_ARG because VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER is unrecognized.

[libvirt] [PATCH v2 0/2] small gluster fixes

2014-02-06 Thread Christophe Fergeau
Hi, I noticed that virsh pool-list --type gluster is not giving me an empty list as expected, but rather the list of active pools. This is happening because virConnectListAllStoragePools() is returning VIR_ERROR_INVALID_ARG because VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER is unrecognized.

[libvirt] [PATCH 1/2 1/3] Add glusterfs to VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE

2014-02-06 Thread Christophe Fergeau
If it's not present in this list, we won't be able to get only glusterfs pools when using virConnectListAllStoragePools. --- src/conf/storage_conf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 62ac749..cada861

Re: [libvirt] [PATCH 0/2] glusterfs related fixes

2014-02-06 Thread Christophe Fergeau
Sorry, screwed up sending the patches, will send a v2, ignore this thread. Christophe On Thu, Feb 06, 2014 at 07:03:25PM +0100, Christophe Fergeau wrote: Hi, I noticed that virsh pool-list --type gluster is not giving me an empty list as expected, but rather the list of active pools. This

[libvirt] [PATCH v2 1/2] build-sys: Removed unused variable from configure.ac

2014-02-06 Thread Christophe Fergeau
LIBGLUSTER_LIBS is emptied before gluster is enabled/disabled, but nothing else sets/uses this variable, so it can be removed. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 884e0e4..e233706 100644 --- a/configure.ac +++ b/configure.ac @@

[libvirt] [PATCH v2 2/2] Add glusterfs to VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE

2014-02-06 Thread Christophe Fergeau
If it's not present in this list, we won't be able to get only glusterfs pools when using virConnectListAllStoragePools. --- src/conf/storage_conf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 62ac749..cada861

Re: [libvirt] [PATCH] libxl: remove unneeded locking of driver when restoring

2014-02-06 Thread Jim Fehlig
Michal Privoznik wrote: On 06.02.2014 18:46, Jim Fehlig wrote: libxlDomainRestoreFlags acquires the driver lock while reading the domain config from the save file and adding it to libxlDriverPrivatePtr-domains. But virDomainObjList provides self-locking APIs, so remove the needless driver

Re: [libvirt] [PATCH] qemu: keep pre-migration domain state after failed migration

2014-02-06 Thread Eric Blake
On 02/06/2014 09:33 AM, Martin Kletzander wrote: Couple of codepaths shared the same code which can be moved out to a function and on one of such places, qemuMigrationConfirmPhase(), the domain was resumed even if it wasn't running before the migration started. +if (state ==

Re: [libvirt] [PATCH v2 2/2] Add glusterfs to VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE

2014-02-06 Thread Eric Blake
On 02/06/2014 11:09 AM, Christophe Fergeau wrote: If it's not present in this list, we won't be able to get only glusterfs pools when using virConnectListAllStoragePools. --- src/conf/storage_conf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v2 1/2] build-sys: Removed unused variable from configure.ac

2014-02-06 Thread Eric Blake
On 02/06/2014 11:09 AM, Christophe Fergeau wrote: LIBGLUSTER_LIBS is emptied before gluster is enabled/disabled, but nothing else sets/uses this variable, so it can be removed. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index

Re: [libvirt] [PATCH v2 0/2] small gluster fixes

2014-02-06 Thread Eric Blake
On 02/06/2014 11:09 AM, Christophe Fergeau wrote: I've played a bit with adding some compile time checks to avoid this in the future, but while they work, they are a bit ugly-looking, and they would require some changes in docs/apibuild.py to teach it to parse 1 N, or to make it ignore

[libvirt] [PATCH 7/6] qemu: allow filtering events by regex

2014-02-06 Thread Eric Blake
When listening for a subset of monitor events, it can be tedious to register for each event name in series; nicer is to register for multiple events in one go. Implement a flag to use regex interpretation of the event filter. While at it, prove how much I hate the shift key, by adding a way to

Re: [libvirt] [PATCHv4 1/7] storage: gluster: Set volume metadata in a separate function

2014-02-06 Thread Eric Blake
On 02/03/2014 09:54 AM, Peter Krempa wrote: Extract the metadata setting code into a separate function for future use. --- src/storage/storage_backend_gluster.c | 66 --- 1 file changed, 46 insertions(+), 20 deletions(-) ACK. -- Eric Blake eblake redhat

Re: [libvirt] [PATCH] Skip the 'copyright-check' on -maint branches

2014-02-06 Thread Eric Blake
On 02/04/2014 06:51 AM, Daniel P. Berrange wrote: The maint branches will often have out of date copyright headers so we must skip the 'sc_copyright_check' rule there. Is that the only rule, or are there others? But yeah, that's definitely the most annoying one. Signed-off-by: Daniel P.

[libvirt] [PATCH v2] libvirt support to force convergence of live guest migration

2014-02-06 Thread Chegu Vinod
Hello, 'am sending this updated patch as an attachment (as I was having some issues with my smtp server and git send-email setup). Thanks, Vinod Subject: [PATCH v2] libvirt support to force convergence of live guest migration Changes since RFC (i.e. v1) patch : - Incorporated feedback from

Re: [libvirt] [PATCHv4 2/7] storage: Add APIs for internal handling of files via the storage driver

2014-02-06 Thread Eric Blake
On 02/03/2014 09:54 AM, Peter Krempa wrote: Some remote filesystems are not accessible via the local filesystem calls, but libvirt needs means to do operations on such files. This patch adds internal APIs into the storage driver that will allow operations on various networked and other

[libvirt] [PATCH 0/3] libxl: misc trivial cleanups

2014-02-06 Thread Jim Fehlig
A few trivial patches for things I noticed while working on my upcoming patches that add job support in the libxl driver. Jim Fehlig (3): libxl: rename libxlCreateDomEvents to libxlDomEventsRegister libxl: register for domain events immediately after creation libxl: fix libxlDoDomainSave

[libvirt] [PATCH 1/3] libxl: rename libxlCreateDomEvents to libxlDomEventsRegister

2014-02-06 Thread Jim Fehlig
libxlDomEventsRegister better reflects its purpose: register for domain events from libxl. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c

[libvirt] [PATCH 2/3] libxl: register for domain events immediately after creation

2014-02-06 Thread Jim Fehlig
A small fix for the possiblitiy of jumping to an error path before registering for domain events, preventing receiving important ones like shutdown and death. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[libvirt] [PATCH 3/3] libxl: fix libxlDoDomainSave documentation

2014-02-06 Thread Jim Fehlig
Update the function's comment, which was missed when removing use of the driver lock everywhere. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c

[libvirt] [PATCH 00/11] libxl: add job support

2014-02-06 Thread Jim Fehlig
This patch series adds job support to the libxl driver, using techiques from the qemu driver. One benefit is no longer blocking get operations during long running modify operations. E.g. with these patches 'vish dominfo dom' will work while 'virsh save dom ...' is in progress. The first patch

[libvirt] [PATCH 08/11] libxl: use job functions in vcpu set and pin functions

2014-02-06 Thread Jim Fehlig
These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git

[libvirt] [PATCH 02/11] libxl: use job functions in libxlVmStart

2014-02-06 Thread Jim Fehlig
Creating a large domain could potentially be time consuming. Use the recently added job functions and unlock the virDomainObj while the create operation is in progress. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 59 ++--

[libvirt] [PATCH 03/11] libxl: use job functions in libxlDomainSetMemoryFlags

2014-02-06 Thread Jim Fehlig
Large balloon operation can be time consuming. Use the recently added job functions and unlock the virDomainObj while ballooning. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-)

[libvirt] [PATCH 10/11] libxl: use job functions in libxlDomainSetAutostart

2014-02-06 Thread Jim Fehlig
Setting autostart is a modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_driver.c

[libvirt] [PATCH 05/11] libxl: use job functions in libxlDomainDestroyFlags

2014-02-06 Thread Jim Fehlig
Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index

[libvirt] [PATCH 11/11] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

2014-02-06 Thread Jim Fehlig
Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 79d64a5..a4b6ecd

[libvirt] [PATCH 07/11] libxl: use job functions in libxlDomainCoreDump

2014-02-06 Thread Jim Fehlig
Dumping a domain's core can take considerable time. Use the recently added job functions and unlock the virDomainObj while dumping core. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 37 ++--- 1 file changed, 26 insertions(+), 11

[libvirt] [PATCH 09/11] libxl: use job functions in device attach and detach functions

2014-02-06 Thread Jim Fehlig
These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 40 ++-- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git

[libvirt] [PATCH 01/11] libxl: Add job support to libxl driver

2014-02-06 Thread Jim Fehlig
Follows the pattern used in the QEMU driver for managing multiple, simultaneous jobs within the driver. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 128 +++ src/libxl/libxl_domain.h | 37 ++ 2 files changed,

[libvirt] [PATCH 04/11] libxl: use job functions in libxlDomain{Suspend, Resume}

2014-02-06 Thread Jim Fehlig
These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_driver.c

[libvirt] [PATCH 06/11] libxl: use job functions in domain save operations

2014-02-06 Thread Jim Fehlig
Saving domain memory and cpu state can take considerable time. Use the recently added job functions and unlock the virDomainObj while saving the domain. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 54 ++-- 1 file changed,

Re: [libvirt] [Qemu-devel] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-06 Thread Fam Zheng
On Thu, 02/06 13:27, Stefan Hajnoczi wrote: On Tue, Feb 4, 2014 at 1:38 PM, Michal Privoznik mpriv...@redhat.com wrote: On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM libvirt: you are welcome to join the QEMU umbrella organization like last year. I've updated wiki with a libvirt

[libvirt] [PATCH v5] bhyve: add a basic driver

2014-02-06 Thread Roman Bogorodskiy
Changes from v4: - Set acpi and apic flags based on domain definition - Add more detailed description about -H and -P flags of bhyve to justify theirs usage Roman Bogorodskiy (1): bhyve: add a basic driver configure.ac| 7 + daemon/libvirtd.c | 9 +

[libvirt] [PATCH v5] bhyve: add a basic driver

2014-02-06 Thread Roman Bogorodskiy
At this point it has a limited functionality and is highly experimental. Supported domain operations are: * define * start * destroy * dumpxml * dominfo It's only possible to have only one disk device and only one network, which should be of type bridge. --- configure.ac