The security driver expects /etc/apparmor.d/libvirt/TEMPLATE but we
installed it to /etc/apparmor.d/libvirtd/TEMPLATE. Move the template to
the expected place since that code was here long before.
---
examples/apparmor/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Coverity complains about cell_cpus being leaked on error
and valgrind shows 'caps' is leaked on success.
Introduced in eb64e87.
---
tests/vircapstest.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/vircapstest.c b/tests/vircapstest.c
index a40771d..4264e9e
On Tue, Feb 11, 2014 at 11:48:58AM +0100, Michal Privoznik wrote:
On 11.02.2014 01:04, Marcelo Tosatti wrote:
On Mon, Feb 10, 2014 at 03:42:45PM -0700, Eric Blake wrote:
On 02/10/2014 03:10 PM, Marcelo Tosatti wrote:
Since QEMU commit kvmclock: clock should count only if vm is running
On Tue, Feb 11, 2014 at 02:07:06PM -0700, Eric Blake wrote:
On 02/11/2014 08:57 AM, Daniel P. Berrange wrote:
On Wed, Jan 29, 2014 at 10:49:22AM -0700, Eric Blake wrote:
This patch adds some new RPC call numbers, but for ease of review,
they sit idle until a later patch adds the client
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
src/storage/storage_backend_scsi.c | 24
src/util/virdbus.c | 2 +-
3 files changed, 1 insertion(+), 26 deletions(-)
diff --git
On 02/12/2014 07:29 AM, Michael Chapman wrote:
On Thu, 16 Jan 2014, Peter Krempa wrote:
On 01/09/14 23:40, Eric Blake wrote:
On 01/06/2014 09:44 AM, Peter Krempa wrote:
Separate the steps to create libvirt's volume metadata from the actual
volume building process. This is already done for
On Wed, 12 Feb 2014, Ján Tomko wrote:
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1828,6 +1828,10 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj,
pool-volumes.objs[pool-volumes.count++] = newvol;
volobj = virGetStorageVol(obj-conn,
virGetStorageVol can return NULL on out-of-memory. If it does, cleanly
abort the volume clone operation.
Signed-off-by: Michael Chapman m...@very.puzzling.org
---
src/storage/storage_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/storage/storage_driver.c
Hi again
So we did 2 changes in the specfile that are described below
This has gone through all our nightlies and all, so that works for us
I’m sorry that I can’t seem to get git send-email to work on my mac (complains
about missing perl modules ?!?)
Fortunately the changes I did are so simple,
Coverity has complained this morning about this change... see below.
Please send a patch to resolve.
On 02/08/2014 01:51 AM, Pradipta Kr. Banerjee wrote:
This test creates a Fake NUMA topology with non-sequential cell ids
to check if libvirt properly handles the same
Signed-off-by:
On 02/12/2014 12:43 PM, John Ferlan wrote:
Coverity has complained this morning about this change... see below.
Please send a patch to resolve.
A patch has been sent this morning, please review:
https://www.redhat.com/archives/libvir-list/2014-February/msg00660.html
signature.asc
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
src/storage/storage_backend_scsi.c | 24
src/util/virdbus.c | 2 +-
3 files
On 02/12/2014 02:47 AM, Ján Tomko wrote:
Coverity complains about cell_cpus being leaked on error
and valgrind shows 'caps' is leaked on success.
Introduced in eb64e87.
---
tests/vircapstest.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
ACK
--
Eric Blake eblake
On 02/12/2014 02:41 AM, Cédric Bosdonnat wrote:
The security driver expects /etc/apparmor.d/libvirt/TEMPLATE but we
installed it to /etc/apparmor.d/libvirtd/TEMPLATE. Move the template to
the expected place since that code was here long before.
---
examples/apparmor/Makefile.am | 2 +-
1
On 02/12/2014 06:31 AM, Eric Blake wrote:
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
src/storage/storage_backend_scsi.c | 24
On 02/12/2014 02:32 PM, Eric Blake wrote:
On 02/12/2014 02:47 AM, Ján Tomko wrote:
Coverity complains about cell_cpus being leaked on error
and valgrind shows 'caps' is leaked on success.
Introduced in eb64e87.
---
tests/vircapstest.c | 7 +--
1 file changed, 5 insertions(+), 2
On 02/12/2014 04:41 AM, Thierry Parmentelat wrote:
Hi again
[Please don't top-post on technical lists]
So we did 2 changes in the specfile that are described below
This has gone through all our nightlies and all, so that works for us
I’m sorry that I can’t seem to get git send-email to
On 02/11/14 17:26, Peter Krempa wrote:
Some remote filesystems are not accessible via the local filesystem
calls, but libvirt needs means to do operations on such files.
This patch adds internal APIs into the storage driver that will allow
operations on various networked and other
On Wed, Feb 12, 2014 at 06:54:41AM -0700, Eric Blake wrote:
On 02/12/2014 04:41 AM, Thierry Parmentelat wrote:
Hi again
[Please don't top-post on technical lists]
So we did 2 changes in the specfile that are described below
This has gone through all our nightlies and all, so that
The storage driver expects 'createVol' to fill out the volume key.
For disk and logical backends, we generate the key only after the volume
has been built. Revert the separation commits for these backends.
Ján Tomko (2):
Revert storage: lvm: Separate creating of the volume from building
This reverts commit 67ccf91bf29488783bd1fda46b362450f71a2078.
We only generate the volume key after we've built it, but the storage
driver expects it to be filled after createVol finishes.
Squash the volume building back with creating to fulfill this
expectation.
---
This reverts commit af1fb38f55d4fb87e0fcaee1e973fa9c6713b1e6.
With it, creating new logical volumes fails:
https://www.redhat.com/archives/libvir-list/2014-February/msg00658.html
In the storage driver, we expect CreateVol to fill out the volume key,
but the LVM backend fills the key with the uuid
These timeout values make librados/librbd return -ETIMEDOUT when a
operation is blocking due to a failing/unreachable Ceph cluster.
By having the operations time out libvirt will not block.
---
src/storage/storage_backend_rbd.c | 17 +
1 file changed, 17 insertions(+)
diff
With this information it's easier for the user to debug what is
going wrong.
---
src/storage/storage_backend_rbd.c | 119 +
1 file changed, 68 insertions(+), 51 deletions(-)
diff --git a/src/storage/storage_backend_rbd.c
b/src/storage/storage_backend_rbd.c
This series of patches changes a couple of things in the RBD storage pool
driver.
The first change is that it includes the return status of librados and librbd
in log and debug messages making it easier for users to track down the real
cause of the problem.
The second patch simplifies some code.
Reduces code and brings logging back to one function.
---
src/storage/storage_backend_rbd.c | 43 ++---
1 file changed, 16 insertions(+), 27 deletions(-)
diff --git a/src/storage/storage_backend_rbd.c
b/src/storage/storage_backend_rbd.c
index bd21873..8d1e320
On 02/12/14 15:03, Ján Tomko wrote:
The storage driver expects 'createVol' to fill out the volume key.
For disk and logical backends, we generate the key only after the volume
has been built. Revert the separation commits for these backends.
Ján Tomko (2):
Revert storage: lvm: Separate
On Tue, Feb 11, 2014 at 05:26:53PM +0100, Peter Krempa wrote:
Some remote filesystems are not accessible via the local filesystem
calls, but libvirt needs means to do operations on such files.
This patch adds internal APIs into the storage driver that will allow
operations on various
On 02/12/2014 12:05 PM, Michael Chapman wrote:
virGetStorageVol can return NULL on out-of-memory. If it does, cleanly
abort the volume clone operation.
Signed-off-by: Michael Chapman m...@very.puzzling.org
---
src/storage/storage_driver.c | 4
1 file changed, 4 insertions(+)
ACK
On 02/12/2014 03:15 PM, Peter Krempa wrote:
On 02/12/14 15:03, Ján Tomko wrote:
The storage driver expects 'createVol' to fill out the volume key.
For disk and logical backends, we generate the key only after the volume
has been built. Revert the separation commits for these backends.
Ján
On 02/12/2014 03:54 PM, Eric Blake wrote:
On 02/12/2014 04:41 AM, Thierry Parmentelat wrote:
Hi again
[Please don't top-post on technical lists]
So we did 2 changes in the specfile that are described below
This has gone through all our nightlies and all, so that works for us
I’m sorry that
On Wed, 2014-02-12 at 06:31 -0700, Eric Blake wrote:
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
src/storage/storage_backend_scsi.c | 24
On 02/12/2014 08:04 AM, Cedric Bosdonnat wrote:
On Wed, 2014-02-12 at 06:31 -0700, Eric Blake wrote:
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
Tier four.
Michal Privoznik (3):
network_conf: Expose virNetworkDefFormatInternal
network: Introduce network hooks
network: Taint networks that are using hook script
docs/hooks.html.in | 98 --
src/conf/network_conf.c | 64
There might be some use cases, where user wants to prepare the host or
its environment prior to starting a network and do some cleanup after
the network has been shut down. Consider all the functionality that
libvirt doesn't currently have as an example what a hook script can
possibly do.
Basically, the idea is copied from domain code, where tainting
exists for a while. Currently, only one taint reason exists -
VIR_NETWORK_TAINT_HOOK to mark those networks which caused invoking
of hook script.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c |
In the next patch I'm going to need the network format function that
takes virBuffer as argument. However, slightly change of name is more
appropriate then: virNetworkDefFormatBuf to match the rest of functions
that format an object to buffer.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
On Wed, Feb 05, 2014 at 03:10:01PM +0100, Cédric Bosdonnat wrote:
LXC rootfs can be either a directory or a block device or an image
file. The first two types have been implemented, but the image file is
still to be done since LXC auto-guesses the file format at mount time
and the LXC driver
On Wed, Feb 05, 2014 at 03:10:00PM +0100, Cédric Bosdonnat wrote:
This function aims at converting LXC configuration into a libvirt
domain XML description to help users migrate from LXC to libvirt.
Here is an example of how the lxc configuration works:
virsh -c lxc:/// domxml-from-native
On Wed, Feb 05, 2014 at 03:09:59PM +0100, Cédric Bosdonnat wrote:
virConf now honours a VIR_CONF_FLAG_LXC_FORMAT flag to handle LXC
configuration files. The differences are that property names can
contain '.' character and values are all strings without any bounding
quotes.
Provide a new
On Wed, Feb 05, 2014 at 03:10:02PM +0100, Cédric Bosdonnat wrote:
Tmpfs relative size and default 50% size values aren't supported as
we have no idea of the available memory at the conversion time.
---
src/lxc/lxc_container.c | 2 +-
src/lxc/lxc_container.h
On Wed, Feb 12, 2014 at 05:23:39PM +, Daniel P. Berrange wrote:
On Wed, Feb 05, 2014 at 03:10:01PM +0100, Cédric Bosdonnat wrote:
LXC rootfs can be either a directory or a block device or an image
file. The first two types have been implemented, but the image file is
still to be done
On Wed, Feb 05, 2014 at 03:10:08PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 44
++
tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 5 +++
tests/lxcconf2xmldata/lxcconf2xml-idmap.xml| 28
On Wed, Feb 05, 2014 at 03:10:04PM +0100, Cédric Bosdonnat wrote:
Some of the LXC configuration properties aren't migrated since they
would only cause problems in libvirt-lxc:
* lxc.network.ipv[46]: LXC driver doesn't setup IP address of guests,
see rhbz#1059624
* lxc.network.name,
On Wed, Feb 05, 2014 at 03:10:06PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 44
tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 6
2 files changed, 50 insertions(+)
ACK
Daniel
--
|: http://berrange.com -o-
On Wed, Feb 05, 2014 at 03:10:09PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 40
tests/lxcconf2xmldata/lxcconf2xml-memtune.config | 10 ++
tests/lxcconf2xmldata/lxcconf2xml-memtune.xml| 29 +
On Wed, Feb 05, 2014 at 03:10:10PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 34
tests/lxcconf2xmldata/lxcconf2xml-cputune.config | 7 +
tests/lxcconf2xmldata/lxcconf2xml-cputune.xml| 29
On Wed, Feb 05, 2014 at 03:10:14PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 4
1 file changed, 4 insertions(+)
ACK
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o-
On Wed, Feb 05, 2014 at 03:10:16PM +0100, Cédric Bosdonnat wrote:
---
docs/drvlxc.html.in | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
ACK
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|
|:
On Wed, Feb 05, 2014 at 03:10:13PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c| 9 +
tests/lxcconf2xmldata/lxcconf2xml-simple.config | 1 +
tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
On Wed, Feb 05, 2014 at 03:10:11PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 30
++
.../lxcconf2xmldata/lxcconf2xml-cpusettune.config | 6 +
tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 27 +++
On Wed, Feb 05, 2014 at 03:10:05PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 44
+++---
.../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 6 +++
tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 26 +
On Wed, Feb 05, 2014 at 03:10:12PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 63
++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 7 +++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 35
On Wed, Feb 05, 2014 at 03:10:17PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 68
++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 4 ++
tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 4 ++
3 files changed, 65
On Wed, Feb 05, 2014 at 03:10:15PM +0100, Cédric Bosdonnat wrote:
The problem with VLAN is that the user still has to manually create the
vlan interface on the host. Then the generated configuration will use
it as a nerwork hostdev device. So the generated configurations of the
following two
On 02/12/2014 03:23 AM, Daniel P. Berrange wrote:
On Tue, Feb 11, 2014 at 02:07:06PM -0700, Eric Blake wrote:
On 02/11/2014 08:57 AM, Daniel P. Berrange wrote:
On Wed, Jan 29, 2014 at 10:49:22AM -0700, Eric Blake wrote:
This patch adds some new RPC call numbers, but for ease of review,
they
On Wed, Feb 05, 2014 at 03:10:07PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 47
+-
.../lxcconf2xml-macvlannetwork.config | 13 ++
.../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 26
On Wed, Feb 05, 2014 at 03:10:15PM +0100, Cédric Bosdonnat wrote:
The problem with VLAN is that the user still has to manually create the
vlan interface on the host. Then the generated configuration will use
it as a nerwork hostdev device. So the generated configurations of the
following two
On Wed, Feb 05, 2014 at 03:09:58PM +0100, Cédric Bosdonnat wrote:
Here is an updated version of the patch set fixing comments from Daniel.
It also adds 3 commits:
* One adding conversion for the newly supported blkio throttle tune
in lxc driver.
* One actually using the state of the
On Wed, Feb 05, 2014 at 03:10:08PM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 44
++
tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 5 +++
tests/lxcconf2xmldata/lxcconf2xml-idmap.xml| 28
On Wed, Feb 05, 2014 at 03:10:03PM +0100, Cédric Bosdonnat wrote:
If no network configuration is provided, LXC only provides the loopback
interface. To match this, we need to use the privnet feature. LXC will
also define a 'none' network type in its 1.0.0 version that fits
libvirt LXC driver's
On 02/12/2014 07:07 PM, Michal Privoznik wrote:
In the next patch I'm going to need the network format function that
takes virBuffer as argument. However, slightly change of name is more
appropriate then: virNetworkDefFormatBuf to match the rest of functions
that format an object to buffer.
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Implement the APIs added by the previous patch in the default storage
driver used by qemu.
---
Notes:
Version 5:
- adapt to error reporting change
src/check-aclrules.pl | 1 +
src/storage/storage_backend.c | 37
On 02/12/2014 07:07 PM, Michal Privoznik wrote:
There might be some use cases, where user wants to prepare the host or
its environment prior to starting a network and do some cleanup after
the network has been shut down. Consider all the functionality that
libvirt doesn't currently have as an
On 02/12/2014 01:03 PM, Chris Friesen wrote:
On 02/11/2014 04:45 PM, Cole Robinson wrote:
On 02/10/2014 06:46 PM, Chris Friesen wrote:
Hi,
We've run into a problem with libvirt 1.1.2 and are looking for some
comments
on whether this is a bug or design intent.
We're trying to use
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Implement storage backend functions to deal with gluster volumes and
implement the stat and unlink backend APIs.
---
+
+static void
+virStorageFileBackendGlusterDeinit(virStorageFilePtr file)
+{
+VIR_DEBUG(deinitializing gluster storage
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Implement the stat and unlink function for file volumes and stat
for block volumes using the regular system calls.
s/block//
---
+static int
+virStorageFileBackendFileUnlink(virStorageFilePtr file)
+{
+int ret;
+
+ret =
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Use the new storage driver APIs to delete snapshot backing files in case
of failure instead of directly relying on unlink. This will help us in
the future when we will be adding network based storage without local
representation in the host.
---
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Use the new storage driver based stat api to detect exiting files just
as we did with local files.
---
Notes:
Version 5:
- new in sereis
src/qemu/qemu_driver.c | 59
+++---
1 file
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Add support for gluster backed images as sources for snapshots in the
qemu driver. This will also simplify adding further network backed
volumes as sources for snapshot in case qemu will support them.
---
Looks a bit confusing the number of
On 02/12/2014 07:29 AM, Laine Stump wrote:
On 02/12/2014 03:54 PM, Eric Blake wrote:
On 02/12/2014 04:41 AM, Thierry Parmentelat wrote:
Hi again
[Please don't top-post on technical lists]
So we did 2 changes in the specfile that are described below
This has gone through all our nightlies
On 02/05/2014 02:51 AM, Daniel P. Berrange wrote:
On Tue, Feb 04, 2014 at 03:15:56PM -0700, Eric Blake wrote:
On Fedora 20, with wireshark-devel installed, 'make rpm' failed
due to installed but unpackaged files related to wireshark. As
F20 is already released without wireshark, I chose to
From: Thierry Parmentelat thierry.parmente...@inria.fr
When building modules, libvirt-daemon-config-network requires
libvirt-daemon-driver-network to ensure the 'default' network
is setup properly
Signed-off-by: Eric Blake ebl...@redhat.com
---
v2: make dep dependent on whether subpackage is
In general, the 'libvirt' metapackage should pull in all subpackages.
Fix this for the wireshark subpackage created in commit f9ada9f.
* libvirt.spec.in (Requires): Add dependency.
Signed-off-by: Eric Blake ebl...@redhat.com
---
libvirt.spec.in | 3 +++
1 file changed, 3 insertions(+)
diff
On 01/27/2014 08:53 PM, Amos Kong wrote:
Signed-off-by: Amos Kong ak...@redhat.com
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
On 01/27/2014 08:53 PM, Amos Kong wrote:
s/marcos/macros/ in the subject line
We will use the marocs to generate two tables, which contain
s/marocs/macros/
(wow, two different ways to mis-spell the word)
the option name and argument information.
Signed-off-by: Amos Kong ak...@redhat.com
On 01/27/2014 08:53 PM, Amos Kong wrote:
vm_config_groups[] contain the options which have parameter, but some
legcy options haven't been added to vm_config_groups[].
s/legcy/legacy/
All the options can be found in qemu-options.hx, this patch used two
new marcos to generate two tables, we
On 01/27/2014 08:53 PM, Amos Kong wrote:
This patch introduced a new maroc, it will be used to dump the help
messages of all the options.
Signed-off-by: Amos Kong ak...@redhat.com
---
qemu-options-wrapper.h | 9 +
1 file changed, 9 insertions(+)
Again, this patch is useless on
On Wed, Feb 12, 2014 at 10:22:11AM +, Daniel P. Berrange wrote:
I agree that this should be a completely separate command, not
merely a flag to the Resume API. The reason is that you cannot
do sensible error reporting if you overload this in one API
call. ie consider that resuming the
On Wed, Feb 12, 2014 at 06:45:28PM -0200, Marcelo Tosatti wrote:
On Wed, Feb 12, 2014 at 10:22:11AM +, Daniel P. Berrange wrote:
I agree that this should be a completely separate command, not
merely a flag to the Resume API. The reason is that you cannot
do sensible error reporting if
On 02/11/2014 05:19 AM, Markus Armbruster wrote:
[Note cc: Eric]
Amos Kong ak...@redhat.com writes:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch try to return help message
for
On 01/27/2014 08:53 PM, Amos Kong wrote:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch try to return help message
for this kind of legacy options.
Example:
{
helpmsg: \-vnc
On 02/12/2014 01:45 PM, Marcelo Tosatti wrote:
On Wed, Feb 12, 2014 at 10:22:11AM +, Daniel P. Berrange wrote:
I agree that this should be a completely separate command, not
merely a flag to the Resume API. The reason is that you cannot
do sensible error reporting if you overload this in
On 02/12/2014 02:05 PM, Eric Blake wrote:
I'll go write a virsh alias and virt-manager patch.
A single virsh command that makes multiple API calls under the hood is
just fine - on partial failure, it can make it quite clear which of the
steps failed. I have no problem with creating a 'virsh
On Wed, Feb 12, 2014 at 01:28:43PM -0700, Eric Blake wrote:
In general, the 'libvirt' metapackage should pull in all subpackages.
Fix this for the wireshark subpackage created in commit f9ada9f.
* libvirt.spec.in (Requires): Add dependency.
Signed-off-by: Eric Blake ebl...@redhat.com
---
On Wed, Feb 12, 2014 at 01:25:11PM -0700, Eric Blake wrote:
From: Thierry Parmentelat thierry.parmente...@inria.fr
When building modules, libvirt-daemon-config-network requires
libvirt-daemon-driver-network to ensure the 'default' network
is setup properly
Signed-off-by: Eric Blake
On 02/12/2014 02:26 PM, Martin Kletzander wrote:
On Wed, Feb 12, 2014 at 01:25:11PM -0700, Eric Blake wrote:
From: Thierry Parmentelat thierry.parmente...@inria.fr
When building modules, libvirt-daemon-config-network requires
libvirt-daemon-driver-network to ensure the 'default' network
is
On 02/12/2014 02:20 PM, Martin Kletzander wrote:
On Wed, Feb 12, 2014 at 01:28:43PM -0700, Eric Blake wrote:
In general, the 'libvirt' metapackage should pull in all subpackages.
Fix this for the wireshark subpackage created in commit f9ada9f.
* libvirt.spec.in (Requires): Add dependency.
Similar to cf76c4b, if modules are used, then nwfilter configuration
requires the nwfilter driver module.
Signed-off-by: Eric Blake ebl...@redhat.com
---
libvirt.spec.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 2d57c71..2b44c21 100644
---
Recent autotest/virt-test testing on f20 discovered an anomaly in how
the bandwidth options are documented and used. This was discovered due
to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20)
in which overflow was actually caught and returned as an error. The fix
was first
I meant to add something under the -- in my email, but the fingers were
too quick... Although the commit message is quite lengthy - it does
hopefully give enough context to decisions made.
There was some consideration to perform kibibyte range checking in
libvirt; however, if the underlying
Dumping a domain's core can take considerable time. Use the
recently added job functions and unlock the virDomainObj while
dumping core.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2: Check libxlDomainObjEndJob() return value
src/libxl/libxl_driver.c | 38
Large balloon operation can be time consuming. Use the recently
added job functions and unlock the virDomainObj while ballooning.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2: Check libxlDomainObjEndJob() return value
src/libxl/libxl_driver.c | 33 +++--
1
Once a domain has reached the shutdown state, set its ID to -1.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 8e4242a..0cd0ec8 100644
---
When explicitly destroying a domain (libxlDomainDestroyFlags), or
handling an out-of-band domain shutdown event, cleanup the domain
in the context of a job. Introduce libxlVmCleanupJob to wrap
libxlVmCleanup in a job block.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2:
Introduce
These operations aren't necessarily time consuming, but need to
wait in the queue of modify jobs.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2: Check libxlDomainObjEndJob() return value
src/libxl/libxl_driver.c | 42 --
1 file changed, 28
This patch series adds job support to the libxl driver, using a simplified
version of the technique used in the qemu driver. One benefit of this
series is no longer blocking get operations during long running modify
operations. E.g. with these patches 'vish dominfo dom' will work while
'virsh
This function, which only has five call sites, simply calls
libxl_domain_destroy and libxlVmCleanup. Call those functions
directly at the call sites, allowing more control over how a
domain is destroyed and cleaned up. This patch maintains the
existing semantic, leaving changes to a subsequent
Follows the pattern used in the QEMU driver for managing multiple,
simultaneous jobs within the driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2:
Add ATTRIBUTE_RETURN_CHECK to libxlDomainObjEndJob
src/libxl/libxl_domain.c | 128 +++
These operations aren't necessarily time consuming, but need to
wait in the queue of modify jobs.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2: Check libxlDomainObjEndJob() return value
src/libxl/libxl_driver.c | 26 --
1 file changed, 20 insertions(+), 6
1 - 100 of 108 matches
Mail list logo
