On Tue, Feb 11, 2014 at 01:03:05PM +0100, Markus Armbruster wrote:
Amos Kong ak...@redhat.com writes:
vm_config_groups[] contain the options which have parameter, but some
legcy options haven't been added to vm_config_groups[].
All the options can be found in qemu-options.hx, this patch
Hello ChunYan,
Good to see your patchset into smaller pieces. This patch looks almost
OK for me, but there are problems you'll need to look into.
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
Add driver info to used_by, to avoid conflict among different drivers if there
are more than
On 02/17/2014 08:33 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
PS2 device only works for X86 platform, other platforms may need
USB mouse. Athough it doesn't influence the QEMU command line, but
it's not right to add one PS2 mouse for non-X86 platform.
What's more, PS2
On Tue, Feb 11, 2014 at 01:19:16PM +0100, Markus Armbruster wrote:
[Note cc: Eric]
Hi Markus,
Amos Kong ak...@redhat.com writes:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch
On Wed, Feb 12, 2014 at 02:00:51PM -0700, Eric Blake wrote:
On 01/27/2014 08:53 PM, Amos Kong wrote:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch try to return help message
for
On 02/17/2014 10:04 AM, Li Zhang wrote:
On 2014年02月17日 16:48, Ján Tomko wrote:
On 02/17/2014 08:33 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
PS2 device only works for X86 platform, other platforms may need
USB mouse. Athough it doesn't influence the QEMU command line,
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific cfg-relaxedACS handling to be a flag, and pass it to hostdev
functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |
On 2014年02月17日 17:17, Ján Tomko wrote:
On 02/17/2014 10:04 AM, Li Zhang wrote:
On 2014年02月17日 16:48, Ján Tomko wrote:
On 02/17/2014 08:33 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
PS2 device only works for X86 platform, other platforms may need
USB mouse. Athough it
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific COLD_BOOT handling to be a flag, and pass it to hostdev functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |6
On 02/14/14 16:26, Eric Blake wrote:
On 02/14/2014 08:08 AM, Peter Krempa wrote:
The internal pools were an idea in one of the first iterations of the
gluster series that deemed unused. Somehow still this got pushed. Remove
grammar is off, but I'm not sure of the best fix. Maybe one of:
On 2014年02月17日 16:48, Ján Tomko wrote:
On 02/17/2014 08:33 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
PS2 device only works for X86 platform, other platforms may need
USB mouse. Athough it doesn't influence the QEMU command line, but
it's not right to add one PS2 mouse for
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
original paring VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT in hostdev function to
qemuDomainDeviceDefPostParse.
typo: paring - parsing.
Signed-off-by: Chunyan Liu
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, move
add/remove a shareable csi hostdev to/from shared device table outside hostdev
functions.
Typo csi - scsi
Signed-off-by: Chunyan Liu cy...@suse.com
---
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patchset is to add keyboard input device.
For PPC64, it doesn't support a default keyboard device when the graphic
is enabled. Libvirt supports QEMU command line as -device VGA which
won't create any keyboard device for it. So it requires libvirt
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to add one new interface to add input devices.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/conf/domain_conf.c | 29 +
src/conf/domain_conf.h | 4
src/libvirt_private.syms | 1 +
3
From: Li Zhang zhlci...@linux.vnet.ibm.com
There is no keyboard support currently in libvirt .
For some platforms, it needs to add a USB keyboard when graphics are enabled.
This patch is to add keyboard input device type.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
From: Li Zhang zhlci...@linux.vnet.ibm.com
PS2 device only works for X86 platform, other platforms may need
USB devices instead. Athough it doesn't influence the QEMU command line,
but it's not right to add PS2 mouse/keyboard for non-X86 platform.
So, this patch is to remove PS2 devices for
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to format xen command line for USB keyboard
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/xenxs/xen_sxpr.c | 27 +++
src/xenxs/xen_xm.c | 30 ++
2 files changed, 41
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to format qemu command line for USB keyboard
and add test cases for it.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_command.c| 41 --
From: Li Zhang zhlci...@linux.vnet.ibm.com
There is no keyboard working on PPC64 and PS2 mouse is only for X86
when graphics are enabled. It needs to add a USB keyboard and USB mouse for
PPC64.
This patch is to add a USB keyboard and USB mouse when graphics are enabled.
Signed-off-by: Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com
QEMU can support USB keyboard but libvirt haven't supportted it yet.
This patch is to add USB keyboard capabilities and test cases.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c | 3 +++
On Thu, 2014-02-13 at 10:44 +0100, Igor Mammedov wrote:
On Thu, 13 Feb 2014 14:14:08 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Tue, 2014-01-21 at 11:10 +0100, Andreas Färber wrote:
Am 21.01.2014 10:51, schrieb Chen Fan:
On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov
On Mon, 17 Feb 2014 18:24:09 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Thu, 2014-02-13 at 10:44 +0100, Igor Mammedov wrote:
On Thu, 13 Feb 2014 14:14:08 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Tue, 2014-01-21 at 11:10 +0100, Andreas Färber wrote:
Am
On 02/17/2014 11:15 AM, Cedric Bosdonnat wrote:
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific cfg-relaxedACS handling to be a flag, and pass it to hostdev
functions.
Signed-off-by: Chunyan Liu
On 02/17/2014 10:31 AM, Cedric Bosdonnat wrote:
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -59,7 +59,10 @@ struct _virPCIDevice {
char name[PCI_ADDR_LEN]; /* domain:bus:slot.function */
char id[PCI_ID_LEN]; /* product vendor */
char
On 02/17/2014 08:32 AM, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific COLD_BOOT handling to be a flag, and pass it to hostdev functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |6 +++---
On 13.02.2014 13:53, Michal Privoznik wrote:
On 13.02.2014 12:40, Laine Stump wrote:
On 02/04/2014 05:49 PM, Michal Privoznik wrote:
This new flag is to be used for tainting domains which
XML definition was altered at runtime by a hook script.
Signed-off-by: Michal Privoznik
On 13.02.2014 19:33, John Ferlan wrote:
Recent autotest/virt-test testing on f20 discovered an anomaly in how
the bandwidth options are documented and used. This was discovered due
to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20)
in which overflow was actually caught and
On 02/17/2014 11:38 AM, Cedric Bosdonnat wrote:
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
original paring VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT in hostdev function to
qemuDomainDeviceDefPostParse.
typo:
On Mon, Feb 17, 2014 at 12:55:25AM +0400, Гусев Павел wrote:
Hi!
I found little semantics bug:
[13:53:40] root@dedicated-04:~ # LC_ALL=C libvirtd -h
libvirtd: invalid option -- 'h'
Usage:
libvirtd [options]
Options:
-v | --verbose Verbose messages.
-d | --daemon
Hi!
I found little semantics bug:
[13:53:40] root@dedicated-04:~ # LC_ALL=C libvirtd -h
libvirtd: invalid option -- 'h'
Usage:
libvirtd [options]
Options:
-v | --verbose Verbose messages.
-d | --daemon Run as a daemon write PID file.
-l | --listen Listen for
h5a name=elementVlanTagSetting VLAN tag (on supported network
types only)/a/h5
diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 1ca1bec..d4c390a 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.html.in
@@ -412,40 +412,81 @@
p
Thanks for your answer!
I am use virsh 1.1.1 in Linux Mint 16 cinnamon.
I must upgrade virsh to 1.1.3. Thank you!)
С уважением,
Гусев Павел
Руководитель отдела системного администрирования
QSOFT | Ведущий web-интегратор
офис 7(495) 771-7363 #110 | моб. 7(926) 850-1108
pgu...@qsoft.ru
Москва,
An update of
https://www.redhat.com/archives/libvir-list/2014-February/msg00401.html
Eric had previously suggested that we could have our fork helper pass
by a pre-opened file descriptor and then label that, so we can move
the labelling code out of the subprocess. While I believe that is
Implement virProcessRunInMountNamespace, which runs callback of type
virProcessNamespaceCallback in a container namespace. This uses a
child process to run the callback, since you can't change the mount
namespace of a thread. This implies that callbacks have to be careful
about what code they run
Add a helper function which takes a file path and ensures
that all directory components leading up to the file exist.
IOW, it strips the filename part of the path and passes
the result to virFileMakePath.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 1 +
From: Eric Blake ebl...@redhat.com
Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and
lxcDomainReboot. Otherwise, a malicious guest could use symlinks
to force the host to manipulate the wrong file in the host's namespace.
Idea by Dan Berrange, based on an initial report by
Rewrite lxcDomainAttachDeviceHostdevStorageLive function
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Rewrite lxcDomainAttachDeviceHostdevMisceLive function
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Rewrite lxcDomainAttachDeviceDiskLive function to use the
virProcessRunInMountNamespace helper. This avoids risk of
a malicious guest replacing /dev with a absolute symlink,
tricking the driver into changing the host OS filesystem.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Rewrite lxcDomainAttachDeviceHostdevSubsysUSBLive function
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
Rewrite multiple hotunplug functions to to use the
virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Thu, Feb 13, 2014 at 02:14:32PM +0400, Roman Bogorodskiy wrote:
+static int
+bhyveBuildDiskArgStr(const virDomainDef *def, virCommandPtr cmd)
+{
+virDomainDiskDefPtr disk;
+
+if (def-ndisks != 1) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED, %s,
+
On 02/16/2014 07:32 AM, Daniel Veillard wrote:
Since February ends up on the 28, I think it makes sense to
enter the freeze for 1.2.2 next week-end if we want to have
it by the end of the month, so please try to get features pushed
this week, well if you want them in the next release,
On Mon, Feb 17, 2014 at 11:08:49AM -0700, Eric Blake wrote:
On 02/16/2014 07:32 AM, Daniel Veillard wrote:
Since February ends up on the 28, I think it makes sense to
enter the freeze for 1.2.2 next week-end if we want to have
it by the end of the month, so please try to get features
Daniel P. Berrange wrote:
+virCommandAddArg(cmd, -s);
+virCommandAddArgFormat(cmd, 2:0,ahci-hd,%s, disk-src);
What is the '2:0' bit here ? Is that disk controller/unit
number ?
Quoting the manpage [1]:
pcislot[:function]
The pcislot value is 0 to
On 02/13/2014 03:14 AM, Roman Bogorodskiy wrote:
At this point it has a limited functionality and is highly
experimental. Supported domain operations are:
* define
* start
* destroy
* dumpxml
* dominfo
* undefine
It's only possible to have only one disk device and only one
On 02/17/2014 09:38 AM, Daniel P. Berrange wrote:
Add a helper function which takes a file path and ensures
that all directory components leading up to the file exist.
IOW, it strips the filename part of the path and passes
the result to virFileMakePath.
Signed-off-by: Daniel P. Berrange
On 02/17/2014 09:38 AM, Daniel P. Berrange wrote:
Implement virProcessRunInMountNamespace, which runs callback of type
virProcessNamespaceCallback in a container namespace. This uses a
child process to run the callback, since you can't change the mount
namespace of a thread. This implies that
On 02/17/2014 09:38 AM, Daniel P. Berrange wrote:
From: Eric Blake ebl...@redhat.com
Use helper virProcessRunInMountNamespace in lxcDomainShutdownFlags and
lxcDomainReboot. Otherwise, a malicious guest could use symlinks
to force the host to manipulate the wrong file in the host's
On 02/17/2014 09:38 AM, Daniel P. Berrange wrote:
Rewrite lxcDomainAttachDeviceDiskLive function to use the
virProcessRunInMountNamespace helper. This avoids risk of
a malicious guest replacing /dev with a absolute symlink,
tricking the driver into changing the host OS filesystem.
On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
Rewrite lxcDomainAttachDeviceHostdevSubsysUSBLive function
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
Rewrite lxcDomainAttachDeviceHostdevStorageLive function
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
filesystem.
On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
Rewrite multiple hotunplug functions to to use the
virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
s/a absolute/an absolute/
symlink, tricking the driver into changing the host OS
On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
Rewrite lxcDomainAttachDeviceHostdevMisceLive function
s/Misce/Misc/
to use the virProcessRunInMountNamespace helper. This avoids
risk of a malicious guest replacing /dev with a absolute
symlink, tricking the driver into changing the host OS
On Mon, Feb 17, 2014 at 11:08:49AM -0700, Eric Blake wrote:
On 02/16/2014 07:32 AM, Daniel Veillard wrote:
Since February ends up on the 28, I think it makes sense to
enter the freeze for 1.2.2 next week-end if we want to have
it by the end of the month, so please try to get features
Hi. Any opinions on this?
At Thu, 13 Feb 2014 14:50:08 +0100,
Claudio Bley wrote:
Hi.
When calling virDomainGetMaxVcpus
(http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMaxVcpus) on
an inactive domain, I receive this error:
scala res2.getMaxVcpus()
libvirt: Domain Config
57 matches
Mail list logo