When start a guest with --pass-fd, if the argument of --pass-fd is invalid,
virsh will exit, but doesn't free the variable 'dom'.
The valgrind said:
...
==24569== 63 (56 direct, 7 indirect) bytes in 1 blocks are definitely lost in
loss record 130 of 234
==24569==at 0x4C2A1D4: calloc (in
IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW:
error: missing braces around initializer [-Werror=missing-braces]
.sin6_addr = IN6ADDR_ANY_INIT,
Use the in6addr_any variable instead.
Reported by Daniel P. Berrange.
---
Pushed as a build breaker.
On 14.02.2014 16:42, Richard Weinberger wrote:
Destroying a suspended domain needs special action.
We cannot simply terminate all process because they are frozen.
Do deal with that we send them SIGKILL and thaw them.
Upon wakeup the process sees the pending signal and dies immediately.
On 02/19/2014 09:36 PM, Daniel P. Berrange wrote:
From: Manuel VIVES manuel.vi...@diateam.net
Add a virStringSearch method to virstring.{c,h} which performs
a regex match against a string and returns the matching substrings.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 02/19/2014 09:36 PM, Daniel P. Berrange wrote:
Add a virStringReplace method to virstring.{h,c} to perform
substring matching and replacement
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virstring.c | 44
On 02/20/2014 02:29 AM, Jincheng Miao wrote:
When start a guest with --pass-fd, if the argument of --pass-fd is invalid,
virsh will exit, but doesn't free the variable 'dom'.
+++ b/tools/virsh-domain.c
@@ -3428,11 +3428,11 @@ cmdStart(vshControl *ctl, const vshCmd *cmd)
if
The coverity server found issue in gvir_stream_close function that
we ignore return values of g_input_stream_close and
g_outpu_stream_close, but we also ignore the error message and we
assume that it's closed without error.
Now we will check return values and also propagate the error message
to
On 02/20/2014 05:38 AM, Eric Blake wrote:
[adding gnulib]
On 02/20/2014 02:39 AM, Ján Tomko wrote:
IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW:
error: missing braces around initializer [-Werror=missing-braces]
.sin6_addr = IN6ADDR_ANY_INIT,
Use the
On 01/29/2014 12:04 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1038363
If a domain has a different maximum for persistent and live maxmem
or max vcpus, then it is possible to hit cases where libvirt
refuses to adjust the current values or gets halfway through
the
On 02/14/2014 05:21 PM, Eric Blake wrote:
Inspired by my work on qemu monitor events; Dan correctly argued
that if we're going to expose those through virsh, we also need
to expose regular events. Patch 5/4 still coming, which adds
handlers for the remaining 15 domain event types.
Ping - I'd
On 12/18/2013 05:22 AM, Daniel P. Berrange wrote:
Wow, this one has sat for a while.
The virDomainGetRootFilesystem method can be generalized to allow
any filesystem path to be obtained.
While doing this, start a new test case for purpose of testing various
helper methods in the
On 01/01/2014 03:44 PM, Eric Blake wrote:
In my recent work on events, I'm running into something where I'm
stumped on timing behavior. I'm using
virEventRegisterDefaultImpl()/virEventRunDefaultImpl() as my event loop,
and trying to test that an event is firing correctly.
Ping. I'm not
Hi,
with my recent work into snapshots with native libgfapi support I've run
into an issue with libvirt APIs used to delete snapshots by management apps.
The management apps use the APIs to do the job:
int
virDomainBlockCommit(virDomainPtr dom, const char *disk,
const char
Hey,
On Thu, Feb 20, 2014 at 01:49:31PM +0100, Pavel Hrdina wrote:
The coverity server found issue in gvir_stream_close function that
we ignore return values of g_input_stream_close and
g_outpu_stream_close, but we also ignore the error message and we
missing 't' in g_output_stream_close
On Thu, Feb 20, 2014 at 02:46:03PM +0100, Peter Krempa wrote:
Hi,
with my recent work into snapshots with native libgfapi support I've run
into an issue with libvirt APIs used to delete snapshots by management apps.
The management apps use the APIs to do the job:
int
On Thu, Feb 20, 2014 at 02:46:03PM +0100, Peter Krempa wrote:
As you can see in the prototypes of these functions (and from the docs
for them which I'm not going to copy here) the user can provide the disk
specification in two possible options:
1) a full path if it's unambiguous - this is
On 02/18/2014 07:16 PM, John Ferlan wrote:
Because I know it's easier to read without all the git +/-, here's what
I have now in the QoS section on the formatnetwork (hopefully I've
captured everything correctly):
This all looks fine. ACK.
The bandwidth element allows setting quality of
On 20.2.2014 15:07, Christophe Fergeau wrote:
Hey,
On Thu, Feb 20, 2014 at 01:49:31PM +0100, Pavel Hrdina wrote:
The coverity server found issue in gvir_stream_close function that
we ignore return values of g_input_stream_close and
g_outpu_stream_close, but we also ignore the error message and
On 02/04/2014 05:23 PM, Jiri Denemark wrote:
On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote:
Hi,
using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to
occasional segmentation faults (see below).
Sometimes it runs for 5 minutes, sometimes for an hour, but after
On Thu, Feb 20, 2014 at 03:57:00PM +0100, Pavel Hrdina wrote:
On 20.2.2014 15:07, Christophe Fergeau wrote:
@@ -102,17 +102,33 @@ static GOutputStream*
gvir_stream_get_output_stream(GIOStream *io_stream)
static gboolean gvir_stream_close(GIOStream *io_stream,
On Fri, Feb 14, 2014 at 06:48:59PM +0100, Thorsten Behrens wrote:
This reads blkio stats from blkio.throttle.io_service_bytes and
blkio.throttle.io_serviced.
---
src/libvirt_private.syms | 2 +
src/util/vircgroup.c | 254
+++
On Fri, Feb 14, 2014 at 06:49:05PM +0100, Thorsten Behrens wrote:
---
Notes to v4:
- share fake disk device path via header file instead of env var
tests/testutilslxc.h | 3 ++
tests/vircgroupmock.c | 98 +-
tests/vircgrouptest.c | 129
On 14.02.2014 18:49, Thorsten Behrens wrote:
---
Notes to v4:
- share fake disk device path via header file instead of env var
tests/testutilslxc.h | 3 ++
tests/vircgroupmock.c | 98 +-
tests/vircgrouptest.c | 129
On 14.02.2014 18:49, Thorsten Behrens wrote:
And provide domain summary stat in that case, for lxc backend.
Use case is a container inheriting all devices from the host,
e.g. when doing application containerization.
---
src/libvirt.c| 8 ++--
tools/virsh-domain-monitor.c
On 14.02.2014 18:49, Thorsten Behrens wrote:
---
Notes to v4:
- check errors before filling param array
- UL-ULL change punted to separate patch
src/lxc/lxc_driver.c | 56
1 file changed, 56 insertions(+)
diff --git
On 14.02.2014 18:49, Thorsten Behrens wrote:
Adds lxcDomainBlockStatsFlags and lxcDomainBlockStats functions.
---
src/lxc/lxc_driver.c | 195 +++
1 file changed, 195 insertions(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index
On 14.02.2014 18:48, Thorsten Behrens wrote:
This patch set adds block io, memory and domain cpu statistics API
slot implementations to the LXC driver, in order to get linux
container monitoring and accounting a bit closer to qemu standards.
The last patch is a tad quirky (happy to hear
On Fri, Feb 14, 2014 at 06:49:00PM +0100, Thorsten Behrens wrote:
---
Notes to v4:
- check errors before filling param array
- UL-ULL change punted to separate patch
src/lxc/lxc_driver.c | 56
1 file changed, 56 insertions(+)
The virCgroupXXX APIs' return value must be checked for
being less than 0, not equal to 0.
An VIR_ERR_OPERATION_INVALID error must also be raised
when the VM is not running to prevent a crash on NULL
priv-cgroup field.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 02/20/2014 07:37 AM, Daniel P. Berrange wrote:
2) Export the image chain in the XML and allow to use indexed disk names
This option would require to export the backing chain in the XML in some
way, either the existing disk source specification in multiple elements
(which I don't like as it
On 02/20/2014 08:26 AM, Michal Privoznik wrote:
On 14.02.2014 18:49, Thorsten Behrens wrote:
And provide domain summary stat in that case, for lxc backend.
Use case is a container inheriting all devices from the host,
e.g. when doing application containerization.
---
src/libvirt.c
On 20.02.2014 16:34, Daniel P. Berrange wrote:
The virCgroupXXX APIs' return value must be checked for
being less than 0, not equal to 0.
An VIR_ERR_OPERATION_INVALID error must also be raised
when the VM is not running to prevent a crash on NULL
priv-cgroup field.
Signed-off-by: Daniel P.
The coverity server found issue in gvir_stream_close function that
we ignore return values of g_input_stream_close and
g_output_stream_close, but we also ignore the error message and we
assume that it's closed without error.
Now we will check return values and also propagate the error message
to
When enum type has '_LAST' in its name, but is not the last type in
that enum, it's skipped even though it shouldn't be. Currently, this
is the case for only VIR_NETWORK_UPDATE_COMMAND_ADD_LAST inside an
enum virNetworkUpdateCommand.
Also, since _LAST types can have other enums instead of
On Thu, Feb 20, 2014 at 05:15:08PM +0100, Martin Kletzander wrote:
When enum type has '_LAST' in its name, but is not the last type in
that enum, it's skipped even though it shouldn't be. Currently, this
is the case for only VIR_NETWORK_UPDATE_COMMAND_ADD_LAST inside an
enum
The TAP harness for glib only works with version 2.38 or later,
so must be disabled for earlier versions
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
configure.ac | 8 +++-
tests/Makefile.am | 18 ++
2 files changed, 21 insertions(+), 5 deletions(-)
diff
On Fri, Feb 14, 2014 at 05:21:38PM -0700, Eric Blake wrote:
Several virsh commands ask for a --timeout parameter in
seconds, then use it to control interfaces that operate on
millisecond limits; I also plan on adding a 'virsh event'
command that also does this. Factor this into a common
On Fri, Feb 14, 2014 at 05:21:39PM -0700, Eric Blake wrote:
I plan to add 'virsh event' to virsh-domain.c and 'virsh
net-event' to virsh-network.c; but as they will share quite
a bit of common boilerplate, it's better to set that up now
in virsh.c.
* tools/virsh.h (_vshControl): Add fields.
On Fri, Feb 14, 2014 at 05:21:40PM -0700, Eric Blake wrote:
Add 'virsh event --list' and 'virsh event [dom] --event=name
[--loop] [--timeout]'. Borrows somewhat from event-test.c,
but defaults to a one-shot notification, and takes advantage
of the event loop integration to allow Ctrl-C to
On Fri, Feb 14, 2014 at 05:21:41PM -0700, Eric Blake wrote:
Add 'virsh net-event --list' and 'virsh net-event [net] --event=name
[--loop] [--timeout]'. Very similar to 'virsh event'.
* tools/virsh.pod (net-event): Document new command.
* tools/virsh-network.c (vshNetworkEventToString,
On Wed, Jan 29, 2014 at 12:04:32PM -0700, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1038363
If a domain has a different maximum for persistent and live maxmem
or max vcpus, then it is possible to hit cases where libvirt
refuses to adjust the current values or gets halfway
On Wed, Jan 01, 2014 at 03:44:10PM -0700, Eric Blake wrote:
In my recent work on events, I'm running into something where I'm
stumped on timing behavior. I'm using
virEventRegisterDefaultImpl()/virEventRunDefaultImpl() as my event loop,
and trying to test that an event is firing correctly.
On Thu, Feb 20, 2014 at 06:17:31AM -0700, Eric Blake wrote:
On 12/18/2013 05:22 AM, Daniel P. Berrange wrote:
Wow, this one has sat for a while.
The virDomainGetRootFilesystem method can be generalized to allow
any filesystem path to be obtained.
While doing this, start a new test
On 02/20/2014 10:33 AM, Daniel P. Berrange wrote:
On Fri, Feb 14, 2014 at 05:21:40PM -0700, Eric Blake wrote:
Add 'virsh event --list' and 'virsh event [dom] --event=name
[--loop] [--timeout]'. Borrows somewhat from event-test.c,
but defaults to a one-shot notification, and takes advantage
On Thu, Feb 20, 2014 at 11:06:55AM -0700, Eric Blake wrote:
On 02/20/2014 10:33 AM, Daniel P. Berrange wrote:
On Fri, Feb 14, 2014 at 05:21:40PM -0700, Eric Blake wrote:
Add 'virsh event --list' and 'virsh event [dom] --event=name
[--loop] [--timeout]'. Borrows somewhat from event-test.c,
On 02/20/2014 11:14 AM, Daniel P. Berrange wrote:
+case VIR_DOMAIN_EVENT_DEFINED:
+ret = _(Defined);
+break;
How about using VIR_ENUM ?
We avoided it in the event-test.c file since we wanted it to
be example code people can compile outside libvirt. Using
enums would
On 02/20/2014 10:38 AM, Daniel P. Berrange wrote:
On Wed, Jan 29, 2014 at 12:04:32PM -0700, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1038363
If a domain has a different maximum for persistent and live maxmem
or max vcpus, then it is possible to hit cases where libvirt
Eric Blake wrote:
On 02/19/2014 07:54 PM, Jim Fehlig wrote:
Commit e4a0e900 missed calling libxlVmCleanupJob in the shutdown
handler when processing a reboot event.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1
Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
OK, how about this patch?
While at it, should I convert the VIR_DOMAIN_VCPU_* instances to
VIR_DOMAIN_AFFECT_* instances for consistency?
src/esx/esx_driver.c |2 +-
src/openvz/openvz_driver.c |2 +-
Hi Michal,
thx for further cleaning up, and pushing -
Michal Privoznik wrote:
+if (!virCgroupGetMemoryUsage(priv-cgroup, mem_usage))
+goto cleanup;
+
+ret = 0;
+if (!virDomainObjIsActive(vm))
+goto cleanup;
I think these two lines (well three), otherwise we
This series is the result of a report from Kim Larry [1] about missing
shutdown events in the libxl driver. Kim's report revealed that the
libxl driver was ignoring the on_* domain lifecycle event configuration!
Patch1 adds support for the four standard actions (destroy, restart,
preserve, and
The libxl driver was ignoring the on_* domain event configuration,
causing e.g. a domain to be rebooted even when on_reboot is set to
destroy.
This patch honors the on_* configuration in the shutdown event
handler.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 83
The shutdown handler may restart a domain when handling a reboot
event or when on_* is set to 'restart'. Restarting consists of
calling libxlVmCleanup followed by libxlVmStart. libxlVmStart will
emit a VIR_DOMAIN_EVENT_STARTED event, but the SHUTDOWN event is
not emitted until exiting the
Add support for coredump-{destroy,restart} actions of on_crash event.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 50
1 file changed, 50 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
Without a libxl config file, I suppose the only thing needed here is
the #define in libxl_conf.h. But I have a dusty series adding lockd
support to the libxl driver, which I'll be cleaning off soon. That
series introduces libxl.conf, and can be
Jim Fehlig wrote:
Cole Robinson wrote:
On 02/18/2014 10:45 PM, Jim Fehlig wrote:
Cole Robinson wrote:
On 02/18/2014 05:12 AM, Kim Larry wrote:
The thing I found today is that if libvirt uses xend driver, shutdown
events
are delivered, but
Hi,
Thanks for libvirt. It is a life saver. I am in the process of writing some
custom wrappers for libvirt so that it can be easily accessed from nodejs
using the nodejs-ffi interfacing (basically describes a way to convert
nodejs to c calls). I did write the wrapper on the lines of the examples
Among other things, gnulib now allows overriding of sed during
'make syntax-check'.
* .gnulib: Update to latest, for maint.mk improvements.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Pushing under the maintainer rule, before we freeze. I still need
to revive Roman's work on using $(SED)
Jim Fehlig wrote:
The libxl driver was ignoring the on_* domain event configuration,
causing e.g. a domain to be rebooted even when on_reboot is set to
destroy.
This patch honors the on_* configuration in the shutdown event
handler.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
- Original Message -
On 02/20/2014 02:29 AM, Jincheng Miao wrote:
When start a guest with --pass-fd, if the argument of --pass-fd is invalid,
virsh will exit, but doesn't free the variable 'dom'.
+++ b/tools/virsh-domain.c
@@ -3428,11 +3428,11 @@ cmdStart(vshControl *ctl,
On Thu, Feb 20, 2014 at 04:19:54PM +, Daniel P. Berrange wrote:
On Thu, Feb 20, 2014 at 05:15:08PM +0100, Martin Kletzander wrote:
When enum type has '_LAST' in its name, but is not the last type in
that enum, it's skipped even though it shouldn't be. Currently, this
is the case for
61 matches
Mail list logo
