[libvirt] [Question] Will we support to set boot order online?

2014-03-03 Thread Wangyufei (James)
Hello, I find that QEMU supports to set boot(QMP command boot_set) order online, namely the virtual machine can be reboot in appointed order, but libvirt had no corresponding interface. So, I want to know if libvirt intend to support to set boot order online. If the answer is yes, I'll try

[libvirt] [PATCH] Bump version to 1.2.3 for new dev cycle

2014-03-03 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f30ac76..a9339ce 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU

Re: [libvirt] [PATCH] Bump version to 1.2.3 for new dev cycle

2014-03-03 Thread Ján Tomko
On 03/03/2014 09:44 AM, Michal Privoznik wrote: Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK, trivial: https://www.redhat.com/archives/libvir-list/2014-January/msg00718.html Jan signature.asc Description:

Re: [libvirt] [PATCH] Bump version to 1.2.3 for new dev cycle

2014-03-03 Thread Michal Privoznik
On 03.03.2014 09:51, Ján Tomko wrote: On 03/03/2014 09:44 AM, Michal Privoznik wrote: Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK, trivial:

Re: [libvirt] [PATCH] Check if systemd is the init before creating machines

2014-03-03 Thread Ján Tomko
On 02/28/2014 06:36 PM, Daniel P. Berrange wrote: On Thu, Feb 27, 2014 at 09:29:24PM +0100, Ján Tomko wrote: If systemd is installed, but not the init system, systemd-machined fails with an unhelpful error message: Launch helper exited with unknown return code 1 Fall back to manual cgroup

Re: [libvirt] [PATCH] Check if systemd is the init before creating machines

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 10:35:36AM +0100, Ján Tomko wrote: On 02/28/2014 06:36 PM, Daniel P. Berrange wrote: On Thu, Feb 27, 2014 at 09:29:24PM +0100, Ján Tomko wrote: If systemd is installed, but not the init system, systemd-machined fails with an unhelpful error message: Launch helper

Re: [libvirt] [Question] Will we support to set boot order online?

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 08:22:13AM +, Wangyufei (James) wrote: Hello, I find that QEMU supports to set boot(QMP command boot_set) order online, namely the virtual machine can be reboot in appointed order, but libvirt had no corresponding interface. So, I want to know if libvirt

[libvirt] [PATCH v2 4/5] add support for apparmor in lxc-enter-namespace

2014-03-03 Thread Cédric Bosdonnat
--- examples/apparmor/libvirt-lxc | 7 +++ src/libvirt-lxc.c | 13 + 2 files changed, 20 insertions(+) diff --git a/examples/apparmor/libvirt-lxc b/examples/apparmor/libvirt-lxc index 47f27b1..d404328 100644 --- a/examples/apparmor/libvirt-lxc +++

[libvirt] [PATCH v2 1/5] LXC driver: generate apparmor profiles for guests

2014-03-03 Thread Cédric Bosdonnat
From: Cédric Bosdonnat cedric.bosdon...@free.fr use_apparmor() was first designed to be called from withing libvirtd, but libvirt_lxc also uses it. in libvirt_lxc, there is no need to check whether to use apparmor or not: just use it if possible. --- examples/apparmor/Makefile.am| 2 ++

[libvirt] [PATCH v2 2/5] Make sure apparmor is started before libvirtd

2014-03-03 Thread Cédric Bosdonnat
If apparmor security driver is enabled in either qemu or lxc driver configuration and libvirtd starts before AppArmor, it will fail. --- daemon/libvirtd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in index e1f2a07..086da36

[libvirt] [PATCH v2 0/5] AppArmor support for lxc containers

2014-03-03 Thread Cédric Bosdonnat
This is a repost of the previous patch series, with the following changes: * Dropped the patch setting none security driver as default in lxc.conf * Add a patch to implement support for none type with apparmor security model. Cédric Bosdonnat (5): LXC driver: generate apparmor profiles for

[libvirt] [PATCH v2 5/5] apparmor: handle none type

2014-03-03 Thread Cédric Bosdonnat
--- src/security/security_apparmor.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 1c1b128..a74a91c 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@

[libvirt] [PATCH v2 3/5] apparmor: add debug traces when changing profile.

2014-03-03 Thread Cédric Bosdonnat
The reason for these is that aa-status doesn't show the process using the profile as they are in another namespace. --- src/security/security_apparmor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index

Re: [libvirt] [PATCH v2] qemu: cleanup tap devices on FreeBSD

2014-03-03 Thread Laine Stump
On 02/27/2014 12:37 PM, Roman Bogorodskiy wrote: We have to explicitly destroy TAP devices on FreeBSD because they're not freed after being closed, otherwise we end up with orphaned TAP devices after destroying a domain. --- src/qemu/qemu_process.c | 7 +++ src/util/virnetdevtap.h | 6

[libvirt] lxc: shutdown $domain broken in 1.2.2

2014-03-03 Thread Stephan Sachse
host: centos-6.5 kernel: 3.13.2-4.el6.x86_64 guest: fedora20 since libvirt-1.2.2 i can not shutdown this domain. works fine with libvirt-1.2.1 # virsh shutdown fedora2 error: Failed to shutdown domain fedora2 error: Mount namespaces are not available on this platform: Function not implemented

Re: [libvirt] [Question] Will we support to set boot order online?

2014-03-03 Thread Jiri Denemark
On Mon, Mar 03, 2014 at 09:58:40 +, Daniel Berrange wrote: On Mon, Mar 03, 2014 at 08:22:13AM +, Wangyufei (James) wrote: Hello, I find that QEMU supports to set boot(QMP command boot_set) order online, namely the virtual machine can be reboot in appointed order, but libvirt

[libvirt] [PATCH] Replace space with a tab in the Makefile

2014-03-03 Thread Ján Tomko
All the other test_programs in the section use tabs and virportallocatortest sticks out with tab width other than 8. --- Pushed as trivial. tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1b752b2..cd91734 100644

Re: [libvirt] [PATCHv2 0/2] Add virusbtest

2014-03-03 Thread Ján Tomko
On 02/28/2014 11:15 AM, Michal Privoznik wrote: On 28.02.2014 11:10, Ján Tomko wrote: v1: https://www.redhat.com/archives/libvir-list/2014-February/msg01620.html v2: Split the mocked part into a separate file and only build the test on Linux. Remove 'serial' files. Get out of testDeviceFind

[libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for arm

2014-03-03 Thread Oleg Strikov
Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to arm-specific code to handle this request (no actual work is done). Signed-off-by: Oleg Strikov oleg.stri...@canonical.com --- This is a port of the

Re: [libvirt] [PATCH 4/4] qemu: add unit tests for the capabilities xml

2014-03-03 Thread Francesco Romani
- Original Message - From: Eric Blake ebl...@redhat.com To: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Friday, February 28, 2014 12:49:25 AM Subject: Re: [libvirt] [PATCH 4/4] qemu: add unit tests for the capabilities xml On 01/17/2014 08:31 AM, Francesco

Re: [libvirt] Libvirt Java Bindings - adding domain event support - pull request

2014-03-03 Thread Claudio Bley
At Thu, 27 Feb 2014 03:47:31 +, Chris Ellis wrote: Hi all I'm new to this list, I've been making use of the Libvirt Java bindings recently. I wanted to make use of domain events yesterday so my application can be alerted when the state of a domain changes etc. However I quickly

[libvirt] [PATCH] dnsmasq: allowing RFC 2782 compliant srv records

2014-03-03 Thread Steven Malin
Hello, I want to provide a patch which allows RFC 2782 compliant dns srv records in the network configs. If you have questions, please contact me. Kind Regards, Steven Malin --- src/conf/network_conf.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Claudio Bley
At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: ACK, if you also add the virEventUpdateTimeout method OK, but why should I add it? It's useless (for the user) and unused by the wrapping code. I want to keep the JNA library definition clean -- e.g. in a later patch I remove all

[libvirt] [PATCHv2 1/2] Split out most of virDBusIsServiceEnabled

2014-03-03 Thread Ján Tomko
Introduce virDBusIsServiceInList which can be used to call other methods for listing services (ListNames), not just ListActivatableNames. No functional change. --- src/util/virdbus.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: ACK, if you also add the virEventUpdateTimeout method OK, but why should I add it? It's useless (for the user) and unused by the wrapping code. I want to keep the

[libvirt] [PATCHv2 2/7] storage: Use cleanup label instead of out

2014-03-03 Thread Peter Krempa
--- src/storage/storage_driver.c | 89 ++-- 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index e0ebdb0..942ba35 100644 --- a/src/storage/storage_driver.c +++

[libvirt] [PATCHv2 1/7] virsh: volume: Fix lookup of volumes to provide better error messages

2014-03-03 Thread Peter Krempa
If a user specifies the pool explicitly, we should make sure to point out that it's inactive instead of falling back to lookup by key/path and failing at the end. Also if the pool isn't found there's no use in continuing the lookup. This changes the error in case the user-selected pool is

[libvirt] [PATCHv2 4/7] storage: Avoid mangling paths of non-local filesystems when looking up

2014-03-03 Thread Peter Krempa
When looking up a volume by path on a non-local filesystem don't use the cleaned path that might be mangled in such a way that it will differ from a path provided by a storage backend. Skip the cleanup step for gluster, sheepdog and RBD. --- src/storage/storage_driver.c | 82

[libvirt] [PATCHv2 3/7] storage: Error out when attempting to vol-upload into a remote pool

2014-03-03 Thread Peter Krempa
Pools that are not backed by files in the filesystem cause problems with some APIs. Error out when attempting to upload a volume in such a pool as currently we expect a local file representation for it. --- src/storage/storage_driver.c | 31 +-- 1 file changed, 25

[libvirt] [PATCHv2 6/7] doc: storage: Explicitly state that it's possible to have non-unique key

2014-03-03 Thread Peter Krempa
With most of our storage backends it's possible to have two separate volume keys to point to a single volume. (By creating sym/hard-links to local files or by mounting remote filesystems to two different locations and creating pools on top of them) Document this possibility. ---

[libvirt] [PATCHv2 0/7] various fixes related to gluster volumes

2014-03-03 Thread Peter Krempa
Peter Krempa (7): virsh: volume: Fix lookup of volumes to provide better error messages storage: Use cleanup label instead of out storage: Error out when attempting to vol-upload into a remote pool storage: Avoid mangling paths of non-local filesystems when looking up storage: Don't lie

[libvirt] [PATCHv2 5/7] storage: Don't lie about path used to look up in error message

2014-03-03 Thread Peter Krempa
In storageVolLookupByPath the provided path is sanitized at first. This removes some extra slashes and stuff. When the lookup of the volume fails the original path is used which makes it hard to trace errors in some cases. Improve the error message to print the sanitized path along with the user

Re: [libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for arm

2014-03-03 Thread Cole Robinson
On 03/03/2014 08:41 AM, Oleg Strikov wrote: Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to arm-specific code to handle this request (no actual work is done). Signed-off-by: Oleg Strikov

[libvirt] [PATCHv8 0/2] Implement RBD storage pool support

2014-03-03 Thread Adam Walters
This is an updated version of my RBD storage pool support patch. Relevant changes since v7 are: - Fixed bug where I compared disk-srcpool-mode to VIR_DOMAIN_DISK_TYPE_NETWORK In response to a couple of items Ján mentioned, I decided not to pursue adding anything to qemuxml2argvtest. The reason

[libvirt] [PATCHv8 1/2] qemu: conf Implement domain RBD storage pool support

2014-03-03 Thread Adam Walters
This patch adds a helper function, qemuAddRBDPoolSourceHost, and implements the usage of this function to allow RBD storage pools in QEMU domain XML. The new function grabs RBD monitor hosts from the storage pool definition and applies them to the domain's disk definition at runtime. This

[libvirt] [PATCHv8 2/2] domain: conf: Fix secret type checking for network volumes

2014-03-03 Thread Adam Walters
This patch fixes the secret type checking done in the virDomainDiskDefParseXML function. Previously, it would not allow any volumes that utilized a secret. This patch is a simple bypass of the checking code for volumes. Signed-off-by: Adam Walters a...@pandorasboxen.com ---

Re: [libvirt] [PATCH v13 00/49] write separate module for hostdev passthrough

2014-03-03 Thread Cedric Bosdonnat
Hello ChunYan, I saw a few minor problems in some patches that made me rebase quite a lot of other patches in your serie, but otherwise it really looks good to me. Here is a summary of the changes I made or questions I have: * Patch 2: Fixed a few remaining changes that broke the build.

[libvirt] [PATCH 1/2] tests: Create privileged driver config in qemuxml2argvtest

2014-03-03 Thread Martin Kletzander
This is actaully a proper setting since we're not checking session-mode related XMLs. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/qemuxml2argvtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index

[libvirt] [PATCH v2 1/2] virNetServer: Introduce unauth clients counter

2014-03-03 Thread Michal Privoznik
The counter gets incremented on each unauthenticated client added to the server and decremented whenever the client authenticates. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c| 21 + src/rpc/virnetserver.c | 36

[libvirt] [PATCH 2/2] qemu: Reject unsupported tuning in session mode

2014-03-03 Thread Martin Kletzander
When domain is started with setting that cannot be done, i.e. those that require cgroups, there is no error reported and it succeeds without any message whatsoever. When setting with API, virsh, an error is reported, but only due to the fact that no cgroups are mounted (priv-cgroup == NULL).

[libvirt] [PATCH v2 0/2] Introduce max_anonymous_clients

2014-03-03 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=981729 So far we can limit how many clients are connected, how many are waiting in accept() line but we could not control the count of accepted but not authenticated yet. Michal Privoznik (2): virNetServer: Introduce unauth clients counter daemon:

[libvirt] [PATCH v2 2/2] daemon: Introduce max_anonymous_clients

2014-03-03 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=981729 This config tunable allows users to determine the maximum number of accepted but yet not authenticated users. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/libvirtd-config.c| 1 + daemon/libvirtd-config.h| 1 +

[libvirt] [PATCH] Don't always skip virportallocatortest

2014-03-03 Thread Ján Tomko
Include dlfcn.h before checking if RTLD_NEXT is defined --- tests/virportallocatortest.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/virportallocatortest.c b/tests/virportallocatortest.c index 5a93dad..fd48c11 100644 --- a/tests/virportallocatortest.c +++

[libvirt] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument isn't added to vm_config_groups[]. Current query-command-line-options only checkes options from vm_config_groups[], so some options will be lost. We have some macros in qemu-options.hx

[libvirt] [PCTCH v2 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-03 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index 9298f55..d624d92 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsList

[libvirt] [PCTCH v2 0/2] fix query-command-line-options

2014-03-03 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-develm=139081830416684w=2 V2: remove

Re: [libvirt] Compiling libvirt RPC client library for QNX

2014-03-03 Thread Panday Ritesh Sharma (rpanday)
On 01/03/14 9:39 AM, Panday Ritesh Sharma (rpanday) rpan...@cisco.com wrote: On 25/02/14 11:17 PM, Eric Blake ebl...@redhat.com wrote: On 02/25/2014 09:05 AM, Panday Ritesh Sharma (rpanday) wrote: We are using a wrapper of make for compilation for QNX. So I need to know, when I am

Re: [libvirt] Compiling libvirt RPC client library for QNX

2014-03-03 Thread Daniel P. Berrange
On Sat, Mar 01, 2014 at 04:09:00AM +, Panday Ritesh Sharma (rpanday) wrote: When I tried using 'gcc.c4.2.1-p2' for trial purpose, which is available to us, I hit the error === checking for gnutls_handshake in -lgnutls... no configure: error: You must install the GnuTLS library

Re: [libvirt] Compiling libvirt RPC client library for QNX

2014-03-03 Thread Panday Ritesh Sharma (rpanday)
On 04/03/14 12:09 AM, Daniel P. Berrange berra...@redhat.com wrote: On Sat, Mar 01, 2014 at 04:09:00AM +, Panday Ritesh Sharma (rpanday) wrote: When I tried using 'gcc.c4.2.1-p2' for trial purpose, which is available to us, I hit the error === checking for gnutls_handshake in

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-03 Thread Nehal J Wani
On Mon, Feb 24, 2014 at 5:27 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as interface-name.status. Each lease contains the following info:

[libvirt] [PATCH 0/7] Remove overhead of disabled logging calls

2014-03-03 Thread Daniel P. Berrange
Looking at the performance of the libvirtd event loop when used with libvirt sandbox and apps which do lots of I/O I discovered that a huge amount of time was being spent in our logging APIs making the event loop quite poor at dealing with frequently firing poll events for small data sizes. To

[libvirt] [PATCH 7/7] Remove global log buffer feature entirely

2014-03-03 Thread Daniel P. Berrange
A earlier commit changed the global log buffer so that it only records messages that are explicitly requested via the log filters setting. This removes the performance burden, and improves the signal/noise ratio for messages in the global buffer. At the same time though, it is somewhat pointless,

[libvirt] [PATCH 2/7] Refactor code that skips logging of error messages

2014-03-03 Thread Daniel P. Berrange
The virRaiseErrorFull method sends all error messages onto the logging code. The logging code has some logic to skip emission when no log outputs are configured which checks the virLogSource. This will complicate later refactoring, and the check can easily be done in the virRaiseErrorFull method

[libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-03 Thread Daniel P. Berrange
Currently the log filter strings are used in a string comparison against the source filename each time log message is emitted. If no log filters at all are set, there's obviously no string comparison to be done. If any single log filter is set though, this imposes a compute burden on every logging

[libvirt] [PATCH 4/7] Turn virLogSource into a struct instead of an enum

2014-03-03 Thread Daniel P. Berrange
As part of the goal to get away from doing string matching on filenames when deciding whether to emit a log message, turn the virLogSource enum into a struct which contains a log name. There will eventually be one virLogSource instance statically declared per source file. To minimise churn in this

Re: [libvirt] [PATCH 1/2] tests: Create privileged driver config in qemuxml2argvtest

2014-03-03 Thread Eric Blake
On 03/03/2014 10:21 AM, Martin Kletzander wrote: This is actaully a proper setting since we're not checking s/actaully/actually/ session-mode related XMLs. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/qemuxml2argvtest.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] Compiling libvirt RPC client library for QNX

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 06:49:25PM +, Panday Ritesh Sharma (rpanday) wrote: On 04/03/14 12:09 AM, Daniel P. Berrange berra...@redhat.com wrote: On Sat, Mar 01, 2014 at 04:09:00AM +, Panday Ritesh Sharma (rpanday) wrote: When I tried using 'gcc.c4.2.1-p2' for trial purpose,

Re: [libvirt] [PATCH] Don't always skip virportallocatortest

2014-03-03 Thread Martin Kletzander
On Mon, Mar 03, 2014 at 06:33:19PM +0100, Ján Tomko wrote: Include dlfcn.h before checking if RTLD_NEXT is defined --- tests/virportallocatortest.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) ACK Martin diff --git a/tests/virportallocatortest.c

[libvirt] [PATCH 3/7] Move dtrace probe macros into separate header file

2014-03-03 Thread Daniel P. Berrange
The dtrace probe macros rely on the logging API. We can't make the internal.h header include the virlog.h header though since that'd be a circular include. Instead simply split the dtrace probes into their own header file, since there's no compelling reason for them to be in the main internal.h

[libvirt] [PATCH 1/7] Reduce performance overhead of the global log buffer

2014-03-03 Thread Daniel P. Berrange
With the vast number of log debug statements in the code, the logging framework has a measurable performance impact on libvirt code, particularly in the daemon event loop. The global log buffer records every single log message triggered whether anyone cares to see them or not. This makes it

Re: [libvirt] [PATCH 00/10] virFork cleanups

2014-03-03 Thread Eric Blake
On 02/28/2014 05:40 AM, Michal Privoznik wrote: On 20.02.2014 06:13, Eric Blake wrote: Some of these patches were written while working on CVE-2013-6456; we decided to reorder things and fix that problem first. While rebasing these patches to the latest tree, I found other things worth

Re: [libvirt] [PATCH 1/3] nwfilter: Cap the poll timeout in the DHCP Snooping code

2014-03-03 Thread Eric Blake
On 03/02/2014 09:34 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Cap the poll timeout in the DHCP Snooping code to a max. of 10 seconds to not hold up the libvirt shutdown longer than this. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH 2/3] nwfilter: Display the pcap errror message

2014-03-03 Thread Eric Blake
On 03/02/2014 09:34 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Display the pcap error message in the log. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/nwfilter/nwfilter_dhcpsnoop.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH 3/3] nwfilter: Increase buffer size for libpcap

2014-03-03 Thread Eric Blake
On 03/02/2014 09:34 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Libpcap 1.5 requires a larger buffer than previous pcap versions. Adjust the size of the buffer to 128kb. This patch should address symptoms in BZ 1071181 and BZ 731059 Signed-off-by: Stefan

Re: [libvirt] [PATCHv2 1/2] Split out most of virDBusIsServiceEnabled

2014-03-03 Thread Eric Blake
On 03/03/2014 08:47 AM, Ján Tomko wrote: Introduce virDBusIsServiceInList which can be used to call other methods for listing services (ListNames), not just ListActivatableNames. Nice refactoring. No functional change. --- src/util/virdbus.c | 26 -- 1 file

Re: [libvirt] [PATCHv2 2/2] Check if systemd is running before creating machines

2014-03-03 Thread Eric Blake
On 03/03/2014 08:47 AM, Ján Tomko wrote: If systemd is installed, but not the init system, Took me a couple reads to understand this. It would be easier with s/not/is not/ systemd-machined fails with an unhelpful error message: Launch helper exited with unknown return code 1 Currently we

Re: [libvirt] [PATCH] dnsmasq: allowing RFC 2782 compliant srv records

2014-03-03 Thread Martin Kletzander
On Mon, Mar 03, 2014 at 10:18:30AM +0100, Steven Malin wrote: Hello, I want to provide a patch which allows RFC 2782 compliant dns srv records in the network configs. If you have questions, please contact me. Kind Regards, Steven Malin Please change the commit message in order for it to

Re: [libvirt] [PATCH 1/3] nwfilter: Cap the poll timeout in the DHCP Snooping code

2014-03-03 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 03/03/2014 02:42:57 PM: From: Eric Blake ebl...@redhat.com To: Stefan Berger/Watson/IBM@IBMUS, libvir-list@redhat.com, Cc: la...@laine.org Date: 03/03/2014 02:43 PM Subject: Re: [libvirt] [PATCH 1/3] nwfilter: Cap the poll timeout in the DHCP Snooping

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Eric Blake
On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: ACK, if you also add the virEventUpdateTimeout method OK, but why should I add it? It's useless (for the user) and

Re: [libvirt] [PATCH] Fix memory leak in virDomainSnapshotDiskDefClear()

2014-03-03 Thread Nehal J Wani
--- src/conf/snapshot_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 12b0930..475525f 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -82,6 +82,7 @@

Re: [libvirt] [libvirt-java] [PATCH 40/65] Add constants for enum virDomainEventID

2014-03-03 Thread Eric Blake
On 02/13/2014 08:22 AM, Claudio Bley wrote: Note: these are only used internally. Signed-off-by: Claudio Bley cb...@av-test.de --- +static final int CONTROL_ERROR = 7; +static final int BLOCK_JOB = 8; +static final int DISK_CHANGE = 9; +static final int

Re: [libvirt] [PATCH 3/3] nwfilter: Increase buffer size for libpcap

2014-03-03 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 03/03/2014 02:43:56 PM: From: Eric Blake ebl...@redhat.com To: Stefan Berger/Watson/IBM@IBMUS, libvir-list@redhat.com, Cc: la...@laine.org Date: 03/03/2014 02:44 PM Subject: Re: [libvirt] [PATCH 3/3] nwfilter: Increase buffer size for libpcap On

Re: [libvirt] Compiling libvirt RPC client library for QNX

2014-03-03 Thread Eric Blake
On 02/28/2014 09:09 PM, Panday Ritesh Sharma (rpanday) wrote: While going through 'configure' file, I realised it uses gcc compiler and links all related libraries. But here internally we use icc compiler for x86-machines. Do you have a configure file which I can use for icc i.e.;

[libvirt] Build failed in Jenkins: libvirt-syntax-check #2035

2014-03-03 Thread Jenkins CI
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2035/ -- Started by upstream project libvirt-build build number 2286 Building on master in workspace http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ws/ [workspace] $ /bin/sh -xe

[libvirt] [PATCH] build: fix cppi warning

2014-03-03 Thread Eric Blake
Jenkins pointed out that the previous commit violates syntax check when cppi is installed. * src/nwfilter/nwfilter_dhcpsnoop.c (SNOOP_POLL_MAX_TIMEOUT_MS): Update indentation. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing under the build-breaker rule

[libvirt] Jenkins build is back to normal : libvirt-syntax-check #2036

2014-03-03 Thread Jenkins CI
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2036/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Libvirt Java Bindings - adding domain event support - pull request

2014-03-03 Thread Chris Ellis
Hi Claudio On Mon, Mar 3, 2014 at 3:00 PM, Claudio Bley cb...@av-test.de wrote: At Thu, 27 Feb 2014 03:47:31 +, Chris Ellis wrote: Hi all I'm new to this list, I've been making use of the Libvirt Java bindings recently. I wanted to make use of domain events yesterday so my

Re: [libvirt] [PATCH 0/4] Expose FSFreeze/FSThaw within the guest as commands

2014-03-03 Thread Eric Blake
On 11/18/2013 09:38 AM, Tomoki Sekiyama wrote: Currently FSFreeze and FSThaw are supported by qemu guest agent and they are used internally in snapshot-create command with --quiesce option. However, when users want to utilize the native snapshot feature of storage devices (such as LVM over

[libvirt] [PATCH 05/13] libxl: move libxlDomEventsRegister to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlDomEventsRegister from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainEventsRegister. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 24 src/libxl/libxl_domain.h | 4 +++-

[libvirt] [PATCH 00/13] libxl: add basic support for migration

2014-03-03 Thread Jim Fehlig
Based on an earlier patch from Chunyan Liu https://www.redhat.com/archives/libvir-list/2013-September/msg00667.html This patch series adds basic migration support to the libxl driver. Follow-up patches can improve pre-migration checks and add support for additional migration flags. Patches 1-12

[libvirt] [PATCH 03/13] libxl: move libxlSaveImageOpen to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlSaveImageOpen from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainSaveImageOpen. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 76 + src/libxl/libxl_domain.h |

[libvirt] [PATCH 04/13] libxl: move libxlVmCleanup{, Job} to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlVmCleanup and libxlVmCleanupJob from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainCleanup and libxlDomainCleanupJob. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 87

[libvirt] [PATCH 02/13] libxl: move libxlDomainManagedSavePath to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlDomainManagedSavePath from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 10 ++ src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 10 -- 3 files changed, 14

[libvirt] [PATCH 06/13] libxl: move libxlDomainAutoCoreDump to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlDomainAutoCoreDump from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 44 src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 44

[libvirt] [PATCH 07/13] libxl: move libxlDoNodeGetInfo to libxl_conf

2014-03-03 Thread Jim Fehlig
Move libxlDoNodeGetInfo from libxl_driver to libxl_conf for use by other libxl modules. For consistency, rename to libxlDriverNodeGetInfo. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 36 src/libxl/libxl_conf.h | 4

[libvirt] [PATCH 01/13] libxl: move libxlDomainEventQueue to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlDomainEventQueue from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 6 ++ src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 6 -- 3 files changed, 10 insertions(+), 6

[libvirt] [PATCH 09/13] libxl: move libxlFreeMem to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlFreeMem from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainFreeMem. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 39 +++ src/libxl/libxl_domain.h | 4

[libvirt] [PATCH 12/13] libxl: move domain event handler to libxl_domain

2014-03-03 Thread Jim Fehlig
Move the domain event handler and shutdown thread out of the main driver module and into libxl_domain module Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 179 +++ src/libxl/libxl_driver.c | 179

[libvirt] [PATCH 08/13] libxl: move libxlDomainSetVcpuAffinities to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlDomainSetVcpuAffinities from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 54 src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 54

[libvirt] [PATCH 10/13] libxl: move libxlVmStart to libxl_domain

2014-03-03 Thread Jim Fehlig
Move libxlVmStart from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainStart. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 176 +++ src/libxl/libxl_domain.h | 6 ++

[libvirt] [PATCH 11/13] libxl: include a pointer to the driver in libxlDomainObjPrivate

2014-03-03 Thread Jim Fehlig
Include a pointer to the libxl driver in libxlDomainObjPrivate object so it can be used in the domain event handler and shutdown thread. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 5 +++-- src/libxl/libxl_domain.h | 4 +++- src/libxl/libxl_driver.c | 4 ++-- 3

[libvirt] [PATCH 13/13] libxl: add migration support

2014-03-03 Thread Jim Fehlig
This patch adds initial migration support to the libxl driver, using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration functions. Signed-off-by: Jim Fehlig jfeh...@suse.com --- po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/libxl/libxl_conf.h | 6 +

Re: [libvirt] [PCTCH v2 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-03 Thread Eric Blake
On 03/03/2014 10:41 AM, Amos Kong wrote: Signed-off-by: Amos Kong ak...@redhat.com --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Purely mechanical. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Jim Fehlig
Eric Blake wrote: On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: ACK, if you also add the virEventUpdateTimeout method OK, but why

Re: [libvirt] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Eric Blake
On 03/03/2014 10:41 AM, Amos Kong wrote: s/PCTCH/PATCH/ in the subject, although it doesn't affect patch application. vm_config_groups[] only contains part of the options which have argument, and all options which have no argument isn't added to s/isn't/aren't/ vm_config_groups[]. Current

Re: [libvirt] [PATCH v13 49/49] add pci passthrough to libxl driver

2014-03-03 Thread Jim Fehlig
Chunyan Liu wrote: Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_conf.c | 63 +++ src/libxl/libxl_conf.h |4 + src/libxl/libxl_driver.c |

Re: [libvirt] [Question] Will we support to set boot order online?

2014-03-03 Thread Wangyufei (James)
Thanks all! I will have a think about it. -Original Message- From: Jiri Denemark [mailto:jdene...@redhat.com] Sent: Monday, March 03, 2014 9:31 PM To: Daniel P. Berrange Cc: Wangyufei (James); libvir-list@redhat.com; Moyuxiang; Zhaoyanbin (A) Subject: Re: [libvirt] [Question] Will

[libvirt] [PATCH] datatypes: Fix comments

2014-03-03 Thread Michael Chapman
- As of commit 2ff4c137, all virGet*() functions in datatypes.c always return pointers to new objects. Objects are not cached in a per-connection hashtable. - As of commit 46ec5f85, the conn.lock mutex does not need to be held when calling any vir*Dispose() function in datatypes.c (via

[libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be lost. We have some macros in qemu-options.hx

Re: [libvirt] [Qemu-devel] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
On Mon, Mar 03, 2014 at 05:37:57PM -0700, Eric Blake wrote: --- qapi-schema.json | 8 ++-- util/qemu-config.c | 52 ++-- 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json

  1   2   >