On Mon, Mar 03, 2014 at 12:19:07PM -0700, Eric Blake wrote:
On 03/03/2014 10:21 AM, Martin Kletzander wrote:
This is actaully a proper setting since we're not checking
s/actaully/actually/
session-mode related XMLs.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On 03/03/2014 08:24 PM, Martin Kletzander wrote:
On Mon, Mar 03, 2014 at 06:33:19PM +0100, Ján Tomko wrote:
Include dlfcn.h before checking if RTLD_NEXT is defined
---
tests/virportallocatortest.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
ACK
Martin
Thanks,
On 03/03/2014 08:57 PM, Eric Blake wrote:
On 03/03/2014 08:47 AM, Ján Tomko wrote:
If systemd is installed, but not the init system,
Took me a couple reads to understand this. It would be easier with
s/not/is not/
systemd-machined fails with an unhelpful error message:
Launch helper
On 03/03/2014 08:55 PM, Eric Blake wrote:
On 03/03/2014 08:47 AM, Ján Tomko wrote:
Introduce virDBusIsServiceInList which can be used to call other
methods for listing services (ListNames), not just ListActivatableNames.
Nice refactoring.
No functional change.
---
src/util/virdbus.c |
https://bugzilla.redhat.com/show_bug.cgi?id=1071264
Reverting of external snapshots is not supported currently. The check
that is present doesn't properly check for all aspects that make a
snapshot external. Use virDomainSnapshotIsExternal() to do the check.
---
src/qemu/qemu_driver.c | 7
On Tue, Mar 04, 2014 at 10:15:00AM +0100, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1071264
Reverting of external snapshots is not supported currently. The check
that is present doesn't properly check for all aspects that make a
snapshot external. Use
In qemuMonitorJSONExtractCPUInfo an error message hinted on missing
character device data which is wrong.
Also a comment states that only qemu-kvm tree includes the thread_id
field. This is no longer true.
---
src/qemu/qemu_monitor_json.c | 6 +++---
1 file changed, 3 insertions(+), 3
[cc-ing Peter as he invented the function]
On 03/03/2014 09:04 PM, Nehal J Wani wrote:
---
src/conf/snapshot_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index 12b0930..475525f 100644
---
As I did previously in 4f588a1b46, libvirt needs to set virtio vectors.
Previously, we were advised to use vectors=N, where
N = 2 * (number of queues) + 1
However, just recently this advisory has changed on the Multiquue wiki
page [1] to:
N = 2 * (number of queues) + 2
1:
On Tue, Mar 04, 2014 at 10:38:29AM +0100, Peter Krempa wrote:
In qemuMonitorJSONExtractCPUInfo an error message hinted on missing
character device data which is wrong.
Also a comment states that only qemu-kvm tree includes the thread_id
field. This is no longer true.
---
ACK
Martin
On Tue, Mar 04, 2014 at 10:47:38AM +0100, Michal Privoznik wrote:
As I did previously in 4f588a1b46, libvirt needs to set virtio vectors.
Previously, we were advised to use vectors=N, where
N = 2 * (number of queues) + 1
However, just recently this advisory has changed on the Multiquue wiki
On 03/04/14 10:31, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 10:15:00AM +0100, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1071264
Reverting of external snapshots is not supported currently. The check
that is present doesn't properly check for all aspects that make
On 03/04/14 10:52, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 10:38:29AM +0100, Peter Krempa wrote:
In qemuMonitorJSONExtractCPUInfo an error message hinted on missing
character device data which is wrong.
Also a comment states that only qemu-kvm tree includes the thread_id
field. This
On Tue, Mar 04, 2014 at 08:31:04AM +0100, Claudio Bley wrote:
At Mon, 3 Mar 2014 15:58:25 +,
Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the
On Mon, Mar 03, 2014 at 11:26:42AM +0100, Cédric Bosdonnat wrote:
From: Cédric Bosdonnat cedric.bosdon...@free.fr
use_apparmor() was first designed to be called from withing libvirtd,
but libvirt_lxc also uses it. in libvirt_lxc, there is no need to check
whether to use apparmor or not: just
On Mon, Mar 03, 2014 at 11:26:43AM +0100, Cédric Bosdonnat wrote:
If apparmor security driver is enabled in either qemu or lxc
driver configuration and libvirtd starts before AppArmor, it will fail.
---
daemon/libvirtd.service.in | 1 +
1 file changed, 1 insertion(+)
ACK
Regards,
Daniel
--
On Mon, Mar 03, 2014 at 11:26:44AM +0100, Cédric Bosdonnat wrote:
The reason for these is that aa-status doesn't show the process using
the profile as they are in another namespace.
---
src/security/security_apparmor.c | 5 +
1 file changed, 5 insertions(+)
ACK
Regards,
Daniel
--
|:
On Mon, Mar 03, 2014 at 11:26:45AM +0100, Cédric Bosdonnat wrote:
---
examples/apparmor/libvirt-lxc | 7 +++
src/libvirt-lxc.c | 13 +
2 files changed, 20 insertions(+)
diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
index 074809a..f10fafc 100644
---
On Mon, Mar 03, 2014 at 11:26:46AM +0100, Cédric Bosdonnat wrote:
---
src/security/security_apparmor.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org
On Mon, Mar 03, 2014 at 11:26:41AM +0100, Cédric Bosdonnat wrote:
This is a repost of the previous patch series, with the following changes:
* Dropped the patch setting none security driver as default in lxc.conf
* Add a patch to implement support for none type with apparmor security
On Mon, Mar 03, 2014 at 10:27:24AM +0800, qiaonuohan wrote:
--memory-only option is introduced without compression supported. Therefore,
this is a freature regression of virsh dump. Now qemu has support dumping
memory
in kdump-compressed format. This patch is adding new
On Mon, Mar 03, 2014 at 10:27:25AM +0800, qiaonuohan wrote:
This patch makes qemu driver supprot virDomainCoreDumpWithFormat API.
---
src/qemu/qemu_driver.c | 45
+++-
src/qemu/qemu_monitor.c | 7 ---
src/qemu/qemu_monitor.h | 3
On Mon, Mar 03, 2014 at 10:27:26AM +0800, qiaonuohan wrote:
This patch is used to add --compress and [--compression-format] string
to
virsh dump --memory-only. And virsh dump --memory-only is going be
implemented by new virDomainCoreDumpWithFormat API.
Signed-off-by: Qiao Nuohan
On Mon, Mar 03, 2014 at 06:22:43PM +0100, Michal Privoznik wrote:
The counter gets incremented on each unauthenticated client added to the
server and decremented whenever the client authenticates.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/remote.c| 21
On Mon, Mar 03, 2014 at 06:22:44PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config tunable allows users to determine the maximum number of
accepted but yet not authenticated users.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On Sat, Mar 01, 2014 at 02:28:56PM +0800, Chunyan Liu wrote:
Specify which driver and which domain in used_by area to avoid conflict among
different drivers.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/lxc/lxc_hostdev.c | 24 +++--
src/qemu/qemu_conf.h|2 +
On Mon, Mar 03, 2014 at 05:57:31PM +0100, Cedric Bosdonnat wrote:
Hello ChunYan,
I saw a few minor problems in some patches that made me rebase quite a
lot of other patches in your serie, but otherwise it really looks good
to me.
Here is a summary of the changes I made or questions I
On Sat, Mar 01, 2014 at 02:28:57PM +0800, Chunyan Liu wrote:
Same logic of preparing/reattaching hostdevs could be used in attach/detach
hotplug places, so reuse hostdev interfaces to avoid duplicate, also for later
extracting general code to common library.
Signed-off-by: Chunyan Liu
On Sat, Mar 01, 2014 at 02:28:59PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
po/POTFILES.in |1 +
src/Makefile.am |1 +
src/libvirt_private.syms |4 ++
src/util/virhostdev.c| 103
On Sat, Mar 01, 2014 at 02:28:59PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
po/POTFILES.in |1 +
src/Makefile.am |1 +
src/libvirt_private.syms |4 ++
src/util/virhostdev.c| 103
On Sat, Mar 01, 2014 at 02:29:01PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/lxc/lxc_conf.h|4
src/lxc/lxc_driver.c | 17 +
src/lxc/lxc_hostdev.c | 49
-
3 files changed,
On Sat, Mar 01, 2014 at 02:29:01PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/lxc/lxc_conf.h|4
src/lxc/lxc_driver.c | 17 +
src/lxc/lxc_hostdev.c | 49
-
3 files changed,
On Sat, Mar 01, 2014 at 02:29:00PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_conf.h|8 --
src/qemu/qemu_driver.c | 74 +--
src/qemu/qemu_hostdev.c | 192
---
On Sat, Mar 01, 2014 at 02:29:02PM +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific cfg-relaxedACS handling to be a flag, and pass it to hostdev
functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
On Sat, Mar 01, 2014 at 02:29:03PM +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific COLD_BOOT handling to be a flag, and pass it to hostdev functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |
On Tue, Mar 04, 2014 at 12:04:39PM +, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 05:57:31PM +0100, Cedric Bosdonnat wrote:
Hello ChunYan,
I saw a few minor problems in some patches that made me rebase quite a
lot of other patches in your serie, but otherwise it really looks
Currently, cputuneshares0/shares/cputune is treated
as if it were not specified.
Treat is as a valid value if it was explicitly specified
and write it to the cgroups.
---
src/conf/domain_conf.c | 12 +++-
src/conf/domain_conf.h | 1 +
src/lxc/lxc_cgroup.c | 2 +-
src/lxc/lxc_driver.c
Hello,
This series tries to fix the behavior of
cputuneshares0/shares/cputune (means default shares of 1024)
and virsh schedinfo --set cpu_shares=0 (means minimum of 2)
If 0 was explicitly specified, treat it as a valid value (which
will get converted to 2 by the kernel)
Re-read the shares
---
src/lxc/lxc_cgroup.c | 13 ++---
src/lxc/lxc_driver.c | 6 +-
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_driver.c | 7 ++-
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
index 876c32e..5887b24
On 03/04/2014 12:45 AM, Ján Tomko wrote:
Commit 631923e used a few macros from sys/wait.h without including
it. On Linux, they were also defined in stdlib.h, but on FreeBSD
the build failed:
../../tests/commandtest.c: In function 'test1':
warning: implicit declaration of function
POSIX requires that stdlib.h expose WIFEXITED and friends,
but FreeBSD and others fail to comply. We can work around it
manually by including sys/wait.h, or we can work around it
automatically by using gnulib's system-posix module.
* bootstrap.conf (gnulib_modules): Add system-posix.
At Mon, 03 Mar 2014 13:06:50 -0700,
Eric Blake wrote:
[1 text/plain; UTF-8 (quoted-printable)]
On 02/13/2014 08:22 AM, Claudio Bley wrote:
Note: these are only used internally.
Signed-off-by: Claudio Bley cb...@av-test.de
---
+static final int CONTROL_ERROR = 7;
+
On 03/03/2014 10:21 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting with API, virsh, an error is reported, but only due to
the fact
On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote:
POSIX requires that stdlib.h expose WIFEXITED and friends,
but FreeBSD and others fail to comply. We can work around it
manually by including sys/wait.h, or we can work around it
automatically by using gnulib's system-posix module.
On 03/04/2014 06:47 AM, Daniel P. Berrange wrote:
On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote:
POSIX requires that stdlib.h expose WIFEXITED and friends,
but FreeBSD and others fail to comply. We can work around it
manually by including sys/wait.h, or we can work around it
On Tue, Mar 04, 2014 at 06:44:01AM -0700, Eric Blake wrote:
On 03/03/2014 10:21 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting with API, virsh, an error is reported, but only due to
the fact that no cgroups are mounted (priv-cgroup == NULL).
On Tue, Mar 04, 2014 at 02:13:15PM +0100, Ján Tomko wrote:
---
src/lxc/lxc_cgroup.c | 13 ++---
src/lxc/lxc_driver.c | 6 +-
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_driver.c | 7 ++-
4 files changed, 30 insertions(+), 8 deletions(-)
ACK,
Martin
On Tue, Mar 04, 2014 at 02:13:14PM +0100, Ján Tomko wrote:
Currently, cputuneshares0/shares/cputune is treated
as if it were not specified.
s/were/was/ in this particular case, I guess.
ACK,
Martin
signature.asc
Description: Digital signature
--
libvir-list mailing list
On 02/28/2014 10:10 AM, hong-hua@freescale.com wrote:
Hi Daniel,
Refer to libvirt/src/qemu/qemu_capabilities.c, only x86_64/i686 support
PCI_MULTIBUS.
/* Currently only x86_64 and i686 support PCI-multibus. */
if (qemuCaps-arch == VIR_ARCH_X86_64 ||
qemuCaps-arch ==
Hi Daniel, Chunyan,
On Tue, 2014-03-04 at 12:41 +, Daniel P. Berrange wrote:
On Sat, Mar 01, 2014 at 02:29:03PM +0800, Chunyan Liu wrote:
typedef enum {
VIR_STRICT_ACS_CHECK = (1 0), /* strict acs check */
+ VIR_COLD_BOOT= (1 1), /* cold boot */
}
On Fri, Feb 28, 2014 at 09:10:47AM +, hong-hua@freescale.com wrote:
Hi Daniel,
Refer to libvirt/src/qemu/qemu_capabilities.c, only x86_64/i686 support
PCI_MULTIBUS.
/* Currently only x86_64 and i686 support PCI-multibus. */
if (qemuCaps-arch == VIR_ARCH_X86_64 ||
On 04.03.2014 12:56, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 06:22:44PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config tunable allows users to determine the maximum number of
accepted but yet not authenticated users.
Signed-off-by:
On 3/3/14 17:14 , Eric Blake ebl...@redhat.com wrote:
On 11/18/2013 09:38 AM, Tomoki Sekiyama wrote:
Currently FSFreeze and FSThaw are supported by qemu guest agent and
they are
used internally in snapshot-create command with --quiesce option.
However, when users want to utilize the native
On Tue, Mar 04, 2014 at 04:46:22PM +0100, Michal Privoznik wrote:
On 04.03.2014 12:56, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 06:22:44PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config tunable allows users to determine the maximum
On 04.03.2014 16:46, Michal Privoznik wrote:
On 04.03.2014 12:56, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 06:22:44PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config tunable allows users to determine the maximum number of
accepted but yet
On 03/04/14 10:44, Ján Tomko wrote:
[cc-ing Peter as he invented the function]
On 03/03/2014 09:04 PM, Nehal J Wani wrote:
---
src/conf/snapshot_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index
On Tue, Mar 04, 2014 at 04:56:24PM +0100, Michal Privoznik wrote:
On 04.03.2014 16:46, Michal Privoznik wrote:
On 04.03.2014 12:56, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 06:22:44PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config
On 03/04/2014 07:13 AM, Martin Kletzander wrote:
1) Would helper function (macro) be preferred so the code looks
cleaner?
What macro do you have in mind?
I haven't thought that through, just from top of my head:
#define SESSION_UNSUPP(what) if (!cfg-privileged) {
On Tue, Mar 04, 2014 at 10:11:39AM -0700, Eric Blake wrote:
On 03/04/2014 08:39 AM, Tomoki Sekiyama wrote:
This patchset adds virDomainFSFreeze()/virDomainFSThaw() APIs and virsh
domfsfreeze/domfsthaw commands to enable the users to freeze and thaw
domain's filesystems cleanly.
On 03/04/2014 08:39 AM, Tomoki Sekiyama wrote:
This patchset adds virDomainFSFreeze()/virDomainFSThaw() APIs and virsh
domfsfreeze/domfsthaw commands to enable the users to freeze and thaw
domain's filesystems cleanly.
Thanks. Based on previous discussion on last November, now I'm getting
On 3/4/14 12:13 , Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Mar 04, 2014 at 10:11:39AM -0700, Eric Blake wrote:
On 03/04/2014 08:39 AM, Tomoki Sekiyama wrote:
This patchset adds virDomainFSFreeze()/virDomainFSThaw() APIs and
virsh
domfsfreeze/domfsthaw commands to enable the
On 03/04/2014 07:15 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting with API, virsh, an error is reported, but only due to
the fact
On 03/03/2014 10:51 PM, Amos Kong wrote:
Signed-off-by: Amos Kong ak...@redhat.com
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
No change from v2. To ease my review time, it is reasonable if you
amend the commit message to include my:
Reviewed-by:
On 03/03/2014 10:51 PM, Amos Kong wrote:
vm_config_groups[] only contains part of the options which have
argument, and all options which have no argument aren't added to
vm_config_groups[]. Current query-command-line-options only
checks options from vm_config_groups[], so some options will
be
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote:
The dtrace probe macros rely on the logging API. We can't make
the internal.h header include the virlog.h header though since
that'd be a circular include. Instead simply split the dtrace
probes into their own header file, since there's no
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote:
With the vast number of log debug statements in the code, the
logging framework has a measurable performance impact on libvirt
code, particularly in the daemon event loop.
The global log buffer records every single log message triggered
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote:
The virRaiseErrorFull method sends all error messages onto the
s/onto/on to/
logging code. The logging code has some logic to skip emission
when no log outputs are configured which checks the virLogSource.
This will complicate later
Jan, thanks a lot for your comments.
Olivia
-Original Message-
From: Ján Tomko [mailto:jto...@redhat.com]
Sent: Tuesday, March 04, 2014 10:43 PM
To: Yin Olivia-R63875; Daniel P. Berrange
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] qemu: add PCI-multibus support for
Daniel,
I got it. We need do machine detection for the special PPC platforms.
Thank you for comments.
Olivia
-Original Message-
From: Daniel P. Berrange [mailto:berra...@redhat.com]
Sent: Tuesday, March 04, 2014 10:53 PM
To: Yin Olivia-R63875
Cc: libvir-list@redhat.com
Subject:
On 03/03/2014 09:05 AM, Peter Krempa wrote:
If a user specifies the pool explicitly, we should make sure to point
out that it's inactive instead of falling back to lookup by key/path and
failing at the end. Also if the pool isn't found there's no use in
continuing the lookup.
---
On 03/03/2014 09:05 AM, Peter Krempa wrote:
---
src/storage/storage_driver.c | 89
++--
1 file changed, 44 insertions(+), 45 deletions(-)
Mechanical and matches our style; ACK
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
On 03/03/2014 09:05 AM, Peter Krempa wrote:
Pools that are not backed by files in the filesystem cause problems with
some APIs. Error out when attempting to upload a volume in such a pool
as currently we expect a local file representation for it.
---
src/storage/storage_driver.c | 31
On 03/03/2014 09:05 AM, Peter Krempa wrote:
In storageVolLookupByPath the provided path is sanitized at first.
This removes some extra slashes and stuff. When the lookup of the volume
fails the original path is used which makes it hard to trace errors in
some cases.
Improve the error
On 03/03/2014 09:05 AM, Peter Krempa wrote:
When looking up a volume by path on a non-local filesystem don't use the
cleaned path that might be mangled in such a way that it will differ
from a path provided by a storage backend.
Skip the cleanup step for gluster, sheepdog and RBD.
---
On 03/03/2014 09:05 AM, Peter Krempa wrote:
With most of our storage backends it's possible to have two separate
volume keys to point to a single volume. (By creating sym/hard-links to
local files or by mounting remote filesystems to two different locations
and creating pools on top of them)
2014-03-04 20:17 GMT+08:00 Daniel P. Berrange berra...@redhat.com:
On Sat, Mar 01, 2014 at 02:28:57PM +0800, Chunyan Liu wrote:
Same logic of preparing/reattaching hostdevs could be used in
attach/detach
hotplug places, so reuse hostdev interfaces to avoid duplicate, also for
later
On 03/03/2014 09:05 AM, Peter Krempa wrote:
According to our documentation the key value has the following
meaning: Providing an identifier for the volume which identifies a
single volume. The currently used keys for gluster volumes consist of
the gluster volume name and file path. This can't
2014-03-04 0:57 GMT+08:00 Cedric Bosdonnat cbosdon...@suse.com:
Hello ChunYan,
I saw a few minor problems in some patches that made me rebase quite a
lot of other patches in your serie, but otherwise it really looks good
to me.
Here is a summary of the changes I made or questions I have:
On Tue, Mar 04, 2014 at 03:03:08PM -0700, Eric Blake wrote:
Hi Eric,
On 03/03/2014 10:51 PM, Amos Kong wrote:
vm_config_groups[] only contains part of the options which have
argument, and all options which have no argument aren't added to
vm_config_groups[]. Current
80 matches
Mail list logo
