2014-03-04 20:38 GMT+08:00 Daniel P. Berrange berra...@redhat.com:
On Sat, Mar 01, 2014 at 02:29:00PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_conf.h|8 --
src/qemu/qemu_driver.c | 74 +--
On 03/03/2014 08:18 PM, Daniel P. Berrange wrote:
As part of the goal to get away from doing string matching on
filenames when deciding whether to emit a log message, turn
the virLogSource enum into a struct which contains a log
name. There will eventually be one virLogSource instance
Il 05/03/2014 09:01, Zhanghailiang ha scritto:
Hi all：
Currently, we use cgroup(memory) to support memory QoS on KVM platform,
and use mlock on qemu to support memory reserved.
The mlock seems to be not appropriate.
Now qemu mlock memory in the main thread, which would lock iothread
Hello,
I passthrough a host usb device to a guest with a bus number and device number
in the xml to identify the usb device.
When I unplug and then plug back into the same USB physical port, the guest
identifies the usb device failed. Because on the host ,the usb device number
increases.
So ,
On 03/05/14 05:47, Eric Blake wrote:
On 03/03/2014 09:05 AM, Peter Krempa wrote:
With most of our storage backends it's possible to have two separate
volume keys to point to a single volume. (By creating sym/hard-links to
local files or by mounting remote filesystems to two different locations
On 03/04/2014 07:45 PM, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 10:27:26AM +0800, qiaonuohan wrote:
This patch is used to add --compress and [--compression-format]string
to
virsh dump --memory-only. And virsh dump --memory-only is going be
implemented by new
On Tue, Mar 04, 2014 at 02:04:05PM -0700, Eric Blake wrote:
On 03/04/2014 07:15 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting
On 03/04/2014 03:30 PM, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 02:13:14PM +0100, Ján Tomko wrote:
Currently, cputuneshares0/shares/cputune is treated
as if it were not specified.
s/were/was/ in this particular case, I guess.
I think this particular case is a perfectly cromulent
On Wed, Mar 05, 2014 at 04:03:19PM +0800, Chunyan Liu wrote:
2014-03-04 20:38 GMT+08:00 Daniel P. Berrange berra...@redhat.com:
On Sat, Mar 01, 2014 at 02:29:00PM +0800, Chunyan Liu wrote:
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_conf.h|8 --
On Wed, Mar 05, 2014 at 02:15:51PM +0800, Chunyan Liu wrote:
2014-03-04 0:57 GMT+08:00 Cedric Bosdonnat cbosdon...@suse.com:
Hello ChunYan,
I saw a few minor problems in some patches that made me rebase quite a
lot of other patches in your serie, but otherwise it really looks good
to
https://bugzilla.redhat.com/show_bug.cgi?id=981729
So far we can limit how many clients are connected,
how many are waiting in accept() line but we could
not control the count of accepted but not
authenticated yet.
diff to v2:
-Dan's suggestions worked in
Michal Privoznik (2):
virNetServer:
On 03/04/2014 07:44 PM, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 10:27:25AM +0800, qiaonuohan wrote:
This patch makes qemu driver supprot virDomainCoreDumpWithFormat API.
---
src/qemu/qemu_driver.c | 45
+++-
https://bugzilla.redhat.com/show_bug.cgi?id=981729
This config tunable allows users to determine the maximum number of
accepted but yet not authenticated users.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/libvirtd-config.c| 4 ++-
daemon/libvirtd-config.h| 1 +
The counter gets incremented on each unauthenticated client added to the
server and decremented whenever the client authenticates.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/remote.c| 21 +
src/rpc/virnetserver.c | 45
Hi,
Could you guide me to install libvirt in a virtual environment..?
OR
How python-libvirt could be used within a virtual environment after
installing it, in the system.
Regards
Sijo
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 03/04/2014 07:41 PM, Daniel P. Berrange wrote:
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index b724f82..605b0d1 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -2427,9 +2427,10 @@ testDomainRestore(virConnectPtr conn,
return
On Wed, Mar 05, 2014 at 12:00:59PM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/04/2014 07:41 PM, Daniel P. Berrange wrote:
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index b724f82..605b0d1 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -2427,9
On 03/05/2014 08:42 PM, Daniel P. Berrange wrote:
On Wed, Mar 05, 2014 at 12:00:59PM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/04/2014 07:41 PM, Daniel P. Berrange wrote:
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index b724f82..605b0d1 100644
---
On Wed, Mar 05, 2014 at 12:48:00PM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/05/2014 08:42 PM, Daniel P. Berrange wrote:
On Wed, Mar 05, 2014 at 12:00:59PM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/04/2014 07:41 PM, Daniel P. Berrange wrote:
diff --git a/src/test/test_driver.c
On 03/04/2014 03:58 AM, Michael Chapman wrote:
- As of commit 2ff4c137, all virGet*() functions in datatypes.c always
return pointers to new objects. Objects are not cached in a
per-connection hashtable.
- As of commit 46ec5f85, the conn.lock mutex does not need to be held
when
On 03/05/2014 03:37 AM, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 02:04:05PM -0700, Eric Blake wrote:
On 03/04/2014 07:15 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
On 03/05/2014 05:34 AM, Sijo Jose wrote:
Hi,
Could you guide me to install libvirt in a virtual environment..?
OR
How python-libvirt could be used within a virtual environment after
installing it, in the system.
Same way as in a non-virtual system. For example, if your virtual
environment
Coverity found a memory leak...
...snip...
int
virSCSIDeviceSetUsedBy(virSCSIDevicePtr dev,
- const char *name)
+ const char *drvname,
+ const char *domname)
{
-char *copy = NULL;
-
-if (VIR_STRDUP(copy, name)
Coverity has found an issue (NEGATIVE_RETURNS)
The 'nfdlist' is the culprit.
diff --git a/tools/virt-login-shell.c b/tools/virt-login-shell.c
index 666facf..75a5223 100644
--- a/tools/virt-login-shell.c
+++ b/tools/virt-login-shell.c
@@ -41,24 +41,8 @@
#include vircommand.h
#define
The subject would IMO be better as:
qemu: support RBD storage pools in 'volume' type disks
On 03/03/2014 05:43 PM, Adam Walters wrote:
This patch adds a helper function, qemuAddRBDPoolSourceHost, and
implements the usage of this function to allow RBD storage pools in QEMU
domain XML.
The
On 03/03/2014 05:43 PM, Adam Walters wrote:
This patch fixes the secret type checking done in the
virDomainDiskDefParseXML function. Previously, it would not allow any
volumes that utilized a secret. This patch is a simple bypass of the
checking code for volumes.
Signed-off-by: Adam Walters
The qemuMonitorJSONBlockJob handles a few errors internally. If qemu
returns a different error we would report a rather unhelpful message:
$ virsh blockpull gluster-job vda --base /dev/null
error: internal error: Unexpected error
As the actual message from qemu contains a bit more info, let's
On 03/03/2014 02:18 PM, Daniel P. Berrange wrote:
The dtrace probe macros rely on the logging API. We can't make
the internal.h header include the virlog.h header though since
that'd be a circular include. Instead simply split the dtrace
probes into their own header file, since there's no
On 03/03/2014 02:18 PM, Daniel P. Berrange wrote:
Any source file which calls the logging APIs now needs
to have a VIR_LOG_INIT(source.name) declaration at
the start of the file. This provides a static variable
of the virLogSource type.
Signed-off-by: Daniel P. Berrange
On Wed, Mar 05, 2014 at 10:09:55AM -0500, John Ferlan wrote:
On 03/03/2014 02:18 PM, Daniel P. Berrange wrote:
Any source file which calls the logging APIs now needs
to have a VIR_LOG_INIT(source.name) declaration at
the start of the file. This provides a static variable
of the
Hi all：
Currently, we use cgroup(memory) to support memory QoS on KVM platform, and use
mlock on qemu to support memory reserved.
The mlock seems to be not appropriate.
Now qemu mlock memory in the main thread, which would lock iothread
(qemu_mutex_lock_iothread), if the memory size is large,
configure check for character devices lock path calls
AC_DEFINE_UNQUOTED for VIR_CHRDEV_LOCK_FILE_PATH even if
$with_chrdev_lock_files = no.
So the locking code in conf/virchrdev.c:
#ifdef VIR_CHRDEV_LOCK_FILE_PATH
is compiled in even if it shouldn't, because VIR_CHRDEV_LOCK_FILE_PATH
is
On Wed, Mar 05, 2014 at 07:34:11PM +0400, Roman Bogorodskiy wrote:
configure check for character devices lock path calls
AC_DEFINE_UNQUOTED for VIR_CHRDEV_LOCK_FILE_PATH even if
$with_chrdev_lock_files = no.
So the locking code in conf/virchrdev.c:
#ifdef VIR_CHRDEV_LOCK_FILE_PATH
is
On 03/05/2014 07:15 AM, Peter Krempa wrote:
The qemuMonitorJSONBlockJob handles a few errors internally. If qemu
returns a different error we would report a rather unhelpful message:
$ virsh blockpull gluster-job vda --base /dev/null
error: internal error: Unexpected error
As the actual
On 03/04/2014 11:40 PM, Amos Kong wrote:
but the docs imply that I should now see:
{parameters: [], option: smbios, argument: true}
I really got : {parameters: [], option: smbios, argument: true}
(I was testing with latest qemu upstream + my patches, attached the
output file)
Hmm,
On 03/05/14 16:49, Eric Blake wrote:
On 03/05/2014 07:15 AM, Peter Krempa wrote:
The qemuMonitorJSONBlockJob handles a few errors internally. If qemu
returns a different error we would report a rather unhelpful message:
$ virsh blockpull gluster-job vda --base /dev/null
error: internal
This patch adds initial migration support to the libxl driver,
using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
functions.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
A few small fixes found while reviewing/testing the patch.
V2:
- Change name of local variable in
Conver the sanlock and lockd lock driver plugins over to use
the new virCryptoHashString APIs instead of having their own
duplicated code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/locking/lock_driver_lockd.c | 32 ++---
Probing capabilities takes 200-300ms per binary and we have as many
as 26 binaries. This noticably slows down libvirtd startup. It does
not look like performance of probing QEMU can be improved, so this
series introduces caching of the capabilities information. So the
first time libvirtd starts
Extracting capabilities from QEMU takes a notable amount of time
when all QEMU binaries are installed. Each system emulator
needs about 200-300ms multiplied by 26 binaries == ~5-8 seconds.
This change causes the QEMU driver to save an XML file containing
the content of the virQEMUCaps object
GNULIB provides APIs for calculating md5 and sha256 hashes,
but these APIs only return you raw byte arrays. Most users
in libvirt want the hash in printable string format. Add
some helper APIs in util/vircrypto.{c,h} for doing this.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Currently the QEMU capabilities cache files on disk are only
invalidated if the QEMU binary changes. New versions of libvirt,
however, may want to extract more information from existing
binaries. Thus we must take into account modification time of
the libvirtd daemon and/or any loadable driver
On 03/05/2014 08:58 AM, Eric Blake wrote:
On 03/04/2014 11:40 PM, Amos Kong wrote:
but the docs imply that I should now see:
{parameters: [], option: smbios, argument: true}
I really got : {parameters: [], option: smbios, argument: true}
(I was testing with latest qemu upstream + my
On 03/05/2014 06:57 AM, John Ferlan wrote:
Coverity has found an issue (NEGATIVE_RETURNS)
The 'nfdlist' is the culprit.
cleanup:
+for (i = 0; i nfdlist; i++)
+VIR_FORCE_CLOSE(fdlist[i]);
(41) Event negative_returns: Using unsigned variable nfdlist in a
loop exit
Daniel P. Berrange wrote:
On Wed, Mar 05, 2014 at 07:34:11PM +0400, Roman Bogorodskiy wrote:
configure check for character devices lock path calls
AC_DEFINE_UNQUOTED for VIR_CHRDEV_LOCK_FILE_PATH even if
$with_chrdev_lock_files = no.
So the locking code in conf/virchrdev.c:
On 03/05/2014 01:55 PM, Eric Blake wrote:
On 03/05/2014 06:57 AM, John Ferlan wrote:
Coverity has found an issue (NEGATIVE_RETURNS)
The 'nfdlist' is the culprit.
cleanup:
+for (i = 0; i nfdlist; i++)
+VIR_FORCE_CLOSE(fdlist[i]);
(41) Event negative_returns:
Hello,
This is patchset v2 to add FSFreeze/FSThaw API for custom disk snapshotting.
Changes to v1:
* added quiesced status tracking to avoid double fsfreeze in qemu driver
* removed unused 'mountPoint' argument
* use @acl: domain:write in remote driver
* rebased to master
(v1:
Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest
filesystems of the domain is quiesced of not.
It also modify error code from qemuDomainSnapshotFSFreeze and
qemuDomainSnapshotFSThaw, so that a caller can know whether the command is
actually sent to the guest agent. If the
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw.
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
---
src/remote/remote_driver.c |2 ++
src/remote/remote_protocol.x | 23 ++-
src/remote_protocol-structs |9 +
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFreeze() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
---
src/qemu/qemu_driver.c | 78
1 file changed, 78 insertions(+)
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
---
tools/virsh-domain.c | 92 ++
tools/virsh.pod | 15
2 files changed, 107 insertions(+)
diff --git
Hi Daniel,
On Wed, Mar 05, 2014 at 05:53:53PM +, Daniel P. Berrange wrote:
[..snip..]
+/* Discard if cache is older that QEMU binary */
+/* XXX must also compare to libvirtd timestamp */
+if (sb.st_mtime qemuCaps-mtime) {
I think looking at the mtime isn't sufficent here.
On 03/05/2014 01:40 PM, Guido Günther wrote:
Hi Daniel,
On Wed, Mar 05, 2014 at 05:53:53PM +, Daniel P. Berrange wrote:
[..snip..]
+/* Discard if cache is older that QEMU binary */
+/* XXX must also compare to libvirtd timestamp */
+if (sb.st_mtime qemuCaps-mtime) {
I
On 03/05/2014 10:53 AM, Daniel P. Berrange wrote:
GNULIB provides APIs for calculating md5 and sha256 hashes,
but these APIs only return you raw byte arrays. Most users
in libvirt want the hash in printable string format. Add
some helper APIs in util/vircrypto.{c,h} for doing this.
On 03/05/2014 10:53 AM, Daniel P. Berrange wrote:
Conver the sanlock and lockd lock driver plugins over to use
s/Conver/Convert/
the new virCryptoHashString APIs instead of having their own
duplicated code.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 03/05/2014 10:53 AM, Daniel P. Berrange wrote:
Extracting capabilities from QEMU takes a notable amount of time
when all QEMU binaries are installed. Each system emulator
needs about 200-300ms multiplied by 26 binaries == ~5-8 seconds.
This change causes the QEMU driver to save an XML
On 03/05/2014 10:53 AM, Daniel P. Berrange wrote:
Currently the QEMU capabilities cache files on disk are only
invalidated if the QEMU binary changes. New versions of libvirt,
however, may want to extract more information from existing
binaries. Thus we must take into account modification time
On Wed, Mar 05, 2014 at 11:50:22AM -0700, Eric Blake wrote:
On 03/05/2014 08:58 AM, Eric Blake wrote:
On 03/04/2014 11:40 PM, Amos Kong wrote:
but the docs imply that I should now see:
{parameters: [], option: smbios, argument: true}
I really got : {parameters: [], option: smbios,
This patchset fixed some issues of query-command-line-options:
* some new options that haven't argument can't be queried. (eg: -enable-fips)
* some legacy options that have argument can't be queried. (eg: -vnc display)
More discussion:
http://marc.info/?l=qemu-develm=139081830416684w=2
V2:
vm_config_groups[] only contains part of the options which have
argument, and all options which have no argument aren't added
to vm_config_groups[]. Current query-command-line-options only
checks options from vm_config_groups[], so some options will
be lost.
We have macro in qemu-options.hx to
Signed-off-by: Amos Kong ak...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..d2facfd 100644
--- a/util/qemu-config.c
+++
This commit moves a few directories into more appropriate subpackages.
In a few cases a directory is owned by two subpackages, however this is
OK as long as the permissions and ownership for the directory are
consistent between them.
- %{_sysconfdir}/libvirt/qemu/
Used by the qemu and network
If SELinux is compiled into libvirt but it is disabled on the host,
libvirtd logs:
error : virIdentityGetSystem:173 : Unable to lookup SELinux process
context: Invalid argument
on each and every client connection.
Use is_selinux_enabled() to skip retrieval of the process's SELinux
context
With the previous commit's securityselinuxhelper enhancements, the
SELinux security manager can be tested even without SELinux enabled on
the test system.
Signed-off-by: Michael Chapman m...@very.puzzling.org
---
tests/securityselinuxlabeltest.c | 3 ---
tests/securityselinuxtest.c | 3 ---
If SELinux is compiled into libvirt but it is disabled on the host, libvirtd
logs:
error : virIdentityGetSystem:173 : Unable to lookup SELinux process
context: Invalid argument
on each and every client connection.
This patch series adds a runtime check for SELinux to this function.
I've
Add fake implementations of:
- is_selinux_enabled
- security_disable
- selinux_virtual_domain_context_path
- selinux_virtual_image_context_path
- selinux_lxc_contexts_path
- selabel_open
- selabel_close
- selabel_lookup_raw
The selabel_* functions back onto the real implementations if SELinux is
Test it once with SELinux enabled and once with it disabled.
Signed-off-by: Michael Chapman m...@very.puzzling.org
---
tests/Makefile.am | 4 +++
tests/viridentitytest.c | 75 -
2 files changed, 78 insertions(+), 1 deletion(-)
diff --git
@Michel
using virtualenv we can create an isolated environment in the system.
Just go through - http://docs.python-guide.org/en/latest/dev/virtualenvs/
@Eric
I'm using Ubuntu, and I was able to install and use libvirt using sudo
apt-get install python-libvirt but its not available in tg2 virtual
Sijo Jose wrote:
@Michel
using virtualenv we can create an isolated environment in the system.
Just go through - http://docs.python-guide.org/en/latest/dev/virtualenvs/
@Eric
I'm using Ubuntu, and I was able to install and use libvirt using sudo
apt-get install python-libvirt but its not
On Sun, Mar 2, 2014 at 7:26 AM, Daniel Veillard veill...@redhat.com wrote:
As planned I have tagged libvirt-1.2.2 in git and it seem the git tree
finally updated despite the horrible network I get in china ATM, the
tarballs may finally arrive at some time too at the usual place after
working
Jason Helfman wrote:
[libvirt-announce@ CCdropped]
I get this breakage on libvirt 1.2.2 for FreeBSD.
CCLD libvirt_iohelper
CC locking/virtlockd-lock_daemon.o
CC locking/virtlockd-lock_daemon_config.o
CC locking/virtlockd-lock_daemon_dispatch.o
CC
71 matches
Mail list logo
