Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lennart Poettering
On Fri, 07.03.14 21:51, Lukasz Pawelczyk (hav...@gmail.com) wrote: > >> Problem: > >> Has anyone thought about a mechanism to limit/remove an access to a > >> device during an application runtime? Meaning we have an > >> application that has an open file descriptor to some /dev/node and > >> depen

[libvirt] [PATCH v2] dnsmasq: allowing RFC 2782 compliant SRV records

2014-03-07 Thread Steven Malin
This patch allows RFC 2782 compliant SRV records in the network config and corrects the documentation. --- docs/formatnetwork.html.in |6 +++--- src/conf/network_conf.c|6 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetw

Re: [libvirt] [PATCH 13/13] src/xenxs: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/xenxs/xen_sxpr.c | 43 +-- > src/xenxs/xen_xm.c | 27 --- > 2 files changed, 25 insertions(+), 45 deletions(-) > ACK -- Eric Blake

Re: [libvirt] [PATCH 12/13] src/xen: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/xen/xen_driver.c | 19 ++- > src/xen/xen_driver.h | 2 +- > src/xen/xen_inotify.c | 13 ++--- > src/xen/xm_internal.c | 18 +++--- > src/xen/xs_internal.c | 19 ++--

Re: [libvirt] [PATCH 11/13] src/util: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/util/virjson.c | 12 +++- > src/util/virlockspace.c | 12 ++-- > 2 files changed, 5 insertions(+), 19 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libv

Re: [libvirt] [PATCH 10/13] src/test: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/test/test_driver.c | 41 + > 1 file changed, 9 insertions(+), 32 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [libvirt] [PATCH 09/13] src/storage: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/storage/storage_backend_disk.c| 13 - > src/storage/storage_backend_fs.c | 5 + > src/storage/storage_backend_iscsi.c | 5 + > src/storage/storage_backend_logical.c | 8

Re: [libvirt] [PATCH 08/13] src/rpc: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/rpc/virnetclient.c | 11 +-- > src/rpc/virnetserver.c | 11 ++- > 2 files changed, 3 insertions(+), 19 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 07/13] src/qemu: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_command.c | 90 > ++-- > src/qemu/qemu_conf.c | 8 +--- > src/qemu/qemu_conf.h | 2 +- > src/qemu/qemu_driver.c | 10 ++---

Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 09:45:28PM +0100, Lukasz Pawelczyk wrote: > > On 7 Mar 2014, at 20:09, Greg KH wrote: > > > On Fri, Mar 07, 2014 at 07:46:44PM +0100, Lukasz Pawelczyk wrote: > >> Problem: > >> Has anyone thought about a mechanism to limit/remove an access to a > >> device during an appli

Re: [libvirt] [PATCH 06/13] src/phyp: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/phyp/phyp_driver.c | 16 +++- > src/phyp/phyp_driver.h | 2 +- > 2 files changed, 8 insertions(+), 10 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virt

Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lukasz Pawelczyk
On 7 Mar 2014, at 20:24, Lennart Poettering wrote: > On Fri, 07.03.14 19:45, Lukasz Pawelczyk (hav...@gmail.com) wrote: > >> Problem: >> Has anyone thought about a mechanism to limit/remove an access to a >> device during an application runtime? Meaning we have an application >> that has an ope

Re: [libvirt] [PATCH 05/13] src/parallels: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/parallels/parallels_driver.c | 15 --- > src/parallels/parallels_storage.c | 32 > 2 files changed, 12 insertions(+), 35 deletions(-) > ACK -- Eric Blake

Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lukasz Pawelczyk
On 7 Mar 2014, at 20:09, Greg KH wrote: > On Fri, Mar 07, 2014 at 07:46:44PM +0100, Lukasz Pawelczyk wrote: >> Problem: >> Has anyone thought about a mechanism to limit/remove an access to a >> device during an application runtime? Meaning we have an application >> that has an open file descript

Re: [libvirt] [PATCH 04/13] src/openvz: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:46 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/openvz/openvz_conf.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [libvirt] [PATCH 03/13] src/nwfilter: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:45 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/nwfilter/nwfilter_gentech_driver.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [libvirt] [PATCH 02/13] src/lxc/: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:45 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/lxc/lxc_container.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org si

Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 07:46:44PM +0100, Lukasz Pawelczyk wrote: > Problem: > Has anyone thought about a mechanism to limit/remove an access to a > device during an application runtime? Meaning we have an application > that has an open file descriptor to some /dev/node and depending on > *somethin

Re: [libvirt] [PATCH 01/13] conf: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

2014-03-07 Thread Eric Blake
On 03/07/2014 02:45 AM, Michal Privoznik wrote: > This fixes a possible double free. In virNetworkAssignDef() if > virBitmapNew() fails, then virNetworkObjFree(network) is called. > However, with network->def pointing to actual @def. So if caller > frees @def again, ... > > Moreover, this fixes on

Re: [libvirt] [PATCH 5/7] Add virLogSource variables to all source files

2014-03-07 Thread Eric Blake
On 03/07/2014 10:43 AM, Eric Blake wrote: > On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: >> Any source file which calls the logging APIs now needs >> to have a VIR_LOG_INIT("source.name") declaration at >> the start of the file. This provides a static variable >> of the virLogSource type. >>

Re: [libvirt] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lennart Poettering
On Fri, 07.03.14 19:45, Lukasz Pawelczyk (hav...@gmail.com) wrote: > Problem: > Has anyone thought about a mechanism to limit/remove an access to a > device during an application runtime? Meaning we have an application > that has an open file descriptor to some /dev/node and depending on > *someth

Re: [libvirt] Release of libvirt-1.2.2

2014-03-07 Thread Jason Helfman
On Fri, Mar 7, 2014 at 3:00 AM, Roman Bogorodskiy wrote: > Jason Helfman wrote: > > > On Thu, Mar 6, 2014 at 5:22 AM, Eric Blake wrote: > > > > > On 03/06/2014 12:02 AM, Jason Helfman wrote: > > > > On Sun, Mar 2, 2014 at 7:26 AM, Daniel Veillard > > > > wrote: > > > > > > > >> As planned I h

[libvirt] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lukasz Pawelczyk
Problem: Has anyone thought about a mechanism to limit/remove an access to a device during an application runtime? Meaning we have an application that has an open file descriptor to some /dev/node and depending on *something* it gains or looses the access to it gracefully (with or without a notific

[libvirt] Suspending access to opened/active /dev/nodes during application runtime

2014-03-07 Thread Lukasz Pawelczyk
Problem: Has anyone thought about a mechanism to limit/remove an access to a device during an application runtime? Meaning we have an application that has an open file descriptor to some /dev/node and depending on *something* it gains or looses the access to it gracefully (with or without a notific

Re: [libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

2014-03-07 Thread Eric Blake
On 03/07/2014 10:09 AM, Daniel P. Berrange wrote: > On Fri, Mar 07, 2014 at 09:56:10AM -0700, Eric Blake wrote: >> On 03/04/2014 06:59 AM, Eric Blake wrote: >>> On 03/04/2014 06:47 AM, Daniel P. Berrange wrote: On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote: > POSIX requires th

Re: [libvirt] [PATCH 7/7] Remove global log buffer feature entirely

2014-03-07 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: > A earlier commit changed the global log buffer so that it only > records messages that are explicitly requested via the log > filters setting. This removes the performance burden, and > improves the signal/noise ratio for messages in the global >

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Fri, Mar 07, 2014 at 07:49:04PM +0400, Roman Bogorodskiy wrote: > > Daniel P. Berrange wrote: > > > > > On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote: > > > > Daniel P. Berrange wrote: > > > > > > > > > All those mangled messages are being

[libvirt] [PATCH v2] libvirt-tck: prefer kvm domains if multiple domain types exist

2014-03-07 Thread Mike Latimer
When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid unpredictable test results, this patch prefers kvm if that domain type exists. If not, the behavior matches what existed before, and the f

Re: [libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-07 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: > Currently the log filter strings are used in a string comparison > against the source filename each time log message is emitted. > If no log filters at all are set, there's obviously no string > comparison to be done. If any single log filter is s

Re: [libvirt] [PATCH 5/7] Add virLogSource variables to all source files

2014-03-07 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: > Any source file which calls the logging APIs now needs > to have a VIR_LOG_INIT("source.name") declaration at > the start of the file. This provides a static variable > of the virLogSource type. > > Signed-off-by: Daniel P. Berrange > --- > dae

Re: [libvirt] [PATCH 4/7] Turn virLogSource into a struct instead of an enum

2014-03-07 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: > As part of the goal to get away from doing string matching on > filenames when deciding whether to emit a log message, turn > the virLogSource enum into a struct which contains a log > "name". There will eventually be one virLogSource instance > s

Re: [libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

2014-03-07 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 09:56:10AM -0700, Eric Blake wrote: > On 03/04/2014 06:59 AM, Eric Blake wrote: > > On 03/04/2014 06:47 AM, Daniel P. Berrange wrote: > >> On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote: > >>> POSIX requires that expose WIFEXITED and friends, > >>> but FreeBSD a

Re: [libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

2014-03-07 Thread Eric Blake
On 03/04/2014 06:59 AM, Eric Blake wrote: > On 03/04/2014 06:47 AM, Daniel P. Berrange wrote: >> On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote: >>> POSIX requires that expose WIFEXITED and friends, >>> but FreeBSD and others fail to comply. We can work around it >>> manually by inclu

Re: [libvirt] [PATCH] Add a mutex to serialize updates to firewall

2014-03-07 Thread Eric Blake
On 03/07/2014 09:15 AM, Daniel P. Berrange wrote: > For > > https://bugzilla.redhat.com/show_bug.cgi?id=1066801 > > The nwfilter conf update mutex previously serialized > updates to the internal data structures for firewall > rules, and updates to the firewall itself. The latter > was recently

Re: [libvirt] [PATCH 2/4] virsh: Add keepalive in new vshConnect function

2014-03-07 Thread Michal Privoznik
On 07.03.2014 17:09, Martin Kletzander wrote: On Fri, Mar 07, 2014 at 04:50:51PM +0100, Michal Privoznik wrote: On 07.03.2014 11:49, Martin Kletzander wrote: Introducing keepalive similarly to Guannan around 2 years ago. Since we want to introduce keepalive for every connection, it makes sense

Re: [libvirt] [bug-report] libvirtd can't be connected by using the master branch with lots of VMs

2014-03-07 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 01:06:10PM +0800, Wangpan wrote: > bug address: https://bugzilla.redhat.com/show_bug.cgi?id=1066801 > I can reproduce it at master/v1.2.1-maint/v1.1.4-maint/v1.1.3.4 release > branches everytime, > but cann't reproduce it at v1.2.1,so I believe this bug is imported by the

[libvirt] [PATCH] Add a mutex to serialize updates to firewall

2014-03-07 Thread Daniel P. Berrange
For https://bugzilla.redhat.com/show_bug.cgi?id=1066801 The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. The latter was recently turned into a read/write lock, and filter instantiation allowed to

Re: [libvirt] [PATCH] add option to enforce minimal pagesize for hugetlbfs backed guests

2014-03-07 Thread Paolo Bonzini
Il 11/02/2014 15:46, Daniel P. Berrange ha scritto: IMHO all of this code is something that belongs in QEMU, with libvirt telling QEMU what min page size it wants via a CLI arg. I disagree. QEMU just gets a path to something that doesn't even have to be a hugetlbfs mountpoint. QEMU hardly ne

Re: [libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

2014-03-07 Thread John Ferlan
On 03/07/2014 10:37 AM, Ján Tomko wrote: > On 03/07/2014 03:55 PM, John Ferlan wrote: >> This resolves a Coverity RESOURCE_LEAK issue introduced by commit >> id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE >> the 'copy' or possibly VIR_STRDUP()'d values. >> >> Signed-off-by: John

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 07:49:04PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote: > > > Daniel P. Berrange wrote: > > > > > > > All those mangled messages are being printed out by libvirt client > > > > code

Re: [libvirt] [PATCH 2/4] virsh: Add keepalive in new vshConnect function

2014-03-07 Thread Martin Kletzander
On Fri, Mar 07, 2014 at 04:50:51PM +0100, Michal Privoznik wrote: > On 07.03.2014 11:49, Martin Kletzander wrote: > > Introducing keepalive similarly to Guannan around 2 years ago. Since > > we want to introduce keepalive for every connection, it makes sense to > > wrap the connecting function int

Re: [libvirt] [PATCH 1/4] virsh: Sort options alphabetically

2014-03-07 Thread Michal Privoznik
On 07.03.2014 11:49, Martin Kletzander wrote: Man page, help output and also parsing is sorted in order to find options smoothly. Signed-off-by: Martin Kletzander --- tools/virsh.c | 64 - tools/virsh.pod | 38 +---

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

2014-03-07 Thread Eric Blake
On 03/07/2014 02:02 AM, Osier Yang wrote: > On 07/03/14 00:27, Mike Latimer wrote: >> Starting with libvirt 0.9.0+, hook scripts can be called from several new >> locations. These locations must also be reflected in the expected logs of >> the hook tests. > > ACK, but wondering why we didn't disc

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote: > > Daniel P. Berrange wrote: > > > > > All those mangled messages are being printed out by libvirt client > > > code, and it is totally expected that log messages libvirt prints > > > are mangled i

Re: [libvirt] [PATCH] Change file names in comments to match the files they are in

2014-03-07 Thread Eric Blake
On 03/07/2014 06:45 AM, Ján Tomko wrote: > Some of these are leftovers from renaming the files, others > are just typos. > > Also introduce an ugly awk script to enforce this. > --- > cfg.mk | 25 + > +++ b/cfg.mk > @@ -863,6 +863,31 @@ sc_

Re: [libvirt] [PATCH 2/4] virsh: Add keepalive in new vshConnect function

2014-03-07 Thread Michal Privoznik
On 07.03.2014 11:49, Martin Kletzander wrote: Introducing keepalive similarly to Guannan around 2 years ago. Since we want to introduce keepalive for every connection, it makes sense to wrap the connecting function into new virsh one that can deal keepalive as well. Function vshConnect() is now

Re: [libvirt] [PATCH] libvirt-tck: prefer kvm if multiple domain types exist

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:55:34 PM Osier Yang wrote: > > - return ($domains[0], > > +# Prefer kvm if multiple domain types are returned > > +my $domain; > > +if (int(@domains) gt 1) { > > +for (my $j = 0 ; $j < int(@domains) ; $j++) { > > I would use "g

Re: [libvirt] [PATCH] libvirt-tck: Ignore SIGPIPE in 051-daemon-hook.t

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:16:48 PM Osier Yang wrote: > > $hook->cleanup(); > > + > > +# Restarting libvirtd broke the tck connection, so ignore sigpipe and > > +# undefine $tck to avoid a return code of 141 > > +$SIG{PIPE} = 'IGNORE'; > > +undef $tck; > > We should get the

Re: [libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

2014-03-07 Thread Osier Yang
On 07/03/14 22:55, John Ferlan wrote: This resolves a Coverity RESOURCE_LEAK issue introduced by commit id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE the 'copy' or possibly VIR_STRDUP()'d values. Signed-off-by: John Ferlan --- src/util/virscsi.c | 26 +++

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:02:00 PM Osier Yang wrote: > ACK, but wondering why we didn't discover it, according to the log for > the hook scripts have been changed. I'm not sure why this hasn't been seen before. The only thing that makes sense is that the hook tests haven't been tested since th

Re: [libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

2014-03-07 Thread Ján Tomko
On 03/07/2014 03:55 PM, John Ferlan wrote: > This resolves a Coverity RESOURCE_LEAK issue introduced by commit > id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE > the 'copy' or possibly VIR_STRDUP()'d values. > > Signed-off-by: John Ferlan > --- > src/util/virscsi.c | 26 +++

Re: [libvirt] [PATCH] Change file names in comments to match the files they are in

2014-03-07 Thread Michal Privoznik
On 07.03.2014 14:45, Ján Tomko wrote: Some of these are leftovers from renaming the files, others are just typos. Also introduce an ugly awk script to enforce this. --- cfg.mk | 25 + daemon/libvirtd-config.c| 2 +- da

Re: [libvirt] [PATCH v14 01/49] virscsi: fix memory leak

2014-03-07 Thread John Ferlan
On 03/07/2014 05:52 AM, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > src/util/virscsi.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/util/virscsi.c b/src/util/virscsi.c > index 69eae24..627b3f8 100644 > --- a/src/util/virscsi.c > +++ b/s

[libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

2014-03-07 Thread John Ferlan
This resolves a Coverity RESOURCE_LEAK issue introduced by commit id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE the 'copy' or possibly VIR_STRDUP()'d values. Signed-off-by: John Ferlan --- src/util/virscsi.c | 26 +++--- 1 file changed, 15 insertions(+), 11

Re: [libvirt] [PATCH 0/4] Fix for virIdentityGetSystem when SELinux is disabled

2014-03-07 Thread Michal Privoznik
On 06.03.2014 07:02, Michael Chapman wrote: If SELinux is compiled into libvirt but it is disabled on the host, libvirtd logs: error : virIdentityGetSystem:173 : Unable to lookup SELinux process context: Invalid argument on each and every client connection. This patch series adds a runti

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > All those mangled messages are being printed out by libvirt client > > code, and it is totally expected that log messages libvirt prints > > are mangled in this way for the console. > > > > What

[libvirt] [PATCH] qemu: Forbid "sgio" support for SCSI generic host device

2014-03-07 Thread Osier Yang
The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's unknow whether the way to support unprivileged SGIO for SCSI generic device will be similar as for SCSI block device or not, even it's simliar (I.e. via sysfs, for SCSI block device, it's /sys/dev/block/

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > All those mangled messages are being printed out by libvirt client > code, and it is totally expected that log messages libvirt prints > are mangled in this way for the console. > > What's more important is what data coming from the guest looks > like. All those spa

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 05:49:34PM +0400, Roman Bogorodskiy wrote: > Hi, > > I've been trying to understand why 'virsh console' doesn't work on > FreeBSD for some time and now I feel like I got stuck. > > Background of the problem. Some time ago I started implementing console > support for the bh

[libvirt] Seeking for advice on 'virsh console' problems debugging

2014-03-07 Thread Roman Bogorodskiy
Hi, I've been trying to understand why 'virsh console' doesn't work on FreeBSD for some time and now I feel like I got stuck. Background of the problem. Some time ago I started implementing console support for the bhyve driver. I initially implemented it using nmdm(4) device: http://www.freebsd.

[libvirt] [PATCH] Change file names in comments to match the files they are in

2014-03-07 Thread Ján Tomko
Some of these are leftovers from renaming the files, others are just typos. Also introduce an ugly awk script to enforce this. --- cfg.mk | 25 + daemon/libvirtd-config.c| 2 +- daemon/libvirtd-config.h| 2

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

2014-03-07 Thread Eric Blake
On 03/07/2014 06:18 AM, Martin Kletzander wrote: > On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote: >> On 07.03.2014 12:59, Daniel P. Berrange wrote: >>> There is a forever growing list of test cases. It is just >>> not worth listing each one individually when a wildcard >>> can do

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

2014-03-07 Thread Martin Kletzander
On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote: > On 07.03.2014 12:59, Daniel P. Berrange wrote: > > There is a forever growing list of test cases. It is just > > not worth listing each one individually when a wildcard > > can do the job. > > > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

2014-03-07 Thread Michal Privoznik
On 07.03.2014 12:59, Daniel P. Berrange wrote: There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job. Signed-off-by: Daniel P. Berrange --- .gitignore | 73 +-

[libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

2014-03-07 Thread Daniel P. Berrange
There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job. Signed-off-by: Daniel P. Berrange --- .gitignore | 73 +- 1 file changed, 1 insertion(+), 72 deletions(-)

[libvirt] [PATCH v14 43/49] improve virHostdevUpdate* parameters to make it more widely used

2014-03-07 Thread Chunyan Liu
Changes parameter from vm def to specific hostdevs info and name info, so that it could be used more widely, e.g, could be used without full vm def info. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 9 ++--- src/util/virhostdev.c | 34 -- src/ut

Re: [libvirt] [PATCH v14 00/49] write separate module for hostdev passthrough

2014-03-07 Thread Chun Yan Liu
The whole patch series could be get from here: https://github.com/chunyanliu/libvirt/commits/hostdev_passthrough -Chunyan >>> On 3/7/2014 at 06:52 PM, in message <1394189596-22994-1-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > These patches implements a separate module for hostdev pass

Re: [libvirt] [PATCH] qemu: don't munge user input during block commit

2014-03-07 Thread Michal Privoznik
On 07.03.2014 00:47, Eric Blake wrote: While investigating https://bugzilla.redhat.com/show_bug.cgi?id=1061827 I noticed that we pass user input unscathed for block-pull, but always pass a canonical absolute name through for block-commit. [Note that we probably _ought_ to validate that the user's

[libvirt] [PATCH v14 44/49] add 3 wrapper functions for prepare/reattach/update domain hostdevs

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 4 ++ src/util/virhostdev.c| 103 +++ src/util/virhostdev.h| 20 + 3 files changed, 127 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e7

[libvirt] [PATCH v14 37/49] extract general code of NodeDeviceDetach

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_driver.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d25d14..b980725 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@

[libvirt] [PATCH v14 42/49] rename some function names to keep consistency

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 8 src/qemu/qemu_hostdev.c | 16 +++ src/util/virhostdev.c| 52 src/util/virhostdev.h| 40 ++--- 4 files changed, 58 insertions

Re: [libvirt] Release of libvirt-1.2.2

2014-03-07 Thread Roman Bogorodskiy
Jason Helfman wrote: > On Thu, Mar 6, 2014 at 5:22 AM, Eric Blake wrote: > > > On 03/06/2014 12:02 AM, Jason Helfman wrote: > > > On Sun, Mar 2, 2014 at 7:26 AM, Daniel Veillard > > wrote: > > > > > >> As planned I have tagged libvirt-1.2.2 in git and it seem the git tree > > >> finally upda

[libvirt] [PATCH v14 30/49] move virHostdevPrepareHostSCSIDevices to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 111 --- src/util/virhostdev.c| 111 +++ src/util/virhostdev.h| 6 +++ 4 files changed, 118 insertions(+),

[libvirt] [PATCH v14 46/49] add unit test for new virhostdev common library

2014-03-07 Thread Chunyan Liu
Add unit test for hostdev common library. Current tests are based on virpcimock. Signed-off-by: Chunyan Liu --- .gitignore | 1 + tests/Makefile.am | 5 + tests/virhostdevtest.c | 507 + 3 files changed, 513 insertions(+) crea

[libvirt] [PATCH v14 47/49] change lxc_hostdev.c to use virhostdev common library APIs

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/lxc/lxc_hostdev.c | 305 ++ 1 file changed, 10 insertions(+), 295 deletions(-) diff --git a/src/lxc/lxc_hostdev.c b/src/lxc/lxc_hostdev.c index 635f2e5..07480dc 100644 --- a/src/lxc/lxc_hostdev.c +++ b/src/lxc/lxc

[libvirt] [PATCH v14 41/49] improve parameter name to let it more meaningful

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/util/virhostdev.c | 44 +++- src/util/virhostdev.h | 12 ++-- 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 4302385..2c8bdf9 100644 --- a/src/u

[libvirt] [PATCH v14 49/49] add pci passthrough to libxl driver

2014-03-07 Thread Chunyan Liu
Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu --- src/libxl/libxl_conf.c | 63 +++ src/libxl/libxl_conf.h | 7 +- src/libxl/libxl_driver.c | 454 ++

[libvirt] [PATCH v14 33/49] move virHostdevReAttachUsbHostdevs to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 66 src/util/virhostdev.c| 66 src/util/virhostdev.h| 6 + 4 files changed, 73 insertions(+), 6

[libvirt] [PATCH v14 45/49] add parameter checks to common interfaces

2014-03-07 Thread Chunyan Liu
Check NULL parameter inputs Signed-off-by: Chunyan Liu --- src/util/virhostdev.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 577de48..5f61bfc 100644 --- a/src/util/virhostdev.c +++ b/

[libvirt] [PATCH v14 31/49] extract general code from qemuDomainReAttachHostUsbDevices

2014-03-07 Thread Chunyan Liu
Extract general code from qemuDomainReAttachHostUsbDevices to virHostdevDomainReAttachHostUsbDevices. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostde

[libvirt] [PATCH v14 48/49] add hostdev pci backend type for xen

2014-03-07 Thread Chunyan Liu
Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use "pciback" as stub driver. Signed-off-by: Chunyan Liu --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 3 ++- src/conf/domain_conf.h| 1 + src/libxl/libxl_domain.c | 9 + src/qemu/

[libvirt] [PATCH v14 29/49] pass driver name as parameter to virHostdevPrepareSCSIDevices

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 9ad32e0..41ee32f 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -247,6 +247,7 @@ qemuP

[libvirt] [PATCH v14 40/49] move virHostdevNodeDevice* to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 3 ++ src/qemu/qemu_driver.c | 81 src/util/virhostdev.c| 81 src/util/virhostdev.h| 8 + 4 files changed, 92 insertions(+),

[libvirt] [PATCH v14 39/49] extract general code of NodeDeviceReset

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_driver.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3abcf5a..6b6a170 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1145

[libvirt] [PATCH v14 27/49] move virHostdevPrepareHostUSBDevices to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 217 --- src/util/virhostdev.c| 216 ++ src/util/virhostdev.h| 7 ++ 4 files changed, 224 insertions(+), 21

[libvirt] [PATCH v14 28/49] extract general code from qemuPrepareHostSCSIDevices

2014-03-07 Thread Chunyan Liu
Extract general code from qemuPrepareHostSCSIDevices to virHostdevPrepareHostSCSIDevices. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 63 + 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/q

[libvirt] [PATCH v14 38/49] extract general code of NodeDeviceReAttach

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_driver.c | 61 +- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b980725..3abcf5a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/

[libvirt] [PATCH v14 35/49] pass driver name as parameter to virHostdevReAttachScciHostdevs

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5e46a3d..b4ab1bd 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -330,6 +330,7 @@ qemuDoma

[libvirt] [PATCH v14 36/49] move virHostdevReAttachHostScsiDevices to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 62 src/util/virhostdev.c| 62 src/util/virhostdev.h| 6 + 4 files changed, 69 insertions(+), 6

[libvirt] [PATCH v14 34/49] extract general code from qemuDomainReAttachHostScsiDevices

2014-03-07 Thread Chunyan Liu
Extract general code from qemuDomainReAttachHostScsiDevices to virHostdevDomainReAttachHostScsiDevices. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/

[libvirt] [PATCH v14 23/49] move virHostdevUpdate* functions to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 3 + src/qemu/qemu_hostdev.c | 151 --- src/util/virhostdev.c| 151 +++ src/util/virhostdev.h| 12 4 files changed, 166 insertions(+),

[libvirt] [PATCH v14 25/49] rename qemu*USBDevices to virHostdev*USBDevices

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 25a34e8..b72e9f9 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -234,9 +234,9

[libvirt] [PATCH v14 26/49] pass driver name to virHostdevPrepareUSBDevices

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index b72e9f9..0eb78ac 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -235,6 +235,7 @@ out:

[libvirt] [PATCH v14 18/49] move virHostdevPrepare(ReAttach)PCIDevices to virhostdev.c

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/libvirt_private.syms | 3 +- src/qemu/qemu_hostdev.c | 647 -- src/qemu/qemu_hostdev.h | 5 - src/qemu/qemu_process.c | 1 + src/util/virhostdev.c| 648 +++ src/

[libvirt] [PATCH v14 32/49] pass driver name as paramter to virHostdevReAttachUsbHostdevs

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 3d6396b..af1fe87 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -318,6 +318,7 @@ qemuDoma

[libvirt] [PATCH v14 20/49] extract general code from qemuUpdateActiveUsbHostdevs

2014-03-07 Thread Chunyan Liu
Extract general code from qemuUpdateActiveUsbHostdevs to virHostdevUpdateActiveUsbHostdevs. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index b

[libvirt] [PATCH v14 21/49] extract general code from qemuUpdateActiveScsiHostdevs

2014-03-07 Thread Chunyan Liu
Extract general code from qemuUpdateActiveScsiHostdevs to virHostdevUpdateActiveScsiHostdevs Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index

[libvirt] [PATCH v14 24/49] extract general code from qemuPrepareHostUSBDevices

2014-03-07 Thread Chunyan Liu
Extract general code from qemuPrepareHostUSBDevices to virHostdevPrepareHostUSBDevices. Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index

[libvirt] [PATCH v14 12/49] rename qemu*NetConfigRestore/Replace to virHostdevNetConfigRestore/Replace

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5dc68a6..d733fef 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qe

[libvirt] [PATCH v14 17/49] rename qemuReAttachPciDevice to virHostdevReAttachPciDevice

2014-03-07 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- src/qemu/qemu_hostdev.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5fa6eb4..2dfe252 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -1254,10 +1

  1   2   >