Re: [libvirt] [PATCH v5 0/3] support dumping guest memory in compressed format

[off-list] Hello, We have just added 'Comment 3' in bugzilla. On 03/06/2014 05:35 PM, Qiao, Nuohan/乔 诺涵 wrote: dumping guest's memroy is introduced without compression supported, and this is a freature regression of 'virsh dump --memory-only'. This patchset is used to add support in

[libvirt] [PATCH] docs: add VMmanager to web apps

This is a request for adding a VMmanager application as requested and described by Ksenya Phil. Signed-off-by: Ksenya Phil philka2...@mail.ru Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/apps.html.in | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/apps.html.in

[libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

When I played with virtlockd I was stunned by lacking documentation. My frustration got bigger when I had to read the patches to get the correct value to set in qemu.conf. Moreover, from pure libvirt-pride I'm changing commented value from sanlock to lockd. We want to favor our own

Re: [libvirt] [libvirt-java] [PATCH] Implement equals and hashCode methods for Connect and Domain

At Tue, 11 Mar 2014 11:18:57 +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/main/java/org/libvirt/Connect.java | 39 + src/main/java/org/libvirt/Domain.java | 52 ++-

Re: [libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

On Wed, Mar 12, 2014 at 08:59:42AM +0100, Michal Privoznik wrote: When I played with virtlockd I was stunned by lacking documentation. My frustration got bigger when I had to read the patches to get the correct value to set in qemu.conf. Moreover, from pure libvirt-pride I'm changing

Re: [libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

On 12.03.2014 11:31, Daniel P. Berrange wrote: On Wed, Mar 12, 2014 at 08:59:42AM +0100, Michal Privoznik wrote: When I played with virtlockd I was stunned by lacking documentation. My frustration got bigger when I had to read the patches to get the correct value to set in qemu.conf. Moreover,

Re: [libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

On Wed, Mar 12, 2014 at 11:47:24AM +0100, Michal Privoznik wrote: On 12.03.2014 11:31, Daniel P. Berrange wrote: On Wed, Mar 12, 2014 at 08:59:42AM +0100, Michal Privoznik wrote: When I played with virtlockd I was stunned by lacking documentation. My frustration got bigger when I had to read

[libvirt] [PATCH] nwfilter: Add ARP src/dst IP mask for ebtables ARP

From: Stefan Berger stef...@linux.vnet.ibm.com Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=862887 Add a netmask for the source and destination IP address for the ebtables --arp-ip-src and --arp-ip-dst options. Extend the XML parser with support for XML attributes for these netmasks

[libvirt] [PATCH] nwfilter: Add missing goto err_exit in error path

From: Stefan Berger stef...@linux.vnet.ibm.com https://bugzilla.redhat.com/show_bug.cgi?id=1071095 Add a missing goto err_exit in the error path where an unsupported value is assigned to the CTRL_IP_LEARNING key. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

[libvirt] libvirt: [PATCH] libxl: Check for control_d string to decide about dom0

I have been looking into a bug report (see BugLink) which reported libvirt to fail starting inside a Xen guest. Upon further investigation I found that some tools that help monitoring Xen guests will mount xenfs to /proc/xen. This will create a capabilities files there even if the guest is not

Re: [libvirt] libvirt: [PATCH] libxl: Check for control_d string to decide about dom0

On Wed, Mar 12, 2014 at 01:03:26PM +0100, Stefan Bader wrote: I have been looking into a bug report (see BugLink) which reported libvirt to fail starting inside a Xen guest. Upon further investigation I found that some tools that help monitoring Xen guests will mount xenfs to /proc/xen. This

Re: [libvirt] libvirt: [PATCH] libxl: Check for control_d string to decide about dom0

On Wed, 2014-03-12 at 13:03 +0100, Stefan Bader wrote: I have been looking into a bug report (see BugLink) which reported libvirt to fail starting inside a Xen guest. Upon further investigation I found that some tools that help monitoring Xen guests will mount xenfs to /proc/xen. This will

Re: [libvirt] libvirt: [PATCH] libxl: Check for control_d string to decide about dom0

On 12.03.2014 13:08, Ian Campbell wrote: On Wed, 2014-03-12 at 13:03 +0100, Stefan Bader wrote: I have been looking into a bug report (see BugLink) which reported libvirt to fail starting inside a Xen guest. Upon further investigation I found that some tools that help monitoring Xen guests

Re: [libvirt] [PATCH] docs: add VMmanager to web apps

On 03/12/2014 01:30 AM, Martin Kletzander wrote: This is a request for adding a VMmanager application as requested and described by Ksenya Phil. Signed-off-by: Ksenya Phil philka2...@mail.ru Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/apps.html.in | 9 + 1 file

[libvirt] [PATCH 0/7] Test parsing of iscsiadm output

Introduce virCommandSetMockOutputFile for faking output of asynchronous commands and use it to test parsing of iscsiadm output in virStorageBackendISCSISession and virStorageBackendISCSIScanTargets Ján Tomko (7): Change virStorageBackendISCSISession 'probe' arg to bool Introduce

[libvirt] [PATCH 1/7] Change virStorageBackendISCSISession 'probe' arg to bool

It quacks like a bool. --- src/storage/storage_backend_iscsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index ada6c48..531d044 100644 --- a/src/storage/storage_backend_iscsi.c +++

[libvirt] [PATCH 6/7] Add test for virStorageBackendISCSISession

Parse iscsiadm output with and without the recently introduced flashnode info. [1] This should check that commits like 57e17a7 (fixing [2]) do not break iscsiadm output parsing. [1] https://github.com/mikechristie/open-iscsi/commit/181af9a [2] https://bugzilla.redhat.com/show_bug.cgi?id=1067173

[libvirt] [PATCH 3/7] Use size_t for ndevice in pool source definition

This allows it to be used by the VIR_*_ELEMENT macros. Also use them for parsing the definiton and remove the redundant freeing of 'nodeset' before jumping to the cleanup label. --- src/conf/storage_conf.c | 23 ++- src/conf/storage_conf.h | 2 +- 2 files changed, 11

[libvirt] [PATCH 7/7] Add a test for virStorageBackendISCSIScanTargets

Check the iscsiadm output parsing by reading it from a file. --- src/storage/storage_backend_iscsi.c | 2 +- src/storage/storage_backend_iscsipriv.h | 5 ++ tests/storageiscsidata/iscsiadm_sendtargets | 6 +++ tests/storageiscsitest.c| 71

Re: [libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

On 03/12/2014 01:59 AM, Michal Privoznik wrote: When I played with virtlockd I was stunned by lacking documentation. My frustration got bigger when I had to read the patches to get the correct value to set in qemu.conf. Moreover, from pure libvirt-pride I'm changing commented value from

[libvirt] [PATCH 5/7] Add virCommandSetMockOutputFile

After this file is set, all commands executed will be replaced by cat file. This is useful for testing functions that parse output of asynchronous commands. --- src/libvirt_private.syms | 1 + src/util/vircommand.c | 33 + src/util/vircommandpriv.h | 1 + 3

[libvirt] [PATCH 4/7] Introduce vircommandpriv.h for functions used by tests

So far it's just virCommandSetDryRun. --- src/Makefile.am| 2 +- src/util/vircommand.c | 2 +- src/util/vircommand.h | 2 -- src/util/vircommandpriv.h | 28 tests/virkmodtest.c| 2 +-

[libvirt] [PATCH 4/7] Add ability to register callback for virCommand dry run

To allow for fault injection of the virCommand dry run, add the ability to register a callback. The callback will be passed the argv, env and stdin buffer and is expected to return the exit status and optionally fill stdout and stderr buffers. Signed-off-by: Daniel P. Berrange berra...@redhat.com

Re: [libvirt] [PATCH] nwfilter: Add missing goto err_exit in error path

On 03/12/2014 12:38 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com https://bugzilla.redhat.com/show_bug.cgi?id=1071095 Add a missing goto err_exit in the error path where an unsupported value is assigned to the CTRL_IP_LEARNING key. Signed-off-by: Stefan Berger

[libvirt] [PATCH 5/7] Introduce an object for managing firewall rulesets

The network and nwfilter drivers both have a need to update firewall rules. The currently share no code for interacting with iptables / firewalld. The nwfilter driver is fairly tied to the concept of creating shell scripts to execute which makes it very hard to port to talk to firewalld via DBus

[libvirt] [PATCH 1/7] Introduce a new set of helper macros for mocking symbols

Introduce virmock.h which provides some macros to assist in creation of LD_PRELOAD overrides. When these are used, the LD_PRELOAD code simply has some stubs which forward to a wrapper function inside the main test case. This means that logic for the test no longer has to be split between the

[libvirt] [PATCH 3/7] Switch systemd test to use generic dbus mock

Remove the virsystemdmock.la library and instead make use of the shared virmockdbus.la library Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/Makefile.am | 13 ++--- tests/virsystemdmock.c | 139 - tests/virsystemdtest.c |

[libvirt] [PATCH 2/7] Create a re-usable DBus LD_PRELOAD mock library

A number of test suites want to mock the DBus APIs. To avoid re-inventing the wheel create a re-usable virmockdbus.la library for LD_PRELOAD usage. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/Makefile.am | 11 +++-- tests/virmockdbus.c | 64

[libvirt] [PATCH 7/7] Convert ebtables code over to use firewall APIs

Convert the virebtables.{c,h} files to use the new virFirewall APIs for changing ebtables rules. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virebtables.c | 187 - 1 file changed, 46 insertions(+), 141 deletions(-) diff

[libvirt] libvirtError: this function is not supported by the connection driver: virInterfaceDefineXML

Hi, Could anyone help I'm getting the following error when I tried to add a new network interface. DETAILS Connection --- import libvirt conn = libvirt.open('qemu:///system') Interface XML -- interface type=bridge name=br0 start mode=onboot/ mtu

Re: [libvirt] [PATCH] qemu: Forbid sgio support for SCSI generic host device

On Fri, Mar 07, 2014 at 22:23:26 +0800, Osier Yang wrote: The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's unknow whether the way to support unprivileged SGIO for SCSI generic device will be similar as for SCSI block device or not, even it's

[libvirt] [PATCH 2/7] Introduce virStoragePoolSourceDeviceClear

Open-coding one VIR_FREE in the test suite just doesn't seem right. --- src/conf/storage_conf.c | 13 + src/conf/storage_conf.h | 1 + src/libvirt_private.syms | 1 + 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c

Re: [libvirt] [PATCH 4/7] Introduce vircommandpriv.h for functions used by tests

On Wed, Mar 12, 2014 at 02:08:14PM +0100, Ján Tomko wrote: So far it's just virCommandSetDryRun. --- src/Makefile.am| 2 +- src/util/vircommand.c | 2 +- src/util/vircommand.h | 2 -- src/util/vircommandpriv.h | 28

Re: [libvirt] [PATCH 5/7] Add virCommandSetMockOutputFile

On Wed, Mar 12, 2014 at 02:08:15PM +0100, Ján Tomko wrote: After this file is set, all commands executed will be replaced by cat file. I think this is a bit too special case and unecessarily forces use of an external cat command. I think your test would be easier if using this callback approach

Re: [libvirt] [PATCH 1/7] Change virStorageBackendISCSISession 'probe' arg to bool

On Wed, Mar 12, 2014 at 02:08:11PM +0100, Ján Tomko wrote: It quacks like a bool. --- src/storage/storage_backend_iscsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCH 7/7] Add a test for virStorageBackendISCSIScanTargets

On Wed, Mar 12, 2014 at 02:08:17PM +0100, Ján Tomko wrote: diff --git a/tests/storageiscsidata/iscsiadm_sendtargets b/tests/storageiscsidata/iscsiadm_sendtargets new file mode 100644 index 000..acea8ee --- /dev/null +++ b/tests/storageiscsidata/iscsiadm_sendtargets @@ -0,0 +1,6 @@

Re: [libvirt] [PATCH 3/7] Use size_t for ndevice in pool source definition

On Wed, Mar 12, 2014 at 02:08:13PM +0100, Ján Tomko wrote: This allows it to be used by the VIR_*_ELEMENT macros. Also use them for parsing the definiton and remove the redundant freeing of 'nodeset' before jumping to the cleanup label. --- src/conf/storage_conf.c | 23

Re: [libvirt] [PATCH 0/7] Test parsing of iscsiadm output

On Wed, Mar 12, 2014 at 02:08:10PM +0100, Ján Tomko wrote: Introduce virCommandSetMockOutputFile for faking output of asynchronous commands and use it to test parsing of iscsiadm output in virStorageBackendISCSISession and virStorageBackendISCSIScanTargets Ján Tomko (7): Change

Re: [libvirt] [PATCH] nwfilter: Add missing goto err_exit in error path

Ján Tomko jto...@redhat.com wrote on 03/12/2014 09:11:35 AM: On 03/12/2014 12:38 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com https://bugzilla.redhat.com/show_bug.cgi?id=1071095 Add a missing goto err_exit in the error path where an unsupported value is

Re: [libvirt] [PATCH 00/13] Add multiple trace backend function and add new ftrace backend for libvirt

On Mon, Mar 10, 2014 at 08:17:21AM +, yangzy.f...@cn.fujitsu.com wrote: From: Xinghai Yu yuxing...@cn.fujitsu.com This patch set will let libvirt to support multiple trace backend function and add a new 'ftrace' backend at the same time. Then, libvirt would have 2 trace backend: dtrace,

Re: [libvirt] [PATCH v14 20/49] extract general code from qemuUpdateActiveUsbHostdevs

On Fri, Mar 07, 2014 at 06:52:47PM +0800, Chunyan Liu wrote: Extract general code from qemuUpdateActiveUsbHostdevs to virHostdevUpdateActiveUsbHostdevs. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7

Re: [libvirt] [PATCH v14 19/49] extract general code from qemuUpdateActivePciHostdevs

On Fri, Mar 07, 2014 at 06:52:46PM +0800, Chunyan Liu wrote: Extract general code from qemuUpdateActivePciHostdevs to virHostdevUpdateActivePciHostdevs. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7

Re: [libvirt] [PATCH v14 21/49] extract general code from qemuUpdateActiveScsiHostdevs

On Fri, Mar 07, 2014 at 06:52:48PM +0800, Chunyan Liu wrote: Extract general code from qemuUpdateActiveScsiHostdevs to virHostdevUpdateActiveScsiHostdevs Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7

Re: [libvirt] [PATCH v14 22/49] pass driver_name as parameter of virHostdevUpdate*Hostdevs functions

On Fri, Mar 07, 2014 at 06:52:49PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v14 18/49] move virHostdevPrepare(ReAttach)PCIDevices to virhostdev.c

On Fri, Mar 07, 2014 at 06:52:45PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 +- src/qemu/qemu_hostdev.c | 647 -- src/qemu/qemu_hostdev.h | 5 - src/qemu/qemu_process.c | 1 +

Re: [libvirt] [PATCH 4/7] Introduce vircommandpriv.h for functions used by tests

On 03/12/2014 03:24 PM, Daniel P. Berrange wrote: On Wed, Mar 12, 2014 at 02:08:14PM +0100, Ján Tomko wrote: So far it's just virCommandSetDryRun. --- src/Makefile.am| 2 +- src/util/vircommand.c | 2 +- src/util/vircommand.h | 2 --

Re: [libvirt] [PATCH v14 23/49] move virHostdevUpdate* functions to virhostdev.c

On Fri, Mar 07, 2014 at 06:52:50PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 + src/qemu/qemu_hostdev.c | 151 --- src/util/virhostdev.c| 151

Re: [libvirt] [PATCH v14 25/49] rename qemu*USBDevices to virHostdev*USBDevices

On Fri, Mar 07, 2014 at 06:52:52PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v14 24/49] extract general code from qemuPrepareHostUSBDevices

On Fri, Mar 07, 2014 at 06:52:51PM +0800, Chunyan Liu wrote: Extract general code from qemuPrepareHostUSBDevices to virHostdevPrepareHostUSBDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 27 +++ 1 file changed, 19 insertions(+), 8

Re: [libvirt] [PATCH v14 26/49] pass driver name to virHostdevPrepareUSBDevices

On Fri, Mar 07, 2014 at 06:52:53PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/

Re: [libvirt] [PATCH v14 29/49] pass driver name as parameter to virHostdevPrepareSCSIDevices

On Fri, Mar 07, 2014 at 06:52:56PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v14 27/49] move virHostdevPrepareHostUSBDevices to virhostdev.c

On Fri, Mar 07, 2014 at 06:52:54PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 217 --- src/util/virhostdev.c| 216

Re: [libvirt] [PATCH v14 28/49] extract general code from qemuPrepareHostSCSIDevices

On Fri, Mar 07, 2014 at 06:52:55PM +0800, Chunyan Liu wrote: Extract general code from qemuPrepareHostSCSIDevices to virHostdevPrepareHostSCSIDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 63 + 1 file

Re: [libvirt] [PATCH v14 30/49] move virHostdevPrepareHostSCSIDevices to virhostdev.c

On Fri, Mar 07, 2014 at 06:52:57PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 111 --- src/util/virhostdev.c| 111

Re: [libvirt] [PATCH v14 31/49] extract general code from qemuDomainReAttachHostUsbDevices

On Fri, Mar 07, 2014 at 06:52:58PM +0800, Chunyan Liu wrote: Extract general code from qemuDomainReAttachHostUsbDevices to virHostdevDomainReAttachHostUsbDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 23 --- 1 file changed, 16

Re: [libvirt] [PATCH v14 32/49] pass driver name as paramter to virHostdevReAttachUsbHostdevs

On Fri, Mar 07, 2014 at 06:52:59PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory s/freature/feature/ but I would not use the word regression

Re: [libvirt] [PATCH v14 34/49] extract general code from qemuDomainReAttachHostScsiDevices

On Fri, Mar 07, 2014 at 06:53:01PM +0800, Chunyan Liu wrote: Extract general code from qemuDomainReAttachHostScsiDevices to virHostdevDomainReAttachHostScsiDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 40 +++- 1 file

Re: [libvirt] [PATCH v14 33/49] move virHostdevReAttachUsbHostdevs to virhostdev.c

On Fri, Mar 07, 2014 at 06:53:00PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 66 src/util/virhostdev.c| 66

Re: [libvirt] [PATCH v14 37/49] extract general code of NodeDeviceDetach

On Fri, Mar 07, 2014 at 06:53:04PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v14 35/49] pass driver name as parameter to virHostdevReAttachScciHostdevs

On Fri, Mar 07, 2014 at 06:53:02PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/

Re: [libvirt] [PATCH v14 36/49] move virHostdevReAttachHostScsiDevices to virhostdev.c

On Fri, Mar 07, 2014 at 06:53:03PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 62 src/util/virhostdev.c| 62

Re: [libvirt] [PATCH v14 39/49] extract general code of NodeDeviceReset

On Fri, Mar 07, 2014 at 06:53:06PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v14 38/49] extract general code of NodeDeviceReAttach

On Fri, Mar 07, 2014 at 06:53:05PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 61 +- 1 file changed, 36 insertions(+), 25 deletions(-) ACK Regards, Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH v14 40/49] move virHostdevNodeDevice* to virhostdev.c

On Fri, Mar 07, 2014 at 06:53:07PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 ++ src/qemu/qemu_driver.c | 81 src/util/virhostdev.c| 81

Re: [libvirt] [PATCH v14 41/49] improve parameter name to let it more meaningful

On Fri, Mar 07, 2014 at 06:53:08PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virhostdev.c | 44 +++- src/util/virhostdev.h | 12 ++-- 2 files changed, 29 insertions(+), 27 deletions(-) ACK Regards,

Re: [libvirt] [PATCH v14 43/49] improve virHostdevUpdate* parameters to make it more widely used

On Fri, Mar 07, 2014 at 06:53:10PM +0800, Chunyan Liu wrote: Changes parameter from vm def to specific hostdevs info and name info, so that it could be used more widely, e.g, could be used without full vm def info. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 9

Re: [libvirt] [PATCH v14 44/49] add 3 wrapper functions for prepare/reattach/update domain hostdevs

On Fri, Mar 07, 2014 at 06:53:11PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 4 ++ src/util/virhostdev.c| 103 +++ src/util/virhostdev.h| 20 + 3 files changed, 127

Re: [libvirt] [PATCH v5 2/3] add qemu support to virDomainCoreDumpWithFormat API

On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: s/to/for/ in the $SUBJ or you can rephrase it to: qemu: add support for virDomainCoreDumpWithFormat API This patch makes qemu driver supprot virDomainCoreDumpWithFormat API. s/supprot/support/ And again like with

Re: [libvirt] [PATCH] qemu: Forbid sgio support for SCSI generic host device

On 12/03/14 21:54, Jiri Denemark wrote: On Fri, Mar 07, 2014 at 22:23:26 +0800, Osier Yang wrote: The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's unknow whether the way to support unprivileged SGIO for SCSI generic device will be similar as for

Re: [libvirt] [PATCH v14 45/49] add parameter checks to common interfaces

On Fri, Mar 07, 2014 at 06:53:12PM +0800, Chunyan Liu wrote: Check NULL parameter inputs Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virhostdev.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/src/util/virhostdev.c

Re: [libvirt] [PATCH v5 3/3] allow virsh dump --memory-only specify dump format

On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: This patch is used to add --compress and [--compression-format] string to s/is used to add/adds/ virsh dump --memory-only. And virsh dump --memory-only is going be implemented by new virDomainCoreDumpWithFormat API.

Re: [libvirt] [PATCH v14 42/49] rename some function names to keep consistency

On Fri, Mar 07, 2014 at 06:53:09PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 8 src/qemu/qemu_hostdev.c | 16 +++ src/util/virhostdev.c| 52

[libvirt] [PATCHv2 0/7] arbitrary qemu monitor events

v1 was here: https://www.redhat.com/archives/libvir-list/2014-February/msg0.html Many of the patches in the series were acked back then, but the 'virsh' changes were made conditional on getting 'virsh event' working first, so it missed the last release. Changes in v2: rebase to master,

[libvirt] [PATCHv2 1/7] qemu: new API for tracking arbitrary monitor events

Several times in the past, qemu has implemented a new event, but libvirt has not yet caught up to reporting that event to the user applications. While it is possible to track libvirt logs to see that an unknown event was received and ignored, it would be nicer to copy what 'virsh

[libvirt] [PATCHv2 6/7] qemu: enable monitor event filtering by name

Filtering monitor events by name requires tracking the name for the duration of the filtering. In order to free the name, I found it easiest to just piggyback on the user's freecb function, which gets called when the event is deregistered. For events without a name filter, we have the design of

[libvirt] [PATCHv2 4/7] qemu: wire up RPC for qemu monitor events

These are the first async events in the qemu protocol, so this patch looks rather big compared to most RPC additions. However, a large majority of this patch is just mechanical copy-and-paste from recently-added network events. It didn't help that this is also the first virConnect rather than

[libvirt] [PATCHv2 5/7] qemu: enable monitor event reporting

Wire up all the pieces to send arbitrary qemu events to a client using libvirt-qemu.so. If the extra bookkeeping of generating event objects even when no one is listening turns out to be noticeable, we can try to further optimize things by adding a counter for how many connections are using

[libvirt] [PATCHv2 3/7] qemu: create object for qemu monitor events

Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c (virDomainQemuMonitorEventClass): New class.

[libvirt] [PATCHv2 7/7] qemu: allow filtering events by regex

When listening for a subset of monitor events, it can be tedious to register for each event name in series; nicer is to register for multiple events in one go. Implement a flag to use regex interpretation of the event filter. While at it, prove how much I hate the shift key, by adding a way to

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory

Re: [libvirt] [PATCH 5/7] Add virCommandSetMockOutputFile

On 03/12/2014 03:26 PM, Daniel P. Berrange wrote: On Wed, Mar 12, 2014 at 02:08:15PM +0100, Ján Tomko wrote: After this file is set, all commands executed will be replaced by cat file. I think this is a bit too special case and unecessarily forces use of an external cat command. I think

Re: [libvirt] [PATCH] Load CPU map from builddir when run uninstalled

On Tue, Mar 11, 2014 at 11:05:34 +0100, Jiri Denemark wrote: On Mon, Mar 10, 2014 at 12:31:00 -0600, Eric Blake wrote: On 03/10/2014 09:26 AM, Jiri Denemark wrote: When libvirtd is run from a build directory without being installed, it should not depend on files from a libvirt package

[libvirt] [PATCH] Make ABI stability issue easier to debug

When ABI stability check fails, we only log the error message describing the incompatibility. Let's log both XMLs in case of an error to make it easier to analyze where and why the stability check failed. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/conf/domain_conf.c | 125

Re: [libvirt] [PATCH] Make ABI stability issue easier to debug

On 03/12/2014 09:52 AM, Jiri Denemark wrote: When ABI stability check fails, we only log the error message describing the incompatibility. Let's log both XMLs in case of an error to make it easier to analyze where and why the stability check failed. Signed-off-by: Jiri Denemark

[libvirt] [PATCHv2 2/7] qemu: virsh wrapper for qemu events

Any new API deserves a good virsh wrapper :) qemu-monitor-event [domain] [event] [--pretty] [--loop] [--timeout number] Very similar to the previous work on 'virsh event'. For an example session: $ virsh -c qemu:///system qemu-monitor-event --event SHUTDOWN $ virsh -c qemu:///system start

Re: [libvirt] [PATCH v14 48/49] add hostdev pci backend type for xen

On Fri, Mar 07, 2014 at 06:53:15PM +0800, Chunyan Liu wrote: Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use pciback as stub driver. Signed-off-by: Chunyan Liu cy...@suse.com --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 3 ++-

Re: [libvirt] [PATCH v14 46/49] add unit test for new virhostdev common library

On Fri, Mar 07, 2014 at 06:53:13PM +0800, Chunyan Liu wrote: Add unit test for hostdev common library. Current tests are based on virpcimock. Signed-off-by: Chunyan Liu cy...@suse.com --- .gitignore | 1 + tests/Makefile.am | 5 + tests/virhostdevtest.c | 507

Re: [libvirt] [PATCH v14 49/49] add pci passthrough to libxl driver

On Fri, Mar 07, 2014 at 06:53:16PM +0800, Chunyan Liu wrote: Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_conf.c | 63 +++ src/libxl/libxl_conf.h

Re: [libvirt] [PATCH v14 47/49] change lxc_hostdev.c to use virhostdev common library APIs

On Fri, Mar 07, 2014 at 06:53:14PM +0800, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/lxc/lxc_hostdev.c | 305 ++ 1 file changed, 10 insertions(+), 295 deletions(-) ACK Regards, Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH v14 00/49] write separate module for hostdev passthrough

On Fri, Mar 07, 2014 at 06:52:27PM +0800, Chunyan Liu wrote: These patches implements a separate module for hostdev passthrough so that it could be shared by different drivers and can maintain a global state of a host device. Patch 1: fix memory leak in virscsi.c Patch 2: improve

Re: [libvirt] [python PATCH 1/2] qemu: support arbitrary monitor events

On 02/04/2014 07:01 PM, Eric Blake wrote: Wrap the new virConnectDomainQemuMonitorEventRegister function being added in libvirt 1.2.2. This patch copies heavily from network events (commit 6ea5be0) and from event loop callbacks in libvirt-override.c, since in the libvirt_qemu module, we must

Re: [libvirt] [libvirt-python PATCH] setup: Make libvirt API XML path configurable

Revisiting an older thread On 11/26/2013 07:38 AM, Martin Kletzander wrote: On Tue, Nov 26, 2013 at 10:14:36AM +, Daniel P. Berrange wrote: On Tue, Nov 26, 2013 at 10:58:25AM +0100, Martin Kletzander wrote: Adding a support for LIBVIRT_API_PATH evironment variable, which can control where

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory in kdump-compressed format. This patch is adding new

[libvirt] [PATCH] Fix type mismatch of virNetDev*NetConfig on non-Linux

Commit b4bbaee changed char* to const char*, but omitted the non-Linux version. --- Pushed as a build breaker fix. src/util/virnetdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 9d8b7cf..55781b2 100644 ---

Re: [libvirt] [PATCH v5 3/3] allow virsh dump --memory-only specify dump format

On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: This patch is used to add --compress and [--compression-format] string to virsh dump --memory-only. And virsh dump --memory-only is going be implemented by new virDomainCoreDumpWithFormat API. Signed-off-by: Qiao

[libvirt] RFC: Exposing backing chains in domain XML

tl;dr: I am working on a series of patches to expose backing chain information in domain XML. Comments are welcome, to make sure my XML design is on the right track. Purpose === Among other things, this will help us support Peter's proposal of enhancing the block-pull and block-commit

Re: [libvirt] RFC: Exposing backing chains in domain XML

On 03/12/14 21:21, Eric Blake wrote: tl;dr: I am working on a series of patches to expose backing chain information in domain XML. Comments are welcome, to make sure my XML design is on the right track. ... Existing design === ... a domain, and recursively show the entire

[libvirt] [PATCH] Fix Invalid write in virCryptoHashString()

While running vircryptotest, it was found that valgrind pointed out the following error: ==27453== Invalid write of size 1 ==27453==at 0x4C7D7C9: virCryptoHashString (vircrypto.c:76) ==27453==by 0x401C4E: testCryptoHash (vircryptotest.c:41) ==27453==by 0x402A11: virtTestRun

Re: [libvirt] [PATCH] Fix Invalid write in virCryptoHashString()

On 03/12/2014 03:44 PM, Nehal J Wani wrote: While running vircryptotest, it was found that valgrind pointed out the following error: ==27453== Invalid write of size 1 ==27453==at 0x4C7D7C9: virCryptoHashString (vircrypto.c:76) --- The errors go away, if I either do: Line 76:

  1   2   >