This partially reverts commits b279e52f7 and ea18f8b2.
It turns out our code base is full of:
if ((struct.member = virBlahFromString(str)) < 0)
goto error;
Meanwhile, the C standard says it is up to the compiler whether
an enum is signed or unsigned when all of its declared values
happen to
Ján Tomko wrote:
> On 05/16/2014 06:16 AM, Jim Fehlig wrote:
>
>> V3 of Michal's series to honor relabel='no' in device config
>>
>> https://www.redhat.com/archives/libvir-list/2014-April/msg00196.html
>>
>> In V3, the patches have been further split to ease review as requested
>> by Jan Tomko.
Ján Tomko wrote:
> On 05/16/2014 06:16 AM, Jim Fehlig wrote:
>
>> The DAC driver ignores the relabel='no' attribute in chardev config
>>
>>
>>
>>
>>
>>
>>
>>
>> This patch avoids labeling chardevs when relabel='no' is specified.
>>
>> Signed-off-by: Michal Privoznik
Now that qemu 2.0 allows commit of the active layer, people are
attempting to use virsh blockcommit and getting into a stuck
state, because libvirt is unprepared to handle the two-phase
commit required by qemu.
Stepping back a bit, there are two valid semantics for a
commit operation:
1. Maintain
Eric Blake wrote:
> On 05/14/2014 04:45 PM, Eric Blake wrote:
>
>> For internal structs, we might as well be type-safe and let the
>> compiler help us with less typing required on our part (getting
>> rid of casts is always nice). In trying to use enums directly,
>> I noticed two problems in vi
On 05/14/2014 04:45 PM, Eric Blake wrote:
> For internal structs, we might as well be type-safe and let the
> compiler help us with less typing required on our part (getting
> rid of casts is always nice). In trying to use enums directly,
> I noticed two problems in virstoragefile.h that can't be
On Fri, May 16, 2014 at 01:53:50PM -0400, Daniel P. Berrange wrote:
> Hi Libvirt team,
>
> A number of opensource projects have weekly meetings between their community
> of contributors to facilitate their day-to-day working and particularly
> to resolve roadblocks that people are having.
>
> I f
Hi Libvirt team,
A number of opensource projects have weekly meetings between their community
of contributors to facilitate their day-to-day working and particularly
to resolve roadblocks that people are having.
I feel that libvirt is large enough, with contributors from many different
organizati
In a number of APIs, the text implied that a user might have
- but common convention is to use "vda",
not "xvda". For example, virDomainGetDiskErrors was correct,
while virDomainBlockStats was confusing.
* src/libvirt.c: Make examples consistent.
Signed-off-by: Eric Blake
---
Copy and paste i
On 05/16/14 16:57, Ján Tomko wrote:
> We allow a seclabel to be specified in the element
> of a chardev:
>
>
>
>
>
>
>
> But we format it outside the source:
>
>
>
>
>
>
>
> Move the formatting inside the source to fix this to make the
> seclabel persistent across XML
On 05/16/14 16:59, Ján Tomko wrote:
> ---
> docs/formatdomain.html.in | 6 ++
> 1 file changed, 6 insertions(+)
>
ACK,
Peter
signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, May 16, 2014 at 08:18:36AM -0600, Eric Blake wrote:
> On 05/16/2014 07:54 AM, Daniel P. Berrange wrote:
>
> >>
> >>
> >>
> >>
> >>
> >>
On 05/13/2014 01:51 PM, Laine Stump wrote:
> Inspired by a simpler patch from "Wangrui (K) ".
>
> A submitted patch pointed out that virNetlinkCommand() was doing an
> improper typecast of the return value from nl_recv() (int to
> unsigned), causing it to miss error returns, and that even after
>
On Fri, May 9, 2014 at 12:50 PM, Alex Williamson wrote:
> The driver_override field allows us to specify the driver for a device
> ...
>
...
> Signed-off-by: Alex Williamson
> Cc: Greg Kroah-Hartman
>
Reviewed-by: Konrad Rzeszutek Wilk
--
libvir-list mailing list
libvir-list@redhat.com
https
On Fri, May 16, 2014 at 04:52:21PM +0200, Igor Mammedov wrote:
> On Thu, 15 May 2014 11:03:49 -0300
> Eduardo Habkost wrote:
> > On Thu, May 15, 2014 at 03:48:16PM +0200, Igor Mammedov wrote:
[...]
> > >
> > > Can't we add query-cpus QMP command or something like this to hide path
> > > from user
---
docs/formatdomain.html.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 76b2bc2..691a451 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -4311,6 +4311,12 @@ qemu-kvm -net nic,model=? /dev/null
We allow a seclabel to be specified in the element
of a chardev:
But we format it outside the source:
Move the formatting inside the source to fix this to make the
seclabel persistent across XML format->parse.
Introduced by commit f8b08d0 'Add to character devices.'
Am 15.05.2014 14:35, schrieb Igor Mammedov:
> PS:
> As side effect cpu/apic will disappear from "info qtree" HMP command output.
Solutions are already on the list and in need of feedback:
http://patchwork.ozlabs.org/patch/317224/
http://patchwork.ozlabs.org/patch/343136/
http://patchwork.ozlabs.o
On Fri, May 16, 2014 at 10:48:00AM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, May 9, 2014 at 12:50 PM, Alex Williamson > wrote:
>
> > The driver_override field allows us to specify the driver for a device
> > ...
> >
> ...
>
> > Signed-off-by: Alex Williamson
> > Cc: Greg Kroah-Hartman
> >
On Thu, 15 May 2014 11:03:49 -0300
Eduardo Habkost wrote:
> On Thu, May 15, 2014 at 03:48:16PM +0200, Igor Mammedov wrote:
> > On Thu, 15 May 2014 10:07:51 -0300
> > Eduardo Habkost wrote:
> >
> > > On Thu, May 15, 2014 at 02:35:01PM +0200, Igor Mammedov wrote:
> > > > On Tue, 06 May 2014 22:29
The Friday 16 May 2014 à 08:20:22 (-0600), Eric Blake wrote :
> On 05/16/2014 08:07 AM, Peter Krempa wrote:
>
> >>>
> >>> It feels rather odd to have elements but no top level
> >>> disk images. Really these are all top level images
> >>
> >> It reflect the ways QEMU does it. A single BlockDriver
On 05/16/2014 04:33 AM, Benoît Canet wrote:
>
>
> I want to make use of the new backingStore xml element to implement quorum.
>
>
>
On 05/16/2014 08:07 AM, Peter Krempa wrote:
>>>
>>> It feels rather odd to have elements but no top level
>>> disk images. Really these are all top level images
>>
>> It reflect the ways QEMU does it. A single BlockDriverState holding n
>> quorum BlockDriverState children. There is a 1-1 mapping.
On 05/16/2014 07:54 AM, Daniel P. Berrange wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
On 05/16/14 16:05, Benoît Canet wrote:
> The Friday 16 May 2014 à 09:54:43 (-0400), Daniel P. Berrange wrote :
>> On Fri, May 16, 2014 at 12:33:04PM +0200, Benoît Canet wrote:
>>>
>>> Hello list,
>>>
>>>
In subject:
s/Fix/conf: Fix/
On 05/16/14 15:23, Ján Tomko wrote:
> We allow a seclabel to be specified in the element
> of a chardev:
>
>
>
>
>
>
There is one paragraph mentioning that in the XML format documentation.
I think it would be worth adding (as a separate patch) an examp
The Friday 16 May 2014 à 09:54:43 (-0400), Daniel P. Berrange wrote :
> On Fri, May 16, 2014 at 12:33:04PM +0200, Benoît Canet wrote:
> >
> > Hello list,
> >
> >
On Fri, May 16, 2014 at 12:33:04PM +0200, Benoît Canet wrote:
>
> Hello list,
>
>
>
> I want to implement libvirt Quorum support.
On Thu, May 15, 2014 at 11:50:54AM +0200, Jiri Denemark wrote:
> On Wed, May 14, 2014 at 15:18:09 +0800, Chen Fan wrote:
> > For now, we set the migration URI via command line '--migrate_uri' or
> > construct the URI by looking up the dest host's hostname which could be
> > solved by DNS automatica
in subject:
s/Rename/conf: Rename/
On 05/16/14 15:23, Ján Tomko wrote:
> Drop the 'Disk' from the name, as there is nothing disk-specific
> about the function.
> ---
> src/conf/domain_conf.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
ACK, good to see i
Ján Tomko (2):
Rename virDomainDiskSourceDefFormatSeclabel
Fix seclabels for chardevs
src/conf/domain_conf.c | 51 ++
.../qemuxml2argv-chardev-label.xml | 40 +
tests/qemuxml2xmltest.c|
Drop the 'Disk' from the name, as there is nothing disk-specific
about the function.
---
src/conf/domain_conf.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e5ae7c6..041a113 100644
--- a/src/con
We allow a seclabel to be specified in the element
of a chardev:
But we format it outside the source:
Move the formatting inside the source to fix this to make the
seclabel persistent across XML format->parse.
Introduced by commit f8b08d0 'Add to character devices.'
On Fri, 16 May 2014 00:11:24 -0600
Eric Blake wrote:
> > Is "no stats yet" really an error?
This is a special case where the guest hasn't ever filled QEMU with balloon
stats. There are two possible cases. Either the guest hasn't done it yet, but
will do in the future or the guest will never do
Hello list,
I want to implement libvirt Quorum support.
(https://github.com/qemu/qemu/commit/c88a1de51ab2f26a9a
On 05/16/2014 06:16 AM, Jim Fehlig wrote:
> V3 of Michal's series to honor relabel='no' in device config
>
> https://www.redhat.com/archives/libvir-list/2014-April/msg00196.html
>
> In V3, the patches have been further split to ease review as requested
> by Jan Tomko.
>
> Jim Fehlig (7):
> sec
On 05/16/2014 06:16 AM, Jim Fehlig wrote:
> When relabel='no' at the domain level, there is no need to call
> the hostdev relabeling functions.
>
> Signed-off-by: Michal Privoznik
> Signed-off-by: Jim Fehlig
> ---
> src/security/security_dac.c | 10 --
> 1 file changed, 8 insertions(+),
On 05/16/2014 06:16 AM, Jim Fehlig wrote:
> The DAC driver ignores the relabel='no' attribute in chardev config
>
>
>
>
>
>
>
>
> This patch avoids labeling chardevs when relabel='no' is specified.
>
> Signed-off-by: Michal Privoznik
> Signed-off-by: Jim Fehlig
> --
On 05/13/2014 11:01 AM, Chen Hanxiao wrote:
> Signed-off-by: Chen Hanxiao
> ---
> src/util/vircgroup.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
> index fce380a..c578bd0 100644
> --- a/src/util/vircgroup.c
> +++
On 14.5.2014 05:41, tomoki.sekiy...@hds.com wrote:
> From: Tomoki Sekiyama
>
> Hello Michael,
>
> Thank you for posting v2.
> May be we should add following diff to avoid sanitytest.pl's
> mapping error.
>
> ---
> diff --git a/sanitytest.py b/sanitytest.py
> index cff30d5..62fe42b 100644
> ---
ping
> -Original Message-
> From: Chen, Hanxiao/陈 晗霄
> Sent: Tuesday, May 13, 2014 4:01 PM
> To: libvir-list@redhat.com
> Cc: Chen, Hanxiao/陈 晗霄
> Subject: [libvirt][PATCH] vircgroup: Don't leak keypath if failed to kill
> process
>
> Signed-off-by: Chen Hanxiao
> ---
> src/util/vircgr
41 matches
Mail list logo
