[libvirt] [PATCH] qemu: Make virFileFindHugeTLBFS fault tolerant

2014-08-06 Thread Michal Privoznik
Since commit be0782e1 we are parsing /proc/meminfo to find out the default huge page size. However, if the host we are running at does not support any huge pages (e.g. CONFIG_HUGETLB_PAGE is turned off), we will not successfully parse the meminfo file and hence the whole qemu driver init process

Re: [libvirt] handle different version of QEMU

2014-08-06 Thread Matthias Gatto
I'm targeting an existing QMP commands, the commands block_set_io_throttle, which is already implemented in libvirt, but since the version 1.7 of QEMU new optional arguments have been add to it, but libvirt didn't handle these new arguments. On Tue, Aug 5, 2014 at 6:57 PM, Eric Blake

Re: [libvirt] [RFC PATCH 2/5] conf: Parse and format ivshmem device XML

2014-08-06 Thread Wang Rui
On 2014/8/6 0:48, Maxime Leroy wrote: This patch adds configuration support for the ivshmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/conf/domain_conf.c | 234 ++-

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

2014-08-06 Thread Christophe Fergeau
Hey, Thanks for the detailed explanation! On Tue, Aug 05, 2014 at 03:52:17PM +0200, Timm Bäder wrote: Also in reply to the 0/4: It will modify the existing one, as long as you don't change the name. Like if you use get_config, then set_description on that config and then _set_config again,

Re: [libvirt] [RFC PATCH 1/5] doc: schema: Add basic documentation for the ivshmem support

2014-08-06 Thread Wang Rui
On 2014/8/6 0:48, Maxime Leroy wrote: This patch documents XML elements used for support of ivshmem devices. About ivshmem, please see the following documentation: http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/ivshmem_device_spec.txt (Ivshmem documentation for qemu will be updated

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

2014-08-06 Thread Himanshu Sharma
Thanks for your response. I just wanted to know is there any way to fix this issue. Please provide me with the command that will help me to create Clone of VM running on ESXi also if possible also share the way to create Template of the VM running on ESXi. It would be easier if we could manager

Re: [libvirt] [PATCH] qemu: Make virFileFindHugeTLBFS fault tolerant

2014-08-06 Thread Martin Kletzander
On Wed, Aug 06, 2014 at 10:44:55AM +0200, Michal Privoznik wrote: Since commit be0782e1 we are parsing /proc/meminfo to find out the default huge page size. However, if the host we are running at does not support any huge pages (e.g. CONFIG_HUGETLB_PAGE is turned off), we will not successfully

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

2014-08-06 Thread Christophe Fergeau
Hey Himanshu, On Wed, Aug 06, 2014 at 09:44:20AM +, Himanshu Sharma wrote: Thanks for your response. I just wanted to know is there any way to fix this issue. Please provide me with the command that will help me to create Clone of VM running on ESXi also if possible also share the way to

Re: [libvirt] [RFC PATCH 4/5] qemu: Build command line for ivshmem device

2014-08-06 Thread Wang Rui
On 2014/8/6 0:48, Maxime Leroy wrote: This patch implements support for the ivshmem device in QEMU. Example from this xml: ivshmem server='yes'' role='master'/ s/'yes''/'yes' source file='/tmp/socket-ivshmem0'/ size unit='M'32/size msi vectors='32'

Re: [libvirt] [RFC PATCH 0/5] ivshmem support

2014-08-06 Thread Wang Rui
On 2014/8/6 0:48, Maxime Leroy wrote: The following patches are an implementation proposal for the ivshmem device support in libvirt. Any feedback is welcome. Note: SELinux is not supported (need to be done for the next patchset version) Just some questiones: Is there only one

[libvirt] [PATCH] Node Devices: Fix nodedev-list for fc_host vports.

2014-08-06 Thread Prerna Saxena
In a system with Fiber Channel Host Adapters, a query to list all Fibre Channel HBAs OR Vports currently returns empty list: $ virsh nodedev-list --cap fc_host $ Libvirt correctly discovers properties for all HBAs. However, the reporting fails because of incorrect flag comparison while

Re: [libvirt] [libvirt-glib] [PATCH 1/4] GVirDomainSnapshot: Add _is_current

2014-08-06 Thread Zeeshan Ali (Khattak)
On Tue, Aug 5, 2014 at 11:13 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Sat, Aug 02, 2014 at 10:41:46AM +0200, m...@baedert.org wrote: From: Timm Bäder m...@baedert.org Add a way to determine if the given GVirDomainSnapshot is the current snapshot of its GVirDomain. ---

Re: [libvirt] [PATCH] Node Devices: Fix nodedev-list for fc_host vports.

2014-08-06 Thread John Ferlan
On 08/06/2014 06:20 AM, Prerna Saxena wrote: In a system with Fiber Channel Host Adapters, a query to list all Fibre Channel HBAs OR Vports currently returns empty list: $ virsh nodedev-list --cap fc_host $ Libvirt correctly discovers properties for all HBAs. However, the

[libvirt] [PATCH] snapshot: conf: Enforce absolute paths on disk and memory images

2014-08-06 Thread Peter Krempa
RNG schema as well as the qemu driver requires absolute paths for memory and disk snapshot image files but the XML parser was not enforcing it. Add checks to avoid problems in qemu where the configuration it creates is invalid. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1126329 ---

Re: [libvirt] Error

2014-08-06 Thread Eric Blake
On 08/05/2014 10:55 PM, ahmad jan wrote: I want to configure Libvirt-1.2.7 on ubuntu and found the following Error Could not find linxml2 anywhere That's not the actual error message you saw, as the string linxml2 does not appear anywhere in the libvirt sources. Please copy and paste exact

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Yuanzhen Gu
Thanks very much Eric! This is exactly what I guessed, I just wondering where I could find this piece of code and control the the pause time of guest, while the snapshot being taken? thanks ! Best, Yuanzhen On Tue, Aug 5, 2014 at 6:30 PM, Eric Blake ebl...@redhat.com wrote: On 08/05/2014

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

2014-08-06 Thread Timm Bäder
On 06.08, Christophe Fergeau wrote: Hey, Thanks for the detailed explanation! On Tue, Aug 05, 2014 at 03:52:17PM +0200, Timm Bäder wrote: Also in reply to the 0/4: It will modify the existing one, as long as you don't change the name. Like if you use get_config, then set_description

Re: [libvirt] [PATCH] qemu: Make virFileFindHugeTLBFS fault tolerant

2014-08-06 Thread Jim Fehlig
Michal Privoznik wrote: Since commit be0782e1 we are parsing /proc/meminfo to find out the default huge page size. However, if the host we are running at does not support any huge pages (e.g. CONFIG_HUGETLB_PAGE is turned off), we will not successfully parse the meminfo file and hence the

[libvirt] [PATCH V3 00/24] xen_xm parsing code refactor

2014-08-06 Thread David Kiarie
Kiarie Kahurani (24): src/xenxs:Refactor code parsing memory config src/xenxs:Refactor code parsing virtual time config src/xenxs:Refactor code parsing event actions src/xenxs:Refactor code parsing PCI config src/xenxs:Refactor code parsing CPU features src/xenxs:Refactor code parsing

[libvirt] [PATCH V3 06/24] src/xenxs:Refactor code parsing xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMDisk(virConfPtr conf, ); which parses xm disk config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 322 - 1 file changed,

[libvirt] [PATCH V3 03/24] src/xenxs:Refactor code parsing event actions

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMEventActions(virConfPtr conf,) which parses events leading to certain actions signed-off-by: David Kiariedavidkia...@gmail.com --- src/xenxs/xen_xm.c | 61 +-

[libvirt] [PATCH V3 02/24] src/xenxs:Refactor code parsing virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMTimeOffset(virConfPtr conf,...); which parses time offset config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 71 +- 1 file

[libvirt] [PATCH V3 01/24] src/xenxs:Refactor code parsing memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMMem(virConfPtr conf,.); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 83 +- 1 file changed, 45

[libvirt] [PATCH V3 04/24] src/xenxs:Refactor code parsing PCI config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce funtion xenParseXMPCI(virConfPtr conf, ); which parses PCI config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 185 +++-- 1 file changed, 95

[libvirt] [PATCH V3 05/24] src/xenxs:Refactor code parsing CPU features

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMCPUFeatures(virConfPtr conf,.); which parses CPU features instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 127 +++-- 1 file

[libvirt] [PATCH V3 10/24] src/xenxs:Refactor code parsing emulated hardware config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMEmulatedHardware(virConfPtr conf,.); which parses emulated devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 82

[libvirt] [PATCH V3 12/24] src/xenxs:Refactor code parsing OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMOS(virConfPtr conf,...); which parses the OS config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 80 ++ 1 file changed,

[libvirt] [PATCH V3 13/24] src/xenxs:Export code for reuse

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com wrap code tagged for resuse into onef function and export it signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 71 -- src/xenxs/xen_xm.h | 2 ++ 2 files changed, 44

[libvirt] [PATCH V3 08/24] src/xenxs:Refactor code parsing Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMCharDev(virConfPtr conf,.); which parses Char devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 174 - 1 file

[libvirt] [PATCH V3 18/24] src/xenxs:Refactor code formating Char devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMCharDev(virConfPtr conf,); which formats Char devices config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 163 ++--- 1 file

[libvirt] [PATCH V3 15/24] src/xenxs:Refactor code formating memory config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce fucntion xenFormatXMMem(virConfPtr conf,...); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 24 ++-- 1 file changed, 18 insertions(+), 6

[libvirt] [PATCH V3 19/24] src/xenxs:Refactor code formating xm disk config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMDomainDisks(virConfPtr conf,.); which formats domain disks config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 72 +- 1

[libvirt] [PATCH V3 20/24] src/xenxs:Refactor code formating CPU features config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce functions xenFormatXMCPUFeatures(virConfPtr conf, ..); which formats CPU features config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 118 -

[libvirt] [PATCH V3 07/24] src/xenxs:Refactor code parsing Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVfb(virConfPtr conf,..); which parses Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 301 +++-- 1 file changed, 155

[libvirt] [PATCH V3 14/24] src/xenxs:Refactor code formating general VM config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMGeneralMeta(virConfPtr conf,..); which parses uuid and name instead signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 53 - 1 file

[libvirt] [PATCH V3 17/24] src/xenxs:Refactor code formating event actions config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEventActions(virConfPtr conf,.); which formats event actions instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 63 +++--- 1 file

[libvirt] [PATCH V3 21/24] src/xenxs:Refactor code formating OS config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMOS(virConfPtr conf,); which formats OS config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 95 --

[libvirt] [PATCH V3 09/24] src/xenxs:Refactor code parsing Vif config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMVif(virConfPtr conf,); which parses Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 283 +++-- 1 file changed, 143

[libvirt] [PATCH V3 22/24] src/xenxs:Refactor code formating Vfb config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMVfb(virConfPtr conf,.); which formats Vfb config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 171 ++--- 1 file changed, 97

[libvirt] [PATCH V3 23/24] src/xenxs:Refactor code formating emulated devices config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMEmulatedHardware(virConfPtr conf,); which formats emulated hardware config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 150

[libvirt] [PATCH V3 16/24] src/xenxs:Refactor code formating virtual time config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenFormatXMTimeOffset(virConfPtr conf,); which formats time config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 153 - 1 file

[libvirt] [PATCH V3 24/24] src/xenxs:Export code

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com export code for reuse and some formating fix signed-off-by:David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 59 +- src/xenxs/xen_xm.h | 4 +-

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Eric Blake
On 08/06/2014 08:36 AM, Yuanzhen Gu wrote: [please don't top-post on technical lists] Thanks very much Eric! This is exactly what I guessed, I just wondering where I could find this piece of code and control the the pause time of guest, while the snapshot being taken? thanks ! Actually,

Re: [libvirt] [PATCH] snapshot: conf: Enforce absolute paths on disk and memory images

2014-08-06 Thread Eric Blake
On 08/06/2014 07:19 AM, Peter Krempa wrote: RNG schema as well as the qemu driver requires absolute paths for memory and disk snapshot image files but the XML parser was not enforcing it. Add checks to avoid problems in qemu where the configuration it creates is invalid. Resolves:

[libvirt] [PATCH V3 11/24] src/xenxs:Refactor code parsing general config

2014-08-06 Thread David Kiarie
From: Kiarie Kahurani davidkiar...@gmail.com introduce function xenParseXMGeneralMeta(virConfPtr conf, ...); which parses general metadata instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 58 -- 1 file

Re: [libvirt] [PATCH] snapshot: conf: Enforce absolute paths on disk and memory images

2014-08-06 Thread Peter Krempa
On 08/06/14 17:36, Eric Blake wrote: On 08/06/2014 07:19 AM, Peter Krempa wrote: RNG schema as well as the qemu driver requires absolute paths for memory and disk snapshot image files but the XML parser was not enforcing it. Add checks to avoid problems in qemu where the configuration it

Re: [libvirt] [PATCH] libxl: support domainReset

2014-08-06 Thread Jim Fehlig
Jim Fehlig wrote: Currently, libxl_send_trigger() does not implement the LIBXL_TRIGGER_RESET option, but domainReset can be implemented in the libxl driver by forcibly destroying the domain and starting it again. Any other comments on this from a libvirt perspective? Regards, Jim

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Yuanzhen Gu
yes, I got your point, thanks very much Eric. If I want to take a distributed snapshot, which need pause all the VMs and then take snapshot, how can I control the pause for all the VMs? Is there only way that I turn to freeze/thaw functions? and freeze/thaw only for file systems, not for the

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Eric Blake
On 08/06/2014 10:06 AM, Yuanzhen Gu wrote: yes, I got your point, thanks very much Eric. not entirely, because you still top-posted. If I want to take a distributed snapshot, which need pause all the VMs and then take snapshot, how can I control the pause for all the VMs? You mean, you

[libvirt] RFC: exposing backing store allocation in domain xml

2014-08-06 Thread Eric Blake
Adam Litke has been asking if I can expose watermark information from qemu when doing block commit. Qemu still doesn't expose that information when doing 'virsh blockcopy' (QMP drive-mirror), but DOES expose it for regular and active 'virsh blockcommit'. The idea is that when you are writing to

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Yuanzhen Gu
On Wed, Aug 6, 2014 at 12:27 PM, Eric Blake ebl...@redhat.com wrote: On 08/06/2014 10:06 AM, Yuanzhen Gu wrote: yes, I got your point, thanks very much Eric. not entirely, because you still top-posted. got it entirely this time, not top-posted. If I want to take a distributed

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Eric Blake
On 08/06/2014 11:17 AM, Yuanzhen Gu wrote: Guest freeze/thaw (virDomainFSFreeze) only works on a live guest. So what you will have to do is: virDomainFSFreeze(vm1, ...) virDomainFSFreeze(vm2, ...) virDomainSuspend(vm1) virDomainSuspend(vm2) virDomainSnapshotCreateXML(vm1, ...)

Re: [libvirt] RFC: exposing backing store allocation in domain xml

2014-08-06 Thread Adam Litke
On 06/08/14 10:36 -0600, Eric Blake wrote: Adam Litke has been asking if I can expose watermark information from qemu when doing block commit. Qemu still doesn't expose that information when doing 'virsh blockcopy' (QMP drive-mirror), but DOES expose it for regular and active 'virsh

Re: [libvirt] [PATCH] Node Devices: Fix nodedev-list for fc_host vports.

2014-08-06 Thread Prerna Saxena
On Wednesday 06 August 2014 05:28 PM, John Ferlan wrote: On 08/06/2014 06:20 AM, Prerna Saxena wrote: In a system with Fiber Channel Host Adapters, a query to list all Fibre Channel HBAs OR Vports currently returns empty list: $ virsh nodedev-list --cap fc_host $ Libvirt correctly

Re: [libvirt] libvirt external disk-only snapshot will pause the VM?

2014-08-06 Thread Yuanzhen Gu
On Wed, Aug 6, 2014 at 1:23 PM, Eric Blake ebl...@redhat.com wrote: On 08/06/2014 11:17 AM, Yuanzhen Gu wrote: Guest freeze/thaw (virDomainFSFreeze) only works on a live guest. So what you will have to do is: virDomainFSFreeze(vm1, ...) virDomainFSFreeze(vm2, ...)

Re: [libvirt] Error

2014-08-06 Thread Nehal J Wani
On Wed, Aug 6, 2014 at 6:55 PM, Eric Blake ebl...@redhat.com wrote: On 08/05/2014 10:55 PM, ahmad jan wrote: I want to configure Libvirt-1.2.7 on ubuntu and found the following Error Could not find linxml2 anywhere That's not the actual error message you saw, as the string linxml2 does not

Re: [libvirt] [PATCH v5 2/4] blockjob: properly track blockcopy xml changes on disk

2014-08-06 Thread Eric Blake
On 07/28/2014 10:20 PM, Eric Blake wrote: Fix things by saving state any time we modify live XML, while delaying XML disk modifications until after the event completes. Except that I didn't, which means I caused a use-after-free situation which can crash libvirtd when doing blockcopy or

Re: [libvirt] valgrind report on active commit

2014-08-06 Thread Eric Blake
On 08/05/2014 10:04 PM, Eric Blake wrote: I'm still investigating, but posting this trace now in case someone else spots the bug. I created a chain three deep (base.img - mid.img - top.img), then ran blockcopy --finish, blockcommit --active --shallow --pivot, and another blockcommit --active

[libvirt] [PATCH 0/2] active commit fixes

2014-08-06 Thread Eric Blake
In response to the valgrind trace I posted to the list last night. Valgrind is awesome :) I had a very hard time reproducing the race when run under gdb or at normal speeds, but valgrind was slow enough that I was hitting it more frequently, as well as getting information about the bug and where

[libvirt] [PATCH 2/2] blockjob: fix use-after-free in blockcopy

2014-08-06 Thread Eric Blake
Commit febf84c2 tried to delay in-memory modification of the actual domain disk structure until after the qemu event was received. However, I missed that the code for block pivot had been temporarily setting disk-src = disk-mirror prior to the qemu command, in order to label the backing chain of a

[libvirt] [PATCH 1/2] blockjob: avoid memory leak during block pivot

2014-08-06 Thread Eric Blake
Valgrind caught a memory leak: ==2018== 9 bytes in 1 blocks are definitely lost in loss record 143 of 927 ==2018==at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==2018==by 0x8C42369: strdup (strdup.c:42) ==2018==by 0x50EACC9: virStrdup

Re: [libvirt] [PATCH V3 01/24] src/xenxs:Refactor code parsing memory config

2014-08-06 Thread Jim Fehlig
David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com Ok, I think we are getting close with all the refactoring work. Some nits that apply to all the patches: 1) Please add a space between the component and comment in the commit summary. E.g. src/xenxs: Refactor code parsing

Re: [libvirt] [PATCH V3 04/24] src/xenxs:Refactor code parsing PCI config

2014-08-06 Thread Jim Fehlig
David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com introduce funtion s/funtion/function/ Regards, Jim xenParseXMPCI(virConfPtr conf, ); which parses PCI config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 185

Re: [libvirt] [PATCH V3 13/24] src/xenxs:Export code for reuse

2014-08-06 Thread Jim Fehlig
David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com wrap code tagged for resuse into onef function and export it s/onef/one/ Regards, Jim signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 71

Re: [libvirt] [PATCH V3 15/24] src/xenxs:Refactor code formating memory config

2014-08-06 Thread Jim Fehlig
David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com introduce fucntion s/fucntion/function/ Regards, Jim xenFormatXMMem(virConfPtr conf,...); which parses memory config instead signed-off-by: David Kiariedavidkiar...@gmail.com --- src/xenxs/xen_xm.c | 24

Re: [libvirt] [PATCH V3 20/24] src/xenxs:Refactor code formating CPU features config

2014-08-06 Thread Jim Fehlig
David Kiarie wrote: From: Kiarie Kahurani davidkiar...@gmail.com introduce functions s/functions/function/ Regards, Jim xenFormatXMCPUFeatures(virConfPtr conf, ..); which formats CPU features config instead signed-off-by: David Kiariedavidkiar...@gmail.com ---

Re: [libvirt] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-06 Thread Serge Hallyn
This worked for me when migrating by hand. I'm trying to make it work through libvirt, using the following patch. (So whether to have pc-1.0 be treated as qemu's or qemu-kvm's pc-1.0 is specifed using a boolean in /etc/libvirt/qemu.conf) Qemu starts with decent looking args, but for some reason

[libvirt] Error

2014-08-06 Thread ahmad jan
I am using Libvirt-1.0.0 on ubuntu 14.02 LTS and found the following error checking linux/if_bridge.h usability... no checking linux/if_bridge.h presence... yes configure: WARNING: linux/if_bridge.h: present but cannot be compiled configure: WARNING: linux/if_bridge.h: check for missing

[libvirt] [PATCH] Fix missing attribute dscp in supported protocols in nwfilter docs

2014-08-06 Thread Jianwei Hu
Added attribute dscp to below supported protocols table in nwfilter docs. IPV4 (ip) TCP/UDP/SCTP (tcp/udp/sctp) ICMP (icmp) IGMP,ESP,AH,UDPLITE,'ALL' (igmp,esp,ah,udplite,all) TCP/UDP/SCTP over IPV6 (tcp-ipv6,udp-ipv6,sctp-ipv6) ICMPV6 (icmpv6) IGMP,ESP,AH,UDPLITE,'ALL' over IPv6

[libvirt] virsh migrate: sometimes command line cannot exit until manually press ENTER key

2014-08-06 Thread Chun Yan Liu
Hi, List, Do you meet the same problem? Host is kvm, doing: (e.g.) #virsh migrate sles11 qemu+ssh://147.2.207.55/system --live --unsafe password: Sometimes, VM is already running on the target host and disappears from source host, but the command line still hangs there, if pressing ENTER, it will