Kiarie Kahurani wrote:
introduce function
xenFormatXMOS(virConfPtr conf,);
I split this into three functions:
- xenFormatXMEmulator
- xenFormatXMCDROM
- xenFormatXMOS
Formating of emulator and cdrom can be different between xm and xl, and
we may want to account for that in the
On 8/8/2014 at 04:44 PM, in message
1407487476-28077-1-git-send-email-cy...@suse.com, Chunyan Liu
cy...@suse.com wrote:
A possible fix to issue:
http://www.redhat.com/archives/libvir-list/2014-August/thread.html#00227
While doing migration on KVM host, found problem sometimes:
VM is
On 13.08.2014 17:42, Tomoki Sekiyama wrote:
This patch gives users a nicer error message when the QEMU guest agent is
not new enough to support 'guest-fsfreeze-freeze-list' command, which is
used by qemuDomainFSFreeze() to freeze specified filesystems only.
Before this patch, it was
On 13.08.2014 18:30, Eric Blake wrote:
On 08/13/2014 06:51 AM, Michal Privoznik wrote:
s/_/-/2 in the subject line
An advice appeared there on the qemu-devel list [1]. When a domain is
suspended and then resumed guest kernel is not aware of this. So we've
introduced virDomainSetTime API that
From: Mo yuxiang moyuxi...@huawei.com
commit d9504941 introduces two new attributes cmd_per_lun and
max_sectors same with the names QEMU uses for virtio-scsi.
But the case of parsing them is not exact. Change to parse
them if controller has driver element.
Signed-off-by: Mo yuxiang
https://bugzilla.redhat.com/show_bug.cgi?id=1103245
An advice appeared there on the qemu-devel list [1]. When a domain is
suspended and then resumed guest kernel is not aware of this. So we've
introduced virDomainSetTime API that resets the time within guest
using qemu-ga. On the other hand, qemu
On Wed, Aug 13, 2014 at 04:10:12PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:13PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
.gitignore | 1 +
daemon/Makefile.am | 14 --
Also add qemuDomainChangeGraphicsPasswords,
qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses.
Replace tabs by spaces.
---
I'll do some testing on the patch and push it later with this squashed in
if it works well.
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_hotplug.c | 12
On 14.08.2014 09:55, Wang Rui wrote:
From: Mo yuxiang moyuxi...@huawei.com
commit d9504941 introduces two new attributes cmd_per_lun and
max_sectors same with the names QEMU uses for virtio-scsi.
But the case of parsing them is not exact. Change to parse
them if controller has driver element.
On Thu, Aug 14, 2014 at 11:37:45AM +0800, Jincheng Miao wrote:
Perl is necessary to our build processing, it will invoke a lot of
generating script, like: gendispatch.pl. If perl is missing, it's
ok for build from git checkout, because autogen.sh will tell you.
But for compiling from a release
On Thu, Aug 14, 2014 at 10:38:42AM +0200, Martin Kletzander wrote:
On Wed, Aug 13, 2014 at 04:10:12PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:13PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
.gitignore | 1 +
On Thu, Aug 14, 2014 at 10:07:34AM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 10:38:42AM +0200, Martin Kletzander wrote:
On Wed, Aug 13, 2014 at 04:10:12PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:13PM +0200, Martin Kletzander wrote:
diff --git
On Wed, Aug 13, 2014 at 04:09:09PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:12PM +0200, Martin Kletzander wrote:
This eliminates the need for active waiting.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Signed-off-by: Martin Kletzander mklet...@redhat.com
On Thu, Aug 14, 2014 at 11:23:27AM +0200, Martin Kletzander wrote:
On Wed, Aug 13, 2014 at 04:09:09PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:12PM +0200, Martin Kletzander wrote:
This eliminates the need for active waiting.
Resolves:
On Wed, Aug 13, 2014 at 04:01:42PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:08PM +0200, Martin Kletzander wrote:
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On 14.08.2014 05:37, Jincheng Miao wrote:
Perl is necessary to our build processing, it will invoke a lot of
generating script, like: gendispatch.pl. If perl is missing, it's
ok for build from git checkout, because autogen.sh will tell you.
But for compiling from a release tarball, configure
On 14.08.2014 10:41, Ján Tomko wrote:
Also add qemuDomainChangeGraphicsPasswords,
qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses.
Replace tabs by spaces.
---
I'll do some testing on the patch and push it later with this squashed in
if it works well.
src/qemu/qemu_domain.c | 2 +-
On 08/14/2014 11:52 AM, Michal Privoznik wrote:
On 14.08.2014 10:41, Ján Tomko wrote:
Also add qemuDomainChangeGraphicsPasswords,
qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses.
Replace tabs by spaces.
---
I'll do some testing on the patch and push it later with this squashed in
Should like below:
interface type='server'
mac address='52:54:00:22:c9:42'/
source address='192.168.0.1' port='5558'/
/interface
...
interface type='client'
mac address='52:54:00:8b:c9:51'/
source address='192.168.0.1' port='5558'/
/interface
---
On Thu, Aug 14, 2014 at 10:26:41AM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 11:23:27AM +0200, Martin Kletzander wrote:
On Wed, Aug 13, 2014 at 04:09:09PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at 04:27:12PM +0200, Martin Kletzander wrote:
This eliminates the need
On Thu, Aug 14, 2014 at 01:02:28PM +0200, Martin Kletzander wrote:
On Thu, Aug 14, 2014 at 10:26:41AM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 11:23:27AM +0200, Martin Kletzander wrote:
On Wed, Aug 13, 2014 at 04:09:09PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 23, 2014 at
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into graphics parent element. However QEMU does not
support listening on multiple addresses. This patch causes qemu
post-parse callback to remove any redundant entries, leaving only 1
listening address if provided,
On Thu, Aug 14, 2014 at 01:09:32PM +0200, Erik Skultety wrote:
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into graphics parent element. However QEMU does not
support listening on multiple addresses. This patch causes qemu
post-parse callback to remove
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
daemon/libvirtd.c | 45 +++--
1 file changed, 27 insertions(+), 18 deletions(-)
diff --git
This eliminates the need for active waiting.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/rpc/virnetsocket.c | 85 +++---
1 file changed, 66 insertions(+), 19 deletions(-)
It's just a wrapper around NewFD and NewUNIX that selects the right
option and increments the number of used FDs.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_remote.syms | 1 +
src/rpc/virnetserverservice.c | 50 ++-
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/commandtest.c | 49 ++---
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 7d2161c..ba823f7 100644
--- a/tests/commandtest.c
That sets a new flag, but that flag does mean the child will get
LISTEN_FDS and LISTEN_PID environment variables properly set and
passed FDs reordered so that it corresponds with LISTEN_FDS (they must
start right after STDERR_FILENO).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On 08/14/2014 12:17 PM, Jianwei Hu wrote:
Should like below:
interface type='server'
mac address='52:54:00:22:c9:42'/
source address='192.168.0.1' port='5558'/
/interface
...
interface type='client'
mac address='52:54:00:8b:c9:51'/
source
Even line like this:
int asdf = i - somevar;
was matched by the regex, so this patch adds '=' to the list of
characters that break the regexp.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cfg.mk b/cfg.mk
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
.gitignore | 1 +
daemon/Makefile.am | 14 --
daemon/libvirtd.conf | 5 +
daemon/libvirtd.service.in | 5 -
daemon/libvirtd.socket.in | 11 +++
libvirt.spec.in| 25
Since not only systemd can do this (we'll be doing it as well few
patches later), change 'systemd' to 'caller' and fix LISTEN_FDS to
LISTEN_PID where applicable.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 1 +
src/locking/lock_daemon.c | 45
On Thu, Aug 14, 2014 at 02:08:51PM +0200, Martin Kletzander wrote:
v3 is here:
https://www.redhat.com/archives/libvir-list/2014-July/msg01185.html
the bug I'm still trying to fix is here:
https://bugzilla.redhat.com/show_bug.cgi?id=927369
I forgot to mention that only patches 4, 8 and
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/locking/lock_daemon.c | 2 +-
src/rpc/virnetserverservice.c | 5 +
src/rpc/virnetserverservice.h | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c
index
v3 is here:
https://www.redhat.com/archives/libvir-list/2014-July/msg01185.html
the bug I'm still trying to fix is here:
https://bugzilla.redhat.com/show_bug.cgi?id=927369
Martin Kletzander (9):
util: abstract parsing of passed FDs into virGetListenFDs()
remote: create
On Thu, Aug 14, 2014 at 02:12:51PM +0200, Martin Kletzander wrote:
On Thu, Aug 14, 2014 at 12:12:33PM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 01:09:32PM +0200, Erik Skultety wrote:
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into
On Thu, Aug 14, 2014 at 12:12:33PM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 01:09:32PM +0200, Erik Skultety wrote:
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into graphics parent element. However QEMU does not
support listening on
On Thu, Aug 14, 2014 at 02:17:15PM +0200, Martin Kletzander wrote:
On Thu, Aug 14, 2014 at 02:12:51PM +0200, Martin Kletzander wrote:
On Thu, Aug 14, 2014 at 12:12:33PM +0100, Daniel P. Berrange wrote:
On Thu, Aug 14, 2014 at 01:09:32PM +0200, Erik Skultety wrote:
When editing guest's XML (on
On 07/28/2014 10:59 PM, Richard Weinberger wrote:
The gid value passed to devpts has to be translated by hand as
virLXCControllerSetupDevPTS() is called before setting up the user
and group mappings.
Otherwise devpts will use an unmapped gid and openpty()
will fail within containers.
Linux
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into graphics parent element. However QEMU does not
support listening on multiple addresses. Configuration is tested for
multiple 'listen address' and if positive, an error is raised.
---
src/qemu/qemu_process.c |
From: Zeng Junliang zengjunli...@huawei.com
The vram attribute is never used for VGA, CIRRUS and VMVGA as
QEMU has no vram attribute for these models. Hide it for qemu
in qemuDomainDevicePostParse function. And update the
corresponding test cases and descriptions.
Signed-off-by: Zeng Junliang
From: Zeng Junliang zengjunli...@huawei.com
Secondary-vga is supported by QEMU in currently master. Add it supported
in libvirt as qemu commandline show: '-device secondary-vga'. And it can
be used as secondary display device, like qxl. Also, add test cases and
descriptions for it.
Libvirt xml
From: Zeng Junliang zengjunli...@huawei.com
http://www.redhat.com/archives/libvir-list/2014-July/msg00644.html
diff to v2:
- hide vram attribute silently instead of reporting an error.
- introduce three new capabilities for vga.vgamem_mb, vmvga.vgamem_mb and
qxl.vgamem_mb.
- fix some error
From: Zeng Junliang zengjunli...@huawei.com
QEMU suopports to specifie the size of the framebuffer portion of
the ram region for vga, vmvga and qxl through the qemu command
line parameter vgamem_mb.
This patch introduces vgamem attribute for video model, makes the
vgamem_mb value configured in
Am 14.08.2014 14:35, schrieb Ján Tomko:
On 07/28/2014 10:59 PM, Richard Weinberger wrote:
The gid value passed to devpts has to be translated by hand as
virLXCControllerSetupDevPTS() is called before setting up the user
and group mappings.
Otherwise devpts will use an unmapped gid and
On 08/14/2014 02:45 PM, Richard Weinberger wrote:
Am 14.08.2014 14:35, schrieb Ján Tomko:
On 07/28/2014 10:59 PM, Richard Weinberger wrote:
The gid value passed to devpts has to be translated by hand as
virLXCControllerSetupDevPTS() is called before setting up the user
and group mappings.
On 08/14/2014 02:44 PM, Erik Skultety wrote:
When editing guest's XML (on QEMU), it was possible to add multiple
listen elements into graphics parent element. However QEMU does not
support listening on multiple addresses. Configuration is tested for
multiple 'listen address' and if positive,
On 08/13/2014 10:10 AM, Jianwei Hu wrote:
The correct vlanid range is 0~4095.
After merging this patch, we can not validate a interface xml with vlanid =
4096.
[root@localhost ~]# cat vlan.xml
interface type='vlan' name='eno1.4096'
start mode='onboot'/
protocol family='ipv4'
No, don't worry, this is not a real commit message, this is more like
an RFC about how to fix it. I'm not sure about this part of libvirt
codebase, so I'm rather asking for help. Apparently, I have a network
with netdef-forward.pfs == NULL, I suspect this is a network I have,
that doesn't have
On Wed, Aug 13, 2014 at 05:15:58PM -0600, Jim Fehlig wrote:
Kiarie Kahurani wrote:
introduce function
xenFormatXMTimeOffset(virConfPtr conf,);
which formats time config instead
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
src/xenxs/xen_xm.c | 153
On Wed, Aug 13, 2014 at 05:35:52PM -0600, Jim Fehlig wrote:
Kiarie Kahurani wrote:
introduce functions
xenFormatXMCPUFeatures(virConfPtr conf, ..);
which formats CPU features config instead
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
src/xenxs/xen_xm.c
On Thu, Aug 14, 2014 at 12:15:32AM -0600, Jim Fehlig wrote:
Kiarie Kahurani wrote:
introduce function
xenFormatXMOS(virConfPtr conf,);
I split this into three functions:
- xenFormatXMEmulator
- xenFormatXMCDROM
- xenFormatXMOS
Formating of emulator and cdrom can be
On 08/14/2014 10:13 AM, Martin Kletzander wrote:
No, don't worry, this is not a real commit message, this is more like
an RFC about how to fix it. I'm not sure about this part of libvirt
codebase, so I'm rather asking for help. Apparently, I have a network
with netdef-forward.pfs == NULL, I
On 13/08/14 19:48 -0600, Eric Blake wrote:
While investigating active commit, I noticed that our code for probing
backing chains currently guesses at type=file vs. type=block solely
based on stat results (regular file vs. block device). Is a block
device allowed to be used as disk type='block'
Le Wednesday 13 August 2014 17:18:44, Michal Privoznik a écrit :
[CC-ing Yohan BELLEGUIC and Manuel VIVES]
On 12.08.2014 17:31, Michal Privoznik wrote:
On 11.08.2014 12:06, Taowei wrote:
This series of patches rewrite the vbox's domain
driver. The driver is separated into two parts: the
On 08/07/2014 04:53 PM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1078126
Using 'virsh attach-device --config' (or --persistent) to attach a
file backed lun device will succeed; however, subsequent domain restarts
will result in failure because the configuration of a
On Thu, Aug 14, 2014 at 05:50:18PM +0200, Yohan Belleguic wrote:
Le Wednesday 13 August 2014 17:18:44, Michal Privoznik a écrit :
[CC-ing Yohan BELLEGUIC and Manuel VIVES]
On 12.08.2014 17:31, Michal Privoznik wrote:
On 11.08.2014 12:06, Taowei wrote:
This series of patches rewrite
On 08/08/2014 10:44 AM, Chunyan Liu wrote:
A possible fix to issue:
http://www.redhat.com/archives/libvir-list/2014-August/thread.html#00227
While doing migration on KVM host, found problem sometimes:
VM is already running on the target host and disappears from source
host, but 'virsh
Update bhyveBuildDiskArgStr to support volumes:
- Make virBhyveProcessBuildBhyveCmd take virConnectPtr as the
first argument instead of bhyveConnPtr as virConnectPtr is
needed for virDomainTranslateDiskSourcePool,
- Add virDomainTranslateDiskSourcePool call to
Currently, qemu driver uses qemuTranslateDiskSourcePool()
to translate disk volume information. This function is
general enough and could be used for other drivers as well,
so move it to conf/domain_conf.c along with its helpers.
- qemuTranslateDiskSourcePool: move to conf/domain_conf.c
and
Martin Kletzander pointed out in email that my commit 2a193f64
introduced a crash in networkCreateInterfacePool() during startup of
any network that doesn't have a pf subelement of its forward
element. He also supplied a patch.
http://www.redhat.com/archives/libvir-list/2014-August/msg00655.html
Kiarie Kahurani wrote:
introduce function
xenFormatXMVfb(virConfPtr conf,.);
which formats Vfb config instead
Continuing my review from yesterday...
Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com
---
src/xenxs/xen_xm.c | 171
Hi Jan,
Is the auto login a pre-requisite for p2p direct migration ? The
current patch mostly focus on avoiding the virsh migrate hang.
Thanks,
Shiva
On Thu, Aug 14, 2014 at 9:40 PM, Ján Tomko jto...@redhat.com wrote:
On 08/08/2014 10:44 AM, Chunyan Liu wrote:
A possible fix to issue:
Kiarie Kahurani wrote:
introduce function
xenFormatXMEmulatedHardware(virConfPtr conf,);
You've also added xenFormatXMVif in this patch. It should be in a
separate patch IMO. Once removed, a better description of this patch is
src/xenxs: Refactor code formating peripheral device
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
Pushed as trivial
src/qemu/qemu_process.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 13c396f..52d9052 100644
--- a/src/qemu/qemu_process.c
+++
Kiarie Kahurani wrote:
Kiarie Kahurani (12):
src/xenxs: Export code for reuse
[...]
src/xenxs: Refactor code formating general VM config
src/xenxs: Refactor code formating memory config
src/xenxs: Refactor code formating virtual time config
src/xenxs: Refactor code formating
On Thu, Aug 14, 2014 at 12:40:07PM -0400, Laine Stump wrote:
Martin Kletzander pointed out in email that my commit 2a193f64
introduced a crash in networkCreateInterfacePool() during startup of
any network that doesn't have a pf subelement of its forward
element. He also supplied a patch.
Hi. Is it possible to preserve comments in libvirt's XML files
without it failing validate-xml checks?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hello,
by default, libvirt with KVM creates a Cgroup hierarchy in 'cpu,cpuacct'
[1], with 'shares' set to 1024 on every level. This raises two points:
1) Every VM is given an equal amount of CPU time. [2]
($CG/machine.slice/*/shares = 1024)
Which means that smaller / less loaded guests
2014-08-14 13:55-0400, Andrew Theurer:
- Original Message -
From: Radim Krčmář rkrc...@redhat.com
To: libvir-list@redhat.com
Cc: Daniel P. Berrange berra...@redhat.com, Andrew Theurer
atheu...@redhat.com
Sent: Thursday, August 14, 2014 9:25:05 AM
Subject: Suboptimal
- Original Message -
From: Radim Krčmář rkrc...@redhat.com
To: libvir-list@redhat.com
Cc: Daniel P. Berrange berra...@redhat.com, Andrew Theurer
atheu...@redhat.com
Sent: Thursday, August 14, 2014 9:25:05 AM
Subject: Suboptimal default cpu Cgroup
Hello,
by default, libvirt
On 08/14/2014 05:33 PM, Michal Privoznik wrote:
On 14.08.2014 05:37, Jincheng Miao wrote:
Perl is necessary to our build processing, it will invoke a lot of
generating script, like: gendispatch.pl. If perl is missing, it's
ok for build from git checkout, because autogen.sh will tell you.
But
Ping. [python PATCH]
On 2014/8/8 17:55, Wang Rui wrote:
From: Mo Yuxiang moyuxi...@huawei.com
On compiling libvirt-python, we get such a warning:
libvirt-qemu-override.c: In function
‘libvirt_qemu_virConnectDomainQemuMonitorEventRegister’:
libvirt-qemu-override.c:304: warning: suggest
On 14/08/14 20:14, Ján Tomko wrote:
On 08/14/2014 11:52 AM, Michal Privoznik wrote:
On 14.08.2014 10:41, Ján Tomko wrote:
Also add qemuDomainChangeGraphicsPasswords,
qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses.
Replace tabs by spaces.
---
I'll do some testing on the patch and
On 08/15/2014 12:36 AM, ban...@openmailbox.org wrote:
Hi. Is it possible to preserve comments in libvirt's XML files
without it failing validate-xml checks?
Any comments you add to the XML will be lost when libvirt parses and formats
it again, only the elements libvirt knows will be
75 matches
Mail list logo
