Re: [libvirt] Entering freeze for libvirt-1.2.9

2014-09-29 Thread Daniel Veillard
On Mon, Sep 29, 2014 at 04:34:50PM +0200, Ján Tomko wrote: > On 09/29/2014 12:01 PM, Christophe Fergeau wrote: > > Hey, > > > > On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote: > >> I have tagged the release candidate 1 for libvirt-1.2.9 in git, > >> and pushed signed tarballs an

Re: [libvirt] [PATCH 2/2] Also filter out non-migratable features out of host-passthrough

2014-09-29 Thread John Ferlan
On 09/29/2014 10:27 AM, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1147584 Could this be expanded a bit - so one doesn't have to chase into the bz in order to understand what is/was being fixed? > --- > src/cpu/cpu_x86.c | 14 ++ > 1 file changed, 6 insertions(+),

Re: [libvirt] [PATCH 1/2] Don't verify CPU features with host-passthrough

2014-09-29 Thread John Ferlan
On 09/29/2014 10:27 AM, Ján Tomko wrote: > Commit fba6bc4 introduced the non-migratable invtsc feature, > breaking save/migration with host-model and host-passthrough. > > On hosts with this feature present it was automatically included > in the CPU definition, regardless of QEMU support. > > C

Re: [libvirt] CreateMachine: Input/output error

2014-09-29 Thread Richard Weinberger
Am 29.09.2014 11:13, schrieb Chen, Hanxiao: > I'm not sure this commit could help > because reproduce this issue looks like so unpredictable. Yeah, maybe. > I did some tests in the last weekend, > unfortunately, I could not reproduce it again with both 208 and 215... Same here. So far I was unab

Re: [libvirt] [PATCH 4/6] qemu: qemuMonitorQueryRxFilter - retrieve guest netdev rx-filter

2014-09-29 Thread Laine Stump
On 09/27/2014 12:41 AM, Amos Kong wrote: > On Wed, Sep 24, 2014 at 05:50:54AM -0400, Laine Stump wrote: >> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c >> index a3d7c2c..58007e6 100644 >> --- a/src/qemu/qemu_monitor_json.c >> +++ b/src/qemu/qemu_monitor_json.c >> @@ -319

Re: [libvirt] [PATCH 3/6] util: define virNetDevRxFilter and basic utility functions

2014-09-29 Thread Laine Stump
On 09/27/2014 12:40 AM, Amos Kong wrote: > On Wed, Sep 24, 2014 at 05:50:53AM -0400, Laine Stump wrote: >> This same structure will be used to retrieve RX filter info for >> interfaces on the host via netlink messages, and RX filter info for >> interfaces on the guest via the qemu "query-rx-filter"

Re: [libvirt] [PATCH 3/3] qemu: bulk stats: add block allocation information

2014-09-29 Thread Eric Blake
On 09/25/2014 06:06 AM, Peter Krempa wrote: > From: Francesco Romani > > Management software wants to be able to allocate disk space on demand. > To support this they need keep track of the space occupation of the > block device. This information is reported by qemu as part of block > stats. >

Re: [libvirt] [PATCH 2/3] qemu: monitor: Add helper function to fill physical/virtual image size

2014-09-29 Thread Eric Blake
On 09/25/2014 06:06 AM, Peter Krempa wrote: > While our code gathers block stats via "query-blockstats" some > information need to be gathered via "query-block". Add a helper function > that will update the blockstats structure if requested. > --- > src/qemu/qemu_monitor.c | 17 ++ >

Re: [libvirt] [PATCH 1/3] qemu: monitor: return block stats data as a hash to avoid disk mixup

2014-09-29 Thread Eric Blake
On 09/25/2014 06:06 AM, Peter Krempa wrote: > The current block stats code matched up the disk name with the actual > stats by the order in the data returned from qemu. This unfortunately > isn't right as qemu may return the disks in any order. Fix this by > returning a hash of stats and index them

[libvirt] [libvirt-glib] gconfig: Add GVIR_CONFIG_DOMAIN_INPUT_DEVICE_KEYBOARD

2014-09-29 Thread Zeeshan Ali (Khattak)
Add missing enum type for keyboard input device. --- libvirt-gconfig/libvirt-gconfig-domain-input.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-input.h b/libvirt-gconfig/libvirt-gconfig-domain-input.h index 252b6ca..83a0ec9 100644 -

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-29 Thread Kashyap Chamarthy
On Mon, Sep 29, 2014 at 07:29:23PM +0200, Guido Günther wrote: > On Mon, Sep 29, 2014 at 02:48:34PM +0530, Kashyap Chamarthy wrote: > > On Mon, Sep 29, 2014 at 08:17:11AM +0200, Guido Günther wrote: > > > On Mon, Sep 29, 2014 at 07:12:29AM +0530, Kashyap Chamarthy wrote: > > > > Applied it: > > > >

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-29 Thread Guido Günther
On Mon, Sep 29, 2014 at 02:48:34PM +0530, Kashyap Chamarthy wrote: > On Mon, Sep 29, 2014 at 08:17:11AM +0200, Guido Günther wrote: > > On Mon, Sep 29, 2014 at 07:12:29AM +0530, Kashyap Chamarthy wrote: > > > Applied it: > > > > > > $ git log | head -5 > > > commit da0a33c3f286ff69b910bc2a

[libvirt] [PATCH] Allow setting migration max downtime any time

2014-09-29 Thread chris . a . st . pierre
From: "Chris St. Pierre" This removes the artificial and unnecessary restriction that virDomainSetMaxDowntime() only be called while a migration is in progress. --- src/qemu/qemu_driver.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c ind

Re: [libvirt] [PATCH 0/3] Fix and improve block bulk stats

2014-09-29 Thread Peter Krempa
On 09/25/14 14:06, Peter Krempa wrote: > Francesco Romani (1): > qemu: bulk stats: add block allocation information > > Peter Krempa (2): > qemu: monitor: return block stats data as a hash to avoid disk mixup > qemu: monitor: Add helper function to fill physical/virtual image size > > src/

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > > On 29 Sep 2014, at 11:08, Michael S. Tsirkin wrote: > > > On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote: > >> Hang on a second! v2 of this patch DID use a new virtual machine, > >> called exactly that. I thought you were objecting to that a

Re: [libvirt] Entering freeze for libvirt-1.2.9

2014-09-29 Thread Christophe Fergeau
On Mon, Sep 29, 2014 at 04:34:50PM +0200, Ján Tomko wrote: > On 09/29/2014 12:01 PM, Christophe Fergeau wrote: > > Hey, > > > > On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote: > >> I have tagged the release candidate 1 for libvirt-1.2.9 in git, > >> and pushed signed tarballs an

[libvirt] [PATCH 1/2] Don't verify CPU features with host-passthrough

2014-09-29 Thread Ján Tomko
Commit fba6bc4 introduced the non-migratable invtsc feature, breaking save/migration with host-model and host-passthrough. On hosts with this feature present it was automatically included in the CPU definition, regardless of QEMU support. Commit de0aeaf stopped including it by default for host-mo

Re: [libvirt] Entering freeze for libvirt-1.2.9

2014-09-29 Thread Ján Tomko
On 09/29/2014 12:01 PM, Christophe Fergeau wrote: > Hey, > > On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote: >> I have tagged the release candidate 1 for libvirt-1.2.9 in git, >> and pushed signed tarballs and rpms to the usual place: >>ftp://libvirt.org/libvirt/ >> >> This

Re: [libvirt] Is seems necessary to pass "migratable=no/yes" to qemu.

2014-09-29 Thread Ján Tomko
On 09/25/2014 02:59 PM, Ján Tomko wrote: > On 09/25/2014 04:31 AM, zhang bo wrote: >> On 2014/9/24 19:49, Ján Tomko wrote: >>> I think the simplest fix for host-passthrough would be to apply the same >>> filter host-model has. >>> >>> But since using invtsc with host-passthrough requires both +invt

[libvirt] [PATCH 2/2] Also filter out non-migratable features out of host-passthrough

2014-09-29 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1147584 --- src/cpu/cpu_x86.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index a98a847..57f343c 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2068,7 +2068,8 @@ x86

[libvirt] [PATCH 0/2] Fix migration with host-passthrough

2014-09-29 Thread Ján Tomko
Ján Tomko (2): Don't verify CPU features with host-passthrough Also filter out non-migratable features out of host-passthrough src/cpu/cpu_x86.c | 14 ++ src/qemu/qemu_migration.c | 22 -- src/qemu/qemu_process.c | 5 + 3 files changed, 23 insert

[libvirt] Availability of Release Candidate 2 of libvirt-1.2.9

2014-09-29 Thread Daniel Veillard
I have tagged the release candidate 2 for libvirt-1.2.9 in git, and pushed signed tarballs and rpms to the usual place: ftp://libvirt.org/libvirt/ So unfortuntely this was too early to try to fix Christophe's reported bug, hopefully we can get it fixed in time. If needed I can postpone the

Re: [libvirt] [PATCH] Fix crash cpu_shares change event crash on domain startup

2014-09-29 Thread Ján Tomko
On 09/29/2014 01:55 PM, Peter Krempa wrote: > On 09/29/14 13:54, Ján Tomko wrote: >> Introduced by commit 0dce260. >> >> qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead >> of virQEMUDriverPtr. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1147494 >> --- >> src/qemu/qemu_cg

Re: [libvirt] [PATCH] Fix crash cpu_shares change event crash on domain startup

2014-09-29 Thread Peter Krempa
On 09/29/14 13:54, Ján Tomko wrote: > Introduced by commit 0dce260. > > qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead > of virQEMUDriverPtr. > > https://bugzilla.redhat.com/show_bug.cgi?id=1147494 > --- > src/qemu/qemu_cgroup.c | 7 --- > 1 file changed, 4 insertions(+

[libvirt] [PATCH] Fix crash cpu_shares change event crash on domain startup

2014-09-29 Thread Ján Tomko
Introduced by commit 0dce260. qemuDomainEventQueue was called with qemuDomainObjPrivatePtr instead of virQEMUDriverPtr. https://bugzilla.redhat.com/show_bug.cgi?id=1147494 --- src/qemu/qemu_cgroup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c

Re: [libvirt] [PATCHv2] storage: Fix logical pool fmt type

2014-09-29 Thread John Ferlan
On 09/26/2014 06:56 AM, John Ferlan wrote: > > > On 09/25/2014 10:26 AM, Erik Skultety wrote: >> According to our documentation logical pool supports formats 'auto' and >> 'lvm2'. However, in storage_conf.c we prevously defined storage pool > > s/prevously/previously > >> formats: unknown, lv

Re: [libvirt] Notes: Non-shared storage live migration w/ active blockcommit

2014-09-29 Thread Kashyap Chamarthy
On Mon, Sep 29, 2014 at 10:33:37AM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 25, 2014 at 3:26 PM, Kashyap Chamarthy > wrote: > > This notes is based on an IRC conversation with Eric Blake, to have > > efficient non-shared storage live migration. Thought I'd post my notes > > here before I forge

[libvirt] [PATCH 3/3] qemu: save domain status after set domain's numa parameters

2014-09-29 Thread Shanzhi Yu
After set domain's numa parameters for running domain, save the change, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511; meanwihle add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetNumaParameters Signed-off-by: Shanzhi Yu --

[libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

2014-09-29 Thread Shanzhi Yu
After set network interface's bandwidth for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters Signed-off-by: Shanzhi Yu --- src/

[libvirt] [PATCH 0/3] Save domain satus after change some parameters

2014-09-29 Thread Shanzhi Yu
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1146511 Shanzhi Yu (3): qemu: save domain status after set the blkio parameters qemu: save domain status after set network interface's bandwidth parameters qemu: save domain status after set domain's numa parameters src/qemu/qemu_driver.

[libvirt] [PATCH 1/3] qemu: save domain status after set the blkio parameters

2014-09-29 Thread Shanzhi Yu
After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetBlkioParameters Signed-off-by: Shanzhi Yu --- src/qemu/qemu_dri

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Alex Bligh
On 29 Sep 2014, at 11:08, Michael S. Tsirkin wrote: > On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote: >> Hang on a second! v2 of this patch DID use a new virtual machine, >> called exactly that. I thought you were objecting to that and >> wanting a machine parameter instead! It's far

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Michael S. Tsirkin
On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote: > Hang on a second! v2 of this patch DID use a new virtual machine, > called exactly that. I thought you were objecting to that and > wanting a machine parameter instead! It's far easier with a new > machine type, and I'd far prefer a new

Re: [libvirt] Entering freeze for libvirt-1.2.9

2014-09-29 Thread Christophe Fergeau
Hey, On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote: > I have tagged the release candidate 1 for libvirt-1.2.9 in git, > and pushed signed tarballs and rpms to the usual place: >ftp://libvirt.org/libvirt/ > > This seems to work fine with my limited testing, but more people

Re: [libvirt] [PATCH v3 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

2014-09-29 Thread Michal Privoznik
On 29.09.2014 10:36, Matthias Gatto wrote: On Mon, Sep 29, 2014 at 10:32 AM, Matthias Gatto wrote: On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik wrote: On 23.09.2014 16:13, Matthias Gatto wrote: This series of patches add support for bps_max, bps_rd_max, bps_wr_max, bps_max, bps_rd_max,

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-29 Thread Kashyap Chamarthy
On Mon, Sep 29, 2014 at 02:48:34PM +0530, Kashyap Chamarthy wrote: > On Mon, Sep 29, 2014 at 08:17:11AM +0200, Guido Günther wrote: [. . .] > > An alternative to rebooting is to remove related processes manually, see: > > > > http://bugs.debian.org/761521 > > I don't see x2d<$vmname>.scope und

Re: [libvirt] Notes: Non-shared storage live migration w/ active blockcommit

2014-09-29 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 3:26 PM, Kashyap Chamarthy wrote: > This notes is based on an IRC conversation with Eric Blake, to have > efficient non-shared storage live migration. Thought I'd post my notes > here before I forget. Please review and spot if there are any > inaccuracies. What are you try

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-29 Thread Kashyap Chamarthy
On Mon, Sep 29, 2014 at 08:17:11AM +0200, Guido Günther wrote: > On Mon, Sep 29, 2014 at 07:12:29AM +0530, Kashyap Chamarthy wrote: > > Applied it: > > > > $ git log | head -5 > > commit da0a33c3f286ff69b910bc2a84e9ec3a844e3ce8 > > Author: Guido Günther > > Date: Thu Sep 25 14:3

Re: [libvirt] CreateMachine: Input/output error

2014-09-29 Thread Chen, Hanxiao
Hi, > -Original Message- > From: Richard Weinberger [mailto:rich...@nod.at] > Sent: Friday, September 26, 2014 6:31 PM > To: Chen, Hanxiao/陈 晗霄; libvir-list@redhat.com > Subject: Re: [libvirt] CreateMachine: Input/output error > > Chen, > > Am 26.09.2014 11:54, schrieb Richard Weinberger

Re: [libvirt] [PATCH v3 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

2014-09-29 Thread Matthias Gatto
On Mon, Sep 29, 2014 at 10:32 AM, Matthias Gatto wrote: > On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik wrote: >> On 23.09.2014 16:13, Matthias Gatto wrote: >>> >>> This series of patches add support for bps_max, bps_rd_max, bps_wr_max, >>> bps_max, bps_rd_max, bps_wr_max, and iops_size in th

Re: [libvirt] [PATCH v3 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

2014-09-29 Thread Matthias Gatto
On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik wrote: > On 23.09.2014 16:13, Matthias Gatto wrote: >> >> This series of patches add support for bps_max, bps_rd_max, bps_wr_max, >> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions >> qemuDomainSetBlockIoTune and qemuDomainGetBlockI

Re: [libvirt] [PATCH] Make editor used for 'virsh edit' configurable

2014-09-29 Thread Martin Kletzander
On Sun, Sep 28, 2014 at 10:35:52AM +0200, Guido Günther wrote: Debian wants to use 'sensible-editor' instead of vi other distros might want to use other defaults. This avoids distro specific patches. --- configure.ac | 9 + tools/virsh.c | 2 +- 2 files changed, 10 insertions(+), 1 deletio

Re: [libvirt] [PATCH] qemu: save domain status after set the blkio parameters

2014-09-29 Thread Shanzhi Yu
- Original Message - | From: "Martin Kletzander" | To: "Shanzhi Yu" | Cc: libvir-list@redhat.com | Sent: Monday, September 29, 2014 3:07:11 PM | Subject: Re: [libvirt] [PATCH] qemu: save domain status after set the blkio parameters | | On Mon, Sep 29, 2014 at 01:14:58PM +0800, Shanzhi

Re: [libvirt] [PATCH] qemu: save domain status after set the blkio parameters

2014-09-29 Thread Martin Kletzander
On Mon, Sep 29, 2014 at 01:14:58PM +0800, Shanzhi Yu wrote: After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd Same story with bug 1146511 Signed-off-by: Shanzhi Yu --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 ins

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Markus Armbruster
Alex Bligh writes: [...] >>> +/* NB cirrus-vga default value is 8MB anyway, save if we >>> + * monkey patch it to change the default when the qemu-kvm-migration >>> + * machine parameter is selected >>> + */ >>> + >> >> This is too hacky for my taste. >> How about creating a new machine e.g. pc-