When use blockCopy, flags cannot get a right value, because
PyArg_ParseTuple want to get 6 parameters and blockCopy only
pass 5.Flags will get a unpredictable value, this will make
this function cannot be used.And error just like:
unsupported flags (0x7f6c) in function qemuDomainBlockCopy
Signed-
Ian Campbell wrote:
> Hi,
>
> On Fri, 2014-10-17 at 00:42 +0100, xen.org wrote:
>
>> *** Found and reproduced problem changeset ***
>>
>> Bug is in tree: libvirt git://libvirt.org/libvirt.git
>> Bug introduced: 24c160376275b7d31f71fbde83af8183cbf744a7
>> Bug not present: 69f7b67d55316ab7
Hi Markus,
On Tue, Oct 21, 2014 at 10:17:17AM +0200, Markus Armbruster wrote:
> Wouter Verhelst writes:
> > On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote:
[...]
> >> Furthermore, STARTTLS is vulnerable to active attacks: if you can get
> >> between the peers, you can make them
On 10/21/2014 08:34 AM, Peter Krempa wrote:
> As in the previous patch, fix all places where 'flags' is converted as a
> signed argument to unsigned including the python code generator.
> ---
> generator.py| 2 +-
> libvirt-lxc-override.c | 2 +-
> libvirt-override.c | 128
>
On 10/21/2014 08:34 AM, Peter Krempa wrote:
> The override function was copied&pasted from virConnectGetAllDomainStats
> and the function name after the collon was not changed. Fix the issue as
s/collon/colon/
> an invalid name would appear in the error message.
> ---
> libvirt-override.c | 2 +-
On Tue, Oct 21, 2014 at 10:35:06AM +0100, Daniel P. Berrange wrote:
> On Tue, Oct 21, 2014 at 12:10:39AM +0200, Wouter Verhelst wrote:
> > On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote:
> > > I cannot comment on whether the proposed STARTTLS command is at the
> > > correct
> > > s
On 10/21/2014 08:34 AM, Peter Krempa wrote:
> From: Luyao Huang
>
> When 'flags' is set to
> 'libvirt.VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS,
> python will report a error:
>
> OverflowError: signed integer is greater than maximum
>
> as VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS
On 10/21/2014 08:22 AM, Roman Bogorodskiy wrote:
> Build with clang fails with:
>
> CC util/libvirt_util_la-virsocketaddr.lo
> util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
> 'struct sockaddr_in *' increases required alignment from 1 to 4
> [-Werror,-Wcast-align]
>
On 2014/10/20 19:39, Kevin Wolf wrote:
> Am 20.10.2014 um 13:27 hat Weidong Huang geschrieben:
>> On 2014/10/20 17:41, Kevin Wolf wrote:
>>
>>> Am 18.10.2014 um 12:02 hat Weidong Huang geschrieben:
Hi ALL:
There are two ways to eject the cdrom tray. One is by the eject's qmp
c
On 10/10/14, 3:23 PM, "Anirban Chakraborty" wrote:
>v4:
>Changed function virNetDevSupportBandwidth to use switch statement.
>Fixed syntax issues
>Fold the two patches into one as the second patch was a one liner
>
>v3:
>Addressed issues pointed out in V2
>Split into two patches
>
>v2:
>Address
Hi all,
A few weeks ago I proposed a patch to fix LXC shutdown for distros that use
`/run/initctl` instead of `/dev/initctl`.
Replying here so that it gets some more visibility.
Would love some feedback here: are people happy with the general approach?
This is my first libvirt patch: is the sty
Luyao Huang (1):
Fix parsing of 'flags' argument for bulk stats functions
Peter Krempa (2):
Fix function name when parsing arguments in libvirt_virNodeAllocPages
Fix rest of unsigned integer handling
generator.py| 2 +-
libvirt-lxc-override.c | 2 +-
libvirt-override.c
The override function was copied&pasted from virConnectGetAllDomainStats
and the function name after the collon was not changed. Fix the issue as
an invalid name would appear in the error message.
---
libvirt-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-ov
As in the previous patch, fix all places where 'flags' is converted as a
signed argument to unsigned including the python code generator.
---
generator.py| 2 +-
libvirt-lxc-override.c | 2 +-
libvirt-override.c | 128
libvirt-
From: Luyao Huang
When 'flags' is set to
'libvirt.VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS,
python will report a error:
OverflowError: signed integer is greater than maximum
as VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS is defined as 1<<31.
This happens as PyArg_ParseTuple's format
Eric Blake wrote:
> On 10/18/2014 10:41 AM, Roman Bogorodskiy wrote:
> > Build with clang fails with:
> >
> > CC util/libvirt_util_la-virsocketaddr.lo
> > util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
> > 'struct sockaddr_in *' increases required alignment from 1
Build with clang fails with:
CC util/libvirt_util_la-virsocketaddr.lo
util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
'struct sockaddr_in *' increases required alignment from 1 to 4
[-Werror,-Wcast-align]
inet4 = (struct sockaddr_in*) res->ai_addr;
On 10/21/14 11:04, Luyao Huang wrote:
> When set flags=libvirt.VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS,
> python will report
> a error:
> OverflowError: signed integer is greater than maximum
>
> Because VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS = 2147483648 (2**31),
> and it set
On Tue, Oct 21, 2014 at 01:49:37PM +0200, Peter Krempa wrote:
On 10/21/14 12:25, Martin Kletzander wrote:
Commit 60627f6d added the code that requests driver cfg, but forgot to
Commit ID doesn't exist in libvirt.git
Yep, my fault, it's 4882618ed13b469d92fa8b2b4a158fdb17dbe9f1, thanks
for fi
On 20.10.2014 12:48, Stefan Bader wrote:
> On 19.10.2014 17:07, intrigeri wrote:
>> Hi Stefan,
>>
>> Stefan Bader wrote (19 Oct 2014 11:07:40 GMT) :
>>> Yeah, I actually did but it felt a bit hackish but then I am told anything
>>> looks
>>> a bit hackish when it involves autoconf. These are again
On 10/21/14 12:25, Martin Kletzander wrote:
> Commit 60627f6d added the code that requests driver cfg, but forgot to
Commit ID doesn't exist in libvirt.git
> unref it.
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_cgroup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
On 10/21/14 12:25, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> HACKING | 18 +++---
> docs/hacking.html.in | 5 +
> 2 files changed, 16 insertions(+), 7 deletions(-)
>
ACK,
Peter
signature.asc
Description: OpenPGP digital signature
--
l
On Tue, Oct 21, 2014 at 01:33:00PM +0200, Martin Kletzander wrote:
> On Thu, Oct 16, 2014 at 09:28:00PM +0200, Lubomir Rintel wrote:
> >virt-manager on Fedora sets up i686 hosts with "/usr/bin/qemu-kvm" emulator,
> >which in turn unconditionally execs qemu-system-x86_64 querying capabilities
> >the
On Thu, Oct 16, 2014 at 09:28:00PM +0200, Lubomir Rintel wrote:
virt-manager on Fedora sets up i686 hosts with "/usr/bin/qemu-kvm" emulator,
which in turn unconditionally execs qemu-system-x86_64 querying capabilities
then fails:
Error launching details: invalid argument: architecture from emula
Signed-off-by: Martin Kletzander
---
HACKING | 18 +++---
docs/hacking.html.in | 5 +
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/HACKING b/HACKING
index add0841..f8546cb 100644
--- a/HACKING
+++ b/HACKING
@@ -14,7 +14,11 @@ General tips for contr
On Thu, Oct 16, 2014 at 10:18:48PM +0800, Wang Rui wrote:
From: Zhou yimin
If VM is configured with many devices(including passthrough devices)
and large memory, libvirtd will take seconds(in the worst case) to
wait for monitor. In this period the qemu process may run on any
PCPU though I inten
Commit 60627f6d added the code that requests driver cfg, but forgot to
unref it.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_cgroup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index fa894c5..b5bdb36 100644
--- a/src/qemu/qemu_cgr
On Fri, Oct 10, 2014 at 09:05:01AM +0200, Marcin Gibuła wrote:
Hi,
currently, there is no way to force disk detach from KVM guest if guest
does not cooperate. This patch makes virDomainDetachDeviceFlags() respect
VIR_DOMAIN_DEVICE_MODIFY_FORCE flag. When it's on, libvirt will always
call drive_d
On Tue, Oct 21, 2014 at 12:10:39AM +0200, Wouter Verhelst wrote:
> On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote:
> > I cannot comment on whether the proposed STARTTLS command is at the correct
> > stage of the NBD protocol. If there is a protocol description for NBD, I
> > can ha
When set flags=libvirt.VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS, python
will report
a error:
OverflowError: signed integer is greater than maximum
Because VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS = 2147483648 (2**31),
and it set a
signed int in PyArg_ParseTuple function.
if (
Wouter Verhelst writes:
> On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote:
>> >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote:
>> >> > On Sat, Oct 18, 2
31 matches
Mail list logo
