Re: [libvirt] [PowerPC Patch v3] Libvirt CPU enhancements for Power KVM

2014-10-27 Thread Prerna Saxena
On Monday 27 October 2014 08:10 PM, Michal Privoznik wrote: > On 26.10.2014 11:56, Prerna Saxena wrote: >> This patch series is a collection of enhancements for PowerPC CPUs on >> PowerKVM. >> >> Series Summary: >> == >> Patch 1/3 : Introduce a new architecture 'ppc64le' for libvirt. >> P

[libvirt] [PATCH] qemu_agent: Produce more readable error messages

2014-10-27 Thread Michal Privoznik
Not every error message from qemu-ga has to have the 'class' field filled out. For instance, I've seen this error message lately: qemuAgentCheckError:1047 : unable to execute QEMU agent command \ {"execute":"guest-set-time"}: \ {"error":{"desc":"Invalid parameter type, expected: integer"}}

Re: [libvirt] [python v2 PATCH] Add dict check for setTime and allow pass one valid parameter

2014-10-27 Thread lhuang
Thanks your reply and i have a new idea about when time = None. On 10/28/2014 01:24 AM, Eric Blake wrote: On 10/27/2014 12:58 AM, Luyao Huang wrote: When pass None to time, it will set guest time to 0. When pass an empty dictionary, it will report error. Allow a one-element dictionary which con

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-27 Thread Tony Krowiak
On 10/26/2014 12:12 PM, Laine Stump wrote: Note that I've attached a patch that addresses all the issues I raise in this review. Please try it out; if you approve, I will squash it in and push the result (with my name added as Signed-Off-By:, so that you don't have to take all the blame if I scre

Re: [libvirt] [PATCH 1/5] Implement public API for virDomainGetFSInfo

2014-10-27 Thread Tomoki Sekiyama
Hi John, thanks for your review. On 10/23/14, 9:16 , "John Ferlan" wrote: >On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: >> virDomainGetFSInfo returns a list of filesystems information mounted in >>the >> guest, which contains mountpoints, device names, filesystem types, and >> device aliases n

Re: [libvirt] [PATCH] qemu: forbid snapshot-delete --children-only on external snapshot

2014-10-27 Thread Eric Blake
On 10/27/2014 09:14 AM, Kashyap Chamarthy wrote: > On Mon, Oct 27, 2014 at 05:44:29AM -0600, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=956506 documents that >> given a domain where an internal snapshot parent has an external >> snapshot child, we lacked a safety check when tr

Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-27 Thread Eric Blake
On 10/27/2014 09:51 AM, Matthias Gatto wrote: > On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake wrote: >> On 10/07/2014 05:14 AM, Matthias Gatto wrote: >>> Detect if the the qemu binary currently in use suport the bps_max option, s/suport/supports/ >>> If yes add it to the command, if not, just igno

Re: [libvirt] [python v2 PATCH] Add dict check for setTime and allow pass one valid parameter

2014-10-27 Thread Eric Blake
On 10/27/2014 12:58 AM, Luyao Huang wrote: > When pass None to time, it will set guest time to 0. > When pass an empty dictionary, it will report error. > Allow a one-element dictionary which contains 'seconds' > or 'nseconds', setting JUST seconds will do the sane > thing of passing 0 for nseconds

Re: [libvirt] [PATCHv3 02/16] Domain conf: allow more than one IP address for net devices

2014-10-27 Thread Cedric Bosdonnat
Hi Daniel, On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote: > On Fri, Oct 10, 2014 at 02:03:54PM +0200, Cédric Bosdonnat wrote: > > Add the possibility to have more than one IP address configured for a > > domain network interface. IP addresses can also have a prefix to define > > the

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-27 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Fri, Oct 24, 2014 at 09:29:29AM -0600, Jim Fehlig wrote: > >> Right. IMO, sleeping in this test is not papering over a bug. The bug >> is attempting to hotplug/hotunplug devices before the guest has an >> opportunity to boot. As currently written, the attempt to

Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-27 Thread Matthias Gatto
On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake wrote: > On 10/07/2014 05:14 AM, Matthias Gatto wrote: >> Detect if the the qemu binary currently in use suport the bps_max option, >> If yes add it to the command, if not, just ignore the options. > > Ignoring options is wrong. If a user explicitly req

[libvirt] [PATCH v2 0/21] hyperv: hyperv: set of new fonctionalities

2014-10-27 Thread Yves Vinter
From: Yves Vinter This serie of 21 patches implements new functionalities in the libvirt hyperv driver. PATCH 01/21: hyperv: avoid query memleaks on failure PATCH 02/21: hyperv: implementation of virConnectGetVersion PATCH 03/21: hyperv: implementation of virConnectGetCapabilities PATCH 04/21:

Re: [libvirt] [PATCH] qemu: forbid snapshot-delete --children-only on external snapshot

2014-10-27 Thread Kashyap Chamarthy
On Mon, Oct 27, 2014 at 05:44:29AM -0600, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=956506 documents that > given a domain where an internal snapshot parent has an external > snapshot child, we lacked a safety check when trying to use the > --children-only option to snapshot-d

Re: [libvirt] [PATCH v3 1/3] PowerPC cpu: Add support for Power LE Architecture.

2014-10-27 Thread Michal Privoznik
On 26.10.2014 12:05, Prerna Saxena wrote: From 74993aa5eab2cc59e71d038b6f6d3fdb4d0956e1 Mon Sep 17 00:00:00 2001 From: "Pradipta Kr. Banerjee" Date: Tue, 7 Oct 2014 10:33:44 +0530 This adds support for PowerPC Little Endian architecture., and allows libvirt to spawn VMs based on 'ppc64le' a

Re: [libvirt] [PATCH v3 2/3] PowerPC : Add support for launching VMs in 'compat' mode.

2014-10-27 Thread Michal Privoznik
On 26.10.2014 12:07, Prerna Saxena wrote: From c3572e59f1e56322ba92ab35e31da48dd63b7cec Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Tue, 21 Oct 2014 01:06:51 -0400 PowerISA allows processors to run VMs in binary compatibility ("compat") mode supporting an older version of ISA. QEMU ha

Re: [libvirt] [PATCH v3 3/3] PowerPC: Improve PVR handling to fall back to the respective CPU generation.

2014-10-27 Thread Michal Privoznik
On 26.10.2014 12:11, Prerna Saxena wrote: From 24608d7df3ec29604a8862a9a646983cb7f686fa Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Tue, 21 Oct 2014 08:09:19 -0400 IBM Power processors differ uniquely across generations (such as power6, power7, power8). Each generation signifies a new

Re: [libvirt] [PowerPC Patch v3] Libvirt CPU enhancements for Power KVM

2014-10-27 Thread Michal Privoznik
On 26.10.2014 11:56, Prerna Saxena wrote: This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM. Series Summary: == Patch 1/3 : Introduce a new architecture 'ppc64le' for libvirt. Patch 2/3 : Add libvirt support for VMs running in 'compat' mode on Power KVM. Patc

[libvirt] [PATCHv5 0/6] Add non-FreeBSD guest support to Bhyve driver.

2014-10-27 Thread Conrad Meyer
Drvbhyve hardcodes bhyveload(8) as the host bootloader for guests. bhyveload(8) loader only supports FreeBSD guests. This patch series adds and handling to bhyve_command, so libvirt can boot non-FreeBSD guests in Bhyve. Additionally, support for grub-bhyve(1)'s --cons-dev argument is added so t

[libvirt] [PATCHv5 3/6] domaincommon.rng: Add bootloader, bootloader_arg to os=hvm schema for Bhyve

2014-10-27 Thread Conrad Meyer
Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer --- docs/schemas/domaincommon.rng | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 20d81ae..

[libvirt] [PATCHv5 5/6] bhyve: Add console support for grub-bhyve bootloader

2014-10-27 Thread Conrad Meyer
This enables booting interactive GRUB menus (e.g. install CDs) with libvirt-bhyve. Caveat: A terminal other than the '--console' option to 'virsh start' (e.g. 'cu -l /dev/nmdm0B -s 115200') must be used to connect to grub-bhyve because the bhyve loader path is synchronous and must occur before the

[libvirt] [PATCHv5 4/6] bhyvexml2argv: Add tests for domain-configured bootloader, args

2014-10-27 Thread Conrad Meyer
Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer --- .../bhyvexml2argv-bhyveload-explicitargs.args | 3 +++ .../bhyvexml2argv-bhyveload-explicitargs.ldargs| 1 + .../bhyvexml2argv-bhyveload-explicitargs.xml | 23 + .../bhyvexml2argv-cu

[libvirt] [PATCHv5 2/6] bhyvexml2argv: Add loader argv tests.

2014-10-27 Thread Conrad Meyer
Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer --- .../bhyvexml2argv-acpiapic.ldargs | 1 + tests/bhyvexml2argvdata/bhyvexml2argv-base.ldargs | 1 + .../bhyvexml2argvdata/bhyvexml2argv-console.ldargs | 1 + .../bhyvexml2argv-disk-cdrom.ldargs

[libvirt] [PATCHv5 6/6] bhyvexml2argv: Add test for grub console support

2014-10-27 Thread Conrad Meyer
Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer --- .../bhyvexml2argv-serial-grub.args | 4 .../bhyvexml2argv-serial-grub.ldargs | 2 ++ .../bhyvexml2argv-serial-grub.xml | 26 ++ tests/bhyvexml2ar

[libvirt] [PATCHv5 1/6] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-27 Thread Conrad Meyer
We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user doesn't supply /domain/bootloader_args, we make an intelligent guess and try chainloading the first partition on the disk (or a CD if o

Re: [libvirt] [PATCHv3 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-27 Thread Conrad Meyer
On Mon, Oct 27, 2014 at 6:17 AM, Daniel P. Berrange wrote: > On Fri, Oct 24, 2014 at 04:28:14PM -0400, Conrad Meyer wrote: >> docs/drvbhyve.html.in | 28 ++- >> docs/formatdomain.html.in | 4 +- >> po/libvirt.pot| 4 + >> src/bhyve/bhyve_command.c | 204 >> ++

Re: [libvirt] [RFC] Can we error out early for unknown device models?

2014-10-27 Thread Daniel P. Berrange
On Mon, Oct 27, 2014 at 01:42:59PM +0100, Martin Kletzander wrote: > On Fri, Oct 24, 2014 at 11:17:48AM +0100, Daniel P. Berrange wrote: > >On Fri, Oct 24, 2014 at 12:15:24PM +0200, Martin Kletzander wrote: > >>On Fri, Oct 24, 2014 at 07:16:44AM +0200, Michal Privoznik wrote: > >>>On 22.10.2014 13:

Re: [libvirt] [RFC] Can we error out early for unknown device models?

2014-10-27 Thread Martin Kletzander
On Fri, Oct 24, 2014 at 11:17:48AM +0100, Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 12:15:24PM +0200, Martin Kletzander wrote: On Fri, Oct 24, 2014 at 07:16:44AM +0200, Michal Privoznik wrote: >On 22.10.2014 13:58, Martin Kletzander wrote: >>Hi everyone, >> >>I had this idea that since w

[libvirt] [PATCH v2 2/21] hyperv: implementation of virConnectGetVersion

2014-10-27 Thread Yves Vinter
From: Yves Vinter This patch implements the virConnectGetVersion function for the hyperv libvirt driver. The value returned by this function must be formatted as ".." with a maximum of 3 digits per item. Therefore, value of Microsoft hypervisor's version has been truncated as shown below:

[libvirt] [PATCH] qemu: forbid snapshot-delete --children-only on external snapshot

2014-10-27 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=956506 documents that given a domain where an internal snapshot parent has an external snapshot child, we lacked a safety check when trying to use the --children-only option to snapshot-delete: $ virsh start dom $ virsh snapshot-create-as dom internal $

Re: [libvirt] [libvirt-python PATCH] Add a type check for time in libvirt_virDomainSetTime

2014-10-27 Thread Luyao Huang
Thanks for your reply and i add check for one-element and 0-element. But seems this will make the code not succinct enough. V2: https://www.redhat.com/archives/libvir-list/2014-October/msg00815.html BTW,How about move the check to libvirt-override-virDomain.py? Thanks, Luyao Huang - Origina

Re: [libvirt] [PATCHv3 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-27 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 04:28:14PM -0400, Conrad Meyer wrote: > We still default to bhyveloader(1) if no explicit bootloader > configuration is supplied in the domain. > > If the /domain/bootloader looks like grub-bhyve and the user doesn't > supply /domain/bootloader_args, we make an intelligent

Re: [libvirt] [PATCHv3 2/2] Generated PO files for 'bhyve: Support /domain/bootloader'

2014-10-27 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 04:28:15PM -0400, Conrad Meyer wrote: > Sponsored by: EMC / Isilon storage division > > Signed-off-by: Conrad Meyer For future reference you can just drop any changes to po files. We manage translations & merging via a separate process, so we don't do patches for them.

Re: [libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-27 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 03:28:33PM -0700, Craig Rodrigues wrote: > On Fri, Oct 24, 2014 at 6:11 AM, Conrad Rad wrote: > > > > > Any idea how soon? Months? A year? 5 years? I'm not comfortable > > postponing improvements indefinitely for vaporware. In the wonderful > > bhyve-UEFI future, we can ig

Re: [libvirt] Coming release plans for libvirt-1.2.10

2014-10-27 Thread Prerna Saxena
On Monday 27 October 2014 01:39 PM, Daniel Veillard wrote: > It's already the end of the month and I didn't pushed plans yet > (forgot !) for the coming release. We have only until the end of > the week to get to next month, o we should freeze this week. > There isn't that many commits yet sine 1

Re: [libvirt] [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/21/2014 12:10 AM, Gonglei wrote: > > There is a problem. > > 1. Qemu receive the "eject" command. > 2. Runs "eject_request_cb" when an eject request is issued from > the monitor, the tray > is closed, and the medium is locked. But the drive is no

[libvirt] Coming release plans for libvirt-1.2.10

2014-10-27 Thread Daniel Veillard
It's already the end of the month and I didn't pushed plans yet (forgot !) for the coming release. We have only until the end of the week to get to next month, o we should freeze this week. There isn't that many commits yet sine 1.2.9, less than 140 and a number of them are the large splitting cha

[libvirt] [python v2 PATCH] Add dict check for setTime and allow pass one valid parameter

2014-10-27 Thread Luyao Huang
When pass None to time, it will set guest time to 0. When pass an empty dictionary, it will report error. Allow a one-element dictionary which contains 'seconds' or 'nseconds', setting JUST seconds will do the sane thing of passing 0 for nseconds, instead of erroring out. Signed-off-by: Luyao Huan