Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-20 Thread Anirban Chakraborty
On 11/20/14, 5:43 AM, "Vasiliy Tolstov" wrote: >2014-11-20 7:58 GMT+03:00 Anirban Chakraborty : >> Your original error message was that qemu couldnĀ¹t find a tap device. >>So, >> I am not sure how the above error relates to your original error. >> Can you write your detail configuration setup an

[libvirt] [PATCH] docs: fix a typo in formatdomain.html

2014-11-20 Thread Chen Fan
Signed-off-by: Chen Fan --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 9364eb5..6a15074 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3413,7 +3413,7 @@

Re: [libvirt] ANNOUNCE: virt-manager 1.1.0 released

2014-11-20 Thread Jason Helfman
Hello, I was able to get this imported for FreeBSD, but had to implement a couple of patches for it to work: https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markup&pathrev=372972 https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files

[libvirt] [PATCH] network: Let domains be restricted to local DNS

2014-11-20 Thread Josh Stone
This adds a new "localOnly" attribute on the domain element of the network xml. With this set to "yes", DNS requests under that domain will only be resolved by libvirt's dnsmasq, never forwarded upstream. This was how it worked before commit f69a6b987d616, and I found that functionality useful.

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 18:54 , "John Ferlan" wrote: >On 11/20/2014 01:19 PM, Eric Blake wrote: >> On 11/20/2014 11:11 AM, John Ferlan wrote: >> However, for some reason I see this build error after 2/5: make[3]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/s

Re: [libvirt] [libvirt-python PATCH] override: Implement bindings for virDomainGetFSInfo as domain.fsInfo

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 7:24 , "Pavel Hrdina" wrote: >On 11/20/2014 01:22 PM, Pavel Hrdina wrote: >> On 11/18/2014 12:29 AM, Tomoki Sekiyama wrote: >>> Implement the function which returns a list of tuples, that contains >>> members >>> of virDomainFSInfo struct. >>> >>> Signed-off-by: Tomoki Sekiyama >>>

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread John Ferlan
On 11/20/2014 01:19 PM, Eric Blake wrote: > On 11/20/2014 11:11 AM, John Ferlan wrote: > >>> However, for some reason I see this build error after 2/5: >>> >>> make[3]: Entering directory >>> '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/src' >>>CC libvirt_la-packet-libvirt.lo

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/19/14, 17:58 , "John Ferlan" wrote: >On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: >> Hi, >> >> This is v2 of patchset to add virDomainGetFSInfo API. >> >> * changes in v1->v2: >> -[all] removed redundant NULL element at the last of returned info >>array >> -[3/5] make error messages i

Re: [libvirt] [PATCH v2 2/5] remote: Implement the remote protocol for virDomainGetFSInfo

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 14:12 , "Eric Blake" wrote: >On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote: >> Add daemon and driver code to (de-)serialize virDomainFSInfo. >> >> Signed-off-by: Tomoki Sekiyama >> --- >> daemon/remote.c | 117 >>++ >> src/remo

Re: [libvirt] [PATCH v2 1/5] Implement public API for virDomainGetFSInfo

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 14:09 , "Eric Blake" wrote: >On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote: >> virDomainGetFSInfo returns a list of filesystems information mounted in >>the >> guest, which contains mountpoints, device names, filesystem types, and >> device aliases named by libvirt. This will be usef

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 14:17 , "Eric Blake" wrote: >On 11/20/2014 05:33 AM, Michal Privoznik wrote: > >>> I'm also hoping someone else (eblake?) can look at the >>>remote_protocol.x >>> changes to ensure they encompass everything they are supposed to. Also >>> that the usage of QEMU_JOB_QUERY not _MODIFY

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

2014-11-20 Thread Eric Blake
On 11/20/2014 08:12 AM, Conrad Meyer wrote: > Hi Eric, > > I think this change breaks build on FreeBSD: > > CC util/libvirt_util_la-virdbus.lo > util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka > 'unsigned int *') increases required alignment from 1 to 4 > [-Werr

Re: [libvirt] [PATCH] storage: qemu: Fix security labelling of new image chain elements

2014-11-20 Thread Eric Blake
On 11/20/2014 08:23 AM, Peter Krempa wrote: > When creating a disk image snapshot the libvirt code would blindly copy > the parents label to the newly created image. This runs into problems > when you start a VM from an image hosted on NFS (or other storage system > that doesn't support selinux lab

Re: [libvirt] [PATCH 08/11] qemu: process: Refresh virtio channel guest state when connecting to mon

2014-11-20 Thread Jiri Denemark
On Thu, Nov 20, 2014 at 22:22:56 +0100, Jiri Denemark wrote: > On Wed, Nov 19, 2014 at 11:23:21 +0100, Peter Krempa wrote: > > Use data provided by "query-chardev" to refresh the guest frontend state > > of virtio channels. > > --- > > src/qemu/qemu_process.c | 68 > >

Re: [libvirt] [PATCH 08/11] qemu: process: Refresh virtio channel guest state when connecting to mon

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:21 +0100, Peter Krempa wrote: > Use data provided by "query-chardev" to refresh the guest frontend state > of virtio channels. > --- > src/qemu/qemu_process.c | 68 > +++-- > 1 file changed, 66 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH 07/11] qemu: chardev: Extract more information about character devices

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:20 +0100, Peter Krempa wrote: > Improve the monitor function to also retrieve the guest state of > character device (if provided) so that we can refresh the state of > virtio-serial channels and perhaps react to changes in the state in > future patches. > > This patch

Re: [libvirt] [PATCH 06/11] qemu: Add handling for VSERPORT_CHANGE event

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:19 +0100, Peter Krempa wrote: > New qemu added a new event that is emitted when a virtio serial channel > is opened in the guest OS. This allows us to update the state of the > port in the output-only XML element. > > This patch implements the monitor callbacks and ne

Re: [libvirt] [PATCH 11/11] qemu: Emit the guest agent lifecycle event

2014-11-20 Thread Eric Blake
On 11/20/2014 12:03 PM, Peter Krempa wrote: >>> @@ -4369,6 +4370,10 @@ processSerialChangedEvent(virQEMUDriverPtr driver, >>> dev.data.chr->targetType != >>> VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_VIRTIO) >>> goto endjob; >>> >>> +if (STREQ_NULLABLE(dev.data.chr->target.name, >

Re: [libvirt] [PATCH 05/11] conf: Add channel state for virtio channels to the XML

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:18 +0100, Peter Krempa wrote: > To track state of virtio channels this patch adds a new output-only > attribute called 'state' to the element of virtio channels. > > This will be later populated with the guest state of the channel. > --- > docs/formatdomain.html.in

[libvirt] [PATCH v3 5/6] qemu-command: use vram attribute for all video devices

2014-11-20 Thread Pavel Hrdina
So far we hadn't any option to set video memory size for qemu video devices. There were only vram (ram for QXL) attribute but it was valid only for QXL video device. To provide this feature to users qemu has dedicated device attribute called 'vgamem_mb' to set the video memory size. We will use th

[libvirt] [PATCH v3 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-20 Thread Pavel Hrdina
Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH v3 4/6] caps: introduce new QEMU capability for vgamem_mb device property

2014-11-20 Thread Pavel Hrdina
Allow setting vgamem size for video devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 33 src/qemu/qemu_capabilities.h | 4 + tests/qemucapabilitiesdata/caps_1.2.2

[libvirt] [PATCH v3 1/6] internal: add macro to round value to the next closest power of 2

2014-11-20 Thread Pavel Hrdina
There are two special cases, if the input number is 0 or the number is larger then 2^31 (for 32bit unsigned int). For the special cases the return value is 0 because they cannot be rounded. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina --- bootstrap.c

[libvirt] [PATCH v3 3/6] QXL: fix setting ram and vram values for QEMU QXL device

2014-11-20 Thread Pavel Hrdina
QEMU has two different type of QXL display device. The first "qxl-vga" is for primary video device and second "qxl" is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and obsolete is using "-vga" option and the current

[libvirt] [PATCH v3 0/6] improve setting video memory

2014-11-20 Thread Pavel Hrdina
As it was pointed out that QEMU needs that the video memory size should be rounded to power of two this patch series introduces new macro to round number to power of two. There are two special cases (more description in the commit message). This patch series also fixes few issues that I've found w

[libvirt] [PATCH v3 2/6] video: cleanup usage of vram attribute and update documentation

2014-11-20 Thread Pavel Hrdina
The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM and the old XEN driver. Only in case of QEMU the vram was used for QXL. This patch updates the documentation to reflect current code in libvirt and also changes the cases when we

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/20/2014 05:33 AM, Michal Privoznik wrote: >> I'm also hoping someone else (eblake?) can look at the remote_protocol.x >> changes to ensure they encompass everything they are supposed to. Also >> that the usage of QEMU_JOB_QUERY not _MODIFY for the GetFSInfo seems >> more appropriate and is

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/19/2014 03:58 PM, John Ferlan wrote: > > > On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: >> Hi, >> >> This is v2 of patchset to add virDomainGetFSInfo API. >> >> * changes in v1->v2: >> -[all] removed redundant NULL element at the last of returned info array >> -[3/5] make error messages

Re: [libvirt] [PATCH v2 2/5] remote: Implement the remote protocol for virDomainGetFSInfo

2014-11-20 Thread Eric Blake
On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote: > Add daemon and driver code to (de-)serialize virDomainFSInfo. > > Signed-off-by: Tomoki Sekiyama > --- > daemon/remote.c | 117 > ++ > src/remote/remote_driver.c | 92 +

Re: [libvirt] [PATCH 11/11] qemu: Emit the guest agent lifecycle event

2014-11-20 Thread Peter Krempa
On 11/20/14 20:01, Eric Blake wrote: > On 11/19/2014 03:23 AM, Peter Krempa wrote: >> Add code to emit the event on change of the channel state and reconnect >> to the qemu process. >> --- >> src/qemu/qemu_driver.c | 5 + >> src/qemu/qemu_process.c | 13 ++--- >> 2 files changed, 15

Re: [libvirt] [PATCH 09/11] event: Add guest agent lifecycle event

2014-11-20 Thread Eric Blake
On 11/19/2014 03:23 AM, Peter Krempa wrote: > As qemu is now able to notify us about change of the channel state used > for communication with the guest agent we now can more precisely track > the state of the guest agent. > > To allow notifying management apps this patch implements a new event >

Re: [libvirt] [PATCH v2 1/5] Implement public API for virDomainGetFSInfo

2014-11-20 Thread Eric Blake
On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote: > virDomainGetFSInfo returns a list of filesystems information mounted in the > guest, which contains mountpoints, device names, filesystem types, and > device aliases named by libvirt. This will be useful, for example, to > specify mountpoints to fsfr

Re: [libvirt] [PATCH 09/11] event: Add guest agent lifecycle event

2014-11-20 Thread Peter Krempa
On 11/20/14 19:54, Eric Blake wrote: > On 11/19/2014 03:23 AM, Peter Krempa wrote: >> As qemu is now able to notify us about change of the channel state used >> for communication with the guest agent we now can more precisely track >> the state of the guest agent. >> >> To allow notifying managemen

Re: [libvirt] [PATCH 11/11] qemu: Emit the guest agent lifecycle event

2014-11-20 Thread Eric Blake
On 11/19/2014 03:23 AM, Peter Krempa wrote: > Add code to emit the event on change of the channel state and reconnect > to the qemu process. > --- > src/qemu/qemu_driver.c | 5 + > src/qemu/qemu_process.c | 13 ++--- > 2 files changed, 15 insertions(+), 3 deletions(-) > > @@ -4369,

Re: [libvirt] [PATCH 10/11] examples: Add support for the guest agent lifecycle event

2014-11-20 Thread Eric Blake
On 11/19/2014 03:23 AM, Peter Krempa wrote: > Add code to support the event in the object-event example. > --- > examples/object-events/event-test.c | 43 > - > 1 file changed, 42 insertions(+), 1 deletion(-) > ACK -- Eric Blake eblake redhat com+1-9

Re: [libvirt] [PATCH 09/11] event: Add guest agent lifecycle event

2014-11-20 Thread Eric Blake
On 11/19/2014 03:23 AM, Peter Krempa wrote: > As qemu is now able to notify us about change of the channel state used > for communication with the guest agent we now can more precisely track > the state of the guest agent. > > To allow notifying management apps this patch implements a new event >

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/20/2014 11:11 AM, John Ferlan wrote: >> However, for some reason I see this build error after 2/5: >> >> make[3]: Entering directory >> '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/src' >>CC libvirt_la-packet-libvirt.lo >> In file included from libvirt/protocol.h:5:0, >>

Re: [libvirt] [PATCH 05/12] util: storage: Copy hosts of a storage file only if they exist

2014-11-20 Thread Peter Krempa
On 11/20/14 16:10, John Ferlan wrote: > > > On 11/12/2014 08:47 AM, Peter Krempa wrote: >> If there are no hosts for a storage source virStorageSourceCopy would >> try to copy them anyways. As the success of virStorageNetHostDefCopy is >> determined by returning a pointer and malloc of 0 elements

Re: [libvirt] [PATCH 01/12] docs: domain: Move docs for storage hosts under the element

2014-11-20 Thread Peter Krempa
On 11/20/14 16:08, John Ferlan wrote: > > > On 11/12/2014 08:47 AM, Peter Krempa wrote: >> The docs describing the element that are under the >> element in the XML document were incorrectly placed under the >> element. Move them to the correct place. >> --- >> docs/formatdomain.html.in | 104

[libvirt] Libvirt Live Migration

2014-11-20 Thread Dhia Abbassi
I'm trying to implement a virtualization API. I was testing migration with libvirt I got some problems. When I use the following command : *virsh migrate --live --persistent --copy-storage-all vm-clone1 qemu+ssh://server_ip/system* the migration works fine but in the destination host the migrate

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

2014-11-20 Thread Conrad Meyer
Hi Eric, I think this change breaks build on FreeBSD: CC util/libvirt_util_la-virdbus.lo util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align] GET_NEXT_VAL(dbus_bool_t, bool_

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread John Ferlan
On 11/20/2014 07:33 AM, Michal Privoznik wrote: > On 19.11.2014 23:58, John Ferlan wrote: >> >> >> On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: >>> Hi, >>> >>> This is v2 of patchset to add virDomainGetFSInfo API. >>> >>> * changes in v1->v2: >>> -[all] removed redundant NULL element at the l

Re: [libvirt] [PATCH 04/11] qemu: monitor: Rename and improve qemuMonitorGetPtyPaths

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:17 +0100, Peter Krempa wrote: > To unify future additions that require information from "query-chardev" > rename qemuMonitorGetPtyPaths and friends to qemuMonitorGetChardevInfo > and move the allocation of the returned hash into the top level > function. > --- > src/q

Re: [libvirt] [PATCH 03/11] test: xml2xml: Print full filenames if xml2xml test fails

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:16 +0100, Peter Krempa wrote: > To simplify looking for a problem instrument the XML comparator function > with possibility to print the filename of the failed/expected XML > output. > > This is necessary as the VIR_TEST_DIFFERENT macro possibly tests two XML > files

Re: [libvirt] [PATCH 02/11] conf: Annotate source enums for character device struct members

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:15 +0100, Peter Krempa wrote: > Add a comment to track which values may be present in certain members of > a struct _virDomainChrDef. > --- > src/conf/domain_conf.h | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/conf/domain_conf.h

Re: [libvirt] [PATCH 01/11] qemu: process: report useful error if alias formatting fails

2014-11-20 Thread Jiri Denemark
On Wed, Nov 19, 2014 at 11:23:14 +0100, Peter Krempa wrote: > When retrieving the paths for PTY devices the alias gets formatted into > a static string. If it doesn't fit we wouldn't report an error. > --- > src/qemu/qemu_process.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

[libvirt] Plan for next releases

2014-11-20 Thread Daniel Veillard
We are getting close to the end of the month and in theory we should enter freeze around next week if we want to release 1.2.11 early Dec. However: - we have 'only' 150 commits since 1.2.10 - December is usually heavilly truncated due to Xmas/etc... vacations - I'm actually on vacations nex

[libvirt] [PATCH] build: avoid 32-bit failure on older gcc

2014-11-20 Thread Eric Blake
On 32-bit platforms with old gcc (hello RHEL 5 gcc 4.1.2), the build fails with: virsh-domain.c: In function 'cmdBlockCopy': virsh-domain.c:2172: warning: comparison is always false due to limited range of data type Adjust the code to silence the warning. * tools/virsh-domain.c (cmdBlockCopy): P

[libvirt] [PATCH] build: fix build when not using dbus

2014-11-20 Thread Eric Blake
Commit c0e7022 breaks on a machine that lacks dbus headers: In file included from util/virdbus.c:24:0: util/virdbuspriv.h:31:3: error: unknown type name 'dbus_int16_t' * src/util/virdbuspriv.h (DBusBasicValue): Only provide fallback when dbus is compiled. Signed-off-by: Eric Blake --- Pushing

[libvirt] [PATCH] drvbhyve: Automatically tear down guest domains on shutdown

2014-11-20 Thread Conrad Meyer
Reboot requires more sophistication and is left as a future work item -- but at least part of the plumbing is in place. --- src/Makefile.am | 2 + src/bhyve/bhyve_monitor.c | 184 ++ src/bhyve/bhyve_monitor.h | 36 + src/bhyve/bhyve_

Re: [libvirt] [PATCH 0/2] Fix fc_host SCSI pool refresh issues

2014-11-20 Thread John Ferlan
On 11/19/2014 03:52 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1152382 > > Fix a couple of fc_host SCSI refresh pool issues. The first patch I found > while working on the second. > > It turns out the existing logic to handle 'retval' wasn't correct. Using > a default

Re: [libvirt] [PATCH 1/2] storage: Fix issue finding LU's when block doesn't exist

2014-11-20 Thread John Ferlan
On 11/20/2014 09:12 AM, Michal Privoznik wrote: <...snip...> >> @@ -451,10 +451,10 @@ virStorageBackendSCSIFindLUs(virStoragePoolObjPtr pool, >> continue; >> } >> >> -found = true; >> -VIR_DEBUG("Found LU '%s'", lun_dirent->d_name); >> +VIR_DEBUG(

[libvirt] [PATCH] storage: qemu: Fix security labelling of new image chain elements

2014-11-20 Thread Peter Krempa
When creating a disk image snapshot the libvirt code would blindly copy the parents label to the newly created image. This runs into problems when you start a VM from an image hosted on NFS (or other storage system that doesn't support selinux labels) and the snapshot destination is on a storage sy

Re: [libvirt] [PATCH 11/12] storage: rbd: qemu: Add support for specifying internal RBD snapshots

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > Some storage systems have internal support for snapshots. Libvirt should > be able to select a correct snapshot when starting a VM. > > This patch adds a XML element to select a storage source snapshot for > the RBD protocol which supports this featu

Re: [libvirt] [PATCH 09/12] util: storagefile: Split out parsing of NBD string into a separate func

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > Split out the code so that the function looks homogenous after adding > more protocol specific parsers. > --- > src/util/virstoragefile.c | 141 > -- > 1 file changed, 86 insertions(+), 55 deletions(-) >

Re: [libvirt] [PATCH 12/12] storage: rbd: Implement support for passing config file option

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > To be able to express some use cases of the RBD backing with libvirt, we > need to be able to specify a config file for the RBD client to qemu as > that is one of the commonly used options. > --- > docs/formatdomain.html.in

Re: [libvirt] [PATCH 00/12] Unbreak vm's backed by RBD disks

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > After recent refactors, starting a VM whose disk is backed by RBD storage > would > fail as the parser for the backing file specification string was not > implemented in the metadata crawler. > > Reuse qemu's parser to do this and fix a few things a

Re: [libvirt] [PATCH] Fix API docs for header file re-organization

2014-11-20 Thread Daniel P. Berrange
On Tue, Nov 18, 2014 at 04:48:32AM +0530, Nehal J Wani wrote: > I guess, references of libvirt-libvirt.html were not removed from > docs/Makefile.am > > Following patch fixes it (But I am not sure if it is the right way to go): > > diff --git a/docs/Makefile.am b/docs/Makefile.am > index 910bfef.

Re: [libvirt] [PATCH 08/12] util: split out qemuParseRBDString into a common helper

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > To allow reuse this non-trivial parser code in the backing store parser > this part of the command line parser needs to be split out into a > separate funciton. > --- > src/libvirt_private.syms | 1 + > src/qemu/qemu_command.c | 133 +++-

Re: [libvirt] [PATCH 06/12] qemu: Refactor qemuBuildNetworkDriveURI to take a virStorageSourcePtr

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > Instead of spliting out various fields, pass the complete structure and s/spliting/splitting > let the function pick various things of it. > > As one of the callers isn't using virStorageSourcePtr to store the data, > this patch adds glue code that

Re: [libvirt] [PATCH 05/12] util: storage: Copy hosts of a storage file only if they exist

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > If there are no hosts for a storage source virStorageSourceCopy would > try to copy them anyways. As the success of virStorageNetHostDefCopy is > determined by returning a pointer and malloc of 0 elements might return > NULL according to the implement

Re: [libvirt] [PATCH 03/12] util: buffer: Clarify scope of the escape operation in virBufferEscape

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > The escaping is applied only to the string, not the formating argument. > State this fact in the docs. s/formating/format ACK John > --- > src/util/virbuffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > -- libvir-list mailin

Re: [libvirt] [PATCH 04/12] util: storage: Add notice for extension of struct virStorageSource

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > As we now have a deep copy function for struct virStorageSource add a > notice that extensions of the structure require also appropriate changes > to the virStorageSourceCopy func. > --- > src/util/virstoragefile.h | 8 +--- > 1 file changed, 5 i

[libvirt] [PATCH v3] qemu: Pass file descriptor when using TPM passthrough

2014-11-20 Thread Stefan Berger
Pass the TPM file descriptor to QEMU via command line. Instead of passing /dev/tpm0 we now pass /dev/fdset/10 and the additional parameters -add-fd set=10,fd=20. This addresses the use case when QEMU is started with non-root privileges and QEMU cannot open /dev/tpm0 for example. One problem is th

Re: [libvirt] [PATCH 01/12] docs: domain: Move docs for storage hosts under the element

2014-11-20 Thread John Ferlan
On 11/12/2014 08:47 AM, Peter Krempa wrote: > The docs describing the element that are under the > element in the XML document were incorrectly placed under the > element. Move them to the correct place. > --- > docs/formatdomain.html.in | 104 > --

Re: [libvirt] [PATCH 2/2] storage: Add thread to refresh for createVport

2014-11-20 Thread Michal Privoznik
On 19.11.2014 21:52, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1152382 When libvirt create's the vport (VPORT_CREATE) for the vHBA, there isn't enough "time" between the creation and the running of the following backend->refreshPool after a backend->startPool in order to fin

Re: [libvirt] [PATCH 1/2] storage: Fix issue finding LU's when block doesn't exist

2014-11-20 Thread Michal Privoznik
On 19.11.2014 21:52, John Ferlan wrote: Fix a problem in the getBlockDevice and processLU where retval initialized to zero causing some failures to erroneously continue through to the virStorageBackendSCSINewLun with an attempt to find a path for "/dev/(null)". This would fail approximately 10 se

[libvirt] [PATCHv5 1/3] leaseshelper: improvements to support all events

2014-11-20 Thread Peter Krempa
From: Nehal J Wani This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and obsoletes use of the lease database file (.leases). That file will not be created

[libvirt] [PATCHv5 0/3] leaseshelper: Couple of improvements

2014-11-20 Thread Peter Krempa
Nehal J Wani (1): leaseshelper: improvements to support all events Peter Krempa (2): leaseshelper: Refactor control flow network: dnsmasq: Don't format lease file path src/network/bridge_driver.c| 16 +- src/network/bridge_driver.h| 3 - s

[libvirt] [PATCHv5 3/3] network: dnsmasq: Don't format lease file path

2014-11-20 Thread Peter Krempa
Now that we don't use the leases file at all for leases just don't format it into the config and use the leaseshelper to do all the lifting. --- src/network/bridge_driver.c | 13 ++--- src/network/bridge_driver.h | 3 --- tes

[libvirt] [PATCHv5 2/3] leaseshelper: Refactor control flow

2014-11-20 Thread Peter Krempa
Untangle a few conditions into a case statement and improve reporting of invaid commands. --- src/network/leaseshelper.c | 100 ++--- 1 file changed, 58 insertions(+), 42 deletions(-) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c inde

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-20 Thread Vasiliy Tolstov
2014-11-20 7:58 GMT+03:00 Anirban Chakraborty : > Your original error message was that qemu couldnĀ¹t find a tap device. So, > I am not sure how the above error relates to your original error. > Can you write your detail configuration setup and the steps you have taken > to get at this error? If i

Re: [libvirt] [PATCH 0/8] Add XML validation to the APIs

2014-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2014 at 12:02:12PM +0100, Martin Kletzander wrote: > On Wed, Nov 19, 2014 at 12:51:22PM +, Daniel P. Berrange wrote: > >On Wed, Nov 19, 2014 at 09:45:39AM +, Daniel P. Berrange wrote: > >>On Wed, Nov 19, 2014 at 08:23:22AM +0100, Martin Kletzander wrote: > >>> On Tue, Nov 18

[libvirt] [PATCH] build: fix build with older dbus headers

2014-11-20 Thread Eric Blake
Compilation on a RHEL 5 host failed, due to the older dbus headers present on that machine, and triggered by commit 2aa167ca: util/virdbus.c: In function 'virDBusMessageIterDecode': util/virdbus.c:952: error: 'DBusBasicValue' undeclared (first use in this function) * m4/virt-dbus.m4 (LIBVIRT_CHE

Re: [libvirt] [libvirt PATCH] rpc: do not fail if the pid of the connecting process is not set

2014-11-20 Thread Giuseppe Scrivano
Martin Kletzander writes: > On Wed, Nov 19, 2014 at 06:29:48PM +0100, Giuseppe Scrivano wrote: >>getsockopt(sock->fd, SOL_SOCKET, SO_PEERCRED, ...) sets the pid to 0 >>when the process that opens the connection is in another container. >> >>Signed-off-by: Giuseppe Scrivano >>--- >> src/rpc/virne

Re: [libvirt] [PATCH] util: don't log failure when older iptables lacks -w

2014-11-20 Thread Eric Blake
On 11/20/2014 12:38 AM, Peter Krempa wrote: > On 11/20/14 00:21, Eric Blake wrote: >> Commit dc33e6e4 caused older platforms like Fedora 20 to emit >> scary log messages at startup: >> >> 2014-11-19 23:12:58.800+: 28906: error : virCommandWait:2532 : internal >> error: Child process (/usr/sbin

Re: [libvirt] [PATCH 06/11] qemu: Add handling for VSERPORT_CHANGE event

2014-11-20 Thread Peter Krempa
On 11/20/14 14:11, Eric Blake wrote: > On 11/20/2014 12:47 AM, Peter Krempa wrote: >> On 11/20/14 08:44, Wang Rui wrote: >>> On 2014/11/19 18:23, Peter Krempa wrote: New qemu added a new event that is emitted when a virtio serial channel is opened in the guest OS. This allows us to update

Re: [libvirt] [PATCH 06/11] qemu: Add handling for VSERPORT_CHANGE event

2014-11-20 Thread Eric Blake
On 11/20/2014 12:47 AM, Peter Krempa wrote: > On 11/20/14 08:44, Wang Rui wrote: >> On 2014/11/19 18:23, Peter Krempa wrote: >>> New qemu added a new event that is emitted when a virtio serial channel >>> is opened in the guest OS. This allows us to update the state of the >>> port in the output-on

Re: [libvirt] [libvirt PATCH] rpc: do not fail if the pid of the connecting process is not set

2014-11-20 Thread Martin Kletzander
On Wed, Nov 19, 2014 at 06:29:48PM +0100, Giuseppe Scrivano wrote: getsockopt(sock->fd, SOL_SOCKET, SO_PEERCRED, ...) sets the pid to 0 when the process that opens the connection is in another container. Signed-off-by: Giuseppe Scrivano --- src/rpc/virnetsocket.c | 8 ++-- 1 file changed, 6

Re: [libvirt] [PATCH v3 03/12] parallels: move parallelsDomNotFoundError to parallels_utils.h

2014-11-20 Thread Peter Krempa
On 11/18/14 14:16, Dmitry Guryanov wrote: > Move macro parallelsDomNotFoundError to file > parallels_utils.h, because it will be used in > parallels_sdk.c. > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_driver.c | 8 > src/parallels/parallels_utils.h | 8 >

Re: [libvirt] [PATCH] qemu: Really fix crash in tunnelled migration

2014-11-20 Thread Peter Krempa
On 11/20/14 13:46, Jiri Denemark wrote: > Oops, I forgot to squash one more instance of the same check into the > previous commit (v1.2.10-144-g52691f9). > > https://bugzilla.redhat.com/show_bug.cgi?id=1147331 > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 2 +- > 1 file chan

[libvirt] [PATCH] qemu: Really fix crash in tunnelled migration

2014-11-20 Thread Jiri Denemark
Oops, I forgot to squash one more instance of the same check into the previous commit (v1.2.10-144-g52691f9). https://bugzilla.redhat.com/show_bug.cgi?id=1147331 Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qem

Re: [libvirt] [PATCH v3 01/12] parallels: move IS_CT macro to parallels_utils.h

2014-11-20 Thread Peter Krempa
On 11/18/14 14:16, Dmitry Guryanov wrote: > This macro will be used in paralles_sdk.c so move > it to common header. > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_driver.c | 2 -- > src/parallels/parallels_utils.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) >

Re: [libvirt] [PATCHv3] virsh: Fix msg: blockjob is aborted from another client

2014-11-20 Thread Peter Krempa
On 11/20/14 12:52, Erik Skultety wrote: > When a block{pull, copy, commit} is aborted via keyboard interrupt, > the job is properly canceled followed by proper error message. > However, when the job receives an abort from another client connected > to the same domain, the error message incorrectly

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Michal Privoznik
On 19.11.2014 23:58, John Ferlan wrote: On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1->v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in qemu_agent.c consis

[libvirt] [PATCH] qemu: Fix crash in tunnelled migration

2014-11-20 Thread Jiri Denemark
Any attempt to start a tunnelled migration with libvirtd that supports RDMA migration (specifically commit v1.2.8-226-ged22a47) crashes libvirtd on the destination host. The crash is inevitable because qemuMigrationPrepareAny is always called with NULL protocol in case of tunnelled migration. htt

Re: [libvirt] [PATCH] qemu: Fix crash in tunnelled migration

2014-11-20 Thread Peter Krempa
On 11/20/14 13:27, Jiri Denemark wrote: > Any attempt to start a tunnelled migration with libvirtd that supports > RDMA migration (specifically commit v1.2.8-226-ged22a47) crashes > libvirtd on the destination host. > > The crash is inevitable because qemuMigrationPrepareAny is always called > wit

Re: [libvirt] [libvirt-python PATCH] override: Implement bindings for virDomainGetFSInfo as domain.fsInfo

2014-11-20 Thread Pavel Hrdina
On 11/20/2014 01:22 PM, Pavel Hrdina wrote: On 11/18/2014 12:29 AM, Tomoki Sekiyama wrote: Implement the function which returns a list of tuples, that contains members of virDomainFSInfo struct. Signed-off-by: Tomoki Sekiyama --- generator.py |5 +++ libvirt-override-api.xml

Re: [libvirt] [libvirt-python PATCH] override: Implement bindings for virDomainGetFSInfo as domain.fsInfo

2014-11-20 Thread Pavel Hrdina
On 11/18/2014 12:29 AM, Tomoki Sekiyama wrote: Implement the function which returns a list of tuples, that contains members of virDomainFSInfo struct. Signed-off-by: Tomoki Sekiyama --- generator.py |5 +++ libvirt-override-api.xml |6 libvirt-override.c | 7

[libvirt] [PATCHv3] virsh: Fix msg: blockjob is aborted from another client

2014-11-20 Thread Erik Skultety
When a block{pull, copy, commit} is aborted via keyboard interrupt, the job is properly canceled followed by proper error message. However, when the job receives an abort from another client connected to the same domain, the error message incorrectly indicates that a blockjob has been finished succ

Re: [libvirt] [PATCH 0/8] Add XML validation to the APIs

2014-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2014 at 12:02:12PM +0100, Martin Kletzander wrote: > On Wed, Nov 19, 2014 at 12:51:22PM +, Daniel P. Berrange wrote: > >On Wed, Nov 19, 2014 at 09:45:39AM +, Daniel P. Berrange wrote: > >>On Wed, Nov 19, 2014 at 08:23:22AM +0100, Martin Kletzander wrote: > >>> On Tue, Nov 18

Re: [libvirt] [PATCH 0/8] Add XML validation to the APIs

2014-11-20 Thread Martin Kletzander
On Wed, Nov 19, 2014 at 12:51:22PM +, Daniel P. Berrange wrote: On Wed, Nov 19, 2014 at 09:45:39AM +, Daniel P. Berrange wrote: On Wed, Nov 19, 2014 at 08:23:22AM +0100, Martin Kletzander wrote: > On Tue, Nov 18, 2014 at 05:59:47PM +, Daniel P. Berrange wrote: > >This proof of concep

Re: [libvirt] [PATCH v4] leaseshelper: improvements to support all events

2014-11-20 Thread Peter Krempa
On 11/20/14 11:24, Daniel P. Berrange wrote: > On Thu, Nov 20, 2014 at 10:56:53AM +0100, Peter Krempa wrote: >> On 11/18/14 18:16, Nehal J Wani wrote: >>> This patch enables the helper program to detect event(s) triggered when >>> there >>> is a change in lease length or expiry and client-id. This

Re: [libvirt] [PATCH v4] leaseshelper: improvements to support all events

2014-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2014 at 10:56:53AM +0100, Peter Krempa wrote: > On 11/18/14 18:16, Nehal J Wani wrote: > > This patch enables the helper program to detect event(s) triggered when > > there > > is a change in lease length or expiry and client-id. This transfers complete > > control of leases databa

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

2014-11-20 Thread Daniel P. Berrange
On Wed, Nov 19, 2014 at 02:42:51PM -0700, Eric Blake wrote: > On 11/17/2014 05:36 PM, Eric Blake wrote: > > Use of an 'int' to represent a 'bool' value is confusing. Just > > because dbus made the mistake of cementing their 4-byte wire > > format of dbus_bool_t into their API doesn't mean we have

Re: [libvirt] [PATCHv2] virsh: Fix msg: blockjob is aborted from another client

2014-11-20 Thread Peter Krempa
On 11/19/14 14:54, Erik Skultety wrote: > When a block{pull, copy, commit} is aborted via keyboard interrupt, > the job is properly canceled followed by proper error message. > However, when the job receives an abort from another client connected > to the same domain, the error message incorrectly

[libvirt] [PATCH] cpu-driver: Fix the cross driver function call

2014-11-20 Thread Daniel Hansel
For Intel and PowerPC the implementation is calling a cpu driver function across driver layers (i.e. from qemu driver directly to cpu driver). The correct behavior is to use libvirt API functionality to perform such a inter-driver call. This patch introduces a new cpu driver API function getModels

Re: [libvirt] [PATCH v4] leaseshelper: improvements to support all events

2014-11-20 Thread Peter Krempa
On 11/18/14 18:16, Nehal J Wani wrote: > This patch enables the helper program to detect event(s) triggered when there > is a change in lease length or expiry and client-id. This transfers complete > control of leases database to libvirt and obsoletes use of the lease database > file (.leases). Tha

Re: [libvirt] [PATCH v4] leaseshelper: improvements to support all events

2014-11-20 Thread Peter Krempa
On 11/18/14 18:16, Nehal J Wani wrote: > This patch enables the helper program to detect event(s) triggered when there > is a change in lease length or expiry and client-id. This transfers complete > control of leases database to libvirt and obsoletes use of the lease database > file (.leases). Tha

Re: [libvirt] [PATCH 06/11] qemu: Add handling for VSERPORT_CHANGE event

2014-11-20 Thread Wang Rui
On 2014/11/20 15:47, Peter Krempa wrote: > the status XML is the piece that is reloaded on libvirtd restart for > running VMs. For inactive VMs this doesn't make sense to report. Thanks. I missed status XML in /var/run/libvirt/. -- libvir-list mailing list libvir-list@redhat.com https://www.redha

  1   2   >