[libvirt] [PATCH] CVE-2014-8131: Fix possible deadlock and segfault in qemuConnectGetAllDomainStats()

2014-12-10 Thread Martin Kletzander
When user doesn't have read access on one of the domains he requested, the for loop could exit abruptly or continue and override pointer which pointed to locked object. This patch fixed two issues at once. One is that domflags might have had QEMU_DOMAIN_STATS_HAVE_JOB even when there was no job

Re: [libvirt] [PATCH v4 00/15] parallels: rewrite driver with parallels SDK

2014-12-10 Thread Dmitry Guryanov
On Tuesday 09 December 2014 19:57:51 Peter Krempa wrote: On 12/01/14 16:38, Dmitry Guryanov wrote: This patch series replaces all code, which used prlctl command to interact with parallels cloud server with calls to parallels sdk functions. The model of this driver remain almost the

Re: [libvirt] [PATCH] docs: Fix missing curly braces

2014-12-10 Thread Ján Tomko
On 12/10/2014 08:25 AM, Hao Liu wrote: Signed-off-by: Hao Liu h...@redhat.com --- HACKING | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) This file is generated from docs/hacking.html.in. You should edit that one instead, regenerate HACKING and include both in the patch. Jan

Re: [libvirt] [PATCH 3/3] libxl: add .domainSendKey

2014-12-10 Thread Daniel P. Berrange
On Tue, Dec 09, 2014 at 11:19:22PM -0700, Chun Yan Liu wrote: On 12/9/2014 at 05:44 PM, in message 2014120909.gb29...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 09, 2014 at 11:27:46AM +0800, Chunyan Liu wrote: libxl supports sysrq. Add .domainSendKey

Re: [libvirt] [PATCH] util: check for an illegal character in a XML namespace prefix

2014-12-10 Thread Erik Skultety
On 12/05/2014 12:57 PM, Michal Privoznik wrote: On 04.12.2014 14:37, Erik Skultety wrote: When user tries to insert element metadata providing a namespace declaration as well, currently we insert the element without any validation check for XML prefix (if provided). The next VM start would

Re: [libvirt] [PATCH] viriscsi: Need to sendtargets on Initiator IQN

2014-12-10 Thread Ján Tomko
On 12/10/2014 01:12 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1172015 The refactoring done as part of commit id '59446096' caused a regression Wow, that was over 4 years ago. for the multi initiator IQN commit '6aabcb5b' because the sendtargets was not done on/for

Re: [libvirt] [PATCH v1 3/3] virconf: Introduce VIR_CONF_ULONG

2014-12-10 Thread Martin Kletzander
On Tue, Dec 09, 2014 at 04:52:16PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1160995 In our config files users are expected to pass several integer values for different configuration knobs. However, majority of them expect a nonnegative number and only a few of

[libvirt] [PATCHv3] lxc: give RW access to /proc/sys/net/ipv[46] to containers

2014-12-10 Thread Cédric Bosdonnat
Some programs want to change some values for the network interfaces configuration in /proc/sys/net/ipv[46] folders. Giving RW access on them allows wicked to work on openSUSE 13.2+. Reusing the lxcNeedNetworkNamespace function to tell lxcContainerMountBasicFS if the netns is disabled. When no

Re: [libvirt] [PATCH] viriscsi: Need to sendtargets on Initiator IQN

2014-12-10 Thread Ján Tomko
On 12/10/2014 10:34 AM, Ján Tomko wrote: On 12/10/2014 01:12 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1172015 The refactoring done as part of commit id '59446096' caused a regression Wow, that was over 4 years ago. It's not even documented on the storage pool

[libvirt] [PATCH] maint: clean up the unused variable 'caps' in src/qemu/qemu_*.c

2014-12-10 Thread Wang Rui
Signed-off-by: Wang Rui moon.wang...@huawei.com --- src/qemu/qemu_driver.c | 9 - src/qemu/qemu_hotplug.c | 5 - 2 files changed, 14 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index be37c8f..3406385 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH v2] docs: Fix missing curly braces

2014-12-10 Thread Hao Liu
Signed-off-by: Hao Liu h...@redhat.com --- docs/hacking.html.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index a73b1e0..53786b7 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -481,8 +481,9 @@ pre while

[libvirt] [PATCH] conf: Ignore device address for guestfwd channel

2014-12-10 Thread Martin Kletzander
It make no sense at all to have it there. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/conf/domain_conf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index db3369e..ec45b8c 100644 ---

Re: [libvirt] [PATCH] maint: clean up the unused variable 'caps' in src/qemu/qemu_*.c

2014-12-10 Thread Martin Kletzander
On Wed, Dec 10, 2014 at 05:45:33PM +0800, Wang Rui wrote: Signed-off-by: Wang Rui moon.wang...@huawei.com --- src/qemu/qemu_driver.c | 9 - src/qemu/qemu_hotplug.c | 5 - 2 files changed, 14 deletions(-) At least we unref'd it everywhere ;-) ACK will push in a while. Martin

Re: [libvirt] [PATCH] conf: Ignore device address for guestfwd channel

2014-12-10 Thread Michal Privoznik
On 10.12.2014 10:58, Martin Kletzander wrote: It make no sense at all to have it there. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/conf/domain_conf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH v2] docs: Fix missing curly braces

2014-12-10 Thread Martin Kletzander
On Wed, Dec 10, 2014 at 05:44:48PM +0800, Hao Liu wrote: Signed-off-by: Hao Liu h...@redhat.com --- docs/hacking.html.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) You need to regenerate HACKING from that and add it to the patch. I did that for you this time, so ACK and I'll push

Re: [libvirt] [PATCH v2] storage: Check stderr when matching parted output

2014-12-10 Thread Martin Kletzander
On Wed, Dec 10, 2014 at 03:14:26PM +0800, Hao Liu wrote: In old version of parted like parted-2.1-25, error message is shown in stdout when printing a disk info without disk label. Error: /dev/sda: unrecognised disk label This line has been moved to stderr in newer version of parted. So we

Re: [libvirt] [PATCHv3] lxc: give RW access to /proc/sys/net/ipv[46] to containers

2014-12-10 Thread Michal Privoznik
On 10.12.2014 10:40, Cédric Bosdonnat wrote: Some programs want to change some values for the network interfaces configuration in /proc/sys/net/ipv[46] folders. Giving RW access on them allows wicked to work on openSUSE 13.2+. Reusing the lxcNeedNetworkNamespace function to tell

[libvirt] How to use blockcopy in libvirt-java

2014-12-10 Thread Star Guo
Hi, ALL, I just look for the class and method to use blockcopy in libvirt-java on this page: http://libvirt.org/sources/java/javadoc/ However, I can not find out. Libvirt-java Support blockcopy ? Thanks. Best Regards, Star Guo -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] docs: Fix typo in path for storage pool

2014-12-10 Thread John Ferlan
Signed-off-by: John Ferlan jfer...@redhat.com --- Pushed as trivial docs/formatstorage.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 0951daa..933268c 100644 --- a/docs/formatstorage.html.in +++

[libvirt] [PATCH] virsh: Emit error for VSH_OT_DATA without VSH_OFLAG_REQ

2014-12-10 Thread Hao Liu
Commit 6b9964 enforces checking invalid use of VSH_OT_STRING with VSH_OFLAG_REQ. This commit tries to do the same thing to stop using VSH_OT_DATA without VSH_OFLAG_REQ and also fix existing misuse. Signed-off-by: Hao Liu h...@redhat.com --- tools/virsh-domain-monitor.c | 2 +-

Re: [libvirt] [PATCH] viriscsi: Need to sendtargets on Initiator IQN

2014-12-10 Thread John Ferlan
On 12/10/2014 04:45 AM, Ján Tomko wrote: On 12/10/2014 10:34 AM, Ján Tomko wrote: On 12/10/2014 01:12 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1172015 The refactoring done as part of commit id '59446096' caused a regression Wow, that was over 4 years ago.

[libvirt] [PATCH] qemu: bulk stats: add pcpu placement information

2014-12-10 Thread Francesco Romani
This patch adds the information about the physical cpu placement of virtual cpus for bulk stats. This is the only difference in output with the virDomainGetVcpus() API. Management software, like oVirt, needs this information to properly manage NUMA configurations. Signed-off-by: Francesco Romani

Re: [libvirt] should we use new Linux syscall getrandom(2)?

2014-12-10 Thread Daniel P. Berrange
On Tue, Dec 09, 2014 at 12:57:25PM -0700, Eric Blake wrote: On 12/09/2014 09:49 AM, Daniel P. Berrange wrote: The question is how should we make use of it ? Should we use it as the seed for initstate_r, or just use it for virRandomBits directly ? Well, consider that libvirt might be

[libvirt] [PATCH] storage: unify permission formatting

2014-12-10 Thread Martin Kletzander
Volume and pool formatting functions took different approaches to unspecified uids/gids. When unknown, it is always parsed as -1, but one of the functions formatted it as unsigned int (wrong) and one as int (better). Due to that, our two of our XML files from tests cannot be parsed on 32-bit

Re: [libvirt] [PATCH v4] automatic create tap device with network type ethernet

2014-12-10 Thread Vasiliy Tolstov
2014-12-09 17:06 GMT+03:00 Eric Blake ebl...@redhat.com: or shorter, -v5 Thanks. Does i need to resend latest patch ? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/3] parallels: set format for real disk devices

2014-12-10 Thread Dmitry Guryanov
It seems file format is usually specified event for real block devices. So report that file format is raw in virDomainGetXMLDesc and add checks for proper file format to prlsdkAddDisk. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_sdk.c | 10 ++ 1

[libvirt] [PATCH 3/3] parallels: use disk name to set disk index

2014-12-10 Thread Dmitry Guryanov
Use guest disk name to determine disk position on bus, because Openstack/nova don't set virDomainDeviceInfo. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_sdk.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH] virsh.pod: Fix typo

2014-12-10 Thread John Ferlan
Commit id 'c9ffd3ea9e' updated the descriptions, but pointed at the wrong place for the pool-define-as (it should have been pool-create-as) Signed-off-by: John Ferlan jfer...@redhat.com --- Pushed as trivial tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr

2014-12-10 Thread Dmitry Guryanov
I support if virDomainVideoAccelDefPtr is NULL it means default values for video acceleration. So we don't need to report error. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 0/3] parallels: a set of fixes for nova

2014-12-10 Thread Dmitry Guryanov
Hello, This 3 patches fix different things, used by nova. Dmitry Guryanov (3): parallels: support NULL virDomainVideoAccelDefPtr parallels: set format for real disk devices parallels: use disk name to set disk index src/parallels/parallels_sdk.c | 22 -- 1 file

[libvirt] [PATCH] Avoid getting '-1:-1' in devices cgroup list

2014-12-10 Thread Cédric Bosdonnat
When calling virCgroupAllowAllDevices we get these invalid entries in the device cgroup config. b -1:-1 rw c -1:-1 rw Check for positive values before outputting the major and minor to avoid that. --- src/util/vircgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH] Add rlimits to lxc

2014-12-10 Thread Michal Privoznik
On 07.12.2014 04:17, Ryan Cleere wrote: --- src/conf/domain_conf.c | 115 +++ src/conf/domain_conf.h | 12 + src/lxc/lxc_controller.c | 12 + src/util/virprocess.c| 4 +- src/util/virprocess.h| 3 ++ 5 files

Re: [libvirt] [PATCH v4] automatic create tap device with network type ethernet

2014-12-10 Thread Michal Privoznik
On 10.12.2014 14:12, Vasiliy Tolstov wrote: 2014-12-09 17:06 GMT+03:00 Eric Blake ebl...@redhat.com: or shorter, -v5 Thanks. Does i need to resend latest patch ? Yes, please. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v5] automatic create tap device with network type ethernet

2014-12-10 Thread Vasiliy Tolstov
If user not specify network type ethernet, assume that user needs simple tap device created with libvirt. This patch does not need to run external script to create tap device or add root to qemu process. Also libvirt runs script after device creating, if user provide it. Signed-off-by: Vasiliy

Re: [libvirt] [PATCHv3 0/2] Fix snapshot-revert and managedsave with host-passthrough CPU mode

2014-12-10 Thread Michal Privoznik
On 05.12.2014 14:19, Ján Tomko wrote: v1: https://www.redhat.com/archives/libvir-list/2014-October/msg01120.html v2: https://www.redhat.com/archives/libvir-list/2014-November/msg00218.html v3: * do not format the features at all, instead of adding a model to them Ján Tomko (2): Do not

Re: [libvirt] [PATCH] qemu: bulk stats: add pcpu placement information

2014-12-10 Thread Eric Blake
On 12/10/2014 05:39 AM, Francesco Romani wrote: This patch adds the information about the physical cpu placement of virtual cpus for bulk stats. This is the only difference in output with the virDomainGetVcpus() API. Management software, like oVirt, needs this information to properly

Re: [libvirt] [PATCH] CVE-2014-8131: Fix possible deadlock and segfault in qemuConnectGetAllDomainStats()

2014-12-10 Thread Eric Blake
On 12/10/2014 01:25 AM, Martin Kletzander wrote: When user doesn't have read access on one of the domains he requested, the for loop could exit abruptly or continue and override pointer which pointed to locked object. This patch fixed two issues at once. One is that domflags might have had

Re: [libvirt] [PATCH] storage: unify permission formatting

2014-12-10 Thread Eric Blake
On 12/10/2014 06:00 AM, Martin Kletzander wrote: Volume and pool formatting functions took different approaches to unspecified uids/gids. When unknown, it is always parsed as -1, but one of the functions formatted it as unsigned int (wrong) and one as int (better). Due to that, our two of

Re: [libvirt] [PATCH v3] network: Bring netdevs online later

2014-12-10 Thread Laine Stump
On 09/16/2014 04:50 PM, Matthew Rosato wrote: Currently, MAC registration occurs during device creation, which is early enough that, during live migration, you end up with duplicate MAC addresses on still-running source and target devices, even though the target device isn't actually being

Re: [libvirt] [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr

2014-12-10 Thread Maxim Nestratov
Looks OK Best, Maxim Nestratov От: Dmitry Guryanovmailto:dgurya...@parallels.com Отправлено: ‎10.‎12.‎2014 17:30 Кому: libvir-list@redhat.commailto:libvir-list@redhat.com Копия: Alexander Burlukamailto:mipt-aburl...@parallels.com; Maxim

Re: [libvirt] [PATCH 3/3] parallels: use disk name to set disk index

2014-12-10 Thread Maxim Nestratov
Looks ok to me Best, Maxim Nestratov От: Dmitry Guryanovmailto:dgurya...@parallels.com Отправлено: ‎10.‎12.‎2014 17:30 Кому: libvir-list@redhat.commailto:libvir-list@redhat.com Копия: Alexander Burlukamailto:mipt-aburl...@parallels.com; Maxim

Re: [libvirt] [PATCH 3/3] libxl: add .domainSendKey

2014-12-10 Thread Chun Yan Liu
On 12/10/2014 at 05:21 PM, in message 20141210092125.gb6...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 09, 2014 at 11:19:22PM -0700, Chun Yan Liu wrote: On 12/9/2014 at 05:44 PM, in message 2014120909.gb29...@redhat.com, Daniel P. Berrange

Re: [libvirt] [virt-tools-list] [PATCH] virtinst: refresh pools status before fetch_pools

2014-12-10 Thread Chun Yan Liu
On 12/5/2014 at 09:54 PM, in message 5481b907.4040...@redhat.com, Cole Robinson crobi...@redhat.com wrote: On 12/05/2014 03:40 AM, Chunyan Liu wrote: Currently, when connecting to hypervisor, if there are pools active but in fact target path already deleted (or for other reasons the

[libvirt] [PATCH v2] virsh: Emit error for VSH_OT_DATA without VSH_OFLAG_REQ

2014-12-10 Thread Hao Liu
Commit 6b9964 enforces checking invalid use of VSH_OT_STRING with VSH_OFLAG_REQ. This commit tries to do the same thing to stop using VSH_OT_DATA without VSH_OFLAG_REQ and also fix existing misuse. Signed-off-by: Hao Liu h...@redhat.com --- V2: Add missing fix of dommemstat --period option.

[libvirt] Candidate Release 2 for libvirt-1.2.11 available

2014-12-10 Thread Daniel Veillard
I have tagged the CR2 in git and pushed signed tarballs and rpms to the usual place: ftp://libvirt.org/libvirt/ this looks fine to me, but my testing is limited and it would be good to get some portability reports for example. If nothing serious is pointed out, I would expect the final

[libvirt] How to use blockcopy in libvirt-java

2014-12-10 Thread Star Guo
Hi, ALL, I just find the page on git: https://github.com/qemu/qemu/blob/master/docs/live-block-ops.txt This metion “Live block copy”, so Live Block Copy is the feature of live-block-ops. And what about the live-block-migration ? Best Regards, Star Guo 发件人: Star Guo

[libvirt] libvirt issues in Fedora 21

2014-12-10 Thread snaper
Sorry if its not the right place to post. Fedora 21 user here and I've run into two problems that were not there in Fedora 20. First enabling hugepages causes a machine to refuse to boot. It gives errors saying Error starting domain: Unable to read from monitor: Connection reset by peer

Re: [libvirt] [PATCH] qemu: bulk stats: add pcpu placement information

2014-12-10 Thread Francesco Romani
- Original Message - From: Eric Blake ebl...@redhat.com To: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Wednesday, December 10, 2014 6:16:07 PM Subject: Re: [libvirt] [PATCH] qemu: bulk stats: add pcpu placement information +++ b/src/libvirt-domain.c @@

[libvirt] [PATCH v2] qemu: bulk stats: add pcpu placement information

2014-12-10 Thread Francesco Romani
This patch adds the information about the physical cpu placement of virtual cpus for bulk stats. This is the only difference in output with the virDomainGetVcpus() API. Management software, like oVirt, needs this information to properly manage NUMA configurations. Signed-off-by: Francesco Romani

[libvirt] [PATCH] qemu: bulk stats: typo in monitor handling

2014-12-10 Thread Francesco Romani
A typo in qemuConnectGetAllDomainStats makes the code mark the monitor as available when qemuDomainObjBeginJob fails, instead of when it succeeds, as the correct flow requires. This patch fixes the check and updates the code documentation accordingly. Signed-off-by: Francesco Romani