Re: [libvirt] [python PATCH] Implement the DEVICE_ADDED event

2015-04-13 Thread John Ferlan
On 04/04/2015 01:17 PM, Ján Tomko wrote: --- examples/event-test.py | 4 +++ libvirt-override-virConnect.py | 9 +++ libvirt-override.c | 57 ++ 3 files changed, 70 insertions(+) ACK - as it seems you've done the correct

Re: [libvirt] [PATCH 4/9] storage: Create matchPoolSourceHost

2015-04-13 Thread John Ferlan
On 04/13/2015 06:18 AM, Peter Krempa wrote: On Thu, Apr 02, 2015 at 13:39:41 -0400, John Ferlan wrote: Split out the nhost == 1 and hosts[0].name logic into a separate routine Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 17 - 1 file

Re: [libvirt] [PATCH] configure: Check for libxl_utils.h instead of libxlutil.h

2015-04-13 Thread Jim Fehlig
Michal Privoznik wrote: The file provided by xen-devel package (or xen-tools in Gentoo) does not provide libxlutil.h. Until recently [1], libxlutil.h was not installed. In fact the package provides libxl_utils.h instead which is the one we are looking for anyway. We are looking for

Re: [libvirt] [PATCH 2/2] Emit VIR_DOMAIN_EVENT_ID_DEVICE_ADDED in the QEMU driver

2015-04-13 Thread John Ferlan
On 04/04/2015 01:16 PM, Ján Tomko wrote: Only for devices that have an alias. --- src/qemu/qemu_driver.c | 17 - src/qemu/qemu_hotplug.c | 5 + 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH 1/2] Add VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event

2015-04-13 Thread John Ferlan
On 04/04/2015 01:16 PM, Ján Tomko wrote: The counterpart to VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED. https://bugzilla.redhat.com/show_bug.cgi?id=1206114 --- daemon/remote.c | 37 +++ include/libvirt/libvirt-domain.h | 18 ++ src/conf/domain_event.c

Re: [libvirt] [PATCH 1/9] storage: Refactor iSCSI Source matching

2015-04-13 Thread John Ferlan
On 04/13/2015 05:27 AM, Peter Krempa wrote: On Thu, Apr 02, 2015 at 13:39:38 -0400, John Ferlan wrote: Create a separate iSCSI Source matching subroutine. Makes the calling code a bit cleaner as well as sets up for future patches which need to do better source hosts[0].name

[libvirt] [PATCH] qemu: set macvtap physdevs online when macvtap is set online

2015-04-13 Thread Laine Stump
A further fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1113474 Since there is no possibility that any type of macvtap will work if the parent physdev it's attached to is offline, we should bring the physdev online at the same time as the macvtap. When taking the macvtap offline, it's

Re: [libvirt] [PATCH v2 2/9] Convert virDomainPinIsDuplicate into bool return

2015-04-13 Thread John Ferlan
On 04/13/2015 06:33 AM, Peter Krempa wrote: On Fri, Apr 10, 2015 at 17:36:20 -0400, John Ferlan wrote: Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 8 src/conf/domain_conf.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) ACK, by the

Re: [libvirt] [PATCH 7/9] storage: Add duplicate host check for Sheepdog pool def

2015-04-13 Thread John Ferlan
On 04/13/2015 06:23 AM, Peter Krempa wrote: On Thu, Apr 02, 2015 at 13:39:44 -0400, John Ferlan wrote: Check proposed pool definitions to ensure they aren't trying to use the same host as currently defined definitions - disallow the duplicate This statement is invalid. Multiple pols can be

[libvirt] [PATCH v2 0/8] Duplicate storage pool source refactoring and checks

2015-04-13 Thread John Ferlan
v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg00141.html Changes: Patches 1-3 are refactored into just 1 patch now Patch 2 is the old patch 4 and renames the function as requested and removes the comment Patch 3 is new - it adds a check for different port #'s to the new

[libvirt] [PATCH v2 1/8] storage: Refactor iSCSI Source matching

2015-04-13 Thread John Ferlan
Create a separate iSCSI Source matching subroutine. Makes the calling code a bit cleaner as well as sets up for future patches which need to do better source hosts[0].name processing/checking. As part of the effort the logic will be inverted from a multi-level if statement to a series of single

[libvirt] [PATCH v2 6/8] storage: Add duplicate host check for Sheepdog pool def

2015-04-13 Thread John Ferlan
Check the proposed pool source host XML definition against existing sheepdog pools to ensure the incoming definition doesn't use the same source host XML definition as an existing pool. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 6 +- 1 file changed, 5

[libvirt] [PATCH v2 7/8] storage: Add duplicate host check for Gluster pool def

2015-04-13 Thread John Ferlan
Check the proposed pool source host XML definition against existing gluster pools to ensure the incoming definition doesn't use the same source host XML definition as an existing pool. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 2 +- 1 file changed, 1

[libvirt] [PATCH v2 8/8] storage: Add duplicate devices check for zfs pool def

2015-04-13 Thread John Ferlan
Check proposed pool definitions to ensure they aren't trying to use the same devices as currently defined definitions - disallow the duplicate Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 2/8] storage: Create virStoragePoolSourceMatchSingleHost

2015-04-13 Thread John Ferlan
Split out the nhost == 1 and hosts[0].name logic into a separate routine Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index

[libvirt] [PATCH v2 3/8] storage: Add check for different ports for host duplicate matching

2015-04-13 Thread John Ferlan
In virStoragePoolSourceMatchSingleHost, add a comparison for port number being different prior to checking the 'name' field. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/storage_conf.c

[libvirt] [PATCH v2 4/8] storage: Use virStoragePoolSourceMatchSingleHost for NETFS

2015-04-13 Thread John Ferlan
Rather than have duplicate code doing the same check, have the netfs matching processing code use the new virStoragePoolSourceMatchSingleHost. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH v2 5/8] storage: Remove default from switch in virStoragePoolSourceFindDuplicate

2015-04-13 Thread John Ferlan
So that we can cover all the cases. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index bb89bb7..1fadff4 100644 --- a/src/conf/storage_conf.c

Re: [libvirt] [PATCH 5/9] storage: Use matchPoolSourceHost for NETFS

2015-04-13 Thread John Ferlan
On 04/13/2015 06:19 AM, Peter Krempa wrote: On Thu, Apr 02, 2015 at 13:39:42 -0400, John Ferlan wrote: Rather than have duplicate code doing the same check, have the netfs matching processing code use the new matchPoolSourceHost. Signed-off-by: John Ferlan jfer...@redhat.com ---

Re: [libvirt] [PATCH 5/5] qemu: Fix condition for checking vcpu when pinning vcpus

2015-04-13 Thread John Ferlan
On 04/07/2015 02:50 PM, Peter Krempa wrote: Previously we checked that the vcpu we are trying to set is in range of the number of threads presented by qemu. The problem is that if the VM is offline the count is 0. Since the condition subtracted 1 from the count the number would overflow and

Re: [libvirt] [PATCH] lib: snapshot: Explain that only one layer of images is inserted

2015-04-13 Thread John Ferlan
On 04/10/2015 04:55 AM, Peter Krempa wrote: When creating a snapshot with _REUSE_EXTERNAL when the pre-created image does not directly link to the current active layer libvirt would re-detect the backing chain incorrectly and it would not match with qemu's view. Since the configuration is an

Re: [libvirt] [PATCH v2 3/9] conf: Add new domain XML element 'iothreadids'

2015-04-13 Thread John Ferlan
On 04/13/2015 08:13 AM, Peter Krempa wrote: On Fri, Apr 10, 2015 at 17:36:21 -0400, John Ferlan wrote: ... diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 95cbb9c..03a0ecd 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2041,6 +2041,19 @@ struct

Re: [libvirt] [PATCH 1/5] conf: Split out parsing of emulatorpin

2015-04-13 Thread John Ferlan
On 04/07/2015 02:50 PM, Peter Krempa wrote: Split up parts of virDomainVcpuPinDefParseXML into virDomainEmulatorPinDefParseXML. --- src/conf/domain_conf.c | 50 +- 1 file changed, 37 insertions(+), 13 deletions(-) ACK John --

Re: [libvirt] [PATCH 2/5] conf: Split up virDomainVcpuPinDefParseXML

2015-04-13 Thread John Ferlan
On 04/07/2015 02:50 PM, Peter Krempa wrote: Extract part that parses iothreads into virDomainIothreadPinDefParseXML --- src/conf/domain_conf.c | 112 + 1 file changed, 66 insertions(+), 46 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 3/5] conf: Error out if iothread id is missing in iothreadpin

2015-04-13 Thread John Ferlan
On 04/07/2015 02:50 PM, Peter Krempa wrote: Defining a domain with the following config: domain ... ... iothreads1/iothreads cputune iothreadpin cpuset='1'/ will result in the following config formatted back: domain type='kvm' ... iothreads1/iothreads cputune

Re: [libvirt] [PATCH 4/5] conf: Refactor virDomainVcpuPinDefParseXML

2015-04-13 Thread John Ferlan
On 04/07/2015 02:50 PM, Peter Krempa wrote: Refactor the code to parse the vcpupin in a similar way the iothreadpin code is now structured. This allows to get rid of some very strange conditions and error messages. Additionally since a existing bug (

Re: [libvirt] [PATCHv3 7/7] qemu: Refactor qemuDomainBlockJobAbort()

2015-04-13 Thread John Ferlan
On 04/09/2015 12:45 PM, Peter Krempa wrote: Change few variable names and refactor the code flow. As an additional bonus the function now fails if the event state is not as expected. --- Notes: Version 3: - fixed error reporting code and success code propagation from pivot

Re: [libvirt] [PATCH 3/3] Rewrite usb device version parsing

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 16:28:24 +0200, Ján Tomko wrote: Simplify the function by leaving out the local copy and checking return values of virStrToLong. --- src/conf/domain_conf.c | 66 +++--- 1 file changed, 20 insertions(+), 46 deletions(-)

Re: [libvirt] [PATCH v2 3/3] qemuMigrationPrecreateDisk: Preserve sparse files

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:25:41 +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=817700 This patch certainly does not resolve this bug. See below ... When pre-creating a disk on the destination, a volume XML is constructed. The XML is then passed to

Re: [libvirt] [PATCHv1 13/13] Add qcow2 features to snapshot XML

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:59:05 +0200, Ján Tomko wrote: This allows creating an external qcow2 snapshot with qcow2 features, e.g: disk name='hda' snapshot='external' type='file' source file='/path/to/file'/ compat1.1/compat features lazy_refcounts/ /features /disk

Re: [libvirt] [PATCHv1 12/13] Rework qemu-img command generation for inactive external snapshots

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:59:04 +0200, Ján Tomko wrote: Reuse the code from storage backend. This also fixes the backing_fmd typo by removing it. --- src/qemu/qemu_driver.c| 46 ++- src/storage/storage_backend.c | 2 +- 2 files changed,

Re: [libvirt] [PATCH 1/2] Rewrite vshPrintPinInfo

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 16:32:32 +0200, Ján Tomko wrote: Use virBitmapDataToString instead of constructing the ranges bit by bit, remove the checking of parameters (that is already done by the callers). Let the callers choose the right bitmap, since there's only one that uses this helper on

Re: [libvirt] [PATCH 2/3] Fix usb device version parsing issues

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 16:28:23 +0200, Ján Tomko wrote: Request that the number be parsed as decimal, to allow 08 and 09. Format it with the leading zero, 1.01 and 1.10 are two different versions. https://bugzilla.redhat.com/show_bug.cgi?id=1210650 --- src/conf/domain_conf.c

Re: [libvirt] luajit binding

2015-04-13 Thread Christophe Fergeau
Hey, On Fri, Apr 10, 2015 at 05:01:55AM +, William Adams wrote: I have started a luajit language binding for libvirt. It can be found here: I don't know how well https://github.com/pavouk/lgi/ works, but one alternative to writing lua bindings for libvirt would be to try to use

Re: [libvirt] [libvirt-glib] Support setting of compat XML node

2015-04-13 Thread Richa Sehgal
Thanks a lot Christophe! Regards Richa On Mon, Apr 13, 2015 at 2:20 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey Richa, On Sun, Apr 12, 2015 at 03:11:41PM -0700, Richa Sehgal wrote: This change adds support for setting of compat XML node in libvirt gconfig storage volumes target

Re: [libvirt] [PATCHv1 09/13] Split out qemu-img command generation

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:59:01 +0200, Ján Tomko wrote: Do not require the volume definition. This will allow code reuse when creating snapshots. --- src/storage/storage_backend.c | 203 +++--- 1 file changed, 109 insertions(+), 94 deletions(-) diff

Re: [libvirt] [PATCH] conf: Don't output cpu tag if it contains no information.

2015-04-13 Thread Erik Skultety
On 04/10/2015 03:09 PM, Andrea Bolognani wrote: The tag is already marked as optional in the schema, so no changes are needed there. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1202606 --- Hi everyone, this is my first contribution to libvirt so I wholeheartedly welcome any

Re: [libvirt] [PATCH v2 1/3] qemuMigrationPrecreateStorage: Fix debug message

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:25:39 +0200, Michal Privoznik wrote: When pre-creating storage for domains, we need to find corresponding disk in the XML on the destination (domain XML may differ there, e.g. disk is accessible under different path). For better debugging, I'm printing all info I

Re: [libvirt] [PATCH] conf: Don't output cpu tag if it contains no information.

2015-04-13 Thread Andrea Bolognani
On Mon, 2015-04-13 at 09:39 +0200, Erik Skultety wrote: Other than that, it looks good, so I removed the comments marked above and pushed. Congratulations to your first patch in libvirt ;). Thank you for reviewing and pushing the patch! Have a nice day. -- Andrea Bolognani

[libvirt] [libvirt-glib] gconfig: Fix small leak in test-domain-create

2015-04-13 Thread Christophe Fergeau
The object returned by gvir_config_domain_disk_get_driver() must be unref'ed when no longer used. --- libvirt-gconfig/tests/test-domain-create.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index

Re: [libvirt] [libvirt-glib] Support setting of compat XML node

2015-04-13 Thread Christophe Fergeau
Hey Richa, On Sun, Apr 12, 2015 at 03:11:41PM -0700, Richa Sehgal wrote: This change adds support for setting of compat XML node in libvirt gconfig storage volumes target Looks good to me, I've now pushed it with a slightly reworked commit message:

Re: [libvirt] [PATCHv1 08/13] Introduce struct _virStorageBackendQemuImgInfo

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:59:00 +0200, Ján Tomko wrote: This will contain the data required for creating the qemu-img command line without having access to the volume definition. --- src/storage/storage_backend.c | 165 ++ 1 file changed, 86

Re: [libvirt] [PATCH 2/2] Rewrite vshParseCPUList

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 16:32:33 +0200, Ján Tomko wrote: Use virBitmap helpers that were added after this function. Change cpumaplen to int and fill it out by this function. --- tools/virsh-domain.c | 112 +-- 1 file changed, 19

Re: [libvirt] [PATCH 1/3] Do xml-xml test for usb-redir-filter

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 16:28:22 +0200, Ján Tomko wrote: We don't format the default '-1' fields back. --- .../qemuxml2xmlout-usb-redir-filter.xml| 45 ++ tests/qemuxml2xmltest.c| 1 + 2 files changed, 46 insertions(+) create

Re: [libvirt] An implementation bug in qemuMigrationWaitForCompletion that introduces an unnecessary sleep of 50 ms when a migration completes

2015-04-13 Thread Michal Privoznik
On 10.04.2015 09:49, Michal Privoznik wrote: On 10.04.2015 00:32, Xing Lin wrote: snip/ Yeah, I guess it's very unlikely that migration will complete within first 50ms after issuing the command on the monitor (in which case we would again wait pointlessly). The other approach would be to

Re: [libvirt] [PATCH 1/9] storage: Refactor iSCSI Source matching

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:38 -0400, John Ferlan wrote: Create a separate iSCSI Source matching subroutine. Makes the calling code a bit cleaner as well as sets up for future patches which need to do better source hosts[0].name processing/checking Signed-off-by: John Ferlan

Re: [libvirt] [PATCHv1 07/13] Rename virStorageBackendCreateQemuImgCmd

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:58:59 +0200, Ján Tomko wrote: Add FromVol at the end. This function will create the qemu-img command line from volume definitions and check them. --- src/storage/storage_backend.c | 21 - src/storage/storage_backend.h | 14 +++---

Re: [libvirt] [PATCHv1 11/13] Use qemu-img to precreate the qcow2 disks

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 14:59:03 +0200, Ján Tomko wrote: The blockdev-snapshot-sync command only takes a format but does not allow specifying the compat level or other features that should be used. Pre-create the qcow2 file ourselves and tell qemu to reuse it. Note: the default compat

Re: [libvirt] [PATCH 6/9] storage: Remove default from switch in virStoragePoolSourceFindDuplicate

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:43 -0400, John Ferlan wrote: So that we can cover all the cases. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) ACK, Peter signature.asc Description: Digital

Re: [libvirt] [PATCH 9/9] storage: Add duplicate devices check for zfs pool def

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:46 -0400, John Ferlan wrote: Check proposed pool definitions to ensure they aren't trying to use the same devices as currently defined definitions - disallow the duplicate Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 2 +- 1

Re: [libvirt] [PATCH v2 3/9] conf: Add new domain XML element 'iothreadids'

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:21 -0400, John Ferlan wrote: Adding a new XML element 'iothreadids' in order to allow defining specific IOThread ID's rather than relying on the algorithm to assign IOThread ID's starting at 1 and incrementing to iothreads count. This will allow future patches

Re: [libvirt] [PATCH 3/9] storage: Invert logic for matchISCSISource

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:40 -0400, John Ferlan wrote: Invert the logic for better readability/flow and futher separation Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff

Re: [libvirt] [PATCH v2 1/9] Rename qemuCheckIothreads to qemuCheckIOThreads

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:19 -0400, John Ferlan wrote: Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK, Peter signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH 4/9] storage: Create matchPoolSourceHost

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:41 -0400, John Ferlan wrote: Split out the nhost == 1 and hosts[0].name logic into a separate routine Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff

Re: [libvirt] [PATCH 5/9] storage: Use matchPoolSourceHost for NETFS

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:42 -0400, John Ferlan wrote: Rather than have duplicate code doing the same check, have the netfs matching processing code use the new matchPoolSourceHost. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 5 ++--- 1 file changed, 2

Re: [libvirt] [PATCH v2 2/9] Convert virDomainPinIsDuplicate into bool return

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:20 -0400, John Ferlan wrote: Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 8 src/conf/domain_conf.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) ACK, by the way, the function is exported, but is used only

Re: [libvirt] [PATCH 7/9] storage: Add duplicate host check for Sheepdog pool def

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:44 -0400, John Ferlan wrote: Check proposed pool definitions to ensure they aren't trying to use the same host as currently defined definitions - disallow the duplicate This statement is invalid. Multiple pols can be hosted on a single host. The check needs to do

Re: [libvirt] [PATCH 8/9] storage: Add duplicate host check for Gluster pool def

2015-04-13 Thread Peter Krempa
On Thu, Apr 02, 2015 at 13:39:45 -0400, John Ferlan wrote: Check proposed pool definitions to ensure they aren't trying to use the same host as currently defined definitions - disallow the duplicate Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/storage_conf.c | 2 +- 1 file

[libvirt] [PATCHv2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

2015-04-13 Thread Erik Skultety
This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed. Also, it partially reverts commit 983f5a which added a check for invalid nodeset 0,^0 into virBitmapParse function. This change

Re: [libvirt] [PATCH 1/2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

2015-04-13 Thread Erik Skultety
On 04/13/2015 07:10 AM, Peter Krempa wrote: On Fri, Apr 10, 2015 at 12:41:12 +0200, Erik Skultety wrote: This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed.

Re: [libvirt] [PATCH v2 4/9] qemu: Convert iothreadpids into an array of structures

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:22 -0400, John Ferlan wrote: Create qemuDomainIOThreadInfo which currently will just be the thread_id returned from IOThreadInfo, but will soon expand to handle the needs of live IOThread data for adding/deleting IOThread's As I've said in previous patch the data

Re: [libvirt] [PATCHv1 10/13] Remove overengineered loop

2015-04-13 Thread Ján Tomko
On Mon, Apr 13, 2015 at 07:51:22AM +0200, Peter Krempa wrote: On Fri, Apr 10, 2015 at 14:59:02 +0200, Ján Tomko wrote: Do not loop over enum with one value. --- src/storage/storage_backend.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) ACK.

[libvirt] [PATCH 0/5] Tiny miscellaneous clean-ups

2015-04-13 Thread Martin Kletzander
Just a few things I stumbled upon that are needed for future work. Martin Kletzander (5): configure: Align messages Link libvirt_util with datatypes closeCallback is already lockable, initialize it as such Change virConnectPtr into virObjectLocklable json: export non-static functions

[libvirt] [PATCH 4/5] Change virConnectPtr into virObjectLocklable

2015-04-13 Thread Martin Kletzander
It already had a virMutex inside, so this is just a cleanup. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/datatypes.c | 12 ++-- src/datatypes.h | 12 +--- src/libvirt-host.c | 18 +- src/util/virerror.c | 18 +- 4 files

Re: [libvirt] [PATCHv2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

2015-04-13 Thread Peter Krempa
On Mon, Apr 13, 2015 at 14:01:27 +0200, Erik Skultety wrote: This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed. Also, it partially reverts commit 983f5a which added a check for

Re: [libvirt] [PATCH v2 7/9] remote: Add support for AddIOThread and DelIOThread

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:25 -0400, John Ferlan wrote: Add remote support for the add/delete IOThread API's Signed-off-by: John Ferlan jfer...@redhat.com --- src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 31 ++-

Re: [libvirt] [PATCH v2 8/9] qemu: Add support to Add/Delete IOThreads

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:26 -0400, John Ferlan wrote: Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or remove an IOThread to/from the host either for live or config optoins The implementation for the 'live' option will use the iothreadpids list in order to make

[libvirt] Changing media on network disks (was Re: can't bot from scsi http cdrom)

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 14:34, Vasiliy Tolstov wrote: Thanks! This is works fine. Last question - does it possible to create empty cdrom with type='network'? I'm try this, but libvrit complains with error: disk type='network' device='cdrom' driver name='qemu' type='raw'/

[libvirt] [PATCH 2/5] Link libvirt_util with datatypes

2015-04-13 Thread Martin Kletzander
We were lucky enough for this to work because the datatypes files were linked to in the resulting binary, but the dependency really is already in libvirt_util. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[libvirt] [PATCH] sparc: Add default PCI root controller

2015-04-13 Thread Martin Kletzander
It is there even with -nodefaults and -no-user-config, so count with that so we can start sparc domains. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_domain.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH] schema: Allow multiple machines for sparc VMs

2015-04-13 Thread Martin Kletzander
Use the same pattern as there is for x86 machines. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/schemas/domaincommon.rng | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 03fd541..80b30df

Re: [libvirt] [PATCH] schema: Allow multiple machines for sparc VMs

2015-04-13 Thread Daniel P. Berrange
On Mon, Apr 13, 2015 at 04:14:53PM +0200, Martin Kletzander wrote: Use the same pattern as there is for x86 machines. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/schemas/domaincommon.rng | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/5] configure: Align messages

2015-04-13 Thread Martin Kletzander
The first two were a bit off. Signed-off-by: Martin Kletzander mklet...@redhat.com --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 38fbbad..aed0934 100644 --- a/configure.ac +++ b/configure.ac @@ -2966,8 +2966,8 @@

[libvirt] [PATCH 5/5] json: export non-static functions

2015-04-13 Thread Martin Kletzander
Two non-static functions in virjson.c were missing their export info in libvirt_private.syms, so they couldn't be used anywhere it the code (and that's about to get changed). Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/libvirt_private.syms | 2 ++ 1 file changed, 2 insertions(+)

[libvirt] [PATCH 3/5] closeCallback is already lockable, initialize it as such

2015-04-13 Thread Martin Kletzander
Luckily we are allocating structs as clean memory and PTHREAD_MUTEX_INITIALIZER is { 0 }, so nothing happened, but it should still be created as lockable object. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/datatypes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH v2 5/9] qemu: Use domain iothreadids to populate iothreadpids

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:23 -0400, John Ferlan wrote: Rather than use the default numbering scheme of 1..number of iothreads defined for the domain, use the iothreadid's list for the iothread_id and possibly augmenting the alias using the iothreadsid name. This also requires adjusting

Re: [libvirt] [PATCHv2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

2015-04-13 Thread Erik Skultety
On 04/13/2015 02:18 PM, Peter Krempa wrote: On Mon, Apr 13, 2015 at 14:01:27 +0200, Erik Skultety wrote: This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed. Also, it partially

Re: [libvirt] [PATCH v2 9/9] virsh: Add iothreadadd and iothreaddel commands

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:27 -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1161617 Add command to allow adding and removing IOThreads from the domain including the configuration and live domain. $ virsh iothreadadd --help NAME iothreadadd - add an

Re: [libvirt] [PATCH v2 6/9] Implement virDomainAddIOThread and virDomainDelIOThread

2015-04-13 Thread Peter Krempa
On Fri, Apr 10, 2015 at 17:36:24 -0400, John Ferlan wrote: Add libvirt API's to manage adding and deleting IOThreads to/from the domain Signed-off-by: John Ferlan jfer...@redhat.com --- include/libvirt/libvirt-domain.h | 7 +++ src/driver-hypervisor.h | 13

Re: [libvirt] [PATCH] configure: Check for libxl_utils.h instead of libxlutil.h

2015-04-13 Thread Martin Kletzander
On Thu, Apr 09, 2015 at 04:08:24PM +0200, Michal Privoznik wrote: The file provided by xen-devel package (or xen-tools in Gentoo) does not provide libxlutil.h. In fact the package provides libxl_utils.h instead which is the one we are looking for anyway. It also perfectly matches

Re: [libvirt] [PATCH 0/2] Fix handling of disk's WWN (world wide name)

2015-04-13 Thread Martin Kletzander
On Tue, Apr 07, 2015 at 04:10:47PM +0200, Peter Krempa wrote: Peter Krempa (2): conf: ABI: Check WWN in disk abi stability check qemu: Enforce WWN to be unique among VM's disks ACK series. docs/formatdomain.html.in | 3 ++- src/conf/domain_conf.c| 33 +

Re: [libvirt] [PATCHv1 03/13] Separate out virStorageFeatureParse

2015-04-13 Thread Ján Tomko
On Mon, Apr 13, 2015 at 07:41:12AM +0200, Peter Krempa wrote: On Fri, Apr 10, 2015 at 14:58:55 +0200, Ján Tomko wrote: diff --git a/src/conf/storage_feature_conf.c b/src/conf/storage_feature_conf.c new file mode 100644 index 000..77e6406 --- /dev/null +++

[libvirt] XML Parser failing due to cryptic Serial Number.

2015-04-13 Thread Roz Fx
I set virt-manager in qemu:///system space and tried to add new VM but it didn't proceed. I figured out its duo to serial numbers is in cryptic form. # cat /sys/devices/virtual/dmi/id/product_serial ÿÿÿ #virt-manager --debug Traceback (most recent call last):   File

[libvirt] [libvirt-glib] Support setting of compat XML node

2015-04-13 Thread Richa Sehgal
This change adds support for setting of compat XML node in libvirt gconfig storage volumes target --- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 13 + libvirt-gconfig/libvirt-gconfig-storage-vol-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 5

[libvirt] [libvirt-glib] Support setting of compat XML node

2015-04-13 Thread Richa Sehgal
This change adds support for setting of compat XML node in libvirt gconfig storage volumes target --- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 13 + libvirt-gconfig/libvirt-gconfig-storage-vol-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 5

Re: [libvirt] [PATCH] Introduce virnetdevtest

2015-04-13 Thread Laine Stump
On 04/13/2015 11:11 AM, John Ferlan wrote: On 04/03/2015 08:36 AM, Michal Privoznik wrote: This is yet another test for check of basic functionality of our NIC state handling code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/libvirt_private.syms | 1 +

[libvirt] [PATCH v2] schema: Allow multiple machines for VMs

2015-04-13 Thread Martin Kletzander
Use the same pattern for all OS types. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/schemas/domaincommon.rng | 160 ++ 1 file changed, 4 insertions(+), 156 deletions(-) diff --git a/docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH] Introduce virnetdevtest

2015-04-13 Thread John Ferlan
On 04/03/2015 08:36 AM, Michal Privoznik wrote: This is yet another test for check of basic functionality of our NIC state handling code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virnetdev.c

Re: [libvirt] [PATCH v5 0/3] Parallels disk device attach

2015-04-13 Thread Dmitry Guryanov
On 04/09/2015 01:42 PM, Alexander Burluka wrote: This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3):