use virNetworkRouteDefFree() instead of VIR_FREE to free routes, otherwise
the element 'family' would not be freed.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c
virBufferContentAndReset() doesn't free buf contents, we should use
virBufferFreeAndReset() to get buf freed.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/conf/capabilities.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/capabilities.c
On Fri, Apr 24, 2015 at 02:02:15PM -0400, John Ferlan wrote:
commit id '1e13eff4' didn't init found when changed from a bool to
an int in virStoragePoolFCRefreshThread and Coverity...
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_scsi.c | 2 +-
1 file changed, 1
On 27.04.2015 11:00, zhang bo wrote:
Besides the maillist and IRC, are there any other means of communication
available for libvirt?
I'm much concerned about scheduled conference, including online
conferences(weekly? monthly?) or face-to-face conference.
so that developers from all around
On Mon, Apr 27, 2015 at 15:38:57 +0800, Shanzhi Yu wrote:
The crash caused when checking the backing file path of a disk while
the disk has no backing file, add a check before using
disk-src-backingStore-path
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1215569
---
On 04/27/2015 05:57 PM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 15:38:57 +0800, Shanzhi Yu wrote:
The crash caused when checking the backing file path of a disk while
the disk has no backing file, add a check before using
disk-src-backingStore-path
Resolves:
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Pushed as trivial.
src/qemu/qemu_domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 76a4819..1d3c77a 100644
--- a/src/qemu/qemu_domain.h
+++
On Mon, Apr 27, 2015 at 02:41:44PM +0800, Zhang Bo wrote:
use cleanup instead of error, so that the allocated strings could also get
freed
when there's no error.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/conf/domain_conf.c | 16 +---
1 file changed, 9
On Mon, Apr 27, 2015 at 10:13:04 +0200, Martin Kletzander wrote:
Commit dcbb243bbc3470431d15cec4c5bb96d2de89a88b used the return value of
the function as int even though it returns bool.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_driver.c | 2 +-
1 file
snapshot and configFile are not freed, free them.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/util/virstoragefile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 9507ca1..6c3017c 100644
---
The lookup is just for check whether a domain we are about to add does
not already exists. Well, the virDomainObjListAdd() function does that
for us already so there's no need to duplicate the check.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/openvz/openvz_driver.c | 16
On Sat, Apr 25, 2015 at 12:14 AM, Laine Stump la...@laine.org wrote:
If someone has updated a network to change its bridge name, but the
network is still active (so that bridge name hasn't taken effect yet),
we still want to disallow another network from taking that new name.
---
As suggested
On Mon, Apr 27, 2015 at 11:26:23AM +0200, Michal Privoznik wrote:
The lookup is just for check whether a domain we are about to add does
not already exists. Well, the virDomainObjListAdd() function does that
for us already so there's no need to duplicate the check.
Signed-off-by: Michal
This fix should completely close
https://bugzilla.redhat.com/show_bug.cgi?id=1214605
Signed-off-by: Pavel Fedin p.fe...@samsung.com
tests/Makefile.am | 40 +++-
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git a/tests/Makefile.am
In a lot places we use path like this:
$(srcdir)/../src/
when in fact it can be:
$(top_srcdir)/src/
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/Makefile.am | 12 ++--
docs/Makefile.am | 50
On Sat, Apr 25, 2015 at 12:11 AM, Laine Stump la...@laine.org wrote:
On 04/24/2015 06:58 AM, Shivaprasad bhat wrote:
Thanks for the patches Laine. I agree pretty much with both the patches.
also had a chance to try these out.
Only scenario I see a trouble is,
net-create without bridge name
Only set directory permissions at pool build time, if:
- User explicitly requested a mode via the XML
- The directory needs to be created
- We need to do the crazy NFS root-squash workaround
This allows qemu:///session to call build on an existing directory
like /tmp.
---
Consider the following issue
- Using virt-manager with qemu:///session
- User adds a storage pool pointing at /tmp. No explicit permissions are
requested in the XML
- virt-manager calls PoolDefine, then PoolBuild
- libvirt tries to unconditionally chmod 755 /tmp. This fails because my
user
Currently we try to chown any directory passed to virDirCreate,
even if the user didn't request any explicit owner/group via the
pool/vol XML.
This causes issues with qemu:///session: try to build a pool of
a root owned directory like /tmp, and it fails trying to chown the
directory to the
From: Tony Krowiak akrow...@linux.vnet.ibm.com
The IBM System z Central Processor Assist for Cryptographic Functions (CPACF)
hardware provides a set of CPU instructions for use in clear-key encryption,
pseudo random number generation, hash functions, and protected-key encryption.
The CPACF
From: Tony Krowiak aekro...@us.ibm.com
Test the support for enabling/disabling CPACF protected key management
operations for a guest.
Signed-off-by: Tony Krowiak akrow...@linux.vnet.ibm.com
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
Reviewed-by: Boris Fiuczynski
The current code attempts to handle this, but it only catches mkdir
failing with EEXIST. However if say trying to build /tmp for an
unprivileged qemu:///session, mkdir will fail with EPERM.
Rather than catch any errors, just don't attempt mkdir if the directory
already exists.
---
From: Tony Krowiak aekro...@us.ibm.com
Introduces two new -machine option parameters to the QEMU command to
enable/disable the CPACF protected key management operations for a guest:
aes-key-wrap='on|off'
dea-key-wrap='on|off'
The QEMU code maps the corresponding domain configuration
This means pool XML actually reports accurate user/group/mode/label.
This uses UpdateVolTargetInfoFD in a bit of a hackish way, but it works
---
src/storage/storage_backend_fs.c | 58 ++--
1 file changed, 44 insertions(+), 14 deletions(-)
diff --git
virDirCreate will give us fine grained details about what actually failed.
---
src/storage/storage_backend_fs.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 521dc70..51d6bb3 100644
---
The XML parser sets a default mode if none is explicitly passed in.
This is then used at pool/vol creation time, and unconditionally reported
in the XML.
The problem with this approach is that it's impossible for other code
to determine if the user explicitly requested a storage mode. There
are
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
tests/commandtest.c | 1 +
tests/domaincapstest.c | 1 +
tests/qemucommandutiltest.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 6400ea2..f001a39 100644
---
Zhang Bo (6):
tests: fix some memleaks in tests
util: fix memleak in virFindSCSIHostByPCI
qemu: fix memleaks in qemuBuildCommandLine
qemu: fix memleak in virCapabilitiesDomainDataLookup
conf: fix memleak in virDomainNetIpParseXML
conf: fix memleak in virDomainHostdevDefClear
free boot_opts_str and boot_order_str both in normal and error paths.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/qemu/qemu_command.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 29b876e..a54f3a3 100644
---
free buf in cleanup.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/util/virutil.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 79cdb7a..0426517 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -1815,6 +1815,8 @@
On Thu, Apr 23, 2015 at 11:18:08AM +0200, Jiri Denemark wrote:
virDomainGetJobStats is able to report statistics of a completed
migration, however to get usable downtime and total time statistics both
hosts have to keep synchronized time. To provide at least some
estimation of the times even
On Sat, Apr 25, 2015 at 02:10:00PM +0800, zhang bo wrote:
iff - if
Michal insists that iff is a real word meaning 'if and only if':
http://en.wiktionary.org/wiki/iff
So we shouldn't correct it as a typo.
rather then - rather than
Signed-off-by: YueWenyuan yueweny...@huawei.com
---
The crash caused when checking the backing file path of a disk while
the disk has no backing file, add a check before using
disk-src-backingStore-path
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1215569
---
src/qemu/qemu_driver.c | 9 +
1 file changed, 9 insertions(+)
diff
On Mon, Apr 27, 2015 at 09:31:30 +0200, Martin Kletzander wrote:
On Thu, Apr 23, 2015 at 11:18:08AM +0200, Jiri Denemark wrote:
virDomainGetJobStats is able to report statistics of a completed
migration, however to get usable downtime and total time statistics both
hosts have to keep
Besides the maillist and IRC, are there any other means of communication
available for libvirt?
I'm much concerned about scheduled conference, including online
conferences(weekly? monthly?) or face-to-face conference.
so that developers from all around could join together to share about
Commit dcbb243bbc3470431d15cec4c5bb96d2de89a88b used the return value of
the function as int even though it returns bool.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
use cleanup instead of error, so that the allocated strings could also get freed
when there's no error.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/conf/domain_conf.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c
On Mon, Apr 27, 2015 at 02:41:39PM +0800, Zhang Bo wrote:
Zhang Bo (6):
tests: fix some memleaks in tests
util: fix memleak in virFindSCSIHostByPCI
qemu: fix memleaks in qemuBuildCommandLine
qemu: fix memleak in virCapabilitiesDomainDataLookup
conf: fix memleak in
Coverity notes taht the switch() used to check 'connected' values has
two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean
it can only be one or the other (CONNECTED or DISCONNECTED), so it just
seems pointless to use a switch to get all values. Convert to if-else
Signed-off-by:
On 27.04.2015 13:33, John Ferlan wrote:
Coverity notes taht the switch() used to check 'connected' values has
s/taht/that/
two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean
it can only be one or the other (CONNECTED or DISCONNECTED), so it just
seems pointless to use a
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image. This condition can be achieved also with a raw file (or a qcow
without a backing file) so remove the condition that would disallow it.
(This patch
On 04/27/2015 07:51 AM, Michal Privoznik wrote:
On 27.04.2015 13:33, John Ferlan wrote:
Coverity notes taht the switch() used to check 'connected' values has
s/taht/that/
two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean
it can only be one or the other (CONNECTED or
The only version that's supported in QEMU is version 2, currently.
Fortunately, it is enabled by aarch64 automatically, so there's
nothing for us that needs to be put onto command line.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_command.c|
On Mon, Apr 27, 2015 at 01:40:53PM +0300, Pavel Fedin wrote:
This fix should completely close
https://bugzilla.redhat.com/show_bug.cgi?id=1214605
Signed-off-by: Pavel Fedin p.fe...@samsung.com
tests/Makefile.am | 40 +++-
1 file changed, 27 insertions(+), 13
On Fri, Apr 24, 2015 at 12:05:53 -0400, John Ferlan wrote:
Adding a new XML element 'iothreadids' in order to allow defining
specific IOThread ID's rather than relying on the algorithm to assign
IOThread ID's starting at 1 and incrementing to iothreads count.
This will allow future patches
On Mon, Apr 27, 2015 at 05:26:31PM +0800, zhang bo wrote:
snapshot and configFile are not freed, free them.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/util/virstoragefile.c | 2 ++
1 file changed, 2 insertions(+)
ACK, will push in a while.
Martin
signature.asc
Description:
On Mon, Apr 27, 2015 at 07:33:06 -0400, John Ferlan wrote:
Coverity notes taht the switch() used to check 'connected' values has
two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean
it can only be one or the other (CONNECTED or DISCONNECTED), so it just
seems pointless to use
On Mon, Apr 27, 2015 at 11:23:23AM +0200, Michal Privoznik wrote:
In a lot places we use path like this:
$(srcdir)/../src/
when in fact it can be:
$(top_srcdir)/src/
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
daemon/Makefile.am | 12 ++--
docs/Makefile.am
There's no APIC on aarch64. It's replaced by GIC (Generic Interrupt Controller).
Michal Privoznik (2):
Introduce GIC feature
qemu: Implement GIC
docs/formatdomain.html.in | 9 ++
docs/schemas/domaincommon.rng | 11 ++-
Some platforms, like aarch64, don't have APIC but GIC. So there's
no reason to have apic/ feature turned on. However, we are
still missing gic/ feature. This commit introduces the feature
to XML parser and formatter, adds documentation and updates RNG
schema.
Signed-off-by: Michal Privoznik
On Tue, Apr 21, 2015 at 01:57:39PM +0200, Marc-André Lureau wrote:
The vmport machine argument works with pc machine kind, not with xen for
example.
---
src/qemu/qemu_capabilities.c | 13 +
src/qemu/qemu_capabilities.h | 3 +++
src/qemu/qemu_command.c | 19 ---
On Fri, Apr 24, 2015 at 12:05:59 -0400, John Ferlan wrote:
Add remote support for the add/delete IOThread API's
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/remote/remote_driver.c | 2 ++
src/remote/remote_protocol.x | 30 +-
On Sat, Apr 25, 2015 at 07:30:21PM +0300, Roman Bogorodskiy wrote:
Martin Kletzander wrote:
On Tue, Mar 10, 2015 at 02:27:44PM +0100, Ján Tomko wrote:
On Tue, Mar 10, 2015 at 01:45:38PM +0100, Martin Kletzander wrote:
On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote:
On
In order not to bring in any link dependencies, bridge driver doesn't
use the usual stubs as other conditionally-built code does. However,
having the function as a macro imposes a problem with possibly unused
variables if just defined as 0. This was worked around by using
(dom=dom, iface=iface,
On Fri, Apr 24, 2015 at 12:05:55 -0400, John Ferlan wrote:
Since it's only ever referenced in domain_conf.c, make the function
static, but also will need to move it to somewhere before it's referenced
rather than forward referencing it.
Signed-off-by: John Ferlan jfer...@redhat.com
---
On Fri, Apr 24, 2015 at 12:05:57 -0400, John Ferlan wrote:
With iothreadid's allowing any 'id' value for an iothread_id, the
iothreadsched code needs a slight adjustment to allow for any
unsigned int value in order to create the bitmap of ids that will
have scheduler adjustments. Adjusted the
Hello!
Thirdly, I wonder why you needed to add this, is gnulib really needed?
is that because of those strdup()s in the file? Why doesn't it fail
with gcc then?
Fourthly (is that even a word?), I'd ACK this and push it, but just
please let me know whether GNULIB_LIBS is really needed
On 04/27/2015 10:08 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:05:54 -0400, John Ferlan wrote:
Add 'thread_id' to the virDomainIOThreadIDDef as a means to store the
'thread_id' as returned from the live qemu monitor data.
Remove the iothreadpids list from _qemuDomainObjPrivate and
On Mon, Apr 27, 2015 at 05:40:28PM +0300, Pavel Fedin wrote:
Hello!
Thirdly, I wonder why you needed to add this, is gnulib really needed?
is that because of those strdup()s in the file? Why doesn't it fail
with gcc then?
Fourthly (is that even a word?), I'd ACK this and push it, but just
Signed-off-by: Pavel Fedin p.fe...@samsung.com
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index dc7daaa..e3ba12b 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@
On Tue, Apr 21, 2015 at 01:57:41PM +0200, Marc-André Lureau wrote:
Check that the vmport feature is correctly used in qemu commande line.
---
.../qemuxml2argv-machine-vmport-opt.args | 6 +
.../qemuxml2argv-machine-vmport-opt.xml| 28 ++
On Fri, Apr 24, 2015 at 12:05:54 -0400, John Ferlan wrote:
Add 'thread_id' to the virDomainIOThreadIDDef as a means to store the
'thread_id' as returned from the live qemu monitor data.
Remove the iothreadpids list from _qemuDomainObjPrivate and replace with
the new iothreadids 'thread_id'
On 04/27/2015 08:01 PM, Peter Krempa wrote:
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image. This condition can be achieved also with a raw file (or a qcow
without a backing file) so remove the
On Mon, Apr 27, 2015 at 03:41:31PM +0200, Martin Kletzander wrote:
All the libraries use same parameters when building, why not have it in
one place at the begining of the Makefile.
This will also ensure no new mock library will have a problem with
missing e.g. MINGW_EXTRA_LDFLAGS.
After pool startup we call refreshPool(). If that fails, we leave
a stale pool state file hanging around.
Hit this trying to create a pool with qemu:///session containing
root owned files.
---
src/storage/storage_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
On Fri, Apr 24, 2015 at 12:06:01 -0400, John Ferlan wrote:
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the 'live' option will use the iothreadpids list
in order to make
On Mon, Apr 27, 2015 at 03:07:06PM +0200, Martin Kletzander wrote:
On Mon, Apr 27, 2015 at 01:40:53PM +0300, Pavel Fedin wrote:
This fix should completely close
https://bugzilla.redhat.com/show_bug.cgi?id=1214605
Signed-off-by: Pavel Fedin p.fe...@samsung.com
tests/Makefile.am | 40
All the libraries use same parameters when building, why not have it in
one place at the begining of the Makefile.
This will also ensure no new mock library will have a problem with
missing e.g. MINGW_EXTRA_LDFLAGS.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/Makefile.am | 58
On Mon, Apr 27, 2015 at 04:03:55PM +0200, Martin Kletzander wrote:
Signed-off-by: Pavel Fedin p.fe...@samsung.com
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
I used send-email and forgot to format the patch, so here are the
On Fri, Apr 24, 2015 at 12:05:56 -0400, John Ferlan wrote:
Remove the iothreadspin array from cputune and replace with a cpumask
to be stored in the iothreadids list.
Adjust the test output because our printing goes in order of the iothreadids
list now.
Signed-off-by: John Ferlan
On Tue, Apr 21, 2015 at 01:57:35PM +0200, Marc-André Lureau wrote:
Hi,
The QEMU machine vmport option allows to set the VMWare IO port
emulation. This emulation is useful for absolute pointer input when the
guest has vmware input drivers, and is enabled by default for kvm.
However it is
On Fri, Apr 24, 2015 at 12:05:58 -0400, John Ferlan wrote:
Add libvirt API's to manage adding and deleting IOThreads to/from the
domain
Signed-off-by: John Ferlan jfer...@redhat.com
---
include/libvirt/libvirt-domain.h | 6 ++
src/driver-hypervisor.h | 12
On Fri, Apr 24, 2015 at 12:06:00 -0400, John Ferlan wrote:
We're about to allow IOThreads to be deleted, but an iothreadid may be
included in some domain thread sched, so add a new API to allow removing
an iothread from some entry.
Then during the writing of the threadsched data and an
First patch fixes a regression introduced with pool state patches
Last 3 patches help fix other issues with the state tracking
Cole Robinson (4):
storage: Fix autostart dir for qemu:///session
storage: Don't leave stale state file if pool startup fails
storage: Break out
Will simplify a future patch
---
src/storage/storage_driver.c | 88 +++-
1 file changed, 47 insertions(+), 41 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 06686bf..9abdc68 100644
---
If you end up with a state file for a pool that no longer starts up
or refreshes correctly, the state file is never removed and adds
noise to the logs everytime libvirtd is started.
If the initial state syncing fails, delete the statefile.
---
src/storage/storage_driver.c | 13 +
1
---
src/storage/storage_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 306d98e..3b7746b 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -237,7 +237,7 @@
On Mon, Apr 27, 2015 at 10:49:32 -0400, John Ferlan wrote:
On 04/27/2015 10:08 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:05:54 -0400, John Ferlan wrote:
Add 'thread_id' to the virDomainIOThreadIDDef as a means to store the
'thread_id' as returned from the live qemu monitor
On 04/27/2015 10:20 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:05:56 -0400, John Ferlan wrote:
Remove the iothreadspin array from cputune and replace with a cpumask
to be stored in the iothreadids list.
Adjust the test output because our printing goes in order of the iothreadids
From: Tony Krowiak akrow...@linux.vnet.ibm.com
Two new domain configuration XML elements have been added to enable/disable
the protected key management operations for a guest:
domain
...
keywrap
cipher name='aes|dea' state='on|off'/
/keywrap
...
/domain
From: Tony Krowiak akrow...@linux.vnet.ibm.com
The IBM System z Central Processor Assist for Cryptographic Functions (CPACF)
hardware provides a set of CPU instructions for use in clear-key encryption,
pseudo random number generation, hash functions, and protected-key encryption.
The CPACF
Hi all,
libvirt's selinux/DAC labeling behavior has been a repeated source of
frustration for desktop virt users. Granted much of the frustration comes from
the fact that virt-manager runs as $user, talks to libvirtd running as root,
which launches VMs running as qemu, and we are mixing it all
I'm a little late, but I have now tagged candidate release 1 for
1.2.15 in git and pushed signed tarballs and rpms to the usual place:
ftp://libvirt.org/libvirt/
this seems to work for me in my limited testing, but please give
it a try, especially on less common platforms.
The
the free callback should be qemuMonitorChardevInfoFree rather than just 'free'
when virHashCreate'ing the chardevInfo hash.
Zhang Bo (2):
qemu: make qemuMonitorChardevInfoFree non-static
tests: free ChardevInfo correctly in qemumonitorjsontest
src/qemu/qemu_monitor.c | 2 +-
On Mon, Apr 27, 2015 at 11:20 PM, Laine Stump la...@laine.org wrote:
On 04/27/2015 05:54 AM, Shivaprasad bhat wrote:
On Sat, Apr 25, 2015 at 12:14 AM, Laine Stump la...@laine.org wrote:
If someone has updated a network to change its bridge name, but the
network is still active (so that bridge
Dear Libvirt Developers,
There seems to be a bug or at least a bad behavior in
`src/qemu/qemu_monitor.c' lines 683-689 function `qemuMonitorIO':
if (qemuMonitorIOWrite(mon) 0) {
error = true;
if (errno == ECONNRESET)
hangup = true;
It would be used in qemumonitorjsontest, thus we make it non-static.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
Signed-off-by: Zhou Yimin zhouyi...@huawei.com
---
src/qemu/qemu_monitor.c | 2 +-
src/qemu/qemu_monitor.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
the free callback should be qemuMonitorChardevInfoFree rather than just 'free'
when virHashCreate'ing the chardevInfo hash.
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
Signed-off-by: Zhou Yimin zhouyi...@huawei.com
---
tests/qemumonitorjsontest.c | 4 ++--
1 file changed, 2 insertions(+), 2
On 04/27/2015 11:38 PM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 22:11:40 +0800, Shanzhi Yu wrote:
On 04/27/2015 08:01 PM, Peter Krempa wrote:
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image.
On Mon, Apr 27, 2015 at 11:25:15 -0400, John Ferlan wrote:
...
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2267,12 +2267,16 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr
driver,
goto cleanup;
}
A few lines prior here is the check that the
On 04/27/2015 10:28 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:05:57 -0400, John Ferlan wrote:
With iothreadid's allowing any 'id' value for an iothread_id, the
iothreadsched code needs a slight adjustment to allow for any
unsigned int value in order to create the bitmap of ids that
A friendly reminder that KVM Forum 2015 accepts proposal submissions
until next Friday.
Thanks on behalf of the KVM Forum 2015 Program Committee.
Paolo
On 11/03/2015 18:53, Paolo Bonzini wrote:
=
KVM Forum 2015: Call For
On Mon, Apr 27, 2015 at 22:11:40 +0800, Shanzhi Yu wrote:
On 04/27/2015 08:01 PM, Peter Krempa wrote:
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image. This condition can be achieved also with
On 04/27/2015 10:35 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:06:00 -0400, John Ferlan wrote:
We're about to allow IOThreads to be deleted, but an iothreadid may be
included in some domain thread sched, so add a new API to allow removing
an iothread from some entry.
Then during
On Mon, Apr 27, 2015 at 11:56:20 -0400, John Ferlan wrote:
On 04/27/2015 11:46 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 11:25:15 -0400, John Ferlan wrote:
...
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2267,12 +2267,16 @@
On Mon, Apr 27, 2015 at 11:54:08 -0400, John Ferlan wrote:
On 04/27/2015 10:35 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:06:00 -0400, John Ferlan wrote:
We're about to allow IOThreads to be deleted, but an iothreadid may be
included in some domain thread sched, so add a new API
Trying to use qemu:///session to create a storage pool pointing at
/tmp will usually fail with something like:
$ virsh pool-start tmp
error: Failed to start pool tmp
error: cannot open volume
'/tmp/systemd-private-c38cf0418d7a4734a66a8175996c384f-colord.service-kEyiTA':
Permission denied
If
On 27.04.2015 14:22, John Ferlan wrote:
On 04/27/2015 07:51 AM, Michal Privoznik wrote:
On 27.04.2015 13:33, John Ferlan wrote:
Coverity notes taht the switch() used to check 'connected' values has
s/taht/that/
two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean
it
...
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2267,12 +2267,16 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr
driver,
goto cleanup;
}
A few lines prior here is the check that the expected thread count
equals to the actual thread count. For some
On Mon, Apr 27, 2015 at 11:27:09 -0400, John Ferlan wrote:
On 04/27/2015 10:28 AM, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 12:05:57 -0400, John Ferlan wrote:
With iothreadid's allowing any 'id' value for an iothread_id, the
iothreadsched code needs a slight adjustment to allow for
1 - 100 of 114 matches
Mail list logo
