On Wed, Apr 29, 2015 at 01:08:37PM -0400, Cole Robinson wrote:
On 04/29/2015 08:32 AM, Martin Kletzander wrote:
On Tue, Apr 28, 2015 at 08:13:19PM -0400, Cole Robinson wrote:
This can cause permissions failures if qemu.conf user/group is changed.
I assume the issue only exists if the socket
On Wed, Apr 29, 2015 at 03:44:46PM -0400, Cole Robinson wrote:
On 04/29/2015 03:42 PM, Guido Günther wrote:
On Tue, Apr 28, 2015 at 07:51:11PM -0400, Cole Robinson wrote:
Many users, who admin their own machines, want to be able to access
system libvirtd via tools like virt-manager without
On Wed, 2015-04-29 at 12:58 +0100, Daniel P. Berrange wrote:
It seems to me that every application that uses libnuma is going to
potentially suffer from the same problem. As such I don't think it
is a good use of effort to workaround it in libvirt - it should be
fixed in libnuma itself, so
On 28.04.2015 00:04, Cole Robinson wrote:
Hi all,
libvirt's selinux/DAC labeling behavior has been a repeated source of
frustration for desktop virt users. Granted much of the frustration comes from
the fact that virt-manager runs as $user, talks to libvirtd running as root,
which launches
Just as we allow stopping filesystem pools when they were unmounted
externally, do not fail to stop an iscsi pool when someone else
closed the session externally.
Reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
---
v2: Do not report errors when returning success (use probe=true)
ping...
2015-04-28 19:26 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
This patch add to libvirt php binding libvirt stream support
Also provide resize/upload/download for libvirt volume
Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru
---
configure.ac | 3 +-
src/libvirt-php.c
On Wed, Apr 29, 2015 at 12:37:38PM -0400, John Ferlan wrote:
On 04/23/2015 07:50 AM, Ján Tomko wrote:
On Wed, Apr 22, 2015 at 01:17:20PM -0400, John Ferlan wrote:
...
Having the dialog in your other series caused me to remember there was
still a question here.
Or just disallow
On Wed, Apr 29, 2015 at 01:03:29PM -0400, John Ferlan wrote:
On 04/29/2015 10:40 AM, Ján Tomko wrote:
On Wed, Apr 29, 2015 at 10:10:11AM -0400, John Ferlan wrote:
On 04/29/2015 09:08 AM, Ján Tomko wrote:
Just as we allow stopping filesystem pools when they were unmounted
On 29.04.2015 13:31, John Ferlan wrote:
On 04/27/2015 09:07 AM, Michal Privoznik wrote:
Some platforms, like aarch64, don't have APIC but GIC. So there's
no reason to have apic/ feature turned on. However, we are
s/have/have the/
s/turned on/enabled/
still missing gic/ feature. This
On Thu, Apr 30, 2015 at 08:46:50AM -0400, John Ferlan wrote:
On 04/30/2015 07:06 AM, Ján Tomko wrote:
Just as we allow stopping filesystem pools when they were unmounted
externally, do not fail to stop an iscsi pool when someone else
closed the session externally.
Reported at:
On Thu, Apr 30, 2015 at 11:56:20AM +0200, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=858147
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/cpu/cpu_x86.c | 6 ++
.../qemuxml2argv-cpu-host-model-vendor.args | 20
On Thu, Apr 30, 2015 at 01:20:30PM +0200, Michal Privoznik wrote:
On 28.04.2015 00:04, Cole Robinson wrote:
Hi all,
libvirt's selinux/DAC labeling behavior has been a repeated source of
frustration for desktop virt users. Granted much of the frustration comes
from
the fact that
The libvirt developer community is generally more comfortable
with python like languages, so this converts the bracket-spacing.pl
test to use python like syntax. It includes one extra external
Perl dependancy, but after applying this, there should be no
functional change - just prettier syntax. If
On 30.04.2015 14:04, Erik Skultety wrote:
The lock is dropped always at the end of an API, but for example when
attaching devices, there's no point in having the NW filter locked if the
device being attached isn't a network interface. It's always a nice
practice to drop unnecessary locks as
On 04/30/2015 07:53 AM, Michal Privoznik wrote:
...
+}
+def-features[val] = VIR_TRISTATE_SWITCH_ON;
+ctxt-node = node;
+break;
+
/* coverity[dead_error_begin] */
case VIR_DOMAIN_FEATURE_LAST:
break;
@@
The lock is dropped always at the end of an API, but for example when
attaching devices, there's no point in having the NW filter locked if the
device being attached isn't a network interface. It's always a nice
practice to drop unnecessary locks as soon as possible.
---
src/qemu/qemu_driver.c |
On 04/30/2015 07:06 AM, Ján Tomko wrote:
Just as we allow stopping filesystem pools when they were unmounted
externally, do not fail to stop an iscsi pool when someone else
closed the session externally.
Reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
---
v2: Do not
On 30.04.2015 14:19, Jiri Denemark wrote:
Only USB addresses are allowed for USB disks. Report an error if another
address is configured.
https://bugzilla.redhat.com/show_bug.cgi?id=1043436
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/qemu/qemu_command.c | 12
Separate the code to simplify future refactors.
---
src/conf/domain_conf.c | 82 +-
1 file changed, 47 insertions(+), 35 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b9c4c61..057602b 100644
---
Peter Krempa (6):
util: Make the virDomainListFree helper more universal
conf: Extract code to filter domain list into a separate function
conf: Rename virDomainObjListFilter type to virDomainObjListACLFilter
conf: Refactor domain list collection critical section
conf: Add helper to
On Thu, Apr 30, 2015 at 02:38:21PM +0200, Michal Privoznik wrote:
On 30.04.2015 14:04, Erik Skultety wrote:
The lock is dropped always at the end of an API, but for example when
attaching devices, there's no point in having the NW filter locked if the
device being attached isn't a network
For some reason, we allow a bridge name with %d in it, which we replace
with an unsigned integer to form a bridge name that does not yet exist
on the host.
Do not blindly pass it to virAsprintf if it's not the only conversion,
to prevent crashing on input like:
network
nametest/name
forward
On Thu, Apr 30, 2015 at 01:27:06PM +0100, Daniel P. Berrange wrote:
The libvirt developer community is generally more comfortable
with python like languages, so this converts the bracket-spacing.pl
test to use python like syntax. It includes one extra external
Perl dependancy, but after
Extend it to a universal helper used for clearing lists of any objects.
Note that the argument type is specifically void * to allow implicit
typecasting.
Additionally add a helper that works on non-NULL terminated arrays once
we know the length.
---
daemon/remote.c | 2 +-
Many users, who admin their own machines, want to be able to access
system libvirtd via tools like virt-manager without having to enter
a root password. Just google 'virt-manager without password' and
you'll find many hits. I've read at least 5 blog posts over the years
describing slightly
On 04/30/2015 05:21 AM, Daniel P. Berrange wrote:
On Wed, Apr 29, 2015 at 03:44:46PM -0400, Cole Robinson wrote:
On 04/29/2015 03:42 PM, Guido Günther wrote:
On Tue, Apr 28, 2015 at 07:51:11PM -0400, Cole Robinson wrote:
Many users, who admin their own machines, want to be able to access
Only USB addresses are allowed for USB disks. Report an error if another
address is configured.
https://bugzilla.redhat.com/show_bug.cgi?id=1043436
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/qemu/qemu_command.c | 12
1 file changed, 12 insertions(+)
diff --git
Add virDomainObjListConvert that will take a list of virDomains, apply
filters and return a list of virDomainObjs.
---
src/conf/domain_conf.c | 54
src/conf/domain_conf.h | 9
src/libvirt_private.syms | 1 +
3 files changed, 64
The passed function is meant to filter domains according to ACL match.
---
src/conf/domain_conf.c | 16
src/conf/domain_conf.h | 12 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Until now the virDomainListAllDomains API would lock the domain list and
then every single domain object to access and filter it. This would
potentially allow a unresponsive VM to block the whole daemon if a
*listAllDomains call would get stuck.
To avoid this problem this patch collects a list of
Use the new domain list collection helpers to avoid going through
virDomainPtrs.
This additionally implements filter capability when called through the
api that accepts domain list filters.
---
src/qemu/qemu_driver.c | 86 ++
1 file changed, 37
https://bugzilla.redhat.com/show_bug.cgi?id=858147
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/cpu/cpu_x86.c | 6 ++
.../qemuxml2argv-cpu-host-model-vendor.args | 20
.../qemuxml2argv-cpu-host-model-vendor.xml
On 04/30/2015 08:45 AM, Peter Krempa wrote:
---
tools/virsh.pod | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f8496f3..f576fb0 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1124,10 +1124,10 @@ I--config or
On Thu, Apr 30, 2015 at 15:32:38 +0200, Ján Tomko wrote:
On Thu, Apr 30, 2015 at 11:56:20AM +0200, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=858147
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
src/cpu/cpu_x86.c | 6
On 04/30/2015 05:59 AM, Ján Tomko wrote:
On Wed, Apr 29, 2015 at 12:37:38PM -0400, John Ferlan wrote:
On 04/23/2015 07:50 AM, Ján Tomko wrote:
On Wed, Apr 22, 2015 at 01:17:20PM -0400, John Ferlan wrote:
...
Having the dialog in your other series caused me to remember there was
still a
cmdBlockJob will be converted to a hub that will call into the
individual executor functions.
---
tools/virsh-domain.c | 93 +++-
1 file changed, 56 insertions(+), 37 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
Move the code to appropriate parts to sanitize control flow.
Peter Krempa (8):
virsh: blockjob: Extract block job info code into a separate function
virsh: cmdBlockJob: Switch to declarative flag interlocking
virsh: blockjob: Split out vshBlockJobSetSpeed from blockJobImpl
virsh: man: Add
Final cleanup to get rid of the hub function.
---
tools/virsh-domain.c | 96 +++-
1 file changed, 35 insertions(+), 61 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 081adfd..e2a38e7 100644
--- a/tools/virsh-domain.c
Use the VSH_EXCLUSIVE_OPTIONS_VAR to interlock incompatible options
---
tools/virsh-domain.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 01c6b9e..720bc68 100644
--- a/tools/virsh-domain.c
---
tools/virsh-domain.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index fef3918..7afa319 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1666,7 +1666,6 @@
On 04/30/2015 06:28 AM, Ján Tomko wrote:
For some reason, we allow a bridge name with %d in it, which we replace
with an unsigned integer to form a bridge name that does not yet exist
on the host.
Do not blindly pass it to virAsprintf if it's not the only conversion,
to prevent crashing on
On 04/30/2015 08:37 AM, Peter Krempa wrote:
Since the qemu capabilities are not initialized for offline VMs the
caller might get suboptimal error message:
$ virsh blockjob VM PATH --bandwidth 1
error: unsupported configuration: block jobs not supported with this QEMU
binary
Move the
On 04/30/2015 06:59 AM, Ján Tomko wrote:
On Wed, Apr 29, 2015 at 01:03:29PM -0400, John Ferlan wrote:
On 04/29/2015 10:40 AM, Ján Tomko wrote:
On Wed, Apr 29, 2015 at 10:10:11AM -0400, John Ferlan wrote:
On 04/29/2015 09:08 AM, Ján Tomko wrote:
Just as we allow stopping filesystem pools
Allow specifying sizes in bytes or as scaled integers for user
convenience.
---
tools/virsh-domain.c | 31 ---
tools/virsh.pod | 10 +++---
2 files changed, 31 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
---
tools/virsh-domain.c | 50 --
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 7afa319..081adfd 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1666,7 +1666,6 @@
---
tools/virsh.pod | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f8496f3..f576fb0 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1124,10 +1124,10 @@ I--config or I--current can be specified. If no
flag is specified,
---
tools/virsh-domain.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 720bc68..0d0e39e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1667,7 +1667,6 @@
On 04/30/2015 07:30 AM, Daniel P. Berrange wrote:
On Thu, Apr 30, 2015 at 01:20:30PM +0200, Michal Privoznik wrote:
On 28.04.2015 00:04, Cole Robinson wrote:
Hi all,
libvirt's selinux/DAC labeling behavior has been a repeated source of
frustration for desktop virt users. Granted much of the
Since the qemu capabilities are not initialized for offline VMs the
caller might get suboptimal error message:
$ virsh blockjob VM PATH --bandwidth 1
error: unsupported configuration: block jobs not supported with this QEMU binary
Move the checks after we make sure that the VM is alive.
---
This means new libxl-lockd.conf and libxl-sanlock.conf
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
Pushed under trivial rule.
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 9d09709..7bcf359 100644
--- a/.gitignore
+++ b/.gitignore
@@
Back in 2013, commit 877bc089 added in some tests that made sure no
error was generated on a domain definition that had an automatically
added usb controller if that domain didn't have a PCI bus to attach
the usb controller to. In particular, two s390-specific tests were
added, one with controller
Found by Laine and discussed a bit on internal IRC.
Commit id c56fe7f1d6 added support for creating a command line to support
scsi-disk.channel.
Series was here:
http://www.redhat.com/archives/libvir-list/2012-February/msg01052.html
Which pointed to a design proposal here:
Daniel Veillard wrote:
On Wed, Apr 29, 2015 at 11:38:06AM -0600, Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 22, 2015 at 02:41:50PM -0600, Jim Fehlig wrote:
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig
I have now tagged candidate release 2 for 1.2.15 in git and pushed
signed tarballs and rpms to the usual place:
ftp://libvirt.org/libvirt/
this seems to work for me in my limited testing, but please give
it a try, especially on less common platforms.
The https://ci.centos.org/ seems to
On Thu, Apr 30, 2015 at 05:45:20PM -0600, Jim Fehlig wrote:
Daniel Veillard wrote:
On Wed, Apr 29, 2015 at 11:38:06AM -0600, Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 22, 2015 at 02:41:50PM -0600, Jim Fehlig wrote:
Provide integration with libvirt's
Add logrotate config for log files in /var/log/libvirt/libxl.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
daemon/Makefile.am | 13 -
daemon/libvirtd.libxl.logrotate.in | 9 +
libvirt.spec.in| 3 +++
3 files changed, 24 insertions(+), 1
On 04/30/2015 04:55 PM, John Ferlan wrote:
Found by Laine and discussed a bit on internal IRC.
Commit id c56fe7f1d6 added support for creating a command line to support
scsi-disk.channel.
Series was here:
http://www.redhat.com/archives/libvir-list/2012-February/msg01052.html
Which
Pavel Hrdina wrote:
Recent commit 198cc1d3 introduced integration of lockd and sanlock into
libxl, but forget to update libvirt.spec.in to also list new files
distributed via package.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
Pushed under build-breaker rule.
libvirt.spec.in | 2
ACK, this just broke my attempt to build 1.2.15-rc2
Daniel
On Thu, Apr 30, 2015 at 05:22:28PM +0200, Pavel Hrdina wrote:
Recent commit 198cc1d3 introduced integration of lockd and sanlock into
libxl, but forget to update libvirt.spec.in to also list new files
distributed via package.
On Thu, Apr 30, 2015 at 14:40:50 +0200, Michal Privoznik wrote:
On 30.04.2015 14:19, Jiri Denemark wrote:
Only USB addresses are allowed for USB disks. Report an error if another
address is configured.
https://bugzilla.redhat.com/show_bug.cgi?id=1043436
Signed-off-by: Jiri Denemark
Recent commit 198cc1d3 introduced integration of lockd and sanlock into
libxl, but forget to update libvirt.spec.in to also list new files
distributed via package.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
Pushed under build-breaker rule.
libvirt.spec.in | 2 ++
1 file changed, 2
On Thu, Apr 30, 2015 at 08:40:56 -0600, Eric Blake wrote:
On 04/30/2015 08:37 AM, Peter Krempa wrote:
Since the qemu capabilities are not initialized for offline VMs the
caller might get suboptimal error message:
$ virsh blockjob VM PATH --bandwidth 1
error: unsupported configuration:
On Wed, Apr 29, 2015 at 11:38:06AM -0600, Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 22, 2015 at 02:41:50PM -0600, Jim Fehlig wrote:
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V3 of
Since libvirt doesn't call to update the new balloon size in qemu add
code that will handle tweaking of the size of the current balloon
statistic until qemu reports the new size using the event.
---
src/qemu/qemu_driver.c | 3 +++
src/qemu/qemu_hotplug.c | 10 ++
2 files changed, 13
To avoid having the ballooned memory size larger than the actual
physical memory size, truncate the ballooned size if it overflows.
---
src/conf/domain_conf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d397bca..3a1782e 100644
---
Specifying a balloon size more than the memory size of a guest isn't
something that should be rejected when parsing the XML. Truncate the
size to the maximum memory size.
---
src/conf/domain_conf.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git
Peter Krempa (3):
conf: Always truncate balloon size to maximum memory size
conf: Fix up balloon size after removing a memory device from def
qemu: Fix balloon size handling with memory hot(un)plug
src/conf/domain_conf.c | 27 +++
src/qemu/qemu_driver.c | 3 +++
67 matches
Mail list logo
