Re: [libvirt] [PATCH v4] parallels: add block device statistics to driver

2015-06-08 Thread Dmitry Guryanov
On 06/05/2015 05:17 PM, Nikolay Shirokovskiy wrote: static int parallelsDoCmdRun(char **outbuf, const char *binary, va_list list) diff --git a/src/parallels/parallels_utils.h b/src/parallels/parallels_utils.h index 2d1d405..cdf6082 100644 --- a/src/parallels/parallels_utils.h +++

Re: [libvirt] [PATCH] parallels: return only success from PCS event handler

2015-06-08 Thread Dmitry Guryanov
On 06/05/2015 04:47 PM, Nikolay Shirokovskiy wrote: 2 reasons to to this. 1. PCS SDK really don't care of handler return value. 2. It hard to imagine how notifier can handle subscriber failures. Even if there are some situations we probably will use some special error codes and not just throw

[libvirt] [PATCH] storage: Need to set secrettype for direct iscsi disk volume

2015-06-08 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1200206 Commit id '1b4eaa61' added the ability to have a mode='direct' for an iscsi disk volume. It relied on virStorageTranslateDiskSourcePool in order to copy any disk source pool authentication information to the direct disk volume, but it neglected

Re: [libvirt] [PATCH 3/3] qemu: caps: Advertise arm 32-on-64 KVM option

2015-06-08 Thread Cole Robinson
On 06/08/2015 04:46 AM, Daniel P. Berrange wrote: On Sat, Jun 06, 2015 at 07:06:42PM -0400, Cole Robinson wrote: On 05/28/2015 07:31 AM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 07:03:28PM -0400, Cole Robinson wrote: We need to use qemu-system-aarch64 to run armv7l KVM VMs on an

Re: [libvirt] [PATCH v2] parallels: simplify event types discrimination

2015-06-08 Thread Dmitry Guryanov
On 06/04/2015 02:45 PM, Nikolay Shirokovskiy wrote: Use issuer type instead of event type to group vm related events. This saves us from explicit enumeration of all vm event types in prlsdkHandleVmEvent. Thanks, ACKed and pushed. --- src/parallels/parallels_sdk.c | 15 +-- 1

[libvirt] [PATCH] libxl: Add timestamp to the libxl driver log.

2015-06-08 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- src/libxl/libxl_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 9b258ac..e845759 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1541,7

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-08 Thread Thibault VINCENT
Hello, Any idea about this one? Not sure if it's bad or getting lost in backlog, and I'd like to see it in next release. Cheers -- Thibault -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: Properly return error from virGetUserID and virGetGroupID stubs

2015-06-08 Thread Peter Krempa
The stubs for the two functions that are compiled on platforms that don't have HAVE_GETPWUID_R and friends defined do not return error but report an error message. The calling code then assumes that the @uid or @gid arguments were filled, which is not the case in the stubs. --- This should fix

Re: [libvirt] [PATCH] util: Properly return error from virGetUserID and virGetGroupID stubs

2015-06-08 Thread Ján Tomko
On Mon, Jun 08, 2015 at 09:35:44AM +0200, Peter Krempa wrote: The stubs for the two functions that are compiled on platforms that don't have HAVE_GETPWUID_R and friends defined do not return error but report an error message. The calling code then assumes that the @uid or @gid arguments were

[libvirt] [PATCH] qemu: update netdevs of the same mac addrs correctly

2015-06-08 Thread zhang bo
If a guest has multiple network devices with the same MAC address, when we online update the second device, libvirtd always updates the first one. commit def31e4c forgot to fix the online updating scenario. We need to use virDomainNetFindIdx() to find the correct network device. Signed-off-by:

[libvirt] [PATCH 2/2] utiltest: Don't assume 'char' is always signed

2015-06-08 Thread Michal Privoznik
Not every architecture out there has 'char' signed by default. For instance, my arm box has it unsigned by default: $ gcc -dM -E - /dev/null | grep __CHAR_UNSIGNED__ #define __CHAR_UNSIGNED__ 1 Therefore, after 65c61e50 the test if failing for me. Problem is, we are trying to assign couple

Re: [libvirt] [PATCH 1/2] utils: Return proper value for virGet{User, Group}ID

2015-06-08 Thread Martin Kletzander
On Mon, Jun 08, 2015 at 10:43:38AM +0200, Michal Privoznik wrote: These two functions are used to translate user or group name into a numerical ID. Depending on platform we are building for, we have an implementation for UNIX-like systems, and a stub implementation for Windows. While the former

Re: [libvirt] [PATCH] apibuild: Fix indentation

2015-06-08 Thread Ján Tomko
On Mon, Jun 08, 2015 at 11:18:57AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark jdene...@redhat.com --- docs/apibuild.py | 48 1 file changed, 24 insertions(+), 24 deletions(-) ACK Jan signature.asc Description: Digital

Re: [libvirt] the error is bug?

2015-06-08 Thread Michal Privoznik
On 29.05.2015 16:38, cloudbuglist wrote: Hi dear! Today I came across a problem, the following is a log and software versions. soft version: os:centos 6.5 libvirt:0.10.29 qemu:0.12.415 2015-05-28 03:28:58.001+: 20919: error : qemuDomainObjBeginJobInternal:843 : Timed out during

Re: [libvirt] [PATCH 3/3] qemu: caps: Advertise arm 32-on-64 KVM option

2015-06-08 Thread Daniel P. Berrange
On Sat, Jun 06, 2015 at 07:06:42PM -0400, Cole Robinson wrote: On 05/28/2015 07:31 AM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 07:03:28PM -0400, Cole Robinson wrote: We need to use qemu-system-aarch64 to run armv7l KVM VMs on an aarch64 host. --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH 1/2] utils: Return proper value for virGet{User, Group}ID

2015-06-08 Thread Michal Privoznik
These two functions are used to translate user or group name into a numerical ID. Depending on platform we are building for, we have an implementation for UNIX-like systems, and a stub implementation for Windows. While the former returns a negative value on error, the latter simply reports an

[libvirt] [PATCH v2] utiltest: Use int8_t instead of char.

2015-06-08 Thread Michal Privoznik
Not every architecture out there has 'char' signed by default. For instance, my arm box has it unsigned by default: $ gcc -dM -E - /dev/null | grep __CHAR_UNSIGNED__ #define __CHAR_UNSIGNED__ 1 Therefore, after 65c61e50 the test if failing for me. Problem is, we are trying to assign couple

[libvirt] [PATCH 0/2] Couple of unrelated fixes

2015-06-08 Thread Michal Privoznik
*** BLURB HERE *** Michal Privoznik (2): utils: Return proper value for virGet{User,Group}ID utiltest: Don't assume 'char' is always signed src/util/virutil.c | 4 ++-- tests/utiltest.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.3.6 -- libvir-list mailing list

[libvirt] [PATCH] util: process: fix build on FreeBSD

2015-06-08 Thread Roman Bogorodskiy
Commit 825df8c3 refactored virProcess{Set,Get}Affinity routines, however broke BSD implementation because of the incorrect variable name. Fix build by using a proper variable name. Pushing as trivial and build break fix. --- src/util/virprocess.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] Canging bridge names on live migration

2015-06-08 Thread Michal Privoznik
On 03.06.2015 13:18, seitan wrote: Hello, i wonder, if there's a possibility to change a name of a shared interface in virtual machine config, while doing migration. The problem is: hypervisor1 (source) uses shared interface name br0. hypervisor2 (target) uses shared interface name br500.

Re: [libvirt] [PATCH 1/2] utils: Return proper value for virGet{User, Group}ID

2015-06-08 Thread Peter Krempa
On Mon, Jun 08, 2015 at 10:47:05 +0200, Martin Kletzander wrote: On Mon, Jun 08, 2015 at 10:43:38AM +0200, Michal Privoznik wrote: These two functions are used to translate user or group name into a numerical ID. Depending on platform we are building for, we have an implementation for

[libvirt] [PATCH] apibuild: Fix indentation

2015-06-08 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- docs/apibuild.py | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 9fa9361..18278db 100755 --- a/docs/apibuild.py +++

[libvirt] [python PATCH 2/2] Provide symbolic names for typed parameters

2015-06-08 Thread Jiri Denemark
https://bugzilla.redhat.com/show_bug.cgi?id=1222795 Signed-off-by: Jiri Denemark jdene...@redhat.com --- generator.py | 8 1 file changed, 8 insertions(+) diff --git a/generator.py b/generator.py index 676243c..2fc838c 100755 --- a/generator.py +++ b/generator.py @@ -10,6 +10,7 @@

[libvirt] [(python) PATCH 0/2] Provide symbolic names for typed parameters

2015-06-08 Thread Jiri Denemark
libvirt: Jiri Denemark (1): apibuild: Generate macro/@string attribute docs/apibuild.py | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) libvirt-python: Jiri Denemark (1): Provide symbolic names for typed parameters generator.py | 8

Re: [libvirt] [PATCH 2/2] utiltest: Don't assume 'char' is always signed

2015-06-08 Thread Peter Krempa
On Mon, Jun 08, 2015 at 10:43:39 +0200, Michal Privoznik wrote: Not every architecture out there has 'char' signed by default. For instance, my arm box has it unsigned by default: $ gcc -dM -E - /dev/null | grep __CHAR_UNSIGNED__ #define __CHAR_UNSIGNED__ 1 Therefore, after 65c61e50

[libvirt] [PATCH 1/2] apibuild: Generate macro/@string attribute

2015-06-08 Thread Jiri Denemark
If a macro has a string value, the @string attribute will contain the value. Otherwise @string attribute will be missing. For example, the following macro definition from libvirt-domain.h: /** * VIR_MIGRATE_PARAM_URI: * ... */ # define VIR_MIGRATE_PARAM_URI migrate_uri

[libvirt] poor virtio-scsi performance

2015-06-08 Thread Vasiliy Tolstov
Hi all! I suspected poor performance of virtio-scsi driver. I did a few tests: Host machine: linux 3.19.1, QEMU emulator version 2.3.0 Guest machine: linux 4.0.4 part of domain xml: emulator/usr/bin/kvm/emulator disk type='block' device='disk' driver name='qemu' type='raw'

Re: [libvirt] [PATCH v2] utiltest: Use int8_t instead of char.

2015-06-08 Thread Peter Krempa
On Mon, Jun 08, 2015 at 12:58:06 +0200, Michal Privoznik wrote: Not every architecture out there has 'char' signed by default. For instance, my arm box has it unsigned by default: $ gcc -dM -E - /dev/null | grep __CHAR_UNSIGNED__ #define __CHAR_UNSIGNED__ 1 Therefore, after 65c61e50

[libvirt] [PATCH] virNumaSetPagePoolSize: Produce friendlier error message

2015-06-08 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1224587 The function takes two important arguments (among many others): @node and @page_size. From these two a path under /sys is constructed. The path is then used to read and write the desired size of huge pages pool. However, if the path does not

Re: [libvirt] [Qemu-devel] poor virtio-scsi performance

2015-06-08 Thread Alexandre DERUMIER
Hi, if you want to use multiqueues in guest, you need to enabled it on virtio-scsi controller. controller type='scsi' index='0' model='virtio-scsi' num_queues='8'/ for example. - Mail original - De: Vasiliy Tolstov v.tols...@selfip.ru À: qemu-devel qemu-de...@nongnu.org,

[libvirt] [PATCH] schema: use arch list from basictypes for os arch attribute

2015-06-08 Thread James Cowgill
I see no reason to duplicate this list of architectures. This also allows more guest architectures to be used with libvirt (like the mips64el qemu machine I am trying to run). Signed-off-by: James Cowgill james...@cowgill.org.uk --- docs/schemas/domaincommon.rng | 26 ++

[libvirt] [PATCH] qemu: implement address for isa-serial

2015-06-08 Thread James Cowgill
I needed to specify the iobase address for certain exotic mips configurations. Signed-off-by: James Cowgill james...@cowgill.org.uk --- src/qemu/qemu_command.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

Re: [libvirt] [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently)

2015-06-08 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 06/05/15 23:47, Eric Blake wrote: On 06/05/2015 03:42 PM, Laszlo Ersek wrote: I found this qemu commit, ie. commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster arm...@redhat.com Date: Thu Mar 5 14:35:26 2015 +0100

Re: [libvirt] [PATCH 3/3] rpc: add testing of RPC JSON (de)serialization

2015-06-08 Thread Martin Kletzander
On Fri, Jun 05, 2015 at 09:47:45AM +0100, Daniel P. Berrange wrote: The virNetServer class has the ability to serialize its state to a JSON file, and then re-load that data after an in-place execve() call to re-connect to active file handles. This data format is critical ABI that must have

Re: [libvirt] [PATCH 3/3] rpc: add testing of RPC JSON (de)serialization

2015-06-08 Thread Martin Kletzander
On Fri, Jun 05, 2015 at 09:47:45AM +0100, Daniel P. Berrange wrote: The virNetServer class has the ability to serialize its state to a JSON file, and then re-load that data after an in-place execve() call to re-connect to active file handles. This data format is critical ABI that must have

Re: [libvirt] [PATCH 1/3] rpc: allow selection of TCP address family

2015-06-08 Thread Martin Kletzander
On Fri, Jun 05, 2015 at 09:47:43AM +0100, Daniel P. Berrange wrote: By default, getaddrinfo() will return addresses for both IPv4 and IPv6 if both protocols are enabled, and so the RPC code will listen/connect to both protocols too. There may be cases where it is desirable to restrict this to

[libvirt] [PATCH 1/2] docs: Adjust Disk storage rng

2015-06-08 Thread John Ferlan
Currently the grammar uses none for a valid Disk Storage Pool format type; however, virStoragePoolFormatDisk uses unknown so virt-xml-validate will fail to validate when unknown is found Signed-off-by: John Ferlan jfer...@redhat.com --- docs/schemas/storagepool.rng | 2 +- 1 file changed, 1

[libvirt] [PATCH 0/2] Fix a couple issues found with disk backend

2015-06-08 Thread John Ferlan
Validation of https://bugzilla.redhat.com/show_bug.cgi?id=1181062 raised a couple of questions about XML format and the defaults - these patches address those questions. John Ferlan (2): docs: Adjust Disk storage rng storage: Force setting of disk format type docs/schemas/storagepool.rng

[libvirt] [PATCH 2/2] storage: Force setting of disk format type

2015-06-08 Thread John Ferlan
Commit id '832a9256' adjusted the code to recognize when the default type of unknown was provided as the format type and to use dos if found. Since the pool is built with dos and it could cause some confusion when formatting the XML after building by seeing unknown in the output, let's just adjust

Re: [libvirt] [PATCH 2/3] rpc: add API for checking IPv4/6 availability

2015-06-08 Thread Martin Kletzander
On Fri, Jun 05, 2015 at 09:47:44AM +0100, Daniel P. Berrange wrote: The socket test suite has a function for checking if IPv4 or IPv6 are available, and returning a free socket. The first bit of that will be needed in another test, so pull that logic out into a separate helper method.

[libvirt] [PATCH 2/2] cmdNetworkList: Introduce --name, --uuid, --table

2015-06-08 Thread Michal Privoznik
When reviewing some network patches, I've noticed we don't have those switches to out 'net-list' command. We should. They are merely copied over from 'list' command. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-network.c | 69

[libvirt] [PATCH] qemuBuildDriveStr: s/virBufferEscapeString/virBufferAsprintf/

2015-06-08 Thread Michal Privoznik
We are using it to print a value that can't be NULL and does not need any escaping anyway. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

Re: [libvirt] [PATCH 0/2] Fix network names with quotes

2015-06-08 Thread Michal Privoznik
On 01.06.2015 10:06, Shivaprasad G Bhat wrote: The following series implements... --- Shivaprasad G Bhat (2): fix domaincommon.rng to accept network name with quotes escape quotes for dsmasq conf contents docs/schemas/domaincommon.rng |2 +-

[libvirt] [PATCH 1/2] cmdNetworkList: switch to FILTER

2015-06-08 Thread Michal Privoznik
Instead of sticking to old code pattern use the one laid out by cmdList. Use FILTER() macro instead of series of boolean variables. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-network.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-)

[libvirt] [PATCH 0/2] Introduce new net-list switches

2015-06-08 Thread Michal Privoznik
I think they might be helpful. Michal Privoznik (2): cmdNetworkList: switch to FILTER cmdNetworkList: Introduce --name, --uuid, --table tools/virsh-network.c | 93 ++- tools/virsh.pod | 7 2 files changed, 70 insertions(+), 30