Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 01:50:24PM +0300, Andrey Korolyov wrote: Hi Daniel, would it possible to adopt an optional tunable for a virCgroup mechanism which targets to a disablement of a nested (per-thread) cgroup creation? Those are bringing visible overhead for many-threaded guest

Re: [libvirt] [PATCH 0/8] logically memory hotplug via guest agent

2015-06-11 Thread Jiri Denemark
On Thu, Jun 11, 2015 at 09:38:24 +0800, zhang bo wrote: On 2015/6/10 17:31, Daniel P. Berrange wrote: On Wed, Jun 10, 2015 at 10:28:08AM +0100, Daniel P. Berrange wrote: On Wed, Jun 10, 2015 at 05:24:50PM +0800, zhang bo wrote: On 2015/6/10 16:39, Vasiliy Tolstov wrote: 2015-06-10

Re: [libvirt] [PATCH] add some more missing libvirt functions

2015-06-11 Thread Vasiliy Tolstov
10 июня 2015 г. 16:00 пользователь Michal Privoznik mpriv...@redhat.com написал: On 10.06.2015 10:18, Vasiliy Tolstov wrote: * libvirt_connect_get_all_domain_stats * libvirt_domain_block_resize * libvirt_domain_block_job_abort * libvirt_domain_block_job_set_speed Signed-off-by:

[libvirt] [PATCH] virfile: Report useful error fork approach to create NFS mount point fails

2015-06-11 Thread Erik Skultety
Commit 92d9114e tweaked the way we handle child errors when using fork approach to set specific permissions. The same logic should be used to create directories with specified permissions as well, otherwise the parent process doesn't report any useful error unknown cause while still returning

Re: [libvirt] [PATCH 1/2] apibuild: Generate macro/@string attribute

2015-06-11 Thread Peter Krempa
On Mon, Jun 08, 2015 at 11:34:35 +0200, Jiri Denemark wrote: If a macro has a string value, the @string attribute will contain the value. Otherwise @string attribute will be missing. For example, the following macro definition from libvirt-domain.h: /** * VIR_MIGRATE_PARAM_URI: *

Re: [libvirt] [python PATCH 2/2] Provide symbolic names for typed parameters

2015-06-11 Thread Peter Krempa
On Mon, Jun 08, 2015 at 11:34:36 +0200, Jiri Denemark wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1222795 Signed-off-by: Jiri Denemark jdene...@redhat.com --- generator.py | 8 1 file changed, 8 insertions(+) ACK, Peter signature.asc Description: Digital signature --

[libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Andrey Korolyov
Hi Daniel, would it possible to adopt an optional tunable for a virCgroup mechanism which targets to a disablement of a nested (per-thread) cgroup creation? Those are bringing visible overhead for many-threaded guest workloads, almost 5% in non-congested host CPU state, primarily because the host

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Andrey Korolyov
On Thu, Jun 11, 2015 at 2:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 01:50:24PM +0300, Andrey Korolyov wrote: Hi Daniel, would it possible to adopt an optional tunable for a virCgroup mechanism which targets to a disablement of a nested (per-thread) cgroup

Re: [libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

2015-06-11 Thread Peter Krempa
On Wed, Jun 10, 2015 at 15:18:15 -0600, Eric Blake wrote: On 06/10/2015 09:27 AM, John Ferlan wrote: So there are basically three options: 1) Silence the coverity warning So on line just prior to CPU_ISSET_S either: sa_assert(sizeof(unsigned long int) == sizeof(cpu_set_t)); Is

Re: [libvirt] [RFC] get guest OS infos

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 09:17:30AM +0100, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 01:51:33PM +0800, zhang bo wrote: Different OSes have different capabilities and behaviors sometimes. We have to distinguish them then. For example, our clients want to send NMI interrupts to

Re: [libvirt] question about virConnectGetAllDomainStats and virTypedParameter

2015-06-11 Thread Vasiliy Tolstov
10 июня 2015 г. 17:15 пользователь Michal Privoznik mpriv...@redhat.com написал: On 10.06.2015 08:52, Vasiliy Tolstov wrote: I'm try to implement virConnectGetAllDomainStats for php binding api, but have one issue with VIR_TYPED_PARAM_STRING: code part: retval =

Re: [libvirt] [PATCH 0/8] logically memory hotplug via guest agent

2015-06-11 Thread Vasiliy Tolstov
2015-06-11 11:42 GMT+03:00 Jiri Denemark jdene...@redhat.com: Such guests would need an update qemu-guest-agent anyway. And installing a new version of qemu-guest-agent is not any easier than installing an updated udev or a new udev rule. That is, I don't think the qemu-guest-agent way has any

[libvirt] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Frediano Ziglio
Allow to specify maximum number of head to QXL driver. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 +++

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 10:27:05AM +0200, Michal Privoznik wrote: On 11.06.2015 10:13, Daniel P. Berrange wrote: On Wed, Jun 10, 2015 at 09:20:40PM +, Vivi L wrote: Michal Privoznik mprivozn at redhat.com writes: On 10.06.2015 01:05, Vivi L wrote: Kashyap Chamarthy kchamart at

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Michal Privoznik
On 11.06.2015 10:48, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 10:27:05AM +0200, Michal Privoznik wrote: On 11.06.2015 10:13, Daniel P. Berrange wrote: On Wed, Jun 10, 2015 at 09:20:40PM +, Vivi L wrote: Michal Privoznik mprivozn at redhat.com writes: On 10.06.2015 01:05, Vivi L

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 02:16:50PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 01:50:24PM +0300, Andrey Korolyov wrote: Hi Daniel, would it possible to adopt an optional tunable for a virCgroup

Re: [libvirt] [PATCH v2 0/2] lxc: properly clean up qemu-nbd

2015-06-11 Thread Daniel P. Berrange
On Wed, Jun 10, 2015 at 04:08:41PM -0400, John Ferlan wrote: On 06/01/2015 09:01 AM, Cédric Bosdonnat wrote: Hi all, Here is the very same patch, but split in two patches. Well, I also moved two comments around between v1 and v2. Cédric Bosdonnat (2): Add virProcessGetPids

Re: [libvirt] [Spice-devel] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Christophe Fergeau
Hey, On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote: Allow to specify maximum number of head to QXL driver. I've tested this with an older qemu without qxl-vga.max_outputs, and with a newer one with support for it, and in both cases this is doing the right thing.

Re: [libvirt] [Spice-devel] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Christophe Fergeau
On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote: Actually can be a compatiblity problem as heads in the XML configuration was set by default to '1'. Yes, this bit is worrying, the old behaviour could be considered as buggy as the XML contained '1' but the number of heads was

Re: [libvirt] [PATCH] schema: use arch list from basictypes for os arch attribute

2015-06-11 Thread Michal Privoznik
On 08.06.2015 15:42, James Cowgill wrote: I see no reason to duplicate this list of architectures. This also allows more guest architectures to be used with libvirt (like the mips64el qemu machine I am trying to run). Signed-off-by: James Cowgill james...@cowgill.org.uk ---

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Clarylin L
On Thu, Jun 11, 2015 at 12:00 AM, Michal Privoznik mpriv...@redhat.com wrote: [please keep the list CC'ed] On 10.06.2015 20:09, Clarylin L wrote: Hi Michal, Thanks a lot. If 100 hugepages are pre-allocated, the guest can start without decreasing number of hugepages. Since the

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Clarylin L
Hi Michal, I also tried the other option you mentioned The other option you have is to not use guest NUMA nodes, in which case global -mem-path can be used. by removing from xml numatune memory mode='strict' nodeset='0-1'/ /numatune while keeping older qemu-1.5.3 which does not

Re: [libvirt] [PATCH] network: add an option to make dns public

2015-06-11 Thread Laine Stump
On 06/10/2015 03:56 PM, John Ferlan wrote: On 06/01/2015 07:54 AM, Cédric Bosdonnat wrote: In some use cases we don't want the virtual network's DNS to only listen to the vnet interface. Adding a publiclyAccessible attribute :-) Really, that name was only intended as a placeholder! I was

Re: [libvirt] [PATCH] lxc / docker containers gives option to inherit the namespaces. Example lxc-start has option [ --share-[net|ipc|uts] name|pid ] where --share-net name|pid means Inherit a network

2015-06-11 Thread Michal Privoznik
On 21.05.2015 19:43, ik.nitk wrote: This patch tries to add the similar option to libvirt lxc. So to inherit namespace from name container c2. add this into xml. lxc:namespace sharenet type='name' value='c2'/ /lxc:namespace And to inherit namespace from a pid.

[libvirt] [PATCH] parallels: implement attach/detach network.

2015-06-11 Thread Mikhail Feoktistov
Support nova commands interface-attach and interface-detach. For containers only. I use memcmp() to compare MAC addresses, because PrlVmDevNet_GetMacAddress() returns MAC as a UTF-8 encoded, null-terminated string. --- src/parallels/parallels_driver.c | 16 src/parallels/parallels_sdk.c

Re: [libvirt] [PATCH v2 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-11 Thread John Ferlan
On 06/04/2015 01:04 PM, Martin Kletzander wrote: The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the capability at all and leave

Re: [libvirt] [RFC] get guest OS infos

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 08:47:12AM -0500, Dennis Jenkins wrote: On Thu, Jun 11, 2015 at 3:51 AM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 09:17:30AM +0100, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 01:51:33PM +0800, zhang bo wrote: Different OSes

Re: [libvirt] [PATCH v2 4/4] qemu: add multiqueue vhost-user support

2015-06-11 Thread John Ferlan
On 06/04/2015 01:04 PM, Martin Kletzander wrote: From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac address='52:54:00:ee:96:6d'/ source

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Andrey Korolyov
On Thu, Jun 11, 2015 at 2:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 02:16:50PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 01:50:24PM +0300, Andrey Korolyov wrote: Hi

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 04:06:59PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 02:16:50PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:09 PM, Daniel P. Berrange berra...@redhat.com wrote:

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 04:24:18PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 4:13 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 04:06:59PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:33 PM, Daniel P. Berrange berra...@redhat.com wrote:

Re: [libvirt] [(python) PATCH 0/2] Provide symbolic names for typed parameters

2015-06-11 Thread Jiri Denemark
On Mon, Jun 08, 2015 at 11:34:34 +0200, Jiri Denemark wrote: libvirt: Jiri Denemark (1): apibuild: Generate macro/@string attribute docs/apibuild.py | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) libvirt-python: Jiri

Re: [libvirt] [sandbox PATCH 1/3] Add an utility function for guessing filetype from file extension

2015-06-11 Thread Daniel P. Berrange
On Wed, Jun 10, 2015 at 01:40:08PM +0200, Eren Yagdiran wrote: Consider the file name extension as the image type, except for .img that are usually RAW images --- libvirt-sandbox/Makefile.am| 1 + libvirt-sandbox/libvirt-sandbox-util.c | 79 ++

Re: [libvirt] [RFC] get guest OS infos

2015-06-11 Thread Dennis Jenkins
On Thu, Jun 11, 2015 at 3:51 AM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 09:17:30AM +0100, Daniel P. Berrange wrote: On Thu, Jun 11, 2015 at 01:51:33PM +0800, zhang bo wrote: Different OSes have different capabilities and behaviors sometimes. We have to

Re: [libvirt] [PATCH v2 0/4] Add support for vhost-user with multi-queue

2015-06-11 Thread John Ferlan
On 06/04/2015 01:04 PM, Martin Kletzander wrote: Also some tiny clean-up. Martin Kletzander (2): conf: Ignore multiqueue with one queue. qemu: Add capability for vhost-user multiqueue Maxime Leroy (2): docs: Clarify that attribute name is not used for vhostuser qemu: add

[libvirt] [PATCH] maint: Remove control characters from LGPL license file

2015-06-11 Thread Andrea Bolognani
--- COPYING.LESSER | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/COPYING.LESSER b/COPYING.LESSER index 4362b49..e5ab03e 100644 --- a/COPYING.LESSER +++ b/COPYING.LESSER @@ -55,7 +55,7 @@ modified by someone else and passed on, the recipients should know

Re: [libvirt] Overhead for a default cpu cg placement scheme

2015-06-11 Thread Andrey Korolyov
On Thu, Jun 11, 2015 at 4:13 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 04:06:59PM +0300, Andrey Korolyov wrote: On Thu, Jun 11, 2015 at 2:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 11, 2015 at 02:16:50PM +0300, Andrey Korolyov wrote: On

Re: [libvirt] [sandbox PATCH 2/3] Add configuration object for disk support

2015-06-11 Thread Daniel P. Berrange
On Wed, Jun 10, 2015 at 01:40:09PM +0200, Eren Yagdiran wrote: Add the config gobject, functions to store and load the new configuration fragments and test. This will allow creating sandboxes with attached disk with a parameter formatted like file:hda=/source/file.qcow2,format=qcow2 +/** + *

[libvirt] [PATCH] scsi: Need to translate disk source pool in config attach path

2015-06-11 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1228007 When attaching a scsi volume lun via the attach-device --config or --persistent options, there was no translation of the source pool like there was for the live path, thus the attempt to modify the config would fail since not enough was known

[libvirt] Accessing libvirtd remotely as non-root user

2015-06-11 Thread Dan Mossor
I manage libvirtd on a few remote machines, and my security policies require me to disable root login via SSH. Up to this point, I've been using root due to the systems being in staging, but this is the final step before they're moved to production. What is the current proscribed method of

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Clarylin L
With older qemu-1.5.3, I can start the guest by removing the following lines from the xml config file and hugepages are correctly used. numa cell id='0' cpus='0-15' memory='67108864'/ cell id='1' cpus='16-31' memory='67108864'/ /numa I believe these lines were used to

[libvirt] [PATCH v2 2/2] lxc: properly clean up qemu-nbd

2015-06-11 Thread Cédric Bosdonnat
Add the qemu-nbd tasks to the container cgroup to make sure those will be killed when the container is stopped. In order to reliably get the qemu-nbd tasks PIDs, we use /sys/devices/virtual/block/DEV/pid as qemu-nbd is daemonizing itself. --- src/lxc/lxc_controller.c | 56

[libvirt] [PATCH v2 1/2] Introduce QEMU_CAPS_ARM_VIRT_PCI

2015-06-11 Thread Pavel Fedin
This capability specifies that virt machine on ARM has PCI controller. Enabled when version is at least 2.3.0. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 6 insertions(+) diff --git

[libvirt] [PATCH v2 0/2] Allow PCI virtio on ARM virt machine

2015-06-11 Thread Pavel Fedin
Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt still insists on virtio devices attached to virt machine to have MMIO bindings. This patch

[libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

2015-06-11 Thread Pavel Fedin
Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0a6d92f..2acdc6a 100644 --- a/src/qemu/qemu_command.c +++

Re: [libvirt] [PATCH v3 00/24] Add support for migration events

2015-06-11 Thread Jiri Denemark
On Wed, Jun 10, 2015 at 11:16:29 -0400, John Ferlan wrote: On 06/10/2015 11:06 AM, Jiri Denemark wrote: On Wed, Jun 10, 2015 at 10:27:11 -0400, John Ferlan wrote: On 06/10/2015 09:42 AM, Jiri Denemark wrote: QEMU will soon (patches are available on qemu-devel) get support for

[libvirt] [PATCH v2 1/2] Add virProcessGetPids to get all tasks of a process

2015-06-11 Thread Cédric Bosdonnat
This function gets all the PIDs listed in /proc/PID/task. This will be needed at least to move all qmeu-nbd tasks to the container cgroup. --- src/libvirt_private.syms | 1 + src/util/virprocess.c| 47 +++ src/util/virprocess.h| 2 ++ 3 files

[libvirt] [PATCH v2 0/2] qemu-nbd cleanup, resent

2015-06-11 Thread Cédric Bosdonnat
Hi all, Note: I'm just resending this as the patches somehow never landed on the mailing list. Here is the very same patch, but split in two patches. Well, I also moved two comments around between v1 and v2. Cédric Bosdonnat (2): Add virProcessGetPids to get all tasks of a process lxc:

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Michal Privoznik
[please keep the list CC'ed] On 10.06.2015 20:09, Clarylin L wrote: Hi Michal, Thanks a lot. If 100 hugepages are pre-allocated, the guest can start without decreasing number of hugepages. Since the guest requires 128 hugepages, it's kind of expected that the guest would not take memory

Re: [libvirt] [PATCH] network: add an option to make dns public

2015-06-11 Thread Cedric Bosdonnat
On Wed, 2015-06-10 at 15:56 -0400, John Ferlan wrote: On 06/01/2015 07:54 AM, Cédric Bosdonnat wrote: In some use cases we don't want the virtual network's DNS to only listen to the vnet interface. Adding a publiclyAccessible attribute to the dns element in the configuration allows the

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Daniel P. Berrange
On Wed, Jun 10, 2015 at 09:20:40PM +, Vivi L wrote: Michal Privoznik mprivozn at redhat.com writes: On 10.06.2015 01:05, Vivi L wrote: Kashyap Chamarthy kchamart at redhat.com writes: You might want re-test by explicitly setting the 'page' element and 'size' attribute?

Re: [libvirt] [RFC] get guest OS infos

2015-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2015 at 01:51:33PM +0800, zhang bo wrote: Different OSes have different capabilities and behaviors sometimes. We have to distinguish them then. For example, our clients want to send NMI interrupts to certain guests(eg.Linux distributions), but not others(eg.Windows

Re: [libvirt] Problem with setting up KVM guests to use HugePages

2015-06-11 Thread Michal Privoznik
On 11.06.2015 10:13, Daniel P. Berrange wrote: On Wed, Jun 10, 2015 at 09:20:40PM +, Vivi L wrote: Michal Privoznik mprivozn at redhat.com writes: On 10.06.2015 01:05, Vivi L wrote: Kashyap Chamarthy kchamart at redhat.com writes: You might want re-test by explicitly setting the

Re: [libvirt] [RFC] get guest OS infos

2015-06-11 Thread Michal Privoznik
On 11.06.2015 07:51, zhang bo wrote: Different OSes have different capabilities and behaviors sometimes. We have to distinguish them then. For example, our clients want to send NMI interrupts to certain guests(eg.Linux distributions), but not others(eg.Windows guests). They want to