Re: [libvirt] [PATCH] Load nbd module before running qemu-nbd

2015-07-29 Thread Daniel P. Berrange
On Mon, Jul 20, 2015 at 05:46:45PM +0200, Cédric Bosdonnat wrote: So far qemu-nbd is run even if the nbd kernel module isn't loaded. This leads to errors when the user starts his lxc container while libvirt could easily load the nbd module automatically. --- src/util/virfile.c | 28

Re: [libvirt] unsupported configuration: unknown video model 'virtio' - virtio-vga

2015-07-29 Thread Daniel P. Berrange
On Mon, Jul 20, 2015 at 03:38:59PM +0200, Martin Kletzander wrote: On Mon, Jul 20, 2015 at 11:23:02AM +0200, poma wrote: $ qemu-system-x86_64 ... -device virtio-vga # lspci -d 1af4:1050 -knn 00:03.0 VGA compatible controller [0300]: Red Hat, Inc Device [1af4:1050] (rev 01)

Re: [libvirt] [sandbox PATCH 00/11] Virt-sandbox-image

2015-07-29 Thread Daniel P. Berrange
On Thu, Jul 23, 2015 at 03:57:26PM +, Eren Yagdiran wrote: Hello, virt-sandbox-image.py is a python script that lets you download and run templates from supported sources using virt-sandbox. Component-based archictecture is accomplished through Source base class. Docker image support

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-29 Thread Jim Fehlig
On 07/20/2015 09:28 AM, Olaf Hering wrote: On Thu, Jul 16, Jim Fehlig wrote: @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); +virObjectUnref(args); This is now below the 'error' label, so args has to

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-29 Thread Jim Fehlig
On 07/29/2015 04:07 PM, Jim Fehlig wrote: On 07/20/2015 09:28 AM, Olaf Hering wrote: On Thu, Jul 16, Jim Fehlig wrote: @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); +virObjectUnref(args); This is

Re: [libvirt] [PATCH v10 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-29 Thread John Ferlan
On 07/29/2015 07:17 AM, Andrea Bolognani wrote: From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the

[libvirt] [PATCH] virsh: fix no error when pass a count = 0 to setvcpus

2015-07-29 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1248277 When count = 0, the client exit without set an error. Signed-off-by: Luyao Huang lhu...@redhat.com --- tools/virsh-domain.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c

Re: [libvirt] [PATCH] qemu: Adjust VM id allocation

2015-07-29 Thread Erik Skultety
On 28/07/15 17:49, Daniel P. Berrange wrote: On Tue, Jul 28, 2015 at 05:41:25PM +0200, Erik Skultety wrote: Our atomic increment (virAtomicIntInc) uses (if available) gcc __sync_add_and_fetch builtin. In qemu driver though, we'd profit more from __sync_fetch_and_add builtin. To keep it

Re: [libvirt] [PATCH v8 0/5] nodeinfo: Add support for subcores

2015-07-29 Thread Shivaprasad bhat
Thanks for adding new test cases and the rework Andrea. I have reviewed all the paches and find them good except in Patch 1 where I am leaving a comment. Test results are good. The nodeinfo behaviour on a Power host with all subcores-per-core mode settings http://ur1.ca/naalk The nodeinfo

Re: [libvirt] Development Examples

2015-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2015 at 07:23:41AM +0400, Kevin Walker wrote: Hi All I am trying to get up to speed with developing with libvirt. Can anyone provide some good examples in C of how to gather statistics from domains, network and storage? The dev guide just has TBD for these items There

[libvirt] [PATCH v9 0/5] nodeinfo: Add support for subcores

2015-07-29 Thread Andrea Bolognani
Only patch 1/5 has been updated, all the other patches are the same as v8: 2/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01045.html 3/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01048.html 4/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01049.html

[libvirt] [PATCH v9 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-29 Thread Andrea Bolognani
From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm

Re: [libvirt] [PATCH] remove redundant code

2015-07-29 Thread Cao jin
Ping On 07/23/2015 06:16 PM, Cao jin wrote: Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 4f30b15..15ba39b 100644 --- a/src/qemu/qemu_monitor.c +++

Re: [libvirt] [PATCH v8 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-29 Thread Andrea Bolognani
On Wed, 2015-07-29 at 13:12 +0530, Shivaprasad bhat wrote: +#if HAVE_LINUX_KVM_H defined(KVM_CAP_PPC_SMT) +if (ARCH_IS_PPC64(arch)) { + +kvmfd = open(/dev/kvm, O_RDONLY); +if (kvmfd 0) { +threads_per_subcore = -1; Its okay for a guest to not have

[libvirt] [PATCH] There is no virDomainFindBy{ID, Name, UUID} anymore

2015-07-29 Thread Cao jin
s/virDomainFindBy/virDomainObjListFindBy/ Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/THREADS.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/THREADS.txt b/src/qemu/THREADS.txt index f3502b4..22d590e 100644 --- a/src/qemu/THREADS.txt +++

Re: [libvirt] [PATCH v8 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-29 Thread Shivaprasad bhat
On Mon, Jul 27, 2015 at 1:38 PM, Andrea Bolognani abolo...@redhat.com wrote: From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core

Re: [libvirt] [PATCH 0/4] manage the shmem device source

2015-07-29 Thread lhuang
On 07/28/2015 12:05 AM, Daniel P. Berrange wrote: On Mon, Jul 27, 2015 at 03:40:36PM +0100, Daniel P. Berrange wrote: On Mon, Jul 27, 2015 at 04:09:01PM +0200, Marc-André Lureau wrote: Hi Luyao On Thu, Jul 23, 2015 at 12:13 PM, Luyao Huanglhu...@redhat.com wrote: But the problem is we

[libvirt] [PATCH v10 0/5] nodeinfo: Add support for subcores

2015-07-29 Thread Andrea Bolognani
Only patch 1/5 has been updated, all the other patches are the same as v8: 2/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01045.html 3/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01048.html 4/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01049.html

[libvirt] [PATCH v10 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-29 Thread Andrea Bolognani
From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm

Re: [libvirt] [PATCH 0/2] Disable floppy disk for PowerPC VMs

2015-07-29 Thread Andrea Bolognani
On Fri, 2015-07-24 at 15:29 -0400, Kothapally Madhu Pavan wrote: This is an attempt to fix: Libvirt BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Libvirt currently assumes ISA_based floppy disks to be available across all architectures and machine types. However, PowerPC Book 3S