https://bugzilla.redhat.com/show_bug.cgi?id=1250287
When run domfsinfo in quiet mode, we cannot get any
useful information (just get \n), this is because
we didn't use vshPrint to print useful information.
Signed-off-by: Luyao Huang
---
tools/virsh-domain.c | 6 +++---
1 file changed, 3 inserti
$SUBJ
s/pining/pinning
Or perhaps - "qemu: Use numad information when getting pin information""
On 07/26/2015 12:57 PM, Martin Kletzander wrote:
> Pinning information returned for emulatorpin and vcpupin calls is being
> returned from our data without querying cgroups for some time. However,
>
I was just recently told I should try using virtio-scsi on arm64 -- that
QEMU 2.4.0 has everything needed for block device hotplug on arm64 using
virtio-scsi. I see that nova appears to have support as of Feb 2014 (
https://review.openstack.org/#/c/70263/). I am currently using the
distro-provide
Any custom source provider can be added to virt-sandbox-image as a source
---
.gitignore | 1 +
bin/Makefile.am | 16
bin/virt-sandbox-image.in| 3 +++
configure.ac | 2 ++
virt-s
From: Daniel P Berrange
virt-sandbox-image.py is a python script that lets you download Docker
images easily. It is a proof of concept code and consumes Docker Rest API.
---
po/POTFILES.in | 1 +
virt-sandbox-image/virt-sandbox-image.py | 394 +
Any custom key=value pair can be used as a custom environment variable
in virt-sandbox-image.
e.g virt-sandbox-image run ubuntu /var/lib/libvirt/templates -c lxc:/// -i
/bin/bash -e key1=val1
---
virt-sandbox-image/sources/DockerSource.py | 10 ++
virt-sandbox-image/sources/Source.py
Provide a way to know how a template can be started depending on the used source
DockerSource will need to parse the topmost config file in order to find the
igniter command
---
virt-sandbox-image/sources/DockerSource.py | 14 ++
virt-sandbox-image/sources/Source.py | 4
2
Refactoring delete function from virt-sandbox-image to DockerSource. Delete
function
can delete templates by name.
---
virt-sandbox-image/sources/DockerSource.py | 53 +++
virt-sandbox-image/sources/Source.py | 4 ++
virt-sandbox-image/virt-sandbox-image.py | 59 +
Allow users to add custom environment variables to their sandbox.
---
bin/virt-sandbox.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
index 195515f..e90b698 100644
--- a/bin/virt-sandbox.c
+++ b/bin/virt-sandbox.c
@@ -64,6 +64,7 @@ int
Move the docker-related code to the DockerSource and use
the Source mechanism
---
virt-sandbox-image/sources/DockerSource.py | 100 +
virt-sandbox-image/sources/Source.py | 4 ++
virt-sandbox-image/virt-sandbox-image.py | 70
3 files chan
"make check" now includes testcase for environment variables
---
libvirt-sandbox/tests/test-config.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libvirt-sandbox/tests/test-config.c
b/libvirt-sandbox/tests/test-config.c
index da05187..ac10bab 100644
--- a/libvirt-sandbox/tests/
Refactor download function from virt-sandbox-image to use
the newly introduced Source abstract class. The docker-specific
download code is moved to a new DockerSource class.
---
virt-sandbox-image/Makefile.am | 1 +
virt-sandbox-image/sources/DockerSource.py | 227 +++
Authentication fix for Docker REST API.
---
virt-sandbox-image/virt-sandbox-image.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index 4f5443b..a9cb0ff 100644
--- a/virt-sandbox-
Volumes let user to map host-paths into guest. Docker containers need volumes
because its
filesystem read-only by default.
---
virt-sandbox-image/sources/DockerSource.py | 12
virt-sandbox-image/sources/Source.py | 4
virt-sandbox-image/virt-sandbox-image.py | 22 ++
---
bin/Makefile.am| 5 ++
bin/virt-sandbox-image.pod | 172 +
2 files changed, 177 insertions(+)
create mode 100644 bin/virt-sandbox-image.pod
diff --git a/bin/Makefile.am b/bin/Makefile.am
index df4c7dc..5d7ff8a 100644
--- a/bin/Makefil
Common-init reads config file and export custom environment
variables from config file and apply them to the running sandbox.
---
libvirt-sandbox/libvirt-sandbox-init-common.c | 30 +++
1 file changed, 30 insertions(+)
diff --git a/libvirt-sandbox/libvirt-sandbox-init-comm
Run an already-built template
If there is no execution command specified by user, source.get_command will
find the command to invoke
---
virt-sandbox-image/virt-sandbox-image.py | 24
1 file changed, 24 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
Check if user-specified connect argument is valid
---
virt-sandbox-image/virt-sandbox-image.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index feee849..4c19fa8 100755
--- a/virt-sandbox-image/virt-
Commandline parameters for running a template
---
virt-sandbox-image/virt-sandbox-image.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index ea7ab02..feee849 100755
--- a/virt-sandbox-image/
Add the config gobject to store custom environment variables.
This will allow creating custom environment variables on a sandbox
with a parameter formatted like --env key1=val1
---
libvirt-sandbox/Makefile.am | 2 +
libvirt-sandbox/libvirt-sandbox-config-all.h | 1 +
libvirt-s
Virt-sandbox-image will pass exact network arguments to virt-sandbox
---
virt-sandbox-image/virt-sandbox-image.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index e20ce22..5fc
virt-sandbox-image.py is a python script that lets you download and run
templates
from supported sources using virt-sandbox.
Component-based archictecture is accomplished through Source base class.
Docker image support is added through DockerSource.
DockerSource is capable of downloading and runni
Provide a way to know which disk image to use for the sandbox depending on the
used source
DockerSource will need to locate the topmost disk image among all the layers
images
---
virt-sandbox-image/sources/DockerSource.py | 9 +
virt-sandbox-image/sources/Source.py | 4
2 file
On 08/04/2015 11:42 AM, Michal Privoznik wrote:
> On 04.08.2015 13:11, John Ferlan wrote:
>> The recent changes to perform SCSI device address checks during the
>> post parse callbacks ran afoul of the Coverity checker since the changes
>> assumed that the 'xmlopt' parameter to virDomainDeviceDef
On 04.08.2015 13:11, John Ferlan wrote:
> The recent changes to perform SCSI device address checks during the
> post parse callbacks ran afoul of the Coverity checker since the changes
> assumed that the 'xmlopt' parameter to virDomainDeviceDefPostParse
> would be non NULL (commit id 'ca2cf74e87');
On 07/31/2015 07:35 PM, Maxim Perevedentsev wrote:
Such messages do not have NLMSG_ERROR or NLMSG_DONE type
but they are valid responses. We test 'multi-partness'
by looking for NLM_F_MULTI flag.
This patch looks OK to me except for comment style.
---
src/util/virnetlink.c | 4 +++-
1 file
On 07/31/2015 07:35 PM, Maxim Perevedentsev wrote:
This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970
dnsmasq main process exits without waiting for DAD, this is dnsmasq
daemon's task. So we periodically poll the kernel using netlink and
check whether there are any IPv6 addresses a
On Tue, Aug 04, 2015 at 05:01:26PM +0200, Jiri Denemark wrote:
> Creating ACL rules is not exactly easy and existing examples are pretty
> simple. This patch adds a somewhat complex example which defines three
> roles (user, operator, admin) with different permissions.
>
> +/* Basic operations an
Creating ACL rules is not exactly easy and existing examples are pretty
simple. This patch adds a somewhat complex example which defines three
roles (user, operator, admin) with different permissions.
Signed-off-by: Jiri Denemark
---
Makefile.am | 2 +-
configure.ac
On 20.07.2015 15:50, Daniel P. Berrange wrote:
> On Wed, Jul 15, 2015 at 03:02:13PM +0200, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1124841
>>
>> When the daemon is running under unprivileged user, that is under
>> qemu:///session, there are plenty of operations we can
On 04.08.2015 14:31, Vasiliy Tolstov wrote:
> 2015-08-03 10:01 GMT+03:00 Michal Privoznik :
>> There has not been much movement in that particular area since 1.2.16.
>> There's inherent race though: by the time that libvirt detects that a
>> certain port is free and qemu binds to it. During this wi
On 08/03/2015 09:57 AM, Ján Tomko wrote:
> On Wed, Jul 22, 2015 at 10:54:34AM -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed)
>>
>> When generating the default drive address for a SCSI device,
>> check the generated address to ensure it doesn't confl
2015-08-03 10:01 GMT+03:00 Michal Privoznik :
> There has not been much movement in that particular area since 1.2.16.
> There's inherent race though: by the time that libvirt detects that a
> certain port is free and qemu binds to it. During this window another
> process may just allocate the port
On 07/18/2015 07:43 AM, John Ferlan wrote:
> Resolve a couple of issues regarding failures seen configuring a disk
> to be a type='volume' device='lun'. The doc patch just indicates that
> using an NPIV storage/source pool is a valid option. The second patch
> allows for a "clearer" error messag
finally, I have found that it is ovs bug.
when reboot vm, libvirt will call ovs-vsctl del-port,
this cmd will cause other port's tc ingress rule automatically remove.
http://openvswitch.org/pipermail/discuss/2015-July/018318.html
I have reported a bug for ovs, and they have admitted it.
anyway
In gnutls 3.4.3 there is a regression in the loading of private
keys via gnutls_x509_privkey_import. We already have a workaround
to deal with failures on older gnutls, but the error code that
the new gnutls returns is different. Extend the workaround so that
is checks for GNUTLS_E_REQUESTED_DATA_N
The recent changes to perform SCSI device address checks during the
post parse callbacks ran afoul of the Coverity checker since the changes
assumed that the 'xmlopt' parameter to virDomainDeviceDefPostParse
would be non NULL (commit id 'ca2cf74e87'); however, what was missed
is there was an "if (x
Hello! Can anybody tell me what is wrong with this? Ignored for a long time.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
> On Behalf Of Pavel
> F
On Mon, Aug 03, 2015 at 11:27:56PM +0530, madhu pavan wrote:
>
>
> On 08/03/2015 06:23 PM, Ján Tomko wrote:
> > On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote:
> >> PowerPC pseries based VMs do not support a floppy disk controller.
> > Here the commit message mentions a co
The code currently assumes that the mask will be 0x, which
is not always the case - it is for the models listed so far, though.
---
src/cpu/cpu_map.xml | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index b3c4477
This is yet another variation of POWER8. The PVR information comes
from arch/powerpc/kernel/cputable.c in the Linux kernel tree.
---
src/cpu/cpu_map.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index 0895ada..d2469ee 100644
--- a/src/cpu/cpu_map
New test cases cover the cpuCompare() and cpuBaseline() implementation.
---
tests/cputest.c | 10 ++
tests/cputestdata/ppc64-baseline-incompatible-models.xml | 14 ++
tests/cputestdata/ppc64-baseline-same-model-result.xml | 3 +++
tes
This ensures comparison of two CPU definitions will be consistent
regardless of the fact that it is performed using cpuCompare() or
cpuGuestData(). The x86 driver uses the same exact code.
---
src/cpu/cpu_ppc64.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff -
Instead of relying on a hard-coded mask value, read it from the CPU
map XML and use it when looking up models by PVR.
Rewrite ppc64DriverNodeData() to use this feature.
---
src/cpu/cpu_ppc64.c | 74
src/cpu/cpu_ppc64_data.h | 1 +
2 files cha
While the previous code was correct, it looked wrong at first
sight because the same variable used to store the result of a
map lookup is later used to store a copy of said result. The
copy is deallocated on error, but due to the fact that a single
variable is used, it looks like the result of the
Limitations of the POWER architecture mean that you can't run
eg. a POWER7 guest on a POWER8 host when using KVM. This applies
to all guests, not just those using VIR_CPU_MATCH_STRICT in the
CPU definition; in fact, exact and strict CPU matching are
basically the same on ppc64.
This means, of cour
Use the ppc64Driver prefix for all functions that are used to
fill in the cpuDriverPPC64 structure, ie. those that are going
to be called by the generic CPU code.
This makes it clear which functions are exported and which are
implementation details; it also gets rid of the ambiguity that
affected
This will allow us to perform PVR matching more broadly, eg. consider
both POWER8 and POWER8E CPUs to be the same even though they have
different PVR values.
---
src/cpu/cpu_ppc64.c | 73
src/cpu/cpu_ppc64_data.h | 8 +-
2 files changed, 6
Fix a test case that was wrongly expected to fail as well.
---
tests/cputest.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tests/cputest.c b/tests/cputest.c
index 06b3f12..5b7de0f 100644
--- a/tests/cputest.c
+++ b/tests/cputest.c
@@ -273,13 +273,8 @
The information is not used anywhere in libvirt.
No functional changes.
---
src/cpu/cpu_map.xml | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index b924bd3..6387ce4 100644
--- a/src/cpu/cpu_map.xml
+++ b/src/cpu/cpu_map.xml
@@ -1385,31 +1385,26
---
src/cpu/cpu_ppc64.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 05ff8f2..dd02a3f 100644
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -115,6 +115,9 @@ ppc64ModelCopy(const struct ppc64_model *model)
{
struct ppc64_model
Having the functions grouped together this way will avoid further
shuffling around down the line.
No functional changes.
---
src/cpu/cpu_ppc64.c | 135 +---
1 file changed, 66 insertions(+), 69 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cp
Use briefer checks, eg. (!model) instead of (model == NULL), and
avoid initializing to NULL a pointer that would be assigned in
the first line of the function anyway.
Also remove a pointless NULL assignment.
No functional changes.
---
src/cpu/cpu_ppc64.c | 33 -
1
Use multiple PVRs per CPU model to reduce the number of models we
need to keep track of.
Remove specific CPU models (eg. POWER7+_v2.1): the corresponding
generic CPU model (eg. POWER7) should be used instead to ensure
the guest can be booted on any compatible host.
Get rid of all the entries that
ppc64Compute(), called by cpuNodeData(), is used not only to retrieve
the driver-specific data associated to a guest CPU definition, but
also to check whether said guest CPU is compatible with the host CPU.
If the user is not interested in the CPU data, it's perfectly fine
to pass a NULL pointer i
Use a typedef instead of the plain struct and heap allocation. This
will make it easier to extend the ppc64 specific CPU data later on.
---
src/cpu/cpu.h| 2 +-
src/cpu/cpu_ppc64.c | 81 ++--
src/cpu/cpu_ppc64_data.h | 3 +-
3 files ch
---
tests/cputestdata/ppc64-baseline-1-result.xml | 3 ---
1 file changed, 3 deletions(-)
delete mode 100644 tests/cputestdata/ppc64-baseline-1-result.xml
diff --git a/tests/cputestdata/ppc64-baseline-1-result.xml
b/tests/cputestdata/ppc64-baseline-1-result.xml
deleted file mode 100644
index cb
This series depends on
[PATCH 0/4] cpu: Rename {powerpc,ppc} => ppc64
which has been already ACKed[1] and is pending upload.
Patches 1-11 are fixes and cleanups that don't introduce
any new feature in the driver and just lay the groundwork
for the second part of the series.
Patches 12-18 rewo
[getting back to this after *loong* time, sorry]
On Fri, Jul 17, 2015 at 02:30:20PM +0200, Erik Skultety wrote:
Actually, I found out this is easier to review as a one patch with
various diff options used for various parts of the patch. Some
questions and suggestions below.
Why vshClientHooks
Libvirt doesn't reliably know the location of the backing chain when
pre-creating images for non-shared migration. This isn't a problem for
full copy, but incremental copy requires the information.
Forbid pre-creating the image in cases where incremental migration is
required. This limitation can
Ping!
Thanks,
Shivaprasad
On Tue, Jul 14, 2015 at 5:26 PM, Shivaprasad G Bhat
wrote:
> The commit 7e72de4 didn't consider the hotplug scenarios. The patch addresses
> the hotplug case whereby if atleast one of the pci function is owned by a
> guest, the hotplug of other functions/devices in the
61 matches
Mail list logo