Re: [libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow startupPolicy update, yet again

2015-09-14 Thread Peter Krempa
On Mon, Sep 14, 2015 at 13:02:49 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1159219 > > So, in 11e058ca589808bd I've tried to make UpdateDevice update > startupPolicy too. And it worked well until somebody came around > and pushed d0dc6c036914da which

Re: [libvirt] [PATCH v2 0/4] Be tolerant to relabel errors for session mode

2015-09-14 Thread Martin Kletzander
On Thu, Sep 10, 2015 at 02:47:14PM +0200, Michal Privoznik wrote: This is a reworked version of my previous patch: https://www.redhat.com/archives/libvir-list/2015-July/msg00576.html Michal Privoznik (4): virSecuritySELinuxSetSecurityAllLabel: drop useless virFileIsSharedFSType

Re: [libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow startupPolicy update, yet again

2015-09-14 Thread Michal Privoznik
On 14.09.2015 13:24, Peter Krempa wrote: > On Mon, Sep 14, 2015 at 13:02:49 +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1159219 >> >> So, in 11e058ca589808bd I've tried to make UpdateDevice update >> startupPolicy too. And it worked well until somebody came around

[libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow startupPolicy update, yet again

2015-09-14 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1159219 So, in 11e058ca589808bd I've tried to make UpdateDevice update startupPolicy too. And it worked well until somebody came around and pushed d0dc6c036914da which accidentally removed my contribution. Redo my commit. Signed-off-by: Michal

Re: [libvirt] [PATCH] conf/qemu: enforce NUMA nodes only for x86 memory hotplug

2015-09-14 Thread Peter Krempa
On Tue, Aug 18, 2015 at 15:35:11 +0530, Nikunj A Dadhania wrote: > libvirt enforces at least one NUMA node for memory hotplug support on > all architectures. While it might be required for some x86 guest, > PowerPC can hotplug memory on non-NUMA system. > > The generic checks are replaced with

Re: [libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow startupPolicy update, yet again

2015-09-14 Thread Michal Privoznik
On 14.09.2015 14:00, Michal Privoznik wrote: > On 14.09.2015 13:24, Peter Krempa wrote: >> On Mon, Sep 14, 2015 at 13:02:49 +0200, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1159219 >>> >>> So, in 11e058ca589808bd I've tried to make UpdateDevice update >>>

[libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-14 Thread Shivaprasad G Bhat
Tunnelled migration can hang if the destination qemu exits despite all the ABI checks. This happens whenever the destination qemu exits before the complete transfer is noticed by source qemu. The savevm state checks at runtime can fail at destination and cause qemu to error out. The source qemu

[libvirt] [PATCH] rbd: Remove snapshots if the FORCED flag has been provided

2015-09-14 Thread Wido den Hollander
When a RBD volume has snapshots it can not be removed. This patch introduces a new flag to force volume removal, VIR_STORAGE_VOL_DELETE_FORCED. With this flag any existing snapshots will be removed prior to removing the volume. No existing mechanism in libvirt allowed us to pass such

Re: [libvirt] [PATCH] qemu: hotplug: Properly clean up drive backend if frontend hotplug fails

2015-09-14 Thread Peter Krempa
On Mon, Sep 14, 2015 at 08:43:37 +0200, Michal Privoznik wrote: > On 11.09.2015 17:41, Peter Krempa wrote: > > Commit 8125113c added code that should remove the disk backend if the > > fronted hotplug failed for any reason. The code had a bug though as it > > used the disk string for unplug rather

[libvirt] [PATCH] virsh: Fix job status indicator for 0 length block jobs

2015-09-14 Thread Peter Krempa
Although 0 length block jobs aren't entirely useful, the output of virsh blockjob is empty due to the condition that suppresses the output for migration jobs that did not start. Add a flag for virshPrintJobProgress that specifies that the job was started so that the function can be used both in

Re: [libvirt] [PATCH 0/2] Fix permissions for per-VM and qemu directories

2015-09-14 Thread Michal Privoznik
On 12.09.2015 16:31, Martin Kletzander wrote: > This is basically v2 of: > https://www.redhat.com/archives/libvir-list/2015-September/msg00295.html > with some changes: > > - permissions for per-VM dirs are fixed as well > > - permissions for the /var/lib/libvirt/qemu directory are fixed in >

Re: [libvirt] [PATCH] qemu: hotplug: Properly clean up drive backend if frontend hotplug fails

2015-09-14 Thread Michal Privoznik
On 11.09.2015 17:41, Peter Krempa wrote: > Commit 8125113c added code that should remove the disk backend if the > fronted hotplug failed for any reason. The code had a bug though as it > used the disk string for unplug rather than the backend alias. Fix the > code by pre-creating an alias string

Re: [libvirt] [PATCH] virsh: Fix job status indicator for 0 length block jobs

2015-09-14 Thread Michal Privoznik
On 14.09.2015 09:22, Peter Krempa wrote: > Although 0 length block jobs aren't entirely useful, the output of virsh > blockjob is empty due to the condition that suppresses the output for > migration jobs that did not start. Add a flag for virshPrintJobProgress > that specifies that the job was

[libvirt] [PATCH] util: Add space before comment end marker

2015-09-14 Thread Andrea Bolognani
This allows the Wikipedia link to be recognized correctly by eg. gnome-terminal's Open Link and Copy Link Address features. --- Pushed as trivial src/util/virarch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virarch.h b/src/util/virarch.h index 3206ce2..af5ff83