Re: [libvirt] crash in virDomainNumaGetMemorySize

On Tue, Oct 13, Peter Krempa wrote: > On Fri, Sep 18, 2015 at 17:10:20 +0200, Olaf Hering wrote: > > With current master (56945e1), while toying around with a WS2008R2 Hyper-V > > host: > Hi, thanks for reporting this. I've (hopefully) fixed the issue with: > commit

Re: [libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

On Thu, 2015-10-15 at 11:31 +0200, Peter Krempa wrote: > On Thu, Oct 15, 2015 at 17:12:18 +0800, Wei Jiangang wrote: > > Signed-off-by: Wei Jiangang > > --- > > src/libvirt-domain.c | 55 > > ++-- > > 1 file changed, 15

Re: [libvirt] genprotocol.pl generates unstable output

On Thu, Oct 15, Martin Kletzander wrote: > Oh, so if you're wondering about reproducibility, then it's a > different thing, I understand that. And libvirt is not a good one > with regards to reproducible builds. libvirt is perfect. Its just that little detail which pops up ever other day. Olaf

Re: [libvirt] genprotocol.pl generates unstable output

On Thu, Oct 15, 2015 at 09:59:24AM +0200, Olaf Hering wrote: > On Wed, Oct 14, Martin Kletzander wrote: > > > On Thu, Oct 01, 2015 at 08:44:55AM +0200, Olaf Hering wrote: > > >If the same source gets built twice the resulting files may differ. > > > I don't see the problem, these pointers are

Re: [libvirt] genprotocol.pl generates unstable output

On Thu, Oct 15, 2015 at 09:59:24AM +0200, Olaf Hering wrote: On Wed, Oct 14, Martin Kletzander wrote: On Thu, Oct 01, 2015 at 08:44:55AM +0200, Olaf Hering wrote: >If the same source gets built twice the resulting files may differ. I don't see the problem, these pointers are not depending

Re: [libvirt] [PATCH 2/3] libvirt-secret: Fix typo

On Thu, Oct 15, 2015 at 17:12:19 +0800, Wei Jiangang wrote: > seclets ==> selects > qualfied ==> qualified > > Signed-off-by: Wei Jiangang > --- > src/libvirt-secret.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libvirt-secret.c

Re: [libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

On Thu, Oct 15, 2015 at 11:31:48 +0200, Peter Krempa wrote: > On Thu, Oct 15, 2015 at 17:12:18 +0800, Wei Jiangang wrote: > > Signed-off-by: Wei Jiangang > > --- > > src/libvirt-domain.c | 55 > > ++-- > > 1 file

Re: [libvirt] [PATCH V2 1/9] qemu_migration: Add support for mutil-thread compressed migration enable

On Thu, Jul 09, 2015 at 21:01:49 +0800, ShaoHe Feng wrote: > We need to set the mutil-thread compress capability as true to enable it. > > Signed-off-by: Eli Qiao > Signed-off-by: ShaoHe Feng > --- > .gnulib | 2 +- >

Re: [libvirt] [PATCH] rbd: Remove snapshots if the FORCED flag has been provided

On Thu, Oct 15, 2015 at 10:28:39AM +0200, Wido den Hollander wrote: > When a RBD volume has snapshots it can not be removed. > > This patch introduces a new flag to force volume removal, > VIR_STORAGE_VOL_DELETE_FORCED. > > With this flag any existing snapshots will be removed prior > to

Re: [libvirt] [PATCH 3/3] Fix conficts with HACKING doc

On Thu, Oct 15, 2015 at 17:12:20 +0800, Wei Jiangang wrote: > Don't compare a bool variable against the literal, "true". > > Signed-off-by: Wei Jiangang > --- > src/conf/nwfilter_conf.c | 2 +- > src/nwfilter/nwfilter_dhcpsnoop.c | 2 +- > src/vz/vz_sdk.c

Re: [libvirt] genprotocol.pl generates unstable output

On Wed, Oct 14, Martin Kletzander wrote: > On Thu, Oct 01, 2015 at 08:44:55AM +0200, Olaf Hering wrote: > >If the same source gets built twice the resulting files may differ. > I don't see the problem, these pointers are not depending on each > other. Or are you saying that it leaves your tree

[libvirt] [PATCH] rbd: Remove snapshots if the FORCED flag has been provided

When a RBD volume has snapshots it can not be removed. This patch introduces a new flag to force volume removal, VIR_STORAGE_VOL_DELETE_FORCED. With this flag any existing snapshots will be removed prior to removing the volume. No existing mechanism in libvirt allowed us to pass such

Re: [libvirt] [PATCH] rbd: Remove snapshots if the FORCED flag has been provided

On Thu, Oct 15, 2015 at 10:28:39AM +0200, Wido den Hollander wrote: > When a RBD volume has snapshots it can not be removed. > > This patch introduces a new flag to force volume removal, > VIR_STORAGE_VOL_DELETE_FORCED. > > With this flag any existing snapshots will be removed prior > to

Re: [libvirt] [PATCH] rbd: Remove snapshots if the FORCED flag has been provided

On 15-10-15 10:44, Daniel P. Berrange wrote: > On Thu, Oct 15, 2015 at 10:28:39AM +0200, Wido den Hollander wrote: >> When a RBD volume has snapshots it can not be removed. >> >> This patch introduces a new flag to force volume removal, >> VIR_STORAGE_VOL_DELETE_FORCED. >> >> With this flag any

[libvirt] [PATCH 3/3] Fix conficts with HACKING doc

Don't compare a bool variable against the literal, "true". Signed-off-by: Wei Jiangang --- src/conf/nwfilter_conf.c | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 2 +- src/vz/vz_sdk.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)

[libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

Signed-off-by: Wei Jiangang --- src/libvirt-domain.c | 55 ++-- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6e1aacd..ed07c9e 100644 ---

[libvirt] [PATCH 2/3] libvirt-secret: Fix typo

seclets ==> selects qualfied ==> qualified Signed-off-by: Wei Jiangang --- src/libvirt-secret.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index fa306e3..db42aec 100644 --- a/src/libvirt-secret.c

Re: [libvirt] [PATCH v3] Close the source fd if the destination qemu exits during tunnelled migration

On Tue, Oct 13, 2015 at 4:51 PM, Shivaprasad bhat wrote: > On Mon, Oct 12, 2015 at 8:03 PM, Jiri Denemark wrote: >> On Thu, Oct 08, 2015 at 17:59:07 +0530, Shivaprasad G Bhat wrote: >>> Tunnelled migration can hang if the destination qemu exits

Re: [libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

On Thu, Oct 15, 2015 at 17:12:18 +0800, Wei Jiangang wrote: > Signed-off-by: Wei Jiangang > --- > src/libvirt-domain.c | 55 > ++-- > 1 file changed, 15 insertions(+), 40 deletions(-) > > diff --git

[libvirt] [PATCH] rbd: Remove snapshots if the DELETE_WITH_SNAPSHOTS flag has been provided

When a RBD volume has snapshots it can not be removed. This patch introduces a new flag to force volume removal, VIR_STORAGE_VOL_DELETE_WITH_SNAPSHOTS. With this flag any existing snapshots will be removed prior to removing the volume. No existing mechanism in libvirt allowed us to pass such

[libvirt] [PATCH] util: implement virProcessGetStartTime on GNU/kFreeBSD

Use the virProcessGetStartTime implementation also when only the kernel is FreeBSD, such as on GNU/kFreeBSD. --- src/util/virprocess.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index e6b78ef..43118f8 100644 ---

[libvirt] [PATCH 0/3] NEWS: Split releases by year

As agreed, I've followed up with the cleanups by splitting the huge news.html.in file into separate, smaller files, one per year. Along with the split I've also included a fixed XSLT stylesheet so that we can start shipping a meaningful NEWS file again. Cheers. Andrea Bolognani (3): NEWS:

Re: [libvirt] [PATCHv3 0/2] Added waiting for DAD to finish for bridge address.

On 09/29/2015 01:16 PM, Maxim Perevedentsev wrote: This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process which is relied on when waiting for DAD to complete exits without actually waiting for DAD. This is dnsmasq daemon's task. It seems to be a race that DAD

Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

In short, may be factor out common p2p code that now resides in libvirt-domain.c and reuse it for vz? Looks like vz driver is not a good place for such common and kinda complicated code. On 11.09.2015 14:06, Nikolay Shirokovskiy wrote: > > > On 11.09.2015 12:28, Daniel P. Berrange wrote: >> On

[libvirt] [PATCH 3/3] NEWS: Fix XSLT stylesheet

This has been broken for a looong time - in fact, we've been shipping a mostly-empty NEWS file for at least the past two years. Including the html namespace and using it for matching elements, like hacking1.xsl and hacking2.xsl were already doing, makes the NEWS file useful again. Add a note

Re: [libvirt] [PATCH] docs: event impl. registration before hypervisor connection

On 09/25/2015 04:54 AM, Dominik Perpeet wrote: > Event implementations need to be registered before a connection to the > Hypervisor is opened, otherwise event handling can be impaired (e.g. > delayed messages). This fact is referenced in an e-mail [1], but should > also be noted in the

[libvirt] [PATCH v2 2/4] qemu: Check for niothreads == 0 in qemuSetupCgroupForIOThreads

If there are no IOThreads defined, no sense making other checks Signed-off-by: John Ferlan --- src/qemu/qemu_cgroup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 570dab5..a8e0b8c 100644 ---

[libvirt] [PATCH v2 0/4] Fix a couple of iothread bugs

v1: http://www.redhat.com/archives/libvir-list/2015-October/msg00417.html Differences since v1 - many. - Reworked patches 1 & 2 to become patches 1 - 3 in the new series - Patch 1 is new, but the thinking behind patch 3 caused me to generate this patch which essentially changes

[libvirt] Fwd: [PATCH 2/3] NEWS: Split releases by year (2012-2015)

[moderated for smaller size] Forwarded Message From: Andrea Bolognani To: libvir-list@redhat.com Subject: [PATCH 2/3] NEWS: Split releases by year (2012-2015) Date: Thu, 15 Oct 2015 16:12:09 +0200 Message-Id:

Re: [libvirt] [PATCH v1 03/23] virSecurityDACSetOwnershipInternal: Don't chown so often

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > It's better if we stat() file that we are about to chown() at > first and check if there's something we need to change. Not that > it would make much difference, but for the upcoming patches we > need to be doing stat() anyway. > >

Re: [libvirt] [PATCH v1 02/23] security_dac: Fix TODO marks

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > Correctly mark the places where we need to remember and recall > file ownership. We don't want to mislead any potential developer. > > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 3 ++- > 1 file

[libvirt] [PATCH v2 4/4] conf: Optimize the iothreadid initialization

https://bugzilla.redhat.com/show_bug.cgi?id=1264008 The existing algorithm assumed that someone was making small, incremental changes; however, it is possible to change iothreads from 0 (or relatively small number) to some really large number and the algorithm would possibly spin its wheels doing

[libvirt] [PATCH v2 1/4] qemu: Use 'niothreadids' instead of 'iothreads'

Although theoretically both should be the same value, the niothreadids should be used in favor of iothreads when performing comparisons. This leaves the iothreads as a purely numeric value to be saved in the config file. The one exception to the rule is virDomainIOThreadIDDefArrayInit where the

[libvirt] [PATCH v2 3/4] qemu: Fix qemu startup check for QEMU_CAPS_OBJECT_IOTHREAD

https://bugzilla.redhat.com/show_bug.cgi?id=1249981 When qemuDomainPinIOThread was added in commit id 'fb562614', a check for the IOThread capability was not needed since a check for iothreadpids covered the condition where the support for IOThreads was not present. The iothreadpids array was

Re: [libvirt] [PATCH v1 04/23] security_dac: Introduce remember/recall stubs

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > These stubs will be worked in later. They merely lay out the > structure of the feature. > > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 45 > + > 1

Re: [libvirt] [PATCH v1 01/23] virtlockd: Don't SIGSEGV on SIGUSR1

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > So we have this mechanism that on SIGUSR1 the virtlockd dumps its > internal state into a JSON file, reexec itself and the reloads > the internal state back. However, there's a bug in our > implementation: > > (gdb) signal SIGUSR1 >

Re: [libvirt] [PATCH v1 11/23] locking: Introduce virSeclabelSpace

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > This module will handle all the security label remembering and > recalling for virlockd. We need to record a tuple of (path, > security model, security label). So I'm going with a hash table, > where @path would be the key, and tuple of (model,

Re: [libvirt] [PATCH v1 08/23] security_dac: Plug in remember/recall APIs

On 10/12/2015 06:25 AM, Michal Privoznik wrote: > Even though the APIs are not implemented yet, they create a > skeleton that can be filled in later. > > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 38 +- > 1

Re: [libvirt] [PATCH v2 2/4] qemu: Check for niothreads == 0 in qemuSetupCgroupForIOThreads

On Thu, Oct 15, 2015 at 16:43:53 -0400, John Ferlan wrote: > If there are no IOThreads defined, no sense making other checks > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_cgroup.c | 3 +++ > 1 file changed, 3 insertions(+) ACK, Peter signature.asc Description:

Re: [libvirt] [PATCH v2 1/4] qemu: Use 'niothreadids' instead of 'iothreads'

On Thu, Oct 15, 2015 at 16:43:52 -0400, John Ferlan wrote: > Although theoretically both should be the same value, the niothreadids > should be used in favor of iothreads when performing comparisons. This > leaves the iothreads as a purely numeric value to be saved in the config > file. The one

Re: [libvirt] [PATCH v1 07/23] security_dac: Limit usage of virSecurityDACSetOwnershipInternal

On Mon, Oct 12, 2015 at 12:25:52 +0200, Michal Privoznik wrote: > This function should really be called only when we want to change > ownership of a file (or disk source). Lets switch to calling a > wrapper function which will eventually record the current owner > of the file and call

Re: [libvirt] [PATCH v1 04/23] security_dac: Introduce remember/recall stubs

On Mon, Oct 12, 2015 at 12:25:49 +0200, Michal Privoznik wrote: > These stubs will be worked in later. They merely lay out the > structure of the feature. > > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 45 >

Re: [libvirt] [PATCH v1 06/23] virSecurityDACRestoreSecurityFileLabel: Pass virSecurityDACDataPtr

On Mon, Oct 12, 2015 at 12:25:51 +0200, Michal Privoznik wrote: > This is pure code adjustment. The structure is going to be needed > later as it will hold a reference that will be used to talk to > virtlockd. However, so far this is no functional change just code > preparation. > >

Re: [libvirt] [PATCH v2 3/4] qemu: Fix qemu startup check for QEMU_CAPS_OBJECT_IOTHREAD

On Thu, Oct 15, 2015 at 16:43:54 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1249981 ... > --- > src/qemu/qemu_command.c| 19 +-- > src/qemu/qemu_process.c| 26 ++- >

Re: [libvirt] [PATCH v2 4/4] conf: Optimize the iothreadid initialization

On Thu, Oct 15, 2015 at 16:43:55 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1264008 [...] > --- > src/conf/domain_conf.c | 39 +++ > 1 file changed, 31 insertions(+), 8 deletions(-) > > diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH v1 03/23] virSecurityDACSetOwnershipInternal: Don't chown so often

On Mon, Oct 12, 2015 at 12:25:48 +0200, Michal Privoznik wrote: > It's better if we stat() file that we are about to chown() at > first and check if there's something we need to change. Not that > it would make much difference, but for the upcoming patches we > need to be doing stat() anyway. > >

Re: [libvirt] [PATCH v1 05/23] virSecurityDACSetOwnership: Pass virSecurityDACDataPtr

On Mon, Oct 12, 2015 at 12:25:50 +0200, Michal Privoznik wrote: > This is pure code adjustment. The structure is going to be needed > later as it will hold a reference that will be used to talk to > virtlockd. However, so far this is no functional change just code > preparation. > >

[libvirt] Fwd: [PATCH 1/3] NEWS: Split releases by year (2005-2011)

[moderated for smaller size] Forwarded Message From: Andrea Bolognani To: libvir-list@redhat.com Subject: [PATCH 1/3] NEWS: Split releases by year (2005-2011) Date: Thu, 15 Oct 2015 16:12:08 +0200 Message-Id:

Re: [libvirt] [PATCH 0/3] NEWS: Split releases by year

On 10/15/2015 08:12 AM, Andrea Bolognani wrote: > As agreed, I've followed up with the cleanups by splitting > the huge news.html.in file into separate, smaller files, > one per year. > > Along with the split I've also included a fixed XSLT > stylesheet so that we can start shipping a meaningful

[libvirt] strange stale qemu processes after domain shutdown

I have 58 active domains with status running, and 62 qemu-system-x86_64 processes. After investigating this issue, i found problem domains. How to fix this issue and not lost this qemu processes? ps auxww: root 29561 0.2 0.2 1599628 743796 ? Sl Aug13 224:44 qemu-system-x86_64

Re: [libvirt] [PATCHv3 1/2] network: added waiting for DAD to finish for bridge address.

Sorry I keep delaying replying about this patch. Whenever I start, I run into a problem with it, then while I'm trying to decide how to respond I get distracted by something else and forget to come back. On 09/29/2015 06:16 AM, Maxim Perevedentsev wrote: This is a fix for commit