Re: [libvirt] [PATCH 08/24] qemu: Use -incoming defer for migrations

On Fri, Nov 13, 2015 at 19:52:20 +0100, Jiri Denemark wrote: > On Fri, Nov 13, 2015 at 11:25:14 +0100, Peter Krempa wrote: > > On Thu, Nov 12, 2015 at 19:37:10 +0100, Jiri Denemark wrote: > > > Traditionally, we pass incoming migration URI on QEMU command line, > > > which has some drawbacks.

[libvirt] [PATCH v3] storage sheepdog: allow to specify redundancy level

Some storage backends allows to specify per volume redundancy options. Sheepdog use x format for specify copies, and x:y format to specify data and parity block count. Signed-off-by: Alexey Tyabin Signed-off-by: Vasiliy Tolstov ---

[libvirt] [PATCH v3] storage sheepdog: allow to specify redundancy level

Completely fix tests and check that all works on production env Vasiliy Tolstov (1): storage sheepdog: allow to specify redundancy level docs/schemas/storagevol.rng | 3 + src/conf/storage_conf.c | 2 + src/storage/storage_backend_sheepdog.c | 143

Re: [libvirt] [PATCH v3 10/11] admin: Introduce virAdmConnectGetLibVersion

On 16/11/15 17:42, Martin Kletzander wrote: >> const ADMIN_PROGRAM = 0x06900690; >> const ADMIN_PROTOCOL_VERSION = 1; >> @@ -71,5 +75,10 @@ enum admin_procedure { >> /** >> * @generate: none >> */ >> -ADMIN_PROC_CONNECT_CLOSE = 2 >> +ADMIN_PROC_CONNECT_CLOSE = 2, >> + >> +

Re: [libvirt] qemuParseCommandLine and virDomainDefPostParse (and virDomaniDefAddImplicitControllers)

On 18.11.2015 21:19, Laine Stump wrote: > While playing with the idea of forcing explicit USB controller models, I > ended up with the qemuargv2xml test failing; it ended up that this was > because changes I had made to qemuDomainDefPostParse() were affecting > the XML produced by

Re: [libvirt] Found mem leak in livirt, need help to debug

On 18.11.2015 15:33, Piotr Rybicki wrote: > Hi. > > There is a mem leak in libvirt, when doing external snapshot (for backup > purposes). My KVM domain uses raw storage images via libgfapi. I'm using > latest 1.2.21 libvirt (although previous versions act the same). > > My bash script for

Re: [libvirt] [[PATCH v6] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2015-06-22 17:36 GMT+03:00 Michal Privoznik : > Interesting, so I've tried to mock some functions, but some are not that > easy. I mean, for instance, if I wanted to mock > qemuNetworkIfaceConnect() - I couldn't. The control jumps into the > original function defined in

Re: [libvirt] [PATCH 1/2] libxl: unref libxlDriverConfig object

On Wed, Nov 18, 2015 at 03:47:24PM -0700, Jim Fehlig wrote: > Commits b6e19cf4 and 6472e54a missed unref'ing the > libxlDriverConfig object. Add missing calls to virObjectUnref. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_driver.c | 22 -- > 1

Re: [libvirt] [PATCH 2/2] libxl: don't unlock virDomainObj if refcnt is 0

On Wed, Nov 18, 2015 at 03:47:25PM -0700, Jim Fehlig wrote: > Commit 6472e54a unlocks the virDomainObj even if libxlDomainObjEndJob > returns false, indicating that its refcnt has dropped to 0. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_driver.c | 4 +--- > 1 file

Re: [libvirt] [PATCH 17/24] qemu: Close logfd when closing monitor

On Fri, Nov 13, 2015 at 14:07:42 +0100, Peter Krempa wrote: > On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote: > > Remembering to call qemuMonitorSetDomainLog in the right paths before > > calling qemuProcessStop is annoying and easy to forget. And I already > > forget to do so in

Re: [libvirt] [PATCH] vz: implementation of domainReboot callback

18.11.2015 18:38, Mikhail Feoktistov пишет: --- src/vz/vz_driver.c | 8 src/vz/vz_sdk.c| 8 src/vz/vz_sdk.h| 1 + 3 files changed, 17 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 0a968b9..5f56eaf 100644 --- a/src/vz/vz_driver.c +++

[libvirt] [PATCH 3/5] conf: add virDomainDefAddController()

We need a virDomainDefAddController() that doesn't check for an existing controller at the same index (since USB2 controllers must be added in sets of 4 that are all at the same index), so rather than duplicating the code in virDomainDefMaybeAddController(), split it into two functions, in the

[libvirt] [PATCH 2/5] qemu: prefer 00:1D.x and 00:1A.x for USB2 controllers on Q35

The real Q35 machine puts the first USB controller set (EHCI+(UHCIx4)) on bus 0 slot 0x1D, and the 2nd USB controller set on bus 0 slot 0x1A, so let's attempt to make the virtual machine match that for controllers with auto-assigned addresses when possible. Three test cases were added to assure

[libvirt] [PATCH 4/5] qemu: define virDomainDevAddUSBController()

This new function will add a single controller of the given model, except the case of ich9-usb-ehci1 (the master controller for a USB2 controller set) in which case a set of related controllers will be added (EHCI1, UHCI1, UHCI2, UHCI3). These controllers will not be given PCI addresses, but

[libvirt] [PATCH 1/5] qemu: don't assume slot 0 is unused/reserved.

When qemuAssignDevicePCISlots() is looking for companion controllers for a USB controller that has no PCI address specified, it initializes a virDevicePCIAddress to :00:00.0, fills it in with the companion's address if one is found, then checks whether or not there was a find based on slot ==

[libvirt] [PATCH 5/5] qemu: auto-add a USB2 controller set for Q35 machines

Use virDomainDefAddUSBController() to add an EHCI1+UHCI1+UHCI2+UHCI3 controller set to newly defined Q35 domains that don't have any USB controllers defined. --- src/qemu/qemu_domain.c | 14 +++--- tests/qemuxml2argvdata/qemuxml2argv-q35.args | 5 + 2 files

[libvirt] [PATCH 0/5] auto-add USB2 controller set for Q35

For just about every other machinetype, libvirt automatically adds a USB controller if there is no controller (including "type='none'") specified in the config. It doesn't do this for the Q35 machinetype, because Q35 hardware would have a USB2 controller, USB2 controllers come in sets of multiple

[libvirt] [PATCH 3/3] libxl: implement virDomainInterfaceStats

Introduce support for domainInterfaceStats API call for querying network interface statistics. Consequently it also enables the use of `virsh domifstat ` command plus seeing the interfaces names instead of "-" when doing `virsh domiflist `. After succesful guest creation we fill the network

[libvirt] [PATCH 2/3] libxl: rename libxlConsoleCallback

. to a more generic name i.e. libxlDomainStartCallback, since it will now cover another case other than the console. Signed-off-by: Joao Martins --- src/libxl/libxl_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

This new field in libxlDomainObjPrivate is named "config" and is kept while the domain is active. For now, "config" will be used in libxlDomainStartCallback to set network interface names based on domid and libxl_device_nic devid that is set in the config on domain create. Signed-off-by: Joao

[libvirt] [PATCH 0/3] libxl: implement virDomainInterfaceStats

Hey, As discussed yesterday, this patch series implements virDomainInterfaceStats but based on "ConsoleCallback" as opposed of doing it in libxlDomainStart. The series is divided as following: Patch 1 adds up domain config to libxlDomainObjPrivate, Patch 2 renames console callback to something

Re: [libvirt] [PATCH 1/2] libxl: unref libxlDriverConfig object

Daniel P. Berrange wrote: > On Wed, Nov 18, 2015 at 03:47:24PM -0700, Jim Fehlig wrote: >> Commits b6e19cf4 and 6472e54a missed unref'ing the >> libxlDriverConfig object. Add missing calls to virObjectUnref. >> >> Signed-off-by: Jim Fehlig >> --- >> src/libxl/libxl_driver.c |

Re: [libvirt] Found mem leak in livirt, need help to debug

W dniu 2015-11-19 o 17:31, Michal Privoznik pisze: procedure is: start libvirtd start kvm run backup script (with external snapshot) stop kvm stop libvirtd Valgrind output: Sorry, better valgrind output - showing problem: valgrind --leak-check=full --show-reachable=yes

Re: [libvirt] [PATCHv4 5/6] qemu: set panic device model if not specified by the user

On Fri, Nov 13, 2015 at 20:16:39 +0300, Dmitry Andreev wrote: > Choose 'ise' or 'pseries' model for panic device 'default' model s/ise/isa/ > value. > > Fixed tests and add two new outputs for xml-2-xml tests. > > Set value Did you want to say something more here? Anyway, most of this patch

Re: [libvirt] [PATCHv4 2/6] qemu: add support for hv_crash feature as a panic device

On Fri, Nov 13, 2015 at 20:16:36 +0300, Dmitry Andreev wrote: > Panic device type used depends on 'model' attribute. > > If no model is specified then device type depends on hypervisor > and guest arch. 'pseries' model is used for pSeries guest and > 'isa' model is used in other cases. > > XML:

Re: [libvirt] [PATCHv4 3/6] schema: allow multiple panic devices

On Fri, Nov 13, 2015 at 20:16:37 +0300, Dmitry Andreev wrote: > 'model' attribute was added to a panic device but only one panic > device is allowed. This patch changes panic device presence > from 'optional' to 'zeroOrMore'. I'd remove the "schema: " prefix from the subject since this patch

Re: [libvirt] [PATCHv4 0/6] Hyper-v crash feature support

On Fri, Nov 13, 2015 at 20:16:34 +0300, Dmitry Andreev wrote: > A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature > will become available in v2.5.0. > > What is changed in v4: > * panic model attribute is added even if it wasn't specified >by the user [5/6], tests updated.

Re: [libvirt] [PATCHv4 1/6] conf: add 'model' attribute for panic device with values isa, pseries, hyperv

On Fri, Nov 13, 2015 at 20:16:35 +0300, Dmitry Andreev wrote: > Libvirt already has two types of panic devices - pvpanic and pSeries firmware. > This patch introduces the 'model' attribute and a new type of panic device. > > 'isa' model is for ISA pvpanic device. > 'pseries' model is a default

Re: [libvirt] [PATCHv4 6/6] conf: reject multiple panic devices of same model

On Fri, Nov 13, 2015 at 20:16:40 +0300, Dmitry Andreev wrote: > Only one panic device per model is allowed. > --- > src/conf/domain_conf.c | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index

Re: [libvirt] [PATCH v4 04/10] Wait for vfio-pci device cleanups before reassinging the device to host driver

On Sat, 2015-11-14 at 14:06 +0530, Shivaprasad G Bhat wrote: > Before unbind from stub driver libvirt should be sure the guest is not using > the device anymore. The libvirt today waits for pci-stub driver alone in > /proc/iommu. > The same wait is needed for vfio devices too. > > Signed-off-by:

Re: [libvirt] [PATCH] storage: Ignore block devices that fail format detection

ping*2? Tks - John On 10/30/2015 11:13 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1276198 > > Prior to commit id '98322052' failure to saferead the block device would > cause an error to be logged and the device to be skipped while attempting > to discover/create a

Re: [libvirt] adding tests to qemu_driver

On Fri, Nov 13, 2015 at 10:44:01 +0200, NoxDaFox wrote: > 2015-11-13 0:30 GMT+02:00 Jiri Denemark : > > > On Thu, Nov 12, 2015 at 23:47:54 +0200, noxdafox wrote: > > > Greetings, > > > > > > I was investigating on an issue in which QEMU's dynamic ownership was > > > not

[libvirt] [PATCH] vz: Allow to create container based on template

We shouldn't delete disk from default config if we create container based on template, because we don't have the new disk from XML, only template name. And don't add template section from XML as new filesystem, we use PrlVmCfg_SetOsTemplate function to set template name. --- src/vz/vz_sdk.c | 33

[libvirt] [PATCH v2 6/7] qemu: Skip starting NBD servers for offline migration

NBD storage migration will not work with offline migration anyway and we already checked that the user did not ask for it. Thus it doesn't make sense to keep the code after 'done' label where we jump in case of offline migration. Signed-off-by: Jiri Denemark --- Notes:

[libvirt] [PATCH v2 7/7] qemu: Use qemuProcessLaunch in migration Prepare phase

Using qemuProcess{Init,Launch,FinishStartup} allows us to run pre-migration commands on destination before asking QEMU to wait for incoming migration data. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 68 ++- 1

[libvirt] [PATCH v2 1/7] qemu: Introduce qemuProcessInit

qemuProcessStart is going to be split in three parts: qemuProcessInit, qemuProcessLaunch, and qemuProcessFinish so that migration Prepare phase can insert additional code in the process. qemuProcessStart will be a small wrapper for all other callers. qemuProcessInit prepares the domain up to the

[libvirt] [PATCH v2 3/7] qemu: Introduce qemuProcessFinishStartup

Finishes starting a new domain launched by qemuProcessLaunch. Signed-off-by: Jiri Denemark --- Notes: Version 2: - save status before running VIR_HOOK_QEMU_OP_STARTED hook - rename qemuProcessFinish as qemuProcessFinishStartup - remove unused cfg from

[libvirt] [PATCH v2 4/7] qemu: Separate incoming URI generation from qemuMigrationPrepareAny

Signed-off-by: Jiri Denemark --- Notes: ACKed in version 1 Version 2: - no change src/qemu/qemu_migration.c | 154 +- 1 file changed, 85 insertions(+), 69 deletions(-) diff --git a/src/qemu/qemu_migration.c

[libvirt] [PATCH v2 2/7] qemu: Introduce qemuProcessLaunch

Once qemuProcessInit was called, qemuProcessLaunch will launch a new QEMU process with stopped virtual CPUs. Signed-off-by: Jiri Denemark --- Notes: Version 2: - save status before running VIR_HOOK_QEMU_OP_STARTED hook - call virSecurityManagerSetAllLabel even

[libvirt] [PATCH v2 5/7] qemu: Kill QEMU process if Prepare phase fails

Some failure paths in qemuMigrationPrepareAny forgot to kill the just started QEMU process. This patch fixes this by combining 'stop' and 'endjob' label into a new label 'stopjob'. This name was chosen to avoid confusion with the most common semantics of 'endjob'. Normally, 'endjob' is always

[libvirt] [PATCH v2 0/7] qemu: Add support for -incoming defer

Traditionally, we pass incoming migration URI on QEMU command line, which has some drawbacks. Depending on the URI QEMU may initialize its migration state immediately without giving us a chance to set any additional migration parameters (this applies mainly for fd: URIs). For some URIs the monitor

Re: [libvirt] [PATCH v2] vz: implementation of domainReboot callback

19.11.2015 15:16, Mikhail Feoktistov пишет: Diff from v1. 1. Add virCheckFlags() call in vzDomainReboot This way even better. ACK --- src/vz/vz_driver.c | 8 src/vz/vz_sdk.c| 8 src/vz/vz_sdk.h| 1 + 3 files changed, 17 insertions(+) diff --git

Re: [libvirt] qemuParseCommandLine and virDomainDefPostParse (and virDomaniDefAddImplicitControllers)

On Thu, Nov 19, 2015 at 11:12:29 +0100, Michal Privoznik wrote: > On 18.11.2015 21:19, Laine Stump wrote: [...] > > > > > Does anyone else have an opinion about this? > > > > I believe there's not much gain in calling post parse callbacks during > cmd line parsing. Well, then you have to

[libvirt] [PATCH v2] vz: implementation of domainReboot callback

Diff from v1. 1. Add virCheckFlags() call in vzDomainReboot --- src/vz/vz_driver.c | 8 src/vz/vz_sdk.c| 8 src/vz/vz_sdk.h| 1 + 3 files changed, 17 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 0a968b9..39f58a4 100644 ---

[libvirt] [PATCH v2] add func to set shared drivers after libvirtd init

Diff from v1: Remove vz prefix from the title of this letter. Because this is the common case for all drivers in libvirt. Description: Built-in drivers in libvirt are initialized before libvirtd initialization. Libvirt loads shared drivers on libvirtd initialization step. For built-in drivers we

Re: [libvirt] [PATCH] set UID and GID according to dynamicOwnership

On Wed, Nov 18, 2015 at 20:20:38 +0200, Matteo Cafasso wrote: > When called with dynamicOwnership set, the qemuOpenFileAs function ignores it > resulting in files not created with proper permissions. > > The issue is reported in: > >

Re: [libvirt] qemuParseCommandLine and virDomainDefPostParse (and virDomaniDefAddImplicitControllers)

On 11/19/2015 07:50 AM, Peter Krempa wrote: On Thu, Nov 19, 2015 at 11:12:29 +0100, Michal Privoznik wrote: On 18.11.2015 21:19, Laine Stump wrote: [...] Does anyone else have an opinion about this? I believe there's not much gain in calling post parse callbacks during cmd line parsing.

Re: [libvirt] [PATCH 6/6] qemu: Add ppc64-specific math to qemuDomainGetMlockLimitBytes()

On Wed, 18 Nov 2015 17:26:54 +0100 Peter Krempa wrote: > On Wed, Nov 18, 2015 at 15:13:20 +0100, Andrea Bolognani wrote: > > The amount of memory a ppc64 domain might need to lock is different > > than that of a equally-sized x86 domain, so we need to check the > > domain's

Re: [libvirt] Found mem leak in livirt, need help to debug

On 19.11.2015 15:00, Piotr Rybicki wrote: > > > W dniu 2015-11-19 o 14:36, Piotr Rybicki pisze: >> >> >> W dniu 2015-11-19 o 11:07, Michal Privoznik pisze: >>> On 18.11.2015 15:33, Piotr Rybicki wrote: Hi. There is a mem leak in libvirt, when doing external snapshot (for

Re: [libvirt] [PATCH v4 04/10] Wait for vfio-pci device cleanups before reassinging the device to host driver

On Fri, Nov 20, 2015 at 4:54 AM, Alex Williamson wrote: > On Sat, 2015-11-14 at 14:06 +0530, Shivaprasad G Bhat wrote: >> Before unbind from stub driver libvirt should be sure the guest is not using >> the device anymore. The libvirt today waits for pci-stub driver

Re: [libvirt] qemuParseCommandLine and virDomainDefPostParse (and virDomaniDefAddImplicitControllers)

On Thu, Nov 19, 2015 at 10:15:25 -0500, Laine Stump wrote: > On 11/19/2015 07:50 AM, Peter Krempa wrote: > > On Thu, Nov 19, 2015 at 11:12:29 +0100, Michal Privoznik wrote: > >> On 18.11.2015 21:19, Laine Stump wrote: > > [...] > > > >>> Does anyone else have an opinion about this? > >>> > >> I

Re: [libvirt] [PATCH] vz: allow only en-us keymap for VNC

On Wed, 2015-11-18 at 18:19 +0300, Mikhail Feoktistov wrote: > In virtuozzo we support only en-us keymap for VMs and containers. > If keymap is specified than check that it's en-us, otherwise > show error message. I thought we've done it already. ACKed and pushed. > --- >  src/vz/vz_sdk.c | 7

Re: [libvirt] Found mem leak in livirt, need help to debug

W dniu 2015-11-19 o 14:36, Piotr Rybicki pisze: W dniu 2015-11-19 o 11:07, Michal Privoznik pisze: On 18.11.2015 15:33, Piotr Rybicki wrote: Hi. There is a mem leak in libvirt, when doing external snapshot (for backup purposes). My KVM domain uses raw storage images via libgfapi. I'm

Re: [libvirt] [PATCH v4 00/10] Few VFIO related fixes

On Sat, 2015-11-14 at 14:03 +0530, Shivaprasad G Bhat wrote: > The series fixes few VFIO related host crash issues. The patches 3, 4, 9 and > 10 > are actual fixes. Patch 7 and 8 are test changes to allow testing patch 9. > Rest of the patches are mostly code movements except for patch 2. > >

Re: [libvirt] qemuParseCommandLine and virDomainDefPostParse (and virDomaniDefAddImplicitControllers)

On 11/19/2015 10:29 AM, Peter Krempa wrote: On Thu, Nov 19, 2015 at 10:15:25 -0500, Laine Stump wrote: On 11/19/2015 07:50 AM, Peter Krempa wrote: On Thu, Nov 19, 2015 at 11:12:29 +0100, Michal Privoznik wrote: On 18.11.2015 21:19, Laine Stump wrote: [...] Does anyone else have an opinion

Re: [libvirt] [PATCH 2/2] vbox: Resolve Coverity CHECKED_RETURN

On Thu, Nov 19, 2015 at 09:43:25 -0500, John Ferlan wrote: > > > On 11/19/2015 09:20 AM, Ján Tomko wrote: > > On Thu, Nov 19, 2015 at 09:06:05AM -0500, John Ferlan wrote: > >> Other callers check return from virDomainGraphicsListenSetAddress, but > >> vbox doesn't in it's vboxDumpDisplay. Follow

Re: [libvirt] Found mem leak in livirt, need help to debug

W dniu 2015-11-19 o 11:07, Michal Privoznik pisze: On 18.11.2015 15:33, Piotr Rybicki wrote: Hi. There is a mem leak in libvirt, when doing external snapshot (for backup purposes). My KVM domain uses raw storage images via libgfapi. I'm using latest 1.2.21 libvirt (although previous versions

Re: [libvirt] [PATCH v3 5/8] libxl: implement virDomainBlockStats

On 11/18/2015 07:01 PM, Jim Fehlig wrote: > On 11/13/2015 06:14 AM, Joao Martins wrote: >> Introduce initial support for domainBlockStats API call that >> allow us to query block device statistics. openstack nova >> uses this API call to query block statistics, alongside >> virDomainMemoryStats

Re: [libvirt] [PATCH 2/2] libxl: don't unlock virDomainObj if refcnt is 0

On 11/18/2015 10:47 PM, Jim Fehlig wrote: > Commit 6472e54a unlocks the virDomainObj even if libxlDomainObjEndJob > returns false, indicating that its refcnt has dropped to 0. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_driver.c | 4 +--- > 1 file changed, 1

Re: [libvirt] [PATCH 1/2] libxl: unref libxlDriverConfig object

On 11/18/2015 10:47 PM, Jim Fehlig wrote: > Commits b6e19cf4 and 6472e54a missed unref'ing the > libxlDriverConfig object. Add missing calls to virObjectUnref. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_driver.c | 22 -- > 1 file changed, 16

Re: [libvirt] [PATCH v3 08/11] admin: Add support for URI aliases

>> -if (!(conn->uri = virURIParse(uri ? uri : default_uri))) >> +if ((!(flags & VIR_CONNECT_NO_ALIASES) && >> + virURIResolveAlias(conf, uri ? uri : default_uri, ) < 0)) > > this should also be fixed (with what I mentioned in previous review). > Fixed. >> +goto error;

Re: [libvirt] [PATCH v2] vz: implementation of domainReboot callback

On Thu, 2015-11-19 at 15:16 +0300, Mikhail Feoktistov wrote: > Diff from v1. > 1. Add virCheckFlags() call in vzDomainReboot > ACKed and pushed. Could you, please, put such notes below '---' delimiter? So that it will not appear in a commit message. Also I think at some point we will need to

Re: [libvirt] [PATCH v3 6/8] libxl: implement virConnectGetAllDomainStats

On 11/18/2015 10:03 PM, Jim Fehlig wrote: > On 11/13/2015 06:14 AM, Joao Martins wrote: >> Introduce support for connectGetAllDomainStats call that >> allow us to _all_ domain(s) statistics including network, block, > > allows us to get > >> cpus and memory. Changes are rather mechanical and

Re: [libvirt] [PATCH 2/2] vbox: Resolve Coverity CHECKED_RETURN

On Thu, Nov 19, 2015 at 09:06:05AM -0500, John Ferlan wrote: > Other callers check return from virDomainGraphicsListenSetAddress, but > vbox doesn't in it's vboxDumpDisplay. Follow other instances within vbox > to just ignore the return value in the vboxDump* functions. > > Signed-off-by: John

Re: [libvirt] [PATCH 1/2] qemu: Fix build error in Coverity environment

On Thu, Nov 19, 2015 at 09:06:04AM -0500, John Ferlan wrote: > Commit id '08600de37' changed the prototype to reduce an argument, but > didn't adjust the ATTRIBUTE_NONNULL(11) to (10) > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_command.h | 2 +- > 1 file changed, 1

[libvirt] [PATCH 0/2] Fix coverity build and resolve new issue

The first patch is a Coverity build breaker... The second one popped up recently and while some may consider it noise or a false positive, it is the only call that didn't check status. Not sure why it "popped up" after the recent changes, but that does happen. John Ferlan (2): qemu: Fix build

[libvirt] [PATCH 1/2] qemu: Fix build error in Coverity environment

Commit id '08600de37' changed the prototype to reduce an argument, but didn't adjust the ATTRIBUTE_NONNULL(11) to (10) Signed-off-by: John Ferlan --- src/qemu/qemu_command.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.h

[libvirt] [PATCH 2/2] vbox: Resolve Coverity CHECKED_RETURN

Other callers check return from virDomainGraphicsListenSetAddress, but vbox doesn't in it's vboxDumpDisplay. Follow other instances within vbox to just ignore the return value in the vboxDump* functions. Signed-off-by: John Ferlan --- src/vbox/vbox_common.c | 5 +++-- 1 file

Re: [libvirt] [PATCH 2/2] vbox: Resolve Coverity CHECKED_RETURN

On 11/19/2015 09:20 AM, Ján Tomko wrote: > On Thu, Nov 19, 2015 at 09:06:05AM -0500, John Ferlan wrote: >> Other callers check return from virDomainGraphicsListenSetAddress, but >> vbox doesn't in it's vboxDumpDisplay. Follow other instances within vbox >> to just ignore the return value in the