[libvirt] [PATCH] Fix formatting for virDomainGetCPUStats docstring

We have few code samples there that are almost unreadable when formatted because they are not indented properly. By indenting them they are formatted as code and hence quite readable. Also adjust descriptions to be comments and add semicolons so that the code sample looks like sample of a

Re: [libvirt] [PATCH v2] qemu: Connect to guest agent iff needed

On Tue, Jan 05, 2016 at 10:34:16 +0100, Peter Krempa wrote: > On Tue, Jan 05, 2016 at 10:23:59 +0100, Michal Privoznik wrote: > > On 04.01.2016 16:28, Peter Krempa wrote: > > > On Tue, Dec 22, 2015 at 15:41:16 +0100, Michal Privoznik wrote: > > >>

Re: [libvirt] [PATCH v2] qemu: Connect to guest agent iff needed

On Tue, Jan 05, 2016 at 10:23:59 +0100, Michal Privoznik wrote: > On 04.01.2016 16:28, Peter Krempa wrote: > > On Tue, Dec 22, 2015 at 15:41:16 +0100, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1293351 > >> > >> I've came across a bit of a silly scenario, but long

Re: [libvirt] [PATCH v2] qemu: Connect to guest agent iff needed

On 04.01.2016 16:28, Peter Krempa wrote: > On Tue, Dec 22, 2015 at 15:41:16 +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1293351 >> >> I've came across a bit of a silly scenario, but long story short: >> after domain was resumed, the virDomainSetTime() API hung for

Re: [libvirt] [PATCH] Fix formatting for virDomainGetCPUStats docstring

On Tue, Jan 05, 2016 at 08:59:11 +0100, Martin Kletzander wrote: > We have few code samples there that are almost unreadable when formatted > because they are not indented properly. By indenting them they are > formatted as code and hence quite readable. Also adjust descriptions to > be comments

Re: [libvirt] [PATCHv2 1/3] conf: introduce 'autodeflate' attribute for memballoon device

On 12/23/2015 07:33 AM, Dmitry Andreev wrote: > Excessive memory balloon inflation can cause invocation of OOM-killer, > when Linux is under severe memory pressure. QEMU memballoon device > has a feature to release some memory at the last moment before some > process will be get killed by

Re: [libvirt] [PATCHv2 2/3] qemu: add capability check for memballoon 'autodeflate' feature

On 12/23/2015 07:33 AM, Dmitry Andreev wrote: > New attribute 'autodeflate' for memballoon was introduced. This > commit adds appropriate capability check and new virQEMUCaps flag. So I see from these changes and the qemu sources, the feature was added in QEMU 2.4; however, your cover letter

Re: [libvirt] [PATCHv2 3/3] qemu: add support of optional 'autodeflate' attribute

On 12/23/2015 07:33 AM, Dmitry Andreev wrote: > Autodeflate can be enabled/disabled for memballon device > of model 'virtio'. > > xml: > > > > > qemu: > qemu -device virtio-balloon-pci,...,deflate-on-oom=on > > Autodeflate cannot be enabled/disabled for running domain. > --- >

Re: [libvirt] [PATCH] qemu: Specify format= iff disk source is not empty

On Sat, Jan 02, 2016 at 01:24:08PM +0100, Michal Privoznik wrote: Just recently, qemu forbade specifying format for sourceless disks (qemu commit 39c4ae941ed992a3bb5). It kind of makes sense. If there's no file to open, why specify its format. Anyway, I have a domain like this:

Re: [libvirt] ARM KVM GICv3 Support

On Tue, 2016-01-05 at 18:14 +, Peter Maydell wrote: > > > Why can libvirt not just run the tool and parse its output?  That's what > > > I understood was done for other things, but perhaps I misunderstood. > >  > > It's the other way around: the tool uses libvirt to implement its > > checks.

Re: [libvirt] ARM KVM GICv3 Support

On 5 January 2016 at 17:58, Andrea Bolognani wrote: > On Tue, 2016-01-05 at 14:47 +0100, Christoffer Dall wrote: >> Why can libvirt not just run the tool and parse its output? That's what >> I understood was done for other things, but perhaps I misunderstood. > > It's the

Re: [libvirt] ARM KVM GICv3 Support

On Tue, 2016-01-05 at 14:47 +0100, Christoffer Dall wrote: >  > > The tool is just a convenience for the administrator (and for higher > > level tools?), and it can't be where the validation happens for two > > reasons: > >  > >   - it doesn't take any argument, so it can't possibly know whether >

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Jan 05, 2016 at 01:37:47PM +0100, Andrea Bolognani wrote: > On Tue, 2016-01-05 at 13:08 +0100, Christoffer Dall wrote: > > On Tue, Jan 05, 2016 at 12:37:02PM +0100, Andrea Bolognani wrote: > > > On Mon, 2015-12-21 at 12:03 +0100, Christoffer Dall wrote: > > > >   > > > > So let me

Re: [libvirt] [PATCH] storage: Clean up error path for create buildPool failure

On Fri, Dec 18, 2015 at 08:07:36AM -0500, John Ferlan wrote: > Commit id 'aeb1078ab' added a buildPool option and failure path which > calls virStoragePoolObjRemove, which unlocks the pool, clears the 'pool' > variable, and goto cleanup. However, at cleanup virStoragePoolObjUnlock > is called

Re: [libvirt] [PATCH] qemu: save config after pivot only if domain is persistent

On Tue, Jan 05, 2016 at 11:38:07 +1100, Michael Chapman wrote: > On Mon, 4 Jan 2016, Peter Krempa wrote: > > On Thu, Dec 31, 2015 at 16:42:52 +1100, Michael Chapman wrote: ... > >> @@ -188,8 +182,8 @@ qemuBlockJobEventProcess(virQEMUDriverPtr driver, > >> if

Re: [libvirt] [PATCH] virsh: improve waiting for block job readiness

On Tue, Jan 05, 2016 at 11:19:44 +1100, Michael Chapman wrote: > On Mon, 4 Jan 2016, Peter Krempa wrote: > > On Thu, Dec 31, 2015 at 16:34:49 +1100, Michael Chapman wrote: > >> Wait for a block job event after the job has reached 100% only if > >> exactly one of the BLOCK_JOB and BLOCK_JOB_2

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

On 01/05/2016 11:36 PM, John Ferlan wrote: > > > On 12/28/2015 10:33 AM, Wido den Hollander wrote: >> If no port number was provided for a storage pool libvirt would default >> to port 6789. >> >> librbd/librados will however already default to 6789 when no port number >> is provided. > >

Re: [libvirt] [PATCHv3 0/2] notify about reverting to a snapshot

On 12/23/2015 09:25 AM, Dmitry Andreev wrote: > Reverting to snapshot may change domain configuration but > there will be no events about that. > > Lack of the event become a problem for virt-manager > https://bugzilla.redhat.com/show_bug.cgi?id=1081148 > > This patch-set introduces new event

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

On 12/28/2015 10:33 AM, Wido den Hollander wrote: > If no port number was provided for a storage pool libvirt would default > to port 6789. > > librbd/librados will however already default to 6789 when no port number > is provided. reads better as: If no port number was provided for a storage

Re: [libvirt] ARM KVM GICv3 Support

On Mon, 2015-12-21 at 12:03 +0100, Christoffer Dall wrote: >  > So let me summarize the things we need to do: >  >  - patch libvirt to allow >  - patch libvirt to properly probe for GICv2 and GICv3 support >  - patch libvirt to generally handle virt-host-validate on ARM >  > And that should be

Re: [libvirt] [PATCHv2] conf: rework code around 'append' attribute to make coverity happy

On 12/29/2015 11:55 AM, Dmitry Mishin wrote: > Additionally fixed condition to use proper type define, thanks to John Ferlan > > Signed-off-by: Dmitry Mishin > --- > src/conf/domain_conf.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > Split

Re: [libvirt] [PATCH] docs: Describe new 'append' attribute for chardevs source

On 12/24/2015 11:40 AM, Dmitry Mishin wrote: > Signed-off-by: Dmitry Mishin > --- > docs/formatdomain.html.in | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > Made a couple of slight adjustments to the text, added a Since 1.3.1 and pushed. Thanks -

Re: [libvirt] [PATCH] storage: Clean up error path for create buildPool failure

ping - Tks - John On 12/18/2015 08:07 AM, John Ferlan wrote: > Commit id 'aeb1078ab' added a buildPool option and failure path which > calls virStoragePoolObjRemove, which unlocks the pool, clears the 'pool' > variable, and goto cleanup. However, at cleanup virStoragePoolObjUnlock > is called

Re: [libvirt] [PATCH] libvirt-domain: fix dxml passing in virDomainMigrateToURI2

On Tue, Jan 05, 2016 at 13:46:31 +0100, Ján Tomko wrote: > The refactoring in commit a26669d silently ignored the dxml > parameter of virDomainMigrateToURI2. > > https://bugzilla.redhat.com/show_bug.cgi?id=1295405 > --- > src/libvirt-domain.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH] rbd: Do not error out on a single image during pool refresh

On 12/29/2015 08:35 AM, Wido den Hollander wrote: > It could happen that rbd_list() returns X names, but that while > refreshing the pool one of those RBD images is removed from Ceph > through a different route then libvirt. > > We do not need to error out in such case, we can simply ignore the

Re: [libvirt] [PATCH 1/2] spec: fix builds on RHEL <= 6

On 12/31/2015 12:09 AM, Michael Chapman wrote: - dbus-devel is needed as build dependency if polkit support is enabled. - chkconfig(8) and service(8) are in /sbin/, not /bin/. Both fixes are valid, and not just for RHEL <= 6, but they should be in separate patches (both because they are

Re: [libvirt] [PATCH 2/2] qemu: domain: Prevent overflows in memory alignment code

Hi, On Mon, Jan 04, 2016 at 09:39:20AM +0100, Peter Krempa wrote: > On Sun, Jan 03, 2016 at 18:26:56 +0100, Guido Günther wrote: > > Hi, > > On Tue, Dec 01, 2015 at 03:11:05PM +0100, Peter Krempa wrote: > > > Since libvirt for dubious historical reasons stores memory size as > > > kibibytes, it's

Re: [libvirt] [PATCH 2/2] virtlogd: fix lock file path in initscript

On 12/31/2015 12:09 AM, Michael Chapman wrote: The virtlogd initscript's lock file should go in /var/lock/subsys/, not (the nonexistent) /var/log/subsys/. ACK and push. Thanks! Signed-off-by: Michael Chapman --- src/logging/virtlogd.init.in | 6 +++--- 1 file

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Jan 05, 2016 at 12:37:02PM +0100, Andrea Bolognani wrote: > On Mon, 2015-12-21 at 12:03 +0100, Christoffer Dall wrote: > >  > > So let me summarize the things we need to do: > >  > >  - patch libvirt to allow > >  - patch libvirt to properly probe for GICv2 and GICv3 support > >  - patch

Re: [libvirt] ARM KVM GICv3 Support

On Tue, 2016-01-05 at 13:08 +0100, Christoffer Dall wrote: > On Tue, Jan 05, 2016 at 12:37:02PM +0100, Andrea Bolognani wrote: > > On Mon, 2015-12-21 at 12:03 +0100, Christoffer Dall wrote: > > >   > > > So let me summarize the things we need to do: > > >   > > >   - patch libvirt to allow > > >  

[libvirt] [PATCH] libvirt-domain: fix dxml passing in virDomainMigrateToURI2

The refactoring in commit a26669d silently ignored the dxml parameter of virDomainMigrateToURI2. https://bugzilla.redhat.com/show_bug.cgi?id=1295405 --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index

Re: [libvirt] [PATCH] qemu: add reporting of vCPU wait time

On Thu, Dec 10, 2015 at 02:41:56PM +, Daniel P. Berrange wrote: > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 783a7cd..5293294 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -1361,6 +1361,80 @@ static char