[libvirt] [PATCH] qemu: Fix NBD migration with default listenAddress

My commit 674afcb09e3d33500cfbbcf870ebf92cb99ecfa3 moved computing the default listen address from qemuMigrationPrepareAny to qemuMigrationPrepareIncoming. However, I didn't notice listenAddress was later passed to qemuMigrationStartNBDServer. Thus, it would be called with the original value of

Re: [libvirt] [PATCH 00/21] Support NBD for tunnelled migration

On Wed, Nov 18, 2015 at 20:12:58 +0200, Pavel Boldin wrote: > The provided patchset implements NBD disk migration over a tunnelled > connection provided by libvirt. > > The migration source instructs QEMU to NBD mirror drives into the provided > UNIX socket. These connections and all the data are

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On 01/07/2016 02:01 PM, Henning Schild wrote: > On Thu, 7 Jan 2016 11:20:23 -0500 > John Ferlan wrote: > >> >> [...] >> No problem - although it seems they've generated a regression in the virttest memtune test suite. I'm 'technically' on vacation for the

[libvirt] [PATCH] vmx: Adapt to emptyBackingString for cdrom-image

https://bugzilla.redhat.com/show_bug.cgi?id=1266088 We are missing this value for cdrom-image device. Honestly, I have no idea whether it can happen for other disk devices too. Signed-off-by: Michal Privoznik --- src/vmx/vmx.c | 10 ++ 1 file changed, 10

Re: [libvirt] [PATCH] qemu: Don't bother user with libvirt-internal paths

On Thu, Jan 07, 2016 at 10:47:46AM +0100, Pavel Hrdina wrote: On Thu, Jan 07, 2016 at 10:18:26AM +0100, Martin Kletzander wrote: On Thu, Jan 07, 2016 at 09:40:29AM +0100, Pavel Hrdina wrote: >On Wed, Jan 06, 2016 at 05:50:57PM +0100, Martin Kletzander wrote: >> If user defines a virtio channel

[libvirt] [PATCH 1/2] virDomainMigrateUnmanagedParams: Don't blindly dereference @dconnuri

This function may be called with @dconnuri == NULL, e.g. from virDomainMigrateToURI3() if the flags are missing VIR_MIGRATE_PEER2PEER flag. Moreover, all later functions called from here do wrap it into NULLSTR() so why not do the same here? Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] qemu: Don't bother user with libvirt-internal paths

On Wed, Jan 06, 2016 at 05:50:57PM +0100, Martin Kletzander wrote: > If user defines a virtio channel with UNIX socket backend and doesn't > care about the path for the socket (e.g. qemu-agent channel), we still > generate it into the persistent XML. Moreover when then user renames > the domain,

[libvirt] [PATCH] Fix LSB requirements in service script and sync them

Commit b22344f3285187ee1768d6e031bc0ff20e32552d mistakenly reordered Default-* lines. Thanks to that I noticed that we are very inconsistent with our init scripts, so I took the liberty of synchronizing them, updating them and making them all look shiny and new. So apart from fixing the LSB

[libvirt] [PATCH 07/10] tests: regenerate all outputs using VIR_TEST_REGENERATE_OUTPUT flag

Since more tests supports regenerating its output, this patch updates those expected output files. Signed-off-by: Pavel Hrdina --- tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml

[libvirt] [PATCH 08/10] tests.nwfilterebiptablestest: swap actual and expected

Those parameters should be in opposite order. Signed-off-by: Pavel Hrdina --- tests/nwfilterebiptablestest.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/nwfilterebiptablestest.c b/tests/nwfilterebiptablestest.c index

[libvirt] [PATCH 00/10] [rebase] various test fixes and input devices handling

This is just a rebase to current HEAD. Pavel Hrdina (10): xen: move virDomainDefPostParse to xenParseSxpr tests: introduce VIR_TEST_REGENERATE_OUTPUT flag tests.testutils: use VIR_TEST_REGENERATE_OUTPUT for virTestDifferenceFull tests.testutils: use virTestDifferenceFull in

[libvirt] [PATCH 01/10] xen: move virDomainDefPostParse to xenParseSxpr

This patch partially reverts previous commit 91a00424 and moves the post parse function to xenParseSxpr. This update is required because xen driver calls xenParseSxpr directly. Signed-off-by: Pavel Hrdina --- src/xen/xend_internal.c | 7 +-- src/xenconfig/xen_sxpr.c |

[libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

This will enable regenerate functionality for those tests to make developer lives easier while updating tests. Signed-off-by: Pavel Hrdina --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +-

[libvirt] [PATCH 02/10] tests: introduce VIR_TEST_REGENERATE_OUTPUT flag

When this flag is specified, some of the expected output files will be regenerated with the actual output data. This is a helper for updating test data. Signed-off-by: Pavel Hrdina --- tests/testutils.c | 14 +++--- tests/testutils.h | 1 + 2 files changed, 12

Re: [libvirt] [PATCH 1/2] xenconfig: support parsing and formatting vif bandwidth

On 29.12.2015 02:09, Jim Fehlig wrote: > Both xm and xl config have long supported specifying vif rate > limiting, e.g. > > vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ] > > Add support for mapping rate to and from in the xenconfig > parser and formatter. rate is mapped to the

Re: [libvirt] [PATCH v2 00/14] Use macros for more common virsh command options

On 01/06/2016 01:58 PM, Laine Stump wrote: > On 12/18/2015 10:45 AM, John Ferlan wrote: >> v1: >> http://www.redhat.com/archives/libvir-list/2015-December/msg00731.html >> >> Changes over v1: >> >> 1. Insert patch 1 to convert already pushed VSH_POOL into VIRSH_POOL >> since that was the

Re: [libvirt] Libvirt 1.3.0 compilation failure on OSX 10.9.5

Justin Clift wrote: > On 6 Jan 2016, at 18:03, Roman Bogorodskiy wrote: > > Roman Bogorodskiy wrote: > >> Justin Clift wrote: > >>> Hiyas, > >>> > >>> Just went to update the MacOS X Homebrew port/formula for > >>> Libvirt 1.3.0. It's failing during compilation with:

[libvirt] [PATCH 10/12] tests: qemuxml2xml: Convert some fprintf to VIR_TEST_DEBUG

--- tests/qemuxml2xmltest.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index e3bd9c2..c0270d4 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -59,7 +59,7 @@ testXML2XMLHelper(const char

[libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

Not all lease values are mandatory, and when they aren't supplied by the libvirt driver they get set to NULL. That makes rb_str_new2() bail out. Signed-off-by: Dan Williams --- For example using the qemu driver we don't get 'iaid', and that makes ruby unhappy:

[libvirt] [PATCH 05/12] qemu: domain: split out post parse default device handling

Should be a no-op --- src/qemu/qemu_domain.c | 53 +++--- 1 file changed, 33 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index bb8d47f..26a29b1 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH 02/12] domain: separate out function for post parse timer validation

This should be a no-op --- src/conf/domain_conf.c | 53 +- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ab22322..2570f94 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH 06/12] qemu: Handle CanonicalizeMachine in post parse

Rather than open coding calls. I can't see any reason not to --- src/qemu/qemu_domain.c | 23 +++ src/qemu/qemu_driver.c | 29 - 2 files changed, 23 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 04/12] domain: Add virDomainDefAddImplicitDevices

It's just a combination of AddImplicitControllers, and AddConsoleCompat. Every caller that wants ImplicitControllers also wants the ConsoleCompat AFAICT, so lump them together. We also need it for future patches. --- src/conf/domain_conf.c | 19 ++- src/conf/domain_conf.h | 2

[libvirt] [PATCH 01/12] domain: separate out function for post parse console compat

This should be a no-op --- src/conf/domain_conf.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9d47846..ab22322 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [PATCH 03/12] domain: add implicit controllers from post parse

Seems like the natural fit, since we are already adding other XML bits in the PostParse routine. Previously AddImplicitControllers was only called at the end of XML parsing, meaning code that builds a DomainDef by hand had to manually call it. Adding it for those sites causes some test suite

[libvirt] [PATCH 00/12] Centralize more more bits in XML PostParse

There are several qemu and generic domain XML validating/populating routines that callers need to invoke manually after parsing XML. This series moves some of these calls into the PostParse handling routines. Functionally there shouldn't be much change, except for more complete XML in a few cases

[libvirt] [PATCH 12/12] qemu: Assign device addresses in PostParse

In order to make this work, we need to short circuit the normal virDomainDefPostParse ordering, and manually add stock devices ourselves, since we need them in the XML before assigning addresses. There's a bit of test suite churn due to extra XML output, and validation happening at different call

[libvirt] [PATCH 08/12] domain: conf: Export virDomainDefPostParseDevices

We will use this in upcoming patches --- src/conf/domain_conf.c | 31 +-- src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 26 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 11/12] tests: qemuxml2xml: Wire up QEMUCaps usage

Future changes will make some of these tests dependent on specific QEMUCaps flags, so wire up the basic handling. --- tests/qemuxml2xmltest.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index c0270d4..32c9fed 100644 ---

[libvirt] [PATCH 09/12] tests: qemuxml2xml: Use standard file comparison helpers

This also makes VIR_TEST_REGENERATE_OUTPUT work --- tests/qemuxml2xmltest.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index f967ceb..e3bd9c2 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@

[libvirt] [PATCH 07/12] qemu: Handle SecurityManagerVerify in post parse

Rather than open coding calls. I can't see any reason not to --- src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_driver.c | 6 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 48a2160..a981310 100644 ---

Re: [libvirt] [PATCH 2/2] libxl: support vif outgoing bandwidth QoS

On 01/07/2016 07:48 AM, Michal Privoznik wrote: > On 29.12.2015 02:09, Jim Fehlig wrote: >> The libxl_device_nic structure supports specifying an outgoing rate >> limit based on a time interval and bytes allowed per interval. In xl >> config a rate limit is specified as "/s@". INTERVAL >> is

Re: [libvirt] [PATCH] pci: Log debug messages when manipulating the inactive list

On Thu, Jan 07, 2016 at 18:21:18 +0100, Andrea Bolognani wrote: > Most of the changes to the list of active and inactive PCI devices > happen in virHostdev, where they are properly logged. > > virPCIDeviceDetach() and virPCIDeviceReattach(), however, change the > inactive list as well, so they

Re: [libvirt] [PATCH 09/12] tests: qemuxml2xml: Use standard file comparison helpers

On Thu, Jan 07, 2016 at 22:50:03 -0500, Cole Robinson wrote: > This also makes VIR_TEST_REGENERATE_OUTPUT work > --- > tests/qemuxml2xmltest.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c > index f967ceb..e3bd9c2

Re: [libvirt] [PATCH 1/2] xenconfig: support parsing and formatting vif bandwidth

On 01/07/2016 07:48 AM, Michal Privoznik wrote: > On 29.12.2015 02:09, Jim Fehlig wrote: >> Both xm and xl config have long supported specifying vif rate >> limiting, e.g. >> >> vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ] >> >> Add support for mapping rate to and from in the

Re: [libvirt] [PATCH 01/12] domain: separate out function for post parse console compat

On Thu, Jan 07, 2016 at 22:49:55 -0500, Cole Robinson wrote: > This should be a no-op > --- > src/conf/domain_conf.c | 38 -- > 1 file changed, 24 insertions(+), 14 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index

Re: [libvirt] [PATCH 02/12] domain: separate out function for post parse timer validation

On Thu, Jan 07, 2016 at 22:49:56 -0500, Cole Robinson wrote: > This should be a no-op > --- > src/conf/domain_conf.c | 53 > +- > 1 file changed, 31 insertions(+), 22 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

[...] >> No problem - although it seems they've generated a regression in the >> virttest memtune test suite. I'm 'technically' on vacation for the >> next couple of weeks; however, I think/perhaps the problem is a >> result of this patch and the change to adding the task to the cgroup >> at

[libvirt] looking again at add nested HVM to libxl

I have been looking at this once again and thinking about this whole implementation. I can agree with Daniel's assesment of the SVM/NPT bit setting but the nested_hvm feature does not exist at all in KVM at the libvirt level/ I could be wrong but when I last looked nested hvm could only be

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On Thu, 7 Jan 2016 11:20:23 -0500 John Ferlan wrote: > > [...] > > >> No problem - although it seems they've generated a regression in > >> the virttest memtune test suite. I'm 'technically' on vacation > >> for the next couple of weeks; however, I think/perhaps the

Re: [libvirt] Libvirt 1.3.0 compilation failure on OSX 10.9.5

On 6 Jan 2016, at 18:03, Roman Bogorodskiy wrote: > Roman Bogorodskiy wrote: >> Justin Clift wrote: >>> Hiyas, >>> >>> Just went to update the MacOS X Homebrew port/formula for >>> Libvirt 1.3.0. It's failing during compilation with: >>> >>>

Re: [libvirt] [PATCH] qemu: fix default migration_address for NBD server

On Thu, Dec 31, 2015 at 16:51:26 +1100, Michael Chapman wrote: > If no migration_address is configured, QEMU will listen on 0.0.0.0 or > [::]. Commit 674afcb09e3d33500cfbbcf870ebf92cb99ecfa3 moved the > handling of this default value into a new qemuMigrationPrepareIncoming > function, however the

Re: [libvirt] [PATCH 2/4] virsh: Add timestamps to events

On Mon, Dec 21, 2015 at 16:25:56 +0100, Andrea Bolognani wrote: > On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: > >  > > @@ -12154,7 +12155,16 @@ virshEventPrint(virshDomEventData *data, > >  if (!data->loop && *data->count) > >  goto cleanup; > >   > > -

Re: [libvirt] [PATCH 1/4] virsh: Refactor event printing

On Mon, Dec 21, 2015 at 14:46:33 +0100, Andrea Bolognani wrote: > n Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: > > To reduce code duplication. > >  > > Signed-off-by: Jiri Denemark > > --- > >  tools/virsh-domain.c | 293 >