[libvirt] [PATCH] virsh: Update description of lxc-enter-namespace

Mention that we run a command in that namespace --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d239ba8..62acecb 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9066,7 +9066,7 @@

[libvirt] [PATCH] virsh: Fix alignment in VIRSH_COMMON_OPT_CONFIG definition

--- Pushed as trivial and safe for freeze. tools/virsh.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.h b/tools/virsh.h index 94d012a..8b5e5ba 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -78,8 +78,8 @@ # define VIRSH_COMMON_OPT_CONFIG(_helpstr)

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

On Mon, 2016-01-11 at 18:03 -0500, John Ferlan wrote: > I've also lift/applied the "helpstr" to each of the # define > VIRSH_COMMON_OPT_*'s in virsh.h (meaning virsh.h is not included in > po/POTFILES.in either).  That also picks up a couple more domain options > from virsh-domain.c which use

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: >  > Just a question, I know it's to late to change those patches, it's pushed now, > but why don't we unify the help string for all the commands?  It does the same > thing for all commands, there is no reason to have different help string for

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

On Mon, Jan 11, 2016 at 04:39:25PM +0100, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > > Rather than continually cut-n-paste the strings into each command, > > create common macros to be used generically.  For virsh-volume, there > > are 3 different types of

Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support

Hi, Daniel and Jiri, Do you have more comments about this new version? I guess that it should fix those comments on previous version. ^-^ Thanks, Qiaowei > -Original Message- > From: Ren, Qiaowei > Sent: Thursday, December 10, 2015 8:35 PM > To: libvir-list@redhat.com > Cc: Daniel P.

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Mon, Jan 11, 2016 at 05:26:55PM +0100, Andrea Bolognani wrote: > On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: > > > > > The config option for the 'schedinfo' and 'change-media' > > > commands, while it has a slightly different help text, also > > > serves AFAICT the same purpose and as

Re: [libvirt] Fwd: DNS for IPv6 addresses?

Hi Yaniv Please refer to the following . [root@localhost images]# virsh net-dumpxml dhcp dhcp 066f0d89-67a6-42c8-bdeb-ed9420aaaf4f [root@localhost images]# virsh dumpxml rhel7.1|grep /interface -B7

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

On Tue, 2016-01-12 at 09:28 +0100, Ján Tomko wrote: >  > > > +#define VIRSH_COMMON_OPT_VOLUME_POOL_CREATE\ > > > +{.name = "pool",   \ > > > + .type = VSH_OT_DATA,  \ > > > + .flags = VSH_OFLAG_REQ, 

[libvirt] Software Offloading Performance Issue on increasing VM's (TSO enabled ) pushing traffic

Hi, Problem- Offloading (in Software) for VM generated packets ( TSO enabled in VM's ) degrades severely with increase in VM's on a host. On increasing VM's ( which are pushing traffic simultaneously ) on a compute node- - % offloaded packets coming out of VM's ( TSO enabled ) on tap port /

Re: [libvirt] [PATCH v2 4/4] tests: update test XML files to follow input changes

Ok, so consider this squashed in, I've forgot to regenerate the tests after rebase to current HEAD and there seems to be new tests. --- diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2-multi.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2-multi.xml index 5f62468..eee1a0b

Re: [libvirt] [PATCH V2 1/3] xenconfig: support vif bandwidth in sexpr parser and formatter

On 01/04/2016 08:08 PM, Jim Fehlig wrote: > The xen sexpr config format has long supported specifying vif rate > limiting, e.g. > > (device > (vif > (mac '00:16:3e:1b:b1:47') > (rate '10240KB/s') > ... > ) > ) > > Add support for mapping rate to and from in the

Re: [libvirt] Entering freeze for libvirt-1.3.1

On 12 Jan 2016, at 03:05, Roman Bogorodskiy wrote: > Oops, it's my fault, I forgot to add the proper include for log > protocol. > > Could you please try the attached patch? > > If you report it works I'll push it tomorrow as trivial if nobody has > objections, it'd be

Re: [libvirt] [PATCH 1/6] tests: Add newlines with VIR_TEST_REGENERATE_OUTPUT

On 01/08/2016 09:21 PM, Cole Robinson wrote: > On 01/08/2016 08:59 PM, Laine Stump wrote: >> On 01/08/2016 07:13 PM, Cole Robinson wrote: >>> Since test files are formatted predictably nowadays, we can make >>> VIR_TEST_REGENERATE_OUTPUT handle most cases for us with a simple >>> replacement.

Re: [libvirt] [PATCH] Xen: use correct domctl version in domaininfolist union

Martin Kletzander wrote: > On Mon, Jan 11, 2016 at 03:26:23PM -0700, Jim Fehlig wrote: >> Commmit fd2e3c4c used the domctl version 8 structure for version 9 >> in the xen_getdomaininfolist union, resulting in insufficient buffer >> size (and subsequent memory corruption) for the GETDOMAININFOLIST

Re: [libvirt] [PATCH] qemu: Use memory-object-file when needed

On Tue, Jan 12, 2016 at 06:48:02PM +0100, Martin Kletzander wrote: We were missing a check for '!nodemask' in the condition that decides whether we need memory-object-file or not. We only used userNodeset, but forgot that we might need to use nodemask even if that's not set. Even though there

[libvirt] [PATCH] qemu: Use memory-object-file when needed

We were missing a check for '!nodemask' in the condition that decides whether we need memory-object-file or not. We only used userNodeset, but forgot that we might need to use nodemask even if that's not set. Even though there was a test for this, the args file was incorrect, so it is very

[libvirt] [PATCH] xenconfig: check return value of regcomp

Commit ec63000a missed checking the return value of regcomp(), which coverity promptly identified. Signed-off-by: Jim Fehlig --- src/xenconfig/xen_sxpr.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/xenconfig/xen_sxpr.c

Re: [libvirt] [PATCH] xenconfig: check return value of regcomp

John Ferlan wrote: > > On 01/12/2016 01:39 PM, Jim Fehlig wrote: >> Commit ec63000a missed checking the return value of regcomp(), >> which coverity promptly identified. >> >> Signed-off-by: Jim Fehlig >> --- >> src/xenconfig/xen_sxpr.c | 12 +++- >> 1 file changed, 11

Re: [libvirt] [PATCH] wireshark: Install into DESTDIR

On 01/12/2016 12:25 PM, Michal Privoznik wrote: > Like everything we install, it should be prefixed with DESTDIR. > > Signed-off-by: Michal Privoznik > --- > m4/virt-wireshark.m4 | 8 > tools/Makefile.am| 1 + > 2 files changed, 5 insertions(+), 4 deletions(-)

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On 01/12/2016 06:40 AM, Pavel Hrdina wrote: > On Tue, Jan 12, 2016 at 10:53:03AM +0100, Andrea Bolognani wrote: >> On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: >>> >>> Just a question, I know it's to late to change those patches, it's pushed >>> now, >>> but why don't we unify the

[libvirt] [PATCH v2 0/4] various test fixes and handling of input devices

Some of the patches from v1 series are already pushed, only those 4 left for review. Pavel Hrdina (4): tests: use virtTestDifferenceFull in tests where we have output file tests: add some missing tests to qemuxml2xmltest device: cleanup input device code tests: update test XML files to

[libvirt] [PATCH v2 3/4] device: cleanup input device code

The current code was a little bit odd. At first we've removed all possible implicit input devices from domain definition to add them later back if there was any graphics device defined while parsing XML description. That's not all, while formating domain definition to XML description we at first

[libvirt] [PATCH v2 1/4] tests: use virtTestDifferenceFull in tests where we have output file

This will enable regenerate functionality for those tests to make developer lives easier while updating tests. Signed-off-by: Pavel Hrdina --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +-

[libvirt] [PATCH v2 2/4] tests: add some missing tests to qemuxml2xmltest

Those tests are in qemuargv2xmltest and it makes sense to include them also in qemuxml2xmltest and qemuxml2argvtest. Signed-off-by: Pavel Hrdina --- This is mainly to ensure that those XML files are regenerated together with qemuxml2xmltest in order to not corrupt

Re: [libvirt] [PATCH 1/4] cgroup: Fix possible bug as a result of code motion for vcpu cgroup setup

On Mon, 11 Jan 2016 13:50:32 -0500 John Ferlan wrote: > Commit id '90b721e43' moved where the virCgroupAddTask was made until > after the check for the vcpupin checks. However, in doing so it missed > an option where if the cpumap didn't exist, then the code would > continue

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Tue, Jan 12, 2016 at 10:53:03AM +0100, Andrea Bolognani wrote: > On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: > >  > > Just a question, I know it's to late to change those patches, it's pushed > > now, > > but why don't we unify the help string for all the commands?  It does the > >

Re: [libvirt] Entering freeze for libvirt-1.3.1

Justin Clift wrote: > On 12 Jan 2016, at 03:05, Roman Bogorodskiy wrote: > > > Oops, it's my fault, I forgot to add the proper include for log > > protocol. > > > > Could you please try the attached patch? > > > > If you report it works I'll push it tomorrow as

Re: [libvirt] [PATCH] Add missing virxdrdefs.h include to log_protocol

On Tue, Jan 12, 2016 at 06:16:17PM +0300, Roman Bogorodskiy wrote: > Commit 2b6f6ad introduced the virxdrdefs.h header with > common definitions to be included in the protocol files, > but logging/log_protocol.x was missed, so add it there as well. > > Hopefully this fixes build on OS X. > --- >

[libvirt] [PATCH] Add missing virxdrdefs.h include to log_protocol

Commit 2b6f6ad introduced the virxdrdefs.h header with common definitions to be included in the protocol files, but logging/log_protocol.x was missed, so add it there as well. Hopefully this fixes build on OS X. --- src/logging/log_protocol.x | 1 + 1 file changed, 1 insertion(+) diff --git

[libvirt] [PATCH] Expand $(wildcard) correctly

So after da176bf6b756 and friend we have switched to $(wildcard some/path/*.xml) instead of enumerating the files explicitly. This is nice, however it makes distcheck build from VPATH fail. The reason is that it's is not obvious to what does the wildcard refer to: srcdir or builddir?

Re: [libvirt] [PATCHv3 0/3] 'autodeflate' attribute for mememory balloon

On 01/08/2016 05:45 AM, Dmitry Andreev wrote: > This patch-set adds support for the new feature 'deflate-on-oom' > that has been added to the QEMU virtio memory balloon a month ago. > This feature lets a guest OS deflate balloon on OOM. > > With 'deflate-on-oom' enabled virtio balloon will

Re: [libvirt] [PATCH] Add missing virxdrdefs.h include to log_protocol

On 12 Jan 2016, at 15:45, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: >> On Tue, Jan 12, 2016 at 06:16:17PM +0300, Roman Bogorodskiy wrote: >>> Commit 2b6f6ad introduced the virxdrdefs.h header with >>> common definitions to be included in the protocol files, >>>

Re: [libvirt] [PATCH] Expand $(wildcard) correctly

On Tue, Jan 12, 2016 at 04:31:38PM +0100, Michal Privoznik wrote: So after da176bf6b756 and friend we have switched to $(wildcard some/path/*.xml) instead of enumerating the files explicitly. This is nice, however it makes distcheck build from VPATH fail. The reason is that it's is not obvious

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

Le 11/01/2016 17:32, John Ferlan a écrit : On 01/11/2016 12:50 PM, Joe Harvell wrote: John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of

Re: [libvirt] [PATCH] Add missing virxdrdefs.h include to log_protocol

Daniel P. Berrange wrote: > On Tue, Jan 12, 2016 at 06:16:17PM +0300, Roman Bogorodskiy wrote: > > Commit 2b6f6ad introduced the virxdrdefs.h header with > > common definitions to be included in the protocol files, > > but logging/log_protocol.x was missed, so add it there as well. > > > >

Re: [libvirt] [PATCH 1/6] tests: Add newlines with VIR_TEST_REGENERATE_OUTPUT

On 01/12/2016 08:29 AM, John Ferlan wrote: > > > On 01/08/2016 09:21 PM, Cole Robinson wrote: >> On 01/08/2016 08:59 PM, Laine Stump wrote: >>> On 01/08/2016 07:13 PM, Cole Robinson wrote: Since test files are formatted predictably nowadays, we can make VIR_TEST_REGENERATE_OUTPUT

[libvirt] [PATCH] testutils: Fix coverity warning with REGENERATE_OUTPUT

- Don't double check for expectName - actual is always non-NULL by this point, so don't check it either --- tests/testutils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 4ffea0c..b587f83 100644 --- a/tests/testutils.c +++

Re: [libvirt] [PATCH] testutils: Fix coverity warning with REGENERATE_OUTPUT

On Tue, Jan 12, 2016 at 11:04:45AM -0500, Cole Robinson wrote: - Don't double check for expectName - actual is always non-NULL by this point, so don't check it either --- tests/testutils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ACK and safe for freeze. signature.asc

Re: [libvirt] ARM KVM GICv3 Support

On Sat, 2016-01-09 at 16:01 +0100, Christoffer Dall wrote: > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > > That's correct, having a QMP command that lists the values gic-version > > > can have on

Re: [libvirt] [PATCH 2/3] rpc: socket: Explicitly error if we exceed retry count

On 01/12/2016 01:31 AM, Martin Kletzander wrote: > On Mon, Jan 11, 2016 at 08:22:33PM -0500, Cole Robinson wrote: >> When we autolaunch libvirtd for session URIs, we spin in a retry >> loop waiting for the daemon to start and the connect(2) to succeed. >> >> However if we exceed the retry count,

[libvirt] [PATCH] build: fix distdir with wireshark disabled

Even though the Makefile has WITH_WIRESHARK guards, the _SOURCES variables are still processed when adding bits to the dist archive. plugin.c is a generated file that is only built when wireshark is enabled and it shouldn't be distributed, so use 'nodist' --- tools/Makefile.am | 4 ++-- 1 file

Re: [libvirt] [PATCH] wireshark: Install into DESTDIR

On Tue, Jan 12, 2016 at 06:25:28PM +0100, Michal Privoznik wrote: Like everything we install, it should be prefixed with DESTDIR. ACK, distcheck finally works for me with this. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] xenconfig: check return value of regcomp

On 01/12/2016 01:39 PM, Jim Fehlig wrote: > Commit ec63000a missed checking the return value of regcomp(), > which coverity promptly identified. > > Signed-off-by: Jim Fehlig > --- > src/xenconfig/xen_sxpr.c | 12 +++- > 1 file changed, 11 insertions(+), 1

Re: [libvirt] [PATCH 12/12] qemu: Assign device addresses in PostParse

On 01/08/2016 06:35 AM, Peter Krempa wrote: > On Thu, Jan 07, 2016 at 22:50:06 -0500, Cole Robinson wrote: >> In order to make this work, we need to short circuit the normal >> virDomainDefPostParse ordering, and manually add stock devices >> ourselves, since we need them in the XML before

[libvirt] [PATCH 7/7] Implement handling of per-domain bandwidth settings

Signed-off-by: Alexander Burluka --- src/qemu/qemu_driver.c | 120 - 1 file changed, 118 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 48aeab6..6a0fa9b 100644 ---

[libvirt] [PATCH 2/7] Add global quota parameter necessary definitions

This parameter controls the maximum bandwidth to be used within a period for whole domain. Signed-off-by: Alexander Burluka --- docs/schemas/domaincommon.rng| 5 + include/libvirt/libvirt-domain.h | 16 src/conf/domain_conf.c | 19

[libvirt] [PATCH 6/7] Implement qemuSetupGlobalCpuCgroup

This functions setups per-domain cpu bandwidth parameters Signed-off-by: Alexander Burluka --- src/qemu/qemu_cgroup.c | 64 + src/qemu/qemu_cgroup.h | 1 + src/qemu/qemu_process.c | 4 3 files changed, 69

[libvirt] [PATCH 0/7] Per domain bandwidth settings

We decide to make a global per domain bandwidth setting as were discussed in mailing list earlier. This patchset implements hierarchy top level cpu.cfs_period_us and cpu.cfs_quota_us control knob. I've named this parameters as global_period and global_quota. Alexander Burluka (7): Add global

[libvirt] [PATCH 4/7] Add new cgroup thread type

Signed-off-by: Alexander Burluka --- src/util/vircgroup.c | 4 src/util/vircgroup.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 78f519c..b829794 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c

[libvirt] [PATCH 3/7] Add error checking on global quota and period

Signed-off-by: Alexander Burluka --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 5d3ab3a..087e9ad 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c

[libvirt] [PATCH 5/7] Rename qemuSetupCgroupVcpuBW to qemuSetupBandwidthCgroup

This rename is required to reuse this function in per-domain bandwidth setup routine Signed-off-by: Alexander Burluka --- src/qemu/qemu_cgroup.c | 14 +++--- src/qemu/qemu_cgroup.h | 6 +++--- src/qemu/qemu_driver.c | 5 ++--- 3 files changed, 12 insertions(+),

[libvirt] [PATCH 1/7] Add global period definitions

This parameter represents top level period cgroup that limits whole domain enforcement period for a quota Signed-off-by: Alexander Burluka --- docs/schemas/domaincommon.rng| 5 + include/libvirt/libvirt-domain.h | 16 src/conf/domain_conf.c

Re: [libvirt] [PATCH] testutils: Fix coverity warning with REGENERATE_OUTPUT

On 01/12/2016 11:04 AM, Cole Robinson wrote: > - Don't double check for expectName > - actual is always non-NULL by this point, so don't check it either > --- > tests/testutils.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tests/testutils.c b/tests/testutils.c

Re: [libvirt] [PATCH] testutils: Fix coverity warning with REGENERATE_OUTPUT

On 01/12/2016 11:22 AM, John Ferlan wrote: > > > On 01/12/2016 11:04 AM, Cole Robinson wrote: >> - Don't double check for expectName >> - actual is always non-NULL by this point, so don't check it either >> --- >> tests/testutils.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH] Expand $(wildcard) correctly

On 01/12/2016 10:31 AM, Michal Privoznik wrote: > So after da176bf6b756 and friend we have switched to $(wildcard > some/path/*.xml) instead of enumerating the files explicitly. > This is nice, however it makes distcheck build from VPATH fail. > The reason is that it's is not obvious to what does

Re: [libvirt] [PATCH 3/3] build: Kill tools/wireshark Makefiles

On 11.01.2016 00:06, Cole Robinson wrote: > Just handle it all in tools/Makefile.am. I verified the generated output > looks similar to the pre patch output, but I didn't test it. > --- > Makefile.am | 2 +- > configure.ac| 4 +--- > tools/Makefile.am

Re: [libvirt] [PATCH 3/3] build: Kill tools/wireshark Makefiles

On 01/12/2016 11:06 AM, Michal Privoznik wrote: > On 11.01.2016 00:06, Cole Robinson wrote: >> Just handle it all in tools/Makefile.am. I verified the generated output >> looks similar to the pre patch output, but I didn't test it. >> --- >> Makefile.am | 2 +- >>

Re: [libvirt] [PATCH] Expand $(wildcard) correctly

On 12.01.2016 17:34, Cole Robinson wrote: > On 01/12/2016 10:31 AM, Michal Privoznik wrote: >> So after da176bf6b756 and friend we have switched to $(wildcard >> some/path/*.xml) instead of enumerating the files explicitly. >> This is nice, however it makes distcheck build from VPATH fail. >> The

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

On 01/12/2016 11:42 AM, Alexander Burluka wrote: We decide to make a global per domain bandwidth setting as were discussed in mailing list earlier. This patchset implements hierarchy top level cpu.cfs_period_us and cpu.cfs_quota_us control knob. I've named this parameters as global_period and

[libvirt] [PATCH] wireshark: Install into DESTDIR

Like everything we install, it should be prefixed with DESTDIR. Signed-off-by: Michal Privoznik --- m4/virt-wireshark.m4 | 8 tools/Makefile.am| 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/m4/virt-wireshark.m4 b/m4/virt-wireshark.m4

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

On 12.01.2016 17:42, Alexander Burluka wrote: > We decide to make a global per domain bandwidth setting > as were discussed in mailing list earlier. > This patchset implements hierarchy top level cpu.cfs_period_us > and cpu.cfs_quota_us control knob. I've named this parameters > as global_period

[libvirt] [PATCH] wireshark: Install into DESTDIR

Like everything we install, it should be prefixed with DESTDIR. Signed-off-by: Michal Privoznik --- m4/virt-wireshark.m4 | 8 tools/Makefile.am| 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/m4/virt-wireshark.m4 b/m4/virt-wireshark.m4