Re: [libvirt] [PATCH] virsh: Update description of lxc-enter-namespace

On Wed, 2016-01-13 at 08:47 +0100, Guido Günther wrote: > Mention that we run a command in that namespace > --- > tools/virsh-domain.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index d239ba8..62acecb 100644 > ---

[libvirt] [PATCH] migration: add option to set target ndb server port

Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But tunelled mode does not support non-shared disks. The other way to make migration secure is to

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

You are absolutely right, this patchset allows to set domain top-level cpu.cfs_period_us and cpu.cfs_quota_us cgroups. Can you please explain problem case a little bit more detailed? This code does not affect top-level cpuset cgroup, only quota and period, so there is no visible troubles for me.

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

On 13.01.2016 11:17, Alexander Burluka wrote: > You are absolutely right, this patchset allows to set domain top-level > cpu.cfs_period_us and cpu.cfs_quota_us cgroups. Can you please > explain problem case a little bit more detailed? This code does not > affect top-level cpuset cgroup, only quota

Re: [libvirt] [PATCH] qemu: Use memory-object-file when needed

On Wed, Jan 13, 2016 at 02:14:58PM +0530, Shivaprasad bhat wrote: Hi Martin, I see, the memory from the node specified in numatune is used correctly. Wit your change memory-backend-file is used to enforce that But, I see the migrations from old versions(my case, 1.2.5) seems to fail as there

[libvirt] Quantifying libvirt errors in launching the libguestfs appliance

As people may know, we frequently encounter errors caused by libvirt when running the libguestfs appliance. I wanted to find out exactly how frequently these happen and classify the errors, so I ran the 'virt-df' tool overnight 1700 times. This tool runs several parallel qemu:///session libvirt

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

Oh, I got it, your example is really problem case, but it's a cpuset specific. cfs_period_us and cfs_quota_us are a little different, they limit only bandwidth and won't cause anything similar. For example: A->B A cpu.cfs_period_us is set to 10 If you will try to write 20 to B

Re: [libvirt] [PATCH] qemu: Use memory-object-file when needed

Hi Martin, I see, the memory from the node specified in numatune is used correctly. Wit your change memory-backend-file is used to enforce that But, I see the migrations from old versions(my case, 1.2.5) seems to fail as there was no backend-file before and only backend-ram. Unknown ramblock

Re: [libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

Hi Laine Stump, Any other comments about this patch ? If not, could you help me to review and merge ? Thanks in advance ~~ On 2016年01月12日 03:32, Laine Stump wrote: On 01/11/2016 05:44 AM, Martin Kletzander wrote: On Mon, Jan 11, 2016 at 02:59:00PM +0800, Leno Hou wrote: 1. When switching

Re: [libvirt] [PATCH 0/7] Per domain bandwidth settings

On 01/12/2016 08:19 PM, Laine Stump wrote: On 01/12/2016 11:42 AM, Alexander Burluka wrote: We decide to make a global per domain bandwidth setting as were discussed in mailing list earlier. This patchset implements hierarchy top level cpu.cfs_period_us and cpu.cfs_quota_us control knob. I've

[libvirt] [PATCH] qemuProcessCleanupChardevDevice: Don't unlink NULL paths

So, you try to start a domain, but before we even get to the part where chardev part of qemu command line is generated (and possibly missing path to unix sockets is made up) an error occurs which results in calling qemuProcessStop. This will then try to clean up the mess and possibly ends up

[libvirt] [REPOST 4/4] qemu: Put the emulator cgroup pid into the right task file

Recently reverted commit id 'a41c00b4' was designed to move the setting of the task file into the right place in the cgroup hierarchy. This patch applies the portion of the reverted patch which writes the pid to the right task file. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH] qemuProcessCleanupChardevDevice: Don't unlink NULL paths

On Wed, Jan 13, 2016 at 11:30:48AM +0100, Michal Privoznik wrote: So, you try to start a domain, but before we even get to the part where chardev part of qemu command line is generated (and possibly missing path to unix sockets is made up) an error occurs which results in calling

[libvirt] [REPOST 2/4] qemu: Add check for NULL cgroup return from virCgroupNewMachine

Commit id '71ce4759' altered the cgroup processing with respect to the call to virCgroupAddTask being moved out from lower layers into the calling layers especially for qemu processing of emulator and vcpu threads. What was missed in the processing was that it is possible for a code path to

[libvirt] [REPOST 1/4] cgroup: Fix possible bug as a result of code motion for vcpu cgroup setup

Commit id '90b721e43' moved where the virCgroupAddTask was made until after the check for the vcpupin checks. However, in doing so it missed an option where if the cpumap didn't exist, then the code would continue back to the top of the current vcpu loop. The results was that the virCgroupAddTask

[libvirt] [REPOST 3/4] Revert "qemu: do not put a task into machine cgroup"

This reverts commit a41c00b472efaa192d2deae51ab732e65903238f. The patch was causing erroneous updates to the /proc/$pid/cgroup file. This resulted in some unexpected behavoirs. Signed-off-by: John Ferlan --- src/qemu/qemu_cgroup.c | 15 +++

[libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

Reposting my cgroup fixes series: http://www.redhat.com/archives/libvir-list/2016-January/msg00236.html partially because I originally forgot to CC the author (Henning Schild) of the original series for which these patch fix a couple of issues discovered during regression testing (virt-test

Re: [libvirt] [PATCHv3 0/3] 'autodeflate' attribute for mememory balloon

On Tue, Jan 12, 2016 at 10:44:58AM -0500, John Ferlan wrote: > > > On 01/08/2016 05:45 AM, Dmitry Andreev wrote: > > This patch-set adds support for the new feature 'deflate-on-oom' > > that has been added to the QEMU virtio memory balloon a month ago. > > This feature lets a guest OS deflate

Re: [libvirt] [PATCH] build: fix distdir with wireshark disabled

On 12.01.2016 23:20, Cole Robinson wrote: > Even though the Makefile has WITH_WIRESHARK guards, the _SOURCES > variables are still processed when adding bits to the dist archive. > > plugin.c is a generated file that is only built when wireshark is > enabled and it shouldn't be distributed, so

[libvirt] [PATCH 2/4] rbd: Implement buildVolFrom using RBD cloning

RBD supports cloning by creating a snapshot, protecting it and create a child image based on that snapshot afterwards. The RBD storage driver will try to find a snapshot with zero deltas between the current state of the original volume and the snapshot. If such a snapshot is found a clone/child

[libvirt] [PATCH 1/4] rbd: Add wiping RBD volumes by using rbd_discard() or rbd_write()

This allows user to use the volume wiping functionality of the libvirt storage driver. This patch also adds a new wiping algorithm VIR_STORAGE_VOL_WIPE_ALG_DISCARD By default the VIR_STORAGE_VOL_WIPE_ALG_ZERO algorithm is used and with RBD this will called rbd_write() in chunks of the underlying

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

On 2016-01-13 10:18, Richard W.M. Jones wrote: I would be good if libvirt could routinely test the case of multiple parallel launches of qemu:///session, since it still contains bugs even after Cole's fixes. Sounds like this testing script would be useful as a (weekly?) cronjob or similar.

Re: [libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

On 01/13/2016 03:49 AM, Leno Hou wrote: Hi Laine Stump, Any other comments about this patch ? If not, could you help me to review and merge ? Thanks in advance ~~ I just noticed that you haven't done anything about the other places in libvirt where netlink sockets are being opened. I would

Re: [libvirt] [PATCH] wireshark: Drop DESTDIR from install path

On 01/13/2016 08:25 AM, Michal Privoznik wrote: > In 50078cfbcbf3c8 I've tried to fix distcheck but accidentally > broke rpm build. The problem is that rpm build not only sets > DESTDIR but also passes plugindir path. This results in double > DESTDIR being in the plugin path, Drop one. > >

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

On 01/13/2016 05:18 AM, Richard W.M. Jones wrote: > As people may know, we frequently encounter errors caused by libvirt > when running the libguestfs appliance. > > I wanted to find out exactly how frequently these happen and classify > the errors, so I ran the 'virt-df' tool overnight 1700

Re: [libvirt] [PATCH V2 1/9] qemu_migration: Add support for mutil-thread compressed migration enable

Hi, Feng. We interested in this patchset too. So if you don't have time to finish it we could help. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 7/8] qemu: hotplug: Drop !QEMU_CAPS_DEVICE code

Nowadays we only support qemu 0.12.0+ which provides QEMU_CAPS_DEVICE, so this is all dead code. --- src/qemu/qemu_hotplug.c | 480 +++- 1 file changed, 144 insertions(+), 336 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH 6/8] qemu: process: Drop !QEMU_CAPS_DEVICE code

Nowadays we only support qemu 0.12.0+ which provides QEMU_CAPS_DEVICE, so this is all dead code. --- src/qemu/qemu_process.c | 471 +++- 1 file changed, 27 insertions(+), 444 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c

[libvirt] [PATCH 1/8] tests: Run test-wrap-argv with REGENERATE_OUTPUT

To get properly wrapped output --- tests/testutils.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index b587f83..10c26648 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -433,6 +433,32

[libvirt] [PATCH 8/8] qemu: monitor: drop now unused hmp monitor commands

Basically all wrappers for these hmp commands: - usb_add - pci_add - pci_del - drive_add - info pci --- src/qemu/qemu_monitor.c | 161 src/qemu/qemu_monitor.h | 49 src/qemu/qemu_monitor_json.c | 88 --- src/qemu/qemu_monitor_json.h | 33 ---

[libvirt] [PATCH 0/8] qemu: Start dropping support for !QEMU_CAPS_DEVICE

libvirt only supports qemu 0.12.0+ nowadays, which means that the qemu binary always provides the -device/QEMU_CAPS_DEVICE option. This patch series is a step towards dropping support for that flag. Patch #1 is a test suite improvement, not strictly related Patch #2-5 adjust the test suite for

[libvirt] [PATCH 4/8] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code path that will be removed. instead use it to

[libvirt] [PATCH] conf: Initialize 'deflate' for balloon parse XML

Commit id '7bf3198df' neglected to initialize deflate leading to a possibility if model allocation/checks fail, then the VIR_FREE(deflate) would be erroneous. Noted by Jan Tomko. Signed-off-by: John Ferlan --- I would have pushed as trivial, but it still wasn't 100% clear

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

On 01/13/2016 06:45 PM, Cole Robinson wrote: > On 01/13/2016 05:18 AM, Richard W.M. Jones wrote: >> As people may know, we frequently encounter errors caused by libvirt >> when running the libguestfs appliance. >> >> I wanted to find out exactly how frequently these happen and classify >> the

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

On Wed, Jan 13, 2016 at 04:25:14PM +0100, Martin Kletzander wrote: > For each of the kernels, libvirt labels them (with both DAC and selinux > labels), then proceeds to launching qemu. If this is done parallel, the > race is pretty obvious. Could you remind me why you couldn't use > or or

Re: [libvirt] [REPOST 1/4] cgroup: Fix possible bug as a result of code motion for vcpu cgroup setup

On Wed, Jan 13, 2016 at 07:29:47AM -0500, John Ferlan wrote: Commit id '90b721e43' moved where the virCgroupAddTask was made until after the check for the vcpupin checks. However, in doing so it missed an option where if the cpumap didn't exist, then the code would continue back to the top of

[libvirt] [PATCH] Fix make check with gcc version 5

When building with gcc-5 (particularly gcc-5.3.0 now) and having pdwtags installed (package dwarves) make check fails with the following error: $ make lock_protocol-struct GEN lock_protocol-struct --- lock_protocol-structs 2016-01-13 15:04:59.318809607 +0100 +++

Re: [libvirt] [PATCH] build: fix distdir with wireshark disabled

On 01/13/2016 08:37 AM, Michal Privoznik wrote: > On 12.01.2016 23:20, Cole Robinson wrote: >> Even though the Makefile has WITH_WIRESHARK guards, the _SOURCES >> variables are still processed when adding bits to the dist archive. >> >> plugin.c is a generated file that is only built when

Re: [libvirt] [PATCH] wireshark: Install into DESTDIR

On 12.01.2016 23:08, Cole Robinson wrote: > On 01/12/2016 12:25 PM, Michal Privoznik wrote: >> Like everything we install, it should be prefixed with DESTDIR. >> >> Signed-off-by: Michal Privoznik >> --- >> m4/virt-wireshark.m4 | 8 >> tools/Makefile.am| 1 + >>

Re: [libvirt] Quantifying libvirt errors in launching the libguestfs appliance

On Wed, Jan 13, 2016 at 10:18:42AM +, Richard W.M. Jones wrote: As people may know, we frequently encounter errors caused by libvirt when running the libguestfs appliance. I wanted to find out exactly how frequently these happen and classify the errors, so I ran the 'virt-df' tool overnight

Re: [libvirt] [PATCHv3 0/3] 'autodeflate' attribute for mememory balloon

> This series is not safe - it introduces an invalid free in the XML > parser, giving the user with a read-write connection a possibility to crash > libvirtd before we get to the ACL checks. > Based on the lack of details, I assume you may be referring to: @@ -11327,6 +11327,7 @@

[libvirt] [PATCH] wireshark: Drop DESTDIR from install path

In 50078cfbcbf3c8 I've tried to fix distcheck but accidentally broke rpm build. The problem is that rpm build not only sets DESTDIR but also passes plugindir path. This results in double DESTDIR being in the plugin path, Drop one. Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH] build: fix distdir with wireshark disabled

On 01/12/2016 05:20 PM, Cole Robinson wrote: Even though the Makefile has WITH_WIRESHARK guards, the _SOURCES variables are still processed when adding bits to the dist archive. plugin.c is a generated file that is only built when wireshark is enabled and it shouldn't be distributed, so use

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

On Wed, Jan 13, 2016 at 07:29:46AM -0500, John Ferlan wrote: Reposting my cgroup fixes series: http://www.redhat.com/archives/libvir-list/2016-January/msg00236.html partially because I originally forgot to CC the author (Henning Schild) of the original series for which these patch fix a couple

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

On 01/13/2016 11:51 AM, Martin Kletzander wrote: > On Wed, Jan 13, 2016 at 07:29:46AM -0500, John Ferlan wrote: >> Reposting my cgroup fixes series: >> >> http://www.redhat.com/archives/libvir-list/2016-January/msg00236.html >> >> partially because I originally forgot to CC the author (Henning

Re: [libvirt] [REPOST 2/4] qemu: Add check for NULL cgroup return from virCgroupNewMachine

On Wed, Jan 13, 2016 at 07:29:48AM -0500, John Ferlan wrote: Commit id '71ce4759' altered the cgroup processing with respect to the call to virCgroupAddTask being moved out from lower layers into the calling layers especially for qemu processing of emulator and vcpu threads. What was missed in

[libvirt] [PATCH] virsh: Correctly detect inserted media in change-media command

https://bugzilla.redhat.com/show_bug.cgi?id=1250331 It all works like this. The change-media command dumps domain XML, finds the corresponding cdrom device we want to change media in and returns it in the xmlNodePtr form. This way we don't have to bother with keeping all the subelements or

Re: [libvirt] [PATCH] virsh: Update description of lxc-enter-namespace

On Wed, Jan 13, 2016 at 09:29:14AM +0100, Cedric Bosdonnat wrote: > On Wed, 2016-01-13 at 08:47 +0100, Guido Günther wrote: > > Mention that we run a command in that namespace > > --- > > tools/virsh-domain.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

On Wed, Jan 13, 2016 at 05:51:34PM +0100, Martin Kletzander wrote: > On Wed, Jan 13, 2016 at 07:29:46AM -0500, John Ferlan wrote: > >Reposting my cgroup fixes series: > > > >http://www.redhat.com/archives/libvir-list/2016-January/msg00236.html > > > >partially because I originally forgot to CC the

Re: [libvirt] [REPOST 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)

On Wed, Jan 13, 2016 at 12:15:23PM -0500, John Ferlan wrote: > > > On 01/13/2016 11:51 AM, Martin Kletzander wrote: > > On Wed, Jan 13, 2016 at 07:29:46AM -0500, John Ferlan wrote: > >> Reposting my cgroup fixes series: > >> > >>