[libvirt] [PATCH 2/3] systemd: Add virSystemdGetMachineNameByPID

2016-02-02 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/libvirt_private.syms | 1 + src/util/virsystemd.c| 53 src/util/virsystemd.h| 2 ++ tests/virsystemdtest.c | 44 4 files changed,

[libvirt] [PATCH 1/3] Revert "systemd: Escape only needed characters for machined"

2016-02-02 Thread Martin Kletzander
This reverts commit 0e0149ce91d84f40b98acf4c4bb0da6e29b9c15c. That commit was added to comply with systemd rules that were changed in the meantime, so this patch is pointless. Signed-off-by: Martin Kletzander --- src/util/virsystemd.c | 23 +++

[libvirt] [PATCH 3/3] systemd: Modernize machine naming

2016-02-02 Thread Martin Kletzander
So, systemd-machined has this philosophy that machine names are like hostnames and hence should follow the same rules. But we always allowed international characters in domain names. Thus we need to modify the machine name we are passing to systemd. In order to change some machinenames that we

[libvirt] [PATCH 0/3] Fix domains with non-ASCII (or long) names on systemd

2016-02-02 Thread Martin Kletzander
Well, try starting such domain. More info in patches. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1282846 Martin Kletzander (3): Revert "systemd: Escape only needed characters for machined" systemd: Add virSystemdGetMachineNameByPID systemd: Modernize machine naming

Re: [libvirt] [PATCH 1/2] storage: zfs: enable on Linux

2016-02-02 Thread John Ferlan
On 01/25/2016 08:37 PM, Roman Bogorodskiy wrote: > John Ferlan wrote: > >> >> >> On 01/02/2016 09:25 PM, Roman Bogorodskiy wrote: >>> ZFS-on-Linux implementation of ZFS starting with version 0.6.4 >>> contains all the features we use, so there's no reason to limit >>> libvirt ZFS storage

Re: [libvirt] [PATCH 2/2] virsh: display if ZFS storage backend is enabled

2016-02-02 Thread John Ferlan
On 01/02/2016 09:25 PM, Roman Bogorodskiy wrote: > Make 'virsh -V' list ZFS storage backend if it's enabled. > --- > tools/virsh.c | 3 +++ > 1 file changed, 3 insertions(+) > Based on response in 1/2... ACK John > diff --git a/tools/virsh.c b/tools/virsh.c > index 7484bed..9118145 100644

Re: [libvirt] [PATCH] qemu: Don't crash when create fails early

2016-02-02 Thread Pavel Hrdina
On Tue, Feb 02, 2016 at 10:26:20PM +0100, Martin Kletzander wrote: > Since commit 714080791778e3dfbd484ccb3953bffd820b8ba9 we are generating > socket path later than before -- when starting a domain. That makes one > particular inconsistent state of a chardev, which was not possible > before,

[libvirt] [PATCH] qemu: Don't crash when create fails early

2016-02-02 Thread Martin Kletzander
Since commit 714080791778e3dfbd484ccb3953bffd820b8ba9 we are generating socket path later than before -- when starting a domain. That makes one particular inconsistent state of a chardev, which was not possible before, currently valid. However, SELinux security driver forgot to guard the main

Re: [libvirt] [PATCH v3 1/3] libxl: add p2p migration

2016-02-02 Thread Jim Fehlig
Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration. > Most of the changes occur at the source and no modifications > at the receiver. > > In P2P mode there is only the Perform phase so we must handle > the connection with the destination and actually perform

Re: [libvirt] [PATCH 1/2] Move qemuGetDHCPInterfaces to separate file

2016-02-02 Thread Laine Stump
On 01/31/2016 01:42 PM, Guido Günther wrote: so we can use it from the LXC driver as well. --- I couldn't find a nice place to add this so I went for a separate file. I'm happy to move this elsewhere. A separate file is fine, but it can't be in the util directory, because you're including a

[libvirt] [PATCH] libxl: support feature

2016-02-02 Thread Jim Fehlig
Even though the libxl driver advertises in capabilities, it is ignored when set in domXML. Enable hap in the libxl_domain_create_info struct when is specified in domXML. The xm/xl <-> domXML parser/formatter already supports hap but lacked a test with hap enabled. Add a hap test.

Re: [libvirt] [PATCH v2 21/21] qemu: iothread: Reuse qemuProcessSetupIOThread in iothread hotplug

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:16PM +0100, Peter Krempa wrote: > Since majority of the steps is shared, the function can be reused to > simplify code. > > Similarly to previous path doing this same for vCPUs this also fixes the > a similar bug (which is not tracked). > --- >

Re: [libvirt] [PATCH v2 20/21] qemu: iothread: Aggregate code to set IOTrhead tuning

2016-02-02 Thread Ján Tomko
s/IOTrhead/IOThread/ in the summary On Fri, Jan 29, 2016 at 05:02:15PM +0100, Peter Krempa wrote: > Rather than iterating 3 times for various settings this function > aggregates all the code into single place. One of the other advantages > is that it can then be reused for properly setting

Re: [libvirt] [PATCH v2 00/21] vcpu info storage refactors - part 2

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:01:55PM +0100, Peter Krempa wrote: > Some of patches were pushed. The rest fixes most of the feedback that made > sense that was against v1. > > Peter Krempa (21): > cgroup: Clean up virCgroupGetPercpuStats > conf: Add helper to retrieve bitmap of active vcpus for a

Re: [libvirt] [PATCH v3 4/4] logical: Display thin lv's found in a libvirt managed volume group

2016-02-02 Thread Ján Tomko
On Mon, Feb 01, 2016 at 03:29:53PM -0500, John Ferlan wrote: > Modify the regex for the 'devices' (a/k/a 'extents') from "(\\S+)" > (e.g., 1 or more) to "(\\S*)" (e.g., zero or more). > > Then for any "thin" lv's found, mark the volume as a sparse volume so > that the volume wipe algorithm

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Andrea Bolognani
On Tue, 2016-02-02 at 13:59 +0100, Andrew Jones wrote: > > > > Our introspection support in QOM only allows us to say that a property > > > > is a particular type (int / enum / str / whatever). We don't have any > > > > way to expose info about what subset of possible values for a type are > > > >

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 03:05:28PM +0100, Christoffer Dall wrote: > On Tue, Feb 02, 2016 at 01:59:26PM +0100, Andrew Jones wrote: > > On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > > > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > > > On Fri, Jan 22,

Re: [libvirt] [PATCH v2 4/6] vol: Add thin_pool to _virStorageVolSource

2016-02-02 Thread Pavel Hrdina
On Mon, Feb 01, 2016 at 03:52:12PM -0500, John Ferlan wrote: > > >> > >> ... > >> > >> %s > >> > >> > >> ... > >> > >> > >> Trying to forward think if/when a vol.xml was used as input... > > > > Maybe we should stop right here and handle the thin pool/volumes in a > > separate

Re: [libvirt] Dealing with GCC 6.0

2016-02-02 Thread Richard W.M. Jones
On Mon, Feb 01, 2016 at 03:37:07PM +0100, Martin Kletzander wrote: > So we recently started compiling with gcc 5 and there's a new thing now > and we don't build on gcc 6. I know it's just a development build, but > it finds new things, like: > > fdstream.c: In function 'virFDStreamWrite': >

[libvirt] [PATCH] conf: qemu: Add support for more HyperV Enlightenment features

2016-02-02 Thread Maxim Nestratov
This patch adds support for "vpindex", "runtime", "synic" and "stimer" features available in qemu 2.5+. - When Hyper-V "vpindex" is on, guest can use MSR HV_X64_MSR_VP_INDEX to get virtual processor ID. - Hyper-V "runtime" enlightement feature allows to use MSR HV_X64_MSR_VP_RUNTIME to get the

Re: [libvirt] [PATCH v3 2/3] libxl: move begin phase job handling

2016-02-02 Thread Jim Fehlig
Joao Martins wrote: > > On 02/02/2016 01:23 AM, Jim Fehlig wrote: >> On 01/20/2016 12:00 PM, Joao Martins wrote: >>> . From libxlMigrationBegin to libxlDomainMigrateBegin3Params(). >>> This is a preparatory patch to be able to begin a job in the >>> perform phase. >>> >>> Signed-off-by: Joao

[libvirt] [PATCH 1/5] cfg.mk: Adjust sc_prohibit_int_ijk to support 'exempt from syntax-check'

2016-02-02 Thread Erik Skultety
There might be cases, like with typed params, where triggering this check isn't desirable. But including the whole module in the exception regex is not always to right way of doing things. By adding an option to manually disable this check on a specific occurrence, the module itself will still be

[libvirt] [PATCH 4/5] util: Export remoteFreeTypedParameters internally via util

2016-02-02 Thread Erik Skultety
Since the method is static to remote_driver, it can't even be used by our daemon. Other than that, it would be useful to be able to use it with admin as well. This patch uses the new virTypedParameterRemote datatype introduced in one of previous patches. --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH v2 12/21] conf: Extract code that formats

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:07PM +0100, Peter Krempa wrote: > virDomainDefFormatInternal is growing rather large. Extract the cputune > formatter into a separate function. > --- > src/conf/domain_conf.c | 230 > +++-- > 1 file changed, 125

Re: [libvirt] [PATCH v2 15/21] conf: Extract code for parsing thread resource scheduler info

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:10PM +0100, Peter Krempa wrote: > As the scheduler info elements are represented orthogonally to how it > makes sense to actually store the information, the extracted code will > be later used when converting between XML and internal definitions. > --- > > Notes: >

Re: [libvirt] [PATCH v2 17/21] conf: Fix how iothread scheduler info is stored

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:12PM +0100, Peter Krempa wrote: > Similarly to previous commit change the way how iothread scheduler info > is stored and clean up a lot of unnecessary code. > --- > src/conf/domain_conf.c | 141 > +++-- >

Re: [libvirt] [PATCH v3 2/3] libxl: move begin phase job handling

2016-02-02 Thread Joao Martins
On 02/02/2016 03:39 PM, Jim Fehlig wrote: > Joao Martins wrote: >> >> On 02/02/2016 01:23 AM, Jim Fehlig wrote: >>> On 01/20/2016 12:00 PM, Joao Martins wrote: . From libxlMigrationBegin to libxlDomainMigrateBegin3Params(). This is a preparatory patch to be able to begin a job in the

[libvirt] [PATCH 3/5] util: Export remoteDeserializeTypedParameters internally via util

2016-02-02 Thread Erik Skultety
Currently, the deserializer is hardcoded into remote_driver which makes it impossible for admin to use it. One way to achieve a shared implementation (besides moving the code to another module) would be pass @ret_params_val as a void pointer as opposed to the remote_typed_param pointer and add a

[libvirt] [PATCH 2/5] util: Introduce virTypedParameterRemote datatype

2016-02-02 Thread Erik Skultety
Both admin and remote protocols define their own types (remote_typed_param vs admin_typed_param). Because of the naming convention, admin typed params wouldn't be able to reuse the serialization/deserialization methods, which are tailored for use by remote protocol, even if those method were

[libvirt] [PATCH 5/5] util: Export remoteSerializeTypedParameters internally via util

2016-02-02 Thread Erik Skultety
Same as for deserializer, this method might get handy for admin one day. The major reason for this patch is to stay consistent with idea, i.e. when deserializer can be shared, why not serializer as well. The only problem to be solved was that the daemon side serializer uses a code snippet which

[libvirt] [PATCH 0/5] Export remote typed params methods internally via util

2016-02-02 Thread Erik Skultety
Erik Skultety (5): cfg.mk: Adjust sc_prohibit_int_ijk to support 'exempt from syntax-check' util: Introduce virTypedParameterRemote datatype util: Export remoteDeserializeTypedParameters internally via util util: Export remoteFreeTypedParameters internally via util util: Export

Re: [libvirt] [PATCH v2 11/21] conf: remove unused cpu pinning helpers and data structures

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:06PM +0100, Peter Krempa wrote: > Now that the pinning info is stored elsewhere we can delete all the > obsolete code. > --- > src/conf/domain_conf.c | 136 > --- > src/conf/domain_conf.h | 27 -- >

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Eric Blake
On 02/02/2016 07:05 AM, Christoffer Dall wrote: >> >> I'm not familiar enough with libvirt, nor the use of QMP, to really argue >> one way or another, but I find it a bit strange that we'd prefer libvirt >> to query two entities over one. And, why should the libvirt installed on >> a particular

Re: [libvirt] [PATCH v2 14/21] conf: Add helper to return a bitmap of active iothread ids

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:09PM +0100, Peter Krempa wrote: > --- > src/conf/domain_conf.c | 29 + > src/conf/domain_conf.h | 3 +++ > src/libvirt_private.syms | 1 + > 3 files changed, 33 insertions(+) > ACK Jan signature.asc Description: Digital

Re: [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > > That's correct, having a QMP command that lists the values gic-version > > > can

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 12:59, Andrew Jones wrote: > This actually doesn't matter for the v2 vs. v3 case. The gic-version property > doesn't exist at all for v2-only QEMU. Although maybe the gic-version property > should be reworked. Instead of gic-version=, we could > create >

Re: [libvirt] [PATCH 3/3] common-impl: make virDomainObjGetPersistentDef return only persistent config

2016-02-02 Thread Nikolay Shirokovskiy
On 02.02.2016 15:13, John Ferlan wrote: > > > On 01/15/2016 09:05 AM, Nikolay Shirokovskiy wrote: >> It's rather unexpected that function with such a name could return >> transient definition. This is possible if we call it for >> a transient active domain. But if it is called in such a

Re: [libvirt] [PATCH v3 1/4] logical: Use VIR_APPEND_ELEMENT instead of VIR_REALLOC_N

2016-02-02 Thread Pavel Hrdina
On Mon, Feb 01, 2016 at 03:29:50PM -0500, John Ferlan wrote: > Rather than preallocating a set number of elements, then walking through > the extents and adjusting the specific element in place, use the APPEND > macros to handle that chore. > > Signed-off-by: John Ferlan >

Re: [libvirt] oVirt considers using macTableManager='libvirt'

2016-02-02 Thread Yaniv Kaul
On Nov 2, 2015 7:50 PM, "Vlad Yasevich" wrote: > > On 11/02/2015 01:18 PM, Laine Stump wrote: > > On 11/02/2015 08:22 AM, Vlad Yasevich wrote: > >> On 11/01/2015 01:05 PM, Laine Stump wrote: > >>> On 11/01/2015 08:52 AM, Ido Barkan wrote: > >>> > >>> > >>> > 6) are there any

Re: [libvirt] [PATCH v3 3/4] logical: Clean up allocation when building regex on the fly

2016-02-02 Thread Pavel Hrdina
On Mon, Feb 01, 2016 at 03:29:52PM -0500, John Ferlan wrote: > Rather than a loop reallocating space to build the regex, just allocate > it once up front, then if there's more than 1 nextent, append a comma and > another regex_unit string. > > Signed-off-by: John Ferlan > ---

Re: [libvirt] [PATCH v3 2/4] logical: Use 'stripes' value for mirror/raid segtype

2016-02-02 Thread Pavel Hrdina
On Mon, Feb 01, 2016 at 03:29:51PM -0500, John Ferlan wrote: > The 'stripes' value is described as the "Number of stripes or mirrors in > a logical volume". So add "mirror" and anything that starts with "raid" > to the list of segtypes that can have an 'nextents' value greater than one. > Use of

Re: [libvirt] [PATCH v3 4/4] logical: Display thin lv's found in a libvirt managed volume group

2016-02-02 Thread Pavel Hrdina
On Tue, Feb 02, 2016 at 09:11:51AM +0100, Ján Tomko wrote: > On Mon, Feb 01, 2016 at 03:29:53PM -0500, John Ferlan wrote: > > Modify the regex for the 'devices' (a/k/a 'extents') from "(\\S+)" > > (e.g., 1 or more) to "(\\S*)" (e.g., zero or more). > > > > Then for any "thin" lv's found, mark the

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 15:09, Andrea Bolognani wrote: > Hold on, so "gic-version=3" means "support all GIC versions up to 3", > not "support GIC version 3 only"? I thought the latter. In the current implemented syntax, it means "expose a version 3 GIC to the guest". You can't

Re: [libvirt] [PATCH v3 4/4] logical: Display thin lv's found in a libvirt managed volume group

2016-02-02 Thread John Ferlan
On 02/02/2016 08:30 AM, Pavel Hrdina wrote: > On Tue, Feb 02, 2016 at 09:11:51AM +0100, Ján Tomko wrote: >> On Mon, Feb 01, 2016 at 03:29:53PM -0500, John Ferlan wrote: >>> Modify the regex for the 'devices' (a/k/a 'extents') from "(\\S+)" >>> (e.g., 1 or more) to "(\\S*)" (e.g., zero or more).

[libvirt] [PATCH] virnetdevbandwidth: Compute quantum value

2016-02-02 Thread Michal Privoznik
I've noticed couple of warning in dmesg while debugging something: [ 9683.973754] HTB: quantum of class 10001 is big. Consider r2q change. [ 9683.976460] HTB: quantum of class 10002 is big. Consider r2q change. I've read the HTB documentation and linux kernel code to find out what's wrong.

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Pavel Fedin
Hello! > Shouldn't the default be "host", to mean "whatever the host supports", > rather than a specific version based either on host or QEMU probing? No, because: 1) Older qemu, which does not support this option, uses v2. 2) It also depends on whether KVM or TCG is used. Currently we can

Re: [libvirt] [PATCH v2 10/21] conf: Store cpu pinning data in def->vcpus

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:05PM +0100, Peter Krempa wrote: > Now with the new struct the data can be stored in a much saner place. > --- > > Notes: > v2: > - clear bitmap pointer after free to avoid use after free > > src/conf/domain_conf.c | 136

Re: [libvirt] [PATCH v2 13/21] util: bitmap: Introduce bitmap subtraction

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:08PM +0100, Peter Krempa wrote: > Performs binary subtraction of two bitmaps. Stores result in the first > operand. > --- > src/libvirt_private.syms | 1 + > src/util/virbitmap.c | 21 ++ > src/util/virbitmap.h | 3 +++ >

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Tue, Feb 2, 2016 at 4:52 PM, Eric Blake wrote: > On 02/02/2016 07:05 AM, Christoffer Dall wrote: > >>> >>> I'm not familiar enough with libvirt, nor the use of QMP, to really argue >>> one way or another, but I find it a bit strange that we'd prefer libvirt >>> to query two

Re: [libvirt] [PATCH v2 16/21] conf: Don't store vcpusched orthogonally to other vcpu info

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:11PM +0100, Peter Krempa wrote: > Due to bad design the vcpu sched element is orthogonal to the way how > the data belongs to the corresponding objects. Now that vcpus are a > struct that allow to store other info too, let's convert the data to the > sane structure. >

Re: [libvirt] [PATCH v4] qemu: Connect to guest agent iff needed

2016-02-02 Thread John Ferlan
On 01/18/2016 05:54 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1293351 > > Since we already have virtio channel events, we know when guest > agent within guest has (dis-)connected. Instead of us blindly > connecting to a socket that no one is listening to, we can

Re: [libvirt] [PATCH v4] qemu: Connect to guest agent iff needed

2016-02-02 Thread Michal Privoznik
On 02.02.2016 18:47, John Ferlan wrote: > > > On 01/18/2016 05:54 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1293351 >> >> Since we already have virtio channel events, we know when guest >> agent within guest has (dis-)connected. Instead of us blindly >>

Re: [libvirt] [PATCH v2 18/21] qemu: vcpu: Aggregate code to set vCPU tuning

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:13PM +0100, Peter Krempa wrote: > Rather than iterating 3 times for various settings this function > aggregates all the code into single place. One of the other advantages > is that it can then be reused for properly setting vCPU info on hotplug. It would be also

Re: [libvirt] [PATCH v2 19/21] qemu: vcpu: Reuse qemuProcessSetupVcpu in vcpu hotplug

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:14PM +0100, Peter Krempa wrote: > Since majority of the steps is shared, the function can be reused to > simplify code. > > Additionally this resolves > https://bugzilla.redhat.com/show_bug.cgi?id=1244128 since the cpu > bandwidth limiting with cgroups would not be

Re: [libvirt] [PATCH v3 2/3] libxl: move begin phase job handling

2016-02-02 Thread Joao Martins
On 02/02/2016 01:23 AM, Jim Fehlig wrote: > On 01/20/2016 12:00 PM, Joao Martins wrote: >> . From libxlMigrationBegin to libxlDomainMigrateBegin3Params(). >> This is a preparatory patch to be able to begin a job in the >> perform phase. >> >> Signed-off-by: Joao Martins

Re: [libvirt] [PATCH v3 4/4] logical: Display thin lv's found in a libvirt managed volume group

2016-02-02 Thread John Ferlan
On 02/02/2016 03:11 AM, Ján Tomko wrote: > On Mon, Feb 01, 2016 at 03:29:53PM -0500, John Ferlan wrote: >> Modify the regex for the 'devices' (a/k/a 'extents') from "(\\S+)" >> (e.g., 1 or more) to "(\\S*)" (e.g., zero or more). >> >> Then for any "thin" lv's found, mark the volume as a sparse

Re: [libvirt] [PATCH 3/3] common-impl: make virDomainObjGetPersistentDef return only persistent config

2016-02-02 Thread John Ferlan
On 01/15/2016 09:05 AM, Nikolay Shirokovskiy wrote: > It's rather unexpected that function with such a name could return > transient definition. This is possible if we call it for > a transient active domain. But if it is called in such a conditions? > No. So we would better fix this case to

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > > > On 6 January

Re: [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > > > That's

Re: [libvirt] [PATCH 1/3] domain: reuse update flags checking functions

2016-02-02 Thread Nikolay Shirokovskiy
On 02.02.2016 01:48, John Ferlan wrote: > > > On 01/15/2016 09:05 AM, Nikolay Shirokovskiy wrote: >> Uses virDomainLiveConfigHelperMethod or >> virDomainObjUpdateModificationImpact appropriately. >> >> Signed-off-by: Nikolay Shirokovskiy >> --- >>

Re: [libvirt] [PATCH v2 08/21] conf: Don't copy def->cpumask into cpu pinning info

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:03PM +0100, Peter Krempa wrote: > This step can be omitted, so that drivers can decide what to do when the > user requests to use default vcpu pinning. > --- > > Notes: > v2: use correct variable > > src/conf/domain_conf.c | 32

Re: [libvirt] [PATCH v2 09/21] conf: Split out logic to determine whether cpupin was provided

2016-02-02 Thread Ján Tomko
On Fri, Jan 29, 2016 at 05:02:04PM +0100, Peter Krempa wrote: > Add a helper function to do the checking. The check is used when > determining whether the element should be formatted. False, the only usage is in the XML parser. > --- > > Notes: > v2: > - renamed func > - used

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Tue, Feb 02, 2016 at 01:59:26PM +0100, Andrew Jones wrote: > On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > > > On Wed, Jan

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 01:15:49PM +, Peter Maydell wrote: > On 2 February 2016 at 12:59, Andrew Jones wrote: > > This actually doesn't matter for the v2 vs. v3 case. The gic-version > > property > > doesn't exist at all for v2-only QEMU. Although maybe the gic-version >

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 14:04, Andrew Jones wrote: > I agree we should have a good argument to justify messing with it, but > until we start versioning mach-virt, then I don't think anybody should > depend on mach-virt command lines working everywhere. Every time we add > a new